core.git: Branch 'distro/collabora/co-23.05' - sw/source

2024-01-29 Thread Michael Stahl (via logerrit)
 sw/source/core/unocore/unodraw.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit ebacfb1a63566077eb10cbe53dfac8fac9da898f
Author: Michael Stahl 
AuthorDate: Thu Dec 21 19:59:48 2023 +0100
Commit: Miklos Vajna 
CommitDate: Tue Jan 30 08:58:24 2024 +0100

tdf#158451 sw: fix crash in text formatting of as-char group shape

The problem is that during formatting of a SwTextFrame, SwTextFly
contains a list of all anchored objects that could overlap, and then
creating a portion for the as-char anchored group shape sets the anchor
property and thereby unexpectedly deletes the child anchored object,
while SwTextFly stores a pointer to it:

4  SwFlyLayFrame::~SwFlyLayFrame()
5  SwFrame::DestroyFrame()
6  SwFrameFormat::DelFrames()
7  SwDoc::SetFlyFrameAnchor()
8  lcl_SetFlyFrameAttr()
10 SwXFrame::setPropertyValue()
   (this=0x4042de0, rPropertyName="AnchorType", 
_rValue=uno::Any("com.sun.star.text.TextContentAnchorType": 
com::sun::star::text::TextContentAnchorType::TextContentAnchorType_AT_CHARACTER))
 at sw/source/core/unocore/unoframe.cxx:1941
11 SwTextBoxHelper::changeAnchor()
12 SwTextBoxHelper::synchronizeGroupTextBoxProperty()
13 SwTextBoxHelper::synchronizeGroupTextBoxProperty()
14 SwFlyCntPortion::SetBase()
15 sw::DrawFlyCntPortion::Create()
16 SwTextFormatter::NewFlyCntPortion()

This is because after the import is complete, only the group shape has
its anchor set, while the child shapes all have a default FLY_AT_PAGE
anchor.

There is already code in SwXShape::setPropertyValue() to propagate the
new anchor to children, but it's limited to group shape with more than 1
text frame; very unclear why this limit exists so just remove it.

Change-Id: Ide0f9def36e3b4eff6140206e3dfa4ee2c65e3eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161137
Tested-by: Jenkins
Reviewed-by: Regina Henschel 
Reviewed-by: Michael Stahl 
(cherry picked from commit 59ece793dbfc23dddccc56cfaff60d3558dc2b6b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161213
Reviewed-by: Caolán McNamara 
(cherry picked from commit ce9a5a9abbfa998312c62c61b27992d01df214d2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162730
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/core/unocore/unodraw.cxx 
b/sw/source/core/unocore/unodraw.cxx
index 8f72cc2bee0a..9300765d22cf 100644
--- a/sw/source/core/unocore/unodraw.cxx
+++ b/sw/source/core/unocore/unodraw.cxx
@@ -1408,12 +1408,12 @@ void SwXShape::setPropertyValue(const OUString& 
rPropertyName, const uno::Any& a
 // If this property is an anchor change, and there is a 
group shape with textboxes
 // do anchor sync in time unless the anchor sync in the 
porfly will cause crash during
 // layout calculation (When importing an inline shape in 
docx via dmapper).
-if (pFormat->Which() == RES_DRAWFRMFMT && 
pFormat->GetOtherTextBoxFormats()
-&& pFormat->GetOtherTextBoxFormats()->GetTextBoxCount()
-   > o3tl::make_unsigned(1))
+if (pFormat->Which() == RES_DRAWFRMFMT && 
pFormat->GetOtherTextBoxFormats())
+{
 SwTextBoxHelper::synchronizeGroupTextBoxProperty(
 SwTextBoxHelper::changeAnchor, pFormat,
 SdrObject::getSdrObjectFromXShape(mxShape));
+}
 }
 else
 pFormat->SetFormatAttr(aSet);


[Bug 130857] Qt5 implement theming using native widgets (weld)

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130857

--- Comment #5 from Michael Weghorn  ---
Created attachment 192246
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192246=edit
Screenshot for discussion on https://gerrit.libreoffice.org/c/core/+/161831/6/

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-23.05' - vcl/source

2024-01-29 Thread Pranam Lashkari (via logerrit)
 vcl/source/control/fmtfield.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f3db33ce067a9ab9b5d060880d5ce6645a667a81
Author: Pranam Lashkari 
AuthorDate: Mon Jan 29 20:06:51 2024 +0530
Commit: Pranam Lashkari 
CommitDate: Tue Jan 30 08:16:30 2024 +0100

LOK: fixed unused variable warning

Change-Id: I70d82980979540cc998feb12f7bd262c28e44a20
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162692
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Pranam Lashkari 

diff --git a/vcl/source/control/fmtfield.cxx b/vcl/source/control/fmtfield.cxx
index e4b1f1dbfb46..5419164d7c65 100644
--- a/vcl/source/control/fmtfield.cxx
+++ b/vcl/source/control/fmtfield.cxx
@@ -1361,7 +1361,7 @@ void 
FormattedField::DumpAsPropertyTree(tools::JsonWriter& rJsonWriter)
 SpinField::DumpAsPropertyTree(rJsonWriter);
 Formatter& rFormatter = GetFormatter();
 
-if (weld::TimeFormatter* timeFormatter = 
dynamic_cast())
+if (dynamic_cast())
 {
 // weld::TimeFormatter uses h24 format
 rJsonWriter.put("type", "time");


core.git: Branch 'distro/collabora/co-24.04' - vcl/jsdialog

2024-01-29 Thread Szymon Kłos (via logerrit)
 vcl/jsdialog/enabled.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 4b3f04df684354b39a2791790c2ec2a4828c83ed
Author: Szymon Kłos 
AuthorDate: Sun Jan 28 22:15:49 2024 +0100
Commit: Szymon Kłos 
CommitDate: Tue Jan 30 08:15:34 2024 +0100

jsdialog: enable paste special in calc

to test:
- copy few cells in calc
- ctrl + shift + alt + v

Signed-off-by: Szymon Kłos 
Change-Id: Iac3a98c50355e2390a36195ba92ef25a30d73e75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162673
(cherry picked from commit 3cabc2504bbd2bc357fab97e16c14c05128db670)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162711
Tested-by: Jenkins CollaboraOffice 

diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx
index c8ed0d73efad..d792128f3360 100644
--- a/vcl/jsdialog/enabled.cxx
+++ b/vcl/jsdialog/enabled.cxx
@@ -125,6 +125,7 @@ bool isBuilderEnabled(std::u16string_view rUIFile, bool 
bMobile)
 || rUIFile == u"modules/scalc/ui/optimalrowheightdialog.ui"
 || rUIFile == u"modules/scalc/ui/pagetemplatedialog.ui"
 || rUIFile == u"modules/scalc/ui/paratemplatedialog.ui"
+|| rUIFile == u"modules/scalc/ui/pastespecial.ui"
 || rUIFile == u"modules/scalc/ui/pivotfielddialog.ui"
 || rUIFile == u"modules/scalc/ui/pivottablelayoutdialog.ui"
 || rUIFile == u"modules/scalc/ui/regressiondialog.ui"


[Bug 159199] Improve loading time for simple, large presentation document

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159199

--- Comment #4 from Laurent Balland  ---
(In reply to Stéphane Guillou (stragu) from comment #3)
> @Laurent: wondering if the warning above sounds interesting to you,
> potential template fix for Candy? I also get it on a single copy of the
> template.
I have almost finished with Grey Elegant template. Candy is my next goal.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: 2 commits - include/sfx2 include/vcl sc/uiconfig sd/uiconfig sfx2/source sw/uiconfig vcl/source

2024-01-29 Thread Szymon Kłos (via logerrit)
 include/sfx2/notebookbar/SfxNotebookBar.hxx|2 ++
 include/vcl/WeldedTabbedNotebookbar.hxx|4 
 sc/uiconfig/scalc/ui/notebookbar_online.ui |   16 
 sd/uiconfig/sdraw/ui/notebookbar_online.ui |   16 
 sd/uiconfig/simpress/ui/notebookbar_online.ui  |   16 
 sfx2/source/notebookbar/SfxNotebookBar.cxx |   13 ++---
 sw/uiconfig/swriter/ui/notebookbar_online.ui   |   16 
 vcl/source/control/WeldedTabbedNotebookbar.cxx |1 +
 8 files changed, 81 insertions(+), 3 deletions(-)

New commits:
commit 37e81fcc16127c43b3cd7e89d82a362cfc15d227
Author: Szymon Kłos 
AuthorDate: Mon Jan 29 11:42:17 2024 +0100
Commit: Tomaž Vajngerl 
CommitDate: Tue Jan 30 07:40:36 2024 +0100

lok: notebookbar: fix number format field

- number format filed is inside different container in online
- make it working again by putting into standalone
  sfxlo-NotebookbarToolBox

Change-Id: Iecf85aad598cc5a68b5128e32f27818f2b372d92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162683
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162705
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/sc/uiconfig/scalc/ui/notebookbar_online.ui 
b/sc/uiconfig/scalc/ui/notebookbar_online.ui
index 599bef675503..bea44e0eeb61 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_online.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_online.ui
@@ -58,7 +58,7 @@
   
 
 
-  
+  
 True
 True
 icons
@@ -73,6 +73,12 @@
 True
   
 
+  
+  
+0
+0
+  
+  
 
   
 True
commit 16890dc78a69146d16e672e718148f462d63f587
Author: Szymon Kłos 
AuthorDate: Tue Jan 9 14:47:35 2024 +0100
Commit: Tomaž Vajngerl 
CommitDate: Tue Jan 30 07:40:26 2024 +0100

lok: notebookbar: enable currency dropdown

Add .uno:NumberFormatCurrency item to .ui
Use weld:: way of widgets creation so we can inject
jsdialog code and popup will be correctly registered.

Signed-off-by: Szymon Kłos 
Change-Id: Ib57e1cad617ca5c7198d67e107441ba062580f06
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162623
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162710
Reviewed-by: Tomaž Vajngerl 
Tested-by: Tomaž Vajngerl 

diff --git a/include/sfx2/notebookbar/SfxNotebookBar.hxx 
b/include/sfx2/notebookbar/SfxNotebookBar.hxx
index 7bf34d1cbf7e..cd94ddad7b1e 100644
--- a/include/sfx2/notebookbar/SfxNotebookBar.hxx
+++ b/include/sfx2/notebookbar/SfxNotebookBar.hxx
@@ -33,6 +33,7 @@ class SfxBindings;
 class SfxViewFrame;
 class SfxViewShell;
 class SystemWindow;
+class ToolbarUnoDispatcher;
 class WeldedTabbedNotebookbar;
 
 namespace sfx2
@@ -74,6 +75,7 @@ public:
 private:
 static bool m_bLock;
 static bool m_bHide;
+static std::unique_ptr m_xCalcToolboxDispatcher;
 
 static std::map>
 m_pNotebookBarWeldedWrapper;
diff --git a/include/vcl/WeldedTabbedNotebookbar.hxx 
b/include/vcl/WeldedTabbedNotebookbar.hxx
index 073902f2d166..a1fffdd6dd39 100644
--- a/include/vcl/WeldedTabbedNotebookbar.hxx
+++ b/include/vcl/WeldedTabbedNotebookbar.hxx
@@ -23,12 +23,16 @@ class VCL_DLLPUBLIC WeldedTabbedNotebookbar
 std::unique_ptr m_xBuilder;
 
 std::unique_ptr m_xContainer;
+std::unique_ptr m_xWeldedToolbar;
 
 public:
 WeldedTabbedNotebookbar(const VclPtr& pContainerWindow,
 const OUString& rUIFilePath,
 const css::uno::Reference& 
rFrame,
 sal_uInt64 nWindowId);
+
+weld::Toolbar& getWeldedToolbar() { return *m_xWeldedToolbar; }
+weld::Builder& getBuilder() { return *m_xBuilder; }
 };
 
 #endif // INCLUDED_SFX2_NOTEBOOKBAR_SFXNOTEBOOKBAR_HXX
diff --git a/sc/uiconfig/scalc/ui/notebookbar_online.ui 
b/sc/uiconfig/scalc/ui/notebookbar_online.ui
index adf29a1ab43c..599bef675503 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_online.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_online.ui
@@ -58,7 +58,7 @@
   
 
 
-  
+  
 True
 True
 icons
@@ -73,6 +73,16 @@
 True
   
 
+
+  
+True
+.uno:NumberFormatCurrency
+  
+  
+True
+True
+  
+
   
   
 False
diff --git a/sd/uiconfig/sdraw/ui/notebookbar_online.ui 
b/sd/uiconfig/sdraw/ui/notebookbar_online.ui
index 223eedce4c97..7fe79d180a0f 100644
--- a/sd/uiconfig/sdraw/ui/notebookbar_online.ui
+++ b/sd/uiconfig/sdraw/ui/notebookbar_online.ui
@@ -57,6 +57,22 @@
 1
   
   

core.git: include/static static/README.wasm.md static/source

2024-01-29 Thread Stephan Bergmann (via logerrit)
 include/static/unoembindhelpers/PrimaryBindings.hxx |   37 +++
 static/README.wasm.md   |   19 +---
 static/source/embindmaker/embindmaker.cxx   |   94 +++-
 static/source/unoembindhelpers/PrimaryBindings.cxx  |5 -
 4 files changed, 85 insertions(+), 70 deletions(-)

New commits:
commit 27ceca1996809c0f9390d1e9fb95dc7436ef1acf
Author: Stephan Bergmann 
AuthorDate: Mon Jan 29 15:57:30 2024 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Jan 30 07:40:02 2024 +0100

Rework the Embind mapping of UNO interfaces

...to make use of the automatic finalization clean-up of smart pointers
available with recent versions of Embind (so that explicitly calling 
delete() on
them should largely be optional now).  See the changes to 
static/README.wasm.md
for how code should look like now.  (The Module.uno_Reference.FromAny dummy
argument for the interface constructor converting from an Any is only 
necessary
to distinguish it from the other constructor, as otherwise Embind complains
because:  "Overload resolution is currently only performed using the 
parameter
count, not actual type info!")

Change-Id: Ia8a8c12e38af1093948bf8a20ecd31aa6591e912
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162697
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/include/static/unoembindhelpers/PrimaryBindings.hxx 
b/include/static/unoembindhelpers/PrimaryBindings.hxx
new file mode 100644
index ..0c744502848e
--- /dev/null
+++ b/include/static/unoembindhelpers/PrimaryBindings.hxx
@@ -0,0 +1,37 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#pragma once
+
+#include 
+
+#include 
+
+#include 
+#include 
+
+template  struct 
emscripten::smart_ptr_trait>
+{
+using PointerType = css::uno::Reference;
+using element_type = T;
+static T* get(css::uno::Reference const& ptr) { return ptr.get(); }
+static sharing_policy get_sharing_policy() { return 
sharing_policy::INTRUSIVE; }
+static css::uno::Reference* share(T* v) { return new 
css::uno::Reference(v); }
+static css::uno::Reference* construct_null() { return new 
css::uno::Reference(); }
+};
+
+namespace unoembindhelpers
+{
+enum class uno_Reference
+{
+FromAny
+};
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/static/README.wasm.md b/static/README.wasm.md
index da5d80309bf0..80e9e75607c0 100644
--- a/static/README.wasm.md
+++ b/static/README.wasm.md
@@ -226,12 +226,13 @@ Some usage examples through javascript of the current 
implementation:
 init_unoembind_uno(Module);
 let css = Module.unoembind_uno.com.sun.star;
 xModel = Module.getCurrentModelFromViewSh();
-xTextDocument = new css.text.XTextDocument(xModel, 
Module.UnoReference_Query.UNO_QUERY);
+xTextDocument = new css.text.XTextDocument(xModel.$query());
 xText = xTextDocument.getText();
-xSimpleText = new css.text.XSimpleText(xText, 
Module.UnoReference_Query.UNO_QUERY);
+xSimpleText = new css.text.XSimpleText(xText.$query());
 xTextCursor = xSimpleText.createTextCursor();
-xTextRange = new css.text.XTextRange(xTextCursor, 
Module.UnoReference_Query.UNO_QUERY);
+xTextRange = new css.text.XTextRange(xTextCursor.$query());
 xTextRange.setString(new Module.OUString("string here!"));
+xSimpleText.delete(); xTextCursor.delete(); xTextRange.delete();
 xModel.delete(); xTextDocument.delete(); xText.delete(); xSimpleText.delete(); 
xTextCursor.delete(); xTextRange.delete();
 ```
 
@@ -240,16 +241,14 @@ xModel.delete(); xTextDocument.delete(); xText.delete(); 
xSimpleText.delete(); x
 init_unoembind_uno(Module);
 let css = Module.unoembind_uno.com.sun.star;
 xModel = Module.getCurrentModelFromViewSh();
-xTextDocument = new css.text.XTextDocument(xModel, 
Module.UnoReference_Query.UNO_QUERY);
-xText = xTextDocument.getText();
-xEnumAccess = new css.container.XEnumerationAccess(xText, 
Module.UnoReference_Query.UNO_QUERY);
+init_unoembind_uno(Module);
+xEnumAccess = new css.container.XEnumerationAccess(xText.$query());
 xParaEnumeration = xEnumAccess.createEnumeration();
 
 while (xParaEnumeration.hasMoreElements()) {
-xParagraph = new css.text.XTextRange();
-xParagraph.set(xParaEnumeration.nextElement(), 
Module.UnoReference_Query.UNO_QUERY);
-if (xParagraph.is()) {
-xParaProps = new css.beans.XPropertySet(xParagraph, 
Module.UnoReference_Query.UNO_QUERY);
+xParagraph = new css.text.XTextRange(xParaEnumeration.nextElement(), 
Module.uno_Reference.FromAny);
+if (xParagraph.$is()) {
+xParaProps = new css.beans.XPropertySet(xParagraph.$query());
   

core.git: static/source

2024-01-29 Thread Stephan Bergmann (via logerrit)
 static/source/embindmaker/embindmaker.cxx |   49 +++---
 1 file changed, 25 insertions(+), 24 deletions(-)

New commits:
commit 2df1dcc324c67d2205f0ff86378f07e2eeddc1b2
Author: Stephan Bergmann 
AuthorDate: Mon Jan 29 12:05:13 2024 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Jan 30 07:39:06 2024 +0100

Some renaming of generated identifiers

uno_Type_com$sun$star$... and uno_Reference_com$sun$star$...

Change-Id: Ibc19f423a60c521c376172807b4d5a34cf0179a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162696
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/static/source/embindmaker/embindmaker.cxx 
b/static/source/embindmaker/embindmaker.cxx
index 0eb3bc684db5..b7c9b1a51eb2 100644
--- a/static/source/embindmaker/embindmaker.cxx
+++ b/static/source/embindmaker/embindmaker.cxx
@@ -455,8 +455,8 @@ void writeJsMap(std::ostream& out, Module const& module, 
std::string const& pref
 {
 out << ",
";
 }
-out << prefix << "'" << ifc.copy(ifc.lastIndexOf('.') + 1) << "': 
instance." << jsName(ifc)
-<< "Ref";
+out << prefix << "'" << ifc.copy(ifc.lastIndexOf('.') + 1) << "': 
instance.uno_Reference_"
+<< jsName(ifc);
 comma = true;
 }
 for (auto const & [ id, sub ] : module.modules)
@@ -544,30 +544,31 @@ SAL_IMPLEMENT_MAIN()
 cppOut << "static void __attribute__((noinline)) register" << n
<< "() {
"
   "::emscripten::class_<"
-   << cppName(ifc) << ">(\"" << jsName(ifc) << "\")
";
+   << cppName(ifc) << ">(\"uno_Type_" << jsName(ifc) << "\")
";
 dumpAttributes(cppOut, ifc, ifcEnt);
 dumpMethods(cppOut, mgr, ifc, ifcEnt, false);
-cppOut << ";
"
-  "
::emscripten::class_<::com::sun::star::uno::Reference<"
-   << cppName(ifc)
-   << ">, 
::emscripten::base<::com::sun::star::uno::BaseReference>>(\""
-   << jsName(ifc)
-   << "Ref\")
"
-  ".constructor<>()
"
-  "
.constructor<::com::sun::star::uno::BaseReference, "
-  "::com::sun::star::uno::UnoReference_Query>()
"
-  ".function(\"is\", 
&::com::sun::star::uno::Reference<"
-   << cppName(ifc)
-   << ">::is)
"
-  ".function(\"get\", 
&::com::sun::star::uno::Reference<"
-   << cppName(ifc)
-   << ">::get, ::emscripten::allow_raw_pointers())
"
-  ".function(\"set\", "
-  
"::emscripten::select_overload(&::com::sun::star::uno::"
-  "Reference<"
-   << cppName(ifc) << ">::set))
";
+cppOut
+<< ";
"
+   "::emscripten::class_<::com::sun::star::uno::Reference<"
+<< cppName(ifc)
+<< ">, 
::emscripten::base<::com::sun::star::uno::BaseReference>>(\"uno_Reference_"
+<< jsName(ifc)
+<< "\")
"
+   ".constructor<>()
"
+   ".constructor<::com::sun::star::uno::BaseReference, 
"
+   "::com::sun::star::uno::UnoReference_Query>()
"
+   ".function(\"is\", 
&::com::sun::star::uno::Reference<"
+<< cppName(ifc)
+<< ">::is)
"
+   ".function(\"get\", 
&::com::sun::star::uno::Reference<"
+<< cppName(ifc)
+<< ">::get, ::emscripten::allow_raw_pointers())
"
+   ".function(\"set\", "
+   
"::emscripten::select_overload(&::com::sun::star::uno::"
+   "Reference<"
+<< cppName(ifc) << ">::set))
";
 dumpAttributes(cppOut, ifc, ifcEnt);
 dumpMethods(cppOut, mgr, ifc, ifcEnt, true);
 cppOut << ";
"


core.git: xmlsecurity/source

2024-01-29 Thread Stephan Bergmann (via logerrit)
 xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx |   15 +++
 1 file changed, 11 insertions(+), 4 deletions(-)

New commits:
commit 32ef7cea779ccea9b24ab4776f3069d3a80dd7ed
Author: Stephan Bergmann 
AuthorDate: Mon Jan 29 20:52:20 2024 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Jan 30 07:38:28 2024 +0100

tdf#159307 Fix GetCertificateManager

...which had always cut off an existing path ever since
92b6ffcd9f687cc54a0fc3801ca85c7e4d77512f "Allow selecting a custom 
certificate
manager", for reasons that are unclear to me.

So if an existing setting contains at least one slash (or backslash, on
Windows), try to use it as-is; otherwise, keep searching for it in aPath.  
(And,
in any case, make sure to report back the given value in sExecutable.)

Change-Id: I8b2b6ac7a449d7afd02e029ff46d4c79e6b824e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162703
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx 
b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
index 3cd13c6060cf..f2bb37241b7c 100644
--- a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
+++ b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
@@ -154,16 +154,23 @@ void GetCertificateManager(OUString& sExecutable)
 OUString aCetMgrConfig = 
officecfg::Office::Common::Security::Scripting::CertMgrPath::get();
 if (!aCetMgrConfig.isEmpty())
 {
+if (aCetMgrConfig.indexOf('/') != -1
 #ifdef _WIN32
-sal_Int32 nLastBackslashIndex = aCetMgrConfig.lastIndexOf('\');
-#else
-sal_Int32 nLastBackslashIndex = aCetMgrConfig.lastIndexOf('/');
+|| aCetMgrConfig.indexOf('\') != -1
 #endif
+   )
+{
+sExecutable = aCetMgrConfig;
+return;
+}
 osl::FileBase::RC searchError = osl::File::searchFileURL(
-aCetMgrConfig.copy(0, nLastBackslashIndex + 1), aPath,
+aCetMgrConfig, aPath,
 aFoundGUIServer);
 if (searchError == osl::FileBase::E_None)
+{
+osl::File::getSystemPathFromFileURL(aFoundGUIServer, sExecutable);
 return;
+}
 }
 
 for (const auto& rServer: aGUIServers)


[Bug 159435] Gray shading of cross-reference that wraps lines displays at end of previous line too

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159435

--- Comment #2 from William Friedman  ---
Created attachment 192245
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192245=edit
Screen shot of the problem

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159435] Gray shading of cross-reference that wraps lines displays at end of previous line too

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159435

--- Comment #1 from William Friedman  ---
Created attachment 192244
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192244=edit
Demonstrates the problem

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159435] New: Gray shading of cross-reference that wraps lines displays at end of previous line too

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159435

Bug ID: 159435
   Summary: Gray shading of cross-reference that wraps lines
displays at end of previous line too
   Product: LibreOffice
   Version: 7.6.4.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: will.fried...@gmail.com

Description:
If I insert a cross-reference at the end of a line that causes the line to
wrap, the gray shading is displayed on the previous line as well.

Steps to Reproduce:
1. Open the attached document.
2. Look at the end of the first line of lorem ipsums. The reference to the
header 1.1.1.1 wraps to the next line, but some gray remains at the end of the
previous line.

Actual Results:
Gray field shading appears at end of line above wrap.

Expected Results:
Gray field shading should entirely be on the line to which it wrapped.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: cpp.hint

2024-01-29 Thread Mike Kaganski (via logerrit)
 cpp.hint |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 6159b8d223a395b01c090daa071cc13ca6013dc4
Author: Mike Kaganski 
AuthorDate: Tue Jan 30 10:28:11 2024 +0600
Commit: Mike Kaganski 
CommitDate: Tue Jan 30 07:18:32 2024 +0100

Add SAL_LOPLUGIN_ANNOTATE to cpp.hint

Allows Visual Studio to recognize names with this decoration

Change-Id: I787e20322ef346d49f94e23e7ac889d669c1245c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162709
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/cpp.hint b/cpp.hint
index 63269345ce7c..67e06e24b646 100644
--- a/cpp.hint
+++ b/cpp.hint
@@ -6,6 +6,8 @@
 
 #define SAL_UNUSED_PARAMETER
 
+#define SAL_LOPLUGIN_ANNOTATE(id)
+
 #define DECL_LINK(Member, ArgType, RetType) \
 RetType Member(ArgType)
 


[Bug 152077] Calc freeze when you draw a line inside the chart

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152077

raal  changed:

   What|Removed |Added

URL|https://geometrydashworld.n |
   |et  |
 Status|VERIFIED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 133092] [META] Crash bugs

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133092
Bug 133092 depends on bug 159434, which changed state.

Bug 159434 Summary: Crash on table selection (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=159434

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103182] [META] GTK3-specific bugs

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103182
Bug 103182 depends on bug 159434, which changed state.

Bug 159434 Summary: Crash on table selection (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=159434

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159434] Crash on table selection (gtk3)

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159434

Buovjaga  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED
 CC||ilmari.lauhakangas@libreoff
   ||ice.org

--- Comment #1 from Buovjaga  ---


*** This bug has been marked as a duplicate of bug 159386 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159386] Selecting all in a certain table causes assert in SfxPoolItem::SetWhich with a debug build

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159386

Buovjaga  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #8 from Buovjaga  ---
*** Bug 159434 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 107200] [META] Writer table and cell selection issues

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107200
Bug 107200 depends on bug 159434, which changed state.

Bug 159434 Summary: Crash on table selection (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=159434

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159160] Typing freezes and Command Bar Drop down commands disappear

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159160

--- Comment #10 from Buovjaga  ---
(In reply to Alex Giuliani from comment #7)
> Created attachment 192240 [details]
> Arquive of the Graphic Test Results. Reference Skia

It seems you have clicked the button "Run Graphics Tests". This is not
relevant.

-- 
You are receiving this mail because:
You are the assignee for the bug.

New Defects reported by Coverity Scan for LibreOffice

2024-01-29 Thread scan-admin
Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

1 new defect(s) introduced to LibreOffice found with Coverity Scan.
16 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1591435:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/svx/source/dialog/grfflt.cxx: 271 in handleGraphicFilterDialog(const 
VclPtr &, const Graphic &, const 
std::function &)::[lambda(int) (instance 
1)]::operator ()(int) const()



*** CID 1591435:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/svx/source/dialog/grfflt.cxx: 271 in handleGraphicFilterDialog(const 
VclPtr &, const Graphic &, const 
std::function &)::[lambda(int) (instance 
1)]::operator ()(int) const()
265 pDlg->StartExecuteAsync(
266 [pDlg, aInputGraphic, f] (sal_Int32 nResult)->void
267 {
268 if (nResult == RET_OK)
269 {
270 Graphic aOutputGraphic = pDlg->GetFilteredGraphic( 
aInputGraphic, 1.0, 1.0 );
>>> CID 1591435:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>> "aOutputGraphic" is passed-by-value as parameter to 
>>> "GraphicObject::GraphicObject(Graphic)" when it could be moved instead.
271 f(aOutputGraphic);
272 }
273 pDlg->disposeOnce();
274 }
275 );
276 }



To view the defects in Coverity Scan visit, 
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DI_zk_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJihCoBL4HhM-2FUQzSEmVtE14r0kO217z4CU3ew2QzXzxbjrbykpkJBjHh6Oi87IaDXcXR-2BZoBogqGageZ7DQmlYSwofF3aUJ0lYcYiyT2YGPMBgynh7IEpZd87K9I2KnwdbRS0-2FUyocVmZ9x0Li6CEHrLsCNkJ-2B8FtoxGzMZNJf-2Fv0-3D



[Bug 159407] Comma (,) instead of decimal point (.) in input line

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159407

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||stephane.guillou@libreoffic
   ||e.org
 Resolution|--- |DUPLICATE

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
Seeing your version, I assume you are experiencing bug 154623. Could you please
test a recent release (the 7.6 branch) and confirm that it is resolved? Thank
you!

*** This bug has been marked as a duplicate of bug 154623 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159182] Feature request: Calc - quicker changing of move selection direction

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159182

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
(In reply to Ralpho from comment #6)
> Thank you, Stéphane.  I was not aware of the motion restriction feature. 
> Now, I will make several entries by selecting the row, or I will make 2-3
> entries by using the Tab key.  I think that completes the solution for my
> purposes.
Thank you! Let's close as "not a bug" then.

> For me, the Note to Bug Reporter would be clearer if "the request" could be
> changed to "that request" or "the information or data request".  I thought
> at first glance that "the request" was my original bug report.
Sorry, I'm not sure what you are referring to.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159434] Crash on table selection (gtk3)

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159434

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9197

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159197] Font becomes bold when applying highlighting to a table with track changes ON

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159197

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9434

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Not reproduced in:

Version: 24.2.0.2 (X86_64) / LibreOffice Community
Build ID: b1fd3a6f0759c6f806568e15c957f97194bbec8f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Crash (!) on selecting the table in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 3be785e088cc0aa726509cf6b52b1d3b03817172
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Crash reported in bug 159434.

No crash with gen VCL plugin, but still not reproduced:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 3be785e088cc0aa726509cf6b52b1d3b03817172
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Character highlighting or table cell background? Were you able to reproduce
again?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 107200] [META] Writer table and cell selection issues

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107200

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||159434


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159434
[Bug 159434] Crash on table selection (gtk3)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 133092] [META] Crash bugs

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133092

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||159434


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159434
[Bug 159434] Crash on table selection (gtk3)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103182] [META] GTK3-specific bugs

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103182

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||159434


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159434
[Bug 159434] Crash on table selection (gtk3)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159434] Crash on table selection (gtk3)

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159434

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

  Regression By||Armin Le Grand

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159434] New: Crash on table selection (gtk3)

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159434

Bug ID: 159434
   Summary: Crash on table selection (gtk3)
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: critical
  Priority: high
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stephane.guil...@libreoffice.org
CC: armin.le.gr...@me.com
Blocks: 103182, 107200, 133092

Created attachment 192243
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192243=edit
crash minidump

Steps:
1. Open attachment 191950
2. Select table

Result: crash

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 3be785e088cc0aa726509cf6b52b1d3b03817172
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

No crash with gen VCL.
Unrelated to track changes recording in the document.
Could not reproduce from a new, empty table.

Bibisected with linux-64-24.8 repo to first bad build
[cad5a2eca916806372f476b380bd34e7d3f388b1] which points to:

commit  38072fd7eb7d53237efbe0d8bacc7db1c4f3131c
author  Armin Le Grand (allotropia) Mon Jan 22 19:18:32 2024 +0100
committer   Armin Le Grand  Tue Jan 23 10:30:59 2024 +0100
ITEM: Solve SfxVoidItem(0) situation
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162414

Armin, can you please have a look?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
[Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=107200
[Bug 107200] [META] Writer table and cell selection issues
https://bugs.documentfoundation.org/show_bug.cgi?id=133092
[Bug 133092] [META] Crash bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159430] Shift+Ctrl+N doesn't invoke "manage templates" as advertised

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159430

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159160] Typing freezes and Command Bar Drop down commands disappear

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159160

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156574] Crash when scrolling through a larger document

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156574

--- Comment #3 from QA Administrators  ---
Dear Uli,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 74064] File Name detection with "File save as" should be last Period, not first Period (Linux only)

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=74064

--- Comment #34 from QA Administrators  ---
Dear Joel Madero,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159430] Shift+Ctrl+N doesn't invoke "manage templates" as advertised

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159430

--- Comment #6 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146820] SECTION: Column distribution different after undo compared to situation prior edit & undo

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146820

--- Comment #3 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 124925] Wrong error message: no corrupted files, but no more disk space

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124925

--- Comment #7 from QA Administrators  ---
Dear regivanx,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159184] Test failure 24.2.0.1 final only on s390x: PngFilterTest

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159184

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159188] High resolution problem of Position and size dialogue

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159188

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159191] Copy unprotected cells from a selected range

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159191

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159160] Typing freezes and Command Bar Drop down commands disappear

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159160

--- Comment #9 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 153717] Working directory of recovered file is assumed to be the one of newly opened file

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153717

--- Comment #2 from QA Administrators  ---
Dear mirh,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 86430] References and cross references don't look right in specific doc

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=86430

--- Comment #14 from QA Administrators  ---
Dear 2460acc,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 130266] There was a problem displaying the menu

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130266

--- Comment #4 from QA Administrators  ---
Dear renet.vol.sys,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 105387] Dragging Extension Manager vertically on a Windows touchscreen does not have effect

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105387

--- Comment #6 from QA Administrators  ---
Dear Volga,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159200] Changing screen setup causes the presentation to restart

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159200

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Thanks for the report.

Not reproduced on Ubuntu 20.04 with GNOME 3.36.8 and:

Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

I tested with `StartAlways` as both false and true, and also tested switching
to single display.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 152077] Calc freeze when you draw a line inside the chart

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152077

Lynn Davenport  changed:

   What|Removed |Added

URL||https://geometrydashworld.n
   ||et

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159210] Jumping to Last Page (Ctrl+End) in Document Extremely Slow

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159210

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Unbearably slow to open with:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2cedb1a19ad605df4e148589e9027512e4dd9265
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

So haven't been able to reproduce.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159433] Math unusable in Impress

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159433

V Stuart Foote  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159433] Math unusable in Impress

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159433

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #2 from Regina Henschel  ---
Created attachment 192242
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192242=edit
Examples

See attached document how to change size of the formula object and how to
change the font color.

A Math object is an OLE object. As such it has a 'display' object on the slide
to display its content. If you change the font color of this 'display' object,
it has no effect on the real Math object. You need to change the font color in
the Math object itself.

The same is true for an inserted chart. A chart is an OLE object too. And for
charts as well you cannot change the font color by the style of the 'display'
object.

The best way to change the font size of a Math object is to use the 'size'
command. That method is compatible with MathML markup and has best
interoperability with other applications.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 108516] Enhancement Request: allow for comments when defining named range

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108516

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9432

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159432] Sort and/or filter Named Ranges And Expressions from Manager

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159432

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||109178
   Keywords||needsUXEval
 Ever confirmed|0   |1
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8831,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||8516
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |NEW

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Thanks for the suggestion.

Note that "Sheet > Named ranges and expressions > Manage" already automatically
sorts by scope and name, and it already is possible (at least with the gtk3 VCL
plugin) to type some characters to jump to a range name that matches, but
sorting by any column and filtering with a search box (like has been done with
the Options dialog and the Functions sidebar recently) could be useful.

UX/Design team, if you agree, could this be an easyHack based on previous
similar effort?

See also:
- bug 108516, which requests range comments, which could be displayed in the
table too and help with annotating and finding ranges.
- bug 158831 for making another table sortable.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109178
[Bug 109178] [META] Named Cell Ranges and Formula Expressions bugs and
enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 109178] [META] Named Cell Ranges and Formula Expressions bugs and enhancements

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109178

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||159432


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159432
[Bug 159432] Sort and/or filter Named Ranges And Expressions from Manager
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158831] Show broken link information in Edit Links dialog

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158831

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9432

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159432] Sort and/or filter Named Ranges And Expressions from Manager

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159432

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||109178
   Keywords||needsUXEval
 Ever confirmed|0   |1
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8831,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||8516
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |NEW

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Thanks for the suggestion.

Note that "Sheet > Named ranges and expressions > Manage" already automatically
sorts by scope and name, and it already is possible (at least with the gtk3 VCL
plugin) to type some characters to jump to a range name that matches, but
sorting by any column and filtering with a search box (like has been done with
the Options dialog and the Functions sidebar recently) could be useful.

UX/Design team, if you agree, could this be an easyHack based on previous
similar effort?

See also:
- bug 108516, which requests range comments, which could be displayed in the
table too and help with annotating and finding ranges.
- bug 158831 for making another table sortable.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109178
[Bug 109178] [META] Named Cell Ranges and Formula Expressions bugs and
enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 159160] Typing freezes and Command Bar Drop down commands disappear

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159160

--- Comment #8 from Alex Giuliani <1alexandregiuli...@gmail.com> ---
Created attachment 192241
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192241=edit
Arquive Reference Skia

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159160] Typing freezes and Command Bar Drop down commands disappear

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159160

--- Comment #7 from Alex Giuliani <1alexandregiuli...@gmail.com> ---
Created attachment 192240
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192240=edit
Arquive of the Graphic Test Results. Reference Skia

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 140879] [META] Console noise

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140879

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||159194


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159194
[Bug 159194] Improve loading time for simple, large text document
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159194] Improve loading time for simple, large text document

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159194

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||140879


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=140879
[Bug 140879] [META] Console noise
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159199] Improve loading time for simple, large presentation document

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159199

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||jumbo4...@yahoo.fr,
   ||stephane.guillou@libreoffic
   ||e.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
First open:

real0m11,481s
user0m11,156s
sys 0m0,518s

Second open:

real0m12,111s
user0m11,779s
sys 0m0,542s

(Gabor, what exactly do you do for testing cold vs hot cache?)

With:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2cedb1a19ad605df4e148589e9027512e4dd9265
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

In the console, I get 16 times:

warn:sd.filter:202522:202522:sd/source/filter/xml/sdxmlwrp.cxx:436: Fixing
inconsistent outline numbering placeholder preview

@Laurent: wondering if the warning above sounds interesting to you, potential
template fix for Candy? I also get it on a single copy of the template.

In any case, too long a wait for what the document is.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159194] Improve loading time for simple, large text document

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159194

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stephane.guillou@libreoffic
   ||e.org
 Ever confirmed|0   |1

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
First open, I get:

real0m6,082s
user0m6,092s
sys 0m0,448s

Second time:

real0m5,906s
user0m5,726s
sys 0m0,459s

With:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2cedb1a19ad605df4e148589e9027512e4dd9265
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

In the terminal, a flood of:

warn:xmloff:201930:201930:xmloff/source/text/txtparai.cxx:358: unknown
attribute http://www.w3.org/1999/xlink xlink:type value=simple

If there's potential for improvement, let's do it.

Gabor, any reason for the Windows-only report?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159198] Improve loading time for simple, large spreadsheet document

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159198

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords|filter:xlsx |

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
(sorry, ODS here)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159198] Improve loading time for simple, large spreadsheet document

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159198

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stephane.guillou@libreoffic
   ||e.org
   Keywords||filter:xlsx
 Ever confirmed|0   |1

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
I am able to start editing in about 4 seconds with:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2cedb1a19ad605df4e148589e9027512e4dd9265
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

But if you see potential for improvements, of course let's do it :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158482] Must not produce 3D surfaces which are opaque on one side and transparent on other side (converting a shape with no fill to 3D)

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158482

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #9 from Stéphane Guillou (stragu) 
 ---
Reproduced from new document, using Eyal's steps + Buovjaga's extra step:

1. Create a new presentation
2. Delete the first slide's contents
3. On the drawing toolbar, choose Block Arrows > Circular Arrow
4. Indicate a rectangle for the "u-turn" arrow to appear
4b. Sidebar - Properties and set Fill to None.
5. Right-click the arrow shape
6. Choose Convert > To 3D
7. Rotate the shape along different axes to examine its faces from multiple
directions

I agree that it's an unexpected default to not be able to see the inside faces.

(In reply to Regina Henschel from comment #5)
> I can image to enable "Double-Sided" automatically, if the shape has no
> fill. That would be more user-friendly.
I agree double-sided should be the default when converting to 3D, at least in
the case of no fill or use of transparency of the original object.

(In reply to Heiko Tietze from comment #8)
> > use the "Double-Sided" button on the 'Geometry' tab
> Linux shows the tooltip on these buttons while Windows returns the name.
Looks like you have Extended Tips on? I get "Double-Sided" when they're off.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2cedb1a19ad605df4e148589e9027512e4dd9265
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158482] Must not produce 3D surfaces which are opaque on one side and transparent on other side (converting a shape with no fill to 3D)

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158482

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #9 from Stéphane Guillou (stragu) 
 ---
Reproduced from new document, using Eyal's steps + Buovjaga's extra step:

1. Create a new presentation
2. Delete the first slide's contents
3. On the drawing toolbar, choose Block Arrows > Circular Arrow
4. Indicate a rectangle for the "u-turn" arrow to appear
4b. Sidebar - Properties and set Fill to None.
5. Right-click the arrow shape
6. Choose Convert > To 3D
7. Rotate the shape along different axes to examine its faces from multiple
directions

I agree that it's an unexpected default to not be able to see the inside faces.

(In reply to Regina Henschel from comment #5)
> I can image to enable "Double-Sided" automatically, if the shape has no
> fill. That would be more user-friendly.
I agree double-sided should be the default when converting to 3D, at least in
the case of no fill or use of transparency of the original object.

(In reply to Heiko Tietze from comment #8)
> > use the "Double-Sided" button on the 'Geometry' tab
> Linux shows the tooltip on these buttons while Windows returns the name.
Looks like you have Extended Tips on? I get "Double-Sided" when they're off.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2cedb1a19ad605df4e148589e9027512e4dd9265
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159433] Math unusable in Impress

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159433

--- Comment #1 from Jonathan Snow  ---
After some work I find that the only way to change the size of the formula is
to change the size of the font in the text dialog in the formula. when you
enlarge it to a size useable in Impress, the forumla become illegible. But then
snaps to size once you exit the editor. This is no good. 

THERE IS NO WAY TO CHANGE THE FORMULA COLOR. You can have any color you want as
long as it's black. That doesn't work for Impress. In fact kind of useless. 

Again, you should be able to resize the whole thing by dragging its corners,
and it should have a color property that can be changed from Impress, and
follow the colors of the slide color scheme by default. 

Currently Formula objects are unusable in Impress.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: vcl/source

2024-01-29 Thread Andrea Gelmini (via logerrit)
 vcl/source/window/dialog.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4f09826f731d5ecfc1ed094e2f9e720071b1e58d
Author: Andrea Gelmini 
AuthorDate: Mon Jan 29 17:17:41 2024 +0100
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Tue Jan 30 00:41:48 2024 +0100

Fix typo

Change-Id: I9f090d5b38e039b8c3fbb8e5a66190d686a8dccb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162702
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>

diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx
index f395dd307411..b60a96e06440 100644
--- a/vcl/source/window/dialog.cxx
+++ b/vcl/source/window/dialog.cxx
@@ -1184,7 +1184,7 @@ void Dialog::EndDialog( tools::Long nResult )
 {
 // We have a special case with async-dialogs that re-execute 
themselves.
 // In order to prevent overwriting state we need here, we need to 
extract
-// all the state we need before before calling maEndDialogFn, because
+// all the state we need before calling maEndDialogFn, because
 // maEndDialogFn might itself call StartExecuteAsync and store new 
state.
 std::shared_ptr xOwnerDialogController = 
std::move(mpDialogImpl->maEndCtx.mxOwnerDialogController);
 std::shared_ptr xOwnerSelf = 
std::move(mpDialogImpl->maEndCtx.mxOwnerSelf);


[Bug 159251] After using the navigator w/rtl user interface, text is garbled during selection

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159251

--- Comment #10 from Yotam Benshalom  ---
My graphics card driver is updated (nvidia-driver 545.29.06-0ubuntu4).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 140652] Copying and pasting a text from clipboard pastes it twice in LibreOffice Writer in KDE (Brazilian bank security app interfering)

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140652

--- Comment #11 from Rafael Lima  ---
Just an update... I'm still getting the "double-paste" behavior using the Basic
IDE in LO 7.6.

However, the issue is gone using the Basic IDE in 24.8.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159433] New: Math unusable in Impress

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159433

Bug ID: 159433
   Summary: Math unusable in Impress
   Product: LibreOffice
   Version: 7.5.9.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jes...@lsu.edu

Description:
I try to use a formula in Impress but you can't change its size or color. 

Steps to Reproduce:
1.Open impress document
2.Insert formula object
3. Use formula editor to make formula
4. Exit into impress

Actual Results:
Formula object is the wrong shape, size and color, but it can't be modified. 

Expected Results:
Should be able to scale object by dragging its corners in Impress, ad change
its color by changing its properties. 


Reproducible: Always


User Profile Reset: No

Additional Info:
It should have created an object whose properties I can set in Impress (color
and size).

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sc/qa

2024-01-29 Thread Andrea Gelmini (via logerrit)
 sc/qa/extras/macros-test.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c06355ad4a0ee177984974e9c7578127538f01a8
Author: Andrea Gelmini 
AuthorDate: Mon Jan 29 17:16:03 2024 +0100
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Tue Jan 30 00:23:30 2024 +0100

Fix typo

Change-Id: I8b7a0eb27678d96ed8ee0bdd268621a49ab72db8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162701
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>

diff --git a/sc/qa/extras/macros-test.cxx b/sc/qa/extras/macros-test.cxx
index 92878cf2bea5..61c7fdad12a5 100644
--- a/sc/qa/extras/macros-test.cxx
+++ b/sc/qa/extras/macros-test.cxx
@@ -900,7 +900,7 @@ CPPUNIT_TEST_FIXTURE(ScMacrosTest, testTdf116127)
 CPPUNIT_TEST_FIXTURE(ScMacrosTest, testTdf159412)
 {
 // Run a macro, that itself calls two other functions using invoke,
-// passing a small integer value to agruments of types Long and Double
+// passing a small integer value to arguments of types Long and Double
 createScDoc("tdf159412.fods");
 
 css::uno::Any aRet;


[Bug 159264] FILEOPEN XLSX Pivot table style is not applied

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159264

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||aron.bu...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: cui/uiconfig

2024-01-29 Thread Caolán McNamara (via logerrit)
 cui/uiconfig/ui/baselinksdialog.ui |  165 ++---
 1 file changed, 81 insertions(+), 84 deletions(-)

New commits:
commit 985cce64903f7e01b15e0748194683b8e4531c62
Author: Caolán McNamara 
AuthorDate: Mon Jan 29 11:22:47 2024 +
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Tue Jan 30 00:22:10 2024 +0100

resave with latest glade

Change-Id: Ia2de2ad1ccc16e0212e4c1be2df2f6958c490da6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162686
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>

diff --git a/cui/uiconfig/ui/baselinksdialog.ui 
b/cui/uiconfig/ui/baselinksdialog.ui
index 14e46c20c82a..65c18215ebdb 100644
--- a/cui/uiconfig/ui/baselinksdialog.ui
+++ b/cui/uiconfig/ui/baselinksdialog.ui
@@ -1,5 +1,5 @@
 
-
+
 
   
   
@@ -17,28 +17,28 @@
 
   
   
-False
-6
+False
+6
 Edit Links
 True
-0
-0
-dialog
+0
+0
+dialog
 
   
-False
+False
 vertical
 12
 
   
-False
-end
+False
+end
 
   
 _Help
 True
-True
-True
+True
+True
 True
   
   
@@ -52,9 +52,9 @@
   
 _Modify...
 True
-True
-True
-True
+True
+True
+True
 
   
 Change 
the source file for the selected link.
@@ -71,9 +71,9 @@
   
 _Break Link
 True
-True
-True
-True
+True
+True
+True
 
   
 Breaks the 
link between the source file and the current document. The most recently 
updated contents of the source file are kept in the current document.
@@ -90,9 +90,9 @@
   
 _Update
 True
-True
-True
-True
+True
+True
+True
 
   
 Updates 
the selected link so that the most recently saved version of the linked file is 
displayed in the current document.
@@ -109,10 +109,10 @@
   
 _Close
 True
-True
-True
-True
-True
+True
+True
+True
+True
 True
   
   
@@ -125,21 +125,21 @@
   
 False
 True
-end
+end
 0
   
 
 
   
 True
-False
+False
 True
 vertical
 6
 
   
 True
-False
+False
 True
 True
 vertical
@@ -147,20 +147,20 @@
 
   
 True
-True
+True
 True
 True
-in
+in
 
   
 True
-True
-True
+True
+True
 True
 True
 liststore1
-0
-False
+0
+False
 
   
 
@@ -227,7 +227,7 @@
   
 True
 True
-end
+end
 1
   
 
@@ -239,75 +239,75 @@
   
 
 
-  
+  
   
 True
-False
-6
-12
+False
+6
+12
 
   
 True
-False
+False
 Source file
-True
-TB_LINKS
+True
+TB_LINKS
 0
   
   
-0
-0
+0
+0
   
 
 
   
 True
-  

[Bug 159425] Formula =AND(ISBLANK(range)) with a range does not produce expected result by pressing Enter

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159425

--- Comment #8 from ady  ---
(In reply to Rafael Lima from comment #4)
> The reason for this ticket is that now Excel automatically understands that
> this is an array formula. Maybe LO should do the same.

Not exactly the same as the old "array formula" but rather "dynamic array",
supported in MSO 365 and 2021. Older versions are "pre-dynamic array era" and
do not support them, so the keyboard combination "CSE" is needed in those older
versions, the same as in LO Calc.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Outreachy - Weekly Update

2024-01-29 Thread Omkar Acharekar
Hi everyone,

  Just had to update my progress.

  Last week, I worked on completing the methods for weld_message_dialog
which should create qt dialog from a .ui file. I completed the required
methods including the .ui parser. The approach is pretty similar to how VCL
does. So currently the dialog having qt widgets can be seen but I need to
connect the buttons. Also possibly rework this whole code so as to avoid
duplication ie having common code for both VCl  and Qt implementation where
it can be possible to make.

   Current patch -  https://gerrit.libreoffice.org/c/core/+/161831


Thanks
Omkar


[Bug 103455] Draw: Edit with external tool only reload first image

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103455

Aron Budea  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159425] Formula =AND(ISBLANK(range)) with a range does not produce expected result by pressing Enter

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159425

--- Comment #7 from Bernhard G  ---
(In reply to Rafael Lima from comment #4)
> This actually works in Calc. But for you to apply the formula as an array
> formula you must press Ctrl+Shitf+Enter.

Oh, right - good catch!

> You'll know you did it right because the formula bar will show
> {AND(ISBLANK(C5:M5))} to indicate this is an array formula.

That's right. Though, I may add, the braces around the formula are easily
overseen.

> The reason for this ticket is that now Excel automatically understands that
> this is an array formula.

Interestingly, I am not sure how precisely E365 handles such a formula:
The example XLSX spreadsheet above, opened in LibreOffice 7.6.4.1, does show
the formula with braces, so indeed it seems that E365 did automatically convert
it. However IIRC, opened again in E365, the formula was again presented as a
regular formula without braces. Does this mean that E365 converts it back and
forth, array from/to regular, whenever the user edits the formula cell? (I may
have to get back to E365 to confirm.)

This may make sense, if it causes less confusion to the user to see his formula
exactly as entered. But the user may have an even harder time understanding the
difference between both formula types. Maybe he no longer needs to?  

> Maybe LO should do the same.

I myself do not know enough about array formula. If it is primarily a technical
distinction, and not a feature to the user, then yes, I would welcome LO to
take one more burden off the user's shoulder, and do the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159251] After using the navigator w/rtl user interface, text is garbled during selection

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159251

--- Comment #9 from m_a_riosv  ---
Then try updating your graphics driver, if possible, from the vendor.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159425] Formula =AND(ISBLANK(range)) with a range does not produce expected result by pressing Enter

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159425

Rafael Lima  changed:

   What|Removed |Added

Summary|ISBLANK(range)  |Formula
   ||=AND(ISBLANK(range)) with a
   ||range does not produce
   ||expected result by pressing
   ||Enter

--- Comment #6 from Rafael Lima  ---
Updated the title for better clarity.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159427] Copy value from sum area

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159427

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m_a_riosv  ---
+1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 159427] Copy value from sum area

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159427

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m_a_riosv  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159251] After using the navigator w/rtl user interface, text is garbled during selection

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159251

Yotam Benshalom  changed:

   What|Removed |Added

   Keywords||regression, text:rtl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159425] ISBLANK(range)

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159425

--- Comment #5 from Bernhard G  ---
(In reply to LeroyG from comment #3)
> (In reply to Bernhard G from comment #0)
> >  =AND(ISBLANK(C5:M5))
> >  =OR(ISBLANK(C5:M5))
> > 
> > should return if all (or any) of the cells are blank. On Excel, this works.
> > But in LibreOffice the above formulae always return FALSE.
> 
> But if result is TRUE when at least once cell is blank, how can I know when
> all cells are blank?

The AND and OR variants are not equivalent.
First variant is to check if ALL cells in range are blank.
Second variant is to check if ANY cell in range is blank.

> Try with =COUNTIF($C5:$M5;"")>0

... for the OR variant, and 
  =COUNTIF($C5:$M5;"")=COLUMNS($C5:$M5) for the AND variant.
I agree there are workarounds, I even listed some myself. This is not the
point.

> Not a bug for me.

Looking at Rafael Lima's insight in #c4 above, I am no longer sure this is an
error in strict technical sense. But I still believe it is really badly
designed logic, and horrible UX, to deliver a constant FALSE whenever an array
formula was entered with regular [Enter] key instead of [Shift]-[Ctrl]-[Enter]
(which can easily happen on a busy day). Particularly as the cursor moves away
from the affected cell with both plain [Enter] and [Shift]-[Ctrl]-[Enter], so
the effect is not immediately visible unless the cell is manually focused
again.

Also, this only takes effect after the cell contents was factually changed (at
least e.g. by adding a character and removing it). Just entering a cell by [F2]
and confirming with [Shift]-[Ctrl]-[Enter] will NOT change its status from
regular formula to array formula. So, it affords a clumsy procedure to change a
formula from regular to array.

I might accept this if there was a valuable use of the regular formula. But
does it make any sense for the regular (non-array) formula
  =AND(ISBLANK(range))
to produce a constant FALSE irrespective of the range's contents?  Is there any
context where this would be helpful/useful in any way?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159251] After using the navigator w/rtl user interface, text is garbled during selection

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159251

--- Comment #8 from Yotam Benshalom  ---
Disabling hardware acceleration and font antialiasing in
Menu/Tools/Options/LibreOffice/View has no effect on the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159251] After using the navigator, text is garbled during selection

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159251

--- Comment #6 from m_a_riosv  ---
Please try enabling skia.
Menu/Tools/Options/LibreOffice/View

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159251] After using the navigator w/rtl user interface, text is garbled during selection

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159251

Yotam Benshalom  changed:

   What|Removed |Added

Summary|After using the navigator,  |After using the navigator
   |text is garbled during  |w/rtl user interface, text
   |selection   |is garbled during selection

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159251] After using the navigator, text is garbled during selection

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159251

--- Comment #7 from Yotam Benshalom  ---
I have no option called "skia" in Menu/Tools/Options/LibreOffice/View.
However, I found out that the problem dissappears when I use English interface
instead of Hebrew (rtl) one.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159251] After using the navigator, text is garbled during selection

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159251

--- Comment #5 from Yotam Benshalom  ---
This problem does not go away in safe mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159347] HP printer incompatibility issue

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159347

--- Comment #4 from m_a_riosv  ---
A sample file is needed to intend to find if is there an issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-23.05' - vcl/jsdialog

2024-01-29 Thread Szymon Kłos (via logerrit)
 vcl/jsdialog/enabled.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 035476042f52712911f457841a3757dac90361f7
Author: Szymon Kłos 
AuthorDate: Sun Jan 28 22:15:49 2024 +0100
Commit: Michael Meeks 
CommitDate: Mon Jan 29 22:15:30 2024 +0100

jsdialog: enable paste special in calc

to test:
- copy few cells in calc
- ctrl + shift + alt + v

Signed-off-by: Szymon Kłos 
Change-Id: Iac3a98c50355e2390a36195ba92ef25a30d73e75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162673
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 

diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx
index c8ed0d73efad..d792128f3360 100644
--- a/vcl/jsdialog/enabled.cxx
+++ b/vcl/jsdialog/enabled.cxx
@@ -125,6 +125,7 @@ bool isBuilderEnabled(std::u16string_view rUIFile, bool 
bMobile)
 || rUIFile == u"modules/scalc/ui/optimalrowheightdialog.ui"
 || rUIFile == u"modules/scalc/ui/pagetemplatedialog.ui"
 || rUIFile == u"modules/scalc/ui/paratemplatedialog.ui"
+|| rUIFile == u"modules/scalc/ui/pastespecial.ui"
 || rUIFile == u"modules/scalc/ui/pivotfielddialog.ui"
 || rUIFile == u"modules/scalc/ui/pivottablelayoutdialog.ui"
 || rUIFile == u"modules/scalc/ui/regressiondialog.ui"


core.git: Branch 'distro/collabora/co-23.05' - include/sfx2 sfx2/source

2024-01-29 Thread Tomaž Vajngerl (via logerrit)
 include/sfx2/notebookbar/SfxNotebookBar.hxx |9 --
 sfx2/source/notebookbar/SfxNotebookBar.cxx  |   99 ++--
 2 files changed, 79 insertions(+), 29 deletions(-)

New commits:
commit da8ebd2c348affbd7fa4975910296f32d3c9d1b0
Author: Tomaž Vajngerl 
AuthorDate: Mon Jan 29 16:08:48 2024 +0900
Commit: Szymon Kłos 
CommitDate: Mon Jan 29 22:09:30 2024 +0100

lok: introduce NotebookBarViewManager and NotebookBarViewData

NotebookBarViewManager is a singleton which is responsible to hold
NotebookBar view specific data, which is kept in NotebookBarViewData
class. The idea is to have one NotebookBarViewData class instance
per one view (SfxViewShell instance).

This also refactors the existing code and now moves the
m_pWeldedWrapper, m_pNotebookBar and the m_pToolbarUnoDispatcher
into NotebookBarViewData class.

Change-Id: I32f5954fa9f1628acd9f5f9bd5760ac23ca687ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162680
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/include/sfx2/notebookbar/SfxNotebookBar.hxx 
b/include/sfx2/notebookbar/SfxNotebookBar.hxx
index cd94ddad7b1e..47bd9cc79901 100644
--- a/include/sfx2/notebookbar/SfxNotebookBar.hxx
+++ b/include/sfx2/notebookbar/SfxNotebookBar.hxx
@@ -16,7 +16,6 @@
 #include 
 #include 
 
-#include 
 #include 
 #include 
 
@@ -33,8 +32,7 @@ class SfxBindings;
 class SfxViewFrame;
 class SfxViewShell;
 class SystemWindow;
-class ToolbarUnoDispatcher;
-class WeldedTabbedNotebookbar;
+class ViewInstanceManager;
 
 namespace sfx2
 {
@@ -75,11 +73,6 @@ public:
 private:
 static bool m_bLock;
 static bool m_bHide;
-static std::unique_ptr m_xCalcToolboxDispatcher;
-
-static std::map>
-m_pNotebookBarWeldedWrapper;
-static std::map> 
m_pNotebookBarInstance;
 
 static void ResetActiveToolbarModeToDefault(vcl::EnumContext::Application 
eApp);
 static void RemoveCurrentLOKWrapper();
diff --git a/sfx2/source/notebookbar/SfxNotebookBar.cxx 
b/sfx2/source/notebookbar/SfxNotebookBar.cxx
index e1a8cfb56bca..657f97840843 100644
--- a/sfx2/source/notebookbar/SfxNotebookBar.cxx
+++ b/sfx2/source/notebookbar/SfxNotebookBar.cxx
@@ -28,7 +28,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 
 using namespace sfx2;
@@ -42,9 +42,68 @@ const char MERGE_NOTEBOOKBAR_URL[] = "URL";
 
 bool SfxNotebookBar::m_bLock = false;
 bool SfxNotebookBar::m_bHide = false;
-std::unique_ptr SfxNotebookBar::m_xCalcToolboxDispatcher;
-std::map> 
SfxNotebookBar::m_pNotebookBarWeldedWrapper;
-std::map> 
SfxNotebookBar::m_pNotebookBarInstance;
+
+namespace
+{
+
+/** View specific notebook bar data */
+struct NotebookBarViewData
+{
+std::unique_ptr m_pWeldedWrapper;
+VclPtr m_pNotebookBar;
+std::unique_ptr m_pToolbarUnoDispatcher;
+
+~NotebookBarViewData()
+{
+if (m_pNotebookBar)
+m_pNotebookBar.disposeAndClear();
+}
+};
+
+/** Notebookbar instance manager is a singleton that is used for track the
+ *  per-view instances of view specifc data contained in NotebookBarViewData
+ *  class.
+ **/
+class NotebookBarViewManager final
+{
+private:
+// map contains a view data instance for a view (SfxViewShell pointer)
+std::unordered_map> m_pViewDataList;
+
+// private constructor to prevent any other instantiation outside of get() 
method
+NotebookBarViewManager() = default;
+
+// prevent class copying
+NotebookBarViewManager(const NotebookBarViewManager&) = delete;
+NotebookBarViewManager& operator=(const NotebookBarViewManager&) = delete;
+
+public:
+// Singleton get method - creates an instance on first get() call
+static NotebookBarViewManager& get()
+{
+static NotebookBarViewManager gManager;
+return gManager;
+}
+
+NotebookBarViewData& getViewData(const SfxViewShell* pViewShell)
+{
+auto aFound = m_pViewDataList.find(pViewShell);
+if (aFound != m_pViewDataList.end()) // found
+return *aFound->second;
+
+// Create new view data instance
+NotebookBarViewData* pViewData = new NotebookBarViewData;
+m_pViewDataList.emplace(pViewShell, 
std::unique_ptr(pViewData));
+return *pViewData;
+}
+
+void removeViewData(const SfxViewShell* pViewShell)
+{
+m_pViewDataList.erase(pViewShell);
+}
+};
+
+} // end anonymous namespace
 
 static void NotebookbarAddonValues(
 std::vector& aImageValues,
@@ -200,13 +259,13 @@ static utl::OConfigurationNode 
lcl_getCurrentImplConfigNode(const Reference VclDisposeHdl
-// which clears also m_pNotebookBarWeldedWrapper
-aFound->second.disposeAndClear();
-m_pNotebookBarInstance.erase(aFound);
+// which clears the whole InstanceManager
+rViewData.m_pNotebookBar.disposeAndClear();
 }
 }
 
@@ -374,7 +433,8 @@ bool SfxNotebookBar::StateMethod(SystemWindow* pSysWindow,
 }
 
 

core.git: Branch 'distro/collabora/co-24.04' - sc/uiconfig

2024-01-29 Thread Szymon Kłos (via logerrit)
 sc/uiconfig/scalc/ui/notebookbar_online.ui |8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit 37fee68f4247dabbd68b7a1c7c6a32f0de946793
Author: Szymon Kłos 
AuthorDate: Mon Jan 29 11:42:17 2024 +0100
Commit: Szymon Kłos 
CommitDate: Mon Jan 29 22:06:45 2024 +0100

lok: notebookbar: fix number format field

- number format filed is inside different container in online
- make it working again by putting into standalone
  sfxlo-NotebookbarToolBox

Change-Id: Iecf85aad598cc5a68b5128e32f27818f2b372d92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162683
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/sc/uiconfig/scalc/ui/notebookbar_online.ui 
b/sc/uiconfig/scalc/ui/notebookbar_online.ui
index 599bef675503..bea44e0eeb61 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_online.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_online.ui
@@ -58,7 +58,7 @@
   
 
 
-  
+  
 True
 True
 icons
@@ -73,6 +73,12 @@
 True
   
 
+  
+  
+0
+0
+  
+  
 
   
 True


[Bug 159384] A11y sidebar: simulated numbering warning in TOC if header numbering has dot

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159384

Balázs Varga (allotropia)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |balazs.varga...@gmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159251] After using the navigator, text is garbled during selection

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159251

--- Comment #4 from m_a_riosv  ---
Please test in safe mode, Menu/Help/Restart in Safe Mode

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159427] Copy value from sum area

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159427

Rafael Lima  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||rafael.palma.l...@gmail.com
   Keywords||needsUXEval

--- Comment #1 from Rafael Lima  ---
This seems like a valid enhancement request.

In Excel, clicking the values will copy them to the clipboard.

Let's hear the UX team.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 159427] Copy value from sum area

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159427

Rafael Lima  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||rafael.palma.l...@gmail.com
   Keywords||needsUXEval

--- Comment #1 from Rafael Lima  ---
This seems like a valid enhancement request.

In Excel, clicking the values will copy them to the clipboard.

Let's hear the UX team.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: editeng/source

2024-01-29 Thread Caolán McNamara (via logerrit)
 editeng/source/misc/acorrcfg.cxx |7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

New commits:
commit 313836d19f46d0e046d1c2b8c593727b0b0192ea
Author: Caolán McNamara 
AuthorDate: Fri Jan 26 09:44:38 2024 +
Commit: Caolán McNamara 
CommitDate: Mon Jan 29 21:23:43 2024 +0100

LanguageTag ctor can canonicalize against various known tags

so can optimize skipping the _lt_tag_canonicalize path which ends up
using a fairly expensive xmlXPathEval

Change-Id: Ie96f16482d247f3731c1c8eac6d613736b8b289a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162596
Tested-by: Jenkins
Reviewed-by: Eike Rathke 
Reviewed-by: Caolán McNamara 

diff --git a/editeng/source/misc/acorrcfg.cxx b/editeng/source/misc/acorrcfg.cxx
index 616d75c69600..49e48bb48be1 100644
--- a/editeng/source/misc/acorrcfg.cxx
+++ b/editeng/source/misc/acorrcfg.cxx
@@ -65,13 +65,12 @@ static void scanAutoCorrectDirForLanguageTags( const 
OUString& rURL )
 continue;
 
 const OUString aBcp47( aTitle.copy( 5, 
aTitle.getLength() - 9));
-OUString aCanonicalized;
 // Ignore invalid langtags and canonicalize for good,
 // allow private-use tags.
-if (!LanguageTag::isValidBcp47( aBcp47, 
))
+const LanguageTag aLanguageTag (aBcp47, true);
+if (!aLanguageTag.isValidBcp47())
 continue;
 
-const LanguageTag aLanguageTag( aCanonicalized);
 if (SvtLanguageTable::HasLanguageType( 
aLanguageTag.getLanguageType()))
 continue;
 
@@ -83,7 +82,7 @@ static void scanAutoCorrectDirForLanguageTags( const 
OUString& rURL )
 // other private-use tag (which should not fallback,
 // but avoid).
 if (aLanguageTag.getCountry().isEmpty()
-&& LanguageTag::isValidBcp47( aCanonicalized, 
nullptr,
+&& LanguageTag::isValidBcp47( 
aLanguageTag.getBcp47(), nullptr,
 LanguageTag::PrivateUse::DISALLOW))
 {
 LanguageTag aFallback( aLanguageTag);


[Bug 136004] calc: UI: fill: 'Fill series' with values of type 'date' doesn't apply appropriate cell format

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136004

Andreas Heinisch  changed:

   What|Removed |Added

 CC||andreas.heini...@yahoo.de

--- Comment #5 from Andreas Heinisch  ---
Code pointer:
https://opengrok.libreoffice.org/xref/core/sc/source/core/data/table4.cxx?r=4790ef5c#2508

Unfortunately, I have not idea how to set the format of a cell.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159432] New: Sort and/or filter Named Ranges And Expressions from Manager

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159432

Bug ID: 159432
   Summary: Sort and/or filter Named Ranges And Expressions from
Manager
   Product: LibreOffice
   Version: 7.3.7.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: topicUI
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: thomas.patrick.welb...@outlook.com

Sometimes it is necessary to create many Named Ranges and Expressions, such as
when creating spreadsheets that will be parsed by software that uses the Named
Range data to perform functions. When there are many worksheets in a workbook,
and many ranges within each worksheet, the Named Ranges and Expressions Manager
display is difficult to navigate. The list is only scrollable, and I may
eventually have to scroll through hundreds of entries. 

Because of this, I request an enhancement where Named Ranges and Expressions
Manager display as sortability by name, and preferably should have
filterability by range name as well as by sheet name . 

Example: 
There are several regions in a worksheet that contain similar types of data,
but is intended to have some variation in fields and placement. A software that
relies on the data must be able to identify the regions in the spreadsheet to
parse it. Because of this a naming convention is adopted where the type is
combined with a serial number: 

MOD_0
MOD_1
...
MOD_100

When continuously editing the spreadsheet across different work sessions, it is
not possible for me to remember the last index number, so I have to scroll to
find it. I may also forget the current index number I am on DURING a work
session and rely on the scrollbar to discover the last index used in a name. 

Furthermore, I want to capture two "subranges" within existing ranges. To do
this I adapt the naming convention for compatibility with the existing range
names: 

MOD_0
MOD_0_SUP
MOD_0_SUB
MOD_1
MOD_1_SUP
MOD_1_SUB
...
MOD_100
MOD_100_SUP
MOD_100_SUB

As I am adding two subranges to correspond with each existing range, I
occasionally need to view the existing range area highlighted in the
spreadsheet while inspecting it in the Named Ranges and Expressions Manager
display so I can accurately select and name the subranges. This process would
be more efficient if I could filter the list of Named Ranges and Expressions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159425] ISBLANK(range)

2024-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159425

Rafael Lima  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

--- Comment #4 from Rafael Lima  ---
This actually works in Calc. But for you to apply the formula as an array
formula you must press Ctrl+Shitf+Enter.

So basically do the following:
1) Enter the formula =AND(ISBLANK(C5:M5)) in cell A1
2) Instead of pressing Enter, press Ctrl+Shift+Enter

You'll know you did it right because the formula bar will show
{AND(ISBLANK(C5:M5))} to indicate this is an array formula.

The reason for this ticket is that now Excel automatically understands that
this is an array formula. Maybe LO should do the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   >