[Bug 160493] Crash with floating table when changing to specific font size

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160493

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
(In reply to Miklos Vajna from comment #4)
And that's perfectly understandable, happy to go with your preference here if
the chain of fixes is too hairy to backport :)

Just noting that this document's fileopen:

- started freezing in in 7.6.1 at 7278c1facfd675dd1972a01370de4425704d9a16
- started crashing in 7.6.2 at 9e453a7af284cf17cb0debd2ab027f626e6e4a62

But given that the signature is quite rare (9 reports currently), we can assume
it doesn't affect many users, so let's just stick to 24.2 fixes:
https://crashreport.libreoffice.org/stats/signature/SwTabFrame::MakeAll(OutputDevice*)

Let's focus on the font size change crash then, targetting 24.2 and trunk!

-- 
You are receiving this mail because:
You are the assignee for the bug.

help.git: source/text

2024-04-04 Thread Olivier Hallot (via logerrit)
 source/text/sbasic/shared/exportasfixedformat.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4c741dd9f01c329e58fe6c5ae6cfcf7570c5a8c7
Author: Olivier Hallot 
AuthorDate: Thu Apr 4 14:54:07 2024 -0300
Commit: Adolfo Jayme Barrientos 
CommitDate: Fri Apr 5 07:32:25 2024 +0200

Mute l10n in page title

Change-Id: Id715ea5bd4b17ac866e8c5638e0f725b9aaa6b96
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165803
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/sbasic/shared/exportasfixedformat.xhp 
b/source/text/sbasic/shared/exportasfixedformat.xhp
index 2705c8c865..0259209369 100644
--- a/source/text/sbasic/shared/exportasfixedformat.xhp
+++ b/source/text/sbasic/shared/exportasfixedformat.xhp
@@ -11,7 +11,7 @@
 
 
 
-ExportAsFixedFormat
+ExportAsFixedFormat
 /text/sbasic/shared/exportasfixedformat.xhp
 
 


core.git: helpcontent2

2024-04-04 Thread Olivier Hallot (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 438f0742320a5999e5ca785d152fd14a279799e1
Author: Olivier Hallot 
AuthorDate: Fri Apr 5 02:32:25 2024 -0300
Commit: Gerrit Code Review 
CommitDate: Fri Apr 5 07:32:25 2024 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 4c741dd9f01c329e58fe6c5ae6cfcf7570c5a8c7
  - Mute l10n in page title

Change-Id: Id715ea5bd4b17ac866e8c5638e0f725b9aaa6b96
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165803
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index c89178e82aba..4c741dd9f01c 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit c89178e82abacbb240e571fcbd9bd0f76b40642d
+Subproject commit 4c741dd9f01c329e58fe6c5ae6cfcf7570c5a8c7


[Bug 82097] REPORTBUILDER: Group Header keeps the values of the first group

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82097

Lionel Elie Mamane  changed:

   What|Removed |Added

URL|https://www.hiddengemsfinan |
   |cial.com/   |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141047] FORMATTING: Calc render 11 pt Calibri font as 10,5 pt when cell contains NBSP at 90% zoom

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141047

Buovjaga  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

--- Comment #15 from Buovjaga  ---
(In reply to ady from comment #14)
> FWIW, I don't see this difference with AOO 4.1.15.

Then let's treat this as a regression.

Users who can reproduce are encouraged to bibisect:
https://wiki.documentfoundation.org/QA/Bibisect/Windows
https://wiki.documentfoundation.org/QA/Bibisect

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160488] VIEWING - Characters extending below the baseline are cut off as drop caps

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160488

--- Comment #2 from Naresh  ---
Hi, Thank you for raising this ticket. Can you please specify the font name to
help me verify this issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 139997] Video playback in Impress disappears or plays above side

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139997

Kira Tubo  changed:

   What|Removed |Added

 CC||kira.t...@gmail.com

--- Comment #8 from Kira Tubo  ---
Not sure if this is the same issue...I was somewhat able to reproduce, but with
slightly different steps:

1. Open attachment 169242 [details] (it contains an mpg video in a pptx file,
but also happens if I convert this to odp)
2. Open the Properties sidebar, select the video on the slide
3. Start playing the video
4. Click outside of slide
5. Move the mouse continuously

Result: Placeholder image and video flickers back and forth between each other. 

Video: https://go.screenpal.com/watch/cZfhf6VsFyi

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: aef28c23adc87b8e26eacb56c7dbcf652e907fb9
CPU threads: 6; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 133092] [META] Crash bugs

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133092

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||160523


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160523
[Bug 160523] FILEOPEN Writer closes immediately after odt document is opened /
created
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160523] FILEOPEN Writer closes immediately after odt document is opened / created

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160523

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
   Priority|medium  |highest
 Blocks||133092
   Severity|normal  |critical
 Ever confirmed|0   |1
 CC||stephane.guillou@libreoffic
   ||e.org
Summary|FILEOPEN Writer closes  |FILEOPEN Writer closes
   |immediately after odt   |immediately after odt
   |document is opened  |document is opened /
   ||created
 Status|UNCONFIRMED |NEW

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
So according to your tests, something between
c9d4f99b2bb54ac7735b3e0d0cadbafbd0279518 and
b0edb1909b9deb1a170497f935a528f8118c8308 caused it.

Reproduced on Windows 11 after clicking Writer Document in the Start Center:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7b9905df455b47977968a185a7c43f35541e018b
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Not reproduced on Linux:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f2482fd96eff00b806fae385096531f63f5f2bf5
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Nor with gen VCL plugin.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133092
[Bug 133092] [META] Crash bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 133092] [META] Crash bugs

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133092

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||160525


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160525
[Bug 160525] Crash in: Edit::ImplSetText(rtl::OUString const &,Selection const
*) when opening Bullets and Numbering dialog in Impress
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 48799] [META] Impress Bullets and Numbering bugs (formatting and UI)

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=48799

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||160525


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160525
[Bug 160525] Crash in: Edit::ImplSetText(rtl::OUString const &,Selection const
*) when opening Bullets and Numbering dialog in Impress
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 133092] [META] Crash bugs

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133092
Bug 133092 depends on bug 160525, which changed state.

Bug 160525 Summary: Crash in: Edit::ImplSetText(rtl::OUString const &,Selection 
const *) when opening Bullets and Numbering dialog in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=160525

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 48799] [META] Impress Bullets and Numbering bugs (formatting and UI)

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=48799
Bug 48799 depends on bug 160525, which changed state.

Bug 160525 Summary: Crash in: Edit::ImplSetText(rtl::OUString const &,Selection 
const *) when opening Bullets and Numbering dialog in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=160525

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160525] Crash in: Edit::ImplSetText(rtl::OUString const &,Selection const *) when opening Bullets and Numbering dialog in Impress

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160525

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 OS|All |Windows (All)
   Keywords||bibisectRequest, regression
 Blocks||48799, 133092
   Severity|normal  |critical
Summary|Crash in:   |Crash in:
   |Edit::ImplSetText(rtl::OUSt |Edit::ImplSetText(rtl::OUSt
   |ring const &,Selection  |ring const &,Selection
   |const *)|const *) when opening
   ||Bullets and Numbering
   ||dialog in Impress
 Status|NEEDINFO|RESOLVED

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
Ah, reproduced on Windows 11 with my sample file:

https://crashreport.libreoffice.org/stats/crash_details/761c4bf0-dc69-48f7-a99e-ce568a9d79e8

Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

However, not reproduced in current trunk build:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7b9905df455b47977968a185a7c43f35541e018b
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Nor in 24.2.2.2:

Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Nor in 7.6.6.3:

Version: 7.6.6.3 (X86_64) / LibreOffice Community
Build ID: d97b2716a9a4a2ce1391dee1765565ea469b0ae7
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Nor in 7.5.0.3.

Regression that is already fixed, but not sure by which commit included in
24.2.2.2.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=48799
[Bug 48799] [META] Impress Bullets and Numbering bugs (formatting and UI)
https://bugs.documentfoundation.org/show_bug.cgi?id=133092
[Bug 133092] [META] Crash bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155838] PDF Conversion Removing Dropdown and Checkbox Input values

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155838

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160196] Combined "Hybrid PDF" and "Archival PDF" options generate non-conformant PDF/A files

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160196

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160297] Write protected Calc file can't be closed.

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160297

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160293] When clicking inside a pivot table, GroupedBar Compact hides all its groups except "File" and "Edit"

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160293

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160304] Manage direct changes dialog is confusing in case of deleted table rows

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160304

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155838] PDF Conversion Removing Dropdown and Checkbox Input values

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155838

--- Comment #10 from QA Administrators  ---
Dear Steph,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157462] Calc: Copy/paste of entire sheet is slightly < 100% complete (pasted sheet is missing a few rectangle shapes)

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157462

--- Comment #4 from QA Administrators  ---
Dear terry.masters,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 139997] Video playback in Impress disappears or plays above side

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139997

--- Comment #7 from QA Administrators  ---
Dear NISZ LibreOffice Team,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 135602] Fileopen DOCX: substitute fonts not working on open when odt with Wingdings saved as DOCX in Linux/Mac (OK in Win and OK as DOC)

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135602

--- Comment #10 from QA Administrators  ---
Dear shariqkeen,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160513] Table guides and margin formatting aids not visible after upgrade from 7.5.9 to 7.6.6

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160513

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|Table guides not visible|Table guides and margin
   |after upgrade from 7.5.9 to |formatting aids not visible
   |7.6.6   |after upgrade from 7.5.9 to
   ||7.6.6
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
(In reply to Ulrich Windl from comment #5)
> I'm NOT talking about table borders that would be visible when printing, but
> I refer to "input aids" showing the page's text boundary (and also
> boundaries for table cells).
> [...]
> When I pressed the "paragraph button" (Ctrl+F10) [...]
Ah, thanks for clarifying.
So there's at least two things that you are referring to:
- the "Table Boundaries" I mention in my comment 4 (unrelated to borders)
- the full margin guides that are shown when activating the "Formatting Aids"
(that's the name in English) with Ctrl + F10.

> So I renamed the "Libreoffice" directory to "remove" the profile temporarily.
> When I pressed the "paragraph button" (Ctrl+F10), the guide lines appeared
> (replacing the crosshair-like markings at the page's edges).
So there's an issue in how your profile is reused when moving to 7.6.
Without access to the profile, this can be tricky to investigate. But the
profile does contain personal information, so wouldn't recommend sharing in
full.

Please do check what the table boundary setting looks like in LO 7.6: Tools >
Options > LibreOffice > Application Colors > General > Table Boundaries

Can you consider using a fresh profile? And possibly, when customising again,
you might find out which setting makes the issue reappear.

Alternatively, you could try bibisecting the issue:
https://bibisect.libreoffice.org/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160525] Crash in: Edit::ImplSetText(rtl::OUString const &,Selection const *)

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160525

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160525] Crash in: Edit::ImplSetText(rtl::OUString const &,Selection const *)

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160525

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Created attachment 193501
  --> https://bugs.documentfoundation.org/attachment.cgi?id=193501=edit
test ODP

Not reproduced on Linux with the sample file I created above:

Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

- Can you reproduce the crash with this file?
- If not, do you have a sample file that you could share?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160196] Combined "Hybrid PDF" and "Archival PDF" options generate non-conformant PDF/A files

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160196

--- Comment #3 from peter.wy...@pdfa.org ---
If you want to pass me some sample corrected PDFs, I'm more than happy to check
them for you for both ISO subset compliance as well as correctness against the
PDF specifications.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160519] Spellchecker Spanish Language do no correct obvious mistakes in a multi language document

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160519

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Agree with RGB here, the basic spellchecker accepts "quien" because the
unaccentuated pronoun does exist: https://www.rae.es/dpd/quien
"escribio" is underlined in red as expected.
(using the Spanish dictionary from https://github.com/sbosio/rla-es, version
2.8)

Checking for grammar rules requires extra tools. I have LanguageTool installed,
and it does underline "quien" in blue, with the suggestion:

"Si es interrogativo, se escribe con tilde."

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160290] Right-clicking to select an always-shown comment in Calc "clicks through" and selects the cell behind it

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160290

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||stephane.guillou@libreoffic
   ||e.org
   Keywords||needsUXEval

--- Comment #13 from Stéphane Guillou (stragu) 
 ---
Thanks for all your input.
I think I'm with Jeff on this, mainly because of the following quotes:

(In reply to Jeff Fortin Tam from comment #3)
> It does not make
> sense to select individual cells that I cannot see, because I cannot see
> what I am acting on.

(In reply to Jeff Fortin Tam from comment #5)
> "Direct right-click" on an image or chart object selects & opens its context
> menu.
> It does not select the cells behind the chart/image.

(In reply to Jeff Fortin Tam from comment #7)
> Z-order interaction behavior should be consistent whether it's right- or
> left-click.
So consider me a +1.

(In reply to ady from comment #6)
> Please let's patiently wait for the UX Team comments now.
Heiko has replied now, but in case others have an on changing a long-standing
behaviour, adding keywords.

I confirm that it's the same in OOo Calc 3.3.

However, looking at consistency across components, note that current trunk's
Impress _does_ allow right-clicking the numbered comment indicator without
needing to first show the comment. It does not open the context menu for the
page or whatever object is behind.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160290] Right-clicking to select an always-shown comment in Calc "clicks through" and selects the cell behind it

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160290

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||stephane.guillou@libreoffic
   ||e.org
   Keywords||needsUXEval

--- Comment #13 from Stéphane Guillou (stragu) 
 ---
Thanks for all your input.
I think I'm with Jeff on this, mainly because of the following quotes:

(In reply to Jeff Fortin Tam from comment #3)
> It does not make
> sense to select individual cells that I cannot see, because I cannot see
> what I am acting on.

(In reply to Jeff Fortin Tam from comment #5)
> "Direct right-click" on an image or chart object selects & opens its context
> menu.
> It does not select the cells behind the chart/image.

(In reply to Jeff Fortin Tam from comment #7)
> Z-order interaction behavior should be consistent whether it's right- or
> left-click.
So consider me a +1.

(In reply to ady from comment #6)
> Please let's patiently wait for the UX Team comments now.
Heiko has replied now, but in case others have an on changing a long-standing
behaviour, adding keywords.

I confirm that it's the same in OOo Calc 3.3.

However, looking at consistency across components, note that current trunk's
Impress _does_ allow right-clicking the numbered comment indicator without
needing to first show the comment. It does not open the context menu for the
page or whatever object is behind.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 160291] Sampling dialog should be able to run without closing the dialog

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160291

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
(In reply to Stéphane Guillou (stragu) from comment #1)
> I agree that it's too cumbersome for several sampling events of the same
> sample to various sources.
various _targets_.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160291] Sampling dialog should be able to run without closing the dialog

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160291

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||heiko.tietze@documentfounda
   ||tion.org,
   ||stephane.guillou@libreoffic
   ||e.org
 Ever confirmed|0   |1

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
I agree that it's too cumbersome for several sampling events of the same sample
to various sources.

What about a simple "Apply" button like in other dialogs? More consistent, and
no need for an extra tick box. I think Paste Special's "Run immediately" only
makes sense when there are preset buttons.

Heiko, do you agree?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160273] Writing direction with rotated text in cell is inconsistent

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160273

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
(In reply to V Stuart Foote from comment #2)
> You are mixing Table/Table Cell *text orientation* up with Character *text
> rotation*.
> 
> Different attributes!
> 
> Table layout BTLR is different to TBRL -- the 90 left rotation happens to
> match the layout of the BTLR orientation.  Simply put, the 270 right
> rotation does not match layout of TBRL orientation.
> 
> IMHO => NAB
I agree with Stuart here. Character rotation is a character effect, not a
whole-paragraph or whole-cell tool.

(In reply to Csábi Frigyes from comment #3)
> Hmm, yes you are right, the 270 rotation is still left to right. My problem
> is, that it is very hard to read. And if i try to change it to right to left
> (Ctrl + Shift + D in Windows) it messes up the text. Would you consider this
> as a bug?
Why would you change an LTR script to RTL direction? In this case, the
character rotation and the writing direction features would be both missused.
If you want the text contained in a table cell to be read by tilting your head
to the right, cell rotation has to be used. What is wrong with using cell
rotation?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141586] Restoring last document position is unreliable

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141586

--- Comment #38 from skierpage  ---
I didn't even know that LO Writer had this feature until Tip of the Day #105
appeared:
> Your Writer document does not reopen with the text cursor at the same editing
> position it was when you saved it? Add First or Last name in
> Tools ▸ Options ▸ %PRODUCTNAME ▸ User Data ▸ First/last name.
(https://cgit.freedesktop.org/libreoffice/core/tree/cui/inc/tipoftheday.hrc#n160
)
and... it didn't work at all in LibreOffice Version: 24.2.2.2 (X86_64) Flatpak;
the text cursor appeared at the top. The Shift-F5 trick did work and
settings.xml did hold ViewTop and ViewLeft, so I think I'm confirming this bug
and not bug 140147. 

Please remove Tip of the Day #105 until it's reliable, or add "then press
Shift-F5" to it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

New Defects reported by Coverity Scan for LibreOffice

2024-04-04 Thread scan-admin
Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

17 new defect(s) introduced to LibreOffice found with Coverity Scan.
7 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent 
build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 17 of 17 defect(s)


** CID 1596132:  API usage errors  (LOCK)



*** CID 1596132:  API usage errors  (LOCK)
/scripting/source/vbaevents/eventhelper.cxx: 529 in 
::EventListener::~EventListener()()
523 
524 #define EVENTLSTNR_PROPERTY_ID_MODEL 1
525 constexpr OUStringLiteral EVENTLSTNR_PROPERTY_MODEL = u"Model";
526 
527 namespace {
528 
>>> CID 1596132:  API usage errors  (LOCK)
>>> "~OPropertyContainer2" uses "this->m_aMutex" in an uninitialized state.
529 class EventListener : public EventListener_BASE
530 ,public ::comphelper::OPropertyContainer2
531 ,public ::comphelper::OPropertyArrayUsageHelper< EventListener >
532 {
533 
534 public:

** CID 1596131:  API usage errors  (LOCK)



*** CID 1596131:  API usage errors  (LOCK)
/sc/source/ui/unoobj/celllistsource.cxx: 74 in 
calc::OCellListSource::~OCellListSource()()
68 {
69 if ( !m_bDisposed )
70 {
71 acquire();  // prevent duplicate dtor
72 dispose();
73 }
>>> CID 1596131:  API usage errors  (LOCK)
>>> "~OPropertyContainer2" uses "this->m_aMutex" in an uninitialized state.
74 }
75 
76 IMPLEMENT_FORWARD_XINTERFACE2( OCellListSource, 
OCellListSource_Base, OCellListSource_PBase )
77 
78 IMPLEMENT_FORWARD_XTYPEPROVIDER2( OCellListSource, 
OCellListSource_Base, OCellListSource_PBase )
79 

** CID 1596130:  API usage errors  (LOCK)



*** CID 1596130:  API usage errors  (LOCK)
/chart2/source/tools/CachedDataSequence.cxx: 98 in 
chart::CachedDataSequence::~CachedDataSequence()()
92 }
93 
94 registerProperties();
95 }
96 
97 CachedDataSequence::~CachedDataSequence()
>>> CID 1596130:  API usage errors  (LOCK)
>>> "~WeakComponentImplHelper" uses "this->m_aMutex" in an uninitialized 
>>> state.
98 {}
99 
100 void CachedDataSequence::registerProperties()
101 {
102 registerProperty( "NumberFormatKey",
103   PROP_NUMBERFORMAT_KEY,

** CID 1596129:  API usage errors  (LOCK)



*** CID 1596129:  API usage errors  (LOCK)
/scripting/source/basprov/basmethnode.cxx: 99 in 
basprov::BasicMethodNodeImpl::~BasicMethodNodeImpl()()
93 registerProperty( BASPROV_PROPERTY_EDITABLE, 
BASPROV_PROPERTY_ID_EDITABLE, BASPROV_DEFAULT_ATTRIBS(), _bEditable, 
cppu::UnoType::get() );
94 }
95 
96 
97 BasicMethodNodeImpl::~BasicMethodNodeImpl()
98 {
>>> CID 1596129:  API usage errors  (LOCK)
>>> "~OPropertyContainer2" uses "this->m_aMutex" in an uninitialized state.
99 }
100 
101 
102 // XInterface
103 
104 

** CID 1596128:  API usage errors  (LOCK)



*** CID 1596128:  API usage errors  (LOCK)
/sc/source/ui/unoobj/pageuno.cxx: 28 in ScPageObj::ScPageObj(SdrPage *)()
22 #include 
23 #include 
24 
25 using namespace ::com::sun::star;
26 
27 ScPageObj::ScPageObj( SdrPage* pPage ) :
>>> CID 1596128:  API usage errors  (LOCK)
>>> "SvxDrawPage" initializes "this->m_aMutex" while it is already 
>>> initialized.
28 SvxDrawPage( pPage )
29 {
30 }
31 
32 ScPageObj::~ScPageObj() noexcept
33 {

** CID 1596127:  API usage errors  (LOCK)



*** CID 1596127:  API usage errors  (LOCK)
/sccomp/source/solver/SolverComponent.cxx: 111 in 
SolverComponent::~SolverComponent()()
105 registerProperty( STR_EPSILONLEVEL, PROP_EPSILONLEVEL, 0, 
, cppu::UnoType::get() );
106 registerProperty( STR_LIMITBBDEPTH, PROP_LIMITBBDEPTH, 0, 
, cppu::UnoType::get() );
107 }
108 
109 SolverComponent::~SolverComponent()
110 {
>>> CID 1596127:  API usage errors  (LOCK)
>>> "~WeakImplHelper" uses "this->m_aMutex" in an uninitialized state.
111 }
112 
113 IMPLEMENT_FORWARD_XINTERFACE2( SolverComponent, SolverComponent_Base, 
comphelper::OPropertyContainer2 )
114 IMPLEMENT_FORWARD_XTYPEPROVIDER2( SolverComponent, 

[Bug 160514] Usability of accessibility check (Alt+7)

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160514

Haris  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Haris  ---
Hi Ulrich Windl,

I have no issues clicking on the hyperlinks to see the targets in the text
area, I can use both the left mouse and right mouse buttons. I'm also not
seeing any of the hyperlink and formula object complaints. Can you please
attach a sample document that demonstrates the complaints shown in the
screenshot?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 149041] Calc SUM button confusing with selected cells

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149041

--- Comment #9 from LeroyG  ---
Bug 124643 says: Inherited From OOo.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160512] CRASH Writer Hangs completely when copying complete file, even small file

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160512

--- Comment #6 from m_a_riosv  ---
I can see the bookmarks in your file, but I'm not able to reproduce it from
scratch.

Have you tested in Safe mode?
Menu/Help/Restart in Safe Mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 149041] Calc SUM button confusing with selected cells

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149041

LeroyG  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||4643

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 124643] Calc - skips existing sum cell if I create a new sum containing the existing cell(using mouse for selecting cells)

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124643

LeroyG  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9041

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 124643] Calc - skips existing sum cell if I create a new sum containing the existing cell(using mouse for selecting cells)

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124643

--- Comment #10 from LeroyG  ---
Still present:

Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 60(Build:1)
CPU threads: 4; OS: Linux 5.14; UI render: default; VCL: gtk3
Locale: es-MX (en_US.UTF-8); UI: en-US
Calc: threaded

And 7.5.9.2 on Windows.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159427] Copy value from sum area

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159427

--- Comment #6 from LeroyG  ---
(In reply to Rafael Lima from comment #1)
> a valid enhancement

Yes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160511] "box around character" uses too much padding above (matter of taste)

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160511

--- Comment #5 from m_a_riosv  ---
Can't you solve it, by disable the synchronization on border's padding?, set up
them individually.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141047] FORMATTING: Calc render 11 pt Calibri font as 10,5 pt when cell contains NBSP at 90% zoom

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141047

ady  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #14 from ady  ---
I can reproduce this with specific zoom values; in my case these are: 90%,
210%, 390%.

This is easier to see when comparing the _horizontal_ length of 2 similar text
values, each on adjacent cells, one on top of the other (e.g. cells A1 and A2).

For instance:
A1: D/SE_elapsed sampler:
A2: D/SE_elapsed sampler:

...where cell A1 contains a NBSP character and A2 replaces it with a simple
space character. Column A must use a font size of 11pt, and the zoom factor (in
my case) is either 90% or 210& or 390%.

The horizontal difference can be clearly seen (in my case) at the end of the
underscore in this example, but it doesn't seem to be related to one specific
character/position; it is rather an accumulative difference that by the 5th
glyph is more evident. I can see the difference also before the underscore, but
it is less clear – you have to be aware of this issue and be looking for this
difference.

Changing the zoom factor makes the render equivalent/equal in both cases; space
character vs NBSP, or A2 vs A1 in my example.

Changing the NBSP character by a simple space character makes the horizontal
length change.

I can also repro this with other fonts (e.g. Arial, Consolas, Liberation Mono,
Liberation Sans, Noto Sans...), but always with 11pt; not repro with other
sizes.

I am not sure whether it happens with so-called "variable" fonts (vs. "static"
fonts, not related to monospaced fonts).

Perhaps this is just a matter of how the specific font size (11pt) is
scaled/rendered in Calc.

FWIW, I don't see this difference with AOO 4.1.15.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1344e6261a1d856c71eca1e0cc29215a586bf335
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (es_AR); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160497] FR: Print (or export) only tracked changes

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160497

--- Comment #1 from Joseph Morris  ---
Cross reference to ask.libreoffice.org question 

https://ask.libreoffice.org/t/is-there-any-way-to-print-a-list-of-only-tracked-changes-without-the-rest-of-the-document-in-writer/104216

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160491] In Calc "text to columns" produces two rows out of one row of data

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160491

--- Comment #5 from m_a_riosv  ---
Because there is a line break at the end of the text.
I2: =CODE(RIGHT(H2)) -> 10

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160525] New: Crash in: Edit::ImplSetText(rtl::OUString const &,Selection const *)

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160525

Bug ID: 160525
   Summary: Crash in: Edit::ImplSetText(rtl::OUString const
&,Selection const *)
   Product: LibreOffice
   Version: 24.2.1.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: leo.m...@syonic.eu

This bug was filed from the crash reporting server and is
br-bd42ce44-b7db-4c93-9305-4a29e7c66ae8.
=

2 Crashes:
https://crashreport.libreoffice.org/stats/crash_details/0874ac49-4d39-457c-ba8c-141de9b4bf6e
https://crashreport.libreoffice.org/stats/crash_details/bd42ce44-b7db-4c93-9305-4a29e7c66ae8
===

Impress Presentation:
- Bullet of type "C. Some Text" (starting at 3);
- Right-Click on a word => "Bullet points" => Crash;

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160522] Generating Chart with more than 4 columns selecting stock first than column or bar: only 4 colors

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160522

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m_a_riosv  ---
Please attach a sample file, reduce the size as much as possible without
private information, and paste the information in Menu/Help/About LibreOffice,
there is a copy icon.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160512] CRASH Writer Hangs completely when copying complete file, even small file

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160512

--- Comment #5 from Peter Zwitser  ---
Created attachment 193500
  --> https://bugs.documentfoundation.org/attachment.cgi?id=193500=edit
file with the word 'huis' copied five times

Since this bug seems hard to reproduce, I tried some other things and finally
found one thing that happens every time if I copy. (If I press ^C)

I made a file with only the word 'huis'. No color, border, or any other
lay-out, just one simple word.

If I copy this one simple word for the first time, nothing happens. The word is
simply copied.

If I copy the word for the second time (without closing the file) there's a
bookmark added with the name:
'_DdeLink__24_3300722863'
If I copy the word for the third time, there's a bookmark added with the name:
'_DdeLink__27_3300722863'
If I copy the word for the fourth time, there's a bookmark added with the name:
'_DdeLink__31_3300722863'
If I copy the word for the fifth time, there's a bookmark added with the name:
'_DdeLink__36_3300722863'

Etc. Every time I copy a bookmark is added. This happens in every document, no
difference if I copy one word or the whole document. Only the numbers of the
bookmark change.

So the first time I copy anything no bookmark is created, but second and later
time copying with every copy a bookmark is created. (I stopped after about 20
bookmarks were created.)

The target of the link is the text I copied. If I copy one word and click on
the bookmark, the one word is highlighted. If I copy the whole document, the
whole document is highlighted when clicking on the bookmark.

I'm absolutely sure this started happening with the last uupdate, because I use
bookmarks all the time.

Since this happens when copying, I thought maybe this has something to do with
the problem.

I've added a file 'test2.odt' with only the word 'huis'. This word is copied
five times, so there are four mysterious bookmarks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158267] Freeze/hang if I open the Options dialog

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158267

--- Comment #8 from Unundev  ---
I have to add that in the meantime my LibreOffice (provided by Fedora repos)
got updated to 7.5.8.2.
I'm still on kernel version 6.2.14-200, because I fear breaking my multi boot
setup by fiddling around, since Fedora handles grub differently and I don't
have the time to figure it out properly.
I also downloaded the Flatpak version (which is 7.6.5.2 now).
For some reason the freeze happens in all of these instances.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160513] Table guides not visible after upgrade from 7.5.9 to 7.6.6

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160513

Ulrich Windl  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159787] False alert regarding accessibility and contrast with large font size

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159787

--- Comment #6 from Ulrich Windl  ---
(In reply to Buovjaga from comment #3)
> Seems like the checker should take font size into account?

In any case a better explanation (reason of complaint, suggested fix) would be
helpful.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159787] False alert regarding accessibility and contrast with large font size

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159787

Ulrich Windl  changed:

   What|Removed |Added

 Attachment #193498|Emissive contrast   |Emissive contrast
description|measurement "black against  |measurement "black against
   |white   |white"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159787] False alert regarding accessibility and contrast with large font size

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159787

--- Comment #5 from Ulrich Windl  ---
Created attachment 193499
  --> https://bugs.documentfoundation.org/attachment.cgi?id=193499=edit
Emissive contrast measurement "cyan against white"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159787] False alert regarding accessibility and contrast with large font size

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159787

--- Comment #4 from Ulrich Windl  ---
Created attachment 193498
  --> https://bugs.documentfoundation.org/attachment.cgi?id=193498=edit
Emissive contrast measurement "black against white

I took the color meter and measured my wide-gamut screen in text mode (lower
contrast, "eye friendly"), and here is what I measured:
"black against white" has contrast 1:34
"cyan against white has" contrast 1:5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160524] New: wishbug: make *switching* column quantity as easy as left- or right-justify

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160524

Bug ID: 160524
   Summary: wishbug: make *switching* column quantity as easy as
left- or right-justify
   Product: LibreOffice
   Version: 24.2.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: m.hatz...@web.de

Description:
When writing in a layout with more than one column it is absolutly necessary to
be able to switch to a one column layout. Unfortunatly, to do so is so
complicated that it distracts way to much. It completly kills the workflow.

So please provide some buttons for switching between one, two, three columns in
a way like one can switch between left-justify, right-justify, centered.

For the sake of a undisturbed workflow this is the most obvious feature you
need when writing in a layout with more then one column.

thanks.  

Steps to Reproduce:
1. write with more than one column (lets say two or three)
2. I needed to insert a headline/text/whatever spanning over all columns
3. I needed to go to a (german) help forum to get instructions on how to
accomplish this trivial layout change (seen from my, a writers angle).

Actual Results:
I gave up instantly. Nobody (except you and your colleagues) wants to know what
is necessary in the background to switch between left- and right-justify.
The same goes for switching between number of columns. It has to be a one click
feature as the above.

Expected Results:
Please give us some suitable buttons to switch between one (spaning over the
whole page) or the preselected number of columns (be it two or three).

Yes, this will not cover all possible combinations, but will be helpfull for
the most obvious and basic needs. Feel free to make it even better ...


Reproducible: Always


User Profile Reset: No

Additional Info:
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158267] Freeze/hang if I open the Options dialog

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158267

Unundev  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #7 from Unundev  ---
(In reply to Stéphane Guillou (stragu) from comment #5)
> From what you said, I assume that using the gen VCL plugin (the grey
> interface you saw) does not crash when opening the Options dialog.
> Is that right?
No, it still crashes with the grey interface.(In reply to m_a_riosv from
comment #6)

> Please test Menu/Help/Restart in Safe Mode
Still crashes in Safe Mode, too.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160242] Enhancement: Make possible 2 or more impress in fullscreen each on a dedicated monitor AND each seekable indipendently with user-defined hotkeys per each file.

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160242

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Thanks for the extra details, much appreciated. Let's see what UX/Design think.
In my opinion, it still remains too niche a use to fit it in the UI, and would
be better suited for an extension.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160242] Enhancement: Make possible 2 or more impress in fullscreen each on a dedicated monitor AND each seekable indipendently with user-defined hotkeys per each file.

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160242

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Thanks for the extra details, much appreciated. Let's see what UX/Design think.
In my opinion, it still remains too niche a use to fit it in the UI, and would
be better suited for an extension.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 60270] LibreOffice 4.1 most annoying bugs

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=60270
Bug 60270 depends on bug 71423, which changed state.

Bug 71423 Summary: Impress frequently crashes when selecting or editing tables 
in slides while styles & formatting dialog is open
https://bugs.documentfoundation.org/show_bug.cgi?id=71423

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160513] Table guides not visible after upgrade from 7.5.9 to 7.6.6

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160513

--- Comment #5 from Ulrich Windl  ---
(In reply to Stéphane Guillou (stragu) from comment #4)
Version I have:
Version: 7.6.6.3 (x86) / LibreOffice Community
Build ID: d97b2716a9a4a2ce1391dee1765565ea469b0ae7
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

You might have mis-understood, or I did not express very well (occasionally I
don't know the correct phrases in English):
I'm NOT talking about table borders that would be visible when printing, but I
refer to "input aids" showing the page's text boundary (and also boundaries for
table cells).

Assuming the feature still exists, I must assume that either the setting was
lost during upgrade, or the setting isn't interpreted correctly.

Maybe it's a setting like this (my wild guess):
true

Regarding the instructions in https://wiki.documentfoundation.org/UserProfile:
I have no program named libreoffice, but I have soffice.exe in C:\Program
Files\LibreOffice 5\program. Also soffice does not know about the "--safe-mode"
option.

So I renamed the "Libreoffice" directory to "remove" the profile temporarily.
When I pressed the "paragraph button" (Ctrl+F10), the guide lines appeared
(replacing the crosshair-like markings at the page's edges).

However when I switch back to my saved profile, I see neither: No
crosshair-like corner markings and not grey lines, and pressing the "paragraph
button" changes nothing.

So I think there's a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160510] When pasting text styled with character format to a new document that style isn't edit-able

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160510

--- Comment #4 from Ulrich Windl  ---
Created attachment 193497
  --> https://bugs.documentfoundation.org/attachment.cgi?id=193497=edit
Sample document showing the bug

Maybe this is just an effect of other bugs related to copying text with
character formats. I made an experiment:
If the text pasted contains more than the styled part, then the character
format can be edited; however if it contains only the styled part, the
character style cannot be edited. In this case I saved the document, closed it
and re-opened it, and still: the character style cannot be edited.

If you try to edit the style "Taste", it does not offer the corresponding
context menu.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: ESC meeting minutes: 2024-04-04

2024-04-04 Thread Eyal Rozenberg

Shame on the BoD - current and previous - for carrying out the entire
hiring process for a RTL/CTL/CJK develop while completely shutting out
(*) the RTL language community, for the second time, despite the
explicit protest and demand not to do so.

And it is unfortunate that the ESC acknowledges this having occurred
without even hinting at an obligation to consult with the relevant
language communities/groups.

Eyal

(*) - I'm making the assumption that this was not discussed on the Farsi
Telegram channel, which I do not follow; otherwise it's "shutting out a
significant part of the RTL language community." Also, I would not be
surprised if the CJK community wasn't involved either.


On 04/04/2024 17:35, Miklos Vajna wrote:

* Present:
     + Cloph, Hossein, Michael W, Olivier, Caolan, Ilmari, Jonathan,
Michael S, Stephan, Xisco, Miklos, Heiko, Thorsten

* Completed Action Items:

* Pending Action Items:

* Release Engineering update (Cloph)
     + 7.6: 7.6.7 RC1 week 16
     + 24.2: 24.2.3 RC1 week 15

* Welcome Jonathan Clark

     - New RTL/CTL/CJK developer

     - working for TDF

     - reviewing bug backlog currently

     - preferred IRC nick? :-) (Xisco)

   - jclark or so


Re: ESC meeting minutes: 2024-04-04

2024-04-04 Thread Eyal Rozenberg

Shame on the BoD - current and previous - for carrying out the entire
hiring process for a RTL/CTL/CJK develop while completely shutting out
(*) the RTL language community, for the second time, despite the
explicit protest and demand not to do so.

And it is unfortunate that the ESC acknowledges this having occurred
without even hinting at an obligation to consult with the relevant
language communities/groups.

Eyal

(*) - I'm making the assumption that this was not discussed on the Farsi
Telegram channel, which I do not follow; otherwise it's "shutting out a
significant part of the RTL language community." Also, I would not be
surprised if the CJK community wasn't involved either.


On 04/04/2024 17:35, Miklos Vajna wrote:

* Present:
     + Cloph, Hossein, Michael W, Olivier, Caolan, Ilmari, Jonathan,
Michael S, Stephan, Xisco, Miklos, Heiko, Thorsten

* Completed Action Items:

* Pending Action Items:

* Release Engineering update (Cloph)
     + 7.6: 7.6.7 RC1 week 16
     + 24.2: 24.2.3 RC1 week 15

* Welcome Jonathan Clark

     - New RTL/CTL/CJK developer

     - working for TDF

     - reviewing bug backlog currently

     - preferred IRC nick? :-) (Xisco)

   - jclark or so


[Bug 160523] New: FILEOPEN Writer closes immediately after odt document is opened

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160523

Bug ID: 160523
   Summary: FILEOPEN Writer closes immediately after odt document
is opened
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stefan_lange...@t-online.de

Libreoffice Writer closes immediately after a selected odt document is opened
and the first page is displayed or when a new text document should be created
after the empty page is displayed. This means for me Writer is not usable.

Reproducing the behavior:
1a. Open existing odt document (until now not tested with other formats e.g.
docx)
or
1b. Choose "New" -> "Text document"
2. Look what happens

In my tests was displayed the first page of an existing document resp. an empty
page (for new document) for about 1 second and then Writer was closed.
Because at the next LO start no abort message was displayed and no hint to send
a crash report appeared it can be Writer did not crash but was closed normally.

I have reproduced the behavior with
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7b9905df455b47977968a185a7c43f35541e018b
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded
(from /daily/master/Win-x86_64@tb77-TDF/2024-04-04_03.57.42/)
and
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b0edb1909b9deb1a170497f935a528f8118c8308
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded
resp. in Windows 11
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b0edb1909b9deb1a170497f935a528f8118c8308
CPU threads: 4; OS: Windows 10.0 Build 22635; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
(from /daily/master/Win-x86_64@tb77-TDF/2024-04-03_21.05.25/)

but not with
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c9d4f99b2bb54ac7735b3e0d0cadbafbd0279518
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded
(from /daily/master/Win-x86_64@tb77-TDF/2024-03-31_03.57.06/)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160511] "box around character" uses too much padding above (matter of taste)

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160511

--- Comment #4 from Ulrich Windl  ---
Created attachment 193496
  --> https://bugs.documentfoundation.org/attachment.cgi?id=193496=edit
Simple sample document

(In reply to m_a_riosv from comment #3)
Sample file created and attached. Writer version is:

Version: 7.6.6.3 (x86) / LibreOffice Community
Build ID: d97b2716a9a4a2ce1391dee1765565ea469b0ae7
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sfx2/source

2024-04-04 Thread Moritz Duge (via logerrit)
 sfx2/source/dialog/backingwindow.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 30c6e51fc9cb0fa864e1755271343d847fcced25
Author: Moritz Duge 
AuthorDate: Wed Apr 3 21:45:09 2024 +0200
Commit: Thorsten Behrens 
CommitDate: Thu Apr 4 23:23:56 2024 +0200

Remove duplicate code.

Change-Id: Ia32b0525ecdf5944c2ebd3045dc3d536941ed394
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165763
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sfx2/source/dialog/backingwindow.cxx 
b/sfx2/source/dialog/backingwindow.cxx
index 9e30572d12d3..efa18f452d51 100644
--- a/sfx2/source/dialog/backingwindow.cxx
+++ b/sfx2/source/dialog/backingwindow.cxx
@@ -354,7 +354,6 @@ void BackingWindow::ApplyStyleSettings()
 
 // setup larger fonts
 setLargerFont(mxOpenButton, aButtonFont);
-setLargerFont(mxOpenButton, aButtonFont);
 setLargerFont(mxRemoteButton, aButtonFont);
 setLargerFont(mxRecentButton, aButtonFont);
 setLargerFont(mxTemplateButton, aButtonFont);


core.git: static/README.wasm.md

2024-04-04 Thread Moritz Duge (via logerrit)
 static/README.wasm.md |   28 +++-
 1 file changed, 15 insertions(+), 13 deletions(-)

New commits:
commit 430704311a1380b569f89c7b9e3cde35ac55b672
Author: Moritz Duge 
AuthorDate: Wed Apr 3 12:04:04 2024 +0200
Commit: Thorsten Behrens 
CommitDate: Thu Apr 4 23:23:21 2024 +0200

Improved documentation (Emscripten, Qt5 usage, WASM examples)

Sentence about Emscripten was probably obsolete since around commit 12a6b57c

Change-Id: Ide59154439f8a069c2dbd58420c1c93844790a79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165754
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/static/README.wasm.md b/static/README.wasm.md
index 006f1409f907..d3bd78b59b99 100644
--- a/static/README.wasm.md
+++ b/static/README.wasm.md
@@ -27,8 +27,8 @@ INFO: latest browser won't work anymore with 0.0.0.0 and need 
127.0.0.1.
 ## Setup for the LO WASM build (with Qt)
 
 We're using Qt 5.15.2 with Emscripten 3.1.46. There are a bunch of Qt patches
-to fix the most grave bugs. Also newer Emscripten versions have various bugs
-with the FS image support.
+to fix the most grave bugs. Also there's rapid development in Emscripten, so
+using another version often causes arbitraty problems.
 
 - See below under Docker build for another build option
 
@@ -57,27 +57,29 @@ FWIW: Qt 5.15 LTS is not maintained publicly and Qt WASM 
has quite a few bugs. M
 WASM fixes from Qt 6 are needed for Qt 5.15 too. Allotropia offers a Qt 
repository
 with the necessary patches cherry-picked.
 
+With "-opensource -confirm-license" you agree to the open source license.
+
 git clone https://github.com/allotropia/qt5.git
 cd qt5
 git checkout v5.15.2+wasm
 ./init-repository --module-subset=qtbase
-./configure -xplatform wasm-emscripten -feature-thread -prefix 
+./configure -opensource -confirm-license -xplatform wasm-emscripten 
-feature-thread -prefix 
 make -j module-qtbase
 
 Optionally you can add the configure flag "-compile-examples". But then you 
also have to
 patch at least mkspecs/wasm-emscripten/qmake.conf with EXIT_RUNTIME=0, 
otherwise they will
 fail to run. In addition, building with examples will break with some of them, 
but at that
-point Qt already works and also most examples.
-Building with examples will break with some of them, but at that point Qt 
already works.
-Or just skip them. Other interesting flags might be "-nomake tests -no-pch 
-ccache".
+point Qt already works and also most examples. Or just skip them. Other 
interesting flags
+might be "-nomake tests -no-pch -ccache".
 
-Linking takes quite a long time, because emscripten-finalize rewrites the 
whole WASM files
-with some options. This way the LO WASM needs at least 64GB RAM. For faster 
link times add
-"-s WASM_BIGINT=1", change to ASSERTIONS=1 nd use -g3 to prevent rewriting the 
WASM file
-and generating source maps (see emscripten.py, finalize_wasm, and avoid 
modify_wasm = True).
-This is just needed for Qt examples, as LO already uses the correct flags!
+Linking takes quite a long time, because emscripten-finalize rewrites the 
whole WASM files with
+some options. This way the LO WASM possibly needs 64GB RAM. For faster link 
times add
+"-s WASM_BIGINT=1", change to ASSERTIONS=1 and use -g3 to prevent rewriting 
the WASM file and
+generating source maps (see emscripten.py, finalize_wasm, and avoid 
modify_wasm = True). This is
+just needed for Qt examples, as LO already uses the correct flags!
 
-The install is not really needed, as LO currently just uses qtbase on its own. 
You can do
+It's needed to install Qt5 to the chosen prefix. Else LO won't find all needed 
files in the
+right place. For installation you can do
 
 make -j install
 or
@@ -104,7 +106,7 @@ Recommended configure setup is thusly:
 `--with-distro=LibreOfficeWASM32`
 
 * local config
-`QT5DIR=/dir/of/git_qt5/qtbase`
+`QT5DIR=/dir/of/qt5/install/prefix`
 
 * if you want to use ccache on both sides of the build
 `--with-build-platform-configure-options=--enable-ccache`


core.git: sc/inc

2024-04-04 Thread Andrea Gelmini (via logerrit)
 sc/inc/column.hxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit f7866596d1c44f092f6c8f896b770e2882b0fe81
Author: Andrea Gelmini 
AuthorDate: Wed Apr 3 20:10:56 2024 +0200
Commit: Julien Nabet 
CommitDate: Thu Apr 4 23:11:38 2024 +0200

Remove duplicated include

Change-Id: I802dc451e12ad42f89dff553128f1324e161af28
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165757
Reviewed-by: Julien Nabet 
Tested-by: Jenkins

diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index 39b192bb68ef..22e3ad1e284c 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -30,7 +30,6 @@
 #include 
 #include 
 #include 
-#include "attarray.hxx"
 
 #include 
 #include 


core.git: sd/source

2024-04-04 Thread Thorsten Behrens (via logerrit)
 sd/source/ui/dlg/present.cxx |4 
 sd/source/ui/slideshow/slideshow.cxx |9 +
 2 files changed, 1 insertion(+), 12 deletions(-)

New commits:
commit 2f093d16be4c87d0535d0c6338c308ad9f6a3c84
Author: Thorsten Behrens 
AuthorDate: Thu Apr 4 21:19:02 2024 +0200
Commit: Thorsten Behrens 
CommitDate: Thu Apr 4 23:10:47 2024 +0200

IASS: make live slideshow non-experimental

Change-Id: I36fb6eae8f77f02fa1a9bcf96a7c074d78ba86c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165804
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sd/source/ui/dlg/present.cxx b/sd/source/ui/dlg/present.cxx
index d3e238b7bd3d..9640c5b72fd7 100644
--- a/sd/source/ui/dlg/present.cxx
+++ b/sd/source/ui/dlg/present.cxx
@@ -25,8 +25,6 @@
 #include 
 #include 
 
-#include 
-
 #include 
 #include 
 #include 
@@ -180,8 +178,6 @@ 
SdStartPresentationDlg::SdStartPresentationDlg(weld::Window* pWindow, const SfxI
 #endif
 
 m_xCbxInteractiveMode->set_active( static_cast( 
rOutAttrs.Get( ATTR_PRESENT_INTERACTIVE ) ).GetValue() );
-if (!officecfg::Office::Common::Misc::ExperimentalMode::get())
-m_xCbxInteractiveMode->set_visible(false);
 
 InitMonitorSettings();
 
diff --git a/sd/source/ui/slideshow/slideshow.cxx 
b/sd/source/ui/slideshow/slideshow.cxx
index c25f0114c876..39e3e6a21221 100644
--- a/sd/source/ui/slideshow/slideshow.cxx
+++ b/sd/source/ui/slideshow/slideshow.cxx
@@ -39,8 +39,6 @@
 #include 
 #include 
 
-#include 
-
 #include 
 #include 
 #include 
@@ -240,12 +238,7 @@ bool SlideShow::IsInteractiveSlideshow(const 
ViewShellBase* pViewShellBase)
 
 bool SlideShow::IsInteractiveSlideshow() const
 {
-// allow override with ENV_VAR for practical dev reasons
-static bool 
g_bEnable_Interactive_Slideshow(getenv("ENABLE_INTERACTIVE_SLIDESHOW"));
-if (g_bEnable_Interactive_Slideshow)
-return true;
-
-return officecfg::Office::Common::Misc::ExperimentalMode::get() && 
mpDoc->getPresentationSettings().mbInteractive;
+return mpDoc->getPresentationSettings().mbInteractive;
 }
 
 void SlideShow::CreateController(  ViewShell* pViewSh, ::sd::View* pView, 
vcl::Window* pParentWindow )


[Bug 160242] Enhancement: Make possible 2 or more impress in fullscreen each on a dedicated monitor AND each seekable indipendently with user-defined hotkeys per each file.

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160242

--- Comment #2 from mrt_...@yahoo.com ---
A. Not covered: each presentation must be run in fullscreen
B. Not covered: It's really impractical. I have to move the mouse between the
screens and I waste too much time stumbling so the conversation gets lost.

C & D. It's hard, when you're standing explaining, having to go back to the
table, to the PC, to the mouse, interrupt the conversation and look for where
to move the mouse to change slides on which projector. I have already tried the
advice you gave and immediately abandoned it at the first conference. Very
unconfortable for my purposes.

I'll tell you how I made do for the moment

For now I'll make do by launching virtual machines each with a presentation and
a laser pointer attached via USB pass-through. Each virtual machine is in full
screen on a different projector. So I have, for example, three laser pointers
with three projectors with which I change the slides on the projector that
interests me from time to time. Plus in the main notebook screen I can see the
image of each 3 projector, (how?) using VNC or RDP connected to the virtual
machines.

The purpose of my request was to be able to do everything without using virtual
machines. So less hardware requirements, cheaper notebook, less power,...

Let's say that I am quite satisfied with the solution I adopt above with VM,
but I would like Impress to offer all of this, or at least part of it, already
by itself.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160242] Enhancement: Make possible 2 or more impress in fullscreen each on a dedicated monitor AND each seekable indipendently with user-defined hotkeys per each file.

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160242

--- Comment #2 from mrt_...@yahoo.com ---
A. Not covered: each presentation must be run in fullscreen
B. Not covered: It's really impractical. I have to move the mouse between the
screens and I waste too much time stumbling so the conversation gets lost.

C & D. It's hard, when you're standing explaining, having to go back to the
table, to the PC, to the mouse, interrupt the conversation and look for where
to move the mouse to change slides on which projector. I have already tried the
advice you gave and immediately abandoned it at the first conference. Very
unconfortable for my purposes.

I'll tell you how I made do for the moment

For now I'll make do by launching virtual machines each with a presentation and
a laser pointer attached via USB pass-through. Each virtual machine is in full
screen on a different projector. So I have, for example, three laser pointers
with three projectors with which I change the slides on the projector that
interests me from time to time. Plus in the main notebook screen I can see the
image of each 3 projector, (how?) using VNC or RDP connected to the virtual
machines.

The purpose of my request was to be able to do everything without using virtual
machines. So less hardware requirements, cheaper notebook, less power,...

Let's say that I am quite satisfied with the solution I adopt above with VM,
but I would like Impress to offer all of this, or at least part of it, already
by itself.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

core.git: editeng/source sw/qa writerfilter/source

2024-04-04 Thread László Németh (via logerrit)
 editeng/source/items/paraitem.cxx  
|2 
 sw/qa/extras/ooxmlexport/data/tdf160518_allowHyphenationAtTrackBottom.docx 
|binary
 sw/qa/extras/ooxmlexport/data/tdf160518_useWord2013TrackBottomHyphenation.docx 
|binary
 sw/qa/extras/ooxmlexport/ooxmlexport14.cxx 
|   64 ++
 writerfilter/source/dmapper/DomainMapperTableHandler.cxx   
|3 
 writerfilter/source/dmapper/PropertyIds.cxx
|1 
 writerfilter/source/dmapper/PropertyIds.hxx
|1 
 writerfilter/source/dmapper/SettingsTable.cxx  
|   17 ++
 writerfilter/source/dmapper/SettingsTable.hxx  
|2 
 9 files changed, 85 insertions(+), 5 deletions(-)

New commits:
commit c8ee0e8f581b8a6e41b1a6b8aa4d40b442c1d463
Author: László Németh 
AuthorDate: Thu Apr 4 14:08:23 2024 +0200
Commit: László Németh 
CommitDate: Thu Apr 4 22:46:12 2024 +0200

tdf160518 DOCX: import hyphenation-keep to fix layout

To fix layout interoperability, import DOCX compatSettings
allowHyphenationAtTrackBottom and useWord2013TrackBottomHyphenation
as hyphenation-keep setting "COLUMN", shifting last hyphenated
lines of pages and columns, like MSO does.

Follow-up to commit 9574a62add8e4901405e12117e75c86c2d2c2f21
"tdf#132599 cui offapi sw xmloff: implement hyphenate-keep".

Change-Id: Ib2a06efc22a4f30d8f8be8a752460b09d09e97a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165798
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/editeng/source/items/paraitem.cxx 
b/editeng/source/items/paraitem.cxx
index 3e99813f628d..4103fe2ea521 100644
--- a/editeng/source/items/paraitem.cxx
+++ b/editeng/source/items/paraitem.cxx
@@ -616,7 +616,7 @@ boolSvxHyphenZoneItem::QueryValue( uno::Any& rVal, 
sal_uInt8 nMemberId ) con
 bool SvxHyphenZoneItem::PutValue( const uno::Any& rVal, sal_uInt8 nMemberId )
 {
 nMemberId &= ~CONVERT_TWIPS;
-sal_Int16 nNewVal = 0;
+sal_Int32 nNewVal = 0; // sal_Int32 needs for MID_HYPHEN_KEEP
 
 if( nMemberId != MID_IS_HYPHEN && nMemberId != MID_HYPHEN_NO_CAPS &&
 nMemberId != MID_HYPHEN_NO_LAST_WORD )
diff --git 
a/sw/qa/extras/ooxmlexport/data/tdf160518_allowHyphenationAtTrackBottom.docx 
b/sw/qa/extras/ooxmlexport/data/tdf160518_allowHyphenationAtTrackBottom.docx
new file mode 100644
index ..61e81cf1f539
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/tdf160518_allowHyphenationAtTrackBottom.docx 
differ
diff --git 
a/sw/qa/extras/ooxmlexport/data/tdf160518_useWord2013TrackBottomHyphenation.docx
 
b/sw/qa/extras/ooxmlexport/data/tdf160518_useWord2013TrackBottomHyphenation.docx
new file mode 100644
index ..26acacc462b3
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/tdf160518_useWord2013TrackBottomHyphenation.docx
 differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
index a045a03407ff..c33275b62394 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
@@ -28,6 +28,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 #include 
 #include 
@@ -1424,6 +1426,68 @@ DECLARE_OOXMLEXPORT_TEST(testTdf159032, 
"tdf124795-5.docx")
 CPPUNIT_ASSERT_EQUAL(57, getPages());
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf160518, 
"tdf160518_useWord2013TrackBottomHyphenation.docx")
+{
+uno::Reference xHyphenator = 
LinguMgr::GetHyphenator();
+if (!xHyphenator->hasLocale(lang::Locale("en", "US", OUString(
+return;
+
+// TODO: fix export too
+if (isExported())
+return;
+// This was 2 (without shifting last hyphenated line of the page)
+CPPUNIT_ASSERT_EQUAL(3, getPages());
+}
+
+DECLARE_OOXMLEXPORT_TEST(testTdf160518_compatible, 
"tdf160518_allowHyphenationAtTrackBottom.docx")
+{
+uno::Reference xHyphenator = 
LinguMgr::GetHyphenator();
+if (!xHyphenator->hasLocale(lang::Locale("en", "US", OUString(
+return;
+
+// TODO: fix export too
+if (isExported())
+return;
+// This is still 2
+CPPUNIT_ASSERT_EQUAL(2, getPages());
+}
+
+DECLARE_OOXMLEXPORT_TEST(testTdf160518_ODT, 
"tdf160518_useWord2013TrackBottomHyphenation.docx")
+{
+uno::Reference xHyphenator = 
LinguMgr::GetHyphenator();
+if (!xHyphenator->hasLocale(lang::Locale("en", "US", OUString(
+return;
+
+// TODO: fix export too
+if (isExported())
+return;
+// This was 2 (without shifting last hyphenated line of the page)
+CPPUNIT_ASSERT_EQUAL(3, getPages());
+
+// check compatibility option in ODT export/import, too
+saveAndReload("writer8");
+
+CPPUNIT_ASSERT_EQUAL(3, getPages());
+}
+
+DECLARE_OOXMLEXPORT_TEST(testTdf160518_ODT_compatible, 

[Bug 60270] LibreOffice 4.1 most annoying bugs

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=60270
Bug 60270 depends on bug 71423, which changed state.

Bug 71423 Summary: Impress frequently crashes when selecting or editing tables 
in slides while styles & formatting dialog is open
https://bugs.documentfoundation.org/show_bug.cgi?id=71423

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160411] Support an "XY+Value" scatter plot chart type

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160411

--- Comment #9 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #7)
> Created attachment 193485 [details]
> Scatter plot with extra data label

In the scatter plot, how do I enable all labels exactly? I see a "reset" which
clears them all.

Selecting the series and right-clicking it doesn't seem to have any option for
showing the labels.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160519] Spellchecker Spanish Language do no correct obvious mistakes in a multi language document

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160519

RGB  changed:

   What|Removed |Added

 CC||rgb.m...@gmail.com

--- Comment #3 from RGB  ---
[Note: native Spanish speaker here] The different between "quien" and "quién"
is grammatical, not orthographic (both are correct in the right context), while
"escribio" *is* an orthographic error: that's why the spellcheck finds the
second problem but not the first one. You need to install a grammar checker
such as LanguageTool in order to detect the "quien" problem. 

[If this solves the issue, please change the status to RESOLVED, NOTABUG]

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 82097] REPORTBUILDER: Group Header keeps the values of the first group

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82097

Hidden Gems Financial  changed:

   What|Removed |Added

URL||https://www.hiddengemsfinan
   ||cial.com/

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'feature/cib_contract49' - 4 commits - include/svx sd/source svx/source sw/source

2024-04-04 Thread Thorsten Behrens (via logerrit)
 include/svx/unoapi.hxx|6 +++
 sd/source/console/PresenterController.cxx |   11 ++
 sd/source/console/PresenterController.hxx |4 ++
 sd/source/console/PresenterScreen.cxx |   51 --
 sd/source/console/PresenterScreen.hxx |5 ++
 sd/source/ui/slideshow/slideshowimpl.cxx  |   17 --
 sd/source/ui/tools/IdleDetection.cxx  |2 -
 svx/source/unodraw/unopage.cxx|   36 +
 sw/source/uibase/docvw/edtwin.cxx |1 
 9 files changed, 126 insertions(+), 7 deletions(-)

New commits:
commit 2643084fa3d9e5c103c35b1329f74abfeefe166d
Author: Thorsten Behrens 
AuthorDate: Thu Apr 4 21:49:44 2024 +0200
Commit: Thorsten Behrens 
CommitDate: Thu Apr 4 21:49:44 2024 +0200

Fixup "improve usability of variable fields"

- bookmark.hxx still needed on this branch

Change-Id: I0941bd7a995b7687cbb3bb75ffb06b3cdb861666

diff --git a/sw/source/uibase/docvw/edtwin.cxx 
b/sw/source/uibase/docvw/edtwin.cxx
index 6ab4cba04698..418d8bf385a0 100644
--- a/sw/source/uibase/docvw/edtwin.cxx
+++ b/sw/source/uibase/docvw/edtwin.cxx
@@ -71,6 +71,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
commit cee3b384d412194960626a4c88929bb573537cb2
Author: Armin Le Grand (allotropia) 
AuthorDate: Thu Mar 28 12:22:12 2024 +0100
Commit: Thorsten Behrens 
CommitDate: Thu Apr 4 21:03:50 2024 +0200

IASS: Update NextSlide in PresenterConsole

Change-Id: I6060e95aabfdb5956bf2f4a71d047bdf5c97a723
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165458
Tested-by: Jenkins
Reviewed-by: Armin Le Grand 

diff --git a/include/svx/unoapi.hxx b/include/svx/unoapi.hxx
index 3107a483579d..6ee2d2cb27c4 100644
--- a/include/svx/unoapi.hxx
+++ b/include/svx/unoapi.hxx
@@ -53,6 +53,12 @@ SVXCORE_DLLPUBLIC css::uno::Reference< 
css::drawing::XDrawPage > GetXDrawPageFor
 /** Returns the SdrPage from the given StarOffice API wrapper */
 SVXCORE_DLLPUBLIC SdrPage* GetSdrPageFromXDrawPage( const css::uno::Reference< 
css::drawing::XDrawPage >& xDrawPage ) noexcept ;
 
+// helper that returns true if the given XShape is member of the given
+// XDrawPage or it's MasterPage (aka associated)
+SVXCORE_DLLPUBLIC bool IsXShapeAssociatedWithXDrawPage(
+const css::uno::Reference& rxShape,
+const css::uno::Reference< css::drawing::XDrawPage >& rxDrawPage) noexcept;
+
 /**
  * Maps the vcl MapUnit enum to an API constant MeasureUnit.
  * Returns false if conversion is not supported.
diff --git a/sd/source/console/PresenterController.cxx 
b/sd/source/console/PresenterController.cxx
index 39ed5506960d..55c0929d8746 100644
--- a/sd/source/console/PresenterController.cxx
+++ b/sd/source/console/PresenterController.cxx
@@ -51,6 +51,7 @@
 #include 
 
 #include 
+#include 
 #include 
 
 using namespace ::com::sun::star;
@@ -402,6 +403,16 @@ void PresenterController::UpdateViews()
 }
 }
 
+void PresenterController::CheckNextSlideUpdate(const 
Reference& rxShape)
+{
+if (!mxNextSlide)
+return;
+
+// check if shape is member of page or it's masterPage
+if(IsXShapeAssociatedWithXDrawPage(rxShape, mxNextSlide))
+UpdateViews();
+}
+
 SharedBitmapDescriptor
 PresenterController::GetViewBackground (const OUString& rsViewURL) const
 {
diff --git a/sd/source/console/PresenterController.hxx 
b/sd/source/console/PresenterController.hxx
index a4d7993eecda..c4a7d22b6096 100644
--- a/sd/source/console/PresenterController.hxx
+++ b/sd/source/console/PresenterController.hxx
@@ -130,6 +130,10 @@ public:
 void HandleMouseClick (const css::awt::MouseEvent& rEvent);
 void UpdatePaneTitles();
 
+// check if the 'NextSlide' needs an update when the given
+// XShape is changed and trigger that update
+void CheckNextSlideUpdate(const css::uno::Reference& 
rxShape);
+
 /** Request activation or deactivation of (some of) the views according
 to the given parameters.
 */
diff --git a/sd/source/console/PresenterScreen.cxx 
b/sd/source/console/PresenterScreen.cxx
index 64e8c8e11e5f..ae2b60448a52 100644
--- a/sd/source/console/PresenterScreen.cxx
+++ b/sd/source/console/PresenterScreen.cxx
@@ -220,6 +220,20 @@ void SAL_CALL PresenterScreenListener::notifyEvent( const 
css::document::EventOb
 mpPresenterScreen = nullptr;
 }
 }
+else if ( Event.EventName == "ShapeModified" )
+{
+if (mpPresenterScreen.is())
+{
+Reference xShape(Event.Source, UNO_QUERY);
+
+if (xShape.is())
+{
+// when presenter is used and shape changes, check
+// and evtl. trigger update of 'NextSlide' view
+mpPresenterScreen->CheckNextSlideUpdate(xShape);
+}
+}
+}
 }
 
 // XEventListener
@@ -432,6 +446,15 @@ void PresenterScreen::SwitchMonitors()
 }
 }
 
+void PresenterScreen::CheckNextSlideUpdate(const Reference& 

[Bug 160301] FILEOPEN: DOC: DOCVARIABLE fields with missing content

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160301

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:24.8.0   |target:24.8.0 target:24.2.3

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - 2 commits - editeng/source sw/inc sw/source

2024-04-04 Thread Oliver Specht (via logerrit)
 editeng/source/editeng/impedit4.cxx |5 
 sw/inc/usrfld.hxx   |2 -
 sw/source/filter/ww8/ww8par.cxx |   43 +---
 sw/source/filter/ww8/ww8par5.cxx|   30 -
 sw/source/uibase/shells/textsh.cxx  |9 +--
 5 files changed, 62 insertions(+), 27 deletions(-)

New commits:
commit 2ae662ed5e2a92ae8c1a2e6b61dcc9b67f94419f
Author: Oliver Specht 
AuthorDate: Thu Mar 21 12:10:40 2024 +0100
Commit: Thorsten Behrens 
CommitDate: Thu Apr 4 21:45:41 2024 +0200

tdf#160301 import DOCVARIABLE fields as user fields

DOCVARIBLE fields in *.doc files are imported as user fields.

Change-Id: Ib723d8a586ca644e0b158f839caef33b2b6225a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165096
Tested-by: Jenkins
Tested-by: Gabor Kelemen 
Reviewed-by: Thorsten Behrens 
(cherry picked from commit ad4b72a0eacf6bb6887236ea3a3807b1264de822)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165721

diff --git a/sw/inc/usrfld.hxx b/sw/inc/usrfld.hxx
index 28d582c4c5ac..f7371ef52c6e 100644
--- a/sw/inc/usrfld.hxx
+++ b/sw/inc/usrfld.hxx
@@ -102,7 +102,7 @@ inline void SwUserFieldType::SetType(sal_uInt16 nSub)
  * Tracks the number format and the language, conversion between the float and
  * string representation is independent from the system locale.
  */
-class SwUserField final : public SwValueField
+class SW_DLLPUBLIC SwUserField final : public SwValueField
 {
 sal_uInt16  m_nSubType;
 
diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index 10ccaa487816..976a68b88a69 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -4808,27 +4809,35 @@ void SwWW8ImplReader::ReadDocVars()
 aDocVarStrings, , );
 if (m_bVer67)return;
 
-uno::Reference xDPS(
-m_pDocShell->GetModel(), uno::UNO_QUERY_THROW);
-uno::Reference xDocProps(
-xDPS->getDocumentProperties());
-OSL_ENSURE(xDocProps.is(), "DocumentProperties is null");
-uno::Reference xUserDefinedProps =
-xDocProps->getUserDefinedProperties();
-OSL_ENSURE(xUserDefinedProps.is(), "UserDefinedProperties is null");
-
-for(size_t i=0; i 
xFieldsSupplier(m_pDocShell->GetModel(), uno::UNO_QUERY_THROW);
+uno::Reference 
xTextFactory(m_pDocShell->GetModel(), uno::UNO_QUERY);
+uno::Reference< container::XNameAccess > xFieldMasterAccess = 
xFieldsSupplier->getTextFieldMasters();
+for(size_t i = 0; i < aDocVarStrings.size(); i++)
 {
 const OUString  = aDocVarStrings[i];
 uno::Any aValue;
-aValue <<= rName;
-try {
-xUserDefinedProps->addProperty( rName,
-beans::PropertyAttribute::REMOVABLE,
-aValue );
-} catch (const uno::Exception &) {
-// ignore
+if (aDocValueStrings.size() > i)
+{
+OUString value = aDocValueStrings[i];
+value = value.replaceAll("
", "
");
+value = value.replaceAll(" ", "
");
+aValue <<= value;
+}
+
+uno::Reference< beans::XPropertySet > xMaster;
+OUString sFieldMasterService("com.sun.star.text.FieldMaster.User." + 
rName);
+
+// Find or create Field Master
+if (xFieldMasterAccess->hasByName(sFieldMasterService))
+{
+xMaster.set(xFieldMasterAccess->getByName(sFieldMasterService), 
uno::UNO_QUERY_THROW);
+}
+else
+{
+
xMaster.set(xTextFactory->createInstance("com.sun.star.text.FieldMaster.User"), 
uno::UNO_QUERY_THROW);
+xMaster->setPropertyValue("Name", uno::Any(rName));
 }
+xMaster->setPropertyValue("Content", aValue);
 }
 }
 
diff --git a/sw/source/filter/ww8/ww8par5.cxx b/sw/source/filter/ww8/ww8par5.cxx
index c87c33dde0e1..6750fa21ae76 100644
--- a/sw/source/filter/ww8/ww8par5.cxx
+++ b/sw/source/filter/ww8/ww8par5.cxx
@@ -58,6 +58,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1831,12 +1832,29 @@ eF_ResT SwWW8ImplReader::Read_F_DocInfo( WW8FieldDesc* 
pF, OUString& rStr )
 aData = aData.replaceAll("\"", "");
 }
 
-const auto pType(static_cast(
-
m_rDoc.getIDocumentFieldsAccess().GetSysFieldType(SwFieldIds::DocInfo)));
-SwDocInfoField aField(pType, nSub|nReg, aData, GetFieldResult(pF), 
nFormat);
-if (bDateTime)
-ForceFieldLanguage(aField, nLang);
-m_rDoc.getIDocumentContentOperations().InsertPoolItem(*m_pPaM, 
SwFormatField(aField));
+bool bDone = false;
+if (DI_CUSTOM == nSub)
+{
+const auto pType(static_cast(
+m_rDoc.getIDocumentFieldsAccess().GetFieldType(SwFieldIds::User, 
aData, false)));
+if (pType)
+{
+SwUserField aField(pType, 0, nFormat);
+if (bDateTime)
+ 

core.git: Branch 'libreoffice-24-2' - editeng/qa editeng/source

2024-04-04 Thread Oliver Specht (via logerrit)
 editeng/qa/unit/core-test.cxx   |   15 +--
 editeng/source/editeng/impedit.hxx  |2 +-
 editeng/source/editeng/impedit2.cxx |4 ++--
 editeng/source/editeng/impedit4.cxx |6 +-
 4 files changed, 9 insertions(+), 18 deletions(-)

New commits:
commit f97dcfaee43f5b8c2eba4c7c3c2d0b786af38bc1
Author: Oliver Specht 
AuthorDate: Thu Mar 7 17:06:54 2024 +0100
Commit: Thorsten Behrens 
CommitDate: Thu Apr 4 21:44:45 2024 +0200

tdf#63259 Cycle case should work on end of words

Now words are selected if the cursor is positioned at the end of
the word. SENTENCE_CASE does not force sentence selection anymore.

Change-Id: I672352b2c18bb695004fd4eb0f20ae5fd7a0ac53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164546
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165799

diff --git a/editeng/qa/unit/core-test.cxx b/editeng/qa/unit/core-test.cxx
index 8d2a6c11d4fc..df9fb6c8ca26 100644
--- a/editeng/qa/unit/core-test.cxx
+++ b/editeng/qa/unit/core-test.cxx
@@ -1863,14 +1863,15 @@ void Test::testTransliterate()
 int selStart = 12;
 int selEnd = 12;
 ESelection esel(0, selStart, 0, selEnd);
+ESelection eSentenSel(0, 0, 0, 25);
 
 /* DocumentContentOperationsManager checks if the cursor is inside of a 
word before transliterating,
  * but Edit Engine has no such check. Therefore, behavior is different 
between these two when the
  * cursor is on a word boundary. */
 
-/* No selection tests. Cursor between the ' ' and 'm' before 'met'. */
+/* No selection tests. Cursor between the ' ' and 'm' before 'met' - 
except in SENTENCE_CASE where the complete sentence is selected.*/
 CPPUNIT_ASSERT_EQUAL(OUString(""), editEng.GetText(esel));
-CPPUNIT_ASSERT_EQUAL(OUString("Mary jones met joe smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::SENTENCE_CASE));
+CPPUNIT_ASSERT_EQUAL(OUString("Mary jones met joe smith. Time Passed."), 
lcl_translitTest(editEng, sText2, eSentenSel, TF::SENTENCE_CASE));
 CPPUNIT_ASSERT_EQUAL(OUString("Mary Jones Met joe Smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::TITLE_CASE));
 CPPUNIT_ASSERT_EQUAL(OUString("Mary Jones MET joe Smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::LOWERCASE_UPPERCASE));
 CPPUNIT_ASSERT_EQUAL(OUString("Mary Jones met joe Smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::UPPERCASE_LOWERCASE));
@@ -1880,9 +1881,8 @@ void Test::testTransliterate()
 selEnd = 14;
 esel = ESelection(0, selStart, 0, selEnd);
 CPPUNIT_ASSERT_EQUAL(OUString(""), editEng.GetText(esel));
-CPPUNIT_ASSERT_EQUAL(OUString("Mary jones met joe smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::SENTENCE_CASE));
-CPPUNIT_ASSERT_EQUAL(OUString("Mary Jones met joe Smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::TITLE_CASE));
-CPPUNIT_ASSERT_EQUAL(OUString("Mary Jones met joe Smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::LOWERCASE_UPPERCASE));
+CPPUNIT_ASSERT_EQUAL(OUString("Mary Jones Met joe Smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::TITLE_CASE));
+CPPUNIT_ASSERT_EQUAL(OUString("Mary Jones MET joe Smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::LOWERCASE_UPPERCASE));
 CPPUNIT_ASSERT_EQUAL(OUString("Mary Jones met joe Smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::UPPERCASE_LOWERCASE));
 
 /* No selection tests. Cursor between the 'h' and the '.' after 'Smith'. */
@@ -1890,7 +1890,6 @@ void Test::testTransliterate()
 selEnd = 24;
 esel = ESelection(0, selStart, 0, selEnd);
 CPPUNIT_ASSERT_EQUAL(OUString(""), editEng.GetText(esel));
-CPPUNIT_ASSERT_EQUAL(OUString("Mary jones met joe smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::SENTENCE_CASE));
 CPPUNIT_ASSERT_EQUAL(OUString("Mary Jones met joe Smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::TITLE_CASE));
 CPPUNIT_ASSERT_EQUAL(OUString("Mary Jones met joe Smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::LOWERCASE_UPPERCASE));
 CPPUNIT_ASSERT_EQUAL(OUString("Mary Jones met joe Smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::UPPERCASE_LOWERCASE));
@@ -1900,7 +1899,6 @@ void Test::testTransliterate()
 selEnd = 12;
 esel = ESelection(0, selStart, 0, selEnd);
 CPPUNIT_ASSERT_EQUAL(OUString(""), editEng.GetText(esel));
-CPPUNIT_ASSERT_EQUAL(OUString("Mary jones met joe smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::SENTENCE_CASE));
 CPPUNIT_ASSERT_EQUAL(OUString("Mary Jones Met joe Smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, TF::TITLE_CASE));
 CPPUNIT_ASSERT_EQUAL(OUString("Mary Jones MET joe Smith. Time Passed."), 
lcl_translitTest(editEng, sText2, esel, 

core.git: officecfg/registry sw/Library_sw.mk sw/source sw/uiconfig sw/UIConfig_swriter.mk

2024-04-04 Thread khushishikhu (via logerrit)
 officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu |   52 +++
 sw/Library_sw.mk |1 
 sw/UIConfig_swriter.mk   |1 
 sw/source/uibase/sidebar/QuickFindPanel.cxx  |  190 +++
 sw/source/uibase/sidebar/QuickFindPanel.hxx  |   42 ++
 sw/source/uibase/sidebar/SwPanelFactory.cxx  |7 
 sw/uiconfig/swriter/ui/sidebarquickfind.ui   |   97 +
 7 files changed, 390 insertions(+)

New commits:
commit 9338f87a6644e9b2309c3a009af096e38fbb107e
Author: khushishikhu 
AuthorDate: Thu Dec 7 14:48:10 2023 +0530
Commit: Jim Raykowski 
CommitDate: Thu Apr 4 20:46:29 2024 +0200

tdf#95405 Sidebar: Quick Find for writer

Implemented the quick find deck on the sidebar of Writer with a 
corresponding panel in it.

Change-Id: Ic4ce6823e11b27b3386e820a657bc5d973e47007
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160500
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
index e038472d704e..291f4dd84153 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
@@ -335,7 +335,28 @@
 
   
 
+  
+
+  Find
+
+
+  FindDeck
+
+
+  private:graphicrepository/cmd/lc_recsearch.png
+
+
+  
+ WriterVariants, any, visible ;
+  
+
+
+  1000
+
+  
+
 
+
 
 
   
@@ -2020,6 +2041,37 @@
 
   
 
+  
+
+  QuickFind
+
+
+  true
+
+
+  QuickFindPanel
+
+
+  FindDeck
+
+
+  
+Writer, any, visible;
+  
+
+
+  
private:resource/toolpanel/SwPanelFactory/QuickFindPanel
+
+
+  300
+
+
+  false
+
+  
+
+
+
 
   
 
diff --git a/sw/Library_sw.mk b/sw/Library_sw.mk
index c8cc2e96814a..872ae8812286 100644
--- a/sw/Library_sw.mk
+++ b/sw/Library_sw.mk
@@ -736,6 +736,7 @@ $(eval $(call gb_Library_add_exception_objects,sw,\
 sw/source/uibase/sidebar/SwPanelFactory \
 sw/source/uibase/sidebar/WriterInspectorTextPanel \
 sw/source/uibase/sidebar/A11yCheckIssuesPanel \
+sw/source/uibase/sidebar/QuickFindPanel \
 sw/source/uibase/table/chartins \
 sw/source/uibase/table/swtablerep \
 sw/source/uibase/table/tablemgr \
diff --git a/sw/UIConfig_swriter.mk b/sw/UIConfig_swriter.mk
index 309eb8666293..27b7248d74e5 100644
--- a/sw/UIConfig_swriter.mk
+++ b/sw/UIConfig_swriter.mk
@@ -291,6 +291,7 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/swriter,\
sw/uiconfig/swriter/ui/sidebarstylepresets \
sw/uiconfig/swriter/ui/sidebartableedit \
sw/uiconfig/swriter/ui/sidebartheme \
+   sw/uiconfig/swriter/ui/sidebarquickfind \
sw/uiconfig/swriter/ui/sortdialog \
sw/uiconfig/swriter/ui/spellmenu \
sw/uiconfig/swriter/ui/splittable \
diff --git a/sw/source/uibase/sidebar/QuickFindPanel.cxx 
b/sw/source/uibase/sidebar/QuickFindPanel.cxx
new file mode 100644
index ..90f428b1ed0c
--- /dev/null
+++ b/sw/source/uibase/sidebar/QuickFindPanel.cxx
@@ -0,0 +1,190 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#include "QuickFindPanel.hxx"
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+using namespace css;
+using namespace std;
+
+const int MinimumPanelWidth = 250;
+
+namespace sw::sidebar
+{
+std::unique_ptr QuickFindPanel::Create(weld::Widget* pParent)
+{
+if (pParent == nullptr)
+throw css::lang::IllegalArgumentException(
+"no parent Window given to QuickFindPanel::Create", nullptr, 0);
+return std::make_unique(pParent);
+}
+
+QuickFindPanel::QuickFindPanel(weld::Widget* pParent)
+: PanelLayout(pParent, "QuickFindPanel", 
"modules/swriter/ui/sidebarquickfind.ui")
+, m_xSearchFindEntry(m_xBuilder->weld_entry("Find"))
+, m_xSearchFindsList(m_xBuilder->weld_tree_view("searchfinds"))
+, m_nRowHeight(m_xSearchFindsList->get_height_rows(4))
+, m_pWrtShell(::GetActiveWrtShell())
+
+{
+m_xContainer->set_size_request(MinimumPanelWidth, -1);
+m_xSearchFindsList->set_size_request(1, m_nRowHeight);
+

core.git: Branch 'feature/cib_contract49' - 3 commits - editeng/source sw/inc sw/Library_sw.mk sw/source sw/uiconfig

2024-04-04 Thread Oliver Specht (via logerrit)
 editeng/source/editeng/impedit4.cxx  |5 +
 sw/Library_sw.mk |1 
 sw/inc/usrfld.hxx|2 
 sw/source/filter/ww8/ww8par.cxx  |   43 ++
 sw/source/filter/ww8/ww8par5.cxx |   30 +--
 sw/source/ui/fldui/flddb.cxx |2 
 sw/source/ui/fldui/flddb.hxx |2 
 sw/source/ui/fldui/fldfunc.cxx   |6 -
 sw/source/ui/fldui/fldfunc.hxx   |6 -
 sw/source/ui/fldui/fldvar.cxx|6 -
 sw/source/ui/fldui/fldvar.hxx|2 
 sw/source/ui/inc/bookmark.hxx|   66 ++-
 sw/source/ui/inc/condedit.hxx|  122 +
 sw/source/ui/inc/regionsw.hxx|  146 ++-
 sw/source/uibase/docvw/edtwin.cxx|1 
 sw/source/uibase/inc/condedit.hxx|   75 -
 sw/source/uibase/shells/textsh.cxx   |9 +-
 sw/source/uibase/utlui/condedit.cxx  |   84 
 sw/uiconfig/swriter/ui/fldvarpage.ui |   34 +---
 19 files changed, 338 insertions(+), 304 deletions(-)

New commits:
commit 1fd0b11e559599afe7399e05e540a95cc75804db
Author: Oliver Specht 
AuthorDate: Thu Mar 21 12:10:40 2024 +0100
Commit: Thorsten Behrens 
CommitDate: Thu Apr 4 19:51:09 2024 +0200

tdf#160301 import DOCVARIABLE fields as user fields

DOCVARIBLE fields in *.doc files are imported as user fields.

Change-Id: Ib723d8a586ca644e0b158f839caef33b2b6225a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165096
Tested-by: Jenkins
Tested-by: Gabor Kelemen 
Reviewed-by: Thorsten Behrens 

diff --git a/sw/inc/usrfld.hxx b/sw/inc/usrfld.hxx
index 28d582c4c5ac..f7371ef52c6e 100644
--- a/sw/inc/usrfld.hxx
+++ b/sw/inc/usrfld.hxx
@@ -102,7 +102,7 @@ inline void SwUserFieldType::SetType(sal_uInt16 nSub)
  * Tracks the number format and the language, conversion between the float and
  * string representation is independent from the system locale.
  */
-class SwUserField final : public SwValueField
+class SW_DLLPUBLIC SwUserField final : public SwValueField
 {
 sal_uInt16  m_nSubType;
 
diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index abd7cf4c0345..efac5960f8ee 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -4808,27 +4809,35 @@ void SwWW8ImplReader::ReadDocVars()
 aDocVarStrings, , );
 if (m_bVer67)return;
 
-uno::Reference xDPS(
-m_pDocShell->GetModel(), uno::UNO_QUERY_THROW);
-uno::Reference xDocProps(
-xDPS->getDocumentProperties());
-OSL_ENSURE(xDocProps.is(), "DocumentProperties is null");
-uno::Reference xUserDefinedProps =
-xDocProps->getUserDefinedProperties();
-OSL_ENSURE(xUserDefinedProps.is(), "UserDefinedProperties is null");
-
-for(size_t i=0; i 
xFieldsSupplier(m_pDocShell->GetModel(), uno::UNO_QUERY_THROW);
+uno::Reference 
xTextFactory(m_pDocShell->GetModel(), uno::UNO_QUERY);
+uno::Reference< container::XNameAccess > xFieldMasterAccess = 
xFieldsSupplier->getTextFieldMasters();
+for(size_t i = 0; i < aDocVarStrings.size(); i++)
 {
 const OUString  = aDocVarStrings[i];
 uno::Any aValue;
-aValue <<= rName;
-try {
-xUserDefinedProps->addProperty( rName,
-beans::PropertyAttribute::REMOVABLE,
-aValue );
-} catch (const uno::Exception &) {
-// ignore
+if (aDocValueStrings.size() > i)
+{
+OUString value = aDocValueStrings[i];
+value = value.replaceAll("
", "
");
+value = value.replaceAll(" ", "
");
+aValue <<= value;
+}
+
+uno::Reference< beans::XPropertySet > xMaster;
+OUString sFieldMasterService("com.sun.star.text.FieldMaster.User." + 
rName);
+
+// Find or create Field Master
+if (xFieldMasterAccess->hasByName(sFieldMasterService))
+{
+xMaster.set(xFieldMasterAccess->getByName(sFieldMasterService), 
uno::UNO_QUERY_THROW);
+}
+else
+{
+
xMaster.set(xTextFactory->createInstance("com.sun.star.text.FieldMaster.User"), 
uno::UNO_QUERY_THROW);
+xMaster->setPropertyValue("Name", uno::Any(rName));
 }
+xMaster->setPropertyValue("Content", aValue);
 }
 }
 
diff --git a/sw/source/filter/ww8/ww8par5.cxx b/sw/source/filter/ww8/ww8par5.cxx
index a5f1d6892fbb..9853bbe8db58 100644
--- a/sw/source/filter/ww8/ww8par5.cxx
+++ b/sw/source/filter/ww8/ww8par5.cxx
@@ -58,6 +58,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1834,12 +1835,29 @@ eF_ResT SwWW8ImplReader::Read_F_DocInfo( WW8FieldDesc* 
pF, OUString& rStr )
 aData = aData.replaceAll("\"", "");
 }
 
-const auto pType(static_cast(
-

core.git: compilerplugins/clang connectivity/source drawinglayer/inc drawinglayer/source include/basic include/unotools odk/examples

2024-04-04 Thread Noel Grandin (via logerrit)
 compilerplugins/clang/unusedenumconstants.readonly.results   |  354 -
 compilerplugins/clang/unusedenumconstants.untouched.results  |  212 
 compilerplugins/clang/unusedenumconstants.writeonly.results  | 2968 
+-
 connectivity/source/drivers/ado/AColumn.cxx  |1 
 connectivity/source/inc/propertyids.hxx  |   38 
 drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx   |1 
 drawinglayer/source/primitive2d/texteffectprimitive2d.cxx|1 
 include/basic/basmgr.hxx |   11 
 include/unotools/itemholderbase.hxx  |2 
 odk/examples/DevelopersGuide/Database/DriverSkeleton/propertyids.cxx |1 
 odk/examples/DevelopersGuide/Database/DriverSkeleton/propertyids.hxx |   22 
 11 files changed, 1804 insertions(+), 1807 deletions(-)

New commits:
commit 1e31403bc8d63f938bebef663fc90bf86b3321ad
Author: Noel Grandin 
AuthorDate: Thu Apr 4 13:55:00 2024 +0200
Commit: Noel Grandin 
CommitDate: Thu Apr 4 19:58:35 2024 +0200

loplugin:unusedenumconstants

Change-Id: I889b4f63e098fecf22ffd4fb98937d62dbdd70b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165791
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/unusedenumconstants.readonly.results 
b/compilerplugins/clang/unusedenumconstants.readonly.results
index 6d82ee1cd1dd..af9a01077c38 100644
--- a/compilerplugins/clang/unusedenumconstants.readonly.results
+++ b/compilerplugins/clang/unusedenumconstants.readonly.results
@@ -1,7 +1,7 @@
-chart2/source/controller/main/DrawCommandDispatch.h:31
-enum DrawCommandID COMMAND_ID_DRAW_TEXT_VERTICAL
-chart2/source/controller/main/DrawCommandDispatch.h:33
-enum DrawCommandID COMMAND_ID_DRAW_CAPTION_VERTICAL
+chart2/source/controller/main/FeatureCommandDispatchBase.hxx:37
+enum ChartCommandID DrawTextVertical
+chart2/source/controller/main/FeatureCommandDispatchBase.hxx:39
+enum ChartCommandID DrawCaptionVertical
 chart2/source/inc/CharacterProperties.hxx:120
 enum chart::CharacterProperties::(unnamed at 
/home/noel/libo-plugin/chart2/source/inc/CharacterProperties.hxx:41:5) 
FAST_PROPERTY_ID_END_CHAR_PROP
 chart2/source/inc/TitleHelper.hxx:49
@@ -36,10 +36,10 @@ chart2/source/view/inc/ShapeFactory.hxx:64
 enum chart::SymbolEnum Symbol_HorizontalBar
 chart2/source/view/inc/ShapeFactory.hxx:65
 enum chart::SymbolEnum Symbol_VerticalBar
-configmgr/source/access.hxx:443
-enum configmgr::Access::(unnamed at 
/home/noel/libo-plugin/configmgr/source/access.hxx:441:5) IS_GROUP_MEMBER
-configmgr/source/access.hxx:443
-enum configmgr::Access::(unnamed at 
/home/noel/libo-plugin/configmgr/source/access.hxx:441:5) IS_SET_MEMBER
+configmgr/source/access.hxx:456
+enum configmgr::Access::(unnamed at 
/home/noel/libo-plugin/configmgr/source/access.hxx:454:5) IS_GROUP_MEMBER
+configmgr/source/access.hxx:456
+enum configmgr::Access::(unnamed at 
/home/noel/libo-plugin/configmgr/source/access.hxx:454:5) IS_SET_MEMBER
 configmgr/source/components.hxx:149
 enum configmgr::Components::ModificationTarget Dconf
 configmgr/source/parsemanager.hxx:43
@@ -56,6 +56,8 @@ dbaccess/source/core/inc/SingleSelectQueryComposer.hxx:71
 enum dbaccess::OSingleSelectQueryComposer::EColumnType SelectColumns
 dbaccess/source/ui/inc/sqlmessage.hxx:56
 enum dbaui::MessBoxStyle DefaultCancel
+drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx:33
+enum drawinglayer::primitive2d::TextEffectStyle2D ReliefEngraved
 drawinglayer/source/tools/emfphelperdata.cxx:63
 enum emfplushelper::(unnamed at 
/home/noel/libo-plugin/drawinglayer/source/tools/emfphelperdata.cxx:61:5) 
WrapModeTile
 drawinglayer/source/tools/emfphelperdata.cxx:64
@@ -536,23 +538,23 @@ emfio/source/reader/wmfreader.cxx:125
 enum (anonymous namespace)::WMFRecords W_META_CREATEBITMAP
 emfio/source/reader/wmfreader.cxx:126
 enum (anonymous namespace)::WMFRecords W_META_CREATEREGION
-extensions/source/update/check/updatehdl.hxx:64
+extensions/source/update/check/updatehdl.hxx:63
 enum UpdateState UPDATESTATE_AUTO_START
-filter/source/msfilter/msdffimp.cxx:179
-enum (anonymous namespace)::OfficeArtBlipRecInstance EMF
 filter/source/msfilter/msdffimp.cxx:180
-enum (anonymous namespace)::OfficeArtBlipRecInstance WMF
+enum (anonymous namespace)::OfficeArtBlipRecInstance EMF
 filter/source/msfilter/msdffimp.cxx:181
-enum (anonymous namespace)::OfficeArtBlipRecInstance PICT
+enum (anonymous namespace)::OfficeArtBlipRecInstance WMF
 filter/source/msfilter/msdffimp.cxx:182
-enum (anonymous namespace)::OfficeArtBlipRecInstance JPEG_RGB
+enum (anonymous namespace)::OfficeArtBlipRecInstance PICT
 filter/source/msfilter/msdffimp.cxx:183
-enum (anonymous namespace)::OfficeArtBlipRecInstance JPEG_CMYK
+enum (anonymous namespace)::OfficeArtBlipRecInstance 

core.git: 2 commits - avmedia/source chart2/source cui/source editeng/source include/avmedia include/comphelper include/editeng include/linguistic include/svl include/svtools include/tools linguistic/

2024-04-04 Thread Noel Grandin (via logerrit)
 avmedia/source/viewer/mediawindow.cxx   |6 -
 chart2/source/view/inc/VDataSeries.hxx  |1 
 chart2/source/view/main/VDataSeries.cxx |5 -
 cui/source/inc/paragrph.hxx |1 
 cui/source/tabpages/paragrph.cxx|6 -
 editeng/source/editeng/editeng.cxx  |5 -
 editeng/source/outliner/outlin2.cxx |5 -
 include/avmedia/mediawindow.hxx |1 
 include/comphelper/componentguard.hxx   |   58 
 include/editeng/editeng.hxx |1 
 include/editeng/outliner.hxx|1 
 include/linguistic/lngprophelp.hxx  |1 
 include/svl/nfengine.hxx|9 --
 include/svl/numformat.hxx   |   17 
 include/svl/poolitem.hxx|8 --
 include/svtools/restartdialog.hxx   |3 
 include/tools/stream.hxx|3 
 linguistic/source/lngprophelp.cxx   |5 -
 sc/inc/interpretercontext.hxx   |2 
 sc/source/core/tool/interpretercontext.cxx  |9 --
 solenv/clang-format/excludelist |1 
 svl/source/numbers/zforlist.cxx |   16 
 svtools/source/control/accessibleruler.cxx  |8 --
 svtools/source/control/accessibleruler.hxx  |4 -
 svtools/source/dialogs/restartdialog.cxx|3 
 svtools/uiconfig/ui/restartdialog.ui|   19 -
 sw/inc/fesh.hxx |1 
 sw/source/core/frmedt/feshview.cxx  |5 -
 toolkit/source/controls/grid/defaultgridcolumnmodel.cxx |1 
 29 files changed, 2 insertions(+), 203 deletions(-)

New commits:
commit f97b1f75bbd7f8a20163716b57c84fc1140e48fa
Author: Noel Grandin 
AuthorDate: Thu Apr 4 11:24:54 2024 +0200
Commit: Noel Grandin 
CommitDate: Thu Apr 4 19:58:23 2024 +0200

RESTART_REASON_MSCOMPATIBLE_FORMS_MENU is dead

removed with
commit 1d4cd39262fb71f72311e33ac2bdb7d925be5d98
Author: Heiko Tietze 
Date:   Thu Sep 14 10:48:46 2023 +0200
Related tdf#157006 - Remove global compatibility options

Change-Id: If24282d2ec7c8d8c6631982b9fe866e3a7df3d69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165790
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/svtools/restartdialog.hxx 
b/include/svtools/restartdialog.hxx
index 7de336c13b90..274b07690d5a 100644
--- a/include/svtools/restartdialog.hxx
+++ b/include/svtools/restartdialog.hxx
@@ -59,9 +59,6 @@ enum RestartReason {
 // For the multi-threaded calculation changes to take effect,
 // %PRODUCTNAME must be restarted:
 RESTART_REASON_THREADING,
-// For restructuring the Form menu,
-// %PRODUCTNAME must be restarted:
-RESTART_REASON_MSCOMPATIBLE_FORMS_MENU,
 // To apply changes, %PRODUCTNAME,
 // %PRODUCTNAME must be restarted:
 RESTART_REASON_UI_CHANGE,
diff --git a/svtools/source/dialogs/restartdialog.cxx 
b/svtools/source/dialogs/restartdialog.cxx
index 8dc4357700ec..f4c838a22fc3 100644
--- a/svtools/source/dialogs/restartdialog.cxx
+++ b/svtools/source/dialogs/restartdialog.cxx
@@ -65,9 +65,6 @@ public:
 case svtools::RESTART_REASON_THREADING:
 reason_ = m_xBuilder->weld_widget("reason_threading");
 break;
-case svtools::RESTART_REASON_MSCOMPATIBLE_FORMS_MENU:
-reason_ = m_xBuilder->weld_widget("reason_mscompatible_formsmenu");
-break;
 case svtools::RESTART_REASON_UI_CHANGE:
 reason_ = m_xBuilder->weld_widget("reason_uichange");
 break;
diff --git a/svtools/uiconfig/ui/restartdialog.ui 
b/svtools/uiconfig/ui/restartdialog.ui
index 05d83c00037e..92115e04d815 100644
--- a/svtools/uiconfig/ui/restartdialog.ui
+++ b/svtools/uiconfig/ui/restartdialog.ui
@@ -243,21 +243,6 @@
 12
   
 
-
-  
-False
-True
-For restructuring the 
Form menu, %PRODUCTNAME must be restarted.
-True
-50
-0
-  
-  
-False
-True
-13
-  
-
 
   
 True
@@ -269,7 +254,7 @@
   
 False
 True
-14
+13
   
 
 
@@ -284,7 +269,7 @@
   
 False
 True
-15
+14
   
 
   
commit 

[Bug 160301] FILEOPEN: DOC: DOCVARIABLE fields with missing content

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160301

--- Comment #4 from Commit Notification 
 ---
Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ad4b72a0eacf6bb6887236ea3a3807b1264de822

tdf#160301 import DOCVARIABLE fields as user fields

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/inc sw/source

2024-04-04 Thread Oliver Specht (via logerrit)
 sw/inc/usrfld.hxx|2 -
 sw/source/filter/ww8/ww8par.cxx  |   43 +++
 sw/source/filter/ww8/ww8par5.cxx |   30 +--
 3 files changed, 51 insertions(+), 24 deletions(-)

New commits:
commit ad4b72a0eacf6bb6887236ea3a3807b1264de822
Author: Oliver Specht 
AuthorDate: Thu Mar 21 12:10:40 2024 +0100
Commit: Thorsten Behrens 
CommitDate: Thu Apr 4 19:47:54 2024 +0200

tdf#160301 import DOCVARIABLE fields as user fields

DOCVARIBLE fields in *.doc files are imported as user fields.

Change-Id: Ib723d8a586ca644e0b158f839caef33b2b6225a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165096
Tested-by: Jenkins
Tested-by: Gabor Kelemen 
Reviewed-by: Thorsten Behrens 

diff --git a/sw/inc/usrfld.hxx b/sw/inc/usrfld.hxx
index 28d582c4c5ac..f7371ef52c6e 100644
--- a/sw/inc/usrfld.hxx
+++ b/sw/inc/usrfld.hxx
@@ -102,7 +102,7 @@ inline void SwUserFieldType::SetType(sal_uInt16 nSub)
  * Tracks the number format and the language, conversion between the float and
  * string representation is independent from the system locale.
  */
-class SwUserField final : public SwValueField
+class SW_DLLPUBLIC SwUserField final : public SwValueField
 {
 sal_uInt16  m_nSubType;
 
diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index b51239d436ac..77f4f2e76be2 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -4806,27 +4807,35 @@ void SwWW8ImplReader::ReadDocVars()
 aDocVarStrings, , );
 if (m_bVer67)return;
 
-uno::Reference xDPS(
-m_pDocShell->GetModel(), uno::UNO_QUERY_THROW);
-uno::Reference xDocProps(
-xDPS->getDocumentProperties());
-OSL_ENSURE(xDocProps.is(), "DocumentProperties is null");
-uno::Reference xUserDefinedProps =
-xDocProps->getUserDefinedProperties();
-OSL_ENSURE(xUserDefinedProps.is(), "UserDefinedProperties is null");
-
-for(size_t i=0; i 
xFieldsSupplier(m_pDocShell->GetModel(), uno::UNO_QUERY_THROW);
+uno::Reference 
xTextFactory(m_pDocShell->GetModel(), uno::UNO_QUERY);
+uno::Reference< container::XNameAccess > xFieldMasterAccess = 
xFieldsSupplier->getTextFieldMasters();
+for(size_t i = 0; i < aDocVarStrings.size(); i++)
 {
 const OUString  = aDocVarStrings[i];
 uno::Any aValue;
-aValue <<= rName;
-try {
-xUserDefinedProps->addProperty( rName,
-beans::PropertyAttribute::REMOVABLE,
-aValue );
-} catch (const uno::Exception &) {
-// ignore
+if (aDocValueStrings.size() > i)
+{
+OUString value = aDocValueStrings[i];
+value = value.replaceAll("
", "
");
+value = value.replaceAll(" ", "
");
+aValue <<= value;
+}
+
+uno::Reference< beans::XPropertySet > xMaster;
+OUString sFieldMasterService("com.sun.star.text.FieldMaster.User." + 
rName);
+
+// Find or create Field Master
+if (xFieldMasterAccess->hasByName(sFieldMasterService))
+{
+xMaster.set(xFieldMasterAccess->getByName(sFieldMasterService), 
uno::UNO_QUERY_THROW);
+}
+else
+{
+
xMaster.set(xTextFactory->createInstance("com.sun.star.text.FieldMaster.User"), 
uno::UNO_QUERY_THROW);
+xMaster->setPropertyValue("Name", uno::Any(rName));
 }
+xMaster->setPropertyValue("Content", aValue);
 }
 }
 
diff --git a/sw/source/filter/ww8/ww8par5.cxx b/sw/source/filter/ww8/ww8par5.cxx
index a5b9f881065e..47cb7e788223 100644
--- a/sw/source/filter/ww8/ww8par5.cxx
+++ b/sw/source/filter/ww8/ww8par5.cxx
@@ -58,6 +58,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1830,12 +1831,29 @@ eF_ResT SwWW8ImplReader::Read_F_DocInfo( WW8FieldDesc* 
pF, OUString& rStr )
 aData = aData.replaceAll("\"", "");
 }
 
-const auto pType(static_cast(
-
m_rDoc.getIDocumentFieldsAccess().GetSysFieldType(SwFieldIds::DocInfo)));
-SwDocInfoField aField(pType, nSub|nReg, aData, GetFieldResult(pF), 
nFormat);
-if (bDateTime)
-ForceFieldLanguage(aField, nLang);
-m_rDoc.getIDocumentContentOperations().InsertPoolItem(*m_pPaM, 
SwFormatField(aField));
+bool bDone = false;
+if (DI_CUSTOM == nSub)
+{
+const auto pType(static_cast(
+m_rDoc.getIDocumentFieldsAccess().GetFieldType(SwFieldIds::User, 
aData, false)));
+if (pType)
+{
+SwUserField aField(pType, 0, nFormat);
+if (bDateTime)
+ForceFieldLanguage(aField, nLang);
+m_rDoc.getIDocumentContentOperations().InsertPoolItem(*m_pPaM, 
SwFormatField(aField));
+bDone = true;
+}
+}
+if (!bDone)
+{
+const auto 

[Bug 160301] FILEOPEN: DOC: DOCVARIABLE fields with missing content

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160301

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160301] FILEOPEN: DOC: DOCVARIABLE fields with missing content

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160301

--- Comment #3 from Gabor Kelemen (allotropia)  ---
Created attachment 193495
  --> https://bugs.documentfoundation.org/attachment.cgi?id=193495=edit
One more with localized characters

attachment 182853 from bug 151370 saved as doc with Word

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160301] FILEOPEN: DOC: DOCVARIABLE fields with missing content

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160301

--- Comment #2 from Gabor Kelemen (allotropia)  ---
Created attachment 193494
  --> https://bugs.documentfoundation.org/attachment.cgi?id=193494=edit
Another example in doc format

attachment 181587 from bug 150267 saved with Word as doc

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160301] FILEOPEN: DOC: DOCVARIABLE fields with missing content

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160301

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 CC||kelem...@ubuntu.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 Blocks||113200


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113200
[Bug 113200] [META] DOC (binary) field bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 113200] [META] DOC (binary) field bugs and enhancements

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113200

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||160301


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160301
[Bug 160301] FILEOPEN: DOC: DOCVARIABLE fields with missing content
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157420] Allow setting a default Date and Time format for fields (see comment 12)

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157420

--- Comment #19 from FaithfulScuff  ---
(In reply to Heiko Tietze from comment #18)
> The UNO command for variable date/time in Writer was added for bug 139141.
> This bug introduced (and reverted) the regression in bug 157337 - macros
> rely on the first item, for some reason.
> 
> I see no need to change the default since you can insert both fix and
> variable per UNO commands (and customize these to your liking).
> 
> (In reply to FaithfulScuff from comment #15)
> > ...being able to define a default format for date and time would be 
> > wonderful.
> Why?

I use Writer to journal, when adding the date it defaults to MM/DD/YY. I use
Wednesday, April 3, 2024 which has to be changed every time I use the shortcut
"command D". IF there is a way to set the default date format for all of writer
I would change that if I had the proper code like mm/dd/yy to get the output I
am looking for.
Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: xmlsecurity/source

2024-04-04 Thread Stephan Bergmann (via logerrit)
 xmlsecurity/source/xmlsec/xmlsec_init.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 64909a84a354a8bee24fc4439a4b3fdeff67cad6
Author: Stephan Bergmann 
AuthorDate: Thu Apr 4 14:40:50 2024 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Apr 4 18:19:45 2024 +0200

Missing include, again

At least the Emscripten build was hit again by what had been fixed with
bddb0d87e809c96ee810de0e553f02bbe158907d "Missing include", after
a0c53ab43840d1c84d7d246b2cbc73c3a8862155 "tdf#146619 Remove unused #includes
from C/C++ files".

Change-Id: I632ab297bc51aa07019e4bb0cb4ef8f6372a1374
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165795
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/xmlsecurity/source/xmlsec/xmlsec_init.cxx 
b/xmlsecurity/source/xmlsec/xmlsec_init.cxx
index 84a7c9c6c368..c8eefe2c3aa0 100644
--- a/xmlsecurity/source/xmlsec/xmlsec_init.cxx
+++ b/xmlsecurity/source/xmlsec/xmlsec_init.cxx
@@ -11,6 +11,7 @@
 
 #include 
 
+#include 
 #include 
 #include 
 #ifdef XMLSEC_CRYPTO_MSCRYPTO


core.git: static/README.wasm.md

2024-04-04 Thread Stephan Bergmann (via logerrit)
 static/README.wasm.md |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 164cb6ac273d34567f19b4e8a0df94efa053703c
Author: Stephan Bergmann 
AuthorDate: Thu Apr 4 16:02:16 2024 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Apr 4 18:14:44 2024 +0200

Drop spurious .delete() calls from example code

...that had been added there accidentally in
27ceca1996809c0f9390d1e9fb95dc7436ef1acf "Rework the Embind mapping of UNO
interfaces"

Change-Id: I390e4b694e95d665f7bc3d62b0f7ba2c887041bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165796
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/static/README.wasm.md b/static/README.wasm.md
index 1abfd39de6c8..006f1409f907 100644
--- a/static/README.wasm.md
+++ b/static/README.wasm.md
@@ -232,7 +232,6 @@ xSimpleText = new css.text.XSimpleText(xText.$query());
 xTextCursor = xSimpleText.createTextCursor();
 xTextRange = new css.text.XTextRange(xTextCursor.$query());
 xTextRange.setString("string here!");
-xSimpleText.delete(); xTextCursor.delete(); xTextRange.delete();
 xModel.delete(); xTextDocument.delete(); xText.delete(); xSimpleText.delete(); 
xTextCursor.delete(); xTextRange.delete();
 ```
 


Re: Error Compiling LibreOffice Core on Debian 12 - x64

2024-04-04 Thread Rene Engelhard

Hi again,

sorry, missed a part of a sentence.

Am 04.04.24 um 18:13 schrieb Rene Engelhard:

This is it. gcc and/or ld got killed from the outside.


...by the OOM killer I guess.

Regards,

Rene


Re: Error Compiling LibreOffice Core on Debian 12 - x64

2024-04-04 Thread Rene Engelhard

Hi,


well..

Am 03.04.24 um 19:45 schrieb Andreas Mantke:

On 2024-03-24 00:17, Andreas Mantke wrote:

I try to compile LibreOffice core on Debian 12 -x64 but the process
ended with an error.

Here the messages in the shell at the end of the build process:

[MOD] unoxml
/builddir/core/filter/source/graphicfilter/icgm/cgmtypes.hxx:108:
warning: type ‘LineType’ violates the C++ One Definition Rule [-Wodr]
   108 | enum LineType   { LT_SOLID = 1, LT_DASH = 2, LT_DOT =
3, LT_DASHDOT = 4, LT_DASHDOTDOT = 5, // Standard
   |
/builddir/core/vcl/inc/regband.hxx:47: note: an enum with different
value name is defined in another translation unit
    47 | enum class LineType { Ascending, Descending };
   |
/builddir/core/filter/source/graphicfilter/icgm/cgmtypes.hxx:108: note:
name ‘LT_SOLID’ differs from name ‘Ascending’ defined in another
translation unit
   108 | enum LineType   { LT_SOLID = 1, LT_DASH = 2, LT_DOT =
3, LT_DASHDOT = 4, LT_DASHDOTDOT = 5, // Standard
   |
/builddir/core/vcl/inc/regband.hxx:47: note: mismatching definition
    47 | enum class LineType { Ascending, Descending };
   |

is only a warning.

g++: fatal error: Getötet signal terminated program lto1
compilation terminated.
lto-wrapper: fatal error: /usr/bin/g++ returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status


This is it. gcc and/or ld got killed from the outside.

Then there are some options which didn't work my git clone on Debian 12:

'--enable-mergelibs' and '--enable-lto'. Maybe also something to
investigate more in depth once I had some free cycles again.


And that is because of this. mergelibs is too big to link on 32bit.

That is a architectural limitation of 32bit archs which is not going to 
go away. Even if you stick 64GB in there one process can just address 4GB.



If I disable all this options above I could successfully build
LibreOffice again.


Unsurprisingly.


Regards,


Rene



[Bug 160522] New: Generating Chart with more than 4 columns selecting stock first than column or bar: only 4 colors

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160522

Bug ID: 160522
   Summary: Generating Chart with more than 4 columns selecting
stock first than column or bar: only 4 colors
   Product: LibreOffice
   Version: 24.2.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bernard.renou...@outlook.fr

Created attachment 193493
  --> https://bugs.documentfoundation.org/attachment.cgi?id=193493=edit
preview with more than 7 columns and only 4 different colors

First, select more than 4 columns to view in a chart.
While generating a chart, in chart wizard we select first or at any time "Stock
chart".
Next, still in the same chart wizard, just with preview chart, without chart,
change to chart Column, bar ...
The result is only 4 colors for the columns : the fourth one is cyan and
repeated for all last columns.
It failed on versions : windows 1124.2.2.2 and lunbuntu 22.04 7.3.7.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: editeng/source sw/source

2024-04-04 Thread Oliver Specht (via logerrit)
 editeng/source/editeng/impedit4.cxx |5 +
 sw/source/uibase/shells/textsh.cxx  |9 ++---
 2 files changed, 11 insertions(+), 3 deletions(-)

New commits:
commit ec5898cb245c68cf116a22b3714408e4a96ee15d
Author: Oliver Specht 
AuthorDate: Tue Mar 19 09:19:38 2024 +0100
Commit: Thorsten Behrens 
CommitDate: Thu Apr 4 17:27:02 2024 +0200

tdf#63259 cycle case on sentences

Cycle case will be applied to the sentence if the cursor is at
a sentence end. Writer now also keeps the word/sentence selection
after case change.

Change-Id: I9dd561775ac612689526bcb118533ba81b5722be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165018
Tested-by: Jenkins
Tested-by: Gabor Kelemen 
Reviewed-by: Thorsten Behrens 

diff --git a/editeng/source/editeng/impedit4.cxx 
b/editeng/source/editeng/impedit4.cxx
index b7e322b68ccd..b7d4be999016 100644
--- a/editeng/source/editeng/impedit4.cxx
+++ b/editeng/source/editeng/impedit4.cxx
@@ -2711,6 +2711,11 @@ EditSelection ImpEditEngine::TransliterateText( const 
EditSelection& rSelection,
 if ( !aSel.HasRange() )
 {
 aSel = SelectWord( aSel, 
css::i18n::WordType::ANYWORD_IGNOREWHITESPACES, true, true );
+if (!aSel.HasRange() && aSel.Min().GetIndex() > 0 &&
+
OUString(".!?").indexOf(aSel.Min().GetNode()->GetChar(aSel.Min().GetIndex() - 
1)) > -1 )
+{
+aSel = SelectSentence(aSel);
+}
 }
 
 // tdf#107176: if there's still no range, just return aSel
diff --git a/sw/source/uibase/shells/textsh.cxx 
b/sw/source/uibase/shells/textsh.cxx
index 5c4713736081..1b1fb47fd1f3 100644
--- a/sw/source/uibase/shells/textsh.cxx
+++ b/sw/source/uibase/shells/textsh.cxx
@@ -885,10 +885,13 @@ void SwTextShell::ExecRotateTransliteration( SfxRequest 
const & rReq )
 }
 else
 {
-rSh.Push(); // save cur cursor
-if ((rSh.IsEndWrd() || rSh.IsStartWord() || rSh.IsInWord()) && 
rSh.SelWrd())
+if (rSh.IsEndSentence())
+{
+rSh.BwdSentence(true);
+rSh.TransliterateText(m_aRotateCase.getNextMode());
+}
+else if ((rSh.IsEndWrd() || rSh.IsStartWord() || rSh.IsInWord()) 
&& rSh.SelWrd())
 rSh.TransliterateText(m_aRotateCase.getNextMode());
-rSh.Pop(SwCursorShell::PopMode::DeleteCurrent);
 }
 }
 }


[Bug 136427] hyperlink with custom protocol handler isn't handled when url ends with .ods or .odt

2024-04-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136427

kolAflash  changed:

   What|Removed |Added

   Assignee|m...@adityaruplaha.me |libreoffice-b...@lists.free
   ||desktop.org
   Keywords|difficultyBeginner, |
   |easyHack, skillCpp  |

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   >