[Bug 160399] Print Preview freezes with whole row merged in large spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=160399 --- Comment #12 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/02b100e8ecbe47bd8d70d81dbefcb24be0501b8b tdf#160399 speed up print preview It will be available in 24.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - writerfilter/source
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 22 +-
1 file changed, 5 insertions(+), 17 deletions(-)
New commits:
commit 4126c6b94e87f7ad2a1aa93d66bbb3edf67ec790
Author: Noel Grandin
AuthorDate: Mon Mar 25 10:39:41 2024 +0200
Commit: Xisco Fauli
CommitDate: Mon Apr 8 16:55:02 2024 +0200
tdf#158556 speedup docx load
If we want to know if an XText is a header/footer object, no need to
loop over the draw objects, we can just query its service name.
Reduces load time from 167s to 97s
Change-Id: I10158c11dd24c4945b3ea6cfed4916717bd4f2f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165269
Tested-by: Noel Grandin
Reviewed-by: Noel Grandin
(cherry picked from commit ab29c857c669bcca3d8eea8a5a9e6ad5eae622d7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165618
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 2b9091452dde..028b4b4c9aee 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -3793,26 +3793,14 @@ void
DomainMapper_Impl::ConvertHeaderFooterToTextFrame(bool bDynamicHeightTop, b
namespace
{
// Determines if the XText content is empty (no text, no shapes, no tables)
-bool isContentEmpty(uno::Reference const& xText,
uno::Reference const& xTextDocument)
+bool isContentEmpty(uno::Reference const& xText)
{
if (!xText.is())
return true; // no XText means it's empty
-uno::Reference
xDrawPageSupplier(xTextDocument, uno::UNO_QUERY);
-auto xDrawPage = xDrawPageSupplier->getDrawPage();
-if (xDrawPage && xDrawPage->hasElements())
-{
-for (sal_Int32 i = 0; i < xDrawPage->getCount(); ++i)
-{
-uno::Reference
xShape(xDrawPage->getByIndex(i), uno::UNO_QUERY);
-if (xShape.is())
-{
-uno::Reference xAnchor = xShape->getAnchor();
-if (xAnchor.is() && xAnchor->getText() == xText)
-return false;
-}
-}
-}
+uno::Reference xTextServiceInfo(xText,
uno::UNO_QUERY);
+if (xTextServiceInfo && xTextServiceInfo->getImplementationName() ==
"SwXHeadFootText")
+return false;
uno::Reference
xEnumAccess(xText->getText(), uno::UNO_QUERY);
uno::Reference xEnum =
xEnumAccess->createEnumeration();
@@ -3959,7 +3947,7 @@ void
DomainMapper_Impl::checkIfHeaderFooterIsEmpty(PagePartType ePagePartType, P
if (!xPageStyle.is())
return;
-bool bEmpty = isContentEmpty(m_aTextAppendStack.top().xTextAppend,
GetTextDocument());
+bool bEmpty = isContentEmpty(m_aTextAppendStack.top().xTextAppend);
if (eType == PageType::FIRST && bEmpty)
{
core.git: Branch 'libreoffice-24-2' - sc/source
sc/source/core/data/table1.cxx | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
New commits:
commit 02b100e8ecbe47bd8d70d81dbefcb24be0501b8b
Author: Noel Grandin
AuthorDate: Thu Mar 28 13:17:50 2024 +0200
Commit: Xisco Fauli
CommitDate: Mon Apr 8 16:54:28 2024 +0200
tdf#160399 speed up print preview
takes time from 11s to 5s for me
Change-Id: Ic874b9168f9caaf697007e586df8499a849ccfd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165460
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit 6931a596350086d52ba32bf8a84cb36fbfdb34d6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165617
Reviewed-by: Xisco Fauli
diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index 93d023f96246..4df5d92ec5e5 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -2091,17 +2091,19 @@ void ScTable::ExtendPrintArea( OutputDevice* pDev,
else
{
// These columns are visible. Check for empty columns.
-for (SCCOL j = i; j <= nLastCol; ++j)
+SCCOL nEmptyCount = 0;
+SCCOL j = i;
+for (; j <= nLastCol; ++j)
{
if ( j >= aCol.size() )
-{
-aSkipCols.setTrue( j, rDocument.MaxCol() );
break;
-}
-if (aCol[j].GetCellCount() == 0)
-// empty
-aSkipCols.setTrue(j,j);
+if (aCol[j].GetCellCount() == 0) // empty
+nEmptyCount++;
}
+if (nEmptyCount)
+aSkipCols.setTrue(i,i+nEmptyCount);
+if ( j >= aCol.size() )
+aSkipCols.setTrue( j, rDocument.MaxCol() );
}
i = nLastCol;
}
[Bug 160399] Print Preview freezes with whole row merged in large spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=160399 Commit Notification changed: What|Removed |Added Whiteboard|target:24.8.0 |target:24.8.0 target:24.2.3 -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - sc/source
sc/source/core/data/documen9.cxx |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) New commits: commit 8f53eb5dc5cc7f90a2b134c5b5ad66988bcc9842 Author: Noel Grandin AuthorDate: Thu Mar 28 13:25:10 2024 +0200 Commit: Xisco Fauli CommitDate: Mon Apr 8 16:52:53 2024 +0200 tdf#160399 speed up print preview takes time from 5s to 2.5s for me Change-Id: I7e62e4a47d5b2aae982273cc3ea38c5c9b04256d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165461 Tested-by: Jenkins Reviewed-by: Noel Grandin (cherry picked from commit 3819e4f6f70ee60fc5c805f0d33c0062a396918c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165616 Reviewed-by: Xisco Fauli diff --git a/sc/source/core/data/documen9.cxx b/sc/source/core/data/documen9.cxx index a9f04943c0d1..ee72637fa9da 100644 --- a/sc/source/core/data/documen9.cxx +++ b/sc/source/core/data/documen9.cxx @@ -440,13 +440,8 @@ bool ScDocument::IsPrintEmpty( SCCOL nStartCol, SCROW nStartRow, // keep vertical part of aMMRect, only update horizontal position aMMRect = *pLastMM; -tools::Long nLeft = 0; -SCCOL i; -for (i=0; i
[Bug 160586] New: LibreOffice 7.6 does not load under Windows 10 64 bit.
https://bugs.documentfoundation.org/show_bug.cgi?id=160586 Bug ID: 160586 Summary: LibreOffice 7.6 does not load under Windows 10 64 bit. Product: LibreOffice Version: 7.6.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 510jrb2...@gmail.com Description: When I updated libreOffice to 7.6 and installed it with the Windows installer, then restarted the computer, the link to 7.6 would not install. Neither would any of my .odt files load. This looks like a serious problem since I followed all the instructions in the download site and the Windows installer. Steps to Reproduce: 1.open Windows 10 2.Click on the icon 3.Click on the Open tab Nothing happens. Actual Results: Windows appears to start the load then stops soon afterword Expected Results: LO should load as usual Reproducible: Always User Profile Reset: No Additional Info: Is it a software problem or a problem with the Windows 10 interface? Note for userprofile. I cannot open the LO so I cannot check the userprofile from within LO. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 101704] Allow extensions to register their own button within a tab in the Notebookbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101704 --- Comment #13 from Sassitude --- I completely agree with your point. Providing more APIs for extensions to register buttons within existing tabs would indeed offer greater flexibility to developers. This would allow them to integrate their features more seamlessly into the user interface, enhancing the user experience. It's a suggestion that the LO development team should definitely consider. https://geometry-free.com -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160585] Mozilla ARchive (mar) on Win builds not correcting build version in the Win appwiz.cpl
https://bugs.documentfoundation.org/show_bug.cgi?id=160585 --- Comment #3 from Mike Kaganski --- See bug 68274 comment 34. This was anticipated; and the cosmetic issue of wrong displayed version is just a minor thing - much more severe will be modifying / repairing the installation. And I see no way of handling that - given that it's only possible using MSI mechanism, and we don't use that in the MAR technology (which isn't an issue for Mozilla, which never used MSI). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160585] Mozilla ARchive (mar) on Win builds not correcting build version in the Win appwiz.cpl
https://bugs.documentfoundation.org/show_bug.cgi?id=160585 --- Comment #2 from V Stuart Foote --- Created attachment 193568 --> https://bugs.documentfoundation.org/attachment.cgi?id=193568=edit the windows registry installer key for LO after MAR update The LO install Windows registry stanzas following MAR update from 24.2.0.3 install to 24.2.2.1 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160585] Mozilla ARchive (mar) on Win builds not correcting build version in the Win appwiz.cpl
https://bugs.documentfoundation.org/show_bug.cgi?id=160585 --- Comment #1 from V Stuart Foote --- Created attachment 193567 --> https://bugs.documentfoundation.org/attachment.cgi?id=193567=edit the windows registry uninstaller key for LO after MAR update The LO uninstall Windows registry stanzas following MAR update from 24.2.0.3 install to 24.2.2.1 -- You are receiving this mail because: You are the assignee for the bug.
core.git: sc/inc sc/qa sc/source
sc/inc/table.hxx |2 -
sc/qa/uitest/data/tdf160104.ods|binary
sc/qa/uitest/solver/solver.py | 57 +
sc/qa/unit/data/ods/SolverModel.ods|binary
sc/qa/unit/ucalc_solver.cxx| 24 +
sc/source/core/data/SolverSettings.cxx |3 +
6 files changed, 85 insertions(+), 1 deletion(-)
New commits:
commit 2533960315607bf3e86ad014d2daa4bfa7e3fa59
Author: Rafael Lima
AuthorDate: Mon Apr 1 14:46:35 2024 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Apr 8 16:03:03 2024 +0200
tdf#160064 Hide named ranges/expressions of solver models
Prior to this patch, all named ranges/expressions associated with solver
models were visible by default, which clutters the UI with various names in the
Manage Names dialog.
Now all such named ranges/expressions are hidden by default, thus mimicking
what MSO does.
Change-Id: I79727b375c48527632c4967d174c61f99ff41050
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165621
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index f04b1fa0df7a..f578926535ae 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -1047,7 +1047,7 @@ public:
const ScObjectHandling eObjectHandling =
ScObjectHandling::RecalcPosMode);
void SetRangeName(std::unique_ptr pNew);
-ScRangeName* GetRangeName() const;
+SC_DLLPUBLIC ScRangeName* GetRangeName() const;
void PreprocessRangeNameUpdate(
sc::EndListeningContext& rEndListenCxt, sc::CompileFormulaContext&
rCompileCxt );
diff --git a/sc/qa/uitest/data/tdf160104.ods b/sc/qa/uitest/data/tdf160104.ods
index a98340f80a50..ea8f23bb4791 100644
Binary files a/sc/qa/uitest/data/tdf160104.ods and
b/sc/qa/uitest/data/tdf160104.ods differ
diff --git a/sc/qa/uitest/solver/solver.py b/sc/qa/uitest/solver/solver.py
index 2a164b90f6c5..ed8132b0f205 100644
--- a/sc/qa/uitest/solver/solver.py
+++ b/sc/qa/uitest/solver/solver.py
@@ -132,4 +132,61 @@ class solver(UITestCase):
# Here isModified needs to be True because changes were made to
the Solver dialog
self.assertTrue(calc_doc.isModified())
+
+# Tests whether all solver named ranges are hidden in the UI
+def test_tdf160064(self):
+# This test uses the same file from bug tdf#160104, so no need to
check if the model is correct upon opening
+with self.ui_test.load_file(get_url_for_data_file("tdf160104.ods")) as
calc_doc:
+# The Manage Names dialog must not contain any names
+with
self.ui_test.execute_dialog_through_command(".uno:DefineName") as xDialog:
+xList = xDialog.getChild("names")
+self.assertEqual('0', get_state_as_dict(xList)['Children'])
+
+# Makes a small change in the solver dialog by clicking the
"Minimize" button
+with
self.ui_test.execute_modeless_dialog_through_command(".uno:SolverDialog",
close_button="") as xDialog:
+xMin = xDialog.getChild("min")
+xMin.executeAction("CLICK", ())
+# Closes the dialog
+xCloseBtn = xDialog.getChild("close")
+xCloseBtn.executeAction("CLICK", ())
+
+# Here the file has been modified and needs to be saved and
reloaded
+self.assertTrue(calc_doc.isModified())
+self.xUITest.executeCommand('.uno:Save')
+self.xUITest.executeCommand('.uno:Reload')
+
+# Open the Solver dialog and check whether the model is loaded
correctly
+with
self.ui_test.execute_modeless_dialog_through_command(".uno:SolverDialog",
close_button="") as xDialog:
+xTargetEdit = xDialog.getChild("targetedit")
+xMin = xDialog.getChild("min")
+xChangeEdit = xDialog.getChild("changeedit")
+xRef1Edit = xDialog.getChild("ref1edit")
+xVal1Edit = xDialog.getChild("val1edit")
+xOp1List = xDialog.getChild("op1list")
+xRef2Edit = xDialog.getChild("ref2edit")
+xVal2Edit = xDialog.getChild("val2edit")
+xOp2List = xDialog.getChild("op2list")
+
+# Checks whether the solver model was loaded correctly
+self.assertEqual("$F$2",
get_state_as_dict(xTargetEdit)["Text"])
+self.assertEqual("true", get_state_as_dict(xMin)["Checked"])
+self.assertEqual("$D$2:$D$11",
get_state_as_dict(xChangeEdit)["Text"])
+self.assertEqual("$F$5", get_state_as_dict(xRef1Edit)["Text"])
+self.assertEqual("$F$8", get_state_as_dict(xVal1Edit)["Text"])
+self.assertEqual("≤",
get_state_as_dict(xOp1List)["SelectEntryText"])
+self.assertEqual("$D$2:$D$11",
get_state_as_dict(xRef2Edit)["Text"])
+self.assertEqual("",
[Bug 160585] Mozilla ARchive (mar) on Win builds not correcting build version in the Win appwiz.cpl
https://bugs.documentfoundation.org/show_bug.cgi?id=160585 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=68 ||274 CC||mikekagan...@hotmail.com, ||sberg@gmail.com, ||vsfo...@libreoffice.org Blocks||54242 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=54242 [Bug 54242] [META] Incremental update + automatic update support -- You are receiving this mail because: You are the assignee for the bug.
[Bug 54242] [META] Incremental update + automatic update support
https://bugs.documentfoundation.org/show_bug.cgi?id=54242 V Stuart Foote changed: What|Removed |Added Depends on||160585 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160585 [Bug 160585] Mozilla ARchive (mar) on Win builds not correcting build version in the Win appwiz.cpl -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160585] New: Mozilla ARchive (mar) on Win builds not correcting build version in the Win appwiz.cpl
https://bugs.documentfoundation.org/show_bug.cgi?id=160585 Bug ID: 160585 Summary: Mozilla ARchive (mar) on Win builds not correcting build version in the Win appwiz.cpl Product: LibreOffice Version: 24.2.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vsfo...@libreoffice.org Mozilla ARchive (mar) on Win builds not correcting build version in the Win appwiz.cpl A new install of 24.2.0.3 with a 'setx LIBO_UPDATER_TEST_ENABLE "1" /M' applied, will perform MAR update cycle on initial launch. Currently from 24.2.0.3 --> 24.2.2.1 (bf759d8), but stops there. Is the 24.2.2.2 final not yet processing? Beyond that, opening the Windows "Programs and Features" dialog (appwiz.cpl from cmd prompt) the updated LibreOffice install is still 'Named' LibreOffice 24.2.0.3 from the initial package install, but also continues to show 'Version' 24.2.0.3 which is not helpful. Other MAR updated programs, e.g. Firefox or Thunderbird, record and show the current 'Version' on the appwiz panel and in the Windows registry. Panel clips for the Windows registry install and uninstall keys attached. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160495] FILESAVE, FORMATTING
https://bugs.documentfoundation.org/show_bug.cgi?id=160495 --- Comment #2 from s.un...@checkpointmedia.com --- Created attachment 193566 --> https://bugs.documentfoundation.org/attachment.cgi?id=193566=edit testfile with line break over problem in combined cells Hello, please find a testfile with the line break over problem enclosed. Please have a look at the combined cells in the 'print range' marked area. If the the format is corrected by using the line break over button all seems fine. But once the file is saved and opened again with the latest LE version 24.2.2 (and 24.2.1) the line breakovers are gone again. If an older file is opened all the line breakovers are missing too. One can correct that by touching up all cells, but the changes are lost on reopening too. I reverted back to 7.6.4.1 for now as I need the software for daily work. Hence this version is not having that issue I can not test this behaviour currently. Best regards -- You are receiving this mail because: You are the assignee for the bug.
core.git: sc/qa sc/source
sc/qa/unit/data/ods/tdf160369_groupshape.ods |binary
sc/qa/unit/scshapetest.cxx | 68 +++
sc/source/core/data/drwlayer.cxx |4 +
sc/source/filter/xml/xmlexprt.cxx| 41 +++-
4 files changed, 100 insertions(+), 13 deletions(-)
New commits:
commit 1e1b1d46155163380252093d9d2868351236ce0e
Author: Regina Henschel
AuthorDate: Sat Apr 6 14:59:38 2024 +0200
Commit: Regina Henschel
CommitDate: Mon Apr 8 15:50:40 2024 +0200
tdf#160369 Do not broadcast temporarily group change
The position and size of a group needs to be temporarily changed when
saving because ODF does not treat hidden rows/cols as zero, but LO does.
After saving, these changes have to be undone. The error was that the
restore was performed with GetGeoDate/SetGeoData. But SetGeoData
includes a broadcast that triggeres recalculations that should not be
performed here. Now the change and restore are both done with NbcMove
and NbcResize.
The import had set a 'logical rectangle', but that is nonsense for a
group, because a group does not have a 'logical rectangle'.
For a group, none of the special corrections in
ScDrawLayer::InitializeCellAnchoredObj are needed.
Change-Id: I00adf39e8302492822d2900e41242d188e84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165872
Tested-by: Jenkins
Reviewed-by: Regina Henschel
diff --git a/sc/qa/unit/data/ods/tdf160369_groupshape.ods
b/sc/qa/unit/data/ods/tdf160369_groupshape.ods
new file mode 100644
index ..8c26fe8ce582
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf160369_groupshape.ods differ
diff --git a/sc/qa/unit/scshapetest.cxx b/sc/qa/unit/scshapetest.cxx
index 98e98aee54f7..5aa24ede6ea6 100644
--- a/sc/qa/unit/scshapetest.cxx
+++ b/sc/qa/unit/scshapetest.cxx
@@ -1227,6 +1227,74 @@ CPPUNIT_TEST_FIXTURE(ScShapeTest,
testTdf160003_copy_page_anchored)
CPPUNIT_ASSERT_EQUAL(size_t(1), pPage->GetObjCount());
}
+CPPUNIT_TEST_FIXTURE(ScShapeTest, testTdf160369_groupshape)
+{
+// The document contains a group spanning range C5:F12. It is currently
anchored to page to
+// make sure its position does not change. When the group was anchored 'To
Cell' and rows or
+// columns were hidden before the group, saving changed the anchor
position and anchor
+// offset. This happened both with using 'resize with cell' and not.
+createScDoc("ods/tdf160369_groupshape.ods");
+
+// Get document and group object
+ScDocument* pDoc = getScDoc();
+SdrObject* pObj = lcl_getSdrObjectWithAssert(*pDoc, 0);
+
+// Anchor group 'To Cell (resize with cell)' to prepare the test.
+ScDrawLayer::SetCellAnchoredFromPosition(*pObj, *pDoc, 0 /*SCTAB*/, true
/*bResizeWithCell*/);
+
+// Hide rows 3 and 4 (UI number), which are before the group
+// Hide column D, which is inside the group
+pDoc->SetRowHidden(2, 3, 0, true);
+pDoc->SetDrawPageSize(0); // trigger recalcpos, otherwise shapes are not
changed
+pDoc->SetColHidden(3, 3, 0, true);
+pDoc->SetDrawPageSize(0);
+
+// Get geometry of the group
+ScDrawObjData* pObjData = ScDrawLayer::GetObjData(pObj);
+ScAddress aOrigStart = (*pObjData).maStart;
+ScAddress aOrigEnd = (*pObjData).maEnd;
+tools::Rectangle aOrigRect = pObj->GetSnapRect();
+
+// Save document but do not reload. Saving alone had already caused the
error.
+save("calc8");
+
+// Get geometry of the group again
+ScDrawObjData* pAfterObjData = ScDrawLayer::GetObjData(pObj);
+ScAddress aAfterStart = (*pAfterObjData).maStart;
+ScAddress aAfterEnd = (*pAfterObjData).maEnd;
+tools::Rectangle aAfterRect = pObj->GetSnapRect();
+
+// verify Orig equals After
+CPPUNIT_ASSERT_EQUAL(aOrigStart, aAfterStart);
+CPPUNIT_ASSERT_EQUAL(aOrigEnd, aAfterEnd);
+CPPUNIT_ASSERT_RECTANGLE_EQUAL_WITH_TOLERANCE(aOrigRect, aAfterRect, 1);
+
+// The same but with saveAndReload.
+createScDoc("ods/tdf160369_groupshape.ods");
+pDoc = getScDoc();
+pObj = lcl_getSdrObjectWithAssert(*pDoc, 0);
+ScDrawLayer::SetCellAnchoredFromPosition(*pObj, *pDoc, 0 /*SCTAB*/, true
/*bResizeWithCell*/);
+pDoc->SetRowHidden(2, 3, 0, true);
+pDoc->SetDrawPageSize(0); // trigger recalcpos, otherwise shapes are not
changed
+pDoc->SetColHidden(3, 3, 0, true);
+pDoc->SetDrawPageSize(0);
+
+saveAndReload("calc8");
+
+// Verify geometry is same as before save
+pDoc = getScDoc();
+pObj = lcl_getSdrObjectWithAssert(*pDoc, 0);
+pAfterObjData = ScDrawLayer::GetObjData(pObj);
+aAfterStart = (*pAfterObjData).maStart;
+aAfterEnd = (*pAfterObjData).maEnd;
+aAfterRect = pObj->GetSnapRect();
+
+// verify Orig equals After
+CPPUNIT_ASSERT_EQUAL(aOrigStart, aAfterStart);
+CPPUNIT_ASSERT_EQUAL(aOrigEnd, aAfterEnd);
+CPPUNIT_ASSERT_RECTANGLE_EQUAL_WITH_TOLERANCE(aOrigRect, aAfterRect, 1);
[Bug 89606] [META] Table of Contents and Indexes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=89606 Bug 89606 depends on bug 160067, which changed state. Bug 160067 Summary: Fileopen: table of content missformatted (wrapped to next page without visible reason) https://bugs.documentfoundation.org/show_bug.cgi?id=160067 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160182] Short cut to next page (ELEMENT)
https://bugs.documentfoundation.org/show_bug.cgi?id=160182 --- Comment #5 from jeffreyreed...@gmail.com --- Thank you Dieter for your efforts. I understand why you could not confirm, I believe. I got the issue "almost" resolved by adjusting the size to be undersized. I say "almost" because it doesn't seem to be an appropriate parameter to effect the process. I did this on a Mac Mini M2 running Sonoma. I don't think it is a Mac issue only but it could be. I have successfully gotten 10 files to work. I don't know if it is worth any additional effort. I have 40 more files to adjust and if I have another issue T will submit another bug report, or amend this, if I can find it. Thank you for your help Jeff Reed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160458] Char unveiled in Calc and Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=160458 --- Comment #6 from Marc Cabana --- Created attachment 193565 --> https://bugs.documentfoundation.org/attachment.cgi?id=193565=edit Strange char in input bar Menu->Insert->Special char looks like this! Strange char in input bar -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160458] Char unveiled in Calc and Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=160458 --- Comment #5 from Marc Cabana --- (In reply to m_a_riosv from comment #4) > You can use Menu/Insert/Special character > > Also introducing the hexadecimal code plus [Alt+X] > 2713+[Alt+X] > > https://help.libreoffice.org/24.8/en-US/text/shared/01/0410. > html?=CALC=WIN > https://help.libreoffice.org/24.8/en-US/text/shared/04/0101. > html?=CALC=WIN#unicode_shortcut I'm using a MacBook so I'm in MacOS! Visibily all chars are confused Look to the capture of the april 8th! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146619] Remove unused #includes from C/C++ files
https://bugs.documentfoundation.org/show_bug.cgi?id=146619 --- Comment #75 from Commit Notification --- Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c7362f365b7d4699740729e6bf263e1217577797 tdf#146619 Drop unused 'using namespace' in: filter/ It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146619] Remove unused #includes from C/C++ files
https://bugs.documentfoundation.org/show_bug.cgi?id=146619 --- Comment #74 from Commit Notification --- Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6b4552e325b38748cb75d3df269082fb8a38751a tdf#146619 Drop unused 'using namespace' in: editeng/ It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: filter/source
filter/source/odfflatxml/OdfFlatXml.cxx |2 -- filter/source/pdf/pdfexport.cxx |1 - filter/source/svg/svgexport.cxx |2 +- filter/source/svg/svgwriter.cxx |1 + filter/source/svg/svgwriter.hxx |1 - filter/source/t602/t602filter.cxx |2 -- filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx |1 - filter/source/xsltdialog/xmlfilterdialogcomponent.cxx |2 -- filter/source/xsltdialog/xmlfiltertabpagexslt.cxx |3 --- filter/source/xsltfilter/XSLTFilter.cxx |1 - 10 files changed, 2 insertions(+), 14 deletions(-) New commits: commit c7362f365b7d4699740729e6bf263e1217577797 Author: Gabor Kelemen AuthorDate: Fri Mar 29 14:09:58 2024 +0100 Commit: Gabor Kelemen CommitDate: Mon Apr 8 15:10:16 2024 +0200 tdf#146619 Drop unused 'using namespace' in: filter/ Change-Id: Id7801c4690b9f095f7f246e8b3a2072c24e6e58c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165544 Tested-by: Jenkins Reviewed-by: Gabor Kelemen diff --git a/filter/source/odfflatxml/OdfFlatXml.cxx b/filter/source/odfflatxml/OdfFlatXml.cxx index 4c838ab5f40e..755f14ec6be2 100644 --- a/filter/source/odfflatxml/OdfFlatXml.cxx +++ b/filter/source/odfflatxml/OdfFlatXml.cxx @@ -38,13 +38,11 @@ #include using namespace ::cppu; -using namespace ::osl; using namespace ::sax; using namespace ::com::sun::star::beans; using namespace ::com::sun::star::io; using namespace ::com::sun::star::uno; using namespace ::com::sun::star::lang; -using namespace ::com::sun::star::registry; using namespace ::com::sun::star::xml; using namespace ::com::sun::star::xml::sax; diff --git a/filter/source/pdf/pdfexport.cxx b/filter/source/pdf/pdfexport.cxx index a73d122282e1..03ecbf576c56 100644 --- a/filter/source/pdf/pdfexport.cxx +++ b/filter/source/pdf/pdfexport.cxx @@ -75,7 +75,6 @@ using namespace ::com::sun::star::uno; using namespace ::com::sun::star::lang; using namespace ::com::sun::star::beans; using namespace ::com::sun::star::view; -using namespace ::com::sun::star::graphic; PDFExport::PDFExport( const Reference< XComponent >& rxSrcDoc, diff --git a/filter/source/svg/svgexport.cxx b/filter/source/svg/svgexport.cxx index d2a42321cf02..c6325f282a2e 100644 --- a/filter/source/svg/svgexport.cxx +++ b/filter/source/svg/svgexport.cxx @@ -74,7 +74,7 @@ using namespace css::animations; using namespace css::presentation; using namespace ::com::sun::star::graphic; -using namespace ::com::sun::star::geometry; +using namespace ::com::sun::star::style; using namespace ::com::sun::star; using namespace ::xmloff::token; diff --git a/filter/source/svg/svgwriter.cxx b/filter/source/svg/svgwriter.cxx index e2079304abbc..adfdda948f76 100644 --- a/filter/source/svg/svgwriter.cxx +++ b/filter/source/svg/svgwriter.cxx @@ -52,6 +52,7 @@ #include +using namespace ::com::sun::star::style; constexpr OUString aPrefixClipPathId = u"clip_path_"_ustr; diff --git a/filter/source/svg/svgwriter.hxx b/filter/source/svg/svgwriter.hxx index 85c931fb1763..1bcf8a87b4c9 100644 --- a/filter/source/svg/svgwriter.hxx +++ b/filter/source/svg/svgwriter.hxx @@ -47,7 +47,6 @@ using namespace ::com::sun::star::uno; using namespace ::com::sun::star::container; using namespace ::com::sun::star::lang; using namespace ::com::sun::star::text; -using namespace ::com::sun::star::style; using namespace ::com::sun::star::svg; using namespace ::com::sun::star::xml::sax; diff --git a/filter/source/t602/t602filter.cxx b/filter/source/t602/t602filter.cxx index d97bc3d5e5de..e215b465b925 100644 --- a/filter/source/t602/t602filter.cxx +++ b/filter/source/t602/t602filter.cxx @@ -37,11 +37,9 @@ #include using namespace ::cppu; -using namespace ::osl; using namespace ::com::sun::star; using namespace ::com::sun::star::uno; using namespace ::com::sun::star::lang; -using namespace ::com::sun::star::registry; using namespace ::com::sun::star::container; using namespace ::com::sun::star::beans; using namespace ::com::sun::star::awt; diff --git a/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx b/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx index 525f567b67c0..1f246433a4ae 100644 --- a/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx +++ b/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx @@ -48,7 +48,6 @@ using namespace comphelper; using namespace com::sun::star::uno; using namespace com::sun::star::lang; -using namespace com::sun::star::io; using namespace com::sun::star::beans; using namespace com::sun::star::container; using namespace com::sun::star::document; diff --git a/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx b/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx index 5cf047d07e41..64b02feb2d78 100644 --- a/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx +++
[Bug 146619] Remove unused #includes from C/C++ files
https://bugs.documentfoundation.org/show_bug.cgi?id=146619 --- Comment #73 from Commit Notification --- Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7f2af61f1a4771f6f823c378f355ee4989a719e4 tdf#146619 Drop unused 'using namespace' in: extensions/ It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - editeng/source extensions/source
editeng/source/editeng/edtspell.cxx |1 - editeng/source/editeng/textconv.cxx |2 -- editeng/source/items/xmlcnitm.cxx|1 - editeng/source/misc/splwrap.cxx |1 - editeng/source/misc/unolingu.cxx |1 - editeng/source/xml/xmltxtexp.cxx |2 -- editeng/source/xml/xmltxtimp.cxx |2 -- extensions/source/abpilot/abpfinalpage.cxx |4 extensions/source/abpilot/abspage.cxx|1 - extensions/source/abpilot/abspilot.cxx |1 - extensions/source/abpilot/admininvokationimpl.cxx|1 - extensions/source/abpilot/unodialogabp.cxx |1 - extensions/source/bibliography/bibconfig.cxx |1 - extensions/source/bibliography/bibcont.cxx |1 - extensions/source/bibliography/bibmod.cxx|4 extensions/source/bibliography/bibview.cxx |1 - extensions/source/dbpilots/commonpagesdbp.cxx|1 - extensions/source/dbpilots/controlwizard.cxx |1 - extensions/source/dbpilots/gridwizard.cxx|1 - extensions/source/dbpilots/groupboxwiz.cxx |1 - extensions/source/dbpilots/listcombowizard.cxx |1 - extensions/source/propctrlr/MasterDetailLinkDialog.cxx |1 - extensions/source/propctrlr/buttonnavigationhandler.cxx |3 --- extensions/source/propctrlr/cellbindinghandler.cxx |1 - extensions/source/propctrlr/cellbindinghelper.cxx|1 - extensions/source/propctrlr/controlfontdialog.cxx|1 - extensions/source/propctrlr/editpropertyhandler.cxx |2 -- extensions/source/propctrlr/eformspropertyhandler.cxx|1 - extensions/source/propctrlr/formcomponenthandler.cxx |1 - extensions/source/propctrlr/formlinkdialog.cxx |1 - extensions/source/propctrlr/pcrcommon.cxx|3 --- extensions/source/propctrlr/pcrunodialogs.cxx|1 - extensions/source/propctrlr/propcontroller.cxx |2 -- extensions/source/propctrlr/propertyhandler.cxx |1 - extensions/source/propctrlr/submissionhandler.cxx|2 -- extensions/source/propctrlr/xsdvalidationpropertyhandler.cxx |2 -- extensions/source/update/check/updatecheck.cxx |1 - 37 files changed, 54 deletions(-) New commits: commit 6b4552e325b38748cb75d3df269082fb8a38751a Author: Gabor Kelemen AuthorDate: Fri Mar 29 14:06:23 2024 +0100 Commit: Gabor Kelemen CommitDate: Mon Apr 8 15:10:01 2024 +0200 tdf#146619 Drop unused 'using namespace' in: editeng/ Change-Id: Ifbad3b15b462a0586eda219f16698d0b42109832 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165535 Tested-by: Jenkins Reviewed-by: Gabor Kelemen diff --git a/editeng/source/editeng/edtspell.cxx b/editeng/source/editeng/edtspell.cxx index 514e70f93025..b989755d8be4 100644 --- a/editeng/source/editeng/edtspell.cxx +++ b/editeng/source/editeng/edtspell.cxx @@ -32,7 +32,6 @@ #include using namespace com::sun::star::uno; -using namespace com::sun::star::beans; using namespace com::sun::star::linguistic2; diff --git a/editeng/source/editeng/textconv.cxx b/editeng/source/editeng/textconv.cxx index 0534d3420cc4..3d4c03e1ddeb 100644 --- a/editeng/source/editeng/textconv.cxx +++ b/editeng/source/editeng/textconv.cxx @@ -29,8 +29,6 @@ using namespace com::sun::star; using namespace com::sun::star::uno; -using namespace com::sun::star::beans; -using namespace com::sun::star::linguistic2; TextConvWrapper::TextConvWrapper( weld::Widget* pWindow, const Reference< XComponentContext >& rxContext, diff --git a/editeng/source/items/xmlcnitm.cxx b/editeng/source/items/xmlcnitm.cxx index 7507ed2afdd0..71f75a910246 100644 --- a/editeng/source/items/xmlcnitm.cxx +++ b/editeng/source/items/xmlcnitm.cxx @@ -29,7 +29,6 @@ using namespace ::com::sun::star::uno; using namespace ::com::sun::star::container; -using namespace ::com::sun::star::lang; using namespace ::com::sun::star::xml; diff --git a/editeng/source/misc/splwrap.cxx b/editeng/source/misc/splwrap.cxx index dd59113a6975..67c3dc28e64a 100644 --- a/editeng/source/misc/splwrap.cxx +++ b/editeng/source/misc/splwrap.cxx @@ -46,7 +46,6 @@ using namespace ::com::sun::star; using namespace ::com::sun::star::uno; -using namespace ::com::sun::star::beans; using namespace ::com::sun::star::linguistic2; diff --git a/editeng/source/misc/unolingu.cxx b/editeng/source/misc/unolingu.cxx index bd1fae50654e..e252dc3233e6 100644 --- a/editeng/source/misc/unolingu.cxx +++ b/editeng/source/misc/unolingu.cxx @@ -48,7 +48,6 @@
[Bug 160564] xlink:type="simple" should be valid in draw:object or chart:chart
https://bugs.documentfoundation.org/show_bug.cgi?id=160564 --- Comment #3 from Regina Henschel --- I think you are right, the attribute xlink:type is allowed in element. But it is grouped with the xlink:href attribute. This group is optional, but when it exists, both attributes have to be present. https://docs.oasis-open.org/office/OpenDocument/v1.3/os/schemas/OpenDocument-v1.3-schema-rng.html#chart-chart-attlist -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156885] add toggle to show / hide authorship metadata in popup Calc comments
https://bugs.documentfoundation.org/show_bug.cgi?id=156885 --- Comment #24 from knec...@spamreich.de --- I agree with the aforementioned authors, this must be toggleable. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 114039] [META] Fields dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114039 Bug 114039 depends on bug 154715, which changed state. Bug 154715 Summary: "Edit Fields" for cross-reference fields should open on the type, format, and selection of the inserted field https://bugs.documentfoundation.org/show_bug.cgi?id=154715 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154715] "Edit Fields" for cross-reference fields should open on the type, format, and selection of the inserted field
https://bugs.documentfoundation.org/show_bug.cgi?id=154715 Caolán McNamara changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #13 from Caolán McNamara --- seems to do something more sensible now -- You are receiving this mail because: You are the assignee for the bug.
[Bug 109265] [META] Remember dialog's previous settings issues
https://bugs.documentfoundation.org/show_bug.cgi?id=109265 Bug 109265 depends on bug 154715, which changed state. Bug 154715 Summary: "Edit Fields" for cross-reference fields should open on the type, format, and selection of the inserted field https://bugs.documentfoundation.org/show_bug.cgi?id=154715 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154715] "Edit Fields" for cross-reference fields should open on the type, format, and selection of the inserted field
https://bugs.documentfoundation.org/show_bug.cgi?id=154715 --- Comment #12 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/db609a58df7be082de7d5a20a2a924789d6a64a1 Resolves: tdf#154715 don't use last-used field setting when editing field It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154715] "Edit Fields" for cross-reference fields should open on the type, format, and selection of the inserted field
https://bugs.documentfoundation.org/show_bug.cgi?id=154715 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/ui/fldui/fldref.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit db609a58df7be082de7d5a20a2a924789d6a64a1
Author: Caolán McNamara
AuthorDate: Sun Apr 7 20:40:39 2024 +0100
Commit: Caolán McNamara
CommitDate: Mon Apr 8 14:39:56 2024 +0200
Resolves: tdf#154715 don't use last-used field setting when editing field
If we are inserting a field it makes sense to use the last-used
settings, but if we are editing an existing field we naturally want to
populate with the current field.
Here we have IsRefresh used twice as a condition, one inside the other.
But if was true in the outer use, it will also be true in the inner
(this duplication exists all the way back to the initial commit) because
GetUserData() has no side effect.
IsRefresh is only true during EditNewField (which is the case of using
the "next/back" button to go to edit another field). So even before this
change if you click next and then back (assuming there is another field
to move to) then you then get the right results
Skip restoring the last-used settings in the EditField case, replace
the outer !IsRefresh() with !IsFieldEdit()
Change-Id: I4224302171d2e8d02a0f1e0efc9fdada5ada9d7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165876
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/ui/fldui/fldref.cxx b/sw/source/ui/fldui/fldref.cxx
index a08715c8ca3c..434e10a6a2f2 100644
--- a/sw/source/ui/fldui/fldref.cxx
+++ b/sw/source/ui/fldui/fldref.cxx
@@ -268,7 +268,7 @@ void SwFieldRefPage::Reset(const SfxItemSet* )
nFieldDlgFormatSel = 0;
sal_uInt16 nFormatBoxPosition = USHRT_MAX;
-if( !IsRefresh() )
+if( !IsFieldEdit() )
{
sal_Int32 nIdx{ 0 };
const OUString sUserData = GetUserData();
core.git: sw/uiconfig
sw/uiconfig/swriter/ui/fldvarpage.ui |2 -- 1 file changed, 2 deletions(-) New commits: commit 5ba8f4c55a65d0f525f3e65402cdca961efbe1ba Author: Caolán McNamara AuthorDate: Sun Apr 7 20:04:57 2024 +0100 Commit: Caolán McNamara CommitDate: Mon Apr 8 14:39:37 2024 +0200 Failed to set property GtkEntry.valign to top: Could not parse enum: 'top' Change-Id: I2d73204bda451bb87b64652b4dd934fc16e3b65d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165875 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sw/uiconfig/swriter/ui/fldvarpage.ui b/sw/uiconfig/swriter/ui/fldvarpage.ui index 7925bdbaaad0..4c6be9736980 100644 --- a/sw/uiconfig/swriter/ui/fldvarpage.ui +++ b/sw/uiconfig/swriter/ui/fldvarpage.ui @@ -524,7 +524,6 @@ True True -top True True @@ -550,7 +549,6 @@ 0 1 -1
[Bug 49259] Writer is too jumpy when selecting an object if another object was selected
https://bugs.documentfoundation.org/show_bug.cgi?id=49259 --- Comment #16 from Stéphane Guillou (stragu) --- (In reply to Heiko Tietze from comment #14) > (In reply to Stéphane Guillou (stragu) from comment #12) > > So the behaviour is inconsistent. > I think it's not worth any effort. => NAB/WFM It's something that's been annoying enough to be reported by 3 contributors, so my opinion is that it should at least be made consistent. Low priority, for sure. (But if it is closed, please "won't fix" rather than the two others.) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 49259] Writer is too jumpy when selecting an object if another object was selected
https://bugs.documentfoundation.org/show_bug.cgi?id=49259 --- Comment #16 from Stéphane Guillou (stragu) --- (In reply to Heiko Tietze from comment #14) > (In reply to Stéphane Guillou (stragu) from comment #12) > > So the behaviour is inconsistent. > I think it's not worth any effort. => NAB/WFM It's something that's been annoying enough to be reported by 3 contributors, so my opinion is that it should at least be made consistent. Low priority, for sure. (But if it is closed, please "won't fix" rather than the two others.) -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160032] MASTER Document -- updating linked documents automatically: different setting for master documents (on opening)
https://bugs.documentfoundation.org/show_bug.cgi?id=160032 --- Comment #2 from Olivier Hallot --- I like "[ ] Don't ask again during the session". I don't know how each user work with MDs. If you open and close MDs 20 times a day, it will be annoying (anything will be annoying 20x a day) I my case I open once and refresh links once I need. Either from the Navigator or from Tools - Update. The latest does not ask for confirmation. I think the prompt is useful. There are times where you don't want to rebuild your document and want to make a small fix. May be you want to see the previous version before updating the links. YMMV. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160032] MASTER Document -- updating linked documents automatically: different setting for master documents (on opening)
https://bugs.documentfoundation.org/show_bug.cgi?id=160032 --- Comment #2 from Olivier Hallot --- I like "[ ] Don't ask again during the session". I don't know how each user work with MDs. If you open and close MDs 20 times a day, it will be annoying (anything will be annoying 20x a day) I my case I open once and refresh links once I need. Either from the Navigator or from Tools - Update. The latest does not ask for confirmation. I think the prompt is useful. There are times where you don't want to rebuild your document and want to make a small fix. May be you want to see the previous version before updating the links. YMMV. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160584] ALT key doesn't open the menus
https://bugs.documentfoundation.org/show_bug.cgi?id=160584 V Stuart Foote changed: What|Removed |Added CC||vsfo...@libreoffice.org --- Comment #2 from V Stuart Foote --- Corrected at the 24.2.3 release, meanwhile will take you to the main menu 'File' entry. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160564] xlink:type="simple" should be valid in draw:object or chart:chart
https://bugs.documentfoundation.org/show_bug.cgi?id=160564 --- Comment #2 from Laurent Balland --- @Regina: any though about this report? I prepared this commit, in case you agree: https://gerrit.libreoffice.org/c/core/+/165853 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 89566] SIDEBAR: Improving the navigator tab in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=89566 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=43 ||220 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103030] [META] Navigator sidebar deck and floating window (also "Target in Document")
https://bugs.documentfoundation.org/show_bug.cgi?id=103030 Bug 103030 depends on bug 43220, which changed state. Bug 43220 Summary: UI: The Navigation Toolbox (top left of Navigator dialog) in Writer can incorrectly launch multiple instances https://bugs.documentfoundation.org/show_bug.cgi?id=43220 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 43220] UI: The Navigation Toolbox (top left of Navigator dialog) in Writer can incorrectly launch multiple instances
https://bugs.documentfoundation.org/show_bug.cgi?id=43220 V Stuart Foote changed: What|Removed |Added Whiteboard|target:6.3.0 target:6.2.1 |target:6.3.0 target:6.2.1 ||target:7.0.0 Resolution|--- |FIXED Status|REOPENED|RESOLVED See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=89 ||566 --- Comment #20 from V Stuart Foote --- (In reply to John from comment #19) Thanks John. Yes this issue was resolved. In fact the Toolbox picker was replaced, and the Navigator was refactored to use mode selection via drop listbox. I think that was done [1] for bug 89566 at the 7.0.0 release =-ref-= [1] https://gerrit.libreoffice.org/c/core/+/87005/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 49259] Writer is too jumpy when selecting an object if another object was selected
https://bugs.documentfoundation.org/show_bug.cgi?id=49259 --- Comment #15 from Ruslan Kabatsayev --- > I think it's not worth any effort. => NAB/WFM > > Ruslan, do you agree? The disappearing menu was the main annoyance here, which I confirm is fixed in 24.2.2.2. The jump remains, and I dislike it, but if it is intended, so be it. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 49259] Writer is too jumpy when selecting an object if another object was selected
https://bugs.documentfoundation.org/show_bug.cgi?id=49259 --- Comment #15 from Ruslan Kabatsayev --- > I think it's not worth any effort. => NAB/WFM > > Ruslan, do you agree? The disappearing menu was the main annoyance here, which I confirm is fixed in 24.2.2.2. The jump remains, and I dislike it, but if it is intended, so be it. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 150937] When opening Advanced filter dialog the "From" field should be filled with the address of current selection
https://bugs.documentfoundation.org/show_bug.cgi?id=150937 --- Comment #2 from Heiko Tietze --- While there are many use cases that make it necessary to change the parameters, I see no harm in using a selection on start. Btw, if I define a range it's neither listed in this dialog nor using the name instead of the actual range is accepted. What is this dropdown about at all? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 150937] When opening Advanced filter dialog the "From" field should be filled with the address of current selection
https://bugs.documentfoundation.org/show_bug.cgi?id=150937 --- Comment #2 from Heiko Tietze --- While there are many use cases that make it necessary to change the parameters, I see no harm in using a selection on start. Btw, if I define a range it's neither listed in this dialog nor using the name instead of the actual range is accepted. What is this dropdown about at all? -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160584] ALT key doesn't open the menus
https://bugs.documentfoundation.org/show_bug.cgi?id=160584 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Mike Kaganski --- *** This bug has been marked as a duplicate of bug 160075 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 99608] Using clone formatting enables scrolling with the mouse -- but it shouldn't
https://bugs.documentfoundation.org/show_bug.cgi?id=99608 Michael Weghorn changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #13 from Michael Weghorn --- (In reply to Heiko Tietze from comment #12) > Not so sure about this. Doesn't the faint dash marker follow the mouse > cursor? Or am I missing some a11y feature here? I don't see any particular a11y feature here. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 99608] Using clone formatting enables scrolling with the mouse -- but it shouldn't
https://bugs.documentfoundation.org/show_bug.cgi?id=99608 Michael Weghorn changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #13 from Michael Weghorn --- (In reply to Heiko Tietze from comment #12) > Not so sure about this. Doesn't the faint dash marker follow the mouse > cursor? Or am I missing some a11y feature here? I don't see any particular a11y feature here. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160188] Installation of Libre Office 24.2 has altered my system
https://bugs.documentfoundation.org/show_bug.cgi?id=160188 --- Comment #3 from V Stuart Foote --- NEEDINFO remains for @buckjumper Also please note, installation on Windows of the nightly builds of master (e.g. against 24.8) do not include the WRITERREGISTRY=1 flag in the MSI packaging that a release build includes. And even if manually set from command line and modifying the MS Windows "registry", the nightly builds against master would show LibreOfficeDev keys rather than LibreOffice. And issue of OP would be more likely (if at all) on a major release upgrade, i.e. from 7.6 to 24.2 where existing LibreOffice user profile and actual changes to os/DE configuration by the installer packaging may have to happen. -- You are receiving this mail because: You are the assignee for the bug.
core.git: udkapi/org unotest/source
udkapi/org/libreoffice/embindtest/XTest.idl |1 +
unotest/source/embindtest/embindtest.cxx|6 ++
unotest/source/embindtest/embindtest.js |7 +++
3 files changed, 14 insertions(+)
New commits:
commit 74b48a8f6e6c861ee791107c9cacd7a9f6b84904
Author: Stephan Bergmann
AuthorDate: Mon Apr 8 11:34:05 2024 +0200
Commit: Stephan Bergmann
CommitDate: Mon Apr 8 12:59:00 2024 +0200
Embind: Clarify poor UNO exception support
As UNO exceptions are not derived from std::exception in C++, the
corresponding
JS object's name property is present but has undefined value. And the UNO
Message property is not present at all.
Change-Id: Ibe152377e5970faa8a518c77b5171d9f3c160f38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165885
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/udkapi/org/libreoffice/embindtest/XTest.idl
b/udkapi/org/libreoffice/embindtest/XTest.idl
index 45042663cf47..b3b5237ce2b4 100644
--- a/udkapi/org/libreoffice/embindtest/XTest.idl
+++ b/udkapi/org/libreoffice/embindtest/XTest.idl
@@ -112,6 +112,7 @@ interface XTest {
boolean isSequenceEnum([in] sequence value);
sequence getSequenceStruct();
boolean isSequenceStruct([in] sequence value);
+void throwRuntimeException();
};
}; }; };
diff --git a/unotest/source/embindtest/embindtest.cxx
b/unotest/source/embindtest/embindtest.cxx
index d437f3907e3a..39ba4c839dae 100644
--- a/unotest/source/embindtest/embindtest.cxx
+++ b/unotest/source/embindtest/embindtest.cxx
@@ -11,6 +11,7 @@
#include
#include
+#include
#include
#include
#include
@@ -496,6 +497,11 @@ class Test : public
cppu::WeakImplHelper
{ 123456, 100.75, u"bazzz"_ustr }
};
}
+
+void SAL_CALL throwRuntimeException() override
+{
+throw css::uno::RuntimeException(u"test"_ustr);
+}
};
}
diff --git a/unotest/source/embindtest/embindtest.js
b/unotest/source/embindtest/embindtest.js
index 1b0cf8eb5fc6..410b3886be6d 100644
--- a/unotest/source/embindtest/embindtest.js
+++ b/unotest/source/embindtest/embindtest.js
@@ -537,6 +537,13 @@ Module.addOnPostRun(function() {
console.assert(test.isFloat(uno.org.libreoffice.embindtest.Constants.Float));
console.assert(uno.org.libreoffice.embindtest.Constants.Double === 100.5);
console.assert(test.isDouble(uno.org.libreoffice.embindtest.Constants.Double));
+try {
+test.throwRuntimeException();
+ } catch (e) {
+ console.assert(e.name === 'com::sun::star::uno::RuntimeException');
+ console.assert(e.message === undefined); //TODO
+ //TODO: console.assert(e.Message.startsWith('test'));
+ }
});
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
[Bug 99608] Using clone formatting enables scrolling with the mouse -- but it shouldn't
https://bugs.documentfoundation.org/show_bug.cgi?id=99608 Heiko Tietze changed: What|Removed |Added CC||m.wegh...@posteo.de Status|NEW |NEEDINFO --- Comment #12 from Heiko Tietze --- (In reply to Stéphane Guillou (stragu) from comment #10) > we need to see which paragraph or selection will get the format > when clicking, which is denoted by a vertical dashed marker. Not so sure about this. Doesn't the faint dash marker follow the mouse cursor? Or am I missing some a11y feature here? -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 99608] Using clone formatting enables scrolling with the mouse -- but it shouldn't
https://bugs.documentfoundation.org/show_bug.cgi?id=99608 Heiko Tietze changed: What|Removed |Added CC||m.wegh...@posteo.de Status|NEW |NEEDINFO --- Comment #12 from Heiko Tietze --- (In reply to Stéphane Guillou (stragu) from comment #10) > we need to see which paragraph or selection will get the format > when clicking, which is denoted by a vertical dashed marker. Not so sure about this. Doesn't the faint dash marker follow the mouse cursor? Or am I missing some a11y feature here? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 49259] Writer is too jumpy when selecting an object if another object was selected
https://bugs.documentfoundation.org/show_bug.cgi?id=49259 Heiko Tietze changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #14 from Heiko Tietze --- (In reply to Stéphane Guillou (stragu) from comment #12) > So the behaviour is inconsistent. I think it's not worth any effort. => NAB/WFM Ruslan, do you agree? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 49259] Writer is too jumpy when selecting an object if another object was selected
https://bugs.documentfoundation.org/show_bug.cgi?id=49259 Heiko Tietze changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #14 from Heiko Tietze --- (In reply to Stéphane Guillou (stragu) from comment #12) > So the behaviour is inconsistent. I think it's not worth any effort. => NAB/WFM Ruslan, do you agree? -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160584] New: ALT key doesn't open the menus
https://bugs.documentfoundation.org/show_bug.cgi?id=160584 Bug ID: 160584 Summary: ALT key doesn't open the menus Product: LibreOffice Version: 24.2.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thedeadlysarc...@gmail.com Description: Since updating to the latest release version, using the ALT key on a physical keyboard doesn't open the application's menus (File, Modify, etc.). The menus are still accessible by clicking on them. Steps to Reproduce: 1. Open a LibreOffice component; 2. Press the ALT key on the keyboard. Actual Results: The menus aren't accessed, and the focus stays where it was before (e.g.: in the text in Writer). Expected Results: Focus shifts to the menus, which are then accessible by using the arrow keys or hotkeys. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: it-IT (it_IT); UI: it-IT Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - sc/source
sc/source/filter/html/htmlpars.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit cbac2445612be0c78ca7e46ca5abd5860025b396
Author: Caolán McNamara
AuthorDate: Fri Apr 5 10:40:36 2024 +0100
Commit: Michael Stahl
CommitDate: Mon Apr 8 12:23:29 2024 +0200
ofz#67854 UNKNOWN READ
Change-Id: I37d2bc6153a8bf616d19105645f91b8519890e61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165729
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sc/source/filter/html/htmlpars.cxx
b/sc/source/filter/html/htmlpars.cxx
index 2130e1119fa0..c6507bd54e15 100644
--- a/sc/source/filter/html/htmlpars.cxx
+++ b/sc/source/filter/html/htmlpars.cxx
@@ -671,8 +671,8 @@ void ScHTMLLayoutParser::Adjust()
SkipLocked(pE.get(), false);
if ( pE->nCol != nColBeforeSkip )
{
-SCCOL nCount = static_cast(maColOffset.size());
-if ( nCount <= pE->nCol )
+size_t nCount = maColOffset.size();
+if ( nCount <= o3tl::make_unsigned(pE->nCol) )
{
pE->nOffset = static_cast(maColOffset[nCount-1]);
MakeCol( , pE->nOffset, pE->nWidth,
nOffsetTolerance, nOffsetTolerance );
[Bug 160319] Calc: add constraints on Format Cells - Format Code
https://bugs.documentfoundation.org/show_bug.cgi?id=160319 --- Comment #2 from Timur --- Idea was to restrict just Format Code "General" description to the language of the cell, so to General for English Language (cannot type Standard), to Standard for German and French Language (cannot type General), etc. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160581] A paragraph with a large as-character object may overlap with following paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=160581 --- Comment #3 from Mike Kaganski --- Regression after commit 72a4987434368bfb0b15f5ebb70a52108d349d5f (fdo#47355: partially revert c5a8a2c3cbcee0175127a0662e3d820ea4deea22, 2014-03-17). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 87892] More shapes for LibreOffice draw are needed
https://bugs.documentfoundation.org/show_bug.cgi?id=87892 --- Comment #22 from Regina Henschel --- (In reply to Heiko Tietze from comment #21) > I wonder what "more shapes" could mean in terms of being done. The latest > patch adds a sinusoid form to the basic shapes. Fixed now? Most of the shape categories shown in the attachments about Dia and Calligra Flow could be provided as extensions for the Gallery. All ActionButtons are missing. In MS Office they provide a UI to determine actions, similar to form elements, which makes them useful for presentations. But that is not a 'difficultyBeginner' task. But at least the buttons themselves could be added because of the images on them. It could be discussed whether to use the MS binary kind or the OOXML kind. In case the 'action' feature is intended, it can not be solved by a Gallery theme, but needs to be a floater in the Drawing toolbar or location in the sidebar. A list of the MS Office binary shapes with illustrations is in https://learn.microsoft.com/en-us/openspecs/office_file_formats/ms-odraw/9c0c5c01-9e90-41aa-ba15-477dacb4cc8e Scroll down to the end for the ActionButtons. >From OOXML are missing: funnel, gear6, gear9, nonIsoscelesTrapezoid, swooshArrow and uturnArrow. They should go to the 'Shapes' or 'Arrows' theme in the Gallery, which contains already other OOXML-shapes. (gear9 and uturnArrow are already there.) I'm not sure about the MS Office binary shape msoUturnArrow (id 101). It is missing but we have the ooxml-version in the Gallery. On the other hand the ooxml-version is not suitable for export to MS Office binary formats. Interesting would be a 'spiral'. Such is available in SoftMaker and in Inkscape. That could go to the Gallery. There is the wish for a mirrored trapezoid in bug 116672. ToDo for the floater in the drawing toolbar: Missing are 'arc' and 'chord'. The currently included ones are in fact no custom shapes but belong to the 'legacy' shapes. For 'arc' it is msosptArc (id 19). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160583] New: Pasted text in HTML-Format doesn't contain Field-Content
https://bugs.documentfoundation.org/show_bug.cgi?id=160583 Bug ID: 160583 Summary: Pasted text in HTML-Format doesn't contain Field-Content Product: LibreOffice Version: 7.6.6.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ka...@mein-kartendruck.de Description: When a text is copied from a LibreOffice-Writer Mail-Merge-Document an pasted in HTML-Format, Field-Content is empty. Works well in 7.4.6, doesn't work after updating to 7.6.6. - workaraound by downgrading to 7.4.6 again. Steps to Reproduce: 1. Copy text from a Mail-Merge-Docoment 2. Paste in HTML-Format - Field-Content is empty 3. Paste in Plain-Text-Format or as Libre-office-Text - Field content is filled Actual Results: After update to 7.6.6. text copied from LibreOffice-Writer and pasted into Thunderbird in HTML-Format doesn't contain the Mail-Merge-Fields. Same behavior if copied text is pasted into new Libre-Office-Document in HTML-Format. Pasted text in pure Text-Format contains all information Expected Results: When a text is copied from a LibreOffice-Writer Mail-Merge-Document it should contain the content of Mail-Merge-Fields. In version 7.4.6 it worked fine. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: de Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: yes Version: 7.6.6 (x64) / LibreOffice Community CPU threads: 12; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160032] MASTER Document -- updating linked documents automatically: different setting for master documents (on opening)
https://bugs.documentfoundation.org/show_bug.cgi?id=160032 Heiko Tietze changed: What|Removed |Added CC||olivier.hallot@libreoffice. ||org --- Comment #1 from Heiko Tietze --- The update usually comes on cost of performance, and you don't want to disable the question in all use cases. But how about adding the option "[ ] Don't ask again during the session" to the dialog. Meaning the next time you start Writer it is necessary again to click yes or no. Olivier, you are a heavy master-document user (not heavy, sorry, but regular user *g*). Have you experienced the same issue as Peter? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160032] MASTER Document -- updating linked documents automatically: different setting for master documents (on opening)
https://bugs.documentfoundation.org/show_bug.cgi?id=160032 Heiko Tietze changed: What|Removed |Added CC||olivier.hallot@libreoffice. ||org --- Comment #1 from Heiko Tietze --- The update usually comes on cost of performance, and you don't want to disable the question in all use cases. But how about adding the option "[ ] Don't ask again during the session" to the dialog. Meaning the next time you start Writer it is necessary again to click yes or no. Olivier, you are a heavy master-document user (not heavy, sorry, but regular user *g*). Have you experienced the same issue as Peter? -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160205] WRITER: page number display in Application background
https://bugs.documentfoundation.org/show_bug.cgi?id=160205 Heiko Tietze changed: What|Removed |Added Resolution|--- |WONTFIX Status|UNCONFIRMED |RESOLVED --- Comment #3 from Heiko Tietze --- I also do not share your excitement over this "head-up display". It's mostly based on the idea of a fancy design, which is not bad per se. But the functionality would be limited in case of zoom, depends on book mode, RTL/LTR, etc. => WF, thanks for your idea -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160205] WRITER: page number display in Application background
https://bugs.documentfoundation.org/show_bug.cgi?id=160205 Heiko Tietze changed: What|Removed |Added Resolution|--- |WONTFIX Status|UNCONFIRMED |RESOLVED --- Comment #3 from Heiko Tietze --- I also do not share your excitement over this "head-up display". It's mostly based on the idea of a fancy design, which is not bad per se. But the functionality would be limited in case of zoom, depends on book mode, RTL/LTR, etc. => WF, thanks for your idea -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 109299] Empty cells are not copied to external application like Notepad (while copied to another spreadsheet)
https://bugs.documentfoundation.org/show_bug.cgi?id=109299 --- Comment #21 from Larsen --- Still a problem in 7.6.6.3 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160547] Database Connection: JDBC-Connection with DuckDB fails
https://bugs.documentfoundation.org/show_bug.cgi?id=160547 --- Comment #3 from Alex Thurgood --- FWIW, when I unload, and the reload the ODB file, I see exactly the same message as @Robert. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160547] Database Connection: JDBC-Connection with DuckDB fails
https://bugs.documentfoundation.org/show_bug.cgi?id=160547 --- Comment #2 from Alex Thurgood --- Confirming also with: Version: 7.6.4.1 (AARCH64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 8; OS: Mac OS X 14.4.1; UI render: Skia/Raster; VCL: osx Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Calc: threaded In many ways, the behaviour is similar to using SQLite. An in memory database can be created and using Tools > SQL allows you to create a table and insert test data (e.g. using the statements from https://duckdb.org/docs/api/java.html) However, it is impossible to display any of the database objects, use queries, use the wizards, etc. For example, trying a query via the SQL query option leads to an error that displays Could not load content of data prepareStatement Turning on/off the design mode leads to the following error: The database contains neither a table nor a query named "items". Confirming -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159719] SfxItemPool::IsInRange crash: save and reload in Impress or Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=159719 --- Comment #11 from Armin Le Grand --- @ilmari.lauhakan...@libreoffice.org: could you please try https://gerrit.libreoffice.org/c/core/+/165883 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152336] Improve CSV field separator detection/behavior when several separators are selected on import
https://bugs.documentfoundation.org/show_bug.cgi?id=152336 m_a_riosv changed: What|Removed |Added Blocks||160582 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160582 [Bug 160582] FILEOPEN: CSV, locale setting is not preserved in the import window (regression tdf#152336) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160582] FILEOPEN: CSV, locale setting is not preserved in the import window (regression tdf#152336)
https://bugs.documentfoundation.org/show_bug.cgi?id=160582 m_a_riosv changed: What|Removed |Added Depends on||152336 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152336 [Bug 152336] Improve CSV field separator detection/behavior when several separators are selected on import -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160582] FILEOPEN: CSV, locale setting is not preserved in the import window (regression tdf#152336)
https://bugs.documentfoundation.org/show_bug.cgi?id=160582 m_a_riosv changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160582] FILEOPEN: CSV, locale setting is not preserved in the import window (regression tdf#152336)
https://bugs.documentfoundation.org/show_bug.cgi?id=160582 --- Comment #1 from m_a_riosv --- Created attachment 193564 --> https://bugs.documentfoundation.org/attachment.cgi?id=193564=edit Sample file csv to test -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160582] New: FILEOPEN: CSV, locale setting is not preserved in the import window (regression tdf#152336)
https://bugs.documentfoundation.org/show_bug.cgi?id=160582 Bug ID: 160582 Summary: FILEOPEN: CSV, locale setting is not preserved in the import window (regression tdf#152336) Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: miguelange...@libreoffice.org With Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5ebdcc60701ca5f2d267f92fa69ac06202309c52 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded After tdf#152336 improvement. The issue is that now, locale setting is not preserved in the import window. As was the case until 24.2. Seems it is reset to the default locale in my case es-ES. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 90186] Right-click on unfocused comment does not focus it and shows wrong context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=90186 --- Comment #8 from Eyal Rozenberg --- A right click still shows the context menu for the text body, with: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ffccbf4762a9ae810bcdd21c41fccdd436e7bfc9 CPU threads: 4; OS: Linux 6.6; UI render: default; VCL: gtk3 Locale: he-IL (en_IL); UI: en-US -- You are receiving this mail because: You are the assignee for the bug.
core.git: compilerplugins/clang
compilerplugins/clang/unusedmember.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit fd7caefaacd91a16fce10b4e4fbfe6ef4f5ffce9
Author: Stephan Bergmann
AuthorDate: Mon Apr 8 08:07:16 2024 +0200
Commit: Stephan Bergmann
CommitDate: Mon Apr 8 10:48:45 2024 +0200
-Werror,-Wunused-but-set-variable
Change-Id: I4e4d3c810e9d37fd4b87d3307c2ba906923aa63b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165882
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/compilerplugins/clang/unusedmember.cxx
b/compilerplugins/clang/unusedmember.cxx
index 9cf40d721259..305f9c606d31 100644
--- a/compilerplugins/clang/unusedmember.cxx
+++ b/compilerplugins/clang/unusedmember.cxx
@@ -126,6 +126,8 @@ public:
{
#if 0 //TODO: friend function definitions are not marked as referenced even if
used?
if (!d3->isThisDeclarationADefinition()) //TODO: do this
check for all kinds?
+#else
+(void)d3;
#endif
{
continue;
core.git: configure.ac download.lst external/rhino Makefile.fetch solenv/flatpak-manifest.in
Makefile.fetch |1 -
configure.ac |7 ++-
download.lst |5 -
external/rhino/README |9 -
solenv/flatpak-manifest.in |7 ---
5 files changed, 2 insertions(+), 27 deletions(-)
New commits:
commit 479a39cbf0f4564abe93066d7a3f6b2e82de0e76
Author: Rene Engelhard
AuthorDate: Wed Apr 3 23:26:08 2024 +0200
Commit: Stephan Bergmann
CommitDate: Mon Apr 8 10:48:19 2024 +0200
clean up after removal of patched rhino
Change-Id: I193fd0c10d297555faa7a832718dbd6cd929a406
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165762
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/Makefile.fetch b/Makefile.fetch
index b96cb573c2bf..afb7d176e79e 100644
--- a/Makefile.fetch
+++ b/Makefile.fetch
@@ -224,7 +224,6 @@ $(WORKDIR)/download: $(BUILDDIR)/config_$(gb_Side).mk
$(SRCDIR)/download.lst $(S
$(call fetch_Optional,REDLAND,REDLAND_TARBALL) \
$(call fetch_Optional,REVENGE,REVENGE_TARBALL) \
$(call fetch_Optional,RHINO,RHINO_TARBALL) \
- $(call fetch_Optional,RHINO,SWING_TARBALL) \
$(call fetch_Optional,SKIA,SKIA_TARBALL) \
$(call fetch_Optional,STAROFFICE,STAROFFICE_TARBALL) \
$(if $(filter WNT,$(OS)),TWAIN_DSM_TARBALL) \
diff --git a/configure.ac b/configure.ac
index 507fef7e9d34..799b88d39abb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2390,11 +2390,8 @@ libo_FUZZ_ARG_ENABLE(scripting-javascript,
AC_ARG_WITH(system-rhino,
AS_HELP_STRING([--with-system-rhino],
-[Use rhino already on system.]),,)
-#[with_system_rhino="$with_system_jars"])
-# Above is not used as we have different debug interface
-# patched into internal rhino. This code needs to be fixed
-# before we can enable it by default.
+[Use rhino already on system.]),,
+[with_system_rhino="$with_system_jars"])
AC_ARG_WITH(rhino-jar,
AS_HELP_STRING([--with-rhino-jar=JARFILE],
diff --git a/download.lst b/download.lst
index 8c732bdb41b0..d8793dbeb620 100644
--- a/download.lst
+++ b/download.lst
@@ -602,11 +602,6 @@ STAROFFICE_TARBALL :=
libstaroffice-0.0.$(STAROFFICE_VERSION_MICRO).tar.xz
# three static lines
# so that git cherry-pick
# will not run into conflicts
-SWING_SHA256SUM :=
64585ac36a81291a58269ec5347e7e3e2e8596dbacb9221015c208191333c6e1
-SWING_TARBALL := 35c94d2df8893241173de1d16b6034c0-swingExSrc.zip
-# three static lines
-# so that git cherry-pick
-# will not run into conflicts
TWAIN_DSM_SHA256SUM :=
82c818be771f242388457aa8c807e4b52aa84dc22b21c6c56184a6b4cbb085e6
TWAIN_DSM_TARBALL := twaindsm_2.4.1.orig.tar.gz
# three static lines
diff --git a/external/rhino/README b/external/rhino/README
index 83e4135d0b89..c60378c32262 100644
--- a/external/rhino/README
+++ b/external/rhino/README
@@ -3,12 +3,3 @@ JavaScript engine/interpreter written in Java, used to provide
JavaScript extens
The Scripting Framework makes use of the Rhino
([http://www.mozilla.org/rhino/])
JavaScript interpreter, available under the Mozilla Public License
([http://www.mozilla.org/MPL/MPL-1.1.html]).
-
-In addition, to support the debugging of scripts contained in OpenOffice.org
-documents, we have modified the Java source file Main.java.
-
-The Rhino source tarball is unpacked and patched with the modified code. The
-Rhino Jar file (js.jar) is then built (download/swingExSrc.zip is unpacked and
-built as part of this procesS) and delivered to the solver. The file
-rhino1_5R5.patch contains the changes made in order to build Rhino. The patch
-was generated using the command: diff -wurN
diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in
index 74beb39f21b9..1ba678b81d12 100644
--- a/solenv/flatpak-manifest.in
+++ b/solenv/flatpak-manifest.in
@@ -709,13 +709,6 @@
"dest": "external/tarballs",
"dest-filename": "@JFREEREPORT_SAC_TARBALL@"
},
-{
-"url":
"https://dev-www.libreoffice.org/src/@SWING_TARBALL@;,
-"sha256": "@SWING_SHA256SUM@",
-"type": "file",
-"dest": "external/tarballs",
-"dest-filename": "@SWING_TARBALL@"
-},
{
"url":
"https://dev-www.libreoffice.org/src/@LIBNUMBERTEXT_TARBALL@;,
"sha256": "@LIBNUMBERTEXT_SHA256SUM@",
[Bug 160581] A paragraph with a large as-character object may overlap with following paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=160581 Mike Kaganski changed: What|Removed |Added Version|6.4.0.3 release |4.3.0.4 release --- Comment #2 from Mike Kaganski --- In fact, the current problem was introduced in version 4.3 (it was still fine in 4.2); after that, it transformed in version 4.4, which lasted until 6.4. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160581] A paragraph with a large as-character object may overlap with following paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=160581 --- Comment #1 from Mike Kaganski --- The change in 6.4 was introduced by commit 28d67b792724a23015dec32fb0278b729f676736 (tdf#107776 sw ODF shape import: make is-textbox check more strict, 2019-08-27). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160581] New: A paragraph with a large as-character object may overlap with following paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=160581 Bug ID: 160581 Summary: A paragraph with a large as-character object may overlap with following paragraphs Product: LibreOffice Version: 6.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Keywords: regression Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com Created attachment 193563 --> https://bugs.documentfoundation.org/attachment.cgi?id=193563=edit A large object shifted down by a "no-wrap" object in header The attachment has a large (taller than available page space) as-char object in the first body paragraph, shifted down a bit by an object in header. Then goes another paragraph with txt "foo bar". The expectation is that the first paragraph is normally followed by the second one, which means that the second paragraph must go to the next page, since the first paragraph takes the whole page (and more). Actual behavior is that the second paragraph appears on top of the first paragraph, at the top of the first page. This worked fine in version 4.0. In version 5.0 it was differently wrong, the as-char object was shifted to the second page, became short, and was followed by the second paragraph there, with an empty third page. In 6.3, there was yet another wrong layout, with the shorter as-char object and the following paragraph both on the first page. In 6.4, it was already same as in current versions. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146619] Remove unused #includes from C/C++ files
https://bugs.documentfoundation.org/show_bug.cgi?id=146619 --- Comment #72 from Commit Notification --- Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/95fab3f7dc1d7b802dce94d934b8ec95def92bf2 tdf#146619 Drop unused 'using namespace' in: basctl/ It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: basctl/source
basctl/source/basicide/basobj3.cxx |1 -
basctl/source/dlged/managelang.cxx |1 -
basctl/source/inc/bastype2.hxx |1 -
3 files changed, 3 deletions(-)
New commits:
commit 95fab3f7dc1d7b802dce94d934b8ec95def92bf2
Author: Gabor Kelemen
AuthorDate: Sat Mar 30 20:54:12 2024 +0100
Commit: Gabor Kelemen
CommitDate: Mon Apr 8 10:06:39 2024 +0200
tdf#146619 Drop unused 'using namespace' in: basctl/
Change-Id: I7df9fa0e7de3cf7ee39ce96bf9ff32c54db14763
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165687
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen
diff --git a/basctl/source/basicide/basobj3.cxx
b/basctl/source/basicide/basobj3.cxx
index 4672cdd52c2b..5d5bacf0e88d 100644
--- a/basctl/source/basicide/basobj3.cxx
+++ b/basctl/source/basicide/basobj3.cxx
@@ -48,7 +48,6 @@
namespace basctl
{
-using namespace comphelper;
using namespace ::com::sun::star;
using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::container;
diff --git a/basctl/source/dlged/managelang.cxx
b/basctl/source/dlged/managelang.cxx
index 69f366ed6656..1dc44b0f09cf 100644
--- a/basctl/source/dlged/managelang.cxx
+++ b/basctl/source/dlged/managelang.cxx
@@ -40,7 +40,6 @@
namespace basctl
{
-using namespace ::com::sun::star::i18n;
using namespace ::com::sun::star::lang;
using namespace ::com::sun::star::resource;
using namespace ::com::sun::star::uno;
diff --git a/basctl/source/inc/bastype2.hxx b/basctl/source/inc/bastype2.hxx
index 0161797f16a2..22321b309757 100644
--- a/basctl/source/inc/bastype2.hxx
+++ b/basctl/source/inc/bastype2.hxx
@@ -45,7 +45,6 @@ namespace o3tl {
namespace basctl
{
-using namespace ::com::sun::star::uno;
enum EntryType
{
[Bug 87892] More shapes for LibreOffice draw are needed
https://bugs.documentfoundation.org/show_bug.cgi?id=87892 --- Comment #21 from Heiko Tietze --- I wonder what "more shapes" could mean in terms of being done. The latest patch adds a sinusoid form to the basic shapes. Fixed now? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160304] Manage direct changes dialog is confusing in case of deleted table rows
https://bugs.documentfoundation.org/show_bug.cgi?id=160304 --- Comment #2 from Telesto --- Created attachment 193562 --> https://bugs.documentfoundation.org/attachment.cgi?id=193562=edit Screencast -- You are receiving this mail because: You are the assignee for the bug.
[Bug 87892] More shapes for LibreOffice draw are needed
https://bugs.documentfoundation.org/show_bug.cgi?id=87892 --- Comment #20 from Commit Notification --- RMZeroFour committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/afb18ac0628c54fdffc1ee5b55db6110c20872cd tdf#50998 tdf#87892 Add sinusoid shape It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 87892] More shapes for LibreOffice draw are needed
https://bugs.documentfoundation.org/show_bug.cgi?id=87892 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
core.git: chart2/uiconfig icon-themes/colibre icon-themes/colibre_dark icon-themes/colibre_dark_svg icon-themes/colibre_svg include/svx officecfg/registry oox/source reportdesign/uiconfig sc/uiconfig
chart2/uiconfig/toolbar/basicshapes.xml |2 icon-themes/colibre/cmd/32/basicshapes.sinusoid.png |binary icon-themes/colibre/cmd/lc_basicshapes.sinusoid.png |binary icon-themes/colibre/cmd/sc_basicshapes.sinusoid.png |binary icon-themes/colibre_dark/cmd/32/basicshapes.sinusoid.png |binary icon-themes/colibre_dark/cmd/lc_basicshapes.sinusoid.png |binary icon-themes/colibre_dark/cmd/sc_basicshapes.sinusoid.png |binary icon-themes/colibre_dark_svg/cmd/32/basicshapes.sinusoid.svg |3 icon-themes/colibre_svg/cmd/32/basicshapes.sinusoid.svg |3 include/svx/msdffdef.hxx |1 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |8 + oox/source/export/shapes.cxx |5 reportdesign/uiconfig/dbreport/toolbar/basicshapes.xml |2 sc/uiconfig/scalc/toolbar/basicshapes.xml|2 sd/uiconfig/sdraw/toolbar/basicshapes.xml|2 sd/uiconfig/simpress/toolbar/basicshapes.xml |2 svx/source/customshapes/EnhancedCustomShapeGeometry.cxx | 57 ++ svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx |6 - svx/source/sidebar/shapes/ShapesUtil.cxx |3 sw/uiconfig/sglobal/toolbar/basicshapes.xml |2 sw/uiconfig/sweb/toolbar/basicshapes.xml |2 sw/uiconfig/swform/toolbar/basicshapes.xml |2 sw/uiconfig/swreport/toolbar/basicshapes.xml |2 sw/uiconfig/swriter/toolbar/basicshapes.xml |2 sw/uiconfig/swxform/toolbar/basicshapes.xml |2 25 files changed, 103 insertions(+), 5 deletions(-) New commits: commit afb18ac0628c54fdffc1ee5b55db6110c20872cd Author: RMZeroFour AuthorDate: Tue Mar 26 21:41:59 2024 +0530 Commit: Heiko Tietze CommitDate: Mon Apr 8 09:54:55 2024 +0200 tdf#50998 tdf#87892 Add sinusoid shape In response to #50998 (as well as #87892 indirectly), regarding adding sinusoidal and coil-like shapes to the shape gallery in LibreOffice, this commit adds a sinusoid shape to the gallery. The shape is still incomplete for release, at least lacking icons for the sidebar. Further details posted on the Bugzilla thread for issue #50998. PS-2: Removed the previously added flag shape. PS-4: Moved sinusoid to the end in a new subgroup. Change-Id: Ie0f6e3948b6dce98dc2b4f87289cfd37f2d16911 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165353 Tested-by: Jenkins Reviewed-by: Regina Henschel Reviewed-by: Heiko Tietze diff --git a/chart2/uiconfig/toolbar/basicshapes.xml b/chart2/uiconfig/toolbar/basicshapes.xml index 148245f66672..a0debaab8fd5 100644 --- a/chart2/uiconfig/toolbar/basicshapes.xml +++ b/chart2/uiconfig/toolbar/basicshapes.xml @@ -45,4 +45,6 @@ + + diff --git a/icon-themes/colibre/cmd/32/basicshapes.sinusoid.png b/icon-themes/colibre/cmd/32/basicshapes.sinusoid.png new file mode 100644 index ..9e418857c3b5 Binary files /dev/null and b/icon-themes/colibre/cmd/32/basicshapes.sinusoid.png differ diff --git a/icon-themes/colibre/cmd/lc_basicshapes.sinusoid.png b/icon-themes/colibre/cmd/lc_basicshapes.sinusoid.png new file mode 100644 index ..7cf307a3d500 Binary files /dev/null and b/icon-themes/colibre/cmd/lc_basicshapes.sinusoid.png differ diff --git a/icon-themes/colibre/cmd/sc_basicshapes.sinusoid.png b/icon-themes/colibre/cmd/sc_basicshapes.sinusoid.png new file mode 100644 index ..c919cc3beb42 Binary files /dev/null and b/icon-themes/colibre/cmd/sc_basicshapes.sinusoid.png differ diff --git a/icon-themes/colibre_dark/cmd/32/basicshapes.sinusoid.png b/icon-themes/colibre_dark/cmd/32/basicshapes.sinusoid.png new file mode 100644 index ..66f701ba1dc9 Binary files /dev/null and b/icon-themes/colibre_dark/cmd/32/basicshapes.sinusoid.png differ diff --git a/icon-themes/colibre_dark/cmd/lc_basicshapes.sinusoid.png b/icon-themes/colibre_dark/cmd/lc_basicshapes.sinusoid.png new file mode 100644 index ..4f49fa91fb65 Binary files /dev/null and b/icon-themes/colibre_dark/cmd/lc_basicshapes.sinusoid.png differ diff --git a/icon-themes/colibre_dark/cmd/sc_basicshapes.sinusoid.png b/icon-themes/colibre_dark/cmd/sc_basicshapes.sinusoid.png new file mode 100644 index ..c3f64f3b0d87 Binary files /dev/null and b/icon-themes/colibre_dark/cmd/sc_basicshapes.sinusoid.png differ diff --git a/icon-themes/colibre_dark_svg/cmd/32/basicshapes.sinusoid.svg b/icon-themes/colibre_dark_svg/cmd/32/basicshapes.sinusoid.svg new file mode
[Bug 123648] [META] Custom shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=123648 Bug 123648 depends on bug 50998, which changed state. Bug 50998 Summary: add "coil" to draw basic shape menu https://bugs.documentfoundation.org/show_bug.cgi?id=50998 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 99671] [META] Gallery bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=99671 Bug 99671 depends on bug 50998, which changed state. Bug 50998 Summary: add "coil" to draw basic shape menu https://bugs.documentfoundation.org/show_bug.cgi?id=50998 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
core.git: compilerplugins/clang
compilerplugins/clang/stringconstant.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit f1697d2b1e6b3ac63946070cc720234dc68efbe9
Author: Stephan Bergmann
AuthorDate: Mon Apr 8 08:05:17 2024 +0200
Commit: Stephan Bergmann
CommitDate: Mon Apr 8 09:50:46 2024 +0200
-Werror,-Wunused-but-set-variable
...ever since the code got introduced in
4f5b3e4bd53d6d61df1f65f496f7bc8dc525c8a1 "In O[U]StringBuffer, make
string_view
params replacements for OUString ones"
Change-Id: If2032db027f45c60f7c92b796a0a10d23f26b6e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165881
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/compilerplugins/clang/stringconstant.cxx
b/compilerplugins/clang/stringconstant.cxx
index 134be1940b82..344125dd4df0 100644
--- a/compilerplugins/clang/stringconstant.cxx
+++ b/compilerplugins/clang/stringconstant.cxx
@@ -96,7 +96,7 @@ CXXConstructExpr const * lookForCXXConstructExpr(Expr const *
expr) {
}
if (auto const e = dyn_cast(expr)) {
// Look through OString::operator std::string_view:
-if (auto const d =
dyn_cast_or_null(e->getCalleeDecl())) {
+if (isa_and_nonnull(e->getCalleeDecl())) {
return
lookForCXXConstructExpr(e->getImplicitObjectArgument()->IgnoreParenImpCasts());
}
}
core.git: sw/source
sw/source/core/docnode/node2lay.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit a57ade9be3aa03634933e767eab5e8fb640760ca
Author: Stephan Bergmann
AuthorDate: Mon Apr 8 07:52:38 2024 +0200
Commit: Stephan Bergmann
CommitDate: Mon Apr 8 09:50:20 2024 +0200
-Werror,-Wunused-but-set-variable
...ever since the code got introduced in
9dc6e2c9062725ef1f9d7e321cae5f4dbe8ca749 "sw: fix expansion of
SetGetExpField in
headers with split table rows"
Change-Id: I44e8d375a47286b625ce9a7808484a32dc1f0aa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165879
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/sw/source/core/docnode/node2lay.cxx
b/sw/source/core/docnode/node2lay.cxx
index 607ebada8ef4..312ce2dff440 100644
--- a/sw/source/core/docnode/node2lay.cxx
+++ b/sw/source/core/docnode/node2lay.cxx
@@ -146,7 +146,7 @@ SwFrame const* FindNeighbourFrameForNode(SwNode const&
rNode)
{
SwNodeIndex idx(rNode);
SwFlowFrame const* pFlow(nullptr);
-if (SwNode *const pNode = GoPreviousWithFrame(, ))
+if (GoPreviousWithFrame(, ))
{
if (::CheckNodesRange(rNode, idx.GetNode(), true))
{
@@ -158,7 +158,7 @@ SwFrame const* FindNeighbourFrameForNode(SwNode const&
rNode)
}
}
idx = rNode;
-if (SwNode *const pNode = GoNextWithFrame(idx.GetNodes(), , ))
+if (GoNextWithFrame(idx.GetNodes(), , ))
{
if (::CheckNodesRange(rNode, idx.GetNode(), true))
{
[Bug 148391] Deleted text with backspace moving a space out of visible range
https://bugs.documentfoundation.org/show_bug.cgi?id=148391 Telesto changed: What|Removed |Added Resolution|INSUFFICIENTDATA|WORKSFORME --- Comment #8 from Telesto --- Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 0020fc1167b3760d0631001689a44427b72b816e CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: compilerplugins/clang
compilerplugins/clang/getstr.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 6202211a09175e914298f93be8ee17260d8a5bf3
Author: Stephan Bergmann
AuthorDate: Mon Apr 8 07:56:32 2024 +0200
Commit: Stephan Bergmann
CommitDate: Mon Apr 8 09:49:53 2024 +0200
-Werror,-Wunused-but-set-variable
...ever since the code got introduced in
77d083f2cbe496274cdab38a3a34497d1b742d86 "New loplugin:getstr"
Change-Id: I3e0c7793c6e19e44d7450156aeb3cead3511faf9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165880
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/compilerplugins/clang/getstr.cxx b/compilerplugins/clang/getstr.cxx
index 671699e73551..97276591e19e 100644
--- a/compilerplugins/clang/getstr.cxx
+++ b/compilerplugins/clang/getstr.cxx
@@ -81,7 +81,7 @@ public:
return true;
}
bool castToVoid = false;
-if (auto const ic = dyn_cast(arg1))
+if (isa(arg1))
{
if (loplugin::TypeCheck(arg1->getType()).Pointer().Void())
{
[Bug 138492] [Docx] Missing Picture on second page
https://bugs.documentfoundation.org/show_bug.cgi?id=138492 --- Comment #7 from Mike Kaganski --- Can't repro in today's master - I could fix this in bug 160526. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160544] Quickfind sidebar: Make the sidebar the default for ctrl+F
https://bugs.documentfoundation.org/show_bug.cgi?id=160544 --- Comment #5 from Heiko Tietze --- I'd just keep the sidebar open, but Ctrl+F5 or F11 both toggle the sidebar. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156374] Make Hanging Indent command create a hanging indent, when used on a paragraph without one
https://bugs.documentfoundation.org/show_bug.cgi?id=156374 Mike Kaganski changed: What|Removed |Added Keywords||difficultyMedium, easyHack, ||skillCpp --- Comment #2 from Mike Kaganski --- (In reply to Heiko Tietze from comment #1) > I wonder if this could be an easyhack. Indeed. The functionality is implemented for SID_HANGING_INDENT in several places (for different modules - sw, sd; for different contexts). The code pointers: 1. Look into the commit mentioned in comment 0, and see the methods implementing the functionality. 1.a. Alternatively: grep for 'SID_HANGING_INDENT' in .sdi files (there the slots for different UNO commands are defined); write down the 'ExecMethod' in each of the found places; and then, find these methods in the respective module's CXX files, where SID_HANGING_INDENT is handled. 2. In these methods, make sure that there is a reasonable processing for the case when current indent is 0. I suppose, that the default hanging indent likely should be the same length as "Increase Indent" function does, as indicated by Heiko. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160580] Provide config option for "Wraparound" of next/previous sheet shortcut in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=160580 a...@patternjugglers.co.nz changed: What|Removed |Added Summary|"Wraparound" of |Provide config option for |next/previous sheet |"Wraparound" of |shortcut in Calc|next/previous sheet ||shortcut in Calc Severity|normal |enhancement --- Comment #1 from a...@patternjugglers.co.nz --- I had replies over on ask/ pointing out that this was a newly added feature per https://bugs.documentfoundation.org/show_bug.cgi?id=156311. As such, clearly it's a desired behaviour for some: is it possible to provide a configuration option to disable this - or perhaps rebind the keyboard customisation to a slightly different option? -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'distro/vector/vector-7.5.9' - vcl/inc vcl/win
vcl/inc/win/DWriteTextRenderer.hxx | 15 +++
vcl/inc/win/winlayout.hxx |2 ++
vcl/win/gdi/DWriteTextRenderer.cxx | 28 ++--
vcl/win/gdi/winlayout.cxx |8
4 files changed, 35 insertions(+), 18 deletions(-)
New commits:
commit 14c76305c6ebbaa765caf45db409a10cf99c5cea
Author: Mike Kaganski
AuthorDate: Mon Apr 8 11:12:01 2024 +0500
Commit: Mike Kaganski
CommitDate: Mon Apr 8 11:12:01 2024 +0500
Revert "Exclude getHScale from DirectWrite font rendering"
This reverts commit 36e8e419d022a9c43302efe5e702a704dea39e76.
diff --git a/vcl/inc/win/DWriteTextRenderer.hxx
b/vcl/inc/win/DWriteTextRenderer.hxx
index a655df6459ea..67094052ebb5 100644
--- a/vcl/inc/win/DWriteTextRenderer.hxx
+++ b/vcl/inc/win/DWriteTextRenderer.hxx
@@ -72,6 +72,21 @@ private:
D2DTextAntiAliasMode meTextAntiAliasMode;
};
+/**
+ * Sets and unsets the needed DirectWrite transform to support the font's
horizontal scaling and
+ * rotation.
+ */
+class WinFontTransformGuard
+{
+public:
+WinFontTransformGuard(ID2D1RenderTarget* pRenderTarget, float fHScale,
const GenericSalLayout& rLayout, const D2D1_POINT_2F& rBaseline, bool
bIsVertical);
+~WinFontTransformGuard();
+
+private:
+ID2D1RenderTarget* mpRenderTarget;
+D2D1::Matrix3x2F maTransform;
+};
+
#endif // INCLUDED_VCL_INC_WIN_DWRITERENDERER_HXX
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/win/winlayout.hxx b/vcl/inc/win/winlayout.hxx
index ac70e42b66cf..0f253230c1b4 100644
--- a/vcl/inc/win/winlayout.hxx
+++ b/vcl/inc/win/winlayout.hxx
@@ -36,6 +36,8 @@ class WinFontInstance : public LogicalFontInstance
public:
~WinFontInstance() override;
+float getHScale() const;
+
void SetGraphics(WinSalGraphics*);
WinSalGraphics* GetGraphics() const { return m_pGraphics; }
diff --git a/vcl/win/gdi/DWriteTextRenderer.cxx
b/vcl/win/gdi/DWriteTextRenderer.cxx
index 321587db8137..b7d7c03e9995 100644
--- a/vcl/win/gdi/DWriteTextRenderer.cxx
+++ b/vcl/win/gdi/DWriteTextRenderer.cxx
@@ -97,20 +97,6 @@ HRESULT checkResult(HRESULT hr, const char* file, size_t
line)
#endif
-// Sets and unsets the needed DirectWrite transform to support the font's
rotation.
-class WinFontTransformGuard
-{
-public:
-WinFontTransformGuard(ID2D1RenderTarget* pRenderTarget,
- const GenericSalLayout& rLayout, const
D2D1_POINT_2F& rBaseline,
- bool bIsVertical);
-~WinFontTransformGuard();
-
-private:
-ID2D1RenderTarget* mpRenderTarget;
-D2D1::Matrix3x2F maTransform;
-};
-
} // end anonymous namespace
D2DWriteTextOutRenderer::D2DWriteTextOutRenderer(bool bRenderingModeNatural)
@@ -232,6 +218,7 @@ bool
D2DWriteTextOutRenderer::performRender(GenericSalLayout const & rLayout, Sa
}
const WinFontInstance& rWinFont = static_cast(rLayout.GetFont());
+float fHScale = rWinFont.getHScale();
float lfEmHeight = 0;
IDWriteFontFace* pFontFace = GetDWriteFace(rWinFont, );
@@ -264,11 +251,11 @@ bool
D2DWriteTextOutRenderer::performRender(GenericSalLayout const & rLayout, Sa
while (rLayout.GetNextGlyph(, aPos, nStart))
{
UINT16 glyphIndices[] = { static_cast(pGlyph->glyphId()) };
-FLOAT glyphAdvances[] = { static_cast(pGlyph->newWidth()) };
+FLOAT glyphAdvances[] = { static_cast(pGlyph->newWidth()) /
fHScale };
DWRITE_GLYPH_OFFSET glyphOffsets[] = { { 0.0f, 0.0f }, };
-D2D1_POINT_2F baseline = { static_cast(aPos.getX() -
bounds.Left()),
+D2D1_POINT_2F baseline = { static_cast(aPos.getX() -
bounds.Left()) / fHScale,
static_cast(aPos.getY() -
bounds.Top()) };
-WinFontTransformGuard aTransformGuard(mpRT, rLayout, baseline,
pGlyph->IsVertical());
+WinFontTransformGuard aTransformGuard(mpRT, fHScale, rLayout,
baseline, pGlyph->IsVertical());
DWRITE_GLYPH_RUN glyphs = {
pFontFace,
lfEmHeight,
@@ -319,7 +306,7 @@ IDWriteFontFace*
D2DWriteTextOutRenderer::GetDWriteFace(const WinFontInstance& r
return pFontFace;
}
-WinFontTransformGuard::WinFontTransformGuard(ID2D1RenderTarget* pRenderTarget,
+WinFontTransformGuard::WinFontTransformGuard(ID2D1RenderTarget* pRenderTarget,
float fHScale,
const GenericSalLayout& rLayout,
const D2D1_POINT_2F& rBaseline,
bool bIsVertical)
@@ -327,6 +314,11 @@
WinFontTransformGuard::WinFontTransformGuard(ID2D1RenderTarget* pRenderTarget,
{
pRenderTarget->GetTransform();
D2D1::Matrix3x2F aTransform = maTransform;
+if (fHScale != 1.0f)
+{
+aTransform
+= aTransform * D2D1::Matrix3x2F::Scale(D2D1::Size(fHScale, 1.0f),
D2D1::Point2F(0, 0));
+}
Degree10
core.git: sw/qa sw/source
sw/qa/core/layout/data/bad-split-section.odt |binary
sw/qa/core/layout/layact.cxx | 22 ++
sw/source/core/inc/sectfrm.hxx |2 +-
sw/source/core/layout/layact.cxx |4 ++--
4 files changed, 25 insertions(+), 3 deletions(-)
New commits:
commit 607fcac441c7f3a7d3c169c19039e581d707f2bb
Author: Miklos Vajna
AuthorDate: Mon Apr 8 06:36:37 2024 +0200
Commit: Miklos Vajna
CommitDate: Mon Apr 8 08:05:33 2024 +0200
tdf#160067 sw floattable: fix missing move bwd of paras in split section
frame
The last (5th) paragraph in the index was on page 2, even if page 1
still had space for it.
This is a regression from commit
397d72e582c725d162c7e0b819dc6c0bb62e42b0 (Related: tdf#158986 sw
floattable: fix unexpected page break with sections, 2024-02-23), in
case SwLayAction::FormatLayout() doesn't calc its lower content frames
then this bugdoc is good, but the old bugdoc moves its floating table to
the next page, which would be bad.
Fix the problem by making the condition for this "calc lower in
FormatLayout()" action more strict: only do this for content frames
which are in sections, followed by sections.
Note that probably a cleaner way would be to completely stop calculating
content frames in SwLayAction::FormatLayout() and only do that in
FormatContent(), but then it's not clear how to re-fix tdf#158986, and
at least this resolves the regression.
Change-Id: Id671b3b68d8af8ad1cca3399a9aa028de58df3a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165878
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/qa/core/layout/data/bad-split-section.odt
b/sw/qa/core/layout/data/bad-split-section.odt
new file mode 100644
index ..6dbd07802dfd
Binary files /dev/null and b/sw/qa/core/layout/data/bad-split-section.odt differ
diff --git a/sw/qa/core/layout/layact.cxx b/sw/qa/core/layout/layact.cxx
index 8923d6b0e89a..9de0c9ebfa43 100644
--- a/sw/qa/core/layout/layact.cxx
+++ b/sw/qa/core/layout/layact.cxx
@@ -21,6 +21,7 @@
#include
#include
#include
+#include
namespace
{
@@ -108,6 +109,27 @@ CPPUNIT_TEST_FIXTURE(Test, testSplitFlyInSection)
CPPUNIT_ASSERT(pPage2);
CPPUNIT_ASSERT(!pPage2->GetSortedObjs());
}
+
+CPPUNIT_TEST_FIXTURE(Test, testBadSplitSection)
+{
+// Given a document with a section, containing 5 paragraphs:
+createSwDoc("bad-split-section.odt");
+
+// When laying out that document:
+SwDoc* pDoc = getSwDoc();
+SwRootFrame* pLayout = pDoc->getIDocumentLayoutAccess().GetCurrentLayout();
+
+// Then make sure the entire section is on page 1:
+auto pPage = pLayout->Lower()->DynCastPageFrame();
+CPPUNIT_ASSERT(pPage);
+auto pBody = pPage->FindBodyCont();
+CPPUNIT_ASSERT(pBody);
+auto pSection = dynamic_cast(pBody->GetLastLower());
+CPPUNIT_ASSERT(pSection);
+// Without the fix in place, it would have failed, the section was split
between page 1 and page
+// 2.
+CPPUNIT_ASSERT(!pSection->GetFollow());
+}
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/inc/sectfrm.hxx b/sw/source/core/inc/sectfrm.hxx
index 69158b335863..9dbf9f4df9cc 100644
--- a/sw/source/core/inc/sectfrm.hxx
+++ b/sw/source/core/inc/sectfrm.hxx
@@ -46,7 +46,7 @@ namespace o3tl {
template<> struct typed_flags :
is_typed_flags {};
}
-class SwSectionFrame final: public SwLayoutFrame, public SwFlowFrame
+class SAL_DLLPUBLIC_RTTI SwSectionFrame final: public SwLayoutFrame, public
SwFlowFrame
, public SvtListener // TODO?
{
SwSection* m_pSection;
diff --git a/sw/source/core/layout/layact.cxx b/sw/source/core/layout/layact.cxx
index 5add4e40a8a7..a7933214f5c7 100644
--- a/sw/source/core/layout/layact.cxx
+++ b/sw/source/core/layout/layact.cxx
@@ -1439,9 +1439,9 @@ bool SwLayAction::FormatLayout( OutputDevice
*pRenderContext, SwLayoutFrame *pLa
PopFormatLayout();
}
}
-else if (pLay->IsSctFrame() && pLow->IsTextFrame() && pLow ==
pLay->GetLastLower())
+else if (pLay->IsSctFrame() && pLay->GetNext() &&
pLay->GetNext()->IsSctFrame() && pLow->IsTextFrame() && pLow ==
pLay->GetLastLower())
{
-// else: only calc the last text lower of sections
+// else: only calc the last text lower of sections, followed by
sections
pLow->OptCalc();
}
