Re: [Libreoffice] [REVIEW] Patch for importing hyperliks from .doc files
Hi there, On Tue, 2011-09-27 at 16:03 +0200, Knut Olav Bøhmer wrote: Here is the LibreOffice bug report: https://bugs.freedesktop.org/show_bug.cgi?id=41255 ... I did not check if the patch was applied in latest LibreOffice git repository. If it is, I can just close the bug. It isn't sadly ... it's fantastic to have your patch, thanks for doing that ! Caolan (who is really the expert here and wrote the original patch) had a few concerns about it. Thank you for all the help :) Sorry it's taken so long to get reviewed, I guess having more sample documents, a unit / regression test and/or digging out the link into Microsoft's documentation for these streams - which in theory is now published and complete might really help speed this up (?). ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Patch for importing hyperliks from .doc files
Hello, Here is the LibreOffice bug report: https://bugs.freedesktop.org/show_bug.cgi?id=41255 I did not check if the patch was applied in latest LibreOffice git repository. If it is, I can just close the bug. Thank you for all the help :) Best regards Knut Olav Bøhmer 2011/9/8 Harald Kagerer har...@binder-kagerer.de: Hi, Hyperlinks in theese two location was wrong (as I already explaind in the bugreport): gsf cat buggy.doc WordDocument # (I guess this is where FormFields are located) gsf cat buggy.doc Data This was right: gsf cat buggy.doc DocumentSummaryInformation And that's what your patch is using. If LibreOffice would use anything else for this docs, it would be wrong. So if you change it again, I can not use it. Harald, can you confirm that this patch fixes the problem for your docs too? I would like to confirm, that Knut's patch would solve a serious problem we have to face at the Munic Limux Project converting *.doc documents with hyperlinks to ODF. At the moment our only workaround is to use the MSO buildin converter :-( I really would prefer to use LO for this task as soon as possible!!! Greetings Harald Kagerer -- Harald Kagerer har...@binder-kagerer.de PGP Key-ID: 0xB2792619 Fingerprint: 8763 31EA 65F8 D4BB 3501 E8D3 2728 CF77 B279 2619 () /\ -- Knut Olav Bøhmer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Patch for importing hyperliks from .doc files
Hi, Hyperlinks in theese two location was wrong (as I already explaind in the bugreport): gsf cat buggy.doc WordDocument # (I guess this is where FormFields are located) gsf cat buggy.doc Data This was right: gsf cat buggy.doc DocumentSummaryInformation And that's what your patch is using. If LibreOffice would use anything else for this docs, it would be wrong. So if you change it again, I can not use it. Harald, can you confirm that this patch fixes the problem for your docs too? I would like to confirm, that Knut's patch would solve a serious problem we have to face at the Munic Limux Project converting *.doc documents with hyperlinks to ODF. At the moment our only workaround is to use the MSO buildin converter :-( I really would prefer to use LO for this task as soon as possible!!! Greetings Harald Kagerer -- Harald Kagerer har...@binder-kagerer.de PGP Key-ID: 0xB2792619 Fingerprint: 8763 31EA 65F8 D4BB 3501 E8D3 2728 CF77 B279 2619 () /\ signature.asc Description: Dies ist ein digital signierter Nachrichtenteil ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Patch for importing hyperliks from .doc files
2011/9/7 Caolán McNamara caol...@redhat.com: On Mon, 2011-09-05 at 23:57 +0200, Knut Olav Bøhmer wrote: 2011/9/5 Caolán McNamara caol...@redhat.com: On Sun, 2011-09-04 at 00:29 +0200, Knut Olav Břhmer wrote: Hi, This patch solves a serious problem experienced by many companies and need to be included in libreoffice. I'm using this patch with my own build for my customers with ooo 3.2.1 http://openoffice.org/bugzilla/show_bug.cgi?id=114485 Which patch exactly, my patch from #12 or #15 above or something additional ? I think I was using the update patch to handle real-world documents. But it was so long time ago that I compiled it so I don't remember. Do you remember what you needed to improve to make it correct? Is there any example where the patch would not work? The reason I didn't go ahead with that patch IIRC, is because there appear to be *three* places where the hyperlink gets set, and the patch sets two of them, but not the two that really matter. i.e. there's the inline hyperlink in the field itself, there's some hyperlinks stored in the DocumentSummaryStream metadata, and then there's hyperlinks in the data stream associated with basically some FormField structure linked to the field. I think my patch set the DocumentSummaryStream one, but hacking documents manually showed that word used the FormField one if it exists over the metadata one, so I don't think the patch is quite right. Well, in my buggy.doc the hyperlink was located 3 places. Hyperlinks in theese two location was wrong (as I already explaind in the bugreport): gsf cat buggy.doc WordDocument # (I guess this is where FormFields are located) gsf cat buggy.doc Data This was right: gsf cat buggy.doc DocumentSummaryInformation And that's what your patch is using. If LibreOffice would use anything else for this docs, it would be wrong. So if you change it again, I can not use it. Harald, can you confirm that this patch fixes the problem for your docs too? Noel was playing with the fieldfield stuff IIRC, new parsers and the like, which might have some bearing on these, at least on getting the parser right to read the same hyperlink value as word reads. I don't know, but if there is no hyperlink in DocumentSummaryInformation, then word might use the FormField link over the Data one. Best regartds -- Knut Olav Bøhmer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Patch for importing hyperliks from .doc files
On 07/09/11 09:02, Caolán McNamara wrote: On Mon, 2011-09-05 at 23:57 +0200, Knut Olav Bøhmer wrote: 2011/9/5 Caolán McNamaracaol...@redhat.com: On Sun, 2011-09-04 at 00:29 +0200, Knut Olav Břhmer wrote: [...] Noel was playing with the fieldfield stuff IIRC, new parsers and the like, which might have some bearing on these, at least on getting the parser right to read the same hyperlink value as word reads. C. At the moment I kinda lack the context of the above ( and due to my ongoing mail problems with the list I even miss the beginning of this thread ) However in my adventures with the formfield stuff I don't recall doing anything with hyperlinks per-se, I might have tweaked some offset or something to do with a hyperlink record in order to properly read/skip something that was failing over but afaik I didn't tweak anything to do with actual parsing of hyperlinks ( afaik ) Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Patch for importing hyperliks from .doc files
On Sun, 2011-09-04 at 00:29 +0200, Knut Olav Bøhmer wrote: Hi, This patch solves a serious problem experienced by many companies and need to be included in libreoffice. I'm using this patch with my own build for my customers with ooo 3.2.1 http://openoffice.org/bugzilla/show_bug.cgi?id=114485 Which patch exactly, my patch from #12 or #15 above or something additional ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] Patch for importing hyperliks from .doc files
Hi, This patch solves a serious problem experienced by many companies and need to be included in libreoffice. I'm using this patch with my own build for my customers with ooo 3.2.1 http://openoffice.org/bugzilla/show_bug.cgi?id=114485 Best regards -- Knut Olav Bøhmer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Patch for importing hyperliks from .doc files
Hmm, messy since it involves .doc import/export. In any case, here is the new live location for the issue: https://issues.apache.org/ooo/show_bug.cgi?id=114485. In migrating to https://issues.apache.org/ooo/ we lost everyone's passwords. You can restore your account by clicking Forgot Password. At the Login: prompt, enter the e-mail address that goes with your previous user ID (that is, use k...@openoffice.org, not just koho). Finally, click Reset Password. You will receive a password-change token by e-mail. The advantage is all live-links of your ID on bugzilla pages will be restored and you will have your My bugs link will work as well. Bringing it to LibreOffice attention is a good idea. I just wanted you to know that you still have a common place to maintain this and other bugs if you choose to do so. Keeping the common number helps us synchronize fixes between LibreOffice and Apache OpenOffice at some point. - Dennis (PS: I am putting up more information on the new URL and the password reset on openoffice.org lists and forums later today here in UTC-0700.) -Original Message- From: libreoffice-bounces+dennis.hamilton=acm@lists.freedesktop.org [mailto:libreoffice-bounces+dennis.hamilton=acm@lists.freedesktop.org] On Behalf Of Knut Olav Bøhmer Sent: Saturday, September 03, 2011 15:30 To: Caolán McNamara; libreoffice Cc: Harald Kagerer Subject: [Libreoffice] [REVIEW] Patch for importing hyperliks from .doc files Hi, This patch solves a serious problem experienced by many companies and need to be included in libreoffice. I'm using this patch with my own build for my customers with ooo 3.2.1 http://openoffice.org/bugzilla/show_bug.cgi?id=114485 Best regards -- Knut Olav Bøhmer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Patch for importing hyperliks from .doc files
I said I just wanted you to know that you still have a common place to maintain this and other bugs if you choose to do so. Keeping the common number helps us synchronize fixes between LibreOffice and Apache OpenOffice at some point. I was only thinking only of issues that are already recorded on the OpenOffice.org bugzilla. To track resolution in LibreOffice, I think a new issue would be needed. In that case, it would be valuable to cross-reference. The same can be done if a reported defect at LibreOffice inspires creation of an issue against the Apache ooo code base as well. (I am not assuming we would use each other's patches, since there may be license and permission incompatibilities.) Also, if an id@openoffice.org e-mail is no longer received correctly, it is not possible to restore that account on the Apache bugzilla. The best that can be done is to create a new account at https://issues.apache.org/ooo/. The My bugs list will be a new empty one. -Original Message- From: libreoffice-bounces+dennis.hamilton=acm@lists.freedesktop.org [mailto:libreoffice-bounces+dennis.hamilton=acm@lists.freedesktop.org] On Behalf Of Dennis E. Hamilton Sent: Saturday, September 03, 2011 16:24 To: 'Knut Olav Bøhmer'; 'Caolán McNamara'; 'libreoffice' Cc: 'Harald Kagerer' Subject: Re: [Libreoffice] [REVIEW] Patch for importing hyperliks from .doc files Hmm, messy since it involves .doc import/export. In any case, here is the new live location for the issue: https://issues.apache.org/ooo/show_bug.cgi?id=114485. In migrating to https://issues.apache.org/ooo/ we lost everyone's passwords. You can restore your account by clicking Forgot Password. At the Login: prompt, enter the e-mail address that goes with your previous user ID (that is, use k...@openoffice.org, not just koho). Finally, click Reset Password. You will receive a password-change token by e-mail. The advantage is all live-links of your ID on bugzilla pages will be restored and you will have your My bugs link will work as well. Bringing it to LibreOffice attention is a good idea. I just wanted you to know that you still have a common place to maintain this and other bugs if you choose to do so. Keeping the common number helps us synchronize fixes between LibreOffice and Apache OpenOffice at some point. - Dennis (PS: I am putting up more information on the new URL and the password reset on openoffice.org lists and forums later today here in UTC-0700.) -Original Message- From: libreoffice-bounces+dennis.hamilton=acm@lists.freedesktop.org [mailto:libreoffice-bounces+dennis.hamilton=acm@lists.freedesktop.org] On Behalf Of Knut Olav Bøhmer Sent: Saturday, September 03, 2011 15:30 To: Caolán McNamara; libreoffice Cc: Harald Kagerer Subject: [Libreoffice] [REVIEW] Patch for importing hyperliks from .doc files Hi, This patch solves a serious problem experienced by many companies and need to be included in libreoffice. I'm using this patch with my own build for my customers with ooo 3.2.1 http://openoffice.org/bugzilla/show_bug.cgi?id=114485 Best regards -- Knut Olav Bøhmer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
