New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 10 new defect(s) introduced to LibreOffice found with Coverity Scan. 5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 10 of 10 defect(s) ** CID 1497939: Integer handling issues (DIVIDE_BY_ZERO) /tools/source/generic/fract.cxx: 186 in ::checked_multiply_by(boost::rational &, const boost::rational &)() *** CID 1497939: Integer handling issues (DIVIDE_BY_ZERO) /tools/source/generic/fract.cxx: 186 in ::checked_multiply_by(boost::rational &, const boost::rational &)() 180 181 // Avoid overflow and preserve normalization 182 sal_Int32 gcd1 = std::gcd(i.numerator(), den); 183 sal_Int32 gcd2 = std::gcd(num, i.denominator()); 184 185 bool fail = false; >>> CID 1497939: Integer handling issues (DIVIDE_BY_ZERO) >>> In expression "i->numerator() / gcd1", division by expression "gcd1" >>> which may be zero has undefined behavior. 186 fail |= o3tl::checked_multiply(i.numerator() / gcd1, num / gcd2, num); 187 fail |= o3tl::checked_multiply(i.denominator() / gcd2, den / gcd1, den); 188 189 if (!fail) 190 i.assign(num, den); 191 ** CID 1497938: Uninitialized members (UNINIT_CTOR) /vcl/source/gdi/print3.cxx: 208 in vcl::ImplPrinterControllerData::ImplPrinterControllerData()() *** CID 1497938: Uninitialized members (UNINIT_CTOR) /vcl/source/gdi/print3.cxx: 208 in vcl::ImplPrinterControllerData::ImplPrinterControllerData()() 202 mbPapersizeFromUser( false ), 203 mbOrientationFromUser( false ), 204 mbPrinterModified( false ), 205 meJobState( css::view::PrintableState_JOB_STARTED ), 206 mnDefaultPaperBin( -1 ), 207 mnFixedPaperBin( -1 ) >>> CID 1497938: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "meUserOrientation" is not initialized in this >>> constructor nor in any functions that it calls. 208 {} 209 210 ~ImplPrinterControllerData() 211 { 212 if (mxProgress) 213 { ** CID 1497937: Integer handling issues (DIVIDE_BY_ZERO) /tools/source/generic/fract.cxx: 186 in ::checked_multiply_by(boost::rational &, const boost::rational &)() *** CID 1497937: Integer handling issues (DIVIDE_BY_ZERO) /tools/source/generic/fract.cxx: 186 in ::checked_multiply_by(boost::rational &, const boost::rational &)() 180 181 // Avoid overflow and preserve normalization 182 sal_Int32 gcd1 = std::gcd(i.numerator(), den); 183 sal_Int32 gcd2 = std::gcd(num, i.denominator()); 184 185 bool fail = false; >>> CID 1497937: Integer handling issues (DIVIDE_BY_ZERO) >>> In expression "num / gcd2", division by expression "gcd2" which may be >>> zero has undefined behavior. 186 fail |= o3tl::checked_multiply(i.numerator() / gcd1, num / gcd2, num); 187 fail |= o3tl::checked_multiply(i.denominator() / gcd2, den / gcd1, den); 188 189 if (!fail) 190 i.assign(num, den); 191 ** CID 1497936: API usage errors (SWAPPED_ARGUMENTS) *** CID 1497936: API usage errors (SWAPPED_ARGUMENTS) /vcl/source/gdi/print3.cxx: 236 in vcl::ImplPrinterControllerData::getRealPaperSize(const Size &, bool) const() 230 if(mbOrientationFromUser) 231 { 232 if ( (meUserOrientation == Orientation::Portrait && size.Width() > size.Height()) || 233 (meUserOrientation == Orientation::Landscape && size.Width() < size.Height()) ) 234 { 235 // coverity[swapped-arguments : FALSE] - this is in the correct order >>> CID 1497936: API usage errors (SWAPPED_ARGUMENTS) >>> The positions of arguments in the constructor for "Size" do not match >>> the ordering of the parameters: * "size.Height()" is passed to "nWidth". * "size.Width()" is passed to "nHeight". 236 size = Size( size.Height(), size.Width() ); 237 } 238 } 239 return size; 240 } 241 PrinterController::PageSize modifyJobSetup( const css::uno::Sequence< css::beans::PropertyValue >& i_rProps ); ** CID 1497935: Integer handling issues (DIVIDE_BY_ZERO) /include/o3tl/unit_conversion.hxx: 138
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1497924:(DEADCODE) /sc/source/ui/view/viewdata.cxx: 1937 in ScViewData::EditGrowX()() /sc/source/ui/view/viewdata.cxx: 1936 in ScViewData::EditGrowX()() *** CID 1497924:(DEADCODE) /sc/source/ui/view/viewdata.cxx: 1937 in ScViewData::EditGrowX()() 1931 1932 aArea.AdjustLeft( -((bLayoutRTL && !bLOKActive) ? nLogicRight : nLogicLeft) ); 1933 aArea.AdjustRight((bLayoutRTL && !bLOKActive) ? nLogicLeft : nLogicRight ); 1934 if (bLOKPrintTwips) 1935 { 1936 aAreaPTwips.AdjustLeft( -((bLayoutRTL && !bLOKActive) ? nLogicRightPTwips : nLogicLeftPTwips) ); >>> CID 1497924:(DEADCODE) >>> Execution cannot reach the expression "nLogicLeftPTwips" inside this >>> statement: "aAreaPTwips.AdjustRight(((b...". 1937 aAreaPTwips.AdjustRight((bLayoutRTL && !bLOKActive) ? nLogicLeftPTwips : nLogicRightPTwips ); 1938 } 1939 1940 if ( aArea.Right() > aArea.Left() + aSize.Width() - 1 ) 1941 { 1942 tools::Long nCenter = ( aArea.Left() + aArea.Right() ) / 2; /sc/source/ui/view/viewdata.cxx: 1936 in ScViewData::EditGrowX()() 1930 } 1931 1932 aArea.AdjustLeft( -((bLayoutRTL && !bLOKActive) ? nLogicRight : nLogicLeft) ); 1933 aArea.AdjustRight((bLayoutRTL && !bLOKActive) ? nLogicLeft : nLogicRight ); 1934 if (bLOKPrintTwips) 1935 { >>> CID 1497924:(DEADCODE) >>> Execution cannot reach the expression "nLogicRightPTwips" inside this >>> statement: "aAreaPTwips.AdjustLeft(-((b...". 1936 aAreaPTwips.AdjustLeft( -((bLayoutRTL && !bLOKActive) ? nLogicRightPTwips : nLogicLeftPTwips) ); 1937 aAreaPTwips.AdjustRight((bLayoutRTL && !bLOKActive) ? nLogicLeftPTwips : nLogicRightPTwips ); 1938 } 1939 1940 if ( aArea.Right() > aArea.Left() + aSize.Width() - 1 ) 1941 { ** CID 1497923:(DEADCODE) /sc/source/ui/view/viewdata.cxx: 2031 in ScViewData::EditGrowX()() /sc/source/ui/view/viewdata.cxx: 2016 in ScViewData::EditGrowX()() *** CID 1497923:(DEADCODE) /sc/source/ui/view/viewdata.cxx: 2031 in ScViewData::EditGrowX()() 2025 if ( aArea.Right() > aArea.Left() + aSize.Width() - 1 ) 2026 { 2027 if ( bLayoutRTL && !bLOKActive ) 2028 { 2029 aArea.SetLeft( aArea.Right() - aSize.Width() + 1 ); 2030 if (bLOKPrintTwips) >>> CID 1497923:(DEADCODE) >>> Execution cannot reach this statement: "aAreaPTwips.SetLeft(aAreaPT...". 2031 aAreaPTwips.SetLeft( aAreaPTwips.Right() - aSizePTwips.Width() + 1 ); 2032 } 2033 else 2034 { 2035 aArea.SetRight( aArea.Left() + aSize.Width() - 1 ); 2036 if (bLOKPrintTwips) /sc/source/ui/view/viewdata.cxx: 2016 in ScViewData::EditGrowX()() 2010 tools::Long nLogicWidth = pWin->PixelToLogic(Size(nPix,0)).Width(); 2011 tools::Long& nLogicWidthPTwips = nColWidth; 2012 if ( bLayoutRTL && !bLOKActive ) 2013 { 2014 aArea.AdjustLeft( -nLogicWidth ); 2015 if (bLOKPrintTwips) >>> CID 1497923:(DEADCODE) >>> Execution cannot reach this statement: "aAreaPTwips.AdjustLeft(-nLo...". 2016 aAreaPTwips.AdjustLeft( -nLogicWidthPTwips ); 2017 } 2018 else 2019 { 2020 aArea.AdjustRight(nLogicWidth ); 2021 if (bLOKPrintTwips) To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DdmSt_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiK8z4nI92mF-2FTV1gOJbYZXBdsBbGyB-2FneQaoH9oKSYu3gHpfP7vbzj-2FeKsqa2e998IHAS7OUn9K6v86jNRR2SUTfl73ctZMtXfHVVWkef4h2qloYw-2BCAJjZUWfUrKJOLV0vPtqLt0z-2FDW7nv9OjlPZVSDpbpEgqerg7agrZUC1tA-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 7 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1497868: Control flow issues (DEADCODE) /sc/source/ui/view/tabview3.cxx: 2394 in ScTabView::PaintArea(short, int, short, int, ScUpdateMode)() *** CID 1497868: Control flow issues (DEADCODE) /sc/source/ui/view/tabview3.cxx: 2394 in ScTabView::PaintArea(short, int, short, int, ScUpdateMode)() 2388 // the width of the embedded text. 2389 // Anyway, clients will ask only for tiles that overlaps 2390 // the visible area. 2391 // Remember that wsd expects int and that aEnd.X() is 2392 // in pixels and will be converted in twips, before performing 2393 // the lok callback, so we need to avoid that an overflow occurs. >>> CID 1497868: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "bLayoutRTL" inside this >>> statement: "aEnd.setX(((!bIsTiledRender...". 2394 aEnd.setX( (!bIsTiledRendering && bLayoutRTL) ? 0 : std::numeric_limits::max() / 1000 ); 2395 } 2396 else 2397 { 2398 aEnd.setX( (!bIsTiledRendering && bLayoutRTL) ? 0 : pGridWin[i]->GetOutputSizePixel().Width() ); 2399 } To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DXML-_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJifv7nWhHTqPuUeTFDuCfkA-2FnbLXrmcqWiEROiN-2F1PupstMkH3lsx339vDwDogHwCrWYaXSuyYPZ7ryfnjVzA21y4HLKh5Nc19u6CtP1RCIwcT9OsdKL-2BT-2FDX5NIHUVoVF-2FzRfVKOylRem-2FFn6Fa7CE1dZzddz0JIo5opDkGbnvXo-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 6 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 6 of 6 defect(s) ** CID 1497861: Null pointer dereferences (FORWARD_NULL) *** CID 1497861: Null pointer dereferences (FORWARD_NULL) /vcl/unx/gtk3/gtkinst.cxx: 6199 in ::GtkInstanceWindow::change_default_widget(weld::Widget *, weld::Widget *)() 6193 GtkWidget* pWidgetOld = pGtkOld->getWidget(); 6194 g_object_set(G_OBJECT(pWidgetOld), "has-default", false, nullptr); 6195 } 6196 if (pNew) 6197 { 6198 GtkInstanceWidget* pGtkNew = dynamic_cast(pNew); >>> CID 1497861: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pGtkNew" to "getWidget", which dereferences it. 6199 GtkWidget* pWidgetNew = pGtkNew->getWidget(); 6200 g_object_set(G_OBJECT(pWidgetNew), "has-default", true, nullptr); 6201 } 6202 #endif 6203 } 6204 ** CID 1497860: Null pointer dereferences (FORWARD_NULL) *** CID 1497860: Null pointer dereferences (FORWARD_NULL) /vcl/source/app/salvtables.cxx: 1519 in SalInstanceWindow::change_default_widget(weld::Widget *, weld::Widget *)() 1513 SalInstanceWidget* pVclOld = dynamic_cast(pOld); 1514 pVclOld->getWidget()->set_property("has-default", OUString::boolean(false)); 1515 } 1516 if (pNew) 1517 { 1518 SalInstanceWidget* pVclNew = dynamic_cast(pNew); >>> CID 1497860: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pVclNew" to "getWidget", which dereferences it. 1519 pVclNew->getWidget()->set_property("has-default", OUString::boolean(true)); 1520 } 1521 } 1522 1523 bool SalInstanceWindow::is_default_widget(const weld::Widget* pCandidate) const 1524 { ** CID 1497859: Null pointer dereferences (FORWARD_NULL) *** CID 1497859: Null pointer dereferences (FORWARD_NULL) /vcl/source/app/salvtables.cxx: 1526 in SalInstanceWindow::is_default_widget(const weld::Widget *) const() 1520 } 1521 } 1522 1523 bool SalInstanceWindow::is_default_widget(const weld::Widget* pCandidate) const 1524 { 1525 const SalInstanceWidget* pVclCandidate = dynamic_cast(pCandidate); >>> CID 1497859: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pVclCandidate" to "getWidget", which dereferences >>> it. 1526 return pVclCandidate->getWidget()->GetStyle() & WB_DEFBUTTON; 1527 } 1528 1529 void SalInstanceWindow::set_window_state(const OString& rStr) 1530 { 1531 SystemWindow* pSysWin = dynamic_cast(m_xWindow.get()); ** CID 1497858: Null pointer dereferences (FORWARD_NULL) *** CID 1497858: Null pointer dereferences (FORWARD_NULL) /vcl/unx/gtk3/gtkinst.cxx: 6193 in ::GtkInstanceWindow::change_default_widget(weld::Widget *, weld::Widget *)() 6187 #else 6188 if (!pOld) 6189 recursively_unset_default_buttons(); 6190 else 6191 { 6192 GtkInstanceWidget* pGtkOld = dynamic_cast(pOld); >>> CID 1497858: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pGtkOld" to "getWidget", which dereferences it. 6193 GtkWidget* pWidgetOld = pGtkOld->getWidget(); 6194 g_object_set(G_OBJECT(pWidgetOld), "has-default", false, nullptr); 6195 } 6196 if (pNew) 6197 { 6198 GtkInstanceWidget* pGtkNew = dynamic_cast(pNew); ** CID 1497857: Null pointer dereferences (FORWARD_NULL) *** CID 1497857: Null pointer dereferences (FORWARD_NULL) /vcl/source/app/salvtables.cxx: 1514 in SalInstanceWindow::change_default_widget(weld::Widget *, weld::Widget *)() 1508 { 1509 if (!pOld) 1510 recursively_unset_default_buttons(); 1511 else 1512 { 1513 SalInstanceWidget* pVclOld = dynamic_cast(pOld); >>> CID 1497857: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pVclOld" to "getWidget", which dereferences it. 1514
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1497619: Uninitialized members (UNINIT_CTOR) /vcl/source/app/svdata.cxx: 482 in ImplSVAppData::ImplSVAppData()() *** CID 1497619: Uninitialized members (UNINIT_CTOR) /vcl/source/app/svdata.cxx: 482 in ImplSVAppData::ImplSVAppData()() 476 ImplSVData::~ImplSVData() {} 477 478 ImplSVAppData::ImplSVAppData() 479 { 480 m_bUseSystemLoop = getenv("SAL_USE_SYSTEM_LOOP") != nullptr; 481 SAL_WARN_IF(m_bUseSystemLoop, "vcl.schedule", "Overriding to run LO on system event loop!"); >>> CID 1497619: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "mpAccelMgr" is not initialized in this >>> constructor nor in any functions that it calls. 482 } 483 484 ImplSVAppData::~ImplSVAppData() {} 485 ImplSVGDIData::~ImplSVGDIData() {} 486 ImplSVFrameData::~ImplSVFrameData() {} 487 ImplSVWinData::~ImplSVWinData() {} 488 ImplSVHelpData::~ImplSVHelpData() {} 489 To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DJwKN_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJieRDa8tM-2BoZPCCgB094oequd8cjbkR2GY0DH4w9M2rvrvg2oZT1LXnaUmp71eSdlRkmKlrrKZYSbsUYS3yq-2FFbL5m6zKzM71UUEVpm09Dvys3qJ3JXAKCt0AxFV0AVHGTjtjj1siR7p2kLT0dbAYTQgZIO3s-2Fg6RVUEJi-2F5cXu68-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1497461: Control flow issues (DEADCODE) /chart2/source/model/template/ChartTypeManager.cxx: 515 in chart::ChartTypeManager::createTemplate(const rtl::OUString &)() *** CID 1497461: Control flow issues (DEADCODE) /chart2/source/model/template/ChartTypeManager.cxx: 515 in chart::ChartTypeManager::createTemplate(const rtl::OUString &)() 509 break; 510 default: break; 511 //case TEMPLATE_SURFACE: 512 //case TEMPLATE_ADDIN: 513 // break; 514 >>> CID 1497461: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "case ::TEMPLATE_NO...". 515 case TEMPLATE_NOT_FOUND: 516 assert( false ); 517 break; 518 } 519 520 return xTemplate; To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DQpz7_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiI-2B4F4IUt4TxRM-2F5J0SK3BilUwfLYxnCagajiillc9o07iZ4-2FOAkkpENkuvr3JeeVXN5-2B32jnuoxNKiFxcBCGIwcQ-2BmR-2BWGTGmxxjHh8RmUe3GzeebndENrzKRhjYCSQh4JdunjBpZzr0hq-2BpSmUaIs-2FN-2Fvqth1w-2FmWCOaaE0t3g-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 3 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1497094: Uninitialized members (UNINIT_CTOR) /svx/source/items/customshapeitem.cxx: 41 in SdrCustomShapeGeometryItem::SdrCustomShapeGeometryItem(const com::sun::star::uno::Sequence &)() *** CID 1497094: Uninitialized members (UNINIT_CTOR) /svx/source/items/customshapeitem.cxx: 41 in SdrCustomShapeGeometryItem::SdrCustomShapeGeometryItem(const com::sun::star::uno::Sequence &)() 35 {} 36 37 SdrCustomShapeGeometryItem::SdrCustomShapeGeometryItem( const uno::Sequence< beans::PropertyValue >& rVal ) 38 : SfxPoolItem( SDRATTR_CUSTOMSHAPE_GEOMETRY ) 39 { 40 SetPropSeq( rVal ); >>> CID 1497094: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "aHash" is not initialized in this constructor >>> nor in any functions that it calls. 41 } 42 43 css::uno::Any* SdrCustomShapeGeometryItem::GetPropertyValueByName( const OUString& rPropName ) 44 { 45 css::uno::Any* pRet = nullptr; 46 PropertyHashMap::iterator aHashIter( aPropHashMap.find( rPropName ) ); ** CID 1497093: Uninitialized members (UNINIT_CTOR) /svx/source/items/customshapeitem.cxx: 35 in SdrCustomShapeGeometryItem::SdrCustomShapeGeometryItem()() *** CID 1497093: Uninitialized members (UNINIT_CTOR) /svx/source/items/customshapeitem.cxx: 35 in SdrCustomShapeGeometryItem::SdrCustomShapeGeometryItem()() 29 using namespace ::std; 30 using namespace com::sun::star; 31 32 33 SdrCustomShapeGeometryItem::SdrCustomShapeGeometryItem() 34 : SfxPoolItem( SDRATTR_CUSTOMSHAPE_GEOMETRY ) >>> CID 1497093: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "aHash" is not initialized in this constructor >>> nor in any functions that it calls. 35 {} 36 37 SdrCustomShapeGeometryItem::SdrCustomShapeGeometryItem( const uno::Sequence< beans::PropertyValue >& rVal ) 38 : SfxPoolItem( SDRATTR_CUSTOMSHAPE_GEOMETRY ) 39 { 40 SetPropSeq( rVal ); ** CID 1497092: Incorrect expression (UNINTENDED_INTEGER_DIVISION) /sc/source/ui/view/output.cxx: 923 in ::drawIconSets(OutputDevice &, const ScIconSetInfo *, const tools::Rectangle &, long, long, std::map, std::allocator>> &)() *** CID 1497092: Incorrect expression (UNINTENDED_INTEGER_DIVISION) /sc/source/ui/view/output.cxx: 923 in ::drawIconSets(OutputDevice &, const ScIconSetInfo *, const tools::Rectangle &, long, long, std::map, std::allocator>> &)() 917 tools::Long aHeight = o3tl::convert(10, o3tl::Length::pt, o3tl::Length::mm100); 918 919 if (pOldIconSetInfo->mnHeight) 920 aHeight = o3tl::convert(pOldIconSetInfo->mnHeight, o3tl::Length::twip, o3tl::Length::mm100); 921 922 Size aSize = rIcon.GetSizePixel(); >>> CID 1497092: Incorrect expression (UNINTENDED_INTEGER_DIVISION) >>> Dividing integer expressions "aSize.Width()" and "aSize.Height()", and >>> then converting the integer quotient to type "double". Any remainder, or >>> fractional part of the quotient, is ignored. 923 double fRatio = aSize.Width() / aSize.Height(); 924 tools::Long aWidth = fRatio * aHeight; 925 926 rRenderContext.Push(); 927 rRenderContext.SetClipRegion(vcl::Region(rRect)); 928 rRenderContext.DrawBitmapEx(Point(rRect.Left() + 2 * nOneX, rRect.Bottom() - 2 * nOneY - aHeight), Size(aWidth, aHeight), rIcon); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DoVc3_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi8BUTjHh3o7fdlY-2FgGmHgkH7ES0qucQJzWG1ivtDydWKmn3oguIvnCreUuDDkjAo9ZT0h-2BbFVsrLAEhK1JQgumfuXjWJkUDlnlLWvOZhieN3Z6iEZu7JCke08LaZ4TsueN-2BAzc-2FH2R8IVumO25NhAF5rlQC5FMQ4DLKDlcZY8Ac4-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1496843:(UNCAUGHT_EXCEPT) /vcl/workben/minvcl.cxx: 58 in main() /vcl/workben/minvcl.cxx: 58 in main() /vcl/workben/minvcl.cxx: 58 in main() *** CID 1496843:(UNCAUGHT_EXCEPT) /vcl/workben/minvcl.cxx: 58 in main() 52 mpWin->Show(); 53 Execute(); 54 mpWin.disposeAndClear(); 55 return 0; 56 } 57 >>> CID 1496843:(UNCAUGHT_EXCEPT) >>> In function "main()" an exception of type >>> "com::sun::star::uno::RuntimeException" is thrown and never caught. 58 int main() 59 { 60 auto xContext = cppu::defaultBootstrap_InitialComponentContext(); 61 css::uno::Reference xServiceManager( 62 xContext->getServiceManager(), css::uno::UNO_QUERY); 63 comphelper::setProcessServiceFactory(xServiceManager); /vcl/workben/minvcl.cxx: 58 in main() 52 mpWin->Show(); 53 Execute(); 54 mpWin.disposeAndClear(); 55 return 0; 56 } 57 >>> CID 1496843:(UNCAUGHT_EXCEPT) >>> In function "main()" an exception of type >>> "com::sun::star::uno::RuntimeException" is thrown and never caught. 58 int main() 59 { 60 auto xContext = cppu::defaultBootstrap_InitialComponentContext(); 61 css::uno::Reference xServiceManager( 62 xContext->getServiceManager(), css::uno::UNO_QUERY); 63 comphelper::setProcessServiceFactory(xServiceManager); /vcl/workben/minvcl.cxx: 58 in main() 52 mpWin->Show(); 53 Execute(); 54 mpWin.disposeAndClear(); 55 return 0; 56 } 57 >>> CID 1496843:(UNCAUGHT_EXCEPT) >>> In function "main()" an exception of type >>> "com::sun::star::uno::RuntimeException" is thrown and never caught. 58 int main() 59 { 60 auto xContext = cppu::defaultBootstrap_InitialComponentContext(); 61 css::uno::Reference xServiceManager( 62 xContext->getServiceManager(), css::uno::UNO_QUERY); 63 comphelper::setProcessServiceFactory(xServiceManager); ** CID 1496842: Error handling issues (UNCAUGHT_EXCEPT) /vcl/workben/minvcl.cxx: 58 in main() *** CID 1496842: Error handling issues (UNCAUGHT_EXCEPT) /vcl/workben/minvcl.cxx: 58 in main() 52 mpWin->Show(); 53 Execute(); 54 mpWin.disposeAndClear(); 55 return 0; 56 } 57 >>> CID 1496842: Error handling issues (UNCAUGHT_EXCEPT) >>> In function "main()" an exception of type >>> "com::sun::star::uno::DeploymentException" is thrown and never caught. 58 int main() 59 { 60 auto xContext = cppu::defaultBootstrap_InitialComponentContext(); 61 css::uno::Reference xServiceManager( 62 xContext->getServiceManager(), css::uno::UNO_QUERY); 63 comphelper::setProcessServiceFactory(xServiceManager); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DL_eI_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiLpUJ63ohom28eyGrhH5qlY5QkhryKaulSqpHuzZa68Zoh7y0-2FvoyAbqAt-2FJqYg2fhP057YrGS69qmcrIxgwgwU2B5PDRLYNYMsiz5Vf15-2FDd45g34beXRk1oPOqeVKIOKA884GP-2FcIljnG7g-2FpVh-2BZV9ZOZbOy7Q5-2FXT0PyEBA4-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 5 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1495785: Error handling issues (CHECKED_RETURN) /sw/source/core/doc/DocumentRedlineManager.cxx: 459 in ::lcl_DeleteTrackedTableRow(const SwPosition *)() *** CID 1495785: Error handling issues (CHECKED_RETURN) /sw/source/core/doc/DocumentRedlineManager.cxx: 459 in ::lcl_DeleteTrackedTableRow(const SwPosition *)() 453 pPos->GetDoc().DeleteRow( aCursor ); 454 } 455 else 456 { 457 // update property "HasTextChangesOnly" 458 SwRedlineTable::size_type nPos = 0; >>> CID 1495785: Error handling issues (CHECKED_RETURN) >>> Calling "UpdateTextChangesOnly" without checking return value (as is >>> done elsewhere 5 out of 6 times). 459 pLine->UpdateTextChangesOnly(nPos); 460 } 461 } 462 } 463 464 // at rejection of a deletion in a table, remove the tracking of the table row ** CID 1495784: Low impact quality (MISSING_MOVE_ASSIGNMENT) /include/cppu/unotype.hxx: 44 in () *** CID 1495784: Low impact quality (MISSING_MOVE_ASSIGNMENT) /include/cppu/unotype.hxx: 44 in () 38 39 namespace com { namespace sun { namespace star { namespace uno { 40 class Type; 41 class Any; 42 class Exception; 43 template< typename > class Reference; >>> CID 1495784: Low impact quality (MISSING_MOVE_ASSIGNMENT) >>> Class >>> "com::sun::star::uno::Sequence >>> >" may benefit from adding a move assignment operator. See other events >>> which show the copy assignment operator being applied to rvalues, where a >>> move assignment may be faster. 44 template< typename > class Sequence; 45 class XInterface; 46 } } } } 47 namespace rtl { class OUString; } 48 49 namespace cppu { ** CID 1494594:(TOCTOU) /solenv/lockfile/lockfile.c: 320 in lockfile_create_save_tmplock() /solenv/lockfile/lockfile.c: 320 in lockfile_create_save_tmplock() /solenv/lockfile/lockfile.c: 325 in lockfile_create_save_tmplock() /solenv/lockfile/lockfile.c: 320 in lockfile_create_save_tmplock() /solenv/lockfile/lockfile.c: 320 in lockfile_create_save_tmplock() /solenv/lockfile/lockfile.c: 320 in lockfile_create_save_tmplock() *** CID 1494594:(TOCTOU) /solenv/lockfile/lockfile.c: 320 in lockfile_create_save_tmplock() 314 * link() over NFS can't be trusted. 315 * EXTRA FIX: the value of the nlink field 316 * can't be trusted (may be cached). 317 */ 318 (void)!link(tmplock, lockfile); 319 >>> CID 1494594:(TOCTOU) >>> Calling function "lstat" to perform check on "tmplock". 320 if (lstat(tmplock, ) < 0) { 321 tmplock[0] = 0; 322 return L_ERROR; /* Can't happen */ 323 } 324 325 if (lstat(lockfile, ) < 0) { /solenv/lockfile/lockfile.c: 320 in lockfile_create_save_tmplock() 314 * link() over NFS can't be trusted. 315 * EXTRA FIX: the value of the nlink field 316 * can't be trusted (may be cached). 317 */ 318 (void)!link(tmplock, lockfile); 319 >>> CID 1494594:(TOCTOU) >>> Calling function "lstat" to perform check on "tmplock". 320 if (lstat(tmplock, ) < 0) { 321 tmplock[0] = 0; 322 return L_ERROR; /* Can't happen */ 323 } 324 325 if (lstat(lockfile, ) < 0) { /solenv/lockfile/lockfile.c: 325 in lockfile_create_save_tmplock() 319 320 if (lstat(tmplock, ) < 0) { 321 tmplock[0] = 0; 322 return L_ERROR; /* Can't happen */ 323 } 324 >>> CID 1494594:(TOCTOU) >>> Calling function "lstat" to perform check on "lockfile". 325 if (lstat(lockfile, ) < 0) { 326 if (statfailed++ > 5) { 327 /* 328 *
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1495379:(UNCAUGHT_EXCEPT) /sw/source/core/layout/frmtool.cxx: 660 in SwFlyNotify::~SwFlyNotify()() /sw/source/core/layout/frmtool.cxx: 660 in SwFlyNotify::~SwFlyNotify()() *** CID 1495379:(UNCAUGHT_EXCEPT) /sw/source/core/layout/frmtool.cxx: 660 in SwFlyNotify::~SwFlyNotify()() 654 // the Writer fly frame is currently registered at. 655 pOldPage( pFlyFrame->GetPageFrame() ), 656 aFrameAndSpace( pFlyFrame->GetObjRectWithSpaces() ) 657 { 658 } 659 >>> CID 1495379:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 660 SwFlyNotify::~SwFlyNotify() 661 { 662 SwFlyFrame *pFly = static_cast(mpFrame); 663 if ( pFly->IsNotifyBack() ) 664 { 665 SwViewShell *pSh = pFly->getRootFrame()->GetCurrShell(); /sw/source/core/layout/frmtool.cxx: 660 in SwFlyNotify::~SwFlyNotify()() 654 // the Writer fly frame is currently registered at. 655 pOldPage( pFlyFrame->GetPageFrame() ), 656 aFrameAndSpace( pFlyFrame->GetObjRectWithSpaces() ) 657 { 658 } 659 >>> CID 1495379:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 660 SwFlyNotify::~SwFlyNotify() 661 { 662 SwFlyFrame *pFly = static_cast(mpFrame); 663 if ( pFly->IsNotifyBack() ) 664 { 665 SwViewShell *pSh = pFly->getRootFrame()->GetCurrShell(); ** CID 1399158:(UNCAUGHT_EXCEPT) /sw/source/core/layout/frmtool.cxx: 474 in SwLayNotify::~SwLayNotify()() /sw/source/core/layout/frmtool.cxx: 474 in SwLayNotify::~SwLayNotify()() /sw/source/core/layout/frmtool.cxx: 474 in SwLayNotify::~SwLayNotify()() /sw/source/core/layout/frmtool.cxx: 474 in SwLayNotify::~SwLayNotify()() *** CID 1399158:(UNCAUGHT_EXCEPT) /sw/source/core/layout/frmtool.cxx: 474 in SwLayNotify::~SwLayNotify()() 468 pLowerFrame->InvalidateObjs( false ); 469 470 pLowerFrame = pLowerFrame->GetNext(); 471 } 472 } 473 >>> CID 1399158:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 474 SwLayNotify::~SwLayNotify() 475 { 476 SwLayoutFrame *pLay = static_cast(mpFrame); 477 SwRectFnSet aRectFnSet(pLay); 478 bool bNotify = false; 479 if ( pLay->getFramePrintArea().SSize() != maPrt.SSize() ) /sw/source/core/layout/frmtool.cxx: 474 in SwLayNotify::~SwLayNotify()() 468 pLowerFrame->InvalidateObjs( false ); 469 470 pLowerFrame = pLowerFrame->GetNext(); 471 } 472 } 473 >>> CID 1399158:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 474 SwLayNotify::~SwLayNotify() 475 { 476 SwLayoutFrame *pLay = static_cast(mpFrame); 477 SwRectFnSet aRectFnSet(pLay); 478 bool bNotify = false; 479 if ( pLay->getFramePrintArea().SSize() != maPrt.SSize() ) /sw/source/core/layout/frmtool.cxx: 474 in SwLayNotify::~SwLayNotify()() 468 pLowerFrame->InvalidateObjs( false ); 469 470 pLowerFrame = pLowerFrame->GetNext(); 471 } 472 } 473 >>> CID 1399158:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 474 SwLayNotify::~SwLayNotify() 475 { 476 SwLayoutFrame *pLay = static_cast(mpFrame); 477 SwRectFnSet aRectFnSet(pLay); 478 bool bNotify = false; 479 if ( pLay->getFramePrintArea().SSize() != maPrt.SSize() ) /sw/source/core/layout/frmtool.cxx: 474 in SwLayNotify::~SwLayNotify()() 468
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 7 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1494650: Insecure data handling (TAINTED_SCALAR) *** CID 1494650: Insecure data handling (TAINTED_SCALAR) /sc/source/filter/lotus/op.cxx: 425 in OP_Formula123(LotusContext &, SvStream &, unsigned short)() 419 420 if (rContext.rDoc.ValidAddress(aAddress) && nTab <= rContext.rDoc.GetMaxTableNumber()) 421 { 422 ScFormulaCell* pCell = new ScFormulaCell(rContext.rDoc, aAddress, std::move(pResult)); 423 pCell->AddRecalcMode( ScRecalcMode::ONLOAD_ONCE ); 424 rContext.rDoc.EnsureTable(nTab); >>> CID 1494650: Insecure data handling (TAINTED_SCALAR) >>> Passing tainted expression "aAddress.nRow" to "SetFormulaCell", which >>> uses it as an offset. 425 rContext.rDoc.SetFormulaCell(aAddress, pCell); 426 } 427 } 428 429 void OP_IEEENumber123(LotusContext& rContext, SvStream& r, sal_uInt16 /*n*/) 430 { ** CID 1485150:(UNCAUGHT_EXCEPT) /usr/include/c++/9/optional: 254 in std::_Optional_payload_base::_M_destroy()() /usr/include/c++/9/optional: 254 in std::_Optional_payload_base::_M_destroy()() /usr/include/c++/9/optional: 254 in std::_Optional_payload_base::_M_destroy()() *** CID 1485150:(UNCAUGHT_EXCEPT) /usr/include/c++/9/optional: 254 in std::_Optional_payload_base::_M_destroy()() 248 ::new ((void *) std::__addressof(this->_M_payload)) 249 _Stored_type(std::forward<_Args>(__args)...); 250 this->_M_engaged = true; 251 } 252 253 constexpr void >>> CID 1485150:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 254 _M_destroy() noexcept 255 { 256 _M_engaged = false; 257 _M_payload._M_value.~_Stored_type(); 258 } 259 /usr/include/c++/9/optional: 254 in std::_Optional_payload_base::_M_destroy()() 248 ::new ((void *) std::__addressof(this->_M_payload)) 249 _Stored_type(std::forward<_Args>(__args)...); 250 this->_M_engaged = true; 251 } 252 253 constexpr void >>> CID 1485150:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 254 _M_destroy() noexcept 255 { 256 _M_engaged = false; 257 _M_payload._M_value.~_Stored_type(); 258 } 259 /usr/include/c++/9/optional: 254 in std::_Optional_payload_base::_M_destroy()() 248 ::new ((void *) std::__addressof(this->_M_payload)) 249 _Stored_type(std::forward<_Args>(__args)...); 250 this->_M_engaged = true; 251 } 252 253 constexpr void >>> CID 1485150:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 254 _M_destroy() noexcept 255 { 256 _M_engaged = false; 257 _M_payload._M_value.~_Stored_type(); 258 } 259 To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dp7_p_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiJSoGrcCjebVW1WIhH27qKBlXotPr-2FU5jAGduSSzFLtw0U74hq-2BcU4RnVZmQLMtehWHhJicQDBF-2FqBU9OWWblA14BEcKkxuvPAclTuv9q3oW4FDKBrftPOgkCW4HS99G9dbcJH94NAPhw86G5yWmHxi9V2LqGq-2FGklD4POTUsehM-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1494631: Control flow issues (DEADCODE) /svx/source/sdr/contact/viewcontactofgraphic.cxx: 339 in sdr::contact::ViewContactOfGraphic::createViewIndependentPrimitive2DSequence(drawinglayer::primitive2d::Primitive2DDecompositionVisitor &) const() *** CID 1494631: Control flow issues (DEADCODE) /svx/source/sdr/contact/viewcontactofgraphic.cxx: 339 in sdr::contact::ViewContactOfGraphic::createViewIndependentPrimitive2DSequence(drawinglayer::primitive2d::Primitive2DDecompositionVisitor &) const() 333 bHMirr = !bHMirr; 334 bVMirr = false; 335 } 336 337 if(bHMirr || bVMirr) 338 { >>> CID 1494631: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "BmpMirrorFlags::NONE" inside >>> this statement: "aLocalGrafInfo.SetMirrorFla...". 339 aLocalGrafInfo.SetMirrorFlags((bHMirr ? BmpMirrorFlags::Horizontal : BmpMirrorFlags::NONE)|(bVMirr ? BmpMirrorFlags::Vertical : BmpMirrorFlags::NONE)); 340 } 341 342 // fill object matrix 343 const double fShearX(-rGeoStat.mfTanShearAngle); 344 const double fRotate(nRotationAngle ? toRadians(36000_deg100 - nRotationAngle) : 0.0); ** CID 1494630: Control flow issues (DEADCODE) /svx/source/sdr/contact/viewcontactofgraphic.cxx: 339 in sdr::contact::ViewContactOfGraphic::createViewIndependentPrimitive2DSequence(drawinglayer::primitive2d::Primitive2DDecompositionVisitor &) const() *** CID 1494630: Control flow issues (DEADCODE) /svx/source/sdr/contact/viewcontactofgraphic.cxx: 339 in sdr::contact::ViewContactOfGraphic::createViewIndependentPrimitive2DSequence(drawinglayer::primitive2d::Primitive2DDecompositionVisitor &) const() 333 bHMirr = !bHMirr; 334 bVMirr = false; 335 } 336 337 if(bHMirr || bVMirr) 338 { >>> CID 1494630: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "BmpMirrorFlags::Vertical" inside >>> this statement: "aLocalGrafInfo.SetMirrorFla...". 339 aLocalGrafInfo.SetMirrorFlags((bHMirr ? BmpMirrorFlags::Horizontal : BmpMirrorFlags::NONE)|(bVMirr ? BmpMirrorFlags::Vertical : BmpMirrorFlags::NONE)); 340 } 341 342 // fill object matrix 343 const double fShearX(-rGeoStat.mfTanShearAngle); 344 const double fRotate(nRotationAngle ? toRadians(36000_deg100 - nRotationAngle) : 0.0); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DgbMh_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi7E7IwGriW-2F4xgWLednSEspLyFxWCqo2NgTux81gSC6H9dcsSQvdAQSDq4idMYyyS53IlzNqETHldvK8F1Do7ws6mpTsVwuNoi4o2SomncggCvmm6ea3XlApyCXfqVrTiPzp4X2umPQUlqDXjzWZRRRxU7kEMSVxRZAybus4HwsA-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 7 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 7 of 7 defect(s) ** CID 1494598: Uninitialized members (UNINIT_CTOR) /sw/source/filter/ww8/docxattributeoutput.cxx: 10220 in DocxAttributeOutput::DocxAttributeOutput(DocxExport &, const std::shared_ptr &, oox::drawingml::DrawingML *)() *** CID 1494598: Uninitialized members (UNINIT_CTOR) /sw/source/filter/ww8/docxattributeoutput.cxx: 10220 in DocxAttributeOutput::DocxAttributeOutput(DocxExport &, const std::shared_ptr &, oox::drawingml::DrawingML *)() 10214 , m_nStateOfFlyFrame( FLY_NOT_PROCESSED ) 10215 { 10216 // Push initial items to the RelId cache. In case the document contains no 10217 // special streams (headers, footers, etc.) then these items are used 10218 // during the full export. 10219 PushRelIdCache(); >>> CID 1494598: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "m_pMoveRedlineData" is not initialized in this >>> constructor nor in any functions that it calls. 10220 } 10221 10222 DocxAttributeOutput::~DocxAttributeOutput() 10223 { 10224 } 10225 ** CID 1494597:(UNCAUGHT_EXCEPT) /include/comphelper/scopeguard.hxx: 59 in comphelper::ScopeGuard::~ScopeGuard()() /include/comphelper/scopeguard.hxx: 59 in comphelper::ScopeGuard::ClassificationInserter::insert(const std::vector> &)::[lambda() (instance 2)]>::~ScopeGuard()() *** CID 1494597:(UNCAUGHT_EXCEPT) /include/comphelper/scopeguard.hxx: 59 in comphelper::ScopeGuard::~ScopeGuard()() 53 { 54 public: 55 /** @param func function object to be executed in dtor 56 */ 57 explicit ScopeGuard( Func && func ) : m_func( std::move(func) ) {} 58 >>> CID 1494597:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 59 ~ScopeGuard() 60 { 61 if (m_bDismissed) 62 return; 63 m_func(); 64 } /include/comphelper/scopeguard.hxx: 59 in comphelper::ScopeGuard::ClassificationInserter::insert(const std::vector> &)::[lambda() (instance 2)]>::~ScopeGuard()() 53 { 54 public: 55 /** @param func function object to be executed in dtor 56 */ 57 explicit ScopeGuard( Func && func ) : m_func( std::move(func) ) {} 58 >>> CID 1494597:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 59 ~ScopeGuard() 60 { 61 if (m_bDismissed) 62 return; 63 m_func(); 64 } ** CID 1494596: Control flow issues (NO_EFFECT) /solenv/lockfile/dotlockfile.c: 199 in main() *** CID 1494596: Control flow issues (NO_EFFECT) /solenv/lockfile/dotlockfile.c: 199 in main() 193 int passthrough = 0; 194 195 /* 196 * Remember real and effective gid, and 197 * drop privs for now. 198 */ >>> CID 1494596: Control flow issues (NO_EFFECT) >>> This less-than-zero comparison of an unsigned value is never true. >>> "(gid = getgid()) < 0U". 199 if ((gid = getgid()) < 0) 200 perror_exit("getgid"); 201 if ((egid = getegid()) < 0) 202 perror_exit("getegid"); 203 if (gid != egid) { 204 if (setregid(-1, gid) < 0) ** CID 1494595: Error handling issues (UNCAUGHT_EXCEPT) /include/comphelper/scopeguard.hxx: 59 in comphelper::ScopeGuard::~ScopeGuard()() *** CID 1494595: Error handling issues (UNCAUGHT_EXCEPT) /include/comphelper/scopeguard.hxx: 59 in comphelper::ScopeGuard::~ScopeGuard()() 53 { 54 public: 55 /** @param func function object to be executed in dtor 56 */ 57 explicit ScopeGuard( Func && func ) : m_func( std::move(func) ) {} 58 >>> CID 1494595: Error handling issues (UNCAUGHT_EXCEPT) >>> An exception of type "boost::wrapexcept" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1494565: Code maintainability issues (VIRTUAL_DTOR) /include/comphelper/interfacecontainer2.hxx: 122 in () *** CID 1494565: Code maintainability issues (VIRTUAL_DTOR) /include/comphelper/interfacecontainer2.hxx: 122 in () 116 This is a copy of the code at include/cppuhelper/interfacecontainer.h, 117 Except that it uses a std::vector instead of a Sequence for the mutable listener 118 list, which provides far better performance. 119 120 @see OInterfaceIteratorHelper2 121 */ >>> CID 1494565: Code maintainability issues (VIRTUAL_DTOR) >>> Class "comphelper::OInterfaceContainerHelper2" does not have a virtual >>> destructor. 122 class COMPHELPER_DLLPUBLIC OInterfaceContainerHelper2 123 { 124 public: 125 /** 126Create an interface container. 127 To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D2hEM_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiDuwctZSM98dNCXfurUevSkQZQavubCjfEbWyxgqSjWspwW3cQA3rHJFOJt1irpnM-2Ba2y1AcaHTxD-2BaJcOP3F65QXXF2PrvJaJytrYAiDgV55Sa-2B6i-2BEBy5irnY1GWhvR3wIQSVv6JSieFcr-2F2VK95hLQpUogUxokexY1XmuhpGQ-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1494452: Null pointer dereferences (REVERSE_INULL) /sfx2/source/view/ipclient.cxx: 289 in SfxInPlaceClient_Impl::saveObject()() *** CID 1494452: Null pointer dereferences (REVERSE_INULL) /sfx2/source/view/ipclient.cxx: 289 in SfxInPlaceClient_Impl::saveObject()() 283 } 284 catch ( uno::Exception& ) 285 { 286 } 287 288 // the client can exist only in case there is a view shell >>> CID 1494452: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "this->m_pClient" suggests that it may be null, but it >>> has already been dereferenced on all paths leading to the check. 289 if ( !m_pClient || !m_pClient->GetViewShell() ) 290 throw uno::RuntimeException(); 291 292 SfxObjectShell* pDocShell = m_pClient->GetViewShell()->GetObjectShell(); 293 if ( !pDocShell ) 294 throw uno::RuntimeException(); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D-wcz_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiMVyuwCMGUElFx-2Bj3nxFVBGgLjUue2TdqEewj8xYOudRBW6hisvfuHbROyT2hoUIu4dJbpJrOuciHFFMZ71AOoFZIqRBk2VtnaxgmJwIvewjPUaeOHL2gX6vHna1xTl6Uqok-2F8TFI-2F962tvKhRg6F-2FmSvb4H9By-2FCPxMHaq-2Fae4A-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 4 new defect(s) introduced to LibreOffice found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1494447: Control flow issues (DEADCODE) /ucb/source/ucp/webdav-curl/CurlSession.cxx: 992 in http_dav_ucp::CurlProcessor::ProcessRequestImpl(http_dav_ucp::CurlSession &, const http_dav_ucp::CurlUri &, curl_slist *, const com::sun::star::uno::Reference *, const com::sun::star::uno::Reference *, const std::pair> &, http_dav_ucp::DAVResource &> *, ::ResponseHeaders &)() *** CID 1494447: Control flow issues (DEADCODE) /ucb/source/ucp/webdav-curl/CurlSession.cxx: 992 in http_dav_ucp::CurlProcessor::ProcessRequestImpl(http_dav_ucp::CurlSession &, const http_dav_ucp::CurlUri &, curl_slist *, const com::sun::star::uno::Reference *, const com::sun::star::uno::Reference *, const std::pair> &, http_dav_ucp::DAVResource &> *, ::ResponseHeaders &)() 986 ExtractRequestedHeaders(rHeaders, pRequestedHeaders); 987 } 988 else 989 { 990 switch (statusCode) 991 { >>> CID 1494447: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "case 0L:". 992 case SC_NONE: 993 assert(false); // ??? should be error returned from perform? 994 break; 995 case SC_REQUEST_TIMEOUT: 996 { 997 throw DAVException( ** CID 1494446: Uninitialized members (UNINIT_CTOR) /ucb/source/ucp/webdav-curl/CurlSession.cxx: 692 in http_dav_ucp::CurlSession::CurlSession(const com::sun::star::uno::Reference &, const rtl::Reference &, const rtl::OUString &, const com::sun::star::uno::Sequence &, const ucbhelper::InternetProxyDecider &)() *** CID 1494446: Uninitialized members (UNINIT_CTOR) /ucb/source/ucp/webdav-curl/CurlSession.cxx: 692 in http_dav_ucp::CurlSession::CurlSession(const com::sun::star::uno::Reference &, const rtl::Reference &, const rtl::OUString &, const com::sun::star::uno::Sequence &, const ucbhelper::InternetProxyDecider &)() 686 { 687 // neon would close the connection from ne_end_request(), this seems 688 // to be the equivalent and not CURLOPT_TCP_KEEPALIVE 689 rc = curl_easy_setopt(m_pCurl.get(), CURLOPT_FORBID_REUSE, 1L); 690 assert(rc == CURLE_OK); 691 } >>> CID 1494446: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "m_AbortFlag._M_base" is not initialized in >>> this constructor nor in any functions that it calls. 692 } 693 694 CurlSession::~CurlSession() {} 695 696 auto CurlSession::CanUse(OUString const& rURI, uno::Sequence const& rFlags) 697 -> bool ** CID 1494445: Concurrent data access violations (MISSING_LOCK) /framework/source/helper/statusindicatorfactory.cxx: 522 in framework::StatusIndicatorFactory::impl_reschedule(bool)() *** CID 1494445: Concurrent data access violations (MISSING_LOCK) /framework/source/helper/statusindicatorfactory.cxx: 522 in framework::StatusIndicatorFactory::impl_reschedule(bool)() 516 // SAFE -> 517 std::unique_lock aRescheduleGuard(rescheduleLock); 518 519 if (m_nInReschedule != 0) 520 return; 521 >>> CID 1494445: Concurrent data access violations (MISSING_LOCK) >>> Accessing "framework::StatusIndicatorFactory::m_nInReschedule" without >>> holding lock "std::unique_lock._M_device". Elsewhere, >>> "framework::StatusIndicatorFactory::m_nInReschedule" is accessed with >>> "std::unique_lock._M_device" held 1 out of 2 times (1 of these >>> accesses strongly imply that it is necessary). 522 ++m_nInReschedule; 523 aRescheduleGuard.unlock(); 524 // <- SAFE 525 526 { 527 SolarMutexGuard g; ** CID 149: Null pointer dereferences (NULL_RETURNS) *** CID 149: Null pointer dereferences (NULL_RETURNS) /sc/source/core/data/table3.cxx: 3054 in ScTable::ValidQuery(int, const ScQueryParam &, const ScRefCellValue *, bool *, const ScInterpreterContext *, sc::TableColumnBlockPositionSet *, ScTable::ValidQueryCache *)() 3048 ScRefCellValue aCell; 3049 if(pCell && it == itBeg) 3050 aCell = *pCell; 3051 else if( pBlockPos )
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1494386: Null pointer dereferences (NULL_RETURNS) *** CID 1494386: Null pointer dereferences (NULL_RETURNS) /sd/source/filter/xml/sdtransform.cxx: 301 in ::SdTransformOOo2xDocument::transformItemSet(SfxItemSet &, bool)() 295 296 bool SdTransformOOo2xDocument::transformItemSet( SfxItemSet& rSet, bool bNumbering ) 297 { 298 bool bRet = false; 299 if( bNumbering ) 300 { >>> CID 1494386: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "nullptr" >>> "rSet->GetItem(EE_PARA_LRSPACE, true)" when calling "SvxLRSpaceItem". 301 SvxLRSpaceItem aItem( *rSet.GetItem( EE_PARA_LRSPACE ) ); 302 if( (aItem.GetLeft() != 0) || (aItem.GetTextFirstLineOffset() != 0) ) 303 { 304 aItem.SetLeftValue( 0 ); 305 aItem.SetTextFirstLineOffset( 0 ); 306 rSet.Put( aItem ); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DG1dX_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJipsqIlaZvSdvCHKtu5JrbOZMxT9fDCx0ERG36scOb5pCUcNl7bo95ISvfwMKpnFjSWig3mBdvvtPDV02RfkYj5BnRSkZN7DqIIR4YJJ6DVlnP5f-2BODZ2e6fdKeFPAa2bElYEvhzQjv95xh3Hfj8HCEnu4onCJaa3a9GsU1ToaOPo-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1421164:(UNCAUGHT_EXCEPT) /sw/source/filter/ww8/ww8par3.cxx: 1483 in WW8ListManager::~WW8ListManager()() /sw/source/filter/ww8/ww8par3.cxx: 1483 in WW8ListManager::~WW8ListManager()() *** CID 1421164:(UNCAUGHT_EXCEPT) /sw/source/filter/ww8/ww8par3.cxx: 1483 in WW8ListManager::~WW8ListManager()() 1477 } 1478 } 1479 // and we're done! 1480 rSt.Seek( nOriginalPos ); 1481 } 1482 >>> CID 1421164:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 1483 WW8ListManager::~WW8ListManager() 1484 { 1485 /* 1486 named lists remain in document 1487 unused automatic lists are removed from document (DelNumRule) 1488 */ /sw/source/filter/ww8/ww8par3.cxx: 1483 in WW8ListManager::~WW8ListManager()() 1477 } 1478 } 1479 // and we're done! 1480 rSt.Seek( nOriginalPos ); 1481 } 1482 >>> CID 1421164:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 1483 WW8ListManager::~WW8ListManager() 1484 { 1485 /* 1486 named lists remain in document 1487 unused automatic lists are removed from document (DelNumRule) 1488 */ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DLv75_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJipRvWH7RhCXcVwmSha-2FYGpyCHb5KTJqNvmUc9Dxs1ustq-2FvKRr3g8bYtImVoacj1QpxId-2BiN08TbTcBkyomhOO1Ha4PPFQwCMnp-2F3B9ceq-2FcvmkhjZ36yO39YN9ZWZgxfDypOxgr6LfrGB1466xC7jSrgqa-2FSySUvGdoqjlR2DGE-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 3 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1493476: Control flow issues (DEADCODE) /vcl/unx/gtk3/gtkinst.cxx: 9180 in ::set_font(_GtkLabel *, const vcl::Font &)() *** CID 1493476: Control flow issues (DEADCODE) /vcl/unx/gtk3/gtkinst.cxx: 9180 in ::set_font(_GtkLabel *, const vcl::Font &)() 9174 if (pOrigList) 9175 { 9176 // tdf#143443 remove both PANGO_ATTR_ABSOLUTE_SIZE and PANGO_ATTR_SIZE 9177 // because pango_attr_list_change(..., pango_attr_size_new...) isn't 9178 // sufficient on its own to ensure a new size sticks. 9179 PangoAttrType aFilterAttrs[] = {PANGO_ATTR_ABSOLUTE_SIZE, PANGO_ATTR_SIZE, PANGO_ATTR_INVALID}; >>> CID 1493476: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "NULL" inside this statement: >>> "pRemovedAttrs = (pOrigList ...". 9180 PangoAttrList* pRemovedAttrs = pOrigList ? pango_attr_list_filter(pAttrList, filter_pango_attrs, ) : nullptr; 9181 pango_attr_list_unref(pRemovedAttrs); 9182 } 9183 9184 update_attr_list(pAttrList, rFont); 9185 gtk_label_set_attributes(pLabel, pAttrList); ** CID 1493475:(UNCAUGHT_EXCEPT) /usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector>, mdds::mtv::default_trait>::~multi_type_vector()() /usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector>, mdds::mtv::default_trait>::~multi_type_vector()() /usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector>, mdds::mtv::default_trait>::~multi_type_vector()() /usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector>, mdds::mtv::default_trait>::~multi_type_vector()() /usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector>, mdds::mtv::default_trait>::~multi_type_vector()() /usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector, mdds::mtv::noncopyable_managed_element_block<(int)53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<(int)54, ScFormulaCell>>, sc::CellStoreTrait>::~multi_type_vector()() *** CID 1493475:(UNCAUGHT_EXCEPT) /usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector>, mdds::mtv::default_trait>::~multi_type_vector()() 384 abort(); 385 } 386 #endif 387 } 388 389 template >>> CID 1493475:(UNCAUGHT_EXCEPT) >>> An exception of type "mdds::general_error" is thrown but the throw list >>> "noexcept" doesn't allow it to be thrown. This will cause a call to >>> unexpected() which usually calls terminate(). 390 multi_type_vector::~multi_type_vector() 391 { 392 delete_element_blocks(0, m_block_store.positions.size()); 393 } 394 395 template /usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector>, mdds::mtv::default_trait>::~multi_type_vector()() 384 abort(); 385 } 386 #endif 387 } 388 389 template >>> CID 1493475:(UNCAUGHT_EXCEPT) >>> An exception of type "mdds::general_error" is thrown but the throw list >>> "noexcept" doesn't allow it to be thrown. This will cause a call to >>> unexpected() which usually calls terminate(). 390 multi_type_vector::~multi_type_vector() 391 { 392 delete_element_blocks(0, m_block_store.positions.size()); 393 } 394 395 template /usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector>, mdds::mtv::default_trait>::~multi_type_vector()() 384 abort(); 385 } 386 #endif 387 } 388 389 template >>> CID 1493475:(UNCAUGHT_EXCEPT) >>> An exception of type "mdds::general_error" is thrown but the throw list >>> "noexcept" doesn't allow it to be thrown. This will cause a call to >>> unexpected() which usually calls terminate(). 390 multi_type_vector::~multi_type_vector() 391 { 392 delete_element_blocks(0, m_block_store.positions.size()); 393 } 394 395 template /usr/include/mdds-2.0/mdds/multi_type_vector/soa/main_def.inl: 390 in mdds::mtv::soa::multi_type_vector>, mdds::mtv::default_trait>::~multi_type_vector()() 384 abort(); 385 } 386 #endif 387 } 388 389 template >>> CID
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1416802: Uninitialized variables (UNINIT) /usr/lib/gcc/x86_64-redhat-linux/9/include/avx512fintrin.h: 207 in _mm512_undefined_epi32()() *** CID 1416802: Uninitialized variables (UNINIT) /usr/lib/gcc/x86_64-redhat-linux/9/include/avx512fintrin.h: 207 in _mm512_undefined_epi32()() 201 202 extern __inline __m512i 203 __attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) 204 _mm512_undefined_epi32 (void) 205 { 206 __m512i __Y = __Y; >>> CID 1416802: Uninitialized variables (UNINIT) >>> Using uninitialized value "__Y". 207 return __Y; 208 } 209 210 #define _mm512_undefined_si512 _mm512_undefined_epi32 211 212 extern __inline __m512i To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DBH1h_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJihMvTdIy7P-2BrOZSNVsZQbGlUwfNH0QH-2Bzfe2ZIlMYSTCIQqYtE1Y31kag-2FiOL1n15CHEbOSKwZGmdpvD7X9hJ79lBJfBWoAYjrrL7o4leC18V0UcYyf1w-2BVMc6S2A-2FkBKlJQvCSsmMUfV9QaNda7jFMgMhc0ZFwezjEuL4sY6XMs-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 6 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 6 of 6 defect(s) ** CID 1493243: Incorrect expression (COPY_PASTE_ERROR) /sw/source/core/undo/undel.cxx: 81 in FindFirstAndNextNode(SwDoc &, const SwUndRng &, const SwRedlineSaveDatas &, SwTextNode *&)() *** CID 1493243: Incorrect expression (COPY_PASTE_ERROR) /sw/source/core/undo/undel.cxx: 81 in FindFirstAndNextNode(SwDoc &, const SwUndRng &, const SwRedlineSaveDatas &, SwTextNode *&)() 75 assert(rRange.m_nEndContent == 0); 76 SwNodeOffset nEndOfRedline(0); 77 for (size_t i = 0; i < rRedlineSaveData.size(); ++i) 78 { 79 auto const& rRedline(rRedlineSaveData[i]); 80 if (rRedline.m_nSttNode <= rRange.m_nSttNode >>> CID 1493243: Incorrect expression (COPY_PASTE_ERROR) >>> "m_nSttNode" in "rRedline.m_nSttNode < rRange.m_nEndNode" looks like a >>> copy-paste error. 81 && rRedline.m_nSttNode < rRange.m_nEndNode 82 && rRange.m_nEndNode <= rRedline.m_nEndNode 83 && rRedline.GetType() == RedlineType::Delete) 84 { 85 nEndOfRedline = rRedline.m_nEndNode; 86 o_rpFirstMergedDeletedTextNode = rDoc.GetNodes()[rRedline.m_nSttNode]->GetTextNode(); ** CID 1493242: Incorrect expression (COPY_PASTE_ERROR) /sw/source/core/doc/docnum.cxx: 1957 in SwDoc::MoveParagraphImpl(SwPaM &, o3tl::strong_int, bool, const SwRootFrame *)() *** CID 1493242: Incorrect expression (COPY_PASTE_ERROR) /sw/source/core/doc/docnum.cxx: 1957 in SwDoc::MoveParagraphImpl(SwPaM &, o3tl::strong_int, bool, const SwRootFrame *)() 1951 // range, too (e.g. as last node). 1952 // If an end node is the last node of the moved range, its start node has to be a part of 1953 // the moved section, too. 1954 pTmp1 = GetNodes()[ nStIdx ]; 1955 if( pTmp1->IsStartNode() ) 1956 { // First is a start node >>> CID 1493242: Incorrect expression (COPY_PASTE_ERROR) >>> "pTmp1" in "pTmp1->EndOfSectionNode()" looks like a copy-paste error. 1957 pTmp2 = pTmp1->EndOfSectionNode(); 1958 if( pTmp2->GetIndex() > nEndIdx ) 1959 return false; // Its end node is behind the moved range 1960 } 1961 pTmp1 = pTmp1->StartOfSectionNode()->EndOfSectionNode(); 1962 if( pTmp1->GetIndex() <= nEndIdx ) ** CID 1493241: Memory - illegal accesses (WRAPPER_ESCAPE) /svx/source/svdraw/svdedxv.cxx: 1668 in SdrObjEditView::SdrEndTextEdit(bool)() *** CID 1493241: Memory - illegal accesses (WRAPPER_ESCAPE) /svx/source/svdraw/svdedxv.cxx: 1668 in SdrObjEditView::SdrEndTextEdit(bool)() 1662 if (pTEObj && !pTEObj->getSdrModelFromSdrObject().isLocked() && pTEObj->GetBroadcaster()) 1663 { 1664 SdrHint aHint(SdrHintKind::EndEdit, *pTEObj); 1665 const_cast(pTEObj->GetBroadcaster())->Broadcast(aHint); 1666 } 1667 >>> CID 1493241: Memory - illegal accesses (WRAPPER_ESCAPE) >>> Using invalidated internal representation of >>> "this->mpLocalTextEditUndoManager". 1668 if (pUndoEditUndoManager) 1669 { 1670 if (bNeedToUndoSavedRedoTextEdit) 1671 { 1672 // undo the text edit action since it was created as part of an EndTextEdit 1673 // callback from undo itself. This needs to be done after the call to ** CID 1493240:(CHECKED_RETURN) /vcl/workben/mtfdemo.cxx: 158 in ::DemoMtfApp::Init()() /vcl/workben/mtfdemo.cxx: 175 in ::DemoMtfApp::Init()() *** CID 1493240:(CHECKED_RETURN) /vcl/workben/mtfdemo.cxx: 158 in ::DemoMtfApp::Init()() 152 aFilename = aArg; 153 } 154 155 OUString sWorkingDir, sFileUrl; 156 osl_getProcessWorkingDir(); 157 osl::FileBase::getFileURLFromSystemPath(aFilename, sFileUrl); >>> CID 1493240:(CHECKED_RETURN) >>> Calling "getAbsoluteFileURL" without checking return value (as is done >>> elsewhere 19 out of 21 times). 158 osl::FileBase::getAbsoluteFileURL(sWorkingDir, sFileUrl, maFileName); 159 160 uno::Reference xComponentContext 161 = ::cppu::defaultBootstrap_InitialComponentContext(); 162
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1492880:(NEGATIVE_RETURNS) *** CID 1492880:(NEGATIVE_RETURNS) /sc/source/ui/docshell/externalrefmgr.cxx: 1771 in ScExternalRefManager::storeRangeNameTokens(unsigned short, const rtl::OUString &, const ScTokenArray &)() 1765 bool bTokenAdded = false; 1766 switch (pToken->GetType()) 1767 { 1768 case svSingleRef: 1769 { 1770 const ScSingleRefData& rRef = *pToken->GetSingleRef(); >>> CID 1492880:(NEGATIVE_RETURNS) >>> "rRef->Tab()" is passed to a parameter that cannot be negative. 1771 OUString aTabName = maRefCache.getTableName(nFileId, rRef.Tab()); 1772 ScExternalSingleRefToken aNewToken(nFileId, svl::SharedString(aTabName), // string not interned 1773 *pToken->GetSingleRef()); 1774 pNewArray->AddToken(aNewToken); 1775 bTokenAdded = true; 1776 } /sc/source/ui/docshell/externalrefmgr.cxx: 1781 in ScExternalRefManager::storeRangeNameTokens(unsigned short, const rtl::OUString &, const ScTokenArray &)() 1775 bTokenAdded = true; 1776 } 1777 break; 1778 case svDoubleRef: 1779 { 1780 const ScSingleRefData& rRef = *pToken->GetSingleRef(); >>> CID 1492880:(NEGATIVE_RETURNS) >>> "rRef->Tab()" is passed to a parameter that cannot be negative. 1781 OUString aTabName = maRefCache.getTableName(nFileId, rRef.Tab()); 1782 ScExternalDoubleRefToken aNewToken(nFileId, svl::SharedString(aTabName), // string not interned 1783 *pToken->GetDoubleRef()); 1784 pNewArray->AddToken(aNewToken); 1785 bTokenAdded = true; 1786 } To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D4ME2_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiatsvszQV9nJbNxYbtjTOohGQA-2FuExu3X0beEiWtI3ZTFZLH-2BoapCju3IXlbEVrSDKQStN-2BJpSx5Yl9RV6lGVLSAigKOHNNuAS4b82mIEiX4tl-2B85u-2FPHS5nczeija9ZottU0nNNqSgMndEHF9C79K4GZK5AOOBo0Ssb-2FxvUpwWE-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1492820: SpotBugs: Performance (FB.WMI_WRONG_MAP_ITERATOR) /qadevOOo/tests/java/ifc/text/_NumberingLevel.java: 143 in ifc.text._NumberingLevel.testPropertyArray()() *** CID 1492820: SpotBugs: Performance (FB.WMI_WRONG_MAP_ITERATOR) /qadevOOo/tests/java/ifc/text/_NumberingLevel.java: 143 in ifc.text._NumberingLevel.testPropertyArray()() 137 // get rest of properties and check if they are optional 138 if (! NumberingLevel.isEmpty()){ 139 for (Iterator e = NumberingLevel.keySet().iterator() ; e.hasNext() ;) { 140 String property = e.next(); 141 142 // if some elements are not optional -> failed >>> CID 1492820: SpotBugs: Performance (FB.WMI_WRONG_MAP_ITERATOR) >>> ifc.text._NumberingLevel.testPropertyArray() makes inefficient use of >>> keySet iterator instead of entrySet iterator. 143 if ( ! NumberingLevel.get(property).booleanValue() ){ 144 145 if ( status ) { 146 log.println("FAILED: com.sun.star.text.NumberingLevel -> " + 147 "could not find not optional property:"); 148 } To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DTst2_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi-2B3Xj-2BB3rIzdNTPogSmZqCenrqsgmhMvk-2B8-2FHP7Svtlv2Qwtwl8EK-2FjZh5-2BiIJX-2FGHnFA6dV4MbwbY-2ByBuBpShjUvl0SitzzA93IEzgOTUaw2rawkWzfxUtI7D9ipK8Q0LkSMx9KsNd33tE7zCrZlEFWpvwMMuDf-2BkdEGiiRirRQ-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1492337: Integer handling issues (SIGN_EXTENSION) /sw/source/core/text/itradj.cxx: 521 in SwTextAdjuster::CalcKanaAdj(SwLineLayout *)() *** CID 1492337: Integer handling issues (SIGN_EXTENSION) /sw/source/core/text/itradj.cxx: 521 in SwTextAdjuster::CalcKanaAdj(SwLineLayout *)() 515 // during text formatting 516 sal_uInt16 nMaxWidthDiff = GetInfo().GetMaxWidthDiff( pPos ); 517 518 // check, if information is stored under other key 519 if ( !nMaxWidthDiff && pPos == pCurrent->GetFirstPortion() ) 520 nMaxWidthDiff = GetInfo().GetMaxWidthDiff( pCurrent ); >>> CID 1492337: Integer handling issues (SIGN_EXTENSION) >>> Suspicious implicit sign extension: "nMaxWidthDiff" with type >>> "sal_uInt16" (16 bits, unsigned) is promoted in "nMinWidth + (1 - >>> nCompress) * nMaxWidthDiff / 1" to type "int" (32 bits, signed), then >>> sign-extended to type "long" (64 bits, signed). If "nMinWidth + (1 - >>> nCompress) * nMaxWidthDiff / 1" is greater than 0x7FFF, the upper >>> bits of the result will all be 1. 521 pPos->Width( nMinWidth + 522( ( 1 - nCompress ) * nMaxWidthDiff ) / 1 ); 523 nDecompress += pPos->Width() - nMinWidth; 524 } 525 else if( pPos->InGlueGrp() && pPos->InFixMargGrp() ) 526 { To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Djy6E_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiv7uWe2YXPLfUTEQTPWjOUofnlaM2UIGk8VEHF1GIbG9oDSwzcFSqA9GQLcYYZggDVNZAHQ4x61QrHmfX00bEPzJwHb3tpfdUrgrQ8-2FY-2FzjvQvbabBbz2waRzAv9RdSflRH4XwFtrR4zvwLHNQsfceD73BrzAod9LDdWXgUXQTxk-3D
Re: New Defects reported by Coverity Scan for LibreOffice
On 02.10.2021 11:31, Mike Kaganski wrote: On 02.10.2021 11:14, scan-ad...@coverity.com wrote: ** CID 1485150: Error handling issues (UNCAUGHT_EXCEPT) /usr/include/c++/9/optional: 254 in std::_Optional_payload_base::_M_destroy()() *** CID 1485150: Error handling issues (UNCAUGHT_EXCEPT) /usr/include/c++/9/optional: 254 in std::_Optional_payload_base::_M_destroy()() 248  ::new ((void *) std::__addressof(this->_M_payload)) 249 _Stored_type(std::forward<_Args>(__args)...); 250  this->_M_engaged = true; 251 } 252 253  constexpr void CID 1485150: Error handling issues (UNCAUGHT_EXCEPT) An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate(). 254  _M_destroy() noexcept 255  { 256 _M_engaged = false; 257 _M_payload._M_value.~_Stored_type(); 258  } 259 Interesting, why some implementation declares optional's dtor noexcept? [optional.dtor] doesn't mention any 'noexcept' specification... at least in n4835.pdf. Ah, yes, implicitly noexcept dtors in c++11... -- Best regards, Mike Kaganski
Re: New Defects reported by Coverity Scan for LibreOffice
On 02.10.2021 11:14, scan-ad...@coverity.com wrote: ** CID 1485150: Error handling issues (UNCAUGHT_EXCEPT) /usr/include/c++/9/optional: 254 in std::_Optional_payload_base::_M_destroy()() *** CID 1485150: Error handling issues (UNCAUGHT_EXCEPT) /usr/include/c++/9/optional: 254 in std::_Optional_payload_base::_M_destroy()() 248 ::new ((void *) std::__addressof(this->_M_payload)) 249 _Stored_type(std::forward<_Args>(__args)...); 250 this->_M_engaged = true; 251 } 252 253 constexpr void CID 1485150: Error handling issues (UNCAUGHT_EXCEPT) An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate(). 254 _M_destroy() noexcept 255 { 256 _M_engaged = false; 257 _M_payload._M_value.~_Stored_type(); 258 } 259 Interesting, why some implementation declares optional's dtor noexcept? [optional.dtor] doesn't mention any 'noexcept' specification... at least in n4835.pdf. -- Best regards, Mike Kaganski
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1492313: Control flow issues (DEADCODE) /sw/source/core/text/atrstck.cxx: 410 in SwAttrHandler::Push(const SwTextAttr &, const SfxPoolItem &)() *** CID 1492313: Control flow issues (DEADCODE) /sw/source/core/text/atrstck.cxx: 410 in SwAttrHandler::Push(const SwTextAttr &, const SfxPoolItem &)() 404 { 405 m_aAttrStack[nStack] = 406 return true; 407 } 408 409 if (!pTopAttr) >>> CID 1492313: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "this->m_aAttrStack[nStack] ...". 410 m_aAttrStack[nStack] = 411 return false; 412 } 413 414 void SwAttrHandler::RemoveFromStack(sal_uInt16 nWhich, const SwTextAttr& rAttr) 415 { ** CID 1485150: Error handling issues (UNCAUGHT_EXCEPT) /usr/include/c++/9/optional: 254 in std::_Optional_payload_base::_M_destroy()() *** CID 1485150: Error handling issues (UNCAUGHT_EXCEPT) /usr/include/c++/9/optional: 254 in std::_Optional_payload_base::_M_destroy()() 248 ::new ((void *) std::__addressof(this->_M_payload)) 249 _Stored_type(std::forward<_Args>(__args)...); 250 this->_M_engaged = true; 251 } 252 253 constexpr void >>> CID 1485150: Error handling issues (UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 254 _M_destroy() noexcept 255 { 256 _M_engaged = false; 257 _M_payload._M_value.~_Stored_type(); 258 } 259 To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DzMsD_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiw2TyZGT7POsJT4IGt7XyaeUXhPvVuR1DvTNXxTRxKzkFcwo7qcu373KDwpTKiGKFMqq-2F95n6fowA8q3R0AfcnsIoo-2Fsb5Bv2T8i6qbztroNRKXGCBsEaMBETNj2A3I2XJupOzr8YgFA6SfL58JA9t-2BqT-2B7I9OobEzfDogFOjWio-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1492160: Null pointer dereferences (REVERSE_INULL) /sw/source/uibase/utlui/glbltree.cxx: 800 in SwGlobalTree::UpdateTracking()() *** CID 1492160: Null pointer dereferences (REVERSE_INULL) /sw/source/uibase/utlui/glbltree.cxx: 800 in SwGlobalTree::UpdateTracking()() 794 { 795 const SwSection* pSection = pActiveShellCurrSection; 796 SwSection* pParent; 797 while ((pParent = pSection->GetParent()) != nullptr) 798 pSection = pParent; 799 >>> CID 1492160: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "pSection" suggests that it may be null, but it has >>> already been dereferenced on all paths leading to the check. 800 if (pSection) 801 m_xTreeView->select_text(pSection->GetSectionName()); 802 } 803 } 804 805 void SwGlobalTree::GotoContent(const SwGlblDocContent* pCont) ** CID 1492159: Uninitialized members (UNINIT_CTOR) /vcl/source/font/fontmetric.cxx: 66 in FontMetric::FontMetric(const PhysicalFontFace &)() *** CID 1492159: Uninitialized members (UNINIT_CTOR) /vcl/source/font/fontmetric.cxx: 66 in FontMetric::FontMetric(const PhysicalFontFace &)() 60 SetPitch(rFace.GetPitch()); 61 SetWeight(rFace.GetWeight()); 62 SetItalic(rFace.GetItalic()); 63 SetAlignment(TextAlign::ALIGN_TOP); 64 SetWidthType(rFace.GetWidthType()); 65 SetQuality(rFace.GetQuality() ); >>> CID 1492159: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "mbFullstopCentered" is not initialized in this >>> constructor nor in any functions that it calls. 66 } 67 68 FontMetric::~FontMetric() 69 { 70 } 71 To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DyyGl_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiCgCXSXq-2Fe0lSJPU6Sn6aiOSzHqNaWjCGPQmQweCFymAh6ZOTSmEeoviLonQGWzam8eI8OTU22AuyPWjo3g8fKhkHRoC-2FCgnSINUhJAZZ7DXoCq5fXltMMOEzuP25N1LD3OCRj8Gnh2L-2BksFYGZG1O5kAB-2FcW-2Bdai7C99JCS-2Fa6Y-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 5 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1491949: Null pointer dereferences (FORWARD_NULL) *** CID 1491949: Null pointer dereferences (FORWARD_NULL) /i18npool/source/transliteration/transliteration_Numeric.cxx: 122 in i18npool::transliteration_Numeric::transliterateImpl(const rtl::OUString &, int, int, com::sun::star::uno::Sequence *)() 116 transliteration_Numeric::transliterateImpl( const OUString& inStr, sal_Int32 startPos, sal_Int32 nCount, 117 Sequence< sal_Int32 >* pOffset ) 118 { 119 if (tableSize) 120 return transliterateBullet( inStr, startPos, nCount, pOffset); 121 else >>> CID 1491949: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pOffset" to "getNativeNumberString", which >>> dereferences it. 122 return rtl::Reference(new NativeNumberSupplierService(bool(pOffset)))->getNativeNumberString( inStr.copy(startPos, nCount), aLocale, nNativeNumberMode, *pOffset ); 123 } 124 125 sal_Unicode SAL_CALL 126 transliteration_Numeric::transliterateChar2Char( sal_Unicode inChar ) 127 { ** CID 1491948: Null pointer dereferences (REVERSE_INULL) /sw/source/core/doc/DocumentLayoutManager.cxx: 512 in sw::DocumentLayoutManager::CopyLayoutFormat(const SwFrameFormat &, const SwFormatAnchor &, bool, bool)() *** CID 1491948: Null pointer dereferences (REVERSE_INULL) /sw/source/core/doc/DocumentLayoutManager.cxx: 512 in sw::DocumentLayoutManager::CopyLayoutFormat(const SwFrameFormat &, const SwFormatAnchor &, bool, bool)() 506 pDestTextBox->GetContent().GetContentIdx()->GetNode().GetStartNode()); 507 aSet.Put(aContent); 508 pDest->SetFormatAttr(aSet); 509 510 // Link FLY and DRAW formats, so it becomes a text box 511 SdrObject* pNewObj = pDest->FindRealSdrObject(); >>> CID 1491948: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "pDest" suggests that it may be null, but it has already >>> been dereferenced on all paths leading to the check. 512 if (bIsGroupObj && pDest && pDest->FindRealSdrObject() 513 && pDest->FindRealSdrObject()->getChildrenOfSdrObject() 514 && (pDest->FindRealSdrObject()->getChildrenOfSdrObject()->GetObjCount() > it) 515 && pDest->FindRealSdrObject()->getChildrenOfSdrObject()->GetObj(it)) 516 pNewObj = pDest->FindRealSdrObject()->getChildrenOfSdrObject()->GetObj(it); 517 pTextBoxNd->AddTextBox(pNewObj, pDestTextBox); ** CID 1491947: Error handling issues (UNCAUGHT_EXCEPT) /usr/include/c++/9/ext/new_allocator.h: 151 in __gnu_cxx::new_allocator::destroy(T1 *)() *** CID 1491947: Error handling issues (UNCAUGHT_EXCEPT) /usr/include/c++/9/ext/new_allocator.h: 151 in __gnu_cxx::new_allocator::destroy(T1 *)() 145 noexcept(noexcept(::new((void *)__p) 146 _Up(std::forward<_Args>(__args)...))) 147 { ::new((void *)__p) _Up(std::forward<_Args>(__args)...); } 148 149 template 150 void >>> CID 1491947: Error handling issues (UNCAUGHT_EXCEPT) >>> An exception of type "std::bad_weak_ptr" is thrown but the throw list >>> "noexcept" doesn't allow it to be thrown. This will cause a call to >>> unexpected() which usually calls terminate(). 151 destroy(_Up* __p) 152 noexcept(noexcept( __p->~_Up())) 153 { __p->~_Up(); } 154 #else 155 // _GLIBCXX_RESOLVE_LIB_DEFECTS 156 // 402. wrong new expression in [some_] allocator::construct ** CID 1491946: Null pointer dereferences (REVERSE_INULL) /i18npool/source/transliteration/textToPronounce_zh.cxx: 70 in i18npool::TextToPronounce_zh::foldingImpl(const rtl::OUString &, int, int, com::sun::star::uno::Sequence *)() *** CID 1491946: Null pointer dereferences (REVERSE_INULL) /i18npool/source/transliteration/textToPronounce_zh.cxx: 70 in i18npool::TextToPronounce_zh::foldingImpl(const rtl::OUString &, int, int, com::sun::star::uno::Sequence *)() 64 65 (*pOffset)[0] = 0; 66 for (sal_Int32 i = 0; i < nCount; i++) { 67
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 3 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1491409: Uninitialized members (UNINIT_CTOR) /workdir/UnpackedTarball/cuckoo/libcuckoo/cuckoohash_map.hh: 1555 in libcuckoo::cuckoohash_map<_rtl_uString *, std::pair, svlHashFunction, svlEqualsFunction, std::allocator>>, (unsigned long)4>::b_slot::b_slot()() *** CID 1491409: Uninitialized members (UNINIT_CTOR) /workdir/UnpackedTarball/cuckoo/libcuckoo/cuckoohash_map.hh: 1555 in libcuckoo::cuckoohash_map<_rtl_uString *, std::pair, svlHashFunction, svlEqualsFunction, std::allocator>>, (unsigned long)4>::b_slot::b_slot()() 1549 static_assert(MAX_BFS_PATH_LEN - 1 <= 1550 std::numeric_limits::max(), 1551 "The depth type must able to hold a value of" 1552 " MAX_BFS_PATH_LEN - 1"); 1553 static_assert(-1 >= std::numeric_limits::min(), 1554 "The depth type must be able to hold a value of -1"); >>> CID 1491409: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "depth" is not initialized in this constructor >>> nor in any functions that it calls. 1555 b_slot() {} 1556 b_slot(const size_type b, const uint16_t p, const decltype(depth) d) 1557 : bucket(b), pathcode(p), depth(d) { 1558 assert(d < MAX_BFS_PATH_LEN); 1559 } 1560 }; ** CID 1491408: Uninitialized members (UNINIT_CTOR) /workdir/UnpackedTarball/cuckoo/libcuckoo/cuckoohash_map.hh: 869 in libcuckoo::cuckoohash_map<_rtl_uString *, std::pair, svlHashFunction, svlEqualsFunction, std::allocator>>, (unsigned long)4>::TwoBuckets::TwoBuckets()() *** CID 1491408: Uninitialized members (UNINIT_CTOR) /workdir/UnpackedTarball/cuckoo/libcuckoo/cuckoohash_map.hh: 869 in libcuckoo::cuckoohash_map<_rtl_uString *, std::pair, svlHashFunction, svlEqualsFunction, std::allocator>>, (unsigned long)4>::TwoBuckets::TwoBuckets()() 863 // locks. In normal_mode, we actually do take locks, and can rehash lazily. 864 using locked_table_mode = std::integral_constant; 865 using normal_mode = std::integral_constant; 866 867 class TwoBuckets { 868 public: >>> CID 1491408: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "i2" is not initialized in this constructor nor >>> in any functions that it calls. 869 TwoBuckets() {} 870 TwoBuckets(size_type i1_, size_type i2_, locked_table_mode) 871 : i1(i1_), i2(i2_) {} 872 TwoBuckets(locks_t , size_type i1_, size_type i2_, normal_mode) 873 : i1(i1_), i2(i2_), first_manager_([lock_ind(i1)]), 874 second_manager_((lock_ind(i1) != lock_ind(i2)) ? [lock_ind(i2)] ** CID 1454626: Uninitialized members (UNINIT_CTOR) /oox/source/export/chartexport.cxx: 543 in oox::drawingml::ChartExport::ChartExport(int, std::shared_ptr, const com::sun::star::uno::Reference &, oox::core::XmlFilterBase *, oox::drawingml::DocumentType)() *** CID 1454626: Uninitialized members (UNINIT_CTOR) /oox/source/export/chartexport.cxx: 543 in oox::drawingml::ChartExport::ChartExport(int, std::shared_ptr, const com::sun::star::uno::Reference &, oox::core::XmlFilterBase *, oox::drawingml::DocumentType)() 537 , mbHasCategoryLabels( false ) 538 , mbHasZAxis( false ) 539 , mbIs3DChart( false ) 540 , mbStacked(false) 541 , mbPercent(false) 542 { >>> CID 1454626: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "mbHasDateCategories" is not initialized in >>> this constructor nor in any functions that it calls. 543 } 544 545 void ChartExport::SetURLTranslator(const std::shared_ptr& pTransformer) 546 { 547 mpURLTransformer = pTransformer; 548 } To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dqfzr_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi8Yl5FxFC1LklfV039wgscxnIjLWDh8J6hBKOIDcHNrMymQlXwofvmTuO498ayhDWpRgH-2Fhvq5ouQM-2BNEBzsI6Ry0Ld8SK1ObJLGEAd1CZVjLj4dNedP-2FhZnE4XqnWqEtsYVeNK5VQiwWH0JxExTasU1y4k9N0-2BwlLOsngS2K054-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1491055: Null pointer dereferences (FORWARD_NULL) *** CID 1491055: Null pointer dereferences (FORWARD_NULL) /sc/source/core/tool/sharedformula.cxx: 397 in sc::SharedFormulaUtil::startListeningAsGroup(sc::StartListeningContext &, ScFormulaCell **)() 391 ScDocument& rDoc = rCxt.getDoc(); 392 rDoc.SetDetectiveDirty(true); 393 394 ScFormulaCellGroupRef xGroup = rTopCell.GetCellGroup(); 395 const ScTokenArray* pCode = xGroup->mpCode ? &*xGroup->mpCode : nullptr; 396 assert(pCode == rTopCell.GetCode()); >>> CID 1491055: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pCode" to "IsRecalcModeAlways", which >>> dereferences it. 397 if (pCode->IsRecalcModeAlways()) 398 { 399 rDoc.StartListeningArea( 400 BCA_LISTEN_ALWAYS, false, 401 xGroup->getAreaListener(ppSharedTop, BCA_LISTEN_ALWAYS, true, true)); 402 } To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DLpm7_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi66xvYucuMo-2F-2Fb-2BKii0ofqoRVqb6poMJ9Gjx6zTrrRVtcuW2T14qS2Dn-2BPTIOiLXqcsHztgWQdEj4gAS6e6g-2BHmpll8-2FmzvG2J7ZP7Gc6J6r3SOiMV-2FiXUQmTwZcpptZ4u7k21Xb643km-2FKQSnFe7wxvBj0EOIZfip-2BZ110I-2Brpc-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1490901: Memory - illegal accesses (OVERRUN) /lotuswordpro/source/filter/lwpsilverbullet.cxx: 101 in LwpSilverBullet::Read()() *** CID 1490901: Memory - illegal accesses (OVERRUN) /lotuswordpro/source/filter/lwpsilverbullet.cxx: 101 in LwpSilverBullet::Read()() 95 if (nNumPos > SAL_N_ELEMENTS(m_pResetPositionFlags)) 96 throw std::range_error("corrupt SilverBullet"); 97 98 for (sal_uInt16 nC = 0; nC < nNumPos; nC++) 99 m_pResetPositionFlags[nC] = m_pObjStrm->QuickReaduInt8(); 100 >>> CID 1490901: Memory - illegal accesses (OVERRUN) >>> Overrunning array of 10 bytes at byte offset 10 by dereferencing >>> pointer "this->m_pResetPositionFlags + nNumPos". 101 memset(m_pResetPositionFlags + nNumPos, 0, SAL_N_ELEMENTS(m_pResetPositionFlags) - nNumPos); 102 103 m_nUseCount = m_pObjStrm->QuickReaduInt32(); 104 105 m_pAtomHolder->Read(m_pObjStrm.get()); 106 } To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DnHNc_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi2SKCkeRNkJGofrkikCHyyEJjMek-2Bt4-2Fl8VDFqEkxT59d5tXStkb-2BUIWvqDc3fLMV1nR1MkxCa1u-2FOP-2FEEDefDlaB8LoZIrwmUZee9DuKk1yf6wckAnz9BO9gJxOy-2B-2Bqwr-2Bs-2F9Vi8mQ7w-2F-2BP7MJTwDy84MpHQfLurr-2FJB-2B7-2Bq-2B3A-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 3 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1490900: Error handling issues (CHECKED_RETURN) /lotuswordpro/source/filter/lwp9reader.cxx: 114 in Lwp9Reader::ReadFileHeader()() *** CID 1490900: Error handling issues (CHECKED_RETURN) /lotuswordpro/source/filter/lwp9reader.cxx: 114 in Lwp9Reader::ReadFileHeader()() 108 return false; 109 110 //Remember to initialize the LwpFileHeader::m_nFileRevision first. 111 LwpFileHeader::m_nFileRevision = 0; 112 113 LwpObjectHeader objHdr; >>> CID 1490900: Error handling issues (CHECKED_RETURN) >>> Calling "Read" without checking return value (as is done elsewhere 4 >>> out of 5 times). 114 objHdr.Read(*m_pDocStream); 115 sal_Int64 pos = m_pDocStream->Tell(); 116 m_LwpFileHdr.Read(m_pDocStream); 117 return m_pDocStream->CheckSeek(pos + objHdr.GetSize()); 118 } 119 ** CID 1490899: Error handling issues (CHECKED_RETURN) /ucb/source/ucp/file/filtask.cxx: 2000 in fileaccess::TaskManager::copy_recursive(const rtl::OUString &, const rtl::OUString &, fileaccess::TaskManager::FileUrlType, bool)() *** CID 1490899: Error handling issues (CHECKED_RETURN) /ucb/source/ucp/file/filtask.cxx: 2000 in fileaccess::TaskManager::copy_recursive(const rtl::OUString &, const rtl::OUString &, fileaccess::TaskManager::FileUrlType, bool)() 1994 { 1995 err = osl_File_copy( srcUnqPath,dstUnqPath,testExistBeforeCopy ); 1996 } 1997 else if( TypeToCopy == FileUrlType::Folder ) 1998 { 1999 osl::Directory aDir( srcUnqPath ); >>> CID 1490899: Error handling issues (CHECKED_RETURN) >>> Calling "open" without checking return value (as is done elsewhere 33 >>> out of 41 times). 2000 aDir.open(); 2001 2002 err = osl::Directory::create( dstUnqPath ); 2003 osl::FileBase::RC next = err; 2004 if( err == osl::FileBase::E_None ) 2005 { ** CID 1490898:(CHECKED_RETURN) /hwpfilter/source/hwpread.cxx: 73 in FieldCode::Read(HWPFile &)() /hwpfilter/source/hwpread.cxx: 76 in FieldCode::Read(HWPFile &)() *** CID 1490898:(CHECKED_RETURN) /hwpfilter/source/hwpread.cxx: 73 in FieldCode::Read(HWPFile &)() 67 uint len1; /* Length of hchar type string DATA #1 */ 68 uint len2; /* Length of hchar type string DATA #2 */ 69 uint len3; /* Length of hchar type string DATA #3 */ 70 uint binlen; /* Length of any binary data format */ 71 72 hwpf.Read4b(size); >>> CID 1490898:(CHECKED_RETURN) >>> Calling "Read2b" without checking return value (as is done elsewhere 45 >>> out of 47 times). 73 hwpf.Read2b(dummy); 74 hwpf.ReadBlock(, 2); 75 hwpf.Read4b(reserved1.data(), 1); 76 hwpf.Read2b(location_info); 77 hwpf.ReadBlock(reserved2.data(), 22); 78 hwpf.Read4b(len1); /hwpfilter/source/hwpread.cxx: 76 in FieldCode::Read(HWPFile &)() 70 uint binlen; /* Length of any binary data format */ 71 72 hwpf.Read4b(size); 73 hwpf.Read2b(dummy); 74 hwpf.ReadBlock(, 2); 75 hwpf.Read4b(reserved1.data(), 1); >>> CID 1490898:(CHECKED_RETURN) >>> Calling "Read2b" without checking return value (as is done elsewhere 45 >>> out of 47 times). 76 hwpf.Read2b(location_info); 77 hwpf.ReadBlock(reserved2.data(), 22); 78 hwpf.Read4b(len1); 79 hwpf.Read4b(len2); 80 hwpf.Read4b(len3); 81 bool bSuccess = hwpf.Read4b(binlen); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DSGf8_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiWVgLSSLavBQzbdOP3tHoT1YMNjwUkJhKZvAbMXByubX22kJ35kSU6HTOsLxQvaetDHFID4RtezkzgoFcDiT0JSnYRytoPbSfMae4kHlSDnTNPxgFAZkUwx7g1IEb8-2FK90qxGXXiYLZe-2BxUhTF4rGxFQuDD2LUgn-2FtMZtxIWravU-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1490801: Uninitialized members (UNINIT_CTOR) /dbaccess/source/ui/misc/TokenWriter.cxx: 93 in dbaui::ODatabaseImportExport::ODatabaseImportExport(const svx::ODataAccessDescriptor &, const com::sun::star::uno::Reference &, const com::sun::star::uno::Reference &)() *** CID 1490801: Uninitialized members (UNINIT_CTOR) /dbaccess/source/ui/misc/TokenWriter.cxx: 93 in dbaui::ODatabaseImportExport::ODatabaseImportExport(const svx::ODataAccessDescriptor &, const com::sun::star::uno::Reference &, const com::sun::star::uno::Reference &)() 87 { 88 m_eDestEnc = osl_getThreadTextEncoding(); 89 90 osl_atomic_increment( _refCount ); 91 impl_initFromDescriptor( _aDataDescriptor, false ); 92 osl_atomic_decrement( _refCount ); >>> CID 1490801: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "m_pStream" is not initialized in this >>> constructor nor in any functions that it calls. 93 } 94 95 // import data 96 ODatabaseImportExport::ODatabaseImportExport( const ::dbtools::SharedConnection& _rxConnection, 97 const Reference< XNumberFormatter >& _rxNumberF, const Reference< XComponentContext >& _rM ) 98 :m_bBookmarkSelection( false ) To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DGLnI_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi-2Bl-2FHNGekJK0XIoSP6jkvK9QxLf75mDkoC0RXFzDCMvbzuhyQFnywnf-2FgnMkcOMMbVEcaH3f8Hz942CgkkRkLidsGI-2F1cSi27xJ7er6O642CElzU20Cpj5iQTjJrggPkXuDn9GBjN-2F01jHAg1uEloFSci-2BmA-2FLgjdOC0-2FcaoDg-2FQ-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1490403: Control flow issues (DEADCODE) /sc/source/filter/oox/richstring.cxx: 158 in oox::xlslcl_unEscapeUnicodeChars(const rtl::OUString &)() *** CID 1490403: Control flow issues (DEADCODE) /sc/source/filter/oox/richstring.cxx: 158 in oox::xlslcl_unEscapeUnicodeChars(const rtl::OUString &)() 152 } 153 while (nPrefixStart != -1); 154 155 if (bFound) 156 return aBuf.makeStringAndClear(); 157 >>> CID 1490403: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: ".OUString(rSrc);". 158 return rSrc; 159 } 160 161 } // namespace 162 163 RichStringPortion::RichStringPortion( const WorkbookHelper& rHelper ) : ** CID 1490402: Resource leaks (RESOURCE_LEAK) /sw/source/core/doc/DocumentContentOperationsManager.cxx: 1282 in ::lcl_SetRedline(SwDoc &, const SwPaM &)() *** CID 1490402: Resource leaks (RESOURCE_LEAK) /sw/source/core/doc/DocumentContentOperationsManager.cxx: 1282 in ::lcl_SetRedline(SwDoc &, const SwPaM &)() 1276 { 1277 std::unique_ptr xRedlineExtraData; 1278 xRedlineExtraData.reset(pExtra); 1279 pRedline->SetExtraData( xRedlineExtraData.get() ); 1280 } 1281 } >>> CID 1490402: Resource leaks (RESOURCE_LEAK) >>> Variable "pExtra" going out of scope leaks the storage it points to. 1282 } 1283 1284 /// Insert Hints according to content types; 1285 // Is used in SwDoc::Insert(..., SwFormatHint ) 1286 1287 bool lcl_InsAttr( To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D-URW_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi7JsXB6G7QnBn3MjYxwO36ZPYbjRt8Nu9DFV-2BG8dX3LC-2FC6UlNdaE9UGd5wB-2B7NijChy2qaJFfbc-2FpSFEfeIzWYqZO325YmOLThsswFbgHDpSKyfxAmSwvj3DrdjQTdVi7NsYCV9l8cgYDAdFlucAhf9-2BbfbnrimvTDYlpuYWORQ-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 5 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1490358: Null pointer dereferences (FORWARD_NULL) *** CID 1490358: Null pointer dereferences (FORWARD_NULL) /vcl/source/outdev/bitmap.cxx: 177 in OutputDevice::DrawBitmap(const Point &, const Size &, const Point &, const Size &, const Bitmap &, MetaActionType)() 171 aBmp.Scale(nScaleX, nScaleY); 172 aPosAry.mnSrcWidth = aPosAry.mnDestWidth; 173 aPosAry.mnSrcHeight = aPosAry.mnDestHeight; 174 } 175 } 176 >>> CID 1490358: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "this->mpGraphics" to "DrawBitmap", which >>> dereferences it. 177 mpGraphics->DrawBitmap( aPosAry, *aBmp.ImplGetSalBitmap(), *this ); 178 } 179 } 180 } 181 182 if( mpAlphaVDev ) ** CID 1490357: Null pointer dereferences (FORWARD_NULL) *** CID 1490357: Null pointer dereferences (FORWARD_NULL) /starmath/source/mathml/import.cxx: 708 in ::SmMLImportContext::inheritStyle()() 702 aAttribute.setMlForm(); 703 m_pElement->setAttribute(aAttribute); 704 } 705 } 706 707 // Inherit mathvariant >>> CID 1490357: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "this->m_pStyle" to "isAttributeSet", which >>> dereferences it. 708 if (m_pStyle->isAttributeSet(SmMlAttributeValueType::MlMathvariant)) 709 m_pElement->setAttribute(m_pStyle->getAttribute(SmMlAttributeValueType::MlMathvariant)); 710 } 711 712 void SmMLImportContext::inheritStyleEnd() 713 { ** CID 1490356: Resource leaks (RESOURCE_LEAK) /sc/source/filter/excel/xiescher.cxx: 1860 in XclImpNoteObj::DoPreProcessSdrObj(XclImpDffConverter &, SdrObject &) const() *** CID 1490356: Resource leaks (RESOURCE_LEAK) /sc/source/filter/excel/xiescher.cxx: 1860 in XclImpNoteObj::DoPreProcessSdrObj(XclImpDffConverter &, SdrObject &) const() 1854 // create formatted text 1855 XclImpTextObj::DoPreProcessSdrObj( rDffConv, rSdrObj ); 1856 OutlinerParaObject* pOutlinerObj = rSdrObj.GetOutlinerParaObject(); 1857 if( maScPos.IsValid() && pOutlinerObj ) 1858 { 1859 // create cell note with all data from drawing object >>> CID 1490356: Resource leaks (RESOURCE_LEAK) >>> Failing to save or free storage allocated by "new >>> OutlinerParaObject(pOutlinerObj)" leaks it. 1860 ScNoteUtil::CreateNoteFromObjectData( 1861 GetDoc(), maScPos, 1862 rSdrObj.GetMergedItemSet().Clone(), // new object on heap expected 1863 new OutlinerParaObject( *pOutlinerObj ),// new object on heap expected 1864 rSdrObj.GetLogicRect(), 1865 ::get_flag( mnNoteFlags, EXC_NOTE_VISIBLE ) ); ** CID 1490355: Control flow issues (DEADCODE) /starmath/source/mathml/import.cxx: 114 in SmMLImportWrapper::Import(SfxMedium &)() *** CID 1490355: Control flow issues (DEADCODE) /starmath/source/mathml/import.cxx: 114 in SmMLImportWrapper::Import(SfxMedium &)() 108 { 109 SAL_WARN("starmath", "Failed to fetch sm model while file input"); 110 return ERRCODE_SFX_DOLOADFAILED; 111 } 112 113 // Get doc shell >>> CID 1490355: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "NULL" inside this statement: >>> "this->m_pDocShell = (pModel...". 114 m_pDocShell = pModel ? static_cast(pModel->GetObjectShell()) : nullptr; 115 if (m_pDocShell == nullptr) 116 { 117 SAL_WARN("starmath", "Failed to fetch smdoc shell while file input"); 118 return ERRCODE_SFX_DOLOADFAILED; 119 } ** CID 1490354: Control flow issues (DEADCODE) /starmath/source/mathml/import.cxx: 317 in SmMLImportWrapper::Import(std::basic_string_view>)() *** CID 1490354: Control flow issues (DEADCODE) /starmath/source/mathml/import.cxx: 317 in SmMLImportWrapper::Import(std::basic_string_view>)() 311 { 312 SAL_WARN("starmath",
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 3 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1490212: Insecure data handling (TAINTED_SCALAR) /sw/source/filter/ww8/ww8par.cxx: 1029 in SwMSDffManager::ProcessObj(SvStream &, DffObjData &, SvxMSDffClientData &, tools::Rectangle &, SdrObject *)() *** CID 1490212: Insecure data handling (TAINTED_SCALAR) /sw/source/filter/ww8/ww8par.cxx: 1029 in SwMSDffManager::ProcessObj(SvStream &, DffObjData &, SvxMSDffClientData &, tools::Rectangle &, SdrObject *)() 1023 rSt.ReadUInt16( nNumElemVert ).ReadUInt16( nNumElemMemVert ).ReadUInt16( nElemSizeVert ); 1024 bool bOk = false; 1025 if (nNumElemVert && ((nElemSizeVert == 8) || (nElemSizeVert == 4))) 1026 { 1027 //check if there is enough data in the file to make the 1028 //record sane >>> CID 1490212: Insecure data handling (TAINTED_SCALAR) >>> Using tainted expression "nElemSizeVert" as the divisor in >>> "rSt->remainingSize() / nElemSizeVert". 1029 bOk = rSt.remainingSize() / nElemSizeVert >= nNumElemVert; 1030 } 1031 if (bOk) 1032 { 1033 pImpRec->pWrapPolygon.reset( new tools::Polygon(nNumElemVert) ); 1034 for (sal_uInt16 i = 0; i < nNumElemVert; ++i) ** CID 1490211: API usage errors (SWAPPED_ARGUMENTS) *** CID 1490211: API usage errors (SWAPPED_ARGUMENTS) /vcl/backendtest/outputdevice/common.cxx: 793 in vcl::test::OutputDeviceTestCommon::checkClosedBezier(Bitmap &)() 787 { { 12, 9 }, true }, { { 12, 10 }, true }, { { 13, 9 }, true } }; 788 789 for (tools::Long x = 0; x < pAccess->Width(); x++) 790 { 791 for (tools::Long y = 0; y < pAccess->Height(); ++y) 792 { >>> CID 1490211: API usage errors (SWAPPED_ARGUMENTS) >>> The positions of arguments in the constructor for "std::pair>> long>" do not match the ordering of the parameters: * "y" is passed to "__x". * "x" is passed to "__y". 793 if (SetPixels[{ y, x }]) 794 { 795 checkValue(pAccess, x, y, constLineColor, nNumberOfQuirks, nNumberOfErrors, true); 796 } 797 else 798 { ** CID 1490210: API usage errors (SWAPPED_ARGUMENTS) *** CID 1490210: API usage errors (SWAPPED_ARGUMENTS) /vcl/backendtest/outputdevice/common.cxx: 748 in vcl::test::OutputDeviceTestCommon::checkHalfEllipse(Bitmap &, bool)() 742 }; 743 744 for (tools::Long x = 0; x < pAccess->Width(); x++) 745 { 746 for (tools::Long y = 0; y < pAccess->Height(); ++y) 747 { >>> CID 1490210: API usage errors (SWAPPED_ARGUMENTS) >>> The positions of arguments in the constructor for "std::pair>> long>" do not match the ordering of the parameters: * "y" is passed to "__x". * "x" is passed to "__y". 748 if (SetPixels[{ y, x }]) 749 { 750 if (aEnableAA) 751 checkValueAA(pAccess, x, y, constLineColor, nNumberOfQuirks, nNumberOfErrors); 752 else 753 checkValue(pAccess, x, y, constLineColor, nNumberOfQuirks, nNumberOfErrors, To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DRFee_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJifTM-2F2n3p4xbO-2BUuyFagSC0j7t4VRRVUxfA8yQxEqA3qAmGrU-2Bt3fpSMJtv3QfYmXNpNkNEXqF1UctOyMV7ulLJs1FWhXQX0FtPCF6MlAM8y-2BramEpHbmC29RphXwjpPLAsG5L5LLi4x-2BJYPeVsvH02qMX9DjOyaUafSKG3y3TFk-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1489971: API usage errors (SWAPPED_ARGUMENTS) *** CID 1489971: API usage errors (SWAPPED_ARGUMENTS) /vcl/backendtest/outputdevice/common.cxx: 612 in vcl::test::OutputDeviceTestCommon::checkDropShape(Bitmap &, bool)() 606 { 607 for (tools::Long y = 0; y < pAccess->Height(); y++) 608 { 609 if (SetPixels[{ x, y }]) 610 { 611 if (aEnableAA) >>> CID 1489971: API usage errors (SWAPPED_ARGUMENTS) >>> The positions of arguments in the call to "checkValueAA" do not match >>> the ordering of the parameters: * "y" is passed to "x". * "x" is passed to "y". 612checkValueAA(pAccess, y, x, constLineColor, nNumberOfQuirks, nNumberOfErrors); 613 else 614 checkValue(pAccess, y, x, constLineColor, nNumberOfQuirks, nNumberOfErrors, 615true); 616 } 617 else To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DRyE3_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJifGZZbwGrSHE6wQbc3OUfT7jh66b0aZMCdBZ0IODlXIawgntl7TRaUlZJPsA6vROL9jVf2ljm9N6MKowoh8kYZQ2qauuN17HO6HIk3m6bQ-2BSZtqfJT5cOzLEsCR-2F-2FnMgP7-2BQQiSthSfXwSRo2GrVhxLJ4oFiZClCCPwgHjZWYL1E-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1489785: Null pointer dereferences (FORWARD_NULL) *** CID 1489785: Null pointer dereferences (FORWARD_NULL) /sc/source/ui/drawfunc/fudraw.cxx: 717 in FuDraw::ForcePointer(const MouseEvent *)() 711 else if ( !bAlt && (pObj = pView->PickObj(aPnt, pView->getHitTolLog(), pPV, SdrSearchOptions::PICKMACRO)) ) 712 { 713 // could be suppressed with ALT 714 SdrObjMacroHitRec aHitRec; //! something missing 715 rViewShell.SetActivePointer( pObj->GetMacroPointer(aHitRec) ); 716 } >>> CID 1489785: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pObj" to "getHyperlink", which dereferences it. 717 else if ( !bAlt && pInfo && (!pInfo->GetMacro().isEmpty() || !pObj->getHyperlink().isEmpty()) ) 718 pWindow->SetPointer( PointerStyle::RefHand ); 719 else if ( IsDetectiveHit( aPnt ) ) 720 rViewShell.SetActivePointer( PointerStyle::Detective ); 721 else 722 { ** CID 1489784: Null pointer dereferences (FORWARD_NULL) /sc/source/ui/drawfunc/drawsh2.cxx: 239 in ScDrawShell::GetDrawFuncState(SfxItemSet &)() *** CID 1489784: Null pointer dereferences (FORWARD_NULL) /sc/source/ui/drawfunc/drawsh2.cxx: 239 in ScDrawShell::GetDrawFuncState(SfxItemSet &)() 233 { 234 rSet.DisableItem( SID_EDIT_HYPERLINK ); 235 rSet.DisableItem( SID_OPEN_HYPERLINK ); 236 rSet.DisableItem( SID_REMOVE_HYPERLINK ); 237 rSet.DisableItem( SID_COPY_HYPERLINK_LOCATION ); 238 } >>> CID 1489784: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pObj" to "GetLayer", which dereferences it. (The >>> dereference happens because this is a virtual function call.) 239 SdrLayerID nLayerID = pObj->GetLayer(); 240 if ( nLayerID != SC_LAYER_INTERN ) 241 bCanRename = true; // #i51351# anything except internal objects can be renamed 242 243 // #91929#; don't show original size entry if not possible 244 sal_uInt16 nObjType = pObj->GetObjIdentifier(); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D79FV_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiiQ7y-2FGsEsWVN-2FyCvUrEN-2FsNO2mXu7IIRuqP9syuSjbjitGYe-2FEYx4ap0VhSq6OeOrUA-2FSMhktDcLeS09UbmsNDaN7hyf22lGS-2BaEdnT4K0MBwpQp-2Bnx2ofN46yjqAH8re2euGwzQzHsdEpeLbmYiGwP5K5gKPfieCV-2BIK4tX-2Bkg-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1489780:(FORWARD_NULL) *** CID 1489780:(FORWARD_NULL) /formula/source/core/api/FormulaCompiler.cxx: 185 in formulaOpCodeList::OpCodeList(const std::pair *, const std::shared_ptr &, formula::FormulaCompiler::SeparatorType)() 179 std::unique_ptr xCharClass( xMap->isEnglish() ? nullptr : createCharClassIfNonEnglishUI()); 180 const CharClass* pCharClass = xCharClass.get(); 181 if (meSepType == FormulaCompiler::SeparatorType::RESOURCE_BASE) 182 { 183 for (sal_uInt16 i = 0; i <= SC_OPCODE_LAST_OPCODE_ID; ++i) 184 { >>> CID 1489780:(FORWARD_NULL) >>> "putDefaultOpCode" dereferences null "this->mpSymbols2". 185 putDefaultOpCode( xMap, i, pCharClass); 186 } 187 } 188 else 189 { 190 for (sal_uInt16 i = 0; i <= SC_OPCODE_LAST_OPCODE_ID; ++i) /formula/source/core/api/FormulaCompiler.cxx: 196 in formulaOpCodeList::OpCodeList(const std::pair *, const std::shared_ptr &, formula::FormulaCompiler::SeparatorType)() 190 for (sal_uInt16 i = 0; i <= SC_OPCODE_LAST_OPCODE_ID; ++i) 191 { 192 OUString aOpStr; 193 if ( getOpCodeString( aOpStr, i) ) 194 xMap->putOpCode( aOpStr, OpCode(i), pCharClass); 195 else >>> CID 1489780:(FORWARD_NULL) >>> "putDefaultOpCode" dereferences null "this->mpSymbols2". 196 putDefaultOpCode( xMap, i, pCharClass); 197 } 198 } 199 } 200 201 OpCodeList::OpCodeList(const std::pair* pSymbols, const FormulaCompiler::NonConstOpCodeMapPtr& xMap, ** CID 1489779: Uninitialized members (UNINIT_CTOR) /cppu/source/threadpool/current.cxx: 88 in cppu::IdContainer::IdContainer()() *** CID 1489779: Uninitialized members (UNINIT_CTOR) /cppu/source/threadpool/current.cxx: 88 in cppu::IdContainer::IdContainer()() 82 83 IdContainer::IdContainer() 84 { 85 pCurrentContext = nullptr; 86 pCurrentContextEnv = nullptr; 87 bInit = false; >>> CID 1489779: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "pCurrentId" is not initialized in this >>> constructor nor in any functions that it calls. 88 } 89 90 IdContainer::~IdContainer() 91 { 92 if (pCurrentContext) 93 { To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D40zJ_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi-2Baefm4BIHP4WMnGJFzx4MRUhOndRgt-2B94NY3pPPgGSHdMvUjmQ-2BQMC8Cd-2Fx4yzfUhq4y8Iyhj-2BCxKaCMpnj-2F3lysjoU5Dx5nWrNDpC-2FZ8nh6YeVKKtYcW8LgZoMUAeFTA8JfoZ0GncXnqFXui1iGiSwJciI2tKG9k3qEVLPNkCg-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1489772: SpotBugs: Correctness (FB.UR_UNINIT_READ) /nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java: 87 in net.adaptivebox.deps.DEPSAgent.(net.adaptivebox.problem.ProblemEncoder, net.adaptivebox.deps.behavior.DEGTBehavior, net.adaptivebox.deps.behavior.PSGTBehavior, double, net.adaptivebox.goodness.IGoodnessCompareEngine)() *** CID 1489772: SpotBugs: Correctness (FB.UR_UNINIT_READ) /nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java: 87 in net.adaptivebox.deps.DEPSAgent.(net.adaptivebox.problem.ProblemEncoder, net.adaptivebox.deps.behavior.DEGTBehavior, net.adaptivebox.deps.behavior.PSGTBehavior, double, net.adaptivebox.goodness.IGoodnessCompareEngine)() 81 82 trailPoint = problemEncoder.getFreshSearchPoint(); 83 pold_t = problemEncoder.getFreshSearchPoint(); 84 pcurrent_t = problemEncoder.getFreshSearchPoint(); 85 86 this.deGTBehavior = deGTBehavior; >>> CID 1489772: SpotBugs: Correctness (FB.UR_UNINIT_READ) >>> Uninitialized read of pbest_t. 87 this.deGTBehavior.setMemPoints(pbest_t, pcurrent_t, pold_t); 88 89 this.psGTBehavior = psGTBehavior; 90 this.psGTBehavior.setMemPoints(pbest_t, pcurrent_t, pold_t); 91 } 92 To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dv8qW_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJioSll6KRhwFvxkHzPBDF73HYLDsLZjsg83I-2BhiAhNUA-2BdsVtzFBIk1K7TcAKsVQhxHTayiofVpObqU3B7-2BKgr2yMK7cm-2FDkaegLkkIok9RyV-2F1LurQnmWRIuXFv-2BeRrjhqXI5HejyE-2B01BUR5Ky56aSWQfflMjy0UlWXm6b88fxs-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1489715: Uninitialized members (UNINIT_CTOR) /sfx2/source/dialog/StyleList.cxx: 110 in StyleList::StyleList(weld::Builder *, std::optional>>, SfxBindings *, SfxCommonTemplateDialog_Impl *, SfxModule *, weld::Container *, rtl::OString, rtl::OString)() *** CID 1489715: Uninitialized members (UNINIT_CTOR) /sfx2/source/dialog/StyleList.cxx: 110 in StyleList::StyleList(weld::Builder *, std::optional>>, SfxBindings *, SfxCommonTemplateDialog_Impl *, SfxModule *, weld::Container *, rtl::OString, rtl::OString)() 104 , m_pBindings(pBindings) 105 , m_Module(Module) 106 , m_nModifier(0) 107 , m_pContainer(pC) 108 { 109 m_xFmtLb->set_help_id(HID_TEMPLATE_FMT); >>> CID 1489715: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "m_pCurObjShell" is not initialized in this >>> constructor nor in any functions that it calls. 110 } 111 112 // Destructor 113 114 StyleList::~StyleList() {} 115 ** CID 1489714: Code maintainability issues (UNUSED_VALUE) /sfx2/source/dialog/templdlg.cxx: 293 in SfxCommonTemplateDialog_Impl::UpdateStyles_Hdl(StyleFlags)() *** CID 1489714: Code maintainability issues (UNUSED_VALUE) /sfx2/source/dialog/templdlg.cxx: 293 in SfxCommonTemplateDialog_Impl::UpdateStyles_Hdl(StyleFlags)() 287 { 288 const SfxStyleFamilyItem* pItem = m_aStyleList.GetFamilyItem(); 289 SfxStyleSearchBits nFilter(nActFilter < pItem->GetFilterList().size() 290? pItem->GetFilterList()[nActFilter].nFlags 291: SfxStyleSearchBits::Auto); 292 if (nFilter == SfxStyleSearchBits::Auto) // automatic >>> CID 1489714: Code maintainability issues (UNUSED_VALUE) >>> Assigning value from "this->nAppFilter" to "nFilter" here, but that >>> stored value is overwritten before it can be used. 293 nFilter = nAppFilter; 294 295 if (nFlags & StyleFlags::UpdateFamily) // Update view type list (Hierarchical, All, etc. 296 { 297 CheckItem(OString::number(nActFamily)); // check Button in Toolbox 298 To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DbvlA_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJibyFXcp2BSjbWWHwprB-2Beqe-2BNVXryV8GFOAjWyScuw-2BsDnUv8tOFvzHg-2FzppES2PFqAquFpExdtVkh5uL6TPJl-2FoQYqAuCHQTTpSZ0qFT6Wh9Cek1KslpHPF9A7Q-2FOmTKK3vieDyVJT3vtcO-2FLljAKSURxNzgc4UowJD-2BOKHd-2Fn8-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1489568: Null pointer dereferences (NULL_RETURNS) *** CID 1489568: Null pointer dereferences (NULL_RETURNS) /sc/source/ui/docshell/dbdocfun.cxx: 605 in ScDBDocFunc::Sort(short, const ScSortParam &, bool, bool, bool)() 599 SfxViewShell* pViewShell = SfxViewShell::GetFirst(); 600 while (pViewShell) 601 { 602 ScTabViewShell* pTabViewShell = dynamic_cast(pViewShell); 603 if (pTabViewShell && pTabViewShell->GetDocId() == pSomeViewForThisDoc->GetDocId()) 604 { >>> CID 1489568: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "nullptr" >>> "pTabViewShell->GetViewData()->GetLOKHeightHelper(nTab)" when calling >>> "invalidateByIndex". 605 pTabViewShell->GetViewData().GetLOKHeightHelper(nTab)->invalidateByIndex(nStartRow); 606 } 607 pViewShell = SfxViewShell::GetNext(*pViewShell); 608 } 609 610 ScTabViewShell::notifyAllViewsSheetGeomInvalidation( ** CID 1399290:(UNCAUGHT_EXCEPT) /sw/source/uibase/lingu/hhcwrp.cxx: 110 in SwHHCWrapper::~SwHHCWrapper()() /sw/source/uibase/lingu/hhcwrp.cxx: 110 in SwHHCWrapper::~SwHHCWrapper()() /sw/source/uibase/lingu/hhcwrp.cxx: 110 in SwHHCWrapper::~SwHHCWrapper()() /sw/source/uibase/lingu/hhcwrp.cxx: 110 in SwHHCWrapper::~SwHHCWrapper()() *** CID 1399290:(UNCAUGHT_EXCEPT) /sw/source/uibase/lingu/hhcwrp.cxx: 110 in SwHHCWrapper::~SwHHCWrapper()() 104 , m_bIsSelection( bSelection ) 105 , m_bStartDone( bOther || bStart ) 106 , m_bEndDone( false ) 107 { 108 } 109 >>> CID 1399290:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 110 SwHHCWrapper::~SwHHCWrapper() 111 { 112 m_pConvArgs.reset(); 113 114 SwViewShell::SetCareDialog(nullptr); 115 /sw/source/uibase/lingu/hhcwrp.cxx: 110 in SwHHCWrapper::~SwHHCWrapper()() 104 , m_bIsSelection( bSelection ) 105 , m_bStartDone( bOther || bStart ) 106 , m_bEndDone( false ) 107 { 108 } 109 >>> CID 1399290:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 110 SwHHCWrapper::~SwHHCWrapper() 111 { 112 m_pConvArgs.reset(); 113 114 SwViewShell::SetCareDialog(nullptr); 115 /sw/source/uibase/lingu/hhcwrp.cxx: 110 in SwHHCWrapper::~SwHHCWrapper()() 104 , m_bIsSelection( bSelection ) 105 , m_bStartDone( bOther || bStart ) 106 , m_bEndDone( false ) 107 { 108 } 109 >>> CID 1399290:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 110 SwHHCWrapper::~SwHHCWrapper() 111 { 112 m_pConvArgs.reset(); 113 114 SwViewShell::SetCareDialog(nullptr); 115 /sw/source/uibase/lingu/hhcwrp.cxx: 110 in SwHHCWrapper::~SwHHCWrapper()() 104 , m_bIsSelection( bSelection ) 105 , m_bStartDone( bOther || bStart ) 106 , m_bEndDone( false ) 107 { 108 } 109 >>> CID 1399290:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 110 SwHHCWrapper::~SwHHCWrapper() 111 { 112 m_pConvArgs.reset(); 113 114 SwViewShell::SetCareDialog(nullptr); 115 To view the defects in Coverity Scan visit,
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 3 new defect(s) introduced to LibreOffice found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1489553: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /vcl/source/filter/svm/SvmReader.cxx: 829 in SvmReader::TextRectHandler(ImplMetaReadData *)() *** CID 1489553: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /vcl/source/filter/svm/SvmReader.cxx: 829 in SvmReader::TextRectHandler(ImplMetaReadData *)() 823 aSerializer.readRectangle(aRect); 824 OUString aStr = mrStream.ReadUniOrByteString(pData->meActualCharSet); 825 sal_uInt16 nTmp(0); 826 mrStream.ReadUInt16(nTmp); 827 828 pAction->SetRect(aRect); >>> CID 1489553: Integer handling issues (CONSTANT_EXPRESSION_RESULT) >>> In "nTmp &= 262143 /* o3tl::is_typed_flags::mask >>> */", wider "262143 /* o3tl::is_typed_flags::mask */" >>> has high-order bits (0x3) that don't affect the narrower left-hand side. 829 nTmp &= o3tl::typed_flags::mask; 830 pAction->SetStyle(static_cast(nTmp)); 831 832 if (aCompat.GetVersion() >= 2) // Version 2 833 aStr = read_uInt16_lenPrefixed_uInt16s_ToOUString(mrStream); 834 ** CID 1489552: Uninitialized variables (UNINIT) *** CID 1489552: Uninitialized variables (UNINIT) /bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx: 229 in x86_64::examine_argument(_typelib_TypeDescriptionReference *, int &, int &)() 223class. Return 0 iff parameter should be passed in memory. */ 224 bool x86_64::examine_argument( typelib_TypeDescriptionReference *pTypeRef, int , int ) noexcept 225 { 226 enum x86_64_reg_class classes[MAX_CLASSES]; 227 int n; 228 >>> CID 1489552: Uninitialized variables (UNINIT) >>> Using uninitialized value "*classes" when calling "classify_argument". 229 n = classify_argument( pTypeRef, classes, 0 ); 230 231 if ( n == 0 ) 232 return false; 233 234 nUsedGPR = 0; ** CID 1489551: Uninitialized variables (UNINIT) *** CID 1489551: Uninitialized variables (UNINIT) /bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx: 259 in x86_64::return_in_hidden_param(_typelib_TypeDescriptionReference *)() 253 bool x86_64::return_in_hidden_param( typelib_TypeDescriptionReference *pTypeRef ) noexcept 254 { 255 if (pTypeRef->eTypeClass == typelib_TypeClass_VOID) { 256 return false; 257 } 258 x86_64_reg_class classes[MAX_CLASSES]; >>> CID 1489551: Uninitialized variables (UNINIT) >>> Using uninitialized value "*classes" when calling "classify_argument". 259 return classify_argument(pTypeRef, classes, 0) == 0; 260 } 261 262 void x86_64::fill_struct( typelib_TypeDescriptionReference *pTypeRef, const sal_uInt64 *pGPR, const double *pSSE, void *pStruct ) noexcept 263 { 264 enum x86_64_reg_class classes[MAX_CLASSES]; To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DGk4V_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiz2EtKpeOylstsfsB-2BlTEuRV1mB6hKLHoei9oBgi4O0tZAEi6wFGrJZF-2Bb01gKT2ky20zaXs3CB5PL-2FOCTxjyN5HpXOCEWk7zsvsZY4H1BhPZZr5cCavv-2FP4EoNgBdd5oZ-2BA-2BR3af1HJl-2BbvlxJ-2FU61B8kjTiFpuRMfDdD4uAuuw-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 122 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1489549: Error handling issues (UNCAUGHT_EXCEPT) /svx/source/engine3d/view3d.cxx: 131 in Impl3DMirrorConstructOverlay::~Impl3DMirrorConstructOverlay()() *** CID 1489549: Error handling issues (UNCAUGHT_EXCEPT) /svx/source/engine3d/view3d.cxx: 131 in Impl3DMirrorConstructOverlay::~Impl3DMirrorConstructOverlay()() 125 SdrObject* pObject = mrView.GetMarkedObjectByIndex(a); 126 mpPolygons[mnCount - (a + 1)] = pObject->TakeXorPoly(); 127 } 128 } 129 } 130 >>> CID 1489549: Error handling issues (UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 131 Impl3DMirrorConstructOverlay::~Impl3DMirrorConstructOverlay() 132 { 133 // The OverlayObjects are cleared using the destructor of OverlayObjectList. 134 // That destructor calls clear() at the list which removes all objects from the 135 // OverlayManager and deletes them. 136 if(!mrView.IsSolidDragging()) To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D6UZx_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiRSEaShgjsvo2VC-2F3R0UpVSJN1R8UEwX3snUCrl5xr4iLewDupMHEJgWGnV64m7Ed1cHj2xYU9SlBvosfORaHefFWg39JsfUk3HfXXWxV3Agv-2BquOOeX7mG8aM42zTpecJZCJTD6Luhos8UPm4kNy2HBL01KASYclGJmG1dLCcyY-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 124 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 20 of 124 defect(s) ** CID 1489541: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 754 in XSecParser::XadesCertificateValuesContext::CreateChildContext(std::optional, unsigned short, const rtl::OUString &)() *** CID 1489541: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 754 in XSecParser::XadesCertificateValuesContext::CreateChildContext(std::optional, unsigned short, const rtl::OUString &)() 748 css::uno::Reference const& xAttrs) override 749 { 750 m_rParser.HandleIdAttr(xAttrs); 751 } 752 753 virtual std::unique_ptr CreateChildContext( >>> CID 1489541: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type >>> "std::optional" (size 240 bytes) by value. 754 std::optional pOldNamespaceMap, 755 sal_uInt16 const nNamespace, OUString const& rName) override 756 { 757 if (nNamespace == XML_NAMESPACE_XADES132 && rName == "EncapsulatedX509Certificate") 758 { 759 return std::make_unique(m_rParser, std::move(pOldNamespaceMap)); ** CID 1489540: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 1339 in XSecParser::DsObjectContext::DsObjectContext(XSecParser&, std::optional)() *** CID 1489540: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 1339 in XSecParser::DsObjectContext::DsObjectContext(XSecParser&, std::optional)() 1333 1334 class XSecParser::DsObjectContext 1335 : public XSecParser::ReferencedContextImpl 1336 { 1337 public: 1338 DsObjectContext(XSecParser & rParser, >>> CID 1489540: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type >>> "std::optional" (size 240 bytes) by value. 1339 std::optional pOldNamespaceMap) 1340 // init with "false" here - the Signature element can't be referenced by its child 1341 : XSecParser::ReferencedContextImpl(rParser, std::move(pOldNamespaceMap), false) 1342 { 1343 } 1344 ** CID 1489539: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 675 in OOXMLSecParser::XadesSigningCertificateContext::CreateChildContext(std::optional, unsigned short, const rtl::OUString &)() *** CID 1489539: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 675 in OOXMLSecParser::XadesSigningCertificateContext::CreateChildContext(std::optional, unsigned short, const rtl::OUString &)() 669 bool const isReferenced) 670 : ReferencedContextImpl(rParser, std::move(pOldNamespaceMap), isReferenced) 671 { 672 } 673 674 virtual std::unique_ptr CreateChildContext( >>> CID 1489539: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type >>> "std::optional" (size 240 bytes) by value. 675 std::optional pOldNamespaceMap, 676 sal_uInt16 const nNamespace, OUString const& rName) override 677 { 678 if (nNamespace == XML_NAMESPACE_XADES132 && rName == "Cert") 679 { 680 return std::make_unique(m_rParser, std::move(pOldNamespaceMap), m_isReferenced); ** CID 1489538: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 846 in XSecParser::LoSignatureLineIdContext::LoSignatureLineIdContext(XSecParser&, std::optional, bool)() *** CID 1489538: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 846 in XSecParser::LoSignatureLineIdContext::LoSignatureLineIdContext(XSecParser&, std::optional, bool)() 840 { 841 private: 842 OUString m_Value; 843 844 public: 845 LoSignatureLineIdContext(XSecParser & rParser, >>> CID 1489538: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1487531: Control flow issues (DEADCODE) /sw/source/core/doc/DocumentStylePoolManager.cxx: 1494 in sw::DocumentStylePoolManager::GetFormatFromPool(unsigned short)() *** CID 1487531: Control flow issues (DEADCODE) /sw/source/core/doc/DocumentStylePoolManager.cxx: 1494 in sw::DocumentStylePoolManager::GetFormatFromPool(unsigned short)() 1488 { 1489 return pNewFormat; 1490 } 1491 } 1492 1493 OUString aNm(SwResId(pRCId)); >>> CID 1487531: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: ".WhichRangesCont...". 1494 SwAttrSet aSet( m_rDoc.GetAttrPool(), pWhichRange ? *pWhichRange : WhichRangesContainer() ); 1495 1496 { 1497 bool bIsModified = m_rDoc.getIDocumentState().IsModified(); 1498 1499 { To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dv57j_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJidbGnoEy66aA3PCyfawsyZMPkUWUTri9m2KrmMlBru-2Bd9W8IHFVeFFXGXg4ryTyJe1631jDQCZqyH9b6v4suzh2zyVp2O0s35Xu2ZLPU96E8-2BSwcN-2Bo7BkBnM-2Fm2SL4yY9KI-2BySVDo9O2tufLoMxqFxdnC4D8j-2BuH-2Bw8oBjMWKBI-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1487495: Integer handling issues (DIVIDE_BY_ZERO) /sc/source/core/tool/interpr1.cxx: 2377 in ScInterpreter::ScCell()() *** CID 1487495: Integer handling issues (DIVIDE_BY_ZERO) /sc/source/core/tool/interpr1.cxx: 2377 in ScInterpreter::ScCell()() 2371 // font color doesn't matter here 2372 mrDoc.GetDefPattern()->GetFont( aDefFont, SC_AUTOCOL_BLACK, pPrinter ); 2373 pPrinter->SetFont( aDefFont ); 2374 tools::Long nZeroWidth = pPrinter->GetTextWidth( OUString( '0' ) ); 2375 pPrinter->SetFont( aOldFont ); 2376 pPrinter->SetMapMode( aOldMode ); >>> CID 1487495: Integer handling issues (DIVIDE_BY_ZERO) >>> In expression "this->mrDoc->GetColWidth(aCellPos.Col(), aCellPos.Tab(), >>> true) / nZeroWidth", division by expression "nZeroWidth" which may be zero >>> has undefined behavior. 2377 int nZeroCount = static_cast(mrDoc.GetColWidth( aCellPos.Col(), aCellPos.Tab() ) / nZeroWidth); 2378 PushInt( nZeroCount ); 2379 } 2380 else if( aInfoType == "PREFIX" ) 2381 { // ' = left; " = right; ^ = centered 2382 sal_Unicode c = 0; To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D8oHc_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJil84TeszvTF-2BATNMNWQLWahJNDrIgOft5H368nfftwb99KxSaEQkey-2BdrK5HEs1Gw2Uh-2FvM-2BMibr3Z0fLZbC7x9rrJprSsvirXgMiCYfUKdMWQ1FyOKZiUKyR9-2BB9MfZHz5Tkdu5Qdp9jwsZ-2Fy5TgY0e8yeJbLRSQVhXty56PGeA-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1487031:(TAINTED_SCALAR) /vcl/source/filter/svm/SvmReader.cxx: 730 in SvmReader::TextArrayHandler(ImplMetaReadData *)() /vcl/source/filter/svm/SvmReader.cxx: 719 in SvmReader::TextArrayHandler(ImplMetaReadData *)() *** CID 1487031:(TAINTED_SCALAR) /vcl/source/filter/svm/SvmReader.cxx: 730 in SvmReader::TextArrayHandler(ImplMetaReadData *)() 724 for (i = 0; i < nAryLen; i++) 725 { 726 mrStream.ReadInt32(val); 727 aArray[i] = val; 728 } 729 // #106172# setup remainder >>> CID 1487031:(TAINTED_SCALAR) >>> Using tainted variable "nTmpLen" as a loop boundary. 730 for (; i < nTmpLen; i++) 731 aArray[i] = 0; 732 } 733 } 734 else 735 { /vcl/source/filter/svm/SvmReader.cxx: 719 in SvmReader::TextArrayHandler(ImplMetaReadData *)() 713 714 if (nAryLen) 715 { 716 // #i9762#, #106172# Ensure that DX array is at least mnLen entries long 717 if (nTmpLen >= nAryLen) 718 { >>> CID 1487031:(TAINTED_SCALAR) >>> Passing tainted expression "nTmpLen * 8UL" to "operator new[]", which >>> uses it as an allocation size. 719 aArray.reset(new (std::nothrow) tools::Long[nTmpLen]); 720 if (aArray) 721 { 722 sal_Int32 i; 723 sal_Int32 val; 724 for (i = 0; i < nAryLen; i++) To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D8t0__OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiZLg-2FhhZU40JdDnlkz7uSerbednszgGbOaYkWH4-2BRmJvr4Puwx2qW0yhvtD-2FHhrlwIOL-2BARlL2NRJNYNbpKVur-2BuVXKlr0Wi5I-2FOxSx1xpWvZX4GaA58qc2mIqyyq-2FmiDZCK3Q5cDcov63Gd7-2BF3wJgux71lv1xifcuDVhFWXx5I-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 4 new defect(s) introduced to LibreOffice found with Coverity Scan. 6 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1487479: Integer handling issues (DIVIDE_BY_ZERO) *** CID 1487479: Integer handling issues (DIVIDE_BY_ZERO) /svx/source/svdraw/svdopath.cxx: 2395 in SdrPathObj::NbcSetSnapRect(const tools::Rectangle &)() 2389 if ( nDivX == 0 ) { nMulX = 1; nDivX = 1; } 2390 if ( nDivY == 0 ) { nMulY = 1; nDivY = 1; } 2391 if ( nDivX == nMulX ) { nMulX = 1; nDivX = 1; } 2392 if ( nDivY == nMulY ) { nMulY = 1; nDivY = 1; } 2393 Fraction aX(nMulX,nDivX); 2394 Fraction aY(nMulY,nDivY); >>> CID 1487479: Integer handling issues (DIVIDE_BY_ZERO) >>> In function call "NbcResize", modulo by expression "aX.mnNumerator" >>> which may be zero has undefined behavior. 2395 NbcResize(aOld.TopLeft(), aX, aY); 2396 NbcMove(Size(rRect.Left() - aOld.Left(), rRect.Top() - aOld.Top())); 2397 } 2398 2399 sal_uInt32 SdrPathObj::GetSnapPointCount() const 2400 { ** CID 1487478: Integer handling issues (DIVIDE_BY_ZERO) *** CID 1487478: Integer handling issues (DIVIDE_BY_ZERO) /svx/source/svdraw/svdopath.cxx: 2395 in SdrPathObj::NbcSetSnapRect(const tools::Rectangle &)() 2389 if ( nDivX == 0 ) { nMulX = 1; nDivX = 1; } 2390 if ( nDivY == 0 ) { nMulY = 1; nDivY = 1; } 2391 if ( nDivX == nMulX ) { nMulX = 1; nDivX = 1; } 2392 if ( nDivY == nMulY ) { nMulY = 1; nDivY = 1; } 2393 Fraction aX(nMulX,nDivX); 2394 Fraction aY(nMulY,nDivY); >>> CID 1487478: Integer handling issues (DIVIDE_BY_ZERO) >>> In function call "NbcResize", modulo by expression "aY.mnNumerator" >>> which may be zero has undefined behavior. 2395 NbcResize(aOld.TopLeft(), aX, aY); 2396 NbcMove(Size(rRect.Left() - aOld.Left(), rRect.Top() - aOld.Top())); 2397 } 2398 2399 sal_uInt32 SdrPathObj::GetSnapPointCount() const 2400 { ** CID 1475942: Uninitialized members (UNINIT_CTOR) /usr/include/c++/9/bits/random.h: 2010 in std::normal_distribution::normal_distribution()() *** CID 1475942: Uninitialized members (UNINIT_CTOR) /usr/include/c++/9/bits/random.h: 2010 in std::normal_distribution::normal_distribution()() 2004 private: 2005_RealType _M_mean; 2006_RealType _M_stddev; 2007 }; 2008 2009 public: >>> CID 1475942: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "_M_saved" is not initialized in this >>> constructor nor in any functions that it calls. 2010 normal_distribution() : normal_distribution(0.0) { } 2011 2012 /** 2013* Constructs a normal distribution with parameters @f$mean@f$ and 2014* standard deviation. 2015*/ ** CID 257629:(MISSING_BREAK) /workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx: 4451 in yytnamerr(char *, const char *)() /workdir/YaccTarget/idlc/source/parser.cxx: 1473 in yytnamerr(char *, const char *)() *** CID 257629:(MISSING_BREAK) /workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx: 4451 in yytnamerr(char *, const char *)() 4445 switch (*++yyp) 4446 { 4447 case '\'': 4448 case ',': 4449 goto do_not_strip_quotes; 4450 >>> CID 257629:(MISSING_BREAK) >>> The case for value "'\\'" is not terminated by a "break" statement. 4451 case '\\': 4452 if (*++yyp != '\\') 4453 goto do_not_strip_quotes; 4454 else 4455 goto append; 4456 /workdir/YaccTarget/idlc/source/parser.cxx: 1473 in yytnamerr(char *, const char *)() 1467 switch (*++yyp) 1468 { 1469 case '\'': 1470 case ',': 1471 goto do_not_strip_quotes; 1472 >>> CID 257629:(MISSING_BREAK) >>> The case for value "'\\'" is not terminated by a "break" statement. 1473 case '\\': 1474 if (*++yyp != '\\') 1475 goto do_not_strip_quotes; 1476 else 1477 goto append; 1478
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1487472: Uninitialized members (UNINIT_CTOR) /include/vcl/test/GraphicsRenderTests.hxx: 42 in GraphicsRenderTests::GraphicsRenderTests()() *** CID 1487472: Uninitialized members (UNINIT_CTOR) /include/vcl/test/GraphicsRenderTests.hxx: 42 in GraphicsRenderTests::GraphicsRenderTests()() 36 OUString getStatus() { return m_aTestStatus; } 37 Bitmap getBitmap() { return m_aResultantBitmap; } 38 }; 39 40 class VCL_PLUGIN_PUBLIC GraphicsRenderTests 41 { >>> CID 1487472: Uninitialized members (UNINIT_CTOR) >>> The compiler-generated constructor for this class does not initialize >>> "m_aStoreResultantBitmap". 42 bool m_aStoreResultantBitmap; 43 44 //For storing the test's info 45 std::vector m_aTestResult; 46 //For storing the current graphics Backend in use. 47 OUString m_aCurGraphicsBackend; To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dceaz_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi8BfZpwaUwBPELNuq9-2F5H79SVn7v0wVPBZZBf9pDvTC-2FzE8g-2F3SQvpgVvdW5XenXiz5nYMP-2BD-2BB9mSalBoYe459oepoKFOomukrY-2BhZ1F60Qo8rh1KlXqRZAE9PQbp9P0t46QH5pxtt7UpR7kn03d5e-2Fq6SXyv-2FBOrk0QhN9UtfU-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 6 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 6 of 6 defect(s) ** CID 1487035: Uninitialized members (UNINIT_CTOR) /oox/source/ole/oleobjecthelper.cxx: 52 in oox::ole::OleObjectInfo::OleObjectInfo()() *** CID 1487035: Uninitialized members (UNINIT_CTOR) /oox/source/ole/oleobjecthelper.cxx: 52 in oox::ole::OleObjectInfo::OleObjectInfo()() 46 47 OleObjectInfo::OleObjectInfo() : 48 mbLinked( false ), 49 mbShowAsIcon( false ), 50 mbAutoUpdate( false ) 51 { >>> CID 1487035: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "mbHasPicture" is not initialized in this >>> constructor nor in any functions that it calls. 52 } 53 54 const char g_aEmbeddedObjScheme[] = "vnd.sun.star.EmbeddedObject:"; 55 56 OleObjectHelper::OleObjectHelper( 57 const Reference< XMultiServiceFactory >& rxModelFactory, ** CID 1487034:(TAINTED_SCALAR) *** CID 1487034:(TAINTED_SCALAR) /vcl/source/filter/svm/SvmReader.cxx: 119 in SvmReader::Read(GDIMetaFile &, ImplMetaReadData *)() 113 { 114 if (pAction->GetType() == MetaActionType::COMMENT) 115 { 116 MetaCommentAction* pCommentAct 117 = static_cast(pAction.get()); 118 >>> CID 1487034:(TAINTED_SCALAR) >>> Passing tainted expression "*pCommentAct->GetComment().pData" to >>> "operator ==", which uses it as a loop boundary. 119 if (pCommentAct->GetComment() == "EMF_PLUS") 120 rMetaFile.UseCanvas(true); 121 } 122 rMetaFile.AddAction(pAction); 123 } 124 } /vcl/source/filter/svm/SvmReader.cxx: 119 in SvmReader::Read(GDIMetaFile &, ImplMetaReadData *)() 113 { 114 if (pAction->GetType() == MetaActionType::COMMENT) 115 { 116 MetaCommentAction* pCommentAct 117 = static_cast(pAction.get()); 118 >>> CID 1487034:(TAINTED_SCALAR) >>> Passing tainted expression "*pCommentAct->GetComment().pData" to >>> "operator ==", which uses it as an offset. 119 if (pCommentAct->GetComment() == "EMF_PLUS") 120 rMetaFile.UseCanvas(true); 121 } 122 rMetaFile.AddAction(pAction); 123 } 124 } ** CID 1487033:(FB.UWF_UNWRITTEN_FIELD) /nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java: 76 in () /nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java: 75 in () *** CID 1487033:(FB.UWF_UNWRITTEN_FIELD) /nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java: 76 in () 70 private DEGTBehavior deGTBehavior; 71 private PSGTBehavior psGTBehavior; 72 public double switchP = 0.5; 73 74 public void setLibrary(Library lib) { 75 deGTBehavior.setLibrary(lib); >>> CID 1487033:(FB.UWF_UNWRITTEN_FIELD) >>> Unwritten field: net.adaptivebox.deps.DEPSAgent.psGTBehavior. 76 psGTBehavior.setLibrary(lib); 77 } 78 79 public void setProblemEncoder(ProblemEncoder encoder) { 80 problemEncoder = encoder; 81 trailPoint = problemEncoder.getFreshSearchPoint(); /nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java: 75 in () 69 // Generate-and-test behaviors. 70 private DEGTBehavior deGTBehavior; 71 private PSGTBehavior psGTBehavior; 72 public double switchP = 0.5; 73 74 public void setLibrary(Library lib) { >>> CID 1487033:(FB.UWF_UNWRITTEN_FIELD) >>> Unwritten field: net.adaptivebox.deps.DEPSAgent.deGTBehavior. 75 deGTBehavior.setLibrary(lib); 76 psGTBehavior.setLibrary(lib); 77 } 78 79 public void setProblemEncoder(ProblemEncoder encoder) { 80 problemEncoder = encoder; ** CID 1487032:(FB.NP_UNWRITTEN_FIELD) /nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java: 76 in net.adaptivebox.deps.DEPSAgent.setLibrary(net.adaptivebox.knowledge.Library)()
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1487029: Incorrect expression (IDENTICAL_BRANCHES) /sc/source/filter/xml/XMLExportDatabaseRanges.cxx: 484 in ::WriteDatabaseRange::writeCondition(const ScQueryEntry &, int, bool, utl::SearchParam::SearchType)() *** CID 1487029: Incorrect expression (IDENTICAL_BRANCHES) /sc/source/filter/xml/XMLExportDatabaseRanges.cxx: 484 in ::WriteDatabaseRange::writeCondition(const ScQueryEntry &, int, bool, utl::SearchParam::SearchType)() 478 { 479 // Multi-item condition. 480 assert( rItems.size() > 1 && "rItems should have more than 1 element"); 481 482 // Store the 1st value for backward compatibility. 483 const ScQueryEntry::Item& rItem = rItems.front(); >>> CID 1487029: Incorrect expression (IDENTICAL_BRANCHES) >>> The same code is executed regardless of whether "rItem.meType == >>> ScQueryEntry::ByValue" is true, because the 'then' and 'else' branches are >>> identical. Should one of the branches be modified, or the entire 'if' >>> statement replaced? 484 if (rItem.meType == ScQueryEntry::ByValue) 485 { 486 mrExport.AddAttribute(XML_NAMESPACE_TABLE, XML_VALUE, rItem.maString.getString()); 487 } 488 else 489 { To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DwOnx_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJin9-2B-2BJqbuhkYr2oOcNx6-2FYQ6uI15Xuvwlqpxw-2BVUXWujt-2FnTQJMvadxq4-2FpPkbEz7lqKSezKmLxEowyBaU-2Fzyc7DaF1aOCNjcSuHM8Iba32rabAFlsI7QmHuH-2BqcqZZOvsxE0cIDGRbDEUo44TrSu4w-2BtGWVka-2FKjdW-2F70MaeDvo-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1486703: Control flow issues (DEADCODE) /sd/source/filter/eppt/pptx-epptooxml.cxx: 1573 in oox::core::PowerPointShapeExport::WritePlaceholderShape(const com::sun::star::uno::Reference &, oox::core::PlaceholderType)() *** CID 1486703: Control flow issues (DEADCODE) /sd/source/filter/eppt/pptx-epptooxml.cxx: 1573 in oox::core::PowerPointShapeExport::WritePlaceholderShape(const com::sun::star::uno::Reference &, oox::core::PlaceholderType)() 1567 1568 SAL_INFO("sd.eppt", "write placeholder " << pType); 1569 if (bUsePlaceholderIndex) 1570 { 1571 if ((mePageType == PageType::LAYOUT || mePageType == PageType::NORMAL) 1572 && ePlaceholder == Outliner) >>> CID 1486703: Control flow issues (DEADCODE) >>> Execution cannot reach the expression >>> "this->mpFS->singleElementNS(3808, 3974, oox::XML_idx, >>> rtl::OStringNumber(rtl::OString::number(static_cast>> *>(this->GetFB())->CreateNewPlaceholderIndex(xShape), 10)))" inside this >>> statement: "this->mpFS->singleElementNS...". 1573 mpFS->singleElementNS( 1574 XML_p, XML_ph, XML_idx, 1575 OString::number( 1576 static_cast(GetFB())->CreateNewPlaceholderIndex(xShape))); 1577 else 1578 mpFS->singleElementNS( ** CID 1486702: Error handling issues (UNCAUGHT_EXCEPT) /vcl/jsdialog/jsdialogbuilder.cxx: 243 in JSDialogSender::~JSDialogSender()() *** CID 1486702: Error handling issues (UNCAUGHT_EXCEPT) /vcl/jsdialog/jsdialogbuilder.cxx: 243 in JSDialogSender::~JSDialogSender()() 237 238 clearQueue(); 239 } 240 241 void JSDialogNotifyIdle::clearQueue() { m_aMessageQueue.clear(); } 242 >>> CID 1486702: Error handling issues (UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 243 JSDialogSender::~JSDialogSender() 244 { 245 sendClose(); 246 mpIdleNotify->Stop(); 247 } 248 To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DAg6w_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi4-2BrCDaMf6oml1NLpwRWtmgiBjuJ0TAyK8RbkHGPqD-2F-2B-2BSNNYBDioMdGyHad0HCSlr78LmKdJKFlzBbbdgjaWxRNMUI-2Fc4mQwK8T50-2FljZEFymEKTxb-2BVtmcQK7zHlIrVIxwxc4l5KkLqHRnjwEYpUMK-2FGx9npReHaZHb23O-2Bi7s-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1486528: Error handling issues (UNCAUGHT_EXCEPT) /svx/source/table/cell.cxx: 426 in sdr::table::Cell::~Cell()() *** CID 1486528: Error handling issues (UNCAUGHT_EXCEPT) /svx/source/table/cell.cxx: 426 in sdr::table::Cell::~Cell()() 420 { 421 SetEditSource(new SvxTextEditSource((), this)); 422 } 423 } 424 425 >>> CID 1486528: Error handling issues (UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 426 Cell::~Cell() noexcept 427 { 428 dispose(); 429 } 430 431 To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dqixo_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiU5uUHdFoUFd8OHvmB3xMavBth6L-2B0n44ewRaYR6k44vskUMZFFcX2u7mD5uSgq5QkyNMe4ckyen2WSk9f4VzGBA48rBAy4u17bZjazLjaB6AuG0TAdS6hXczNrjyXqtXSinPMWpyzJVe3eUUQIGTvW6lpGbh-2BMk6YI9CuAr4ic8-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1486261: Null pointer dereferences (REVERSE_INULL) /sw/source/core/layout/pagechg.cxx: 2089 in lcl_MoveAllLowers(SwFrame *, const Point &)() *** CID 1486261: Null pointer dereferences (REVERSE_INULL) /sw/source/core/layout/pagechg.cxx: 2089 in lcl_MoveAllLowers(SwFrame *, const Point &)() 2083 } 2084 2085 // the move any objects 2086 lcl_MoveAllLowerObjs( pFrame, rOffset ); 2087 2088 // finally, for layout frames we have to call this function recursively: >>> CID 1486261: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "pFrame" suggests that it may be null, but it has already >>> been dereferenced on all paths leading to the check. 2089 if ( pFrame && pFrame->IsLayoutFrame() ) 2090 { 2091 SwFrame* pLowerFrame = pFrame->GetLower(); 2092 while ( pLowerFrame ) 2093 { 2094 lcl_MoveAllLowers( pLowerFrame, rOffset ); ** CID 1486260:(UNCAUGHT_EXCEPT) /sw/source/core/doc/list.cxx: 57 in SwList::~SwList()() /sw/source/core/doc/list.cxx: 57 in SwList::~SwList()() *** CID 1486260:(UNCAUGHT_EXCEPT) /sw/source/core/doc/list.cxx: 57 in SwList::~SwList()() 51 pNode = rNodes[nIndex]; 52 } 53 } 54 while ( pNode != () ); 55 } 56 >>> CID 1486260:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 57 SwList::~SwList() COVERITY_NOEXCEPT_FALSE 58 { 59 for ( auto& rNumberTree : maListTrees ) 60 { 61 SwNodeNum::HandleNumberTreeRootNodeDelete(*(rNumberTree.pRoot)); 62 SwNodeNum::HandleNumberTreeRootNodeDelete(*(rNumberTree.pRootRLHidden)); /sw/source/core/doc/list.cxx: 57 in SwList::~SwList()() 51 pNode = rNodes[nIndex]; 52 } 53 } 54 while ( pNode != () ); 55 } 56 >>> CID 1486260:(UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 57 SwList::~SwList() COVERITY_NOEXCEPT_FALSE 58 { 59 for ( auto& rNumberTree : maListTrees ) 60 { 61 SwNodeNum::HandleNumberTreeRootNodeDelete(*(rNumberTree.pRoot)); 62 SwNodeNum::HandleNumberTreeRootNodeDelete(*(rNumberTree.pRootRLHidden)); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DUoF1_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiH8VVagCickaLrfggGJ5ZO3LVWZS61J9-2FwVd4J1LvS8iqJd5k8yiVWhLJ4wTnmMHM-2BPvhIVFL3Xk31spNDtwCQBGIdccsrGw-2Bp-2Fygxpn5w5ZChkTaCuNK3bo8hkDvU-2B3lxAJVQIJWLyRe07tFSep65eIdOsqGSKabtluX1DD6A-2B0N8OScDLJQJUz4gH78UHOX ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 3 new defect(s) introduced to LibreOffice found with Coverity Scan. 5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1486243: Possible Control flow issues (DEADCODE) /vcl/source/control/roadmapwizard.cxx: 329 in vcl::RoadmapWizard::implUpdateRoadmap()() *** CID 1486243: Possible Control flow issues (DEADCODE) /vcl/source/control/roadmapwizard.cxx: 329 in vcl::RoadmapWizard::implUpdateRoadmap()() 323 bool bCurrentPageCanAdvance = true; 324 TabPage* pCurrentPage = GetPage( getCurrentState() ); 325 if ( pCurrentPage ) 326 { 327 const IWizardPageController* pController = nullptr; 328 OSL_ENSURE( pController != nullptr, "RoadmapWizard::implUpdateRoadmap: no controller for the current page!" ); >>> CID 1486243: Possible Control flow issues (DEADCODE) >>> Execution cannot reach the expression "pController->canAdvance()" >>> inside this statement: "bCurrentPageCanAdvance = !p...". 329 bCurrentPageCanAdvance = !pController || pController->canAdvance(); 330 } 331 332 // now, we have to remove all items after nCurrentStatePathIndex, and insert the items from the active 333 // path, up to (excluding) nUpperStepBoundary 334 RoadmapTypes::ItemIndex nLoopUntil = ::std::max( nUpperStepBoundary, m_xRoadmapImpl->pRoadmap->GetItemCount() ); ** CID 1486242: Control flow issues (DEADCODE) /vcl/source/control/roadmapwizard.cxx: 383 in vcl::RoadmapWizard::implUpdateRoadmap()() *** CID 1486242: Control flow issues (DEADCODE) /vcl/source/control/roadmapwizard.cxx: 383 in vcl::RoadmapWizard::implUpdateRoadmap()() 377 } 378 379 // if the item is *after* the current state, but the current page does not 380 // allow advancing, the disable the state. This relieves derived classes 381 // from disabling all future states just because the current state does not 382 // (yet) allow advancing. >>> CID 1486242: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "nItemIndex > >>> nCurrentStatePathIndex" inside this statement: "bUnconditionedDisable = >>> !bC...". 383 const bool bUnconditionedDisable = !bCurrentPageCanAdvance && ( nItemIndex > nCurrentStatePathIndex ); 384 const bool bEnable = !bUnconditionedDisable && ( m_xRoadmapImpl->aDisabledStates.find( nState ) == m_xRoadmapImpl->aDisabledStates.end() ); 385 386 m_xRoadmapImpl->pRoadmap->EnableRoadmapItem( m_xRoadmapImpl->pRoadmap->GetItemID( nItemIndex ), bEnable ); 387 } 388 ** CID 1486241: Possible Control flow issues (DEADCODE) /vcl/source/control/wizardmachine.cxx: 685 in vcl::RoadmapWizard::prepareLeaveCurrentState(vcl::WizardTypes::CommitPageReason)() *** CID 1486241: Possible Control flow issues (DEADCODE) /vcl/source/control/wizardmachine.cxx: 685 in vcl::RoadmapWizard::prepareLeaveCurrentState(vcl::WizardTypes::CommitPageReason)() 679 Finish( RET_OK ); 680 } 681 682 bool RoadmapWizard::prepareLeaveCurrentState( WizardTypes::CommitPageReason _eReason ) 683 { 684 IWizardPageController* pController = nullptr; >>> CID 1486241: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: ";". 685 ENSURE_OR_RETURN( pController != nullptr, "RoadmapWizard::prepareLeaveCurrentState: no controller for the current page!", true ); 686 return pController->commitPage( _eReason ); 687 } 688 689 bool RoadmapWizard::skipBackwardUntil( WizardTypes::WizardState _nTargetState ) 690 { To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DS5q9_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJim8PyfXycapxDXKkv-2FYbqdUCZuJo4WvfZLjKh5S74XJJqYS1AWII3eA-2BRV265tB-2BVgeVH74yEEzj7AXfFbww9lfT-2BykLPw1h-2FNj-2BLxXYV4YIkKwhHgJOHys-2B8YBbMPaDmFu03dgKq1m7tr9x-2Bpx4AlKrM6hwZx1npCtQvm7rkR0E-3D ___ LibreOffice mailing list
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 5 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1486008: Null pointer dereferences (FORWARD_NULL) /sccomp/source/solver/SwarmSolver.cxx: 254 in ::SwarmSolver::getPropertyDescription(const rtl::OUString &)() *** CID 1486008: Null pointer dereferences (FORWARD_NULL) /sccomp/source/solver/SwarmSolver.cxx: 254 in ::SwarmSolver::getPropertyDescription(const rtl::OUString &)() 248 case PROP_ALGORITHM: 249 pResId = RID_PROPERTY_ALGORITHM; 250 break; 251 default: 252 break; 253 } >>> CID 1486008: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pResId" to "basic_string_view", which >>> dereferences it. (The dereference is assumed on the basis of the "nonnull" >>> parameter attribute.) 254 return SwarmSolver::getResourceString(pResId); 255 } 256 257 // XServiceInfo 258 virtual OUString SAL_CALL getImplementationName() override 259 { ** CID 1486007: Memory - illegal accesses (USE_AFTER_FREE) *** CID 1486007: Memory - illegal accesses (USE_AFTER_FREE) /sw/source/core/layout/ftnfrm.cxx: 1979 in SwFootnoteBossFrame::MoveFootnotes_(std::vector> &, bool)() 1973 const sal_uInt16 nRefCol = lcl_ColumnNum( this ); 1974 if( nRefNum < nMyNum || ( nRefNum == nMyNum && nRefCol <= nMyCol ) ) 1975 pRefBoss = this; 1976 } 1977 pRefBoss->InsertFootnote( pFootnote ); 1978 >>> CID 1486007: Memory - illegal accesses (USE_AFTER_FREE) >>> Calling "GetUpper" dereferences freed pointer "pFootnote". 1979 if ( pFootnote->GetUpper() ) // robust, e.g. with duplicates 1980 { 1981 // First condense the content so that footnote frames that do not fit on the page 1982 // do not do too much harm (Loop 66312). So, the footnote content first grows as 1983 // soon as the content gets formatted and it is sure that it fits on the page. 1984 SwFrame *pCnt = pFootnote->ContainsAny(); ** CID 1486006: Null pointer dereferences (FORWARD_NULL) *** CID 1486006: Null pointer dereferences (FORWARD_NULL) /sw/source/uibase/uno/unoatxt.cxx: 500 in SwXAutoTextGroup::getByIndex(int)() 494 std::unique_ptr pGlosGroup(pGlossaries ? pGlossaries->GetGroupDoc(m_sGroupName) : nullptr); 495 if (!pGlosGroup || pGlosGroup->GetError()) 496 throw uno::RuntimeException(); 497 const sal_uInt16 nCount = pGlosGroup->GetCount(); 498 if (nIndex < 0 || nIndex >= static_cast(nCount)) 499 throw lang::IndexOutOfBoundsException(); >>> CID 1486006: Null pointer dereferences (FORWARD_NULL) >>> "getByName" dereferences null "this->pGlossaries". 500 return getByName(pGlosGroup->GetShortName(o3tl::narrowing(nIndex))); 501 } 502 503 uno::Type SwXAutoTextGroup::getElementType() 504 { 505 return cppu::UnoType::get(); ** CID 1486005: Uninitialized members (UNINIT_CTOR) /oox/source/drawingml/textliststyle.cxx: 41 in oox::drawingml::TextListStyle::TextListStyle(const oox::drawingml::TextListStyle&)() *** CID 1486005: Uninitialized members (UNINIT_CTOR) /oox/source/drawingml/textliststyle.cxx: 41 in oox::drawingml::TextListStyle::TextListStyle(const oox::drawingml::TextListStyle&)() 35 { 36 for ( size_t i = 0; i < NUM_TEXT_LIST_STYLE_ENTRIES; i++ ) 37 { 38 maListStyle[i] = rStyle.maListStyle[i]; 39 maAggregationListStyle[i] = rStyle.maAggregationListStyle[i]; 40 } >>> CID 1486005: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "mbHasListStyleOnImport" is not initialized in >>> this constructor nor in any functions that it calls. 41 } 42 43 TextListStyle& TextListStyle::operator=(const TextListStyle& rStyle) 44 { 45 if(this != ) 46 { ** CID 1486004: Error handling issues (UNCAUGHT_EXCEPT) /usr/include/c++/9/ext/new_allocator.h: 151 in __gnu_cxx::new_allocator::destroy(T1 *)() *** CID 1486004: Error handling issues (UNCAUGHT_EXCEPT) /usr/include/c++/9/ext/new_allocator.h: 151
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1485887: Error handling issues (CHECKED_RETURN) /sc/source/filter/excel/xiescher.cxx: 743 in XclImpDrawObjBase::ConvertFillStyle(SdrObject &, const XclObjFillData &) const() *** CID 1485887: Error handling issues (CHECKED_RETURN) /sc/source/filter/excel/xiescher.cxx: 743 in XclImpDrawObjBase::ConvertFillStyle(SdrObject &, const XclObjFillData &) const() 737 aMemStrm.WriteUChar( 0xFF ).WriteUChar( 0xFF ).WriteUChar( 0xFF ); 738 aMemStrm.WriteUChar( 0x00 ).WriteUChar( 0x00 ).WriteUChar( 0x00 ); 739 for( size_t nIdx = 0; nIdx < 8; ++nIdx ) 740 aMemStrm.WriteUInt32( pnPattern[ nIdx ] ); // 32-bit little-endian 741 aMemStrm.Seek( STREAM_SEEK_TO_BEGIN ); 742 Bitmap aBitmap; >>> CID 1485887: Error handling issues (CHECKED_RETURN) >>> Calling "ReadDIB" without checking return value (as is done elsewhere 4 >>> out of 5 times). 743 ReadDIB(aBitmap, aMemStrm, false); 744 745 XOBitmap aXOBitmap(( BitmapEx(aBitmap) )); 746 aXOBitmap.Bitmap2Array(); 747 if( aXOBitmap.GetBackgroundColor() == COL_BLACK ) 748 ::std::swap( aPattColor, aBackColor ); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dqx-V_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiHo4dxdJiuo4DUbMRiVVNIMy3ZhpJofXW3JqHIOEoBahXy9aKQb6i-2FyEhSL7Y6mVJSLzce5oGnuAt4JjcnhhmnlzJ8NzX-2Bro0fniSBSU0gxk13NdumFrH-2FPtu5hx-2FZDquGWNozJBPdJTiJgvKV-2F9NwJ4-2FpbqpWB-2Fnl9UjfkyhROw-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1485166: Uninitialized variables (UNINIT) *** CID 1485166: Uninitialized variables (UNINIT) /usr/include/c++/9/bits/unique_ptr.h: 857 in std::make_unique(T2 &&...)() 851 { struct __invalid_type { }; }; 852 853 /// std::make_unique for single objects 854 template 855 inline typename _MakeUniq<_Tp>::__single_object 856 make_unique(_Args&&... __args) >>> CID 1485166: Uninitialized variables (UNINIT) >>> Using uninitialized value "->mxStartNodeIdx" when >>> calling "SvxRTFItemStackType". 857 { return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); } 858 859 /// std::make_unique for arrays of unknown bound 860 template 861 inline typename _MakeUniq<_Tp>::__array 862 make_unique(size_t __num) ** CID 1485165: Low impact quality (MISSING_MOVE_ASSIGNMENT) /include/vcl/GraphicObject.hxx: 51 in () *** CID 1485165: Low impact quality (MISSING_MOVE_ASSIGNMENT) /include/vcl/GraphicObject.hxx: 51 in () 45 } 46 47 class VirtualDevice; 48 struct GrfSimpleCacheObj; 49 struct ImplTileInfo; 50 >>> CID 1485165: Low impact quality (MISSING_MOVE_ASSIGNMENT) >>> Class "GraphicObject" may benefit from adding a move assignment >>> operator. See other events which show the copy assignment operator being >>> applied to rvalues, where a move assignment may be faster. 51 class VCL_DLLPUBLIC GraphicObject 52 { 53 friend class SdrGrafObj; 54 55 private: 56 Graphic maGraphic; To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DTygO_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi-2BTNIDddeEVJld2fWNGRUNiZ70nUjR1e3GIZHqux1ThqFvIuFjlhlwUXdnPa2g-2BRvpwcBWlUOq84XRQLwEY50L00BpLyCG8vwWFUPvdbKHxb4a3OHhQjedlgwxSnivk8QKuJCZW1boZ4-2B-2FWK0XK6ZtB-2F7YqyVgBQXyaQKnFNYgZA-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 5 new defect(s) introduced to LibreOffice found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1485154:(UNINIT) *** CID 1485154:(UNINIT) /editeng/source/rtf/svxrtf.cxx: 738 in SvxRTFParser::AttrGroupEnd()() 732 else 733 { 734 // Now it gets complicated: 735 // - all character attributes sre keep the area 736 // - all paragraph attributes to get the area 737 // up to the previous paragraph >>> CID 1485154:(UNINIT) >>> Using uninitialized value "->mxStartNodeIdx" when >>> calling "SvxRTFItemStackType". 738 std::unique_ptr pNew( 739 new SvxRTFItemStackType(*pOld, *mxInsertPosition, true)); 740 pNew->aAttrSet.SetParent( pOld->aAttrSet.GetParent() ); 741 742 // Delete all paragraph attributes from pNew 743 for( sal_uInt16 n = 0; n < (sizeof(aPardMap) / sizeof(sal_uInt16)) && /editeng/source/rtf/svxrtf.cxx: 814 in SvxRTFParser::AttrGroupEnd()() 808 { 809 // at the beginning of a paragraph? Move back one position 810 MovePos(); 811 bCrsrBack = false; 812 813 // Open a new Group. >>> CID 1485154:(UNINIT) >>> Using uninitialized value "->mxStartNodeIdx" when >>> calling "SvxRTFItemStackType". 814 std::unique_ptr pNew(new SvxRTFItemStackType( 815 *pCurrent, *mxInsertPosition, true )); 816 pNew->SetRTFDefaults( GetRTFDefaults() ); 817 818 // Set all until here valid Attributes 819 AttrGroupEnd(); ** CID 1485153: Uninitialized variables (UNINIT) *** CID 1485153: Uninitialized variables (UNINIT) /editeng/source/rtf/rtfitem.cxx: 221 in SvxRTFParser::ReadAttr(int, SfxItemSet *)() 215 break; 216 217 if (pCurrent->aAttrSet.Count() || pCurrent->m_pChildList || 218 pCurrent->nStyleNo ) 219 { 220 // Open a new Group >>> CID 1485153: Uninitialized variables (UNINIT) >>> Using uninitialized value "->mxStartNodeIdx" when >>> calling "SvxRTFItemStackType". 221 std::unique_ptr pNew(new SvxRTFItemStackType( 222 *pCurrent, *mxInsertPosition, true )); 223 pNew->SetRTFDefaults( GetRTFDefaults() ); 224 225 // "Set" all valid attributes up until this point 226 AttrGroupEnd(); ** CID 1485152:(UNINIT) *** CID 1485152:(UNINIT) /editeng/source/rtf/svxrtf.cxx: 617 in SvxRTFParser::GetAttrSet_()() 611 612 SvxRTFItemStackType* SvxRTFParser::GetAttrSet_() 613 { 614 SvxRTFItemStackType* pCurrent = aAttrStack.empty() ? nullptr : aAttrStack.back().get(); 615 std::unique_ptr pNew; 616 if( pCurrent ) >>> CID 1485152:(UNINIT) >>> Using uninitialized value "->mxStartNodeIdx" when >>> calling "SvxRTFItemStackType". 617 pNew.reset(new SvxRTFItemStackType( *pCurrent, *mxInsertPosition, false/*bCopyAttr*/ )); 618 else 619 pNew.reset(new SvxRTFItemStackType( *pAttrPool, aWhichMap.data(), 620 *mxInsertPosition )); 621 pNew->SetRTFDefaults( GetRTFDefaults() ); 622 /editeng/source/rtf/svxrtf.cxx: 619 in SvxRTFParser::GetAttrSet_()() 613 { 614 SvxRTFItemStackType* pCurrent = aAttrStack.empty() ? nullptr : aAttrStack.back().get(); 615 std::unique_ptr pNew; 616 if( pCurrent ) 617 pNew.reset(new SvxRTFItemStackType( *pCurrent, *mxInsertPosition, false/*bCopyAttr*/ )); 618 else >>> CID 1485152:(UNINIT) >>> Using uninitialized value "->mxStartNodeIdx" when >>> calling "SvxRTFItemStackType". 619 pNew.reset(new SvxRTFItemStackType( *pAttrPool, aWhichMap.data(), 620 *mxInsertPosition )); 621 pNew->SetRTFDefaults( GetRTFDefaults() ); 622 623
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1485136: Control flow issues (UNREACHABLE) /vcl/inc/unx/gtk/gtkdata.hxx: 179 in surface_get_device_position(_GdkWindow *, _GdkDevice *, double &, double &, GdkModifierType *)() *** CID 1485136: Control flow issues (UNREACHABLE) /vcl/inc/unx/gtk/gtkdata.hxx: 179 in surface_get_device_position(_GdkWindow *, _GdkDevice *, double &, double &, GdkModifierType *)() 173pMask); 174 #else 175 int nX(x), nY(y); 176 return gdk_window_get_device_position(pSurface, pDevice, 177, , 178pMask); >>> CID 1485136: Control flow issues (UNREACHABLE) >>> This code cannot be reached: "x = nX;". 179 x = nX; 180 y = nY; 181 #endif 182 } 183 184 inline GdkGLContext* surface_create_gl_context(GdkSurface* pSurface) ** CID 1476301: Null pointer dereferences (NULL_RETURNS) /starmath/source/edit.cxx: 715 in SmEditTextWindow::UpdateStatus(bool)() *** CID 1476301: Null pointer dereferences (NULL_RETURNS) /starmath/source/edit.cxx: 715 in SmEditTextWindow::UpdateStatus(bool)() 709 void SmEditTextWindow::UpdateStatus(bool bSetDocModified) 710 { 711 SmModule *pMod = SM_MOD(); 712 if (pMod && pMod->GetConfig()->IsAutoRedraw()) 713 Flush(); 714 if (bSetDocModified) >>> CID 1476301: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "nullptr" >>> "this->mrEditWindow->GetDoc()" when calling "SetModified". (The dereference >>> happens because this is a virtual function call.) 715 mrEditWindow.GetDoc()->SetModified(); 716 717 static_cast(GetEditEngine())->executeZoom(GetEditView()); 718 } 719 720 void SmEditWindow::UpdateStatus(bool bSetDocModified) To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DqfrD_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJib67kE6CcT6XwPlBxQ6WdE2CWkl74z2rbx828MAzkDpILa7GkJghj0nDEYLTJ3P5mlK6yn-2FXvzVV-2FXdvY7KvCCoIFcT7cS-2BG-2B-2BTrQGKDbxrka0FNbG0I7z3CDZ02LKYQQ3wxz3VCi8kxSaw001O9trBc15a9k7oWbNkkRp95d9wc-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1484905: Null pointer dereferences (REVERSE_INULL) /vcl/source/gdi/gdimtf.cxx: 395 in GDIMetaFile::ImplPlayWithRenderer(OutputDevice *, const Point &, Size)() *** CID 1484905: Null pointer dereferences (REVERSE_INULL) /vcl/source/gdi/gdimtf.cxx: 395 in GDIMetaFile::ImplPlayWithRenderer(OutputDevice *, const Point &, Size)() 389 { 390 if (!m_bUseCanvas) 391 return false; 392 393 Size rDestSize( pOut->LogicToPixel( rLogicDestSize ) ); 394 >>> CID 1484905: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "pOut" suggests that it may be null, but it has already >>> been dereferenced on all paths leading to the check. 395 const vcl::Window* win = pOut ? pOut->GetOwnerWindow() : nullptr; 396 397 if (!win) 398 win = Application::GetActiveTopWindow(); 399 if (!win) 400 win = Application::GetFirstTopLevelWindow(); ** CID 1484904: Null pointer dereferences (FORWARD_NULL) *** CID 1484904: Null pointer dereferences (FORWARD_NULL) /vcl/source/edit/texteng.cxx: 1926 in TextEngine::ImpPaint(OutputDevice *, const Point &, const tools::Rectangle *, const TextSelection *)() 1920 { 1921 OSL_ENSURE(pPortion->GetTextPortions().size(), 1922 "ImpPaint: Line without Textportion!"); 1923 TETextPortion* pTextPortion = pPortion->GetTextPortions()[ y ]; 1924 SAL_WARN_IF( !pTextPortion, "vcl", "ImpPaint: Bad pTextPortion!" ); 1925 >>> CID 1484904: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pOutDev" to "ImpInitLayoutMode", which >>> dereferences it. 1926 ImpInitLayoutMode( pOutDev /*, pTextPortion->IsRightToLeft() */); 1927 1928 const tools::Long nTxtWidth = pTextPortion->GetWidth(); 1929 aTmpPos.setX( rStartPos.X() + ImpGetOutputOffset( nPara, , nIndex, nIndex ) ); 1930 1931 // only print if starting in the visible region To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D2mSt_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiQw-2Fy9CCr9KLUR-2F8Zc7YciNXi8bFb71AU86a-2FRdUWWOitiEuuLtd6nzk0x7LEgVDSb8lMpsLsOdoRfiTiHaJSWFGtFaqyhEgS-2FvQk7FUVq1kpqDgLQkO8jzynyf2691yG2UIDN4vy2RooFTudQwcRc7qGO8V0xNWS8vxIM1YwdMk-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 4 new defect(s) introduced to LibreOffice found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1484879:(UNINIT_CTOR) /sw/source/uibase/inc/wrtsh.hxx: 680 in MakeAllOutlineContentTemporarilyVisible::MakeAllOutlineContentTemporarilyVisible(SwDoc *)() /sw/source/uibase/inc/wrtsh.hxx: 671 in MakeAllOutlineContentTemporarilyVisible::MakeAllOutlineContentTemporarilyVisible(SwDoc *)() *** CID 1484879:(UNINIT_CTOR) /sw/source/uibase/inc/wrtsh.hxx: 680 in MakeAllOutlineContentTemporarilyVisible::MakeAllOutlineContentTemporarilyVisible(SwDoc *)() 674 m_pWrtSh->GetViewOptions()->IsShowOutlineContentVisibilityButton()) 675 { 676 m_pWrtSh->StartAllAction(); 677 m_pWrtSh->MakeAllFoldedOutlineContentVisible(); 678 m_bDone = true; 679 } >>> CID 1484879:(UNINIT_CTOR) >>> Non-static class member "m_pWrtSh" is not initialized in this >>> constructor nor in any functions that it calls. 680 } 681 682 ~MakeAllOutlineContentTemporarilyVisible() COVERITY_NOEXCEPT_FALSE 683 { 684 --nLock; 685 if (nLock > 0) /sw/source/uibase/inc/wrtsh.hxx: 671 in MakeAllOutlineContentTemporarilyVisible::MakeAllOutlineContentTemporarilyVisible(SwDoc *)() 665 public: 666 static sal_uInt32 nLock; 667 MakeAllOutlineContentTemporarilyVisible(SwDoc* pDoc) 668 { 669 ++nLock; 670 if (nLock > 1) >>> CID 1484879:(UNINIT_CTOR) >>> Non-static class member "m_pWrtSh" is not initialized in this >>> constructor nor in any functions that it calls. 671 return; 672 if (SwDocShell* pDocSh = pDoc->GetDocShell()) 673 if ((m_pWrtSh = pDocSh->GetWrtShell()) && m_pWrtSh->GetViewOptions() && 674 m_pWrtSh->GetViewOptions()->IsShowOutlineContentVisibilityButton()) 675 { 676 m_pWrtSh->StartAllAction(); ** CID 1484878: Uninitialized members (UNINIT_CTOR) /sc/source/filter/oox/autofilterbuffer.cxx: 408 in oox::xls::ColorFilter::ColorFilter(const oox::xls::WorkbookHelper &)() *** CID 1484878: Uninitialized members (UNINIT_CTOR) /sc/source/filter/oox/autofilterbuffer.cxx: 408 in oox::xls::ColorFilter::ColorFilter(const oox::xls::WorkbookHelper &)() 402 return aSettings; 403 } 404 405 ColorFilter::ColorFilter(const WorkbookHelper& rHelper) 406 : FilterSettingsBase(rHelper) 407 { >>> CID 1484878: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "mbIsBackgroundColor" is not initialized in >>> this constructor nor in any functions that it calls. 408 } 409 410 void ColorFilter::importAttribs(sal_Int32 nElement, const AttributeList& rAttribs) 411 { 412 if (nElement == XLS_TOKEN(colorFilter)) 413 { ** CID 1484877: Null pointer dereferences (FORWARD_NULL) *** CID 1484877: Null pointer dereferences (FORWARD_NULL) /sw/source/uibase/docvw/FrameControlsManager.cxx: 212 in SwFrameControlsManager::SetOutlineContentVisibilityButton(const SwContentFrame *)() 206 m_pEditWin, pContentFrame).get()); 207 rControls.insert(lb, make_pair(pContentFrame, pNewControl)); 208 pControl.swap(pNewControl); 209 } 210 211 SwOutlineContentVisibilityWin* pWin = dynamic_cast(pControl->GetWindow()); >>> CID 1484877: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pWin" to "Set", which dereferences it. 212 pWin->Set(); 213 214 if (pWin->GetSymbol() == ButtonSymbol::SHOW) 215 pWin->Show(); // show the SHOW button immediately 216 else if (!pWin->IsVisible() && pWin->GetSymbol() == ButtonSymbol::HIDE) 217 pWin->ShowAll(true); ** CID 1465676: Error handling issues (CHECKED_RETURN) /sw/source/uibase/docvw/OutlineContentVisibilityWin.cxx: 114 in SwOutlineContentVisibilityWin::Set()() *** CID 1465676: Error handling issues (CHECKED_RETURN) /sw/source/uibase/docvw/OutlineContentVisibilityWin.cxx: 114 in SwOutlineContentVisibilityWin::Set()() 108 { 109 const SwTextFrame* pTextFrame =
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1482285: Error handling issues (UNCAUGHT_EXCEPT) /starmath/source/edit.cxx: 132 in SmEditWindow::~SmEditWindow()() *** CID 1482285: Error handling issues (UNCAUGHT_EXCEPT) /starmath/source/edit.cxx: 132 in SmEditWindow::~SmEditWindow()() 126 { 127 mxScrolledWindow->connect_vadjustment_changed(LINK(this, SmEditWindow, ScrollHdl)); 128 129 CreateEditView(rBuilder); 130 } 131 >>> CID 1482285: Error handling issues (UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 132 SmEditWindow::~SmEditWindow() 133 { 134 DeleteEditView(); 135 mxScrolledWindow.reset(); 136 } 137 To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D7fEt_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi4yQ4Db8GrcKiC5m1X6E-2B1FzIf9rW29q-2BOhido6-2FgKFfJkgPMkShFSTCSRegKyDNCJ6ssH7aYqMhmvk83G69czt5acgPICCvCN0258Rk025INEfnWaf8AEFThy5a3sKsdIkIWqBrEvRo1QL8UKE5H1TfUuj67UbHQM0806CTS1R0-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1482086: Memory - corruptions (USE_AFTER_FREE) /vcl/source/bitmap/BitmapMosaicFilter.cxx: 163 in BitmapMosaicFilter::execute(const BitmapEx &) const() *** CID 1482086: Memory - corruptions (USE_AFTER_FREE) /vcl/source/bitmap/BitmapMosaicFilter.cxx: 163 in BitmapMosaicFilter::execute(const BitmapEx &) const() 157 } 158 159 Bitmap::ReleaseAccess(pReadAcc); 160 161 if (pNewBmp) 162 { >>> CID 1482086: Memory - corruptions (USE_AFTER_FREE) >>> Calling "ReleaseAccess" frees pointer "pWriteAcc" which has already >>> been freed. 163 Bitmap::ReleaseAccess(pWriteAcc); 164 165 if (bRet) 166 { 167 const MapMode aMap(aBitmap.GetPrefMapMode()); 168 const Size aPrefSize(aBitmap.GetPrefSize()); ** CID 1482085: Uninitialized members (UNINIT_CTOR) /sc/source/ui/cctrl/checklistmenu.cxx: 431 in ScCheckListMember::ScCheckListMember()() *** CID 1482085: Uninitialized members (UNINIT_CTOR) /sc/source/ui/cctrl/checklistmenu.cxx: 431 in ScCheckListMember::ScCheckListMember()() 425 , mbDate(false) 426 , mbLeaf(false) 427 , mbValue(false) 428 , mbDuplicated(false) 429 , meDatePartType(YEAR) 430 { >>> CID 1482085: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "mnValue" is not initialized in this >>> constructor nor in any functions that it calls. 431 } 432 433 ScCheckListMenuControl::ScCheckListMenuControl(ScCheckListMenuWindow* pParent, vcl::Window* pContainer, 434ScDocument* pDoc, bool bCanHaveSubMenu, 435bool bHasDates, int nWidth) 436 : mxFrame(pParent) To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DCs-I_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJixKAUgOV-2FUxxk9dw6d52OEqc4IFDnK42z8ZeWF2-2BePQO5hZLRDeWpjlguwC9vfk3zYmPfLit256oKVW0DZqIMvRUZaTbjC-2FDjoo0Sl5KpHuCaw4Rktg5nrYmow-2FhymlXJGws-2FjgV1U5cuOaZ5-2BRb6-2FSQJEOHF9TDH2lIE9AcUWXg-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1478174: Uninitialized members (UNINIT_CTOR) /sw/source/core/text/porfly.cxx: 276 in SwFlyCntPortion::SwFlyCntPortion()() *** CID 1478174: Uninitialized members (UNINIT_CTOR) /sw/source/core/text/porfly.cxx: 276 in SwFlyCntPortion::SwFlyCntPortion()() 270 SwFlyCntPortion::SwFlyCntPortion() 271 : m_bMax(false) 272 , m_eAlign(sw::LineAlign::NONE) 273 { 274 mnLineLength = TextFrameIndex(1); 275 SetWhichPor(PortionType::FlyCnt); >>> CID 1478174: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "m_bDeleted" is not initialized in this >>> constructor nor in any functions that it calls. 276 } 277 278 sw::FlyContentPortion::FlyContentPortion(SwFlyInContentFrame* pFly) 279 : m_pFly(pFly) 280 { 281 SAL_WARN_IF(!pFly, "sw.core", "SwFlyCntPortion::SwFlyCntPortion: no SwFlyInContentFrame!"); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D2kdw_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiX0b8YxoFjteg-2F-2FmTZIAsij3q9J6JUExUvTc5blUKLLJwjK-2FL6g5e8XxCw9jCbGSrBLzyPSPA58cFvpfeDusA28Jg96uZONCKZcDcGKyHOH-2FBhaVPtEKG8LS5atkWrRlb4lRzdQO1GwJw6KkRtF8zb9jJ6mqMytqrw08iml30EKH7gz4Bw7v2-2BPpknRZt-2Bs9k ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1478001: Null pointer dereferences (REVERSE_INULL) /vcl/unx/generic/gdi/salvd.cxx: 130 in X11SalVirtualDevice::X11SalVirtualDevice(const SalGraphics *, long &, long &, DeviceFormat, const SystemGraphicsData *, std::unique_ptr>)() *** CID 1478001: Null pointer dereferences (REVERSE_INULL) /vcl/unx/generic/gdi/salvd.cxx: 130 in X11SalVirtualDevice::X11SalVirtualDevice(const SalGraphics *, long &, long &, DeviceFormat, const SystemGraphicsData *, std::unique_ptr>)() 124 bExternPixmap_ = true; 125 } 126 else 127 { 128 nDX_ = nDX; 129 nDY_ = nDY; >>> CID 1478001: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "pGraphics" suggests that it may be null, but it has >>> already been dereferenced on all paths leading to the check. 130 m_nXScreen = pGraphics ? static_cast(pGraphics)->GetScreenNumber() : 131 vcl_sal::getSalDisplay(GetGenericUnixSalData())->GetDefaultXScreen(); 132 hDrawable_ = limitXCreatePixmap( GetXDisplay(), 133 pDisplay_->GetDrawable( m_nXScreen ), 134 nDX_, nDY_, 135 GetDepth() ); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dv0j9_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiR9y3GSOtackX7-2FbTMWD53A1TjnpzgoighLs7brjfqYXwDAz8HCw7-2BObBObXVrXvvMVALA1qzXXBJ-2FcCzQZ-2FkTx9Cohnbie4C5Z5NmGiLT6u01pSdpvDP2B3a1lZZbHpgQjEmQ21iB55owHL5tusebfQ0fZFXUOJfiJJVGz-2Bx0XQ-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1477405:(UNINIT_CTOR) /include/comphelper/profilezone.hxx: 70 in comphelper::ProfileZone::ProfileZone(const char *, bool)() /include/comphelper/profilezone.hxx: 70 in comphelper::ProfileZone::ProfileZone(const char *, bool)() *** CID 1477405:(UNINIT_CTOR) /include/comphelper/profilezone.hxx: 70 in comphelper::ProfileZone::ProfileZone(const char *, bool)() 64 m_nPid = aProcessInfo.Ident; 65 66 m_nNesting = s_nNesting++; 67 } 68 else 69 m_nCreateTime = 0; >>> CID 1477405:(UNINIT_CTOR) >>> Non-static class member "m_nNesting" is not initialized in this >>> constructor nor in any functions that it calls. 70 } 71 72 ~ProfileZone() 73 { 74 if (m_nCreateTime > 0) 75 { /include/comphelper/profilezone.hxx: 70 in comphelper::ProfileZone::ProfileZone(const char *, bool)() 64 m_nPid = aProcessInfo.Ident; 65 66 m_nNesting = s_nNesting++; 67 } 68 else 69 m_nCreateTime = 0; >>> CID 1477405:(UNINIT_CTOR) >>> Non-static class member "m_nPid" is not initialized in this constructor >>> nor in any functions that it calls. 70 } 71 72 ~ProfileZone() 73 { 74 if (m_nCreateTime > 0) 75 { To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D5e58_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiKCz3e-2FtK20eEWgyPgjEFG-2F2HWxv3tQNI11acMDT7c5MwRLItI-2FlDHwr2NPHLf7sO0EWhgk0AGUrANs7L8n3AMmxXVBdIL7SFsOOsFqgIznC4ga-2B4TWIx-2FE-2FcAUztegnV2d8pg0Nzy-2BKHs5hmm8iS8L3HmM3WoIF5bAVuPVvGDp0-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1477317: Control flow issues (DEADCODE) /sc/source/core/data/document.cxx: 2388 in ScDocument::TransposeClip(ScDocument*, InsertDeleteFlags, bool, bool)() *** CID 1477317: Control flow issues (DEADCODE) /sc/source/core/data/document.cxx: 2388 in ScDocument::TransposeClip(ScDocument*, InsertDeleteFlags, bool, bool)() 2382 nRowOffset = nRowCount; 2383 2384 // calculate filtered rows of current clip range 2385 SCROW nRowCountAll = aClipRange.aEnd.Row() - aClipRange.aStart.Row() + 1; 2386 SCROW nRowCountNonFiltered = CountNonFilteredRows( 2387 aClipRange.aStart.Row(), aClipRange.aEnd.Row(), aClipRange.aStart.Tab()); >>> CID 1477317: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "nRowCountAll" inside this >>> statement: "nRowCountInRange = (bInclud...". 2388 SCROW nRowCountInRange = bIncludeFiltered ? nRowCountAll : nRowCountNonFiltered; 2389 nRowCount += nRowCountInRange; // for next iteration 2390 } 2391 2392 for (SCTAB i = 0; i < static_cast(maTabs.size()); i++) 2393 { ** CID 1477316: Uninitialized members (UNINIT_CTOR) /starmath/source/view.cxx: 286 in SmGraphicWidget::SmGraphicWidget(SmViewShell &, SmGraphicWindow &)() *** CID 1477316: Uninitialized members (UNINIT_CTOR) /starmath/source/view.cxx: 286 in SmGraphicWidget::SmGraphicWidget(SmViewShell &, SmGraphicWindow &)() 280 } 281 282 SmGraphicWidget::SmGraphicWidget(SmViewShell& rShell, SmGraphicWindow& rGraphicWindow) 283 : mrGraphicWindow(rGraphicWindow) 284 , mrViewShell(rShell) 285 { >>> CID 1477316: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "bIsLineVisible" is not initialized in this >>> constructor nor in any functions that it calls. 286 } 287 288 void SmGraphicWidget::SetDrawingArea(weld::DrawingArea* pDrawingArea) 289 { 290 weld::CustomWidgetController::SetDrawingArea(pDrawingArea); 291 To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DMJ_O_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJirF5WJ5Rv8fYtA3CBQtSElo00iVD0BsC1YmSEzIXzL7nRUmUe9Q-2FzIGjEmRelyAyTIckH-2BJR7yPaiw6hXW8aSRvHwnQ8KWhf2yOksLq3kOo8liHLF0EdQRM-2FRhCjIGpKk050d1WJXuAESUsWU-2BoRYVytNqzddHexPM9kdLvq3-2FCI-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1476301: Null pointer dereferences (NULL_RETURNS) /starmath/source/edit.cxx: 788 in SmEditTextWindow::UpdateStatus(bool)() *** CID 1476301: Null pointer dereferences (NULL_RETURNS) /starmath/source/edit.cxx: 788 in SmEditTextWindow::UpdateStatus(bool)() 782 void SmEditTextWindow::UpdateStatus(bool bSetDocModified) 783 { 784 SmModule *pMod = SM_MOD(); 785 if (pMod && pMod->GetConfig()->IsAutoRedraw()) 786 Flush(); 787 if ( bSetDocModified ) >>> CID 1476301: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "nullptr" >>> "this->mrEditWindow->GetDoc()" when calling "SetModified". (The dereference >>> happens because this is a virtual function call.) 788 mrEditWindow.GetDoc()->SetModified(); 789 } 790 791 void SmEditWindow::Cut() 792 { 793 if (mxTextControl) ** CID 1476300: Null pointer dereferences (FORWARD_NULL) *** CID 1476300: Null pointer dereferences (FORWARD_NULL) /svx/source/svdraw/svdmrkv.cxx: 811 in SdrMarkView::SetMarkHandlesForLOKit(const tools::Rectangle &, const SfxViewShell *)() 805 { 806 auto& rTableObject = dynamic_cast(*mpMarkedObj); 807 bTableSelection = rTableObject.createTableEdgesJson(aTableJsonTree); 808 } 809 if (mpMarkedObj && mpMarkedObj->GetObjIdentifier() == OBJ_EDGE) 810 { >>> CID 1476300: Null pointer dereferences (FORWARD_NULL) >>> "dumpGluePointsToJSON" dereferences null "this->mpMarkedPV". 811 bConnectorSelection = dumpGluePointsToJSON(aGluePointsTree); 812 } 813 if (GetMarkedObjectCount()) 814 { 815 SdrMark* pM = GetSdrMarkByIndex(0); 816 SdrObject* pO = pM->GetMarkedSdrObj(); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D16Ot_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJibfe-2BvtHAh-2B0LdXsIiymWiwf7NZfOvl4Jf4NBG1zXR0MCAtIcjxoQwls228ENf40eDr8jb7flAePvfBMk95IqPnfUm7a8xORdjsUBt7zSuPWFygD-2FeYoX9cayGfl174obYpxMOxW-2Ffw1o2bneJYv04gF0VXTtWk-2Baw6-2Bk0p1-2FIC0-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1476278: Null pointer dereferences (NULL_RETURNS) /sw/source/core/unocore/unosrch.cxx: 154 in SwSearchProperties_Impl::FillItemSet(SfxItemSet &, bool) const() *** CID 1476278: Null pointer dereferences (NULL_RETURNS) /sw/source/core/unocore/unosrch.cxx: 154 in SwSearchProperties_Impl::FillItemSet(SfxItemSet &, bool) const() 148 return rpPoolItem.get(); 149 }; 150 for(auto const & rPair : maValues) 151 { 152 SfxPoolItem* pTempItem = nullptr; 153 const SfxItemPropertyMapEntry & rPropEntry = *mrMap.getByName(rPair.first); >>> CID 1476278: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "rPropEntry", which is known to be "nullptr". 154 sal_uInt16 nWID = rPropEntry.nWID; 155 switch(nWID) 156 { 157 case RES_BOX: 158 pTempItem = funcClone(nWID, pBoxItem); 159 break; To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DGiq1_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJikYNyCJ-2BS6a2rTmR05VQRAcSSwnloROgUVYt5V1TqpYtV8gnWFUSt5jHoHgVacwHyCjEBqyZ6CZxLUIrxLTd-2BQp-2BglT-2ByF-2FHgVuxUZQHDOLQDJscE08Qquy2TMz-2BJLYGqYgwtvAaWex194TFHtUV9srFzy5C78zrpEyP4MdTsEyc-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1476017: Null pointer dereferences (FORWARD_NULL) /sw/source/filter/ww8/ww8graf.cxx: 3184 in SwWW8ImplReader::ImportReplaceableDrawables(SdrObject *&, SdrObject *&, SvxMSDffImportRec *, WW8_FSPA *, SfxItemSet &)() *** CID 1476017: Null pointer dereferences (FORWARD_NULL) /sw/source/filter/ww8/ww8graf.cxx: 3184 in SwWW8ImplReader::ImportReplaceableDrawables(SdrObject *&, SdrObject *&, SvxMSDffImportRec *, WW8_FSPA *, SfxItemSet &)() 3178 3179 // The Contact-Object MUST be set in the Draw-Page, so that in 3180 // SwWW8ImplReader::LoadDoc1() the Z-Order can be defined !!! 3181 if (!rpOurNewObject->IsInserted()) 3182 { 3183 // pass information, if object is in page header|footer to method. >>> CID 1476017: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "pRecord". 3184 m_xWWZOrder->InsertEscherObject( rpOurNewObject, pF->nSpId, 3185 pRecord->bDrawHell, 3186m_bIsHeader || m_bIsFooter ); 3187 } 3188 } 3189 return pRetFrameFormat; To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dy11g_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJif8N2SJEHhv0bMQhpeR8UhVB2jO-2FUi76ubiA1nF2wC8c1yThMWDwCjXvwt-2BMvQAIs0IoGF-2Fslum7F-2BjbIrG87EFrGZBPunO-2BftA3OyE2wlfivS6S679DTXqUvgfTJSDmQY65W4QRpsDykHMMyoZBgfU1rrEgJ0iwn-2Bb4IEYsKb48-3D ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 9 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1475942: Uninitialized members (UNINIT_CTOR) /usr/include/c++/9/bits/random.h: 2010 in std::normal_distribution::normal_distribution()() *** CID 1475942: Uninitialized members (UNINIT_CTOR) /usr/include/c++/9/bits/random.h: 2010 in std::normal_distribution::normal_distribution()() 2004 private: 2005_RealType _M_mean; 2006_RealType _M_stddev; 2007 }; 2008 2009 public: >>> CID 1475942: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "_M_saved" is not initialized in this >>> constructor nor in any functions that it calls. 2010 normal_distribution() : normal_distribution(0.0) { } 2011 2012 /** 2013* Constructs a normal distribution with parameters @f$mean@f$ and 2014* standard deviation. 2015*/ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dvawy_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJirGcAK3-2BSLUV8I6LPverxknJjgb3GwfHrZPbO0ow86ZcEOpRDJiyxSOB3BsxkIJ3R1J6c-2FR4hr1BWcMqOPTd1vjsYBtkCR7MpMeJB3YlnER-2F29S1DyegRNNEGX9gILMqg9099tt9Y4habW2v9z9ePvoX6PVf2X7woOV1af2YD66kPxnp4gnlGMiCmHGbZyqxZ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1475790: Uninitialized members (UNINIT_CTOR) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 1233 in OOXMLSecParser::OOXMLSecParser(XMLSignatureHelper &, XSecController *)() *** CID 1475790: Uninitialized members (UNINIT_CTOR) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 1233 in OOXMLSecParser::OOXMLSecParser(XMLSignatureHelper &, XSecController *)() 1227 m_pNamespaceMap->Add( "_xades141", GetXMLToken(XML_N_XADES141), XML_NAMESPACE_XADES141); 1228 m_pNamespaceMap->Add( "_dc", GetXMLToken(XML_N_DC), XML_NAMESPACE_DC ); 1229 m_pNamespaceMap->Add( "_mdssi", NS_MDSSI, XML_NAMESPACE_MDSSI ); 1230 m_pNamespaceMap->Add( "_msodigsig", "https://u15810271.ct.sendgrid.net/ls/click?upn=CTPegkVN6peWFCMEieYYmP0gNmCf-2F3lRFYfEYs-2FkkMtEyQbkFGXZMXeiICvzk-2FTk3-2BhimIEEW-2BdrRMTAOxQv9g-3D-3DXJ3h_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJirI2hX6CSUeZ-2FSJLhCmNkNfcy-2BUC8luzQDzifxa2JlvcswBp7OcW14xrwDQICmecV-2BxYVlvJT8vz1RUSNFA0P1nV2X6G5etrym8tDAU6r3sRR-2FFQZAaayM1Rn4fNsCCJ-2BXUaOTlvxXEDxrziGva1W2sswtquhxLBfOQceMIGXcMTv4G6VX0OrPRiFqndJVAGp XML_NAMESPACE_MSODIGSIG ); 1231 m_pNamespaceMap->Add( "_office_libo", 1232 GetXMLToken(XML_N_LO_EXT), XML_NAMESPACE_LO_EXT); >>> CID 1475790: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "m_bReferenceUnresolved" is not initialized in >>> this constructor nor in any functions that it calls. 1233 } 1234 1235 OOXMLSecParser::~OOXMLSecParser() 1236 { 1237 } 1238 To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DOMMc_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJirI2hX6CSUeZ-2FSJLhCmNkNWhZYrut-2BYrGIOgVjhaGkr2mlylZCJGLCzf2m6P3tvVYN9kZSRlY2a2szPI-2Bpba3RsnJi-2FYmhOIT4RUOj1lAhkbDXcLNWwF4Q5Nzt3c0TixP0kJHqxcvrlUYkyU4F8WIF-2B-2BBh-2BZceXDVctFfMULPB1SMKbF68NkDXI0E3QiUXZ7U ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 4 new defect(s) introduced to LibreOffice found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1474353: Insecure data handling (TAINTED_SCALAR) *** CID 1474353: Insecure data handling (TAINTED_SCALAR) /sw/source/filter/ww8/ww8toolbar.cxx: 402 in SwCTB::Read(SvStream &)() 396 { 397 SAL_INFO("sw.ww8","SwCTB::Read() stream pos 0x" << std::hex << rS.Tell() ); 398 nOffSet = rS.Tell(); 399 if ( !name.Read( rS ) ) 400 return false; 401 rS.ReadInt32( cbTBData ); >>> CID 1474353: Insecure data handling (TAINTED_SCALAR) >>> Passing tainted expression "*rS.m_pBufPos" to "Read", which uses it as >>> a loop boundary. 402 if ( !tb.Read( rS ) ) 403 return false; 404 for ( short index = 0; index < nVisualData; ++index ) 405 { 406 TBVisualData aVisData; 407 aVisData.Read( rS ); ** CID 1473931: Insecure data handling (TAINTED_SCALAR) /sw/source/filter/ww8/ww8par2.cxx: 3729 in WW8RStyle::WW8RStyle(WW8Fib &, SwWW8ImplReader *)() *** CID 1473931: Insecure data handling (TAINTED_SCALAR) /sw/source/filter/ww8/ww8par2.cxx: 3729 in WW8RStyle::WW8RStyle(WW8Fib &, SwWW8ImplReader *)() 3723 , mbCTLFontChanged(false) 3724 , mbFSizeChanged(false) 3725 , mbFCTLSizeChanged(false) 3726 , mbWidowsChanged(false) 3727 , mbBidiChanged(false) 3728 { >>> CID 1473931: Insecure data handling (TAINTED_SCALAR) >>> Passing tainted expression "this->m_cstd" to "resize", which uses it as >>> an allocation size. [Note: The source code implementation of the function >>> has been overridden by a builtin model.] 3729 mpIo->m_vColl.resize(m_cstd); 3730 } 3731 3732 void WW8RStyle::Set1StyleDefaults() 3733 { 3734 // see #i25247#, #i25561#, #i48064#, #i92341# for default font ** CID 1473756: Insecure data handling (TAINTED_SCALAR) *** CID 1473756: Insecure data handling (TAINTED_SCALAR) /sw/source/filter/ww8/ww8par.cxx: 465 in ::Sttb::Read(SvStream &)() 459 if (cData > nMaxPossibleRecords) 460 return false; 461 for ( sal_Int32 index = 0; index < cData; ++index ) 462 { 463 SBBItem aItem; 464 rS.ReadUInt16( aItem.cchData ); >>> CID 1473756: Insecure data handling (TAINTED_SCALAR) >>> Passing tainted expression "aItem.cchData" to >>> "read_uInt16s_ToOUString", which uses it as a loop boundary. 465 aItem.data = read_uInt16s_ToOUString(rS, aItem.cchData); 466 dataItems.push_back( aItem ); 467 } 468 } 469 return true; 470 } ** CID 1473755: Insecure data handling (TAINTED_SCALAR) *** CID 1473755: Insecure data handling (TAINTED_SCALAR) /include/tools/stream.hxx: 461 in read_uInt16_lenPrefixed_uInt16s_ToOUString(SvStream &)() 455 /// 16bit units to an OUString, returned OString's length is number of 456 /// units successfully read. 457 inline OUString read_uInt16_lenPrefixed_uInt16s_ToOUString(SvStream& rStrm) 458 { 459 sal_uInt16 nUnits = 0; 460 rStrm.ReadUInt16( nUnits ); >>> CID 1473755: Insecure data handling (TAINTED_SCALAR) >>> Passing tainted expression "nUnits" to "read_uInt16s_ToOUString", which >>> uses it as a loop boundary. 461 return read_uInt16s_ToOUString(rStrm, nUnits); 462 } 463 464 inline OUString read_uInt32_lenPrefixed_uInt16s_ToOUString(SvStream& rStrm) 465 { 466 sal_uInt32 nUnits = 0; To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DFI7K_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJik17NuiXcVoG1L0tp4qZ2gRTVf9k01t5mvsMixKsv03o3hjPJcjpVYaIOlB3xjEXyoXlpX3-2FMV9DjGHEoSSufOiaYDrSR-2BxSa-2FR8Tp4R-2BaVdr-2F3a76Cl6hU2uWNFSg-2FAsACWogQ-2BoIOoea6Nco6vAGcYCvFDEYc9YyqjGCzcdrKoIx4GBZCl-2FW9Lwznq7YpJz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1474452: Null pointer dereferences (FORWARD_NULL) *** CID 1474452: Null pointer dereferences (FORWARD_NULL) /sw/source/core/text/itrcrsr.cxx: 1564 in SwTextCursor::GetModelPositionForViewPoint(SwPosition *, const Point &, bool, SwCursorMoveState *) const() 1558 if ( pPor->IsPostItsPortion() || pPor->IsBreakPortion() || 1559 pPor->InToxRefGrp() ) 1560 { 1561 if (pPor->IsPostItsPortion()) 1562 { 1563 SwPostItsPortion* pPostItsPortion = dynamic_cast(pPor); >>> CID 1474452: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pPostItsPortion" to "IsScript", which >>> dereferences it. 1564 if (!pPostItsPortion->IsScript()) // tdf#141079 1565 { 1566 // Offset would be nCurrStart + nLength below, do the same for post-it portions. 1567 nCurrStart += pPor->GetLen(); 1568 } 1569 } To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DZH6v_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi4ic8m5YRW-2FzSiz1ur2-2B84gF-2BE-2FBnnw5llHIfbJV4FWfDyGu2Zq-2Bn6p0E5KNV4AQ5F2RYL8lVs-2B-2FdRxL8DasNqWxB-2BmgRHr7-2Ff64Unm2jy9ovR-2Fd2ikQkAV5i-2FCXxy5MNhIq1XPdEBb30FA2jkg2gEMd651Z3VpvQ3t1B5fnz69h3apZ0HKS5MReZAEnoHmdP ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 19 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 147:(DIVIDE_BY_ZERO) *** CID 147:(DIVIDE_BY_ZERO) /vcl/source/fontsubset/sft.cxx: 2067 in vcl::GetTTGlobalFontInfo(vcl::TrueTypeFont *, vcl::TTGlobalFontInfo_ *)() 2061 2062 GetTTGlobalFontHeadInfo(ttf, info->xMin, info->yMin, info->xMax, info->yMax, info->macStyle); 2063 2064 table = ttf->table(O_hhea, table_size); 2065 if (table_size >= 10) 2066 { >>> CID 147:(DIVIDE_BY_ZERO) >>> In function call "XUnits", division by expression "UPEm" which may be >>> zero has undefined behavior. 2067 info->ascender = XUnits(UPEm, GetInt16(table, HHEA_ascender_offset)); 2068 info->descender = XUnits(UPEm, GetInt16(table, HHEA_descender_offset)); 2069 info->linegap = XUnits(UPEm, GetInt16(table, HHEA_lineGap_offset)); 2070 } 2071 } 2072 /vcl/source/fontsubset/sft.cxx: 2068 in vcl::GetTTGlobalFontInfo(vcl::TrueTypeFont *, vcl::TTGlobalFontInfo_ *)() 2062 GetTTGlobalFontHeadInfo(ttf, info->xMin, info->yMin, info->xMax, info->yMax, info->macStyle); 2063 2064 table = ttf->table(O_hhea, table_size); 2065 if (table_size >= 10) 2066 { 2067 info->ascender = XUnits(UPEm, GetInt16(table, HHEA_ascender_offset)); >>> CID 147:(DIVIDE_BY_ZERO) >>> In function call "XUnits", division by expression "UPEm" which may be >>> zero has undefined behavior. 2068 info->descender = XUnits(UPEm, GetInt16(table, HHEA_descender_offset)); 2069 info->linegap = XUnits(UPEm, GetInt16(table, HHEA_lineGap_offset)); 2070 } 2071 } 2072 2073 GlyphData *GetTTRawGlyphData(AbstractTrueTypeFont *ttf, sal_uInt32 glyphID) /vcl/source/fontsubset/sft.cxx: 2069 in vcl::GetTTGlobalFontInfo(vcl::TrueTypeFont *, vcl::TTGlobalFontInfo_ *)() 2063 2064 table = ttf->table(O_hhea, table_size); 2065 if (table_size >= 10) 2066 { 2067 info->ascender = XUnits(UPEm, GetInt16(table, HHEA_ascender_offset)); 2068 info->descender = XUnits(UPEm, GetInt16(table, HHEA_descender_offset)); >>> CID 147:(DIVIDE_BY_ZERO) >>> In function call "XUnits", division by expression "UPEm" which may be >>> zero has undefined behavior. 2069 info->linegap = XUnits(UPEm, GetInt16(table, HHEA_lineGap_offset)); 2070 } 2071 } 2072 2073 GlyphData *GetTTRawGlyphData(AbstractTrueTypeFont *ttf, sal_uInt32 glyphID) 2074 { ** CID 1474443:(UNINIT) /vcl/unx/generic/app/saldisp.cxx: 2369 in SalVisual::SalVisual(const XVisualInfo *)() /vcl/unx/generic/app/saldisp.cxx: 2368 in SalVisual::SalVisual(const XVisualInfo *)() *** CID 1474443:(UNINIT) /vcl/unx/generic/app/saldisp.cxx: 2369 in SalVisual::SalVisual(const XVisualInfo *)() 2363 { 2364 *static_cast(this) = *pXVI; 2365 if( GetClass() != TrueColor ) 2366 { 2367 eRGBMode_ = SalRGB::RGB; 2368 nRedShift_ = nGreenShift_ = nBlueShift_; >>> CID 1474443:(UNINIT) >>> Using uninitialized value "this->nBlueBits_". 2369 nRedBits_ = nGreenBits_ = nBlueBits_; 2370 return; 2371 } 2372 2373 nRedShift_ = sal_Shift( red_mask ); 2374 nGreenShift_= sal_Shift( green_mask ); /vcl/unx/generic/app/saldisp.cxx: 2368 in SalVisual::SalVisual(const XVisualInfo *)() 2362 SalVisual::SalVisual( const XVisualInfo* pXVI ) 2363 { 2364 *static_cast(this) = *pXVI; 2365 if( GetClass() != TrueColor ) 2366 { 2367 eRGBMode_ = SalRGB::RGB; >>> CID 1474443:(UNINIT) >>> Using uninitialized value "this->nBlueShift_". 2368 nRedShift_ = nGreenShift_ = nBlueShift_; 2369 nRedBits_ = nGreenBits_ = nBlueBits_; 2370 return; 2371 } 2372 2373 nRedShift_ = sal_Shift( red_mask ); To view the defects in Coverity Scan visit,
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 385 new defect(s) introduced to LibreOffice found with Coverity Scan. 24 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 20 of 385 defect(s) ** CID 1474403: Error handling issues (CHECKED_RETURN) /sw/source/core/undo/rolbck.cxx: 152 in SwHistorySetFormat::dumpAsXml(_xmlTextWriter *) const() *** CID 1474403: Error handling issues (CHECKED_RETURN) /sw/source/core/undo/rolbck.cxx: 152 in SwHistorySetFormat::dumpAsXml(_xmlTextWriter *) const() 146 return aResult; 147 } 148 149 void SwHistorySetFormat::dumpAsXml(xmlTextWriterPtr pWriter) const 150 { 151 xmlTextWriterStartElement(pWriter, BAD_CAST("SwHistorySetFormat")); >>> CID 1474403: Error handling issues (CHECKED_RETURN) >>> Calling "xmlTextWriterWriteAttribute(pWriter, (xmlChar >>> *)"m_nNodeIndex", (xmlChar *)rtl::OString::number(this->m_nNodeIndex, >>> 10).getStr())" without checking return value. This library function may >>> fail and return an error code. 152 xmlTextWriterWriteAttribute(pWriter, BAD_CAST("m_nNodeIndex"), 153 BAD_CAST(OString::number(m_nNodeIndex).getStr())); 154 SwHistoryHint::dumpAsXml(pWriter); 155 156 if (m_pAttr) 157 { ** CID 1474402: Error handling issues (CHECKED_RETURN) /drawinglayer/source/dumper/XShapeDumper.cxx: 236 in ::dumpFillTransparenceGradientNameAsAttribute(std::basic_string_view>, _xmlTextWriter *)() *** CID 1474402: Error handling issues (CHECKED_RETURN) /drawinglayer/source/dumper/XShapeDumper.cxx: 236 in ::dumpFillTransparenceGradientNameAsAttribute(std::basic_string_view>, _xmlTextWriter *)() 230 { 231 xmlTextWriterWriteFormatAttribute(xmlWriter, BAD_CAST("fillTransparence"), "%" SAL_PRIdINT32, aTransparence); 232 } 233 234 void dumpFillTransparenceGradientNameAsAttribute(std::u16string_view sTranspGradName, xmlTextWriterPtr xmlWriter) 235 { >>> CID 1474402: Error handling issues (CHECKED_RETURN) >>> Calling "xmlTextWriterWriteFormatAttribute(xmlWriter, (xmlChar >>> *)"fillTransparenceGradientName", "%s", >>> rtl::OString(rtl::OUStringToOString(sTranspGradName, 76, 1382U)).getStr())" >>> without checking return value. This library function may fail and return an >>> error code. 236 xmlTextWriterWriteFormatAttribute(xmlWriter, BAD_CAST("fillTransparenceGradientName"), "%s", 237 OUStringToOString(sTranspGradName, RTL_TEXTENCODING_UTF8).getStr()); 238 } 239 240 //because there's more awt::Gradient properties to dump 241 void dumpGradientProperty(const awt::Gradient& rGradient, xmlTextWriterPtr xmlWriter) ** CID 1474401: Error handling issues (CHECKED_RETURN) /svl/source/undo/undo.cxx: 1367 in SfxListUndoAction::dumpAsXml(_xmlTextWriter *) const() *** CID 1474401: Error handling issues (CHECKED_RETURN) /svl/source/undo/undo.cxx: 1367 in SfxListUndoAction::dumpAsXml(_xmlTextWriter *) const() 1361 return !maUndoActions.empty() && maUndoActions[maUndoActions.size()-1].pAction->Merge( pNextAction ); 1362 } 1363 1364 void SfxListUndoAction::dumpAsXml(xmlTextWriterPtr pWriter) const 1365 { 1366 xmlTextWriterStartElement(pWriter, BAD_CAST("SfxListUndoAction")); >>> CID 1474401: Error handling issues (CHECKED_RETURN) >>> Calling "xmlTextWriterWriteAttribute(pWriter, (xmlChar *)"size", >>> (xmlChar *)rtl::OString::number(this->maUndoActions.size(), 10).getStr())" >>> without checking return value. This library function may fail and return an >>> error code. 1367 xmlTextWriterWriteAttribute(pWriter, BAD_CAST("size"), BAD_CAST(OString::number(maUndoActions.size()).getStr())); 1368 SfxUndoAction::dumpAsXml(pWriter); 1369 1370 for (size_t i = 0; i < maUndoActions.size(); ++i) 1371 maUndoActions[i].pAction->dumpAsXml(pWriter); 1372 ** CID 1474400: Error handling issues (CHECKED_RETURN) /svl/source/items/stritem.cxx: 31 in SfxStringItem::dumpAsXml(_xmlTextWriter *) const() *** CID 1474400: Error handling issues (CHECKED_RETURN) /svl/source/items/stritem.cxx: 31 in SfxStringItem::dumpAsXml(_xmlTextWriter *) const() 25 { 26 return new SfxStringItem(*this); 27 } 28 29 void SfxStringItem::dumpAsXml(xmlTextWriterPtr pWriter) const 30 { >>> CID
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 3 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1473323: Incorrect expression (IDENTICAL_BRANCHES) /sd/source/ui/app/sdpopup.cxx: 122 in SdFieldPopup::Fill(o3tl::strong_int)() *** CID 1473323: Incorrect expression (IDENTICAL_BRANCHES) /sd/source/ui/app/sdpopup.cxx: 122 in SdFieldPopup::Fill(o3tl::strong_int)() 116 m_xPopup->set_active(OString::number(static_cast( pTimeField->GetFormat() ) + 1), true); // - 2 + 3 ! 117 } 118 else if( auto pFileField = dynamic_cast< const SvxExtFileField *>( m_pField ) ) 119 { 120 //SvxExtFileField aFileField( *pFileField ); 121 >>> CID 1473323: Incorrect expression (IDENTICAL_BRANCHES) >>> The same code is executed regardless of whether "pFileField->GetType() >>> == SvxFileType::Fix" is true, because the 'then' and 'else' branches are >>> identical. Should one of the branches be modified, or the entire 'if' >>> statement replaced? 122 if( pFileField->GetType() == SvxFileType::Fix ) 123 m_xPopup->set_active("1", true); 124 else 125 m_xPopup->set_active("1", true); 126 127 m_xPopup->append_radio(OUString::number(nID++), SdResId(STR_FILEFORMAT_NAME_EXT)); ** CID 1473322: Incorrect expression (DIVIDE_BY_ZERO) /emfio/source/reader/mtftools.cxx: 423 in emfio::ScaledFontDetectCorrectHelper::evaluateAlternativeFontScale(const rtl::OUString &, long)() *** CID 1473322: Incorrect expression (DIVIDE_BY_ZERO) /emfio/source/reader/mtftools.cxx: 423 in emfio::ScaledFontDetectCorrectHelper::evaluateAlternativeFontScale(const rtl::OUString &, long)() 417 vcl::Font rFontCandidate2(rFontCandidate); 418 rFontCandidate2.SetAverageFontWidth(static_cast(fCorrectedAverageFontWidth)); 419 pTempVirtualDevice->SetFont(rFontCandidate2); 420 nCorrectedTextLength = pTempVirtualDevice->GetTextWidth(rText); 421 } 422 >>> CID 1473322: Incorrect expression (DIVIDE_BY_ZERO) >>> In expression "static_cast(nImportedTextLength) / >>> static_cast(nCorrectedTextLength)", division by expression >>> "nCorrectedTextLength" which may be zero has undefined behavior. 423 const double fFactorCorrectedText(static_cast(nImportedTextLength) / static_cast(nCorrectedTextLength)); 424 const double fFactorCorrectedTextPercent(fabs(1.0 - fFactorCorrectedText) * 100.0); 425 426 // If FactorCorrectedText fits better than FactorText this is probably 427 // an import of an old EMF/WMF written by LibreOffice on a non-Windows (unx) system 428 // and should be corrected. ** CID 1473321: Incorrect expression (DIVIDE_BY_ZERO) /emfio/source/reader/mtftools.cxx: 394 in emfio::ScaledFontDetectCorrectHelper::evaluateAlternativeFontScale(const rtl::OUString &, long)() *** CID 1473321: Incorrect expression (DIVIDE_BY_ZERO) /emfio/source/reader/mtftools.cxx: 394 in emfio::ScaledFontDetectCorrectHelper::evaluateAlternativeFontScale(const rtl::OUString &, long)() 388 pTempVirtualDevice->SetFont(rFontCandidate); 389 const tools::Long nMeasuredTextLength(pTempVirtualDevice->GetTextWidth(rText)); 390 391 // compare expected and imported TextLengths 392 if(nImportedTextLength != nMeasuredTextLength) 393 { >>> CID 1473321: Incorrect expression (DIVIDE_BY_ZERO) >>> In expression "static_cast(nImportedTextLength) / >>> static_cast(nMeasuredTextLength)", division by expression >>> "nMeasuredTextLength" which may be zero has undefined behavior. 394 const double fFactorText(static_cast(nImportedTextLength) / static_cast(nMeasuredTextLength)); 395 const double fFactorTextPercent(fabs(1.0 - fFactorText) * 100.0); 396 397 // if we assume that loaded file was written on old linux, we have to 398 // back-convert the scale value depending on which system we run 399 #ifdef _WIN32 To view the defects in Coverity Scan visit,
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1473315: Uninitialized members (UNINIT_CTOR) /chart2/source/tools/RegressionCurveCalculator.cxx: 49 in chart::RegressionCurveCalculator::RegressionCurveCalculator()() *** CID 1473315: Uninitialized members (UNINIT_CTOR) /chart2/source/tools/RegressionCurveCalculator.cxx: 49 in chart::RegressionCurveCalculator::RegressionCurveCalculator()() 43 mInterceptValue(0.0), 44 mPeriod(2), 45 mXName("x"), mYName("f(x)") 46 { 47 rtl::math::setNan( _fCorrelationCoefficient ); 48 rtl::math::setNan( ); >>> CID 1473315: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "mnMovingType" is not initialized in this >>> constructor nor in any functions that it calls. 49 } 50 51 RegressionCurveCalculator::~RegressionCurveCalculator() 52 {} 53 54 bool RegressionCurveCalculator::isLinearScaling( To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DtMyx_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi2b9fxe7l69NXJu1qlDXQSOn1zj4oh4BstI6oTRaYltF5DqtduJJjG5pXsSN9y1PiadBp0Iof9TQ-2BU-2Bnu3l8R809U-2Fu963IUkxfREGfSqMqA-2FSArDNtqTLQfxPMQWP4Nh-2B0tfQHxiC6ScKJodTQTdPcSUDZf2Lvdb-2BpBFia3VCvvWz9uXr7gutF-2F-2FB3Vp-2FZAl ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1473244: Error handling issues (CHECKED_RETURN) /extensions/source/bibliography/general.cxx: 347 in BibGeneralPage::LastElementKeyInputHdl(const KeyEvent &)() *** CID 1473244: Error handling issues (CHECKED_RETURN) /extensions/source/bibliography/general.cxx: 347 in BibGeneralPage::LastElementKeyInputHdl(const KeyEvent &)() 341 { 342 uno::Reference xUpdateCursor(xRowSet, UNO_QUERY); 343 if (xUpdateCursor.is()) 344 xUpdateCursor->moveToInsertRow(); 345 } 346 else >>> CID 1473244: Error handling issues (CHECKED_RETURN) >>> Calling "next" without checking return value (as is done elsewhere 182 >>> out of 188 times). 347 xRowSet->next(); 348 } 349 xIdentifierED->grab_focus(); 350 xIdentifierED->select_region(0, -1); 351 GainFocusHdl(*xIdentifierED); 352 return true; To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DUP7T_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi7IwFZ9-2FtTEHkQyuINYc-2FK4zOK-2FFWFtZ3o4NfdIX92Sp1q9FbCPaZjCxTXRsVwk97ka-2B3nUwd-2FNSKqS1HIPGuxPj4caymQz0IM-2FK1PSYl00iTbP7P14TaZOmpM-2Fp4GfxhowNsoRyuWZ1FFYxFte4eCxNFEp9lqyAB44dKTrSunhXmxMsx83Ua-2FopBRRW2Ket-2F ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1473106: Uninitialized members (UNINIT_CTOR) /canvas/source/opengl/ogl_canvashelper.cxx: 93 in oglcanvas::CanvasHelper::Action::Action(const std::function> &)> &)() *** CID 1473106: Uninitialized members (UNINIT_CTOR) /canvas/source/opengl/ogl_canvashelper.cxx: 93 in oglcanvas::CanvasHelper::Action::Action(const std::function> &)> &)() 87 88 functor maFunction; 89 90 Action(const functor& rFunction) 91 : maFunction(rFunction) 92 { >>> CID 1473106: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "meDstBlendMode" is not initialized in this >>> constructor nor in any functions that it calls. 93 } 94 }; 95 96 namespace 97 { 98 bool lcl_drawLine( const CanvasHelper& /*rHelper*/, To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dk7HN_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi52AUU6eBR398djZkiid-2ByWxPosqJ8ZvQ0TetT-2BTI96BzUxWlgi5GpIn-2Bv0-2FXsv08uH6DmDH9kx703oz8vcKer6GZsRHxG3T1nxMFFR28oG54hm4ricgU6pHp5z7GU6H1nM2USbOHjAwwVTO9GSoTNx3EkDu-2B7vLs4DntX7X6Uq5-2F-2BMy8OURpYp06L-2FhqdWok ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1472878: Null pointer dereferences (FORWARD_NULL) *** CID 1472878: Null pointer dereferences (FORWARD_NULL) /sw/source/core/doc/docbm.cxx: 1543 in sw::mark::MarkManager::LOKUpdateActiveField(SfxViewShell *)() 1537 1538 if (m_pLastActiveFieldmark) 1539 { 1540 if (m_pLastActiveFieldmark->GetFieldname() == ODF_FORMDROPDOWN) 1541 { 1542 auto pDrowDown = dynamic_cast<::sw::mark::DropDownFieldmark*>(m_pLastActiveFieldmark); >>> CID 1472878: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pDrowDown" to "SendLOKShowMessage", which >>> dereferences it. 1543 pDrowDown->SendLOKShowMessage(pViewShell); 1544 } 1545 } 1546 else 1547 { 1548 // Check whether we have any drop down fieldmark at all. To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DFgQe_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiMeZoV7fVQ-2FlsfEFgEOjG7F-2FF3YN3UUiAPRwS98xuTiHAhHN1M52-2F3eyiu7-2FxMSSPT-2FrO8WLXZREeFRfxrEs7H0d4J-2F3vmJ-2Fh9gWMYScTsEvPeA-2BVW9MionRUNwPvrBCeizLMpvUnXiJSOiMTnPkR77xEX4YoW4vrf3E02DCd5qj37Zu-2F5CyR2s3213hBkvcH ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 13 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1472858: Null pointer dereferences (FORWARD_NULL) /vcl/jsdialog/executor.cxx: 44 in jsdialog::SendFullUpdate(unsigned long, const rtl::OString &)() *** CID 1472858: Null pointer dereferences (FORWARD_NULL) /vcl/jsdialog/executor.cxx: 44 in jsdialog::SendFullUpdate(unsigned long, const rtl::OString &)() 38 { 39 weld::Widget* pWidget = JSInstanceBuilder::FindWeldWidgetsMap(nWindowId, rWidget); 40 41 if (pWidget != nullptr) 42 { 43 auto pJSWidget = dynamic_cast(pWidget); >>> CID 1472858: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pJSWidget" to "sendFullUpdate", which >>> dereferences it. (The dereference happens because this is a virtual >>> function call.) 44 pJSWidget->sendFullUpdate(); 45 } 46 } 47 48 bool ExecuteAction(sal_uInt64 nWindowId, const OString& rWidget, StringMap& rData) 49 { ** CID 1472857: Uninitialized members (UNINIT_CTOR) /sc/source/core/data/table1.cxx: 312 in ScTable::ScTable(ScDocument &, short, const rtl::OUString &, bool, bool)() *** CID 1472857: Uninitialized members (UNINIT_CTOR) /sc/source/core/data/table1.cxx: 312 in ScTable::ScTable(ScDocument &, short, const rtl::OUString &, bool, bool)() 306 pDrawLayer->SetPageSize( static_cast(nTab), Size( nx, ny ), false ); 307 } 308 } 309 310 for (SCCOL k=0; k < aCol.size(); k++) 311 aCol[k].Init( k, nTab, rDocument, true ); >>> CID 1472857: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "bTableAreaVisibleValid" is not initialized in >>> this constructor nor in any functions that it calls. 312 } 313 314 ScTable::~ScTable() COVERITY_NOEXCEPT_FALSE 315 { 316 if (!rDocument.IsInDtorClear()) 317 { To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D6mEy_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiS-2FG9YP7rC79MR7VV8jdCQY7yKFVL-2BRToIpEUcF2u4X-2Fw3R3joCeJFACH-2BlWm5EpAoXCA2zgDVXkTxXm4-2FCCFXgMx5NuZG0xZYQnSlbSMtX-2BDQ1-2Fyc9b4X6vDyBsz8EutmMB43i7jppGWMw4ERUIZyFmzChk9Y7DDM87Kava5t8FXijKdGOxUewmubEJ48IVp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 5 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1472785: Null pointer dereferences (REVERSE_INULL) /sc/source/ui/view/cellsh1.cxx: 2790 in ScCellShell::ExecuteEdit(SfxRequest &)() *** CID 1472785: Null pointer dereferences (REVERSE_INULL) /sc/source/ui/view/cellsh1.cxx: 2790 in ScCellShell::ExecuteEdit(SfxRequest &)() 2784 2785 const SfxInt32Item* param5 = rReq.GetArg(FN_PARAM_5); 2786 SCROW table = param5 ? param5->GetValue() : 0; 2787 2788 ScInputHandler* pInputHdl = SC_MOD()->GetInputHdl(); 2789 >>> CID 1472785: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "pTabViewShell" suggests that it may be null, but it has >>> already been dereferenced on all paths leading to the check. 2790 if(param3 && param4 && pInputHdl && pTabViewShell) 2791 { 2792 ScViewData& rData = pTabViewShell->GetViewData(); 2793 ScTabView* pTabView = rData.GetView(); 2794 2795 if (param1 && param2) ** CID 1472784: Null pointer dereferences (NULL_RETURNS) /sw/source/filter/ww8/docxsdrexport.cxx: 804 in DocxSdrExport::startDMLAnchorInline(const SwFrameFormat *, const Size &)() *** CID 1472784: Null pointer dereferences (NULL_RETURNS) /sw/source/filter/ww8/docxsdrexport.cxx: 804 in DocxSdrExport::startDMLAnchorInline(const SwFrameFormat *, const Size &)() 798 else 799 { 800 // In this case we likely had an odt document to be exported to docx. 801 // There is no grab-bag or something else so for a workaround, 802 // let's export the geometry of the shape... 803 // First get the UNO-shape >>> CID 1472784: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "nullptr" "const_cast>> *>(pFrameFormat->FindRealSdrObject())" when calling "getUnoShape". (The >>> dereference happens because this is a virtual function call.) 804 uno::Reference xShape( 805 const_cast(pFrameFormat->FindRealSdrObject())->getUnoShape(), 806 uno::UNO_QUERY); 807 808 if (xShape && xShape->getShapeType() == u"com.sun.star.drawing.CustomShape") 809 { ** CID 1472783: Null pointer dereferences (FORWARD_NULL) *** CID 1472783: Null pointer dereferences (FORWARD_NULL) /sc/source/core/data/drwlayer.cxx: 2031 in ScDrawLayer::MirrorRTL(SdrObject *)() 2025 // save and reload. 2026 const tools::Long nInverseShift = aOldSnapRect.Left() + aOldSnapRect.Right(); 2027 const Point aLogicLT = pObj->GetLogicRect().TopLeft(); 2028 const Point aMirroredLogicLT = aLogicLT + Point(nInverseShift, 0); 2029 const Point aOffsetDiff = aMirroredLogicLT - aOldLogicRect.TopLeft(); 2030 // new Offsets >>> CID 1472783: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pNoRotatedAnchor->maStartOffset" to "operator >>> +=", which dereferences it. 2031 pNoRotatedAnchor->maStartOffset += aOffsetDiff; 2032 pNoRotatedAnchor->maEndOffset += aOffsetDiff; 2033 } 2034 else // page anchored 2035 { 2036 Point aRef1( 0, 0 ); ** CID 1472782: Null pointer dereferences (FORWARD_NULL) *** CID 1472782: Null pointer dereferences (FORWARD_NULL) /sw/source/core/layout/fly.cxx: 681 in SwFlyFrame::SwClientNotify(const SwModify &, const SfxHint &)() 675 pOItem = aOIter.NextItem(); 676 } while(pNItem); 677 if(aOldSet.Count() || aNewSet.Count()) 678 SwLayoutFrame::SwClientNotify(rMod, sw::LegacyModifyHint(, )); 679 } 680 else >>> CID 1472782: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pLegacy->m_pNew" to "UpdateAttr_", which >>> dereferences it. 681 UpdateAttr_(pLegacy->m_pOld, pLegacy->m_pNew, nInvFlags); 682 683 if(nInvFlags == 0) 684 return; 685 686 Invalidate_(); ** CID 1472781: Error handling issues (UNCAUGHT_EXCEPT)
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 3 new defect(s) introduced to LibreOffice found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1472568: Integer handling issues (DIVIDE_BY_ZERO) /sc/source/core/data/table2.cxx: 4011 in ScTable::GetRowForHeight(long) const() *** CID 1472568: Integer handling issues (DIVIDE_BY_ZERO) /sc/source/core/data/table2.cxx: 4011 in ScTable::GetRowForHeight(long) const() 4005 tools::Long nPixelsLeft = nHeight - nSum; 4006 tools::Long nCommonPixels = aRowHeightRange.mnValue * nCommon; 4007 4008 // are we in the zone ? 4009 if (nCommonPixels > nPixelsLeft) 4010 { >>> CID 1472568: Integer handling issues (DIVIDE_BY_ZERO) >>> In expression "(nPixelsLeft + aRowHeightRange.mnValue - 1L) / >>> aRowHeightRange.mnValue", division by expression "aRowHeightRange.mnValue" >>> which may be zero has undefined behavior. 4011 nRow += (nPixelsLeft + aRowHeightRange.mnValue - 1) / aRowHeightRange.mnValue; 4012 4013 // FIXME: finding this next row is far from elegant, 4014 // we have a single caller, which subtracts one as well(!?) 4015 if (nRow >= rDocument.MaxRow()) 4016 return rDocument.MaxRow(); ** CID 1472567: Null pointer dereferences (NULL_RETURNS) /chart2/source/controller/main/ChartController_TextEdit.cxx: 101 in chart::ChartController::StartTextEdit(const Point *)() *** CID 1472567: Null pointer dereferences (NULL_RETURNS) /chart2/source/controller/main/ChartController_TextEdit.cxx: 101 in chart::ChartController::StartTextEdit(const Point *)() 95 pOutlinerView->MouseButtonUp( aEditEvt ); 96 } 97 } 98 99 //we invalidate the outliner region because the outliner has some 100 //paint problems (some characters are painted twice a little bit shifted) >>> CID 1472567: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "nullptr" >>> "this->GetChartWindow()" when calling "Invalidate". (The dereference >>> happens because this is a virtual function call.) 101 GetChartWindow()->Invalidate( m_pDrawViewWrapper->GetMarkedObjBoundRect() ); 102 } 103 104 bool ChartController::EndTextEdit() 105 { 106 m_pDrawViewWrapper->SdrEndTextEdit(); ** CID 1472566: Integer handling issues (SIGN_EXTENSION) /sc/source/core/data/table2.cxx: 4006 in ScTable::GetRowForHeight(long) const() *** CID 1472566: Integer handling issues (SIGN_EXTENSION) /sc/source/core/data/table2.cxx: 4006 in ScTable::GetRowForHeight(long) const() 4000 SCROW nLastCommon = std::min(aData.mnRow2, aRowHeightRange.mnRow2); 4001 assert (nLastCommon >= nRow); 4002 SCROW nCommon = nLastCommon - nRow + 1; 4003 4004 // how much further to go ? 4005 tools::Long nPixelsLeft = nHeight - nSum; >>> CID 1472566: Integer handling issues (SIGN_EXTENSION) >>> Suspicious implicit sign extension: "aRowHeightRange.mnValue" with type >>> "sal_uInt16" (16 bits, unsigned) is promoted in "aRowHeightRange.mnValue * >>> nCommon" to type "int" (32 bits, signed), then sign-extended to type "long" >>> (64 bits, signed). If "aRowHeightRange.mnValue * nCommon" is greater than >>> 0x7FFF, the upper bits of the result will all be 1. 4006 tools::Long nCommonPixels = aRowHeightRange.mnValue * nCommon; 4007 4008 // are we in the zone ? 4009 if (nCommonPixels > nPixelsLeft) 4010 { 4011 nRow += (nPixelsLeft + aRowHeightRange.mnValue - 1) / aRowHeightRange.mnValue; To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DrTjK_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJihwUEFQgPb0bXIjlPUTLWQt6yWBCWN4ds0q3ZcO3SF25mJNGNSfy-2BYOcyHF6eWo6sm5Z3DgYQRpGkhTwttKIgd2RnwwbhyjYDzXB9TgNQ2lLY60a-2BPgz5cEtp22JzsU7RXGY-2BjyY-2FE9RP159fvzSiH3q6sbn0HsSYcfMPtl1l3jGWiS5v0Golk5CZd0xuVnXk ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1472493: Integer handling issues (SIGN_EXTENSION) /sc/source/core/data/table2.cxx: 4006 in ScTable::GetRowForHeight(unsigned long) const() *** CID 1472493: Integer handling issues (SIGN_EXTENSION) /sc/source/core/data/table2.cxx: 4006 in ScTable::GetRowForHeight(unsigned long) const() 4000 SCROW nLastCommon = std::min(aData.mnRow2, aRowHeightRange.mnRow2); 4001 assert (nLastCommon >= nRow); 4002 SCROW nCommon = nLastCommon - nRow + 1; 4003 4004 // how much further to go ? 4005 sal_uLong nPixelsLeft = nHeight - nSum; >>> CID 1472493: Integer handling issues (SIGN_EXTENSION) >>> Suspicious implicit sign extension: "aRowHeightRange.mnValue" with type >>> "sal_uInt16" (16 bits, unsigned) is promoted in "aRowHeightRange.mnValue * >>> nCommon" to type "int" (32 bits, signed), then sign-extended to type >>> "unsigned long" (64 bits, unsigned). If "aRowHeightRange.mnValue * >>> nCommon" is greater than 0x7FFF, the upper bits of the result will all >>> be 1. 4006 sal_uLong nCommonPixels = aRowHeightRange.mnValue * nCommon; 4007 4008 // are we in the zone ? 4009 if (nCommonPixels > nPixelsLeft) 4010 { 4011 nRow += (nPixelsLeft + aRowHeightRange.mnValue - 1) / aRowHeightRange.mnValue; To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DXYXv_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJie07jXsGeBWccWlwrcSU65nvevvmNa5neYsm98tXlcp-2BS18mbmiQmZ5Qp3GFNA6tXMnjCMufEPLmow9j3kj5T0zzTTKK1CBN9XTPR97T6X7DUiqVWRFR3-2Fk9dBJVl8I80H52VahitctUlIpbqqyvV-2B7S3nCF0ov2mZAAzma-2Fj9zcK6aMh-2FzVVElCBJdLxcCnD ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1472266:(INVALIDATE_ITERATOR) /oox/source/drawingml/fillproperties.cxx: 501 in oox::drawingml::FillProperties::pushToPropMap(oox::drawingml::ShapePropertyMap &, const oox::GraphicHelper &, int, Color, bool, bool, bool) const() /oox/source/drawingml/fillproperties.cxx: 601 in oox::drawingml::FillProperties::pushToPropMap(oox::drawingml::ShapePropertyMap &, const oox::GraphicHelper &, int, Color, bool, bool, bool) const() /oox/source/drawingml/fillproperties.cxx: 415 in oox::drawingml::FillProperties::pushToPropMap(oox::drawingml::ShapePropertyMap &, const oox::GraphicHelper &, int, Color, bool, bool, bool) const() /oox/source/drawingml/fillproperties.cxx: 494 in oox::drawingml::FillProperties::pushToPropMap(oox::drawingml::ShapePropertyMap &, const oox::GraphicHelper &, int, Color, bool, bool, bool) const() /oox/source/drawingml/fillproperties.cxx: 595 in oox::drawingml::FillProperties::pushToPropMap(oox::drawingml::ShapePropertyMap &, const oox::GraphicHelper &, int, Color, bool, bool, bool) const() *** CID 1472266:(INVALIDATE_ITERATOR) /oox/source/drawingml/fillproperties.cxx: 501 in oox::drawingml::FillProperties::pushToPropMap(oox::drawingml::ShapePropertyMap &, const oox::GraphicHelper &, int, Color, bool, bool, bool) const() 495 aGradientStops.size() == 3 && 496 std::next(aGradientStops.begin())->second.getColor(rGraphicHelper, nPhClr) == std::prev(aGradientStops.end())->second.getColor(rGraphicHelper, nPhClr) && 497 std::next(aGradientStops.begin())->second.getTransparency() == std::prev(aGradientStops.end())->second.getTransparency()) 498 { 499 // Two segments, second is uniformly coloured 500 SAL_INFO("oox.drawingml.gradient", "two segments, second is uniformly coloured"); >>> CID 1472266:(INVALIDATE_ITERATOR) >>> Dereferencing iterator "std::prev(aGradientStops.end(), 1L)" though it >>> is already past the end of its container. 501 nBorder = std::prev(aGradientStops.end())->first - std::next(aGradientStops.begin())->first; 502 aGradientStops.erase(std::next(aGradientStops.begin())); 503 aWidestSegmentStart = aGradientStops.begin(); 504 bSwap = true; 505 nShapeRotation = 180*6 - nShapeRotation; 506 } /oox/source/drawingml/fillproperties.cxx: 601 in oox::drawingml::FillProperties::pushToPropMap(oox::drawingml::ShapePropertyMap &, const oox::GraphicHelper &, int, Color, bool, bool, bool) const() 595 aStartColor = aWidestSegmentEnd->second; 596 aEndColor = aWidestSegmentStart->second; 597 } 598 else 599 { 600 aStartColor = aWidestSegmentStart->second; >>> CID 1472266:(INVALIDATE_ITERATOR) >>> Dereferencing iterator "aWidestSegmentEnd" though it is already past >>> the end of its container. 601 aEndColor = aWidestSegmentEnd->second; 602 } 603 604 SAL_INFO("oox.drawingml.gradient", "start color: " << std::hex << sal_Int32(aStartColor.getColor( rGraphicHelper, nPhClr )) << std::dec << 605 "@" << (100-aStartColor.getTransparency()) << "%" 606 ", end color: " << std::hex << sal_Int32(aEndColor.getColor( rGraphicHelper, nPhClr )) << std::dec << /oox/source/drawingml/fillproperties.cxx: 415 in oox::drawingml::FillProperties::pushToPropMap(oox::drawingml::ShapePropertyMap &, const oox::GraphicHelper &, int, Color, bool, bool, bool) const() 409 410 // Check if the gradient is symmetric, which we will emulate with an "axial" gradient. 411 bool bSymmetric(true); 412 { 413 GradientFillProperties::GradientStopMap::const_iterator aItA( aGradientStops.begin() ); 414 GradientFillProperties::GradientStopMap::const_iterator aItZ(std::prev(aGradientStops.end())); >>> CID 1472266:(INVALIDATE_ITERATOR) >>> Dereferencing iterator "aItZ" though it is already past the end of its >>> container. 415
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 3 new defect(s) introduced to LibreOffice found with Coverity Scan. 9 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1472120: Error handling issues (UNCAUGHT_EXCEPT) /sw/source/core/edit/ednumber.cxx: 430 in ::MakeAllOutlineContentTemporarilyVisibile::~MakeAllOutlineContentTemporarilyVisibile()() *** CID 1472120: Error handling issues (UNCAUGHT_EXCEPT) /sw/source/core/edit/ednumber.cxx: 430 in ::MakeAllOutlineContentTemporarilyVisibile::~MakeAllOutlineContentTemporarilyVisibile()() 424 } 425 } 426 } 427 } 428 } 429 >>> CID 1472120: Error handling issues (UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 430 ~MakeAllOutlineContentTemporarilyVisibile() 431 { 432 if (!pWrtShell) 433 return; 434 // restore outlines content visibility 435 for (SwNode* pNd : aOutlineNdsArray) ** CID 1472119: Uninitialized members (UNINIT_CTOR) /sc/inc/refdata.hxx: 131 in ScComplexRefData::ScComplexRefData()() *** CID 1472119: Uninitialized members (UNINIT_CTOR) /sc/inc/refdata.hxx: 131 in ScComplexRefData::ScComplexRefData()() 125 ScSingleRefData Ref1; 126 ScSingleRefData Ref2; 127 bool bTrimToData; 128 129 ScComplexRefData() : 130 bTrimToData(false) >>> CID 1472119: Uninitialized members (UNINIT_CTOR) >>> Non-static class member field "Ref2.mnTab" is not initialized in this >>> constructor nor in any functions that it calls. 131 {} 132 133 void InitFlags() 134 { Ref1.InitFlags(); Ref2.InitFlags(); } 135 void InitRange( const ScRange& rRange ) 136 { ** CID 1470701: Error handling issues (UNCAUGHT_EXCEPT) /vcl/source/graphic/UnoGraphic.cxx: 45 in unographic::Graphic::init(const Graphic &)() *** CID 1470701: Error handling issues (UNCAUGHT_EXCEPT) /vcl/source/graphic/UnoGraphic.cxx: 45 in unographic::Graphic::init(const Graphic &)() 39 } 40 41 Graphic::~Graphic() throw() 42 { 43 } 44 >>> CID 1470701: Error handling issues (UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "throw()" doesn't allow it to be thrown. This will cause >>> a call to unexpected() which usually calls terminate(). 45 void Graphic::init( const ::Graphic& rGraphic ) 46 throw() 47 { 48 maGraphic = rGraphic; 49 unographic::GraphicDescriptor::init(maGraphic); 50 } To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DkYF2_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiCwD3NAaJ-2B-2BVu2JeUT5uPGYJzkBxFvq1eVZsXmKzdDFYiz44mVJwqX-2FMBBCsa55KqJ2kRSWmHRaMPJEcWQbsaLmnip7GXgyPOXBv-2BmwCtF-2BT7N6O5rTQ1tTS70UpYUDR95rP5-2B-2FhsGeTPkQlToW46efZFSrbBpokLHIxGj3rEVyXAYcpIRCcNlSkJGrVwufzW ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 297 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1471720: Null pointer dereferences (FORWARD_NULL) *** CID 1471720: Null pointer dereferences (FORWARD_NULL) /sw/source/core/undo/untblk.cxx: 427 in SwUndoInserts::RedoImpl(sw::UndoRedoContext &)() 421 } 422 423 if (rDoc.GetTextFormatColls()->IsAlive(m_pTextFormatColl)) 424 { 425 SwTextNode* pTextNd = rPam.GetMark()->nNode.GetNode().GetTextNode(); 426 if( pTextNd ) >>> CID 1471720: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "this->m_pTextFormatColl" to "ChgFormatColl", >>> which dereferences it. 427 pTextNd->ChgFormatColl( m_pTextFormatColl ); 428 } 429 m_pTextFormatColl = pSavTextFormatColl; 430 431 if (m_pLastNodeColl && rDoc.GetTextFormatColls()->IsAlive(m_pLastNodeColl) 432 && rPam.GetPoint()->nNode != rPam.GetMark()->nNode) ** CID 1471719: Parse warnings (PARSE_ERROR) /sd/source/ui/unoidl/unopage.cxx: 105 in () *** CID 1471719: Parse warnings (PARSE_ERROR) /sd/source/ui/unoidl/unopage.cxx: 105 in () 99 WID_TRANSITION_DIRECTION, WID_TRANSITION_FADE_COLOR, WID_TRANSITION_DURATION, WID_LOOP_SOUND, 100 WID_NAVORDER, WID_PAGE_PREVIEWMETAFILE 101 }; 102 103 } 104 >>> CID 1471719: Parse warnings (PARSE_ERROR) >>> class template name must be a placeholder for the complete type being >>> initialized (not for a component of that type) 105 OUStringLiteral const sEmptyPageName = u"page"; 106 107 // this function stores the property maps for draw pages in impress and draw 108 static const SvxItemPropertySet* ImplGetDrawPagePropertySet( bool bImpress, PageKind ePageKind ) 109 { 110 static const SfxItemPropertyMapEntry aDrawPagePropertyMap_Impl[] = To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DSEIt_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiIgU-2FYO3drlK68cbdjI0h1Y-2Blb-2FZwltZ7qbtctziD6W8cQfi7S990cyr0A-2FXXQ1u0rdBceHuwP2mhZOrGB-2BO5u-2BNfv9tzIgQ-2Bktr1Bm6-2BRHlGTbD-2FfihwEQx7JMo57jV6ua1ZGZ7XhSjqAQFyWgLFXJck51d3MCD40pKO3rkLYsxuIGASM2hTjxhDEpi6QoUQ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1471704: Memory - corruptions (OVERLAPPING_COPY) /tools/source/generic/bigint.cxx: 84 in BigInt::Normalize()() *** CID 1471704: Memory - corruptions (OVERLAPPING_COPY) /tools/source/generic/bigint.cxx: 84 in BigInt::Normalize()() 78 while ( nLen > 1 && nNum[nLen-1] == 0 ) 79 nLen--; 80 81 if ( nLen < 3 ) 82 { 83 if ( nLen < 2 ) >>> CID 1471704: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "(*this).nNum[0]" to "(*this).nVal", which have overlapping >>> memory locations and different types. 84 nVal = nNum[0]; 85 else if ( nNum[1] & 0x8000 ) 86 return; 87 else 88 nVal = (static_cast(nNum[1]) << 16) + nNum[0]; 89 ** CID 1471703: Uninitialized members (UNINIT_CTOR) /vcl/jsdialog/jsdialogbuilder.cxx: 902 in JSMessageDialog::JSMessageDialog(MessageDialog *, VclPtr, SalInstanceBuilder *, bool)() *** CID 1471703: Uninitialized members (UNINIT_CTOR) /vcl/jsdialog/jsdialogbuilder.cxx: 902 in JSMessageDialog::JSMessageDialog(MessageDialog *, VclPtr, SalInstanceBuilder *, bool)() 896 { 897 if (aContentWindow && aContentWindow->IsDisableIdleNotify()) 898 { 899 pDialog->AddEventListener(LINK(this, JSMessageDialog, on_window_event)); 900 m_bNotifyCreated = false; 901 } >>> CID 1471703: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "m_bNotifyCreated" is not initialized in this >>> constructor nor in any functions that it calls. 902 } 903 904 void JSMessageDialog::set_primary_text(const OUString& rText) 905 { 906 SalInstanceMessageDialog::set_primary_text(rText); 907 notifyDialogState(); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Di1Z4_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJirS80j2TCi66gpVYqK94sirIPxuWlUVTLNYaxnyz4pOpb5gzllHUg5YCpefgIfnURmE3IwWBpCfmjcneJinwYOUuiInVHApG4SQRVGEXIFL6tlre7x0VJgPMpyTR1RnNy-2FVG0p5T5VwkmWUt6RuBTUpeWlle5x7xhBbPrGGMF0bt2nbFeoXoUjz0Tqqms06kS ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1470591: Null pointer dereferences (REVERSE_INULL) /sc/source/filter/xcl97/xcl97rec.cxx: 1106 in XclObjAny::WriteFromTo(XclExpXmlStream &, const com::sun::star::uno::Reference &, short)() *** CID 1470591: Null pointer dereferences (REVERSE_INULL) /sc/source/filter/xcl97/xcl97rec.cxx: 1106 in XclObjAny::WriteFromTo(XclExpXmlStream &, const com::sun::star::uno::Reference &, short)() 1100 awt::Point aTopLeft= rShape->getPosition(); 1101 awt::Size aSize = rShape->getSize(); 1102 1103 // size is correct, but aTopLeft needs correction for rotated shapes 1104 SdrObject* pObj = SdrObject::getSdrObjectFromXShape(rShape.get()); 1105 sal_Int32 nRotation = pObj->GetRotateAngle(); >>> CID 1470591: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "pObj" suggests that it may be null, but it has already >>> been dereferenced on all paths leading to the check. 1106 if ( pObj && nRotation != 0 && pObj->GetObjIdentifier() == OBJ_CUSTOMSHAPE ) 1107 { 1108 const tools::Rectangle& aSnapRect(pObj->GetSnapRect()); // bounding box of the rotated shape 1109 aTopLeft.X = aSnapRect.getX() + (aSnapRect.GetWidth() / 2) - (aSize.Width / 2); 1110 aTopLeft.Y = aSnapRect.getY() + (aSnapRect.GetHeight() / 2) - (aSize.Height / 2); } ** CID 1470590: Memory - corruptions (OVERRUN) *** CID 1470590: Memory - corruptions (OVERRUN) /comphelper/source/misc/storagehelper.cxx: 436 in comphelper::OStorageHelper::CreatePackageEncryptionData(std::basic_string_view>)() 430 if ( nError != rtl_Digest_E_None ) 431 { 432 aEncryptionData.realloc( nSha1Ind ); 433 break; 434 } 435 >>> CID 1470590: Memory - corruptions (OVERRUN) >>> Overrunning array "pBuffer" of 20 bytes by passing it to a function >>> which accesses it at byte offset 159 using argument "20". 436 aEncryptionData[nSha1Ind+nInd].Value <<= uno::Sequence< sal_Int8 >( reinterpret_cast(pBuffer), RTL_DIGEST_LENGTH_SHA1 ); 437 } 438 439 // actual SHA1 440 aEncryptionData[nSha1Ind + 2].Name = PACKAGE_ENCRYPTIONDATA_SHA1CORRECT; 441 OString aByteStrPass = OUStringToOString(aPassword, RTL_TEXTENCODING_UTF8); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D3Fdw_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi4Hml82RPhD614tpZwPe6uTjWmrhpUB9PgbQjAFoqHUX47TnYaD0Q17l-2BtWdnv4HsPIeGYUVj3Oq0r0t711qIX9ZOpOSOAIx6G5nV6s2ODdsVTwoec340-2BsUA0BFp5nk-2BJrXE5Jel7S2Q1jQzFEjAfDeXhnPGp7lVAb0eFiDE53atHAxfvdEKq0vZ11iau-2BCG ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 3 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1470587: Null pointer dereferences (FORWARD_NULL) *** CID 1470587: Null pointer dereferences (FORWARD_NULL) /sw/source/core/layout/flyincnt.cxx: 121 in SwFlyInContentFrame::SwClientNotify(const SwModify &, const SfxHint &)() 115 { 116 aTweakedChgs.first = std::make_unique(*pOldAttrSetChg); 117 aTweakedChgs.first->ClearItem(RES_SURROUND); 118 aTweakedChgs.first->ClearItem(RES_FRMMACRO); 119 aSuperArgs = std::pair(aTweakedChgs.first.get(), aTweakedChgs.second.get()); 120 } >>> CID 1470587: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pNewAttrSetChg" to "GetChgSet", which >>> dereferences it. 121 } else if(pNewAttrSetChg->GetChgSet()->Count()) 122 aSuperArgs = std::pair(pLegacy->m_pOld, pLegacy->m_pNew); 123 break; 124 } 125 case RES_SURROUND: 126 case RES_FRMMACRO: ** CID 1470586: Null pointer dereferences (FORWARD_NULL) *** CID 1470586: Null pointer dereferences (FORWARD_NULL) /sw/source/core/layout/flylay.cxx: 771 in SwFlyLayFrame::SwClientNotify(const SwModify &, const SfxHint &)() 765 pTmpPage = static_cast(pTmpPage->GetNext()); 766 --nPagesToFlip; 767 } 768 if(!nPagesToFlip) 769 { 770 // #i50432# - adjust synopsis of >>> CID 1470586: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pTmpPage" to "PlaceFly", which dereferences it. 771 pTmpPage->PlaceFly(this, nullptr); 772 } 773 if(!pTmpPage) 774 { 775 pRoot->SetAssertFlyPages(); 776 pRoot->AssertFlyPages(); ** CID 1470585: Null pointer dereferences (NULL_RETURNS) *** CID 1470585: Null pointer dereferences (NULL_RETURNS) /sw/source/core/edit/edtab.cxx: 170 in SwEditShell::TableToText(char16_t)() 164 // tell the charts about the table to be deleted and have them use their own data 165 GetDoc()->getIDocumentChartDataProviderAccess().CreateChartInternalDataProviders( >GetTable() ); 166 167 StartAllAction(); 168 169 // move current Cursor out of the listing area >>> CID 1470585: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "nullptr" "pTableNd" when calling >>> "SwNodeIndex". 170 SwNodeIndex aTabIdx( *pTableNd ); 171 pCursor->DeleteMark(); 172 pCursor->GetPoint()->nNode = *pTableNd->EndOfSectionNode(); 173 pCursor->GetPoint()->nContent.Assign( nullptr, 0 ); 174 // move sPoint and Mark out of the area! 175 pCursor->SetMark(); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D2cFJ_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiUKqysL9Tib2JVVvn4NbopvtGvq5SIc-2FWzbQeN1BoSWZN6yJIMHGa2oweC8-2FroAUJ08zDOVPUA5x15ARyieYwkTAYXGBkqHF3spnbvoQOqcCoydr7zET-2BWyX-2FHLsqVxB57-2FKaCd-2Bh5MAUv9kfx3JKY13q6g2cOYaoCYee3eTzRlH82rXwl-2FJAWA1P6UVGwSsp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1470573: Null pointer dereferences (FORWARD_NULL) /sw/source/core/fields/usrfld.cxx: 219 in SwUserFieldType::SwClientNotify(const SwModify &, const SfxHint &)() *** CID 1470573: Null pointer dereferences (FORWARD_NULL) /sw/source/core/fields/usrfld.cxx: 219 in SwUserFieldType::SwClientNotify(const SwModify &, const SfxHint &)() 213 return m_aName; 214 } 215 216 void SwUserFieldType::SwClientNotify(const SwModify&, const SfxHint& rHint) 217 { 218 auto pLegacy = dynamic_cast(); >>> CID 1470573: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "pLegacy". 219 if(!pLegacy->m_pOld && !pLegacy->m_pNew) 220 m_bValidValue = false; 221 222 CallSwClientNotify(rHint); 223 // update input fields that might be connected to the user field 224 if (!IsModifyLocked()) To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DxKfa_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJikHIOtypVsnWYw8Ja5YcpnHz-2FoPOBSXHj-2BQak39AS7nclvjOlZIw9JtnbDrvdOqgBpqraftoBxN71aj1rColNKkHjfTdeo05EsSSrkZ2q8ICznc1SGklYoN-2FCz5a0rd5VgMsCSPQTS-2Fa-2FqAIGn49iGQktpn1eI3a-2BC3SDmadfiR4HNjsxyYGnNtrpQe76kQzh ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1470402: SpotBugs: Internationalization (FB.DM_DEFAULT_ENCODING) /odk/source/com/sun/star/lib/loader/WinRegKey.java: 48 in com.sun.star.lib.loader.WinRegKey.getStringValue()() *** CID 1470402: SpotBugs: Internationalization (FB.DM_DEFAULT_ENCODING) /odk/source/com/sun/star/lib/loader/WinRegKey.java: 48 in com.sun.star.lib.loader.WinRegKey.getStringValue()() 42 /** 43 * Reads the default string value. 44 */ 45 public String getStringValue() throws WinRegKeyException { 46 try { 47 Process p = Runtime.getRuntime().exec(new String[]{"reg", "QUERY", m_keyName}); >>> CID 1470402: SpotBugs: Internationalization (FB.DM_DEFAULT_ENCODING) >>> Found reliance on default encoding: new >>> java.io.InputStreamReader(InputStream). 48 BufferedReader r = new BufferedReader(new InputStreamReader(p.getInputStream())); 49 String v = null; 50 Pattern pt = Pattern.compile("\\s+\\(Default\\)\\s+REG_SZ\\s+(.+)"); 51 for (;;) { 52 String s = r.readLine(); 53 if (s == null) { To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DFob-_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiGe6c8AT01Hb9KNQnXdZCrq2Y91B3A0hcb-2F0aK0eqa0-2FDBZHfxDlc6hw2K2UwU7Bup5h1D4a-2ByER-2FMauULh7KMotCvo3NiKHT6mp5xX3xsKPjCnmJN1rbXAhPyg-2BcMHfhGrJ-2BV2X9tMbufqhKuDu-2FBIK4JHfeErbKQmTjFgag29hPijrB7ldYHAPGK8lnVdyD ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 13 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1470396: Null pointer dereferences (FORWARD_NULL) /sc/source/core/data/drwlayer.cxx: 942 in ScDrawLayer::InitializeCellAnchoredObj(SdrObject *, ScDrawObjData &)() *** CID 1470396: Null pointer dereferences (FORWARD_NULL) /sc/source/core/data/drwlayer.cxx: 942 in ScDrawLayer::InitializeCellAnchoredObj(SdrObject *, ScDrawObjData &)() 936 // anchor from start and end point. 937 SdrMeasureObj* pMeasureObj = dynamic_cast(pObj); 938 // tdf#137576. The logic rectangle has likely no current values here, but only the 939 // 1cm x 1cm default size. The call of TakeUnrotatedSnapRect is currently (LO 7.2) 940 // the only way to force a recalc of the logic rectangle. 941 tools::Rectangle aObjRect; >>> CID 1470396: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pMeasureObj" to "TakeUnrotatedSnapRect", which >>> dereferences it. (The dereference happens because this is a virtual >>> function call.) 942 pMeasureObj->TakeUnrotatedSnapRect(aObjRect); 943 GetCellAnchorFromPosition(aObjRect, rNoRotatedAnchor, *pDoc, rData.maStart.Tab(), 944 false /*bHiddenAsZero*/); 945 } 946 else 947 { To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DBV7D_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJikbejnUuzpwbnch-2FWhF47anTj5jsBOy-2FVE3DyInnO8Sc-2F4zhrxaV8qAob-2BjmnzyBoHslRUkEhMzpr775PibjCXo9fyUWnZ6-2B-2Bl-2FixyPGGN3-2FFqZS-2FJrgmYd0S8VAfMnPV7jRTJV1k8rNUtnwm65Y-2FJOiyqa9fGGLFKYLEhgEw8Y9QR6kCNndcsDw2w8pWRv9o ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 25 new defect(s) introduced to LibreOffice found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 20 of 25 defect(s) ** CID 1470375: Parse warnings (PARSE_ERROR) /sax/source/fastparser/fastparser.cxx: 1502 in () *** CID 1470375: Parse warnings (PARSE_ERROR) /sax/source/fastparser/fastparser.cxx: 1502 in () 1496 if( ! bSuccess ) 1497 bSuccess = NormalizeW3URI( rName ); 1498 } 1499 1500 const OUStringLiteral XML_URI_W3_PREFIX(u"https://u15810271.ct.sendgrid.net/ls/click?upn=CTPegkVN6peWFCMEieYYmMAi6rxYQqD8BK-2BowJuYSxg-3Dc6q9_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi-2B4MXY6F0w8TVlVWTU6jHANV6gdLlgOLABK-2F2IuW4zk32FGVaiuzudvtgyqMeq59PyJPL6-2FrPaQxbjCnUTgXMDX-2Fuk-2BppQlRGHM4-2F2YQxGmTTpxLZRH9xLewuWKwi9NfwFYdUsxACgQYyBgVaSUQ1V3W6t9Wt6uwTc6RxIBsDFrw6JT4cvkBgStNPCql6lLNQ 1501 const OUStringLiteral XML_URI_XFORMS_SUFFIX(u"/xforms"); >>> CID 1470375: Parse warnings (PARSE_ERROR) >>> class template name must be a placeholder for the complete type being >>> initialized (not for a component of that type) 1502 const OUStringLiteral XML_N_XFORMS_1_0(u"https://u15810271.ct.sendgrid.net/ls/click?upn=CTPegkVN6peWFCMEieYYmE4D34YvVPE16-2FjT4Tl-2FaCEX2vkfxwH3ZDFlUPEa3IWFbStP_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi-2B4MXY6F0w8TVlVWTU6jHAEt0BawV1hb436D-2BC9IReecEo5Ay71l9qnPdaNjsIdbQx8-2BBL40Dn-2FumrEreP5QumVMJBPudpwBxB43W4o1wN4gDmyo909wQTfSTyVz2hvKfu5wIboilLd5jik5W1FduU7lNDL-2BNkbDIg0x0S-2FCHsAxHrZa8GMyZlEXJ3-2FoLiG-2Fr 1503 const OUStringLiteral XML_N_SVG(u"https://u15810271.ct.sendgrid.net/ls/click?upn=CTPegkVN6peWFCMEieYYmNsCdS2AhBjuINuzNiQdqd4Du2h6yaUjbK9yiBv9mh4RJZXc_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi-2B4MXY6F0w8TVlVWTU6jHAA3OCKUodGCzvTlHlI7EkVbz9GgsfvnSjr8Jscojq3KsV574ppYVlysR-2FBiFpEvk8k8L73VjyTvPZnm5TDxG-2FqxfQaWszGSDxKm48Sz4-2BJEfHNP1OkEWXNKBk2i7LYEoJNXGDQdWs4pp9Pay7yiR4Fs567jV5tl4XECWXjCsbEpT 1504 const OUStringLiteral XML_N_SVG_COMPAT(u"urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0"); 1505 const OUStringLiteral XML_N_FO(u"https://u15810271.ct.sendgrid.net/ls/click?upn=CTPegkVN6peWFCMEieYYmGddCe8wGYJVaRe7igkdO2XLI6htp92A2rsGR3zYeI3XSl5i_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi-2B4MXY6F0w8TVlVWTU6jHAHIBJfocAstr0ttGCGQ0tp2j2FlMJkwhOmhr2iuMvIDnQgcKeALk-2Fg9FvuMUnxWN25JMQEI8xnkHCyyu2eYCSBhcMiKO5M6Pm3pihmPCHiCMpOULOiGLyKf69-2Blh5TkJKe6s-2BWjWf8GiTFGNY-2B9AYdiii1YAb1FOTJNW3mfHDldD 1506 const OUStringLiteral XML_N_FO_COMPAT(u"urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0"); 1507 const OUStringLiteral XML_N_SMIL(u"https://u15810271.ct.sendgrid.net/ls/click?upn=CTPegkVN6peWFCMEieYYmA5FGwWkCOniUlZCORDq8ZvZTTztOU1bxWhU85CvVK4jGRtI_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi-2B4MXY6F0w8TVlVWTU6jHACZIz2XZsYsEajFVE6xfaMef3ONm78lbSsQc3AsNY9S4cu16Z1hTVNo9oTdPTwwiB-2Fw3IhB3BZvdpXDdIgDBHrI0CU1LmOsw9aU-2F8iGUwVl1162RX7tnT6dj2qWvccEx6MglkebJTGk5GuWEBhEfqvukGZlWCRYyGvnjxwJBG3WB ** CID 1470374:(STRAY_SEMICOLON) /basic/source/comp/buffer.cxx: 29 in ::write>>, unsigned char>(T1, T2)() /basic/source/comp/buffer.cxx: 29 in ::write>>, signed char>(T1, T2)() *** CID 1470374:(STRAY_SEMICOLON) /basic/source/comp/buffer.cxx: 29 in ::write>>, unsigned char>(T1, T2)() 23 { 24 const sal_uInt32 UP_LIMIT=0xFF00; 25 26 template void write(I it, T n) 27 { 28 *it = static_cast(n & 0xFF); >>> CID 1470374:(STRAY_SEMICOLON) >>> An "if" statement with no "then" or "else" is suspicious. 29 if constexpr (sizeof(n) > 1) 30 { 31 for (std::size_t i = 1; i < sizeof(n); ++i) 32 { 33 n >>= 8; 34 *++it = static_cast(n & 0xFF); /basic/source/comp/buffer.cxx: 29 in ::write>>, signed char>(T1, T2)() 23 { 24 const sal_uInt32 UP_LIMIT=0xFF00; 25 26 template void write(I it, T n) 27 { 28 *it = static_cast(n & 0xFF); >>> CID 1470374:(STRAY_SEMICOLON) >>> An "if" statement with no "then" or "else" is suspicious. 29 if constexpr (sizeof(n) > 1) 30 { 31 for (std::size_t i = 1; i < sizeof(n); ++i) 32 { 33 n >>= 8; 34 *++it = static_cast(n & 0xFF); ** CID 1470373: Incorrect expression (IDENTICAL_BRANCHES) /starmath/source/mathmlimport.cxx: 1400 in ::SmXMLOperatorContext_Impl::TCharacters(const rtl::OUString &)()
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1468697: Error handling issues (UNCAUGHT_EXCEPT) /include/vcl/embeddedfontshelper.hxx: 99 in EmbeddedFontsHelper::~EmbeddedFontsHelper()() *** CID 1468697: Error handling issues (UNCAUGHT_EXCEPT) /include/vcl/embeddedfontshelper.hxx: 99 in EmbeddedFontsHelper::~EmbeddedFontsHelper()() 93 /** 94 Removes all temporary fonts in the path used by fileUrlForTemporaryFont(). 95 @internal 96 */ 97 static void clearTemporaryFontFiles(); 98 >>> CID 1468697: Error handling issues (UNCAUGHT_EXCEPT) >>> An exception of type "com::sun::star::uno::RuntimeException" is thrown >>> but the throw list "noexcept" doesn't allow it to be thrown. This will >>> cause a call to unexpected() which usually calls terminate(). 99 ~EmbeddedFontsHelper() 100 { 101 activateFonts(); 102 } 103 }; 104 105 #endif 106 ** CID 1468696: Control flow issues (DEADCODE) /sc/source/core/tool/interpr1.cxx: 8225 in ScInterpreter::ScIndirect()() *** CID 1468696: Control flow issues (DEADCODE) /sc/source/core/tool/interpr1.cxx: 8225 in ScInterpreter::ScIndirect()() 8219 { 8220 nIndex = ScGlobal::FindUnquoted( sRefStr, '!'); 8221 if (nIndex >= 3 && sRefStr[nIndex-1] == '\'') 8222 { 8223 bExternalName = true; 8224 if (eConv == FormulaGrammar::CONV_OOO) >>> CID 1468696: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "eConv = formula::FormulaGra...". 8225 eConv = FormulaGrammar::CONV_XL_A1; 8226 } 8227 } 8228 } 8229 8230 } To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DYK2O_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJimRN9Xbga1fuQ5yx6ryj6NKApDnpHbewpFKN0jqtphBCMJ3Rq7M0OdWGHkBhhogEJJ1FZ2sEAEoXgiaBdQTcn2vU2nHPryBQ9eGtxNOU-2FGMJ9bmuZxXsaBS-2FpjKWeEy6VNkl56L3SdZJwyGcggvPyjDBPKlyvIIfoxzGvOqSMY8l-2BDYMYauEQ-2B4vF-2B3PyhUeO ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 2 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1468666: Possible Control flow issues (DEADCODE) /cui/source/options/optgdlg.cxx: 766 in OfaViewTabPage::UpdateSkiaStatus()() *** CID 1468666: Possible Control flow issues (DEADCODE) /cui/source/options/optgdlg.cxx: 766 in OfaViewTabPage::UpdateSkiaStatus()() 760 m_xSkiaStatusEnabled->hide(); 761 m_xSkiaStatusDisabled->hide(); 762 return; 763 } 764 765 // Easier than a custom translation string. >>> CID 1468666: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "bEnabled = SkiaHelper::isVC...". 766 bool bEnabled = SkiaHelper::isVCLSkiaEnabled(); 767 m_xSkiaStatusEnabled->set_visible(bEnabled); 768 m_xSkiaStatusDisabled->set_visible(!bEnabled); 769 770 // FIXME: should really add code to show a 'lock' icon here. 771 m_xUseSkia->set_sensitive(!officecfg::Office::Common::VCL::UseSkia::isReadOnly()); ** CID 1468665: Null pointer dereferences (FORWARD_NULL) *** CID 1468665: Null pointer dereferences (FORWARD_NULL) /sw/source/uibase/shells/textfld.cxx: 807 in SwTextShell::StateField(SfxItemSet &)() 801 else if ( !pPostItMgr->HasActiveSidebarWin() ) 802 { 803 rSet.InvalidateItem( FN_DELETE_COMMENT ); 804 rSet.InvalidateItem( FN_HIDE_NOTE ); 805 } 806 // tdf#137568 do not offer comment formating, if no comments are present >>> CID 1468665: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pPostItMgr" to "HasNotes", which dereferences it. 807 if ( !pPostItMgr->HasNotes() ) 808 rSet.DisableItem( FN_FORMAT_ALL_NOTES ); 809 } 810 break; 811 812 case FN_EDIT_FIELD: To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D2ZcC_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJieP-2F63v7J1-2F2QityukfF6pcaezW7fvxt5Yy4XXM9h0swqAkI-2BVdPvQ6YZaWuAZa8vwh4E1JZkJKIC8ltUBS3eDKy2adtP5HhBOBBEHDYVAmn7ZXmUBAiJjLqwOZv9wruJC8No2242WasWsHf9PJuwwhAGqFqjC3pY0J7sV3bOFAXasb7ZQ5mTxh-2BEfg-2BvM5Mo ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice