Re: [Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping
Hello Kohei, 2012/1/24 Kohei Yoshida kohei.yosh...@gmail.com: Hi there, I would like http://cgit.freedesktop.org/libreoffice/core/commit/?id=2c659e692a17cc10d364a2304bead9403fc6bdde to be backported to the 3-5 branch. It fixes https://bugs.freedesktop.org/show_bug.cgi?id=45067 Review and sign-off appreciated. Did you check with libreoffice 3-5? I think that eike's work for date patterns is missing in 3-5 so that this patch does reopen the bug we discussed on IRC. At least your unit test fails and I think we should check that before adding the patch to 3-5. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping
Hi, On Tuesday, 2012-01-24 11:42:57 +0100, Markus Mohrhard wrote: Did you check with libreoffice 3-5? I think that eike's work for date patterns is missing in 3-5 Yes, that's only on master. so that this patch does reopen the bug we discussed on IRC. At least your unit test fails and I think we should check that before adding the patch to 3-5. Relying on date patterns sounds very fragile, they vary between locales and may change at any time. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgp80WFH7OTZ0.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping
On Tue, 2012-01-24 at 12:24 +0100, Eike Rathke wrote: Hi, On Tuesday, 2012-01-24 11:42:57 +0100, Markus Mohrhard wrote: Did you check with libreoffice 3-5? I think that eike's work for date patterns is missing in 3-5 Yes, that's only on master. so that this patch does reopen the bug we discussed on IRC. At least your unit test fails and I think we should check that before adding the patch to 3-5. Relying on date patterns sounds very fragile, they vary between locales and may change at any time. Sure, but that's how it used to work. It's fragile, yes, but to fix it properly we'd have to make more invasive changes, and definitely not for 3.5. -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
