[Bug 160462] F10 key is marked reserved, but doesn't do anything (kf5, gtk3)

2024-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160462

--- Comment #6 from Buovjaga  ---
F10 does move the focus to the first menu on Windows as well (so you can hit
Down arrow to open the menu).

Somewhat interesting is this handling of alternate keycodes found only in gen
and gtk3 plugins:
https://opengrok.libreoffice.org/xref/core/vcl/unx/generic/window/salframe.cxx?r=10831c8b#2613
https://opengrok.libreoffice.org/xref/core/vcl/unx/gtk3/gtkframe.cxx?r=bee080ab#337

// F10 means either KEY_F10 or KEY_MENU, which has to be decided
// in the independent part.

This leads to the way more interesting
https://opengrok.libreoffice.org/xref/core/vcl/source/window/menubarwindow.cxx?r=f0977206#750

if ( nCode == KEY_MENU && !rKEvent.GetKeyCode().IsShift() ) // only F10, not
Shift-F10
{
mbAutoPopup = false;
if ( m_nHighlightedItem == ITEMPOS_INVALID )
{
ChangeHighlightItem( 0, false );
GrabFocus();
}
else
{
ChangeHighlightItem( ITEMPOS_INVALID, false );
m_xSaveFocusId = nullptr;
}
bDone = true;
}

and another special case:
https://opengrok.libreoffice.org/xref/core/vcl/source/window/menufloatingwindow.cxx?r=f0977206#1144

Then there is this for Windows:
https://opengrok.libreoffice.org/xref/core/vcl/win/window/salframe.cxx?r=d4a110f8#5130
// Process here KeyMenu events only for Alt to activate the MenuBar

Indeed, Left Alt on Windows acts just like F10 in that it moves the focus into
the first menu.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160462] F10 key is marked reserved, but doesn't do anything (kf5, gtk3)

2024-05-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160462

Buovjaga  changed:

   What|Removed |Added

 Blocks||102495

--- Comment #5 from Buovjaga  ---
F10 opens the first menu for me with gtk3. With gen, it moves the focus there,
but doesn't open. With kf5/kf6, it seems this never worked (tested with 7.0).

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 98142886f21e40d0f7052f18108d9586f4b2fbc5
CPU threads: 8; OS: Linux 6.8; UI render: default; VCL: kf6 (cairo+wayland)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
[Bug 102495] [META] KDE (kf5) VCL backend bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160462] F10 key is marked reserved, but doesn't do anything (kf5, gtk3)

2024-05-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160462

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
Summary|F10 key is marked reserved, |F10 key is marked reserved,
   |but doesn't do anything |but doesn't do anything
   ||(kf5, gtk3)
 Blocks||98259
  Component|Writer  |LibreOffice
 Status|UNCONFIRMED |NEW
Version|7.6.5.2 release |6.2.0.3 release
 CC||ilmari.lauhakangas@libreoff
   ||ice.org,
   ||stephane.guillou@libreoffic
   ||e.org

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Ilmari recently clarified reserved shortcuts with:

commit  e1c59fd539222973410dc6adcb8eac4abeeb9e6a
author  Ilmari Lauhakangas Tue Apr 23 14:02:00 2024 +0300
committer   Ilmari Lauhakangas Thu Apr 25 11:01:17 2024 +0200
Improve documentation on reserved shortcuts

For F10 we now have:

vcl::KeyCode(KEY_F10,0) // Activate the first menu

...which matches the Help:
https://help.libreoffice.org/latest/en-US/text/shared/04/0101.html

But it's true that for me, F10 does not do anything in a recent daily build:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 658a212585c56540a17c4e6829716d4ef4e3
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

... and already in 6.2.0.3 (gtk3 as well).

It used to work with the gtk2 VCL plugin, e.g. in:

Version: 6.1.0.3
Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk2; 
Locale: en-AU (en_AU.UTF-8); Calc: group threaded

And still works with gen.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
[Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.