Re: [PATCH]staging "vme" Fix typos.
On 13/08/12 16:58, Justin P. Mattock wrote: > From: "Justin P. Mattock" > > Signed-off-by: Justin P. Mattock > > --- > > The below patch fixes typos found while reading through staging "vme" > > drivers/staging/vme/devices/Kconfig|2 +- > drivers/staging/vme/devices/vme_user.c |6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/vme/devices/Kconfig > b/drivers/staging/vme/devices/Kconfig > index d0cab17..5504ab4 100644 > --- a/drivers/staging/vme/devices/Kconfig > +++ b/drivers/staging/vme/devices/Kconfig > @@ -5,7 +5,7 @@ config VME_USER > depends on STAGING > help > If you say Y here you want to be able to access a limited number of > - VME windows in a manner at least semi-compatible with the interface > + VME windows in a manner atleast semi-compatible with the interface Um, are you sure? I don't think "atleast" is a word. > provided with the original driver at http://vmelinux.org/. > > config VME_PIO2 > diff --git a/drivers/staging/vme/devices/vme_user.c > b/drivers/staging/vme/devices/vme_user.c > index e25645e..46f60d6 100644 > --- a/drivers/staging/vme/devices/vme_user.c > +++ b/drivers/staging/vme/devices/vme_user.c > @@ -64,12 +64,12 @@ static unsigned int bus_num; > * > * However the VME driver at http://www.vmelinux.org/ is rather old and > doesn't > * even support the tsi148 chipset (which has 8 master and 8 slave windows). > - * We'll run with this or now as far as possible, however it probably makes > + * We'll run with this for now as far as possible, however it probably makes > * sense to get rid of the old mappings and just do everything dynamically. > * > * So for now, we'll restrict the driver to providing 4 masters and 4 slaves > as > * defined above and try to support at least some of the interface from > - * http://www.vmelinux.org/ as an alternative drive can be written providing > a > + * http://www.vmelinux.org/ as an alternative the driver can be written > providing a Sorry, but you'll have to wrap the line here. The comment now extends beyond 80 characters. > * saner interface later. > * > * The vmelinux.org driver never supported slave images, the devices reserved > @@ -242,7 +242,7 @@ static ssize_t resource_to_user(int minor, char __user > *buf, size_t count, > } > > /* > - * We are going ot alloc a page during init per window for small transfers. > + * We are going to alloc a page during init per window for small transfers. Yup - that's OK. Care to fix up the issues above? Martyn > * Small transfers will go user space -> buffer -> VME. Larger (more than a > * page) transfers will lock the user space buffer into memory and then > * transfer the data directly from the user space buffers out to VME. > -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E martyn.we...@ge.com | VAT:GB 927559189 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH]staging "vme" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging "vme" drivers/staging/vme/devices/Kconfig|2 +- drivers/staging/vme/devices/vme_user.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vme/devices/Kconfig b/drivers/staging/vme/devices/Kconfig index d0cab17..5504ab4 100644 --- a/drivers/staging/vme/devices/Kconfig +++ b/drivers/staging/vme/devices/Kconfig @@ -5,7 +5,7 @@ config VME_USER depends on STAGING help If you say Y here you want to be able to access a limited number of - VME windows in a manner at least semi-compatible with the interface + VME windows in a manner atleast semi-compatible with the interface provided with the original driver at http://vmelinux.org/. config VME_PIO2 diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index e25645e..46f60d6 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers/staging/vme/devices/vme_user.c @@ -64,12 +64,12 @@ static unsigned int bus_num; * * However the VME driver at http://www.vmelinux.org/ is rather old and doesn't * even support the tsi148 chipset (which has 8 master and 8 slave windows). - * We'll run with this or now as far as possible, however it probably makes + * We'll run with this for now as far as possible, however it probably makes * sense to get rid of the old mappings and just do everything dynamically. * * So for now, we'll restrict the driver to providing 4 masters and 4 slaves as * defined above and try to support at least some of the interface from - * http://www.vmelinux.org/ as an alternative drive can be written providing a + * http://www.vmelinux.org/ as an alternative the driver can be written providing a * saner interface later. * * The vmelinux.org driver never supported slave images, the devices reserved @@ -242,7 +242,7 @@ static ssize_t resource_to_user(int minor, char __user *buf, size_t count, } /* - * We are going ot alloc a page during init per window for small transfers. + * We are going to alloc a page during init per window for small transfers. * Small transfers will go user space -> buffer -> VME. Larger (more than a * page) transfers will lock the user space buffer into memory and then * transfer the data directly from the user space buffers out to VME. -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH]staging vme Fix typos.
From: Justin P. Mattock justinmatt...@gmail.com Signed-off-by: Justin P. Mattock justinmatt...@gmail.com --- The below patch fixes typos found while reading through staging vme drivers/staging/vme/devices/Kconfig|2 +- drivers/staging/vme/devices/vme_user.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vme/devices/Kconfig b/drivers/staging/vme/devices/Kconfig index d0cab17..5504ab4 100644 --- a/drivers/staging/vme/devices/Kconfig +++ b/drivers/staging/vme/devices/Kconfig @@ -5,7 +5,7 @@ config VME_USER depends on STAGING help If you say Y here you want to be able to access a limited number of - VME windows in a manner at least semi-compatible with the interface + VME windows in a manner atleast semi-compatible with the interface provided with the original driver at http://vmelinux.org/. config VME_PIO2 diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index e25645e..46f60d6 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers/staging/vme/devices/vme_user.c @@ -64,12 +64,12 @@ static unsigned int bus_num; * * However the VME driver at http://www.vmelinux.org/ is rather old and doesn't * even support the tsi148 chipset (which has 8 master and 8 slave windows). - * We'll run with this or now as far as possible, however it probably makes + * We'll run with this for now as far as possible, however it probably makes * sense to get rid of the old mappings and just do everything dynamically. * * So for now, we'll restrict the driver to providing 4 masters and 4 slaves as * defined above and try to support at least some of the interface from - * http://www.vmelinux.org/ as an alternative drive can be written providing a + * http://www.vmelinux.org/ as an alternative the driver can be written providing a * saner interface later. * * The vmelinux.org driver never supported slave images, the devices reserved @@ -242,7 +242,7 @@ static ssize_t resource_to_user(int minor, char __user *buf, size_t count, } /* - * We are going ot alloc a page during init per window for small transfers. + * We are going to alloc a page during init per window for small transfers. * Small transfers will go user space - buffer - VME. Larger (more than a * page) transfers will lock the user space buffer into memory and then * transfer the data directly from the user space buffers out to VME. -- 1.7.5.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH]staging vme Fix typos.
On 13/08/12 16:58, Justin P. Mattock wrote: From: Justin P. Mattock justinmatt...@gmail.com Signed-off-by: Justin P. Mattock justinmatt...@gmail.com --- The below patch fixes typos found while reading through staging vme drivers/staging/vme/devices/Kconfig|2 +- drivers/staging/vme/devices/vme_user.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vme/devices/Kconfig b/drivers/staging/vme/devices/Kconfig index d0cab17..5504ab4 100644 --- a/drivers/staging/vme/devices/Kconfig +++ b/drivers/staging/vme/devices/Kconfig @@ -5,7 +5,7 @@ config VME_USER depends on STAGING help If you say Y here you want to be able to access a limited number of - VME windows in a manner at least semi-compatible with the interface + VME windows in a manner atleast semi-compatible with the interface Um, are you sure? I don't think atleast is a word. provided with the original driver at http://vmelinux.org/. config VME_PIO2 diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index e25645e..46f60d6 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers/staging/vme/devices/vme_user.c @@ -64,12 +64,12 @@ static unsigned int bus_num; * * However the VME driver at http://www.vmelinux.org/ is rather old and doesn't * even support the tsi148 chipset (which has 8 master and 8 slave windows). - * We'll run with this or now as far as possible, however it probably makes + * We'll run with this for now as far as possible, however it probably makes * sense to get rid of the old mappings and just do everything dynamically. * * So for now, we'll restrict the driver to providing 4 masters and 4 slaves as * defined above and try to support at least some of the interface from - * http://www.vmelinux.org/ as an alternative drive can be written providing a + * http://www.vmelinux.org/ as an alternative the driver can be written providing a Sorry, but you'll have to wrap the line here. The comment now extends beyond 80 characters. * saner interface later. * * The vmelinux.org driver never supported slave images, the devices reserved @@ -242,7 +242,7 @@ static ssize_t resource_to_user(int minor, char __user *buf, size_t count, } /* - * We are going ot alloc a page during init per window for small transfers. + * We are going to alloc a page during init per window for small transfers. Yup - that's OK. Care to fix up the issues above? Martyn * Small transfers will go user space - buffer - VME. Larger (more than a * page) transfers will lock the user space buffer into memory and then * transfer the data directly from the user space buffers out to VME. -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E martyn.we...@ge.com | VAT:GB 927559189 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
