Re: [PATCH 09/24] elevate mnt writers for callers of vfs_mkdir()

2007-09-19 Thread Christoph Hellwig
On Mon, Sep 17, 2007 at 11:27:29AM -0700, Dave Hansen wrote:
> 
> Pretty self-explanatory.  Fits in with the rest of the series.

Ok.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 09/24] elevate mnt writers for callers of vfs_mkdir()

2007-09-19 Thread Christoph Hellwig
On Mon, Sep 17, 2007 at 11:27:29AM -0700, Dave Hansen wrote:
 
 Pretty self-explanatory.  Fits in with the rest of the series.

Ok.

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 09/24] elevate mnt writers for callers of vfs_mkdir()

2007-09-17 Thread Dave Hansen

Pretty self-explanatory.  Fits in with the rest of the series.

Signed-off-by: Dave Hansen <[EMAIL PROTECTED]>
---

 lxc-dave/fs/namei.c|5 +
 lxc-dave/fs/nfsd/nfs4recover.c |4 
 2 files changed, 9 insertions(+)

diff -puN fs/namei.c~elevate-mnt-writers-for-callers-of-vfs-mkdir fs/namei.c
--- lxc/fs/namei.c~elevate-mnt-writers-for-callers-of-vfs-mkdir 2007-09-17 
09:44:01.0 -0700
+++ lxc-dave/fs/namei.c 2007-09-17 09:44:01.0 -0700
@@ -2051,7 +2051,12 @@ asmlinkage long sys_mkdirat(int dfd, con
 
if (!IS_POSIXACL(nd.dentry->d_inode))
mode &= ~current->fs->umask;
+   error = mnt_want_write(nd.mnt);
+   if (error)
+   goto out_dput;
error = vfs_mkdir(nd.dentry->d_inode, dentry, mode);
+   mnt_drop_write(nd.mnt);
+out_dput:
dput(dentry);
 out_unlock:
mutex_unlock(>d_inode->i_mutex);
diff -puN fs/nfsd/nfs4recover.c~elevate-mnt-writers-for-callers-of-vfs-mkdir 
fs/nfsd/nfs4recover.c
--- lxc/fs/nfsd/nfs4recover.c~elevate-mnt-writers-for-callers-of-vfs-mkdir  
2007-09-17 09:44:01.0 -0700
+++ lxc-dave/fs/nfsd/nfs4recover.c  2007-09-17 09:44:01.0 -0700
@@ -156,7 +156,11 @@ nfsd4_create_clid_dir(struct nfs4_client
dprintk("NFSD: nfsd4_create_clid_dir: DIRECTORY EXISTS\n");
goto out_put;
}
+   status = mnt_want_write(rec_dir.mnt);
+   if (status)
+   goto out_put;
status = vfs_mkdir(rec_dir.dentry->d_inode, dentry, S_IRWXU);
+   mnt_drop_write(rec_dir.mnt);
 out_put:
dput(dentry);
 out_unlock:
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 09/24] elevate mnt writers for callers of vfs_mkdir()

2007-09-17 Thread Dave Hansen

Pretty self-explanatory.  Fits in with the rest of the series.

Signed-off-by: Dave Hansen [EMAIL PROTECTED]
---

 lxc-dave/fs/namei.c|5 +
 lxc-dave/fs/nfsd/nfs4recover.c |4 
 2 files changed, 9 insertions(+)

diff -puN fs/namei.c~elevate-mnt-writers-for-callers-of-vfs-mkdir fs/namei.c
--- lxc/fs/namei.c~elevate-mnt-writers-for-callers-of-vfs-mkdir 2007-09-17 
09:44:01.0 -0700
+++ lxc-dave/fs/namei.c 2007-09-17 09:44:01.0 -0700
@@ -2051,7 +2051,12 @@ asmlinkage long sys_mkdirat(int dfd, con
 
if (!IS_POSIXACL(nd.dentry-d_inode))
mode = ~current-fs-umask;
+   error = mnt_want_write(nd.mnt);
+   if (error)
+   goto out_dput;
error = vfs_mkdir(nd.dentry-d_inode, dentry, mode);
+   mnt_drop_write(nd.mnt);
+out_dput:
dput(dentry);
 out_unlock:
mutex_unlock(nd.dentry-d_inode-i_mutex);
diff -puN fs/nfsd/nfs4recover.c~elevate-mnt-writers-for-callers-of-vfs-mkdir 
fs/nfsd/nfs4recover.c
--- lxc/fs/nfsd/nfs4recover.c~elevate-mnt-writers-for-callers-of-vfs-mkdir  
2007-09-17 09:44:01.0 -0700
+++ lxc-dave/fs/nfsd/nfs4recover.c  2007-09-17 09:44:01.0 -0700
@@ -156,7 +156,11 @@ nfsd4_create_clid_dir(struct nfs4_client
dprintk(NFSD: nfsd4_create_clid_dir: DIRECTORY EXISTS\n);
goto out_put;
}
+   status = mnt_want_write(rec_dir.mnt);
+   if (status)
+   goto out_put;
status = vfs_mkdir(rec_dir.dentry-d_inode, dentry, S_IRWXU);
+   mnt_drop_write(rec_dir.mnt);
 out_put:
dput(dentry);
 out_unlock:
_
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/