Re: [PATCH NEXT]staging "tidspbridge" Fix typos.
On 07/23/2012 01:44 PM, Ramirez Luna, Omar wrote: Hi Justin, On Mon, Jul 23, 2012 at 8:49 AM, Justin P. Mattock wrote: diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c b/drivers/staging/tidspbridge/core/tiomap3430.c index f9609ce..2c82d5a 100644 --- a/drivers/staging/tidspbridge/core/tiomap3430.c +++ b/drivers/staging/tidspbridge/core/tiomap3430.c @@ -328,7 +328,7 @@ static int bridge_brd_read(struct bridge_dev_context *dev_ctxt, ul_num_bytes, mem_type); return status; } - /* copy the data from DSP memory, */ + /* copy the data from DSP memory, */ I guess we can get rid of the comma (,) at the end of this sentence. good catch! ... diff --git a/drivers/staging/tidspbridge/include/dspbridge/proc.h b/drivers/staging/tidspbridge/include/dspbridge/proc.h index a82380e..9cd5022 100644 --- a/drivers/staging/tidspbridge/include/dspbridge/proc.h +++ b/drivers/staging/tidspbridge/include/dspbridge/proc.h @@ -263,7 +263,7 @@ extern int proc_get_processor_id(void *proc, u32 * proc_id); * Returns: * 0 : Success. * -EFAULT : Invalid processor handle. - * -EPERM : General failure while retireving processor trace + * -EPERM : General failure while retireing processor trace This was meant to be 'retrieving'. And given that this is focused on tidspbridge, could you change the patch subject? To: staging: tidspbridge: fix typos. Cheers, Omar ah.. I see now.. comments can be tough to decipher sometimes with what the writer is saying, helps to know what the code is doing. cheers, resending the revised version, and Thank you for taking the time. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH NEXT]staging "tidspbridge" Fix typos.
Hi Justin, On Mon, Jul 23, 2012 at 8:49 AM, Justin P. Mattock wrote: > diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c > b/drivers/staging/tidspbridge/core/tiomap3430.c > index f9609ce..2c82d5a 100644 > --- a/drivers/staging/tidspbridge/core/tiomap3430.c > +++ b/drivers/staging/tidspbridge/core/tiomap3430.c > @@ -328,7 +328,7 @@ static int bridge_brd_read(struct bridge_dev_context > *dev_ctxt, >ul_num_bytes, mem_type); > return status; > } > - /* copy the data from DSP memory, */ > + /* copy the data from DSP memory, */ I guess we can get rid of the comma (,) at the end of this sentence. ... > diff --git a/drivers/staging/tidspbridge/include/dspbridge/proc.h > b/drivers/staging/tidspbridge/include/dspbridge/proc.h > index a82380e..9cd5022 100644 > --- a/drivers/staging/tidspbridge/include/dspbridge/proc.h > +++ b/drivers/staging/tidspbridge/include/dspbridge/proc.h > @@ -263,7 +263,7 @@ extern int proc_get_processor_id(void *proc, u32 * > proc_id); > * Returns: > * 0 : Success. > * -EFAULT : Invalid processor handle. > - * -EPERM : General failure while retireving processor trace > + * -EPERM : General failure while retireing processor trace This was meant to be 'retrieving'. And given that this is focused on tidspbridge, could you change the patch subject? To: staging: tidspbridge: fix typos. Cheers, Omar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH NEXT]staging "tidspbridge" Fix typos.
From: "Justin P. Mattock"
Signed-off-by: Justin P. Mattock
---
The below patch fixes some typos found while reading through staging
"tidspbridge".
.../staging/tidspbridge/Documentation/error-codes |2 +-
drivers/staging/tidspbridge/core/_tiomap.h |2 +-
drivers/staging/tidspbridge/core/chnl_sm.c |6 +++---
drivers/staging/tidspbridge/core/io_sm.c | 10 +-
drivers/staging/tidspbridge/core/sync.c|2 +-
drivers/staging/tidspbridge/core/tiomap3430.c |4 ++--
drivers/staging/tidspbridge/core/tiomap3430_pwr.c |2 +-
drivers/staging/tidspbridge/dynload/tramp.c|8
drivers/staging/tidspbridge/hw/hw_mmu.c|6 +++---
.../tidspbridge/include/dspbridge/dspioctl.h |2 +-
.../staging/tidspbridge/include/dspbridge/mbx_sh.h |2 +-
.../staging/tidspbridge/include/dspbridge/node.h |2 +-
.../staging/tidspbridge/include/dspbridge/ntfy.h |2 +-
.../staging/tidspbridge/include/dspbridge/proc.h |2 +-
.../staging/tidspbridge/include/dspbridge/strm.h |2 +-
.../staging/tidspbridge/include/dspbridge/sync.h |4 ++--
drivers/staging/tidspbridge/rmgr/dbdcd.c |2 +-
drivers/staging/tidspbridge/rmgr/dspdrv.c |4 ++--
drivers/staging/tidspbridge/rmgr/mgr.c |4 ++--
drivers/staging/tidspbridge/rmgr/nldr.c|2 +-
drivers/staging/tidspbridge/rmgr/node.c|2 +-
drivers/staging/tidspbridge/rmgr/proc.c|2 +-
22 files changed, 37 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/tidspbridge/Documentation/error-codes
b/drivers/staging/tidspbridge/Documentation/error-codes
index 12826e2..ad73cba 100644
--- a/drivers/staging/tidspbridge/Documentation/error-codes
+++ b/drivers/staging/tidspbridge/Documentation/error-codes
@@ -69,7 +69,7 @@ The error codes used by this driver are:
Invalid pointer or handler.
[EEXIST]
-Attempted to create a channel manager when one already exists.
+Attempted to create a channel manager when one already exists.
[EINVAL]
Invalid argument.
diff --git a/drivers/staging/tidspbridge/core/_tiomap.h
b/drivers/staging/tidspbridge/core/_tiomap.h
index 7cb5871..543a127 100644
--- a/drivers/staging/tidspbridge/core/_tiomap.h
+++ b/drivers/staging/tidspbridge/core/_tiomap.h
@@ -219,7 +219,7 @@ static const struct map_l4_peripheral l4_peripheral_table[]
= {
/* MBX_PM_MAX_RESOURCES: CORE 2 Clock Resources. */
#define MBX_CORE2_RESOURCES 1
-/* MBX_PM_MAX_RESOURCES: TOTAL Clock Reosurces. */
+/* MBX_PM_MAX_RESOURCES: TOTAL Clock Resources. */
#define MBX_PM_MAX_RESOURCES 11
/* Power Management Commands */
diff --git a/drivers/staging/tidspbridge/core/chnl_sm.c
b/drivers/staging/tidspbridge/core/chnl_sm.c
index e0c7e4c..f38950e 100644
--- a/drivers/staging/tidspbridge/core/chnl_sm.c
+++ b/drivers/staging/tidspbridge/core/chnl_sm.c
@@ -20,7 +20,7 @@
* The lower edge functions must be implemented by the Bridge driver
* writer, and are declared in chnl_sm.h.
*
- * Care is taken in this code to prevent simulataneous access to channel
+ * Care is taken in this code to prevent simultaneous access to channel
* queues from
* 1. Threads.
* 2. io_dpc(), scheduled from the io_isr() as an event.
@@ -34,7 +34,7 @@
* Channel Invariant:
* There is an important invariant condition which must be maintained per
* channel outside of bridge_chnl_get_ioc() and IO_Dispatch(), violation
of
- * which may cause timeouts and/or failure offunction sync_wait_on_event.
+ * which may cause timeouts and/or failure of function sync_wait_on_event.
* This invariant condition is:
*
* list_empty(>io_completions) ==> pchnl->sync_event is reset
@@ -602,7 +602,7 @@ int bridge_chnl_get_ioc(struct chnl_object *chnl_obj, u32
timeout,
/* Since DSPStream_Reclaim() does not take a timeout
* parameter, we pass the stream's timeout value to
* bridge_chnl_get_ioc. We cannot determine whether or not
-* we have waited in User mode. Since the stream's timeout
+* we have waited in user mode. Since the stream's timeout
* value may be non-zero, we still have to set the event.
* Therefore, this optimization is taken out.
*
diff --git a/drivers/staging/tidspbridge/core/io_sm.c
b/drivers/staging/tidspbridge/core/io_sm.c
index 480a384..e322fb7 100644
--- a/drivers/staging/tidspbridge/core/io_sm.c
+++ b/drivers/staging/tidspbridge/core/io_sm.c
@@ -837,8 +837,8 @@ static void io_dispatch_pm(struct io_mgr *pio_mgr)
/*
* io_dpc
* Deferred procedure call for shared memory channel driver ISR. Carries
- * out the dispatch of I/O as a non-preemptible event.It can only be
- * pre-empted by an ISR.
+ * out the dispatch
[PATCH NEXT]staging tidspbridge Fix typos.
From: Justin P. Mattock justinmatt...@gmail.com
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
The below patch fixes some typos found while reading through staging
tidspbridge.
.../staging/tidspbridge/Documentation/error-codes |2 +-
drivers/staging/tidspbridge/core/_tiomap.h |2 +-
drivers/staging/tidspbridge/core/chnl_sm.c |6 +++---
drivers/staging/tidspbridge/core/io_sm.c | 10 +-
drivers/staging/tidspbridge/core/sync.c|2 +-
drivers/staging/tidspbridge/core/tiomap3430.c |4 ++--
drivers/staging/tidspbridge/core/tiomap3430_pwr.c |2 +-
drivers/staging/tidspbridge/dynload/tramp.c|8
drivers/staging/tidspbridge/hw/hw_mmu.c|6 +++---
.../tidspbridge/include/dspbridge/dspioctl.h |2 +-
.../staging/tidspbridge/include/dspbridge/mbx_sh.h |2 +-
.../staging/tidspbridge/include/dspbridge/node.h |2 +-
.../staging/tidspbridge/include/dspbridge/ntfy.h |2 +-
.../staging/tidspbridge/include/dspbridge/proc.h |2 +-
.../staging/tidspbridge/include/dspbridge/strm.h |2 +-
.../staging/tidspbridge/include/dspbridge/sync.h |4 ++--
drivers/staging/tidspbridge/rmgr/dbdcd.c |2 +-
drivers/staging/tidspbridge/rmgr/dspdrv.c |4 ++--
drivers/staging/tidspbridge/rmgr/mgr.c |4 ++--
drivers/staging/tidspbridge/rmgr/nldr.c|2 +-
drivers/staging/tidspbridge/rmgr/node.c|2 +-
drivers/staging/tidspbridge/rmgr/proc.c|2 +-
22 files changed, 37 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/tidspbridge/Documentation/error-codes
b/drivers/staging/tidspbridge/Documentation/error-codes
index 12826e2..ad73cba 100644
--- a/drivers/staging/tidspbridge/Documentation/error-codes
+++ b/drivers/staging/tidspbridge/Documentation/error-codes
@@ -69,7 +69,7 @@ The error codes used by this driver are:
Invalid pointer or handler.
[EEXIST]
-Attempted to create a channel manager when one already exists.
+Attempted to create a channel manager when one already exists.
[EINVAL]
Invalid argument.
diff --git a/drivers/staging/tidspbridge/core/_tiomap.h
b/drivers/staging/tidspbridge/core/_tiomap.h
index 7cb5871..543a127 100644
--- a/drivers/staging/tidspbridge/core/_tiomap.h
+++ b/drivers/staging/tidspbridge/core/_tiomap.h
@@ -219,7 +219,7 @@ static const struct map_l4_peripheral l4_peripheral_table[]
= {
/* MBX_PM_MAX_RESOURCES: CORE 2 Clock Resources. */
#define MBX_CORE2_RESOURCES 1
-/* MBX_PM_MAX_RESOURCES: TOTAL Clock Reosurces. */
+/* MBX_PM_MAX_RESOURCES: TOTAL Clock Resources. */
#define MBX_PM_MAX_RESOURCES 11
/* Power Management Commands */
diff --git a/drivers/staging/tidspbridge/core/chnl_sm.c
b/drivers/staging/tidspbridge/core/chnl_sm.c
index e0c7e4c..f38950e 100644
--- a/drivers/staging/tidspbridge/core/chnl_sm.c
+++ b/drivers/staging/tidspbridge/core/chnl_sm.c
@@ -20,7 +20,7 @@
* The lower edge functions must be implemented by the Bridge driver
* writer, and are declared in chnl_sm.h.
*
- * Care is taken in this code to prevent simulataneous access to channel
+ * Care is taken in this code to prevent simultaneous access to channel
* queues from
* 1. Threads.
* 2. io_dpc(), scheduled from the io_isr() as an event.
@@ -34,7 +34,7 @@
* Channel Invariant:
* There is an important invariant condition which must be maintained per
* channel outside of bridge_chnl_get_ioc() and IO_Dispatch(), violation
of
- * which may cause timeouts and/or failure offunction sync_wait_on_event.
+ * which may cause timeouts and/or failure of function sync_wait_on_event.
* This invariant condition is:
*
* list_empty(pchnl-io_completions) == pchnl-sync_event is reset
@@ -602,7 +602,7 @@ int bridge_chnl_get_ioc(struct chnl_object *chnl_obj, u32
timeout,
/* Since DSPStream_Reclaim() does not take a timeout
* parameter, we pass the stream's timeout value to
* bridge_chnl_get_ioc. We cannot determine whether or not
-* we have waited in User mode. Since the stream's timeout
+* we have waited in user mode. Since the stream's timeout
* value may be non-zero, we still have to set the event.
* Therefore, this optimization is taken out.
*
diff --git a/drivers/staging/tidspbridge/core/io_sm.c
b/drivers/staging/tidspbridge/core/io_sm.c
index 480a384..e322fb7 100644
--- a/drivers/staging/tidspbridge/core/io_sm.c
+++ b/drivers/staging/tidspbridge/core/io_sm.c
@@ -837,8 +837,8 @@ static void io_dispatch_pm(struct io_mgr *pio_mgr)
/*
* io_dpc
* Deferred procedure call for shared memory channel driver ISR. Carries
- * out the dispatch of I/O as a non-preemptible event.It can only be
- *
Re: [PATCH NEXT]staging tidspbridge Fix typos.
Hi Justin, On Mon, Jul 23, 2012 at 8:49 AM, Justin P. Mattock justinmatt...@gmail.com wrote: diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c b/drivers/staging/tidspbridge/core/tiomap3430.c index f9609ce..2c82d5a 100644 --- a/drivers/staging/tidspbridge/core/tiomap3430.c +++ b/drivers/staging/tidspbridge/core/tiomap3430.c @@ -328,7 +328,7 @@ static int bridge_brd_read(struct bridge_dev_context *dev_ctxt, ul_num_bytes, mem_type); return status; } - /* copy the data from DSP memory, */ + /* copy the data from DSP memory, */ I guess we can get rid of the comma (,) at the end of this sentence. ... diff --git a/drivers/staging/tidspbridge/include/dspbridge/proc.h b/drivers/staging/tidspbridge/include/dspbridge/proc.h index a82380e..9cd5022 100644 --- a/drivers/staging/tidspbridge/include/dspbridge/proc.h +++ b/drivers/staging/tidspbridge/include/dspbridge/proc.h @@ -263,7 +263,7 @@ extern int proc_get_processor_id(void *proc, u32 * proc_id); * Returns: * 0 : Success. * -EFAULT : Invalid processor handle. - * -EPERM : General failure while retireving processor trace + * -EPERM : General failure while retireing processor trace This was meant to be 'retrieving'. And given that this is focused on tidspbridge, could you change the patch subject? To: staging: tidspbridge: fix typos. Cheers, Omar -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH NEXT]staging tidspbridge Fix typos.
On 07/23/2012 01:44 PM, Ramirez Luna, Omar wrote: Hi Justin, On Mon, Jul 23, 2012 at 8:49 AM, Justin P. Mattock justinmatt...@gmail.com wrote: diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c b/drivers/staging/tidspbridge/core/tiomap3430.c index f9609ce..2c82d5a 100644 --- a/drivers/staging/tidspbridge/core/tiomap3430.c +++ b/drivers/staging/tidspbridge/core/tiomap3430.c @@ -328,7 +328,7 @@ static int bridge_brd_read(struct bridge_dev_context *dev_ctxt, ul_num_bytes, mem_type); return status; } - /* copy the data from DSP memory, */ + /* copy the data from DSP memory, */ I guess we can get rid of the comma (,) at the end of this sentence. good catch! ... diff --git a/drivers/staging/tidspbridge/include/dspbridge/proc.h b/drivers/staging/tidspbridge/include/dspbridge/proc.h index a82380e..9cd5022 100644 --- a/drivers/staging/tidspbridge/include/dspbridge/proc.h +++ b/drivers/staging/tidspbridge/include/dspbridge/proc.h @@ -263,7 +263,7 @@ extern int proc_get_processor_id(void *proc, u32 * proc_id); * Returns: * 0 : Success. * -EFAULT : Invalid processor handle. - * -EPERM : General failure while retireving processor trace + * -EPERM : General failure while retireing processor trace This was meant to be 'retrieving'. And given that this is focused on tidspbridge, could you change the patch subject? To: staging: tidspbridge: fix typos. Cheers, Omar ah.. I see now.. comments can be tough to decipher sometimes with what the writer is saying, helps to know what the code is doing. cheers, resending the revised version, and Thank you for taking the time. Justin P. Mattock -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
