Re: [PATCH net-next 09/10] selftests: forwarding: router_mpath_nh_res: Add a diagram

2024-04-15 Thread Hangbin Liu
On Fri, Apr 12, 2024 at 07:03:12PM +0200, Petr Machata wrote:
> This test lacks a topology diagram, making the setup not obvious.
> Add one.
> 
> Signed-off-by: Petr Machata 
> ---
>  .../net/forwarding/router_mpath_nh_res.sh | 35 +++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/forwarding/router_mpath_nh_res.sh 
> b/tools/testing/selftests/net/forwarding/router_mpath_nh_res.sh
> index 4b483d24ad00..cd9e346436fc 100755
> --- a/tools/testing/selftests/net/forwarding/router_mpath_nh_res.sh
> +++ b/tools/testing/selftests/net/forwarding/router_mpath_nh_res.sh
> @@ -1,6 +1,41 @@
>  #!/bin/bash
>  # SPDX-License-Identifier: GPL-2.0
>  
> +# +-+
> +# |  H1 |
> +# |   $h1 + |
> +# |  192.0.2.2/24 | |
> +# |  2001:db8:1::2/64 | |
> +# +---|-+
> +# |
> +# +---|--+
> +# |   |   R1 |
> +# | $rp11 +  |
> +# |  192.0.2.1/24|
> +# |  2001:db8:1::1/64|
> +# |  |
> +# |  + $rp12  + $rp13|
> +# |  | 169.254.2.12/24| 169.254.3.13/24  |
> +# |  | fe80:2::12/64  | fe80:3::13/64|
> +# +--||--+
> +#||
> +# +--||--+
> +# |  + $rp22  + $rp23|
> +# |169.254.2.22/24  169.254.3.23/24  |
> +# |fe80:2::22/64fe80:3::23/64|
> +# |  |
> +# | $rp21 +  |
> +# |   198.51.100.1/24 |  |
> +# |  2001:db8:2::1/64 |   R2 |
> +# +---|--+
> +# |
> +# +---|-+
> +# |   | |
> +# |   $h2 + |
> +# |   198.51.100.2/24   |
> +# |  2001:db8:2::2/64H2 |
> +# +-+
> +
>  ALL_TESTS="
>   ping_ipv4
>   ping_ipv6
> -- 
> 2.43.0
> 
Reviewed-by: Hangbin Liu 



[PATCH net-next 09/10] selftests: forwarding: router_mpath_nh_res: Add a diagram

2024-04-12 Thread Petr Machata
This test lacks a topology diagram, making the setup not obvious.
Add one.

Signed-off-by: Petr Machata 
---
 .../net/forwarding/router_mpath_nh_res.sh | 35 +++
 1 file changed, 35 insertions(+)

diff --git a/tools/testing/selftests/net/forwarding/router_mpath_nh_res.sh 
b/tools/testing/selftests/net/forwarding/router_mpath_nh_res.sh
index 4b483d24ad00..cd9e346436fc 100755
--- a/tools/testing/selftests/net/forwarding/router_mpath_nh_res.sh
+++ b/tools/testing/selftests/net/forwarding/router_mpath_nh_res.sh
@@ -1,6 +1,41 @@
 #!/bin/bash
 # SPDX-License-Identifier: GPL-2.0
 
+# +-+
+# |  H1 |
+# |   $h1 + |
+# |  192.0.2.2/24 | |
+# |  2001:db8:1::2/64 | |
+# +---|-+
+# |
+# +---|--+
+# |   |   R1 |
+# | $rp11 +  |
+# |  192.0.2.1/24|
+# |  2001:db8:1::1/64|
+# |  |
+# |  + $rp12  + $rp13|
+# |  | 169.254.2.12/24| 169.254.3.13/24  |
+# |  | fe80:2::12/64  | fe80:3::13/64|
+# +--||--+
+#||
+# +--||--+
+# |  + $rp22  + $rp23|
+# |169.254.2.22/24  169.254.3.23/24  |
+# |fe80:2::22/64fe80:3::23/64|
+# |  |
+# | $rp21 +  |
+# |   198.51.100.1/24 |  |
+# |  2001:db8:2::1/64 |   R2 |
+# +---|--+
+# |
+# +---|-+
+# |   | |
+# |   $h2 + |
+# |   198.51.100.2/24   |
+# |  2001:db8:2::2/64H2 |
+# +-+
+
 ALL_TESTS="
ping_ipv4
ping_ipv6
-- 
2.43.0