Re: [PATCH net-next 10/10] selftests: forwarding: router_nh: Add a diagram

2024-04-15 Thread Hangbin Liu
On Fri, Apr 12, 2024 at 07:03:13PM +0200, Petr Machata wrote:
> This test lacks a topology diagram, making the setup not obvious.
> Add one.
> 
> Signed-off-by: Petr Machata 
> ---
>  .../testing/selftests/net/forwarding/router_nh.sh  | 14 ++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/forwarding/router_nh.sh 
> b/tools/testing/selftests/net/forwarding/router_nh.sh
> index f3a53738bdcc..92904b01eae9 100755
> --- a/tools/testing/selftests/net/forwarding/router_nh.sh
> +++ b/tools/testing/selftests/net/forwarding/router_nh.sh
> @@ -1,6 +1,20 @@
>  #!/bin/bash
>  # SPDX-License-Identifier: GPL-2.0
>  
> +# +-+  +-+
> +# | H1  |  |  H2 |
> +# |   $h1 + |  |   $h2 + |
> +# |  192.0.2.2/24 | |  |   198.51.100.2/24 | |
> +# |  2001:db8:1::2/64 | |  |  2001:db8:2::2/64 | |
> +# +---|-+  +---|-+
> +# ||
> +# +---||-+
> +# | R1|| |
> +# |  $rp1 +   $rp2 + |
> +# |  192.0.2.1/24  198.51.100.1/24   |
> +# |  2001:db8:1::1/64 2001:db8:2::1/64   |
> +# +--+
> +
>  ALL_TESTS="
>   ping_ipv4
>   ping_ipv6
> -- 
> 2.43.0
> 
Reviewed-by: Hangbin Liu 



[PATCH net-next 10/10] selftests: forwarding: router_nh: Add a diagram

2024-04-12 Thread Petr Machata
This test lacks a topology diagram, making the setup not obvious.
Add one.

Signed-off-by: Petr Machata 
---
 .../testing/selftests/net/forwarding/router_nh.sh  | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/tools/testing/selftests/net/forwarding/router_nh.sh 
b/tools/testing/selftests/net/forwarding/router_nh.sh
index f3a53738bdcc..92904b01eae9 100755
--- a/tools/testing/selftests/net/forwarding/router_nh.sh
+++ b/tools/testing/selftests/net/forwarding/router_nh.sh
@@ -1,6 +1,20 @@
 #!/bin/bash
 # SPDX-License-Identifier: GPL-2.0
 
+# +-+  +-+
+# | H1  |  |  H2 |
+# |   $h1 + |  |   $h2 + |
+# |  192.0.2.2/24 | |  |   198.51.100.2/24 | |
+# |  2001:db8:1::2/64 | |  |  2001:db8:2::2/64 | |
+# +---|-+  +---|-+
+# ||
+# +---||-+
+# | R1|| |
+# |  $rp1 +   $rp2 + |
+# |  192.0.2.1/24  198.51.100.1/24   |
+# |  2001:db8:1::1/64 2001:db8:2::1/64   |
+# +--+
+
 ALL_TESTS="
ping_ipv4
ping_ipv6
-- 
2.43.0