Re: [PATCH v2 21/25] nvdimm: virtio_pmem: drop owner assignment

2024-04-25 Thread Ira Weiny 
Krzysztof Kozlowski wrote:
> virtio core already sets the .owner, so driver does not need to.
> 
> Acked-by: Dave Jiang 

Acked-by: Ira Weiny 

> Signed-off-by: Krzysztof Kozlowski 
> ---
> 
> Depends on the first patch.
> ---
>  drivers/nvdimm/virtio_pmem.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/nvdimm/virtio_pmem.c b/drivers/nvdimm/virtio_pmem.c
> index 4ceced5cefcf..c9b97aeabf85 100644
> --- a/drivers/nvdimm/virtio_pmem.c
> +++ b/drivers/nvdimm/virtio_pmem.c
> @@ -151,7 +151,6 @@ static struct virtio_driver virtio_pmem_driver = {
>   .feature_table  = features,
>   .feature_table_size = ARRAY_SIZE(features),
>   .driver.name= KBUILD_MODNAME,
> - .driver.owner   = THIS_MODULE,
>   .id_table   = id_table,
>   .validate   = virtio_pmem_validate,
>   .probe  = virtio_pmem_probe,
> 
> -- 
> 2.34.1
>

Re: [PATCH v2 21/25] nvdimm: virtio_pmem: drop owner assignment

2024-04-04 Thread Gupta, Pankaj 

On 3/31/2024 10:44 AM, Krzysztof Kozlowski wrote:

virtio core already sets the .owner, so driver does not need to.

Acked-by: Dave Jiang 
Signed-off-by: Krzysztof Kozlowski 
---

Depends on the first patch.
---
  drivers/nvdimm/virtio_pmem.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/nvdimm/virtio_pmem.c b/drivers/nvdimm/virtio_pmem.c
index 4ceced5cefcf..c9b97aeabf85 100644
--- a/drivers/nvdimm/virtio_pmem.c
+++ b/drivers/nvdimm/virtio_pmem.c
@@ -151,7 +151,6 @@ static struct virtio_driver virtio_pmem_driver = {
.feature_table  = features,
.feature_table_size = ARRAY_SIZE(features),
.driver.name= KBUILD_MODNAME,
-   .driver.owner   = THIS_MODULE,
.id_table   = id_table,
.validate   = virtio_pmem_validate,
.probe  = virtio_pmem_probe,



Reviewed-by: Pankaj Gupta

[PATCH v2 21/25] nvdimm: virtio_pmem: drop owner assignment

2024-03-31 Thread Krzysztof Kozlowski 
virtio core already sets the .owner, so driver does not need to.

Acked-by: Dave Jiang 
Signed-off-by: Krzysztof Kozlowski 
---

Depends on the first patch.
---
 drivers/nvdimm/virtio_pmem.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/nvdimm/virtio_pmem.c b/drivers/nvdimm/virtio_pmem.c
index 4ceced5cefcf..c9b97aeabf85 100644
--- a/drivers/nvdimm/virtio_pmem.c
+++ b/drivers/nvdimm/virtio_pmem.c
@@ -151,7 +151,6 @@ static struct virtio_driver virtio_pmem_driver = {
.feature_table  = features,
.feature_table_size = ARRAY_SIZE(features),
.driver.name= KBUILD_MODNAME,
-   .driver.owner   = THIS_MODULE,
.id_table   = id_table,
.validate   = virtio_pmem_validate,
.probe  = virtio_pmem_probe,

-- 
2.34.1