[balbi-usb:testing/next 50/50] drivers/usb/dwc3/./trace.h:216:449: warning: 's' may be used uninitialized in this function

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git 
testing/next
head:   ad7b607f82731eec3ed17d9d22764eb6f09609f9
commit: ad7b607f82731eec3ed17d9d22764eb6f09609f9 [50/50] usb: dwc3: trace: add 
missing break statement to make compiler happy
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout ad7b607f82731eec3ed17d9d22764eb6f09609f9
# save the attached .config to linux build tree
make ARCH=i386 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   In file included from include/trace/trace_events.h:394:0,
from include/trace/define_trace.h:96,
from drivers/usb/dwc3/trace.h:342,
from drivers/usb/dwc3/trace.c:11:
   drivers/usb/dwc3/./trace.h: In function 'trace_raw_output_dwc3_log_trb':
>> drivers/usb/dwc3/./trace.h:216:449: warning: 's' may be used uninitialized 
>> in this function [-Wmaybe-uninitialized]
DECLARE_EVENT_CLASS(dwc3_log_trb,





^   









   drivers/usb/dwc3/./trace.h:216:647: note: 's' was declared here
DECLARE_EVENT_CLASS(dwc3_log_trb,








  ^

vim +/s +216 drivers/usb/dwc3/./trace.h

2c4cbe6e5a Felipe Balbi2014-04-30  215  
2c4cbe6e5a Felipe Balbi2014-04-30 @216  DECLARE_EVENT_CLASS(dwc3_log_trb,
2c4cbe6e5a Felipe Balbi2014-04-30  217  TP_PROTO(struct dwc3_ep *dep, 
struct dwc3_trb *trb),
2c4cbe6e5a Felipe Balbi2014-04-30  218  TP_ARGS(dep, trb),
2c4cbe6e5a Felipe Balbi2014-04-30  219  TP_STRUCT__entry(
e42f09b85f Felipe Balbi2017-04-28  220  __string(name, 
dep->name)
2c4cbe6e5a Felipe Balbi2014-04-30  221  __field(struct dwc3_trb 
*, trb)
68d34c8a74 Felipe Balbi2016-05-30  222  __field(u32, allocated)
68d34c8a74 Felipe Balbi2016-05-30  223  __field(u32, queued)
4ac4fc9322 Felipe Balbi2014-09-17  224  __field(u32, bpl)
4ac4fc9322 Felipe Balbi2014-09-17  225  __field(u32, bph)
4ac4fc9322 Felipe Balbi2014-09-17  226  __field(u32, size)
4ac4fc9322 Felipe Balbi2014-09-17  227  __field(u32, ctrl)
fa8d965d73 Felipe Balbi2016-09-28  228  __field(u32, type)
2c4cbe6e5a Felipe Balbi2014-04-30  229  ),
2c4cbe6e5a Felipe Balbi2014-04-30  230  TP_fast_assign(
e42f09b85f Felipe Balbi2017-04-28  231  __assign_str(name, 
dep->name);
2c4cbe6e5a Felipe Balbi2014-04-30  232  __entry->trb = trb;
4ac4fc9322 Felipe Balbi2014-09-17  233  __entry->bpl = trb->bpl;
4ac4fc9322 Felipe Balbi2014-09-17  234  __entry->bph = trb->bph;
4ac4fc9322 Felipe Balbi2014-09-17  235  __entry->size = 
trb->size;
4ac4fc9322 Felipe Balbi2014-09-17  236  __entry->ctrl = 
trb->ctrl;
fa8d965d73 Felipe Balbi2016-09-28  237  __entry->type = 
usb_endpoint_type(dep->endpoint.desc);
2c4cbe6e5a Felipe Balbi2014-04-30  238  ),

[balbi-usb:testing/next 50/50] drivers/usb/dwc3/./trace.h:239:2: note: in expansion of macro 'TP_printk'

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git 
testing/next
head:   ad7b607f82731eec3ed17d9d22764eb6f09609f9
commit: ad7b607f82731eec3ed17d9d22764eb6f09609f9 [50/50] usb: dwc3: trace: add 
missing break statement to make compiler happy
config: i386-randconfig-x006-12051027 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout ad7b607f82731eec3ed17d9d22764eb6f09609f9
# save the attached .config to linux build tree
make ARCH=i386 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   In file included from include/trace/define_trace.h:96:0,
from drivers/usb/dwc3/trace.h:342,
from drivers/usb/dwc3/trace.c:11:
   drivers/usb/dwc3/./trace.h: In function 'trace_raw_output_dwc3_log_trb':
>> include/trace/trace_events.h:360:2: warning: 's' may be used uninitialized 
>> in this function [-Wmaybe-uninitialized]
 trace_seq_printf(s, print); \
 ^~~~
   drivers/usb/dwc3/./trace.h:241:11: note: 's' was declared here
  ({char *s;
  ^
   include/trace/trace_events.h:360:22: note: in definition of macro 
'DECLARE_EVENT_CLASS'
 trace_seq_printf(s, print); \
 ^
>> drivers/usb/dwc3/./trace.h:239:2: note: in expansion of macro 'TP_printk'
 TP_printk("%s: trb %p buf %08x%08x size %s%d ctrl %08x (%c%c%c%c:%c%c:%s)",
 ^
--
   In file included from include/trace/define_trace.h:96:0,
from drivers/usb//dwc3/trace.h:342,
from drivers/usb//dwc3/trace.c:11:
   drivers/usb//dwc3/./trace.h: In function 'trace_raw_output_dwc3_log_trb':
>> include/trace/trace_events.h:360:2: warning: 's' may be used uninitialized 
>> in this function [-Wmaybe-uninitialized]
 trace_seq_printf(s, print); \
 ^~~~
   drivers/usb//dwc3/./trace.h:241:11: note: 's' was declared here
  ({char *s;
  ^
   include/trace/trace_events.h:360:22: note: in definition of macro 
'DECLARE_EVENT_CLASS'
 trace_seq_printf(s, print); \
 ^
   drivers/usb//dwc3/./trace.h:239:2: note: in expansion of macro 'TP_printk'
 TP_printk("%s: trb %p buf %08x%08x size %s%d ctrl %08x (%c%c%c%c:%c%c:%s)",
 ^

vim +/TP_printk +239 drivers/usb/dwc3/./trace.h

2c4cbe6e5a Felipe Balbi2014-04-30  215  
2c4cbe6e5a Felipe Balbi2014-04-30  216  DECLARE_EVENT_CLASS(dwc3_log_trb,
2c4cbe6e5a Felipe Balbi2014-04-30  217  TP_PROTO(struct dwc3_ep *dep, 
struct dwc3_trb *trb),
2c4cbe6e5a Felipe Balbi2014-04-30  218  TP_ARGS(dep, trb),
2c4cbe6e5a Felipe Balbi2014-04-30  219  TP_STRUCT__entry(
e42f09b85f Felipe Balbi2017-04-28  220  __string(name, 
dep->name)
2c4cbe6e5a Felipe Balbi2014-04-30  221  __field(struct dwc3_trb 
*, trb)
68d34c8a74 Felipe Balbi2016-05-30  222  __field(u32, allocated)
68d34c8a74 Felipe Balbi2016-05-30  223  __field(u32, queued)
4ac4fc9322 Felipe Balbi2014-09-17  224  __field(u32, bpl)
4ac4fc9322 Felipe Balbi2014-09-17  225  __field(u32, bph)
4ac4fc9322 Felipe Balbi2014-09-17  226  __field(u32, size)
4ac4fc9322 Felipe Balbi2014-09-17  227  __field(u32, ctrl)
fa8d965d73 Felipe Balbi2016-09-28  228  __field(u32, type)
2c4cbe6e5a Felipe Balbi2014-04-30  229  ),
2c4cbe6e5a Felipe Balbi2014-04-30  230  TP_fast_assign(
e42f09b85f Felipe Balbi2017-04-28  231  __assign_str(name, 
dep->name);
2c4cbe6e5a Felipe Balbi2014-04-30  232  __entry->trb = trb;
4ac4fc9322 Felipe Balbi2014-09-17  233  __entry->bpl = trb->bpl;
4ac4fc9322 Felipe Balbi2014-09-17  234  __entry->bph = trb->bph;
4ac4fc9322 Felipe Balbi2014-09-17  235  __entry->size = 
trb->size;
4ac4fc9322 Felipe Balbi2014-09-17  236  __entry->ctrl = 
trb->ctrl;
fa8d965d73 Felipe Balbi2016-09-28  237  __entry->type = 
usb_endpoint_type(dep->endpoint.desc);
2c4cbe6e5a Felipe Balbi2014-04-30  238  ),
0bd0f6d201 Felipe Balbi2018-03-26 @239  TP_printk("%s: trb %p buf 
%08x%08x size %s%d ctrl %08x (%c%c%c%c:%c%c:%s)",
0bd0f6d201 Felipe Balbi2018-03-26  240  __get_str(name), 
__entry->trb, __entry->bph, __entry->bpl,
fa8d965d73 Felipe Balbi2016-09-28 @241  ({char *s;
fa8d965d73 Felipe Balbi2016-09-28  242  int pcm = 
((__entry->size >> 24) & 3) + 1;
fa8d965d73 Felipe Balbi2016-09-28  243  switch (__entry->type) {
fa8d965d73 Felipe Balbi2016-09-28  244  case 
USB_ENDPOINT_XFER_INT:
fa8d965d73 Felipe Balbi2016-09-28  245  case 
USB_ENDPOINT_XFER_ISOC:
fa8d965d73 Felipe Balbi

[balbi-usb:testing/next 50/50] drivers/usb/gadget/function/f_fs.c:2198:9: error: too few arguments to function 'ffs_do_single_desc'

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git 
testing/next
head:   3591a2f3900e0f93dbd246d979ddd939251cac3e
commit: 3591a2f3900e0f93dbd246d979ddd939251cac3e [50/50] usb: gadget: f_fs: add 
the support for alternate interface setting
config: arm-omap2plus_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 3591a2f3900e0f93dbd246d979ddd939251cac3e
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   drivers/usb/gadget/function/f_fs.c: In function 'ffs_do_descs_alt_intf':
>> drivers/usb/gadget/function/f_fs.c:2198:9: error: too few arguments to 
>> function 'ffs_do_single_desc'
  ret = ffs_do_single_desc(data, len, entity, priv);
^~
   drivers/usb/gadget/function/f_fs.c:1966:25: note: declared here
static int __must_check ffs_do_single_desc(char *data, unsigned len,
^~

vim +/ffs_do_single_desc +2198 drivers/usb/gadget/function/f_fs.c

  2148  
  2149  static int do_function_enable_interface(enum ffs_entity_type type, u8 
*valuep,
  2150  struct usb_descriptor_header 
*desc,
  2151  void *priv);
  2152  
  2153  static int do_function_disable_interface(enum ffs_entity_type type, u8 
*valuep,
  2154  struct usb_descriptor_header 
*desc,
  2155  void *priv);
  2156  
  2157  static int __must_check ffs_do_descs_alt_intf(unsigned int count, char 
*data,
  2158  unsigned int len, unsigned int 
intf,
  2159  unsigned int alt, void *priv)
  2160  {
  2161  const unsigned int _len = len;
  2162  unsigned long num = 0;
  2163  struct usb_descriptor_header *_ds;
  2164  struct usb_interface_descriptor *idecs;
  2165  ffs_entity_callback entity = NULL;
  2166  
  2167  ENTER();
  2168  
  2169  for (;;) {
  2170  int ret;
  2171  
  2172  if (num == count)
  2173  data = NULL;
  2174  
  2175  if (!data) {
  2176  pr_vdebug("%s Exiting. No more Data\n", 
__func__);
  2177  return _len - len;
  2178  }
  2179  
  2180  _ds = (void *)data;
  2181  if (_ds->bDescriptorType == USB_DT_INTERFACE) {
  2182  idecs = (void *)_ds;
  2183  
  2184  /*Check the interface no to deal with */
  2185  if (idecs->bInterfaceNumber == intf) {
  2186  if (idecs->bAlternateSetting == alt)
  2187  entity = 
do_function_enable_interface;
  2188  else
  2189  entity = 
do_function_disable_interface;
  2190  } else if (entity &&
  2191  (idecs->bInterfaceNumber != 
intf)) {
  2192  pr_vdebug(
  2193  "%s Exiting.Moved past the interface 
no\n",
  2194  
__func__);
  2195  return _len - len;
  2196  }
  2197  }
> 2198  ret = ffs_do_single_desc(data, len, entity, priv);
  2199  if (unlikely(ret < 0)) {
  2200  pr_err("%s Exiting with err %d\n", __func__, 
ret);
  2201  return ret;
  2202  }
  2203  
  2204  len -= ret;
  2205  data += ret;
  2206  ++num;
  2207  }
  2208  }
  2209  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH v2] usb: chipidea: imx: Allow OC polarity active low

[kbuild test robot]

Hi Matthew,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.20-rc4 next-20181130]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Matthew-Starr/usb-chipidea-imx-Allow-OC-polarity-active-low/20181202-132847
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: x86_64-randconfig-x000-201848 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/usb/chipidea/usbmisc_imx.c: In function 'usbmisc_imx7d_init':
>> drivers/usb/chipidea/usbmisc_imx.c:452:2: error: expected '}' before 'else'
 else {
 ^~~~

vim +452 drivers/usb/chipidea/usbmisc_imx.c

   434  
   435  static int usbmisc_imx7d_init(struct imx_usbmisc_data *data)
   436  {
   437  struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev);
   438  unsigned long flags;
   439  u32 reg;
   440  
   441  if (data->index >= 1)
   442  return -EINVAL;
   443  
   444  spin_lock_irqsave(>lock, flags);
   445  reg = readl(usbmisc->base);
   446  if (data->disable_oc) {
   447  reg |= MX6_BM_OVER_CUR_DIS;
   448  } else if (data->oc_polarity == 1) {
   449  /* Low active */
   450  reg &= ~(MX6_BM_OVER_CUR_DIS);
   451  reg |= MX6_BM_OVER_CUR_POLARITY;
 > 452  else {
   453  reg &= ~(MX6_BM_OVER_CUR_DIS | 
MX6_BM_OVER_CUR_POLARITY);
   454  }
   455  writel(reg, usbmisc->base);
   456  
   457  reg = readl(usbmisc->base + MX7D_USBNC_USB_CTRL2);
   458  reg &= ~MX7D_USB_VBUS_WAKEUP_SOURCE_MASK;
   459  writel(reg | MX7D_USB_VBUS_WAKEUP_SOURCE_BVALID,
   460   usbmisc->base + MX7D_USBNC_USB_CTRL2);
   461  spin_unlock_irqrestore(>lock, flags);
   462  
   463  usbmisc_imx7d_set_wakeup(data, false);
   464  
   465  return 0;
   466  }
   467  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH 1/2] phy: core: Add phy_pm_runtime_enabled

[kbuild test robot]

Hi Tony,

I love your patch! Yet something to improve:

[auto build test ERROR on phy/next]
[also build test ERROR on v4.20-rc3 next-20181119]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Tony-Lindgren/Improve-phy-mapphone-pm/20181119-222603
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git 
next
config: riscv-tinyconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 8.1.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=riscv 

All errors (new ones prefixed by >>):

   In file included from include/linux/usb/otg.h:13,
from include/linux/usb/of.h:12,
from drivers/usb/phy/of.c:9:
   include/linux/phy/phy.h: In function 'phy_pm_runtime_enabled':
>> include/linux/phy/phy.h:246:14: error: expected ';' before '}' token
 return false
 ^
 ;
}
~ 

vim +246 include/linux/phy/phy.h

   243  
   244  static inline bool phy_pm_runtime_enabled(struct phy *phy)
   245  {
 > 246  return false
   247  }
   248  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[balbi-usb:testing/next 17/22] drivers/usb/dwc3/drd.c:604: undefined reference to `usb_role_switch_unregister'

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git 
testing/next
head:   bad6c1502dac79c80ad5a7149fa308849c0191dd
commit: 24e2238d8c102f242ece57f45fbeb4014929aad4 [17/22] usb: dwc3: drd: 
Register a USB role switch
config: x86_64-randconfig-s4-11151335 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout 24e2238d8c102f242ece57f45fbeb4014929aad4
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/usb/dwc3/drd.o: In function `dwc3_drd_exit':
>> drivers/usb/dwc3/drd.c:604: undefined reference to 
>> `usb_role_switch_unregister'
   drivers/usb/dwc3/drd.o: In function `dwc3_drd_init':
>> drivers/usb/dwc3/drd.c:563: undefined reference to `usb_role_switch_register'
>> drivers/usb/dwc3/drd.c:563: undefined reference to `usb_role_switch_register'

vim +604 drivers/usb/dwc3/drd.c

   514  
   515  int dwc3_drd_init(struct dwc3 *dwc)
   516  {
   517  int ret, irq;
   518  
   519  dwc->edev = dwc3_get_extcon(dwc);
   520  if (IS_ERR(dwc->edev))
   521  return PTR_ERR(dwc->edev);
   522  
   523  if (dwc->edev) {
   524  dwc->edev_nb.notifier_call = dwc3_drd_notifier;
   525  ret = extcon_register_notifier(dwc->edev, 
EXTCON_USB_HOST,
   526 >edev_nb);
   527  if (ret < 0) {
   528  dev_err(dwc->dev, "couldn't register cable 
notifier\n");
   529  return ret;
   530  }
   531  
   532  dwc3_drd_update(dwc);
   533  } else {
   534  dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_OTG);
   535  dwc->current_dr_role = DWC3_GCTL_PRTCAP_OTG;
   536  
   537  /* use OTG block to get ID event */
   538  irq = dwc3_otg_get_irq(dwc);
   539  if (irq < 0)
   540  return irq;
   541  
   542  dwc->otg_irq = irq;
   543  
   544  /* disable all OTG IRQs */
   545  dwc3_otg_disable_events(dwc, DWC3_OTG_ALL_EVENTS);
   546  /* clear all events */
   547  dwc3_otg_clear_events(dwc);
   548  
   549  ret = request_threaded_irq(dwc->otg_irq, dwc3_otg_irq,
   550 dwc3_otg_thread_irq,
   551 IRQF_SHARED, "dwc3-otg", 
dwc);
   552  if (ret) {
   553  dev_err(dwc->dev, "failed to request irq #%d 
--> %d\n",
   554  dwc->otg_irq, ret);
   555  ret = -ENODEV;
   556  return ret;
   557  }
   558  
   559  dwc3_otg_init(dwc);
   560  dwc3_set_mode(dwc, DWC3_GCTL_PRTCAP_OTG);
   561  }
   562  
 > 563  dwc->role_sw = usb_role_switch_register(dwc->dev, 
 > _role_switch);
   564  if (ret) {
   565  dwc3_drd_exit(dwc);
   566  return PTR_ERR(dwc->role_sw);
   567  }
   568  return 0;
   569  }
   570  
   571  void dwc3_drd_exit(struct dwc3 *dwc)
   572  {
   573  unsigned long flags;
   574  
   575  if (dwc->edev)
   576  extcon_unregister_notifier(dwc->edev, EXTCON_USB_HOST,
   577 >edev_nb);
   578  
   579  cancel_work_sync(>drd_work);
   580  
   581  /* debug user might have changed role, clean based on current 
role */
   582  switch (dwc->current_dr_role) {
   583  case DWC3_GCTL_PRTCAP_HOST:
   584  dwc3_host_exit(dwc);
   585  break;
   586  case DWC3_GCTL_PRTCAP_DEVICE:
   587  dwc3_gadget_exit(dwc);
   588  dwc3_event_buffers_cleanup(dwc);
   589  break;
   590  case DWC3_GCTL_PRTCAP_OTG:
   591  dwc3_otg_exit(dwc);
   592  spin_lock_irqsave(>lock, flags);
   593  dwc->desired_otg_role = DWC3_OTG_ROLE_IDLE;
   594  spin_unlock_irqrestore(>lock, flags);
   595  dwc3_otg_update(dwc, 1);
   596  break;
   597  default:
   598  break;
   599  }
   600  
   601  if (!dwc->edev)
   602  free_irq(dwc->otg_irq, dwc);
   603  
 > 604  usb_role_switch_unregister(dwc->role_sw);

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[balbi-usb:testing/next 17/22] drivers/usb/dwc3/drd.c:491:2-3: Unneeded semicolon

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git 
testing/next
head:   bad6c1502dac79c80ad5a7149fa308849c0191dd
commit: 24e2238d8c102f242ece57f45fbeb4014929aad4 [17/22] usb: dwc3: drd: 
Register a USB role switch


coccinelle warnings: (new ones prefixed by >>)

>> drivers/usb/dwc3/drd.c:491:2-3: Unneeded semicolon

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation

[PATCH] usb: dwc3: drd: fix semicolon.cocci warnings

[kbuild test robot]

From: kbuild test robot 

drivers/usb/dwc3/drd.c:491:2-3: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: 24e2238d8c10 ("usb: dwc3: drd: Register a USB role switch")
CC: Heikki Krogerus 
Signed-off-by: kbuild test robot 
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git 
testing/next
head:   bad6c1502dac79c80ad5a7149fa308849c0191dd
commit: 24e2238d8c102f242ece57f45fbeb4014929aad4 [17/22] usb: dwc3: drd: 
Register a USB role switch

 drd.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/dwc3/drd.c
+++ b/drivers/usb/dwc3/drd.c
@@ -488,7 +488,7 @@ static int dwc3_usb_role_switch_set(stru
default:
mode = DWC3_GCTL_PRTCAP_OTG;
break;
-   };
+   }
 
dwc3_set_mode(dev_get_drvdata(dev), mode);
return 0;

Re: [PATCH] usb: gadget: f_fs: Allow scatter-gather buffers

[kbuild test robot]

Hi Andrzej,

I love your patch! Yet something to improve:

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.20-rc1 next-20181109]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Andrzej-Pietrasiewicz/usb-gadget-f_fs-Allow-scatter-gather-buffers/20181109-194916
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=sparc64 

All error/warnings (new ones prefixed by >>):

   drivers/usb/gadget/function/f_fs.c: In function 'ffs_build_sg_list':
>> drivers/usb/gadget/function/f_fs.c:769:10: error: implicit declaration of 
>> function 'vmalloc'; did you mean 'kvmalloc'? 
>> [-Werror=implicit-function-declaration]
 vaddr = vmalloc(size);
 ^~~
 kvmalloc
>> drivers/usb/gadget/function/f_fs.c:769:8: warning: assignment makes pointer 
>> from integer without a cast [-Wint-conversion]
 vaddr = vmalloc(size);
   ^
>> drivers/usb/gadget/function/f_fs.c:778:3: error: implicit declaration of 
>> function 'vfree'; did you mean 'kvfree'? 
>> [-Werror=implicit-function-declaration]
  vfree(vaddr);
  ^
  kvfree
   cc1: some warnings being treated as errors

vim +769 drivers/usb/gadget/function/f_fs.c

   755  
   756  /*
   757   * allocate a virtually contiguous buffer and create a scatterlist 
describing it
   758   * @sg_table- pointer to a place to be filled with sg_table contents
   759   * @size- required buffer size
   760   */
   761  static void *ffs_build_sg_list(struct sg_table *sg_table, size_t size)
   762  {
   763  struct page **pages;
   764  void *vaddr;
   765  unsigned long ptr;
   766  unsigned int n_pages;
   767  int i;
   768  
 > 769  vaddr = vmalloc(size);
   770  if (!vaddr)
   771  return NULL;
   772  
   773  n_pages =  (PAGE_ALIGN((unsigned long)vaddr + size) -
   774  ((unsigned long)vaddr & PAGE_MASK))
   775  >> PAGE_SHIFT;
   776  pages = kvmalloc_array(n_pages, sizeof(struct page *), 
GFP_KERNEL);
   777  if (!pages) {
 > 778  vfree(vaddr);
   779  
   780  return NULL;
   781  }
   782  for (i = 0, ptr = (unsigned long)vaddr & PAGE_MASK; i < n_pages;
   783  ++i, ptr += PAGE_SIZE)
   784  pages[i] = vmalloc_to_page((void *)ptr);
   785  
   786  if (sg_alloc_table_from_pages(sg_table, pages, n_pages,
   787  ((unsigned long)vaddr) & ~PAGE_MASK, size, GFP_KERNEL)) 
{
   788  kvfree(pages);
   789  vfree(vaddr);
   790  
   791  return NULL;
   792  }
   793  kvfree(pages);
   794  
   795  return vaddr;
   796  }
   797  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH 2/3] spi: add FTDI MPSSE SPI controller driver

[kbuild test robot]

Hi Anatolij,

I love your patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.20-rc1 next-20181105]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Anatolij-Gustschin/Add-support-for-ARRI-FPGA-configuration/20181106-090458
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

>> drivers//spi/spi-ftdi-mpsse.c:27:2: error: expected identifier before 
>> numeric constant
 CS = BIT(3),
 ^~

vim +27 drivers//spi/spi-ftdi-mpsse.c

22  
23  enum gpiol {
24  SK  = BIT(0),
25  DO  = BIT(1),
26  DI  = BIT(2),
  > 27  CS  = BIT(3),
28  };
29  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH 2/3] spi: add FTDI MPSSE SPI controller driver

[kbuild test robot]

Hi Anatolij,

I love your patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.20-rc1 next-20181105]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Anatolij-Gustschin/Add-support-for-ARRI-FPGA-configuration/20181106-090458
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from arch/x86/include/uapi/asm/ptrace.h:6:0,
from arch/x86/include/asm/ptrace.h:7,
from arch/x86/include/asm/math_emu.h:5,
from arch/x86/include/asm/processor.h:12,
from arch/x86/include/asm/cpufeature.h:8,
from arch/x86/include/asm/thread_info.h:53,
from include/linux/thread_info.h:38,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:81,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/stat.h:19,
from include/linux/module.h:10,
from drivers/spi/spi-ftdi-mpsse.c:11:
>> arch/x86/include/uapi/asm/ptrace-abi.h:20:13: error: expected identifier 
>> before numeric constant
#define CS  13
^
>> drivers/spi/spi-ftdi-mpsse.c:27:2: note: in expansion of macro 'CS'
 CS = BIT(3),
 ^~

vim +/CS +27 drivers/spi/spi-ftdi-mpsse.c

  > 11  #include 
12  #include 
13  #include 
14  #include 
15  #include 
16  #include 
17  #include 
18  #include 
19  #include 
20  #include 
21  #include 
22  
23  enum gpiol {
24  SK  = BIT(0),
25  DO  = BIT(1),
26  DI  = BIT(2),
  > 27  CS  = BIT(3),
28  };
29  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH 2/4] usb: chipidea: imx: add HSIC support

[kbuild test robot]

Hi Peter,

I love your patch! Yet something to improve:

[auto build test ERROR on peter.chen-usb/ci-for-usb-next]
[also build test ERROR on v4.19-rc8 next-20181012]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Peter-Chen/usb-chipidea-imx-add-HSIC-support/20181016-130840
base:   https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git 
ci-for-usb-next
config: x86_64-randconfig-x017-201841 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/usb/chipidea/ci_hdrc_imx.c: In function 'ci_hdrc_imx_notify_event':
>> drivers/usb/chipidea/ci_hdrc_imx.c:261:10: error: implicit declaration of 
>> function 'pinctrl_select_state'; did you mean 'inc_node_state'? 
>> [-Werror=implicit-function-declaration]
   ret = pinctrl_select_state(data->pinctrl,
 ^~~~
 inc_node_state
   drivers/usb/chipidea/ci_hdrc_imx.c: In function 'ci_hdrc_imx_probe':
   drivers/usb/chipidea/ci_hdrc_imx.c:317:18: error: implicit declaration of 
function 'devm_pinctrl_get'; did you mean 'devm_clk_get'? 
[-Werror=implicit-function-declaration]
 data->pinctrl = devm_pinctrl_get(dev);
 ^~~~
 devm_clk_get
   drivers/usb/chipidea/ci_hdrc_imx.c:317:16: warning: assignment makes pointer 
from integer without a cast [-Wint-conversion]
 data->pinctrl = devm_pinctrl_get(dev);
   ^
>> drivers/usb/chipidea/ci_hdrc_imx.c:322:23: error: implicit declaration of 
>> function 'pinctrl_lookup_state'; did you mean 'inc_node_state'? 
>> [-Werror=implicit-function-declaration]
  pinctrl_hsic_idle = pinctrl_lookup_state(data->pinctrl, "idle");
  ^~~~
  inc_node_state
   drivers/usb/chipidea/ci_hdrc_imx.c:322:21: warning: assignment makes pointer 
from integer without a cast [-Wint-conversion]
  pinctrl_hsic_idle = pinctrl_lookup_state(data->pinctrl, "idle");
^
   drivers/usb/chipidea/ci_hdrc_imx.c:338:29: warning: assignment makes pointer 
from integer without a cast [-Wint-conversion]
  data->pinctrl_hsic_active = pinctrl_lookup_state(data->pinctrl,
^
   cc1: some warnings being treated as errors

vim +261 drivers/usb/chipidea/ci_hdrc_imx.c

   250  
   251  static int ci_hdrc_imx_notify_event(struct ci_hdrc *ci, unsigned int 
event)
   252  {
   253  struct device *dev = ci->dev->parent;
   254  struct ci_hdrc_imx_data *data = dev_get_drvdata(dev);
   255  int ret = 0;
   256  
   257  switch (event) {
   258  case CI_HDRC_IMX_HSIC_ACTIVE_EVENT:
   259  if (!IS_ERR(data->pinctrl) &&
   260  !IS_ERR(data->pinctrl_hsic_active)) {
 > 261  ret = pinctrl_select_state(data->pinctrl,
   262  data->pinctrl_hsic_active);
   263  if (ret)
   264  dev_err(dev,
   265  "hsic_active select failed, 
err=%d\n",
   266  ret);
   267  return ret;
   268  }
   269  break;
   270  case CI_HDRC_IMX_HSIC_SUSPEND_EVENT:
   271  if (data->usbmisc_data) {
   272  ret = 
imx_usbmisc_hsic_set_connect(data->usbmisc_data);
   273  if (ret)
   274  dev_err(dev,
   275  "hsic_set_connect failed, 
err=%d\n",
   276  ret);
   277  return ret;
   278  }
   279  break;
   280  default:
   281  break;
   282  }
   283  
   284  return ret;
   285  }
   286  
   287  static int ci_hdrc_imx_probe(struct platform_device *pdev)
   288  {
   289  struct ci_hdrc_imx_data *data;
   290  struct ci_hdrc_platform_data pdata = {
   291  .name   = dev_name(>dev),
   292  .capoffset  = DEF_CAPOFFSET,
   293  .notify_event   = ci_hdrc_imx_notify_event,
   294  };
   295  int ret;
   296  const struct of_device_id *of_id;
   297  const struct ci_hdrc_imx_platform_flag *imx_platform_flag;
   298  struct device_node *np = pdev->dev.of_node;
   299  struct device *dev = >dev;
   300  struct pinctrl_state *pinctrl_hsic_idle;
   301  
   302  of_id = of_match_device(ci_hdrc_imx_dt_ids, dev);
   303  if (!of_id)
   304  return -ENODEV;
   305  
 

[hid:for-4.20/google 2/3] drivers/hid/hid-google-hammer.c:73: undefined reference to `cros_ec_cmd_xfer_status'

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git 
for-4.20/google
head:   8f35260e0b6cc09d77bcbbc21554342aa79ceb2f
commit: eb1aac4c8744f75460c34d71b0c73bebf3e8ee5c [2/3] HID: google: add support 
tablet mode switch for Whiskers
config: x86_64-randconfig-s3-10092338 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout eb1aac4c8744f75460c34d71b0c73bebf3e8ee5c
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/hid/hid-google-hammer.o: In function `cbas_ec_query_base':
>> drivers/hid/hid-google-hammer.c:73: undefined reference to 
>> `cros_ec_cmd_xfer_status'

vim +73 drivers/hid/hid-google-hammer.c

51  
52  static int cbas_ec_query_base(struct cros_ec_device *ec_dev, bool 
get_state,
53bool *state)
54  {
55  struct ec_params_mkbp_info *params;
56  struct cros_ec_command *msg;
57  int ret;
58  
59  msg = kzalloc(sizeof(*msg) + max(sizeof(u32), sizeof(*params)),
60GFP_KERNEL);
61  if (!msg)
62  return -ENOMEM;
63  
64  msg->command = EC_CMD_MKBP_INFO;
65  msg->version = 1;
66  msg->outsize = sizeof(*params);
67  msg->insize = sizeof(u32);
68  params = (struct ec_params_mkbp_info *)msg->data;
69  params->info_type = get_state ?
70  EC_MKBP_INFO_CURRENT : EC_MKBP_INFO_SUPPORTED;
71  params->event_type = EC_MKBP_EVENT_SWITCH;
72  
  > 73  ret = cros_ec_cmd_xfer_status(ec_dev, msg);
74  if (ret >= 0) {
75  if (ret != sizeof(u32)) {
76  dev_warn(ec_dev->dev, "wrong result size: %d != 
%zu\n",
77   ret, sizeof(u32));
78  ret = -EPROTO;
79  } else {
80  *state = cbas_parse_base_state(msg->data);
81  ret = 0;
82  }
83  }
84  
85  kfree(msg);
86  
87  return ret;
88  }
89  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[hid:for-4.20/google 2/3] ERROR: "cros_ec_cmd_xfer_status" [drivers/hid/hid-google-hammer.ko] undefined!

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git 
for-4.20/google
head:   8f35260e0b6cc09d77bcbbc21554342aa79ceb2f
commit: eb1aac4c8744f75460c34d71b0c73bebf3e8ee5c [2/3] HID: google: add support 
tablet mode switch for Whiskers
config: x86_64-randconfig-s0-10091927 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
git checkout eb1aac4c8744f75460c34d71b0c73bebf3e8ee5c
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> ERROR: "cros_ec_cmd_xfer_status" [drivers/hid/hid-google-hammer.ko] 
>> undefined!

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH v2] usb: export firmware port location in sysfs

[kbuild test robot]

Hi Bjørn,

I love your patch! Perhaps something to improve:

[auto build test WARNING on peter.chen-usb/ci-for-usb-next]
[also build test WARNING on v4.19-rc5 next-20180928]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Bj-rn-Mork/usb-export-firmware-port-location-in-sysfs/20180928-192720
base:   https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git 
ci-for-usb-next
config: i386-randconfig-x005-201838 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/pm_qos.h:10:0,
from drivers/usb//core/port.c:11:
   include/linux/device.h:598:26: warning: 'dev_attr_location' defined but not 
used [-Wunused-variable]
 struct device_attribute dev_attr_##_name = __ATTR_RO(_name)
 ^
>> drivers/usb//core/port.c:26:8: note: in expansion of macro 'DEVICE_ATTR_RO'
static DEVICE_ATTR_RO(location);
   ^~

vim +/DEVICE_ATTR_RO +26 drivers/usb//core/port.c

  > 11  #include 
12  
13  #include "hub.h"
14  
15  static int usb_port_block_power_off;
16  
17  static const struct attribute_group *port_dev_group[];
18  
19  static ssize_t location_show(struct device *dev,
20   struct device_attribute *attr, char *buf)
21  {
22  struct usb_port *port_dev = to_usb_port(dev);
23  
24  return sprintf(buf, "0x%08x\n", port_dev->location);
25  }
  > 26  static DEVICE_ATTR_RO(location);
27  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH] usb: dwc2: Disable all EP's on disconnect

[kbuild test robot]

Hi Minas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on balbi-usb/next]
[also build test WARNING on v4.19-rc4 next-20180918]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Minas-Harutyunyan/usb-dwc2-Disable-all-EP-s-on-disconnect/20180919-104259
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All warnings (new ones prefixed by >>):

>> drivers/usb/dwc2/gadget.c:4053:9: warning: context imbalance in 
>> 'dwc2_hsotg_ep_disable' - different lock contexts for basic block
>> drivers/usb/dwc2/gadget.c:4361:28: warning: context imbalance in 
>> 'dwc2_hsotg_udc_stop' - different lock contexts for basic block

vim +/dwc2_hsotg_ep_disable +4053 drivers/usb/dwc2/gadget.c

5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3993  
8b9bc4608 drivers/usb/gadget/s3c-hsotg.c Lukasz Majewski2012-05-04  3994  
/**
1f91b4cc0 drivers/usb/dwc2/gadget.c  Felipe Balbi   2015-08-06  3995   
* dwc2_hsotg_ep_disable - disable given endpoint
8b9bc4608 drivers/usb/gadget/s3c-hsotg.c Lukasz Majewski2012-05-04  3996   
* @ep: The endpoint to disable.
8b9bc4608 drivers/usb/gadget/s3c-hsotg.c Lukasz Majewski2012-05-04  3997   
*/
1f91b4cc0 drivers/usb/dwc2/gadget.c  Felipe Balbi   2015-08-06  3998  
static int dwc2_hsotg_ep_disable(struct usb_ep *ep)
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3999  {
1f91b4cc0 drivers/usb/dwc2/gadget.c  Felipe Balbi   2015-08-06  4000
struct dwc2_hsotg_ep *hs_ep = our_ep(ep);
941fcce4f drivers/usb/dwc2/gadget.c  Dinh Nguyen2014-11-11  4001
struct dwc2_hsotg *hsotg = hs_ep->parent;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  4002
int dir_in = hs_ep->dir_in;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  4003
int index = hs_ep->index;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  4004
unsigned long flags;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  4005
u32 epctrl_reg;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  4006
u32 ctrl;
a4705c3fe drivers/usb/dwc2/gadget.c  Minas Harutyunyan  2018-09-18  4007
int locked;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  4008  
1e0112937 drivers/usb/dwc2/gadget.c  Marek Szyprowski   2014-09-09  4009
dev_dbg(hsotg->dev, "%s(ep %p)\n", __func__, ep);
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  4010  
c6f5c050e drivers/usb/dwc2/gadget.c  Mian Yousaf Kaukab 2015-01-09  4011
if (ep == >eps_out[0]->ep) {
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  4012
dev_err(hsotg->dev, "%s: called for ep0\n", __func__);
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  4013
return -EINVAL;
9b481092c drivers/usb/dwc2/gadget.c  John Stultz2017-10-23  4014
}
9b481092c drivers/usb/dwc2/gadget.c  John Stultz2017-10-23  4015  
9b481092c drivers/usb/dwc2/gadget.c  John Stultz2017-10-23  4016
if (hsotg->op_state != OTG_STATE_B_PERIPHERAL) {
9b481092c drivers/usb/dwc2/gadget.c  John Stultz2017-10-23  4017
dev_err(hsotg->dev, "%s: called in host mode?\n", __func__);
9b481092c drivers/usb/dwc2/gadget.c  John Stultz2017-10-23  4018
return -EINVAL;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  4019
}
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  4020  
94cb8fd63 drivers/usb/gadget/s3c-hsotg.c Lukasz Majewski2012-05-04  4021
epctrl_reg = dir_in ? DIEPCTL(index) : DOEPCTL(index);
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  4022  
a4705c3fe drivers/usb/dwc2/gadget.c  Minas Harutyunyan  2018-09-18  4023
locked = spin_trylock(>lock);
a4705c3fe drivers/usb/dwc2/gadget.c  Minas Harutyunyan  2018-09-18  4024
spin_unlock(>lock);
5ad1d3160 drivers/usb/gadget/s3c-hsotg.c Lukasz Majewski2012-06-14  4025
spin_lock_irqsave(>lock, flags);
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  4026  
f25c42b8d drivers/usb/dwc2/gadget.c  Gevorg Sahakyan2018-07-26  4027
ctrl = dwc2_readl(hsotg, epctrl_reg);
a4f827714 drivers/usb/dwc2/gadget.c  Vahram Aharonyan   2016-11-14  4028  
a4f827714 drivers/usb/dwc2/gadget.c  Vahram Aharonyan   2016-11-14  4029
if (ctrl & DXEPCTL_EPENA)
a4f827714 drivers/usb/dwc2/gadget.c  Vahram Aharonyan   2016-11-14  4030
dwc2_hsotg_ep_stop_xfr(hsotg, hs_ep);
a4f827714 

[hid:for-4.20/microsoft 2/3] ERROR: "input_ff_create_memless" [drivers/hid/hid-microsoft.ko] undefined!

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git 
for-4.20/microsoft
head:   830e82aa48f32518dfa5335c0134f611d4bab4b2
commit: 73c5b254c36529c84c9d19e07905f7103bb32e79 [2/3] HID: microsoft: Add 
rumble support for Xbox One S controller
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 73c5b254c36529c84c9d19e07905f7103bb32e79
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=m68k 

Note: the hid/for-4.20/microsoft HEAD 830e82aa48f32518dfa5335c0134f611d4bab4b2 
builds fine.
  It only hurts bisectibility.

All errors (new ones prefixed by >>):

>> ERROR: "input_ff_create_memless" [drivers/hid/hid-microsoft.ko] undefined!

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[hid:for-4.20/microsoft 2/2] undefined reference to `input_ff_create_memless'

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git 
for-4.20/microsoft
head:   73c5b254c36529c84c9d19e07905f7103bb32e79
commit: 73c5b254c36529c84c9d19e07905f7103bb32e79 [2/2] HID: microsoft: Add 
rumble support for Xbox One S controller
config: parisc-b180_defconfig (attached as .config)
compiler: hppa-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 73c5b254c36529c84c9d19e07905f7103bb32e79
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=parisc 

All errors (new ones prefixed by >>):

   drivers/hid/hid-microsoft.o: In function `ms_probe':
>> (.text+0x324): undefined reference to `input_ff_create_memless'

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[hid:for-4.20/microsoft 2/2] hid-microsoft.c:undefined reference to `input_ff_create_memless'

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git 
for-4.20/microsoft
head:   73c5b254c36529c84c9d19e07905f7103bb32e79
commit: 73c5b254c36529c84c9d19e07905f7103bb32e79 [2/2] HID: microsoft: Add 
rumble support for Xbox One S controller
config: i386-alldefconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout 73c5b254c36529c84c9d19e07905f7103bb32e79
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/hid/hid-microsoft.o: In function `ms_probe':
>> hid-microsoft.c:(.text+0x2d7): undefined reference to 
>> `input_ff_create_memless'

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[hid:for-4.20/multitouch 1/1] drivers/hid/hid-multitouch.c:1327:5: error: 'struct hid_input' has no member named 'application'

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git 
for-4.20/multitouch
head:   93c61d2e6bc4849a5527e32568479ff67154870e
commit: 93c61d2e6bc4849a5527e32568479ff67154870e [1/1] HID: multitouch: 
simplify the application retrieval
config: x86_64-randconfig-x018-201835 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout 93c61d2e6bc4849a5527e32568479ff67154870e
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/hid/hid-multitouch.c: In function 'mt_input_mapping':
>> drivers/hid/hid-multitouch.c:1327:5: error: 'struct hid_input' has no member 
>> named 'application'
  hi->application = HID_DG_STYLUS;
^~
   drivers/hid/hid-multitouch.c: In function 'mt_input_configured':
   drivers/hid/hid-multitouch.c:1527:12: error: 'struct hid_input' has no 
member named 'application'
 switch (hi->application) {
   ^~

vim +1327 drivers/hid/hid-multitouch.c

  1257  
  1258  #define mt_map_key_clear(c) hid_map_usage_clear(hi, usage, bit, \
  1259  max, EV_KEY, (c))
  1260  static int mt_input_mapping(struct hid_device *hdev, struct hid_input 
*hi,
  1261  struct hid_field *field, struct hid_usage *usage,
  1262  unsigned long **bit, int *max)
  1263  {
  1264  struct mt_device *td = hid_get_drvdata(hdev);
  1265  struct mt_application *application;
  1266  struct mt_report_data *rdata;
  1267  
  1268  rdata = mt_find_report_data(td, field->report);
  1269  if (!rdata) {
  1270  hid_err(hdev, "failed to allocate data for report\n");
  1271  return 0;
  1272  }
  1273  
  1274  application = rdata->application;
  1275  
  1276  /*
  1277   * If mtclass.export_all_inputs is not set, only map fields from
  1278   * TouchScreen or TouchPad collections. We need to ignore fields
  1279   * that belong to other collections such as Mouse that might 
have
  1280   * the same GenericDesktop usages.
  1281   */
  1282  if (!td->mtclass.export_all_inputs &&
  1283  field->application != HID_DG_TOUCHSCREEN &&
  1284  field->application != HID_DG_PEN &&
  1285  field->application != HID_DG_TOUCHPAD &&
  1286  field->application != HID_GD_KEYBOARD &&
  1287  field->application != HID_GD_SYSTEM_CONTROL &&
  1288  field->application != HID_CP_CONSUMER_CONTROL &&
  1289  field->application != HID_GD_WIRELESS_RADIO_CTLS &&
  1290  field->application != HID_GD_SYSTEM_MULTIAXIS &&
  1291  !(field->application == HID_VD_ASUS_CUSTOM_MEDIA_KEYS &&
  1292application->quirks & MT_QUIRK_ASUS_CUSTOM_UP))
  1293  return -1;
  1294  
  1295  /*
  1296   * Some Asus keyboard+touchpad devices have the hotkeys defined 
in the
  1297   * touchpad report descriptor. We need to treat these as an 
array to
  1298   * map usages to input keys.
  1299   */
  1300  if (field->application == HID_VD_ASUS_CUSTOM_MEDIA_KEYS &&
  1301  application->quirks & MT_QUIRK_ASUS_CUSTOM_UP &&
  1302  (usage->hid & HID_USAGE_PAGE) == HID_UP_CUSTOM) {
  1303  set_bit(EV_REP, hi->input->evbit);
  1304  if (field->flags & HID_MAIN_ITEM_VARIABLE)
  1305  field->flags &= ~HID_MAIN_ITEM_VARIABLE;
  1306  switch (usage->hid & HID_USAGE) {
  1307  case 0x10: mt_map_key_clear(KEY_BRIGHTNESSDOWN);
break;
  1308  case 0x20: mt_map_key_clear(KEY_BRIGHTNESSUP);  
break;
  1309  case 0x35: mt_map_key_clear(KEY_DISPLAY_OFF);   
break;
  1310  case 0x6b: mt_map_key_clear(KEY_F21);   
break;
  1311  case 0x6c: mt_map_key_clear(KEY_SLEEP); 
break;
  1312  default:
  1313  return -1;
  1314  }
  1315  return 1;
  1316  }
  1317  
  1318  if (rdata->is_mt_collection)
  1319  return mt_touch_input_mapping(hdev, hi, field, usage, 
bit, max,
  1320application);
  1321  
  1322  /*
  1323   * some egalax touchscreens have "application == DG_TOUCHSCREEN"
  1324   * for the stylus. Overwrite the hid_input application
  1325   */
  1326  if (field->physical == HID_DG_STYLUS)
> 1327  hi->application = HID_DG_STYLUS;
  1328  
  1329  /* let hid-core decide for the others */
  1330  return 0;
  1331  }
  1332  

---
0-DAY kernel test infrastructureOpen Source 

Re: [PATCH 2/2] usb: typec: ucsi: add support for Cypress CCGx

[kbuild test robot]

Hi Ajay,

I love your patch! Yet something to improve:

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on v4.19-rc1 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Ajay-Gupta/i2c-buses-add-i2c-bus-driver-for-NVIDIA-GPU/20180827-092936
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git 
i2c/for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/usb//typec/ucsi/ucsi_i2c_ccg.c: In function 'ucsi_i2c_ccg_resume':
>> drivers/usb//typec/ucsi/ucsi_i2c_ccg.c:559:8: error: implicit declaration of 
>> function 'ucsi_run_command'; did you mean 'ucsi_i2c_ccg_cmd'? 
>> [-Werror=implicit-function-declaration]
 ret = ucsi_run_command(ui->ucsi, , NULL, 0);
   ^~~~
   ucsi_i2c_ccg_cmd
   cc1: some warnings being treated as errors

vim +559 drivers/usb//typec/ucsi/ucsi_i2c_ccg.c

   544  
   545  static int ucsi_i2c_ccg_resume(struct device *dev)
   546  {
   547  struct i2c_client *client = to_i2c_client(dev);
   548  struct ucsi_i2c_ccg *ui = i2c_get_clientdata(client);
   549  struct ucsi_control c;
   550  int ret;
   551  
   552  if (device_may_wakeup(dev) && ui->wake_enabled) {
   553  disable_irq_wake(ui->irq);
   554  ui->wake_enabled = false;
   555  }
   556  
   557  /* restore UCSI notification enable mask */
   558  UCSI_CMD_SET_NTFY_ENABLE(c, UCSI_ENABLE_NTFY_ALL);
 > 559  ret = ucsi_run_command(ui->ucsi, , NULL, 0);
   560  if (ret) {
   561  dev_err(ui->dev, "%s: failed to set notification enable 
- %d\n",
   562  __func__, ret);
   563  }
   564  
   565  return 0;
   566  }
   567  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH v2 2/2] usb: typec: ucsi: add support for Cypress CCGx

[kbuild test robot]

Hi Ajay,

I love your patch! Yet something to improve:

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on v4.19-rc1 next-20180827]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Ajay-Gupta/i2c-buses-add-i2c-bus-driver-for-NVIDIA-GPU/20180827-093218
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git 
i2c/for-next
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/usb/typec/ucsi/ucsi_i2c_ccg.c: In function 'ucsi_i2c_ccg_resume':
>> drivers/usb/typec/ucsi/ucsi_i2c_ccg.c:559:8: error: implicit declaration of 
>> function 'ucsi_run_command'; did you mean 'ucsi_i2c_ccg_cmd'? 
>> [-Werror=implicit-function-declaration]
 ret = ucsi_run_command(ui->ucsi, , NULL, 0);
   ^~~~
   ucsi_i2c_ccg_cmd
   cc1: some warnings being treated as errors

vim +559 drivers/usb/typec/ucsi/ucsi_i2c_ccg.c

   544  
   545  static int ucsi_i2c_ccg_resume(struct device *dev)
   546  {
   547  struct i2c_client *client = to_i2c_client(dev);
   548  struct ucsi_i2c_ccg *ui = i2c_get_clientdata(client);
   549  struct ucsi_control c;
   550  int ret;
   551  
   552  if (device_may_wakeup(dev) && ui->wake_enabled) {
   553  disable_irq_wake(ui->irq);
   554  ui->wake_enabled = false;
   555  }
   556  
   557  /* restore UCSI notification enable mask */
   558  UCSI_CMD_SET_NTFY_ENABLE(c, UCSI_ENABLE_NTFY_ALL);
 > 559  ret = ucsi_run_command(ui->ucsi, , NULL, 0);
   560  if (ret) {
   561  dev_err(ui->dev, "%s: failed to set notification enable 
- %d\n",
   562  __func__, ret);
   563  }
   564  
   565  return 0;
   566  }
   567  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[usb:usb-next 36/38] drivers/usb/typec/tcpci.c:549: undefined reference to `__devm_regmap_init_i2c'

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
head:   aaf3f4e925dc2bdc4715142103660285632a245c
commit: 990da41530b31ed7de29340ce1d78c04bee9670c [36/38] staging: typec: tcpci: 
move tcpci drivers out of staging
config: x86_64-randconfig-a0-06290727 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
git checkout 990da41530b31ed7de29340ce1d78c04bee9670c
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/usb/typec/tcpci.o: In function `tcpci_probe':
>> drivers/usb/typec/tcpci.c:549: undefined reference to 
>> `__devm_regmap_init_i2c'
   drivers/usb/typec/tcpci.o: In function `tcpci_i2c_driver_init':
>> drivers/usb/typec/tcpci.c:609: undefined reference to `i2c_register_driver'
   drivers/usb/typec/tcpci.o: In function `tcpci_i2c_driver_exit':
>> drivers/usb/typec/tcpci.c:609: undefined reference to `i2c_del_driver'
   drivers/usb/typec/tcpci_rt1711h.o: In function `rt1711h_check_revision':
>> drivers/usb/typec/tcpci_rt1711h.c:218: undefined reference to 
>> `i2c_smbus_read_word_data'
   drivers/usb/typec/tcpci_rt1711h.c:225: undefined reference to 
`i2c_smbus_read_word_data'
   drivers/usb/typec/tcpci_rt1711h.o: In function `rt1711h_probe':
>> drivers/usb/typec/tcpci_rt1711h.c:251: undefined reference to 
>> `__devm_regmap_init_i2c'
   drivers/usb/typec/tcpci_rt1711h.o: In function `rt1711h_i2c_driver_init':
>> drivers/usb/typec/tcpci_rt1711h.c:308: undefined reference to 
>> `i2c_register_driver'
   drivers/usb/typec/tcpci_rt1711h.o: In function `rt1711h_i2c_driver_exit':
>> drivers/usb/typec/tcpci_rt1711h.c:308: undefined reference to 
>> `i2c_del_driver'

vim +549 drivers/usb/typec/tcpci.c

8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  537  
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  538  static 
int tcpci_probe(struct i2c_client *client,
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  539   
   const struct i2c_device_id *i2c_id)
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  540  {
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  541   struct 
tcpci_chip *chip;
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  542   int err;
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  543   u16 val 
= 0;
74e656d6b drivers/staging/typec/tcpci.c Guenter Roeck 2017-04-27  544  
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  545   chip = 
devm_kzalloc(>dev, sizeof(*chip), GFP_KERNEL);
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  546   if 
(!chip)
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  547   
return -ENOMEM;
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  548  
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 @549   
chip->data.regmap = devm_regmap_init_i2c(client, _regmap_config);
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  550   if 
(IS_ERR(chip->data.regmap))
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  551   
return PTR_ERR(chip->data.regmap);
74e656d6b drivers/staging/typec/tcpci.c Guenter Roeck 2017-04-27  552  
b28d9be6c drivers/staging/typec/tcpci.c Peter Chen2018-06-27  553   
i2c_set_clientdata(client, chip);
b28d9be6c drivers/staging/typec/tcpci.c Peter Chen2018-06-27  554  
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  555   /* 
Disable chip interrupts before requesting irq */
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  556   err = 
regmap_raw_write(chip->data.regmap, TCPC_ALERT_MASK, ,
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  557   
   sizeof(u16));
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  558   if (err 
< 0)
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  559   
return err;
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  560  
b28d9be6c drivers/staging/typec/tcpci.c Peter Chen2018-06-27  561   
chip->tcpci = tcpci_register_port(>dev, >data);
b28d9be6c drivers/staging/typec/tcpci.c Peter Chen2018-06-27  562   if 
(IS_ERR(chip->tcpci))
b28d9be6c drivers/staging/typec/tcpci.c Peter Chen2018-06-27  563   
return PTR_ERR(chip->tcpci);
b28d9be6c drivers/staging/typec/tcpci.c Peter Chen2018-06-27  564  
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  565   err = 
devm_request_threaded_irq(>dev, client->irq, NULL,
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  566   
_tcpci_irq,
74e656d6b drivers/staging/typec/tcpci.c Guenter Roeck 2017-04-27  567   
IRQF_ONESHOT | IRQF_TRIGGER_LOW,
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06  568   

Re: [PATCH v4] USB: serial: ftdi_sio: Add MTP NVM support

[kbuild test robot]

Hi Loic,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.18-rc2 next-20180625]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Loic-Poulain/USB-serial-ftdi_sio-Add-MTP-NVM-support/20180625-181125
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: x86_64-randconfig-x011-201825 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/usb/serial/ftdi_sio.c: In function 'ftdi_register_eeprom':
>> drivers/usb/serial/ftdi_sio.c:1603:18: error: 'SZ_2K' undeclared (first use 
>> in this function)
  nvmconf.size = SZ_2K;
 ^
   drivers/usb/serial/ftdi_sio.c:1603:18: note: each undeclared identifier is 
reported only once for each function it appears in
>> drivers/usb/serial/ftdi_sio.c:1606:18: error: 'SZ_128' undeclared (first use 
>> in this function); did you mean 'SZ_2K'?
  nvmconf.size = SZ_128;
 ^~
 SZ_2K

vim +/SZ_2K +1603 drivers/usb/serial/ftdi_sio.c

  1594  
  1595  static int ftdi_register_eeprom(struct usb_serial_port *port)
  1596  {
  1597  struct ftdi_private *priv = usb_get_serial_port_data(port);
  1598  struct usb_device *udev = port->serial->dev;
  1599  struct nvmem_config nvmconf = {};
  1600  
  1601  switch (priv->chip_type) {
  1602  case FTX:
> 1603  nvmconf.size = SZ_2K;
  1604  break;
  1605  case FT232RL:
> 1606  nvmconf.size = SZ_128;
  1607  break;
  1608  default:
  1609  return 0;
  1610  }
  1611  
  1612  nvmconf.word_size = 2;
  1613  nvmconf.stride = 2;
  1614  nvmconf.read_only = false;
  1615  nvmconf.priv = port;
  1616  nvmconf.dev = >dev;
  1617  nvmconf.reg_read = ftdi_read_eeprom;
  1618  nvmconf.reg_write = ftdi_write_eeprom;
  1619  nvmconf.owner = THIS_MODULE;
  1620  
  1621  priv->eeprom = nvmem_register();
  1622  if (IS_ERR(priv->eeprom)) {
  1623  dev_err(>dev, "Unable to register FTDI EEPROM\n");
  1624  priv->eeprom = NULL;
  1625  return -ENOMEM;
  1626  }
  1627  
  1628  dev_info(>dev, "Registered %d-byte FTDI EEPROM\n", 
nvmconf.size);
  1629  
  1630  return 0;
  1631  }
  1632  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH v4] USB: serial: ftdi_sio: Add MTP NVM support

[kbuild test robot]

Hi Loic,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.18-rc2 next-20180625]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Loic-Poulain/USB-serial-ftdi_sio-Add-MTP-NVM-support/20180625-181125
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: ia64-allyesconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

   drivers/usb/serial/ftdi_sio.c: In function 'ftdi_register_eeprom':
   drivers/usb/serial/ftdi_sio.c:1603:18: error: 'SZ_2K' undeclared (first use 
in this function)
  nvmconf.size = SZ_2K;
 ^
   drivers/usb/serial/ftdi_sio.c:1603:18: note: each undeclared identifier is 
reported only once for each function it appears in
>> drivers/usb/serial/ftdi_sio.c:1606:18: error: 'SZ_128' undeclared (first use 
>> in this function)
  nvmconf.size = SZ_128;
 ^~

vim +/SZ_128 +1606 drivers/usb/serial/ftdi_sio.c

  1594  
  1595  static int ftdi_register_eeprom(struct usb_serial_port *port)
  1596  {
  1597  struct ftdi_private *priv = usb_get_serial_port_data(port);
  1598  struct usb_device *udev = port->serial->dev;
  1599  struct nvmem_config nvmconf = {};
  1600  
  1601  switch (priv->chip_type) {
  1602  case FTX:
> 1603  nvmconf.size = SZ_2K;
  1604  break;
  1605  case FT232RL:
> 1606  nvmconf.size = SZ_128;
  1607  break;
  1608  default:
  1609  return 0;
  1610  }
  1611  
  1612  nvmconf.word_size = 2;
  1613  nvmconf.stride = 2;
  1614  nvmconf.read_only = false;
  1615  nvmconf.priv = port;
  1616  nvmconf.dev = >dev;
  1617  nvmconf.reg_read = ftdi_read_eeprom;
  1618  nvmconf.reg_write = ftdi_write_eeprom;
  1619  nvmconf.owner = THIS_MODULE;
  1620  
  1621  priv->eeprom = nvmem_register();
  1622  if (IS_ERR(priv->eeprom)) {
  1623  dev_err(>dev, "Unable to register FTDI EEPROM\n");
  1624  priv->eeprom = NULL;
  1625  return -ENOMEM;
  1626  }
  1627  
  1628  dev_info(>dev, "Registered %d-byte FTDI EEPROM\n", 
nvmconf.size);
  1629  
  1630  return 0;
  1631  }
  1632  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH] usb: gadget: uvc: configfs: Add bFrameIndex attributes

[kbuild test robot]

Hi Joel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.17 next-20180608]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Laurent-Pinchart/usb-gadget-uvc-configfs-Add-bFrameIndex-attributes/20180609-194618
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-x011-201822 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> drivers/usb/gadget/function/uvc_configfs.c:994:20: error: expected ')' 
>> before numeric constant
  noop_conversion, 8);
   ^
>> drivers/usb/gadget/function/uvc_configfs.c:1141:3: error: 
>> 'uvcg_frame_attr_b_frame_index' undeclared here (not in a function); did you 
>> mean 'uvcg_frame_attr_dw_frame_interval'?
 _frame_attr_b_frame_index,
  ^
  uvcg_frame_attr_dw_frame_interval

vim +994 drivers/usb/gadget/function/uvc_configfs.c

   992  
   993  UVCG_FRAME_ATTR_RO(b_frame_index, bFrameIndex, noop_conversion,
 > 994  noop_conversion, 8);
   995  UVCG_FRAME_ATTR(bm_capabilities, bmCapabilities, noop_conversion,
   996  noop_conversion, 8);
   997  UVCG_FRAME_ATTR(w_width, wWidth, le16_to_cpu, cpu_to_le16, 16);
   998  UVCG_FRAME_ATTR(w_height, wHeight, le16_to_cpu, cpu_to_le16, 16);
   999  UVCG_FRAME_ATTR(dw_min_bit_rate, dwMinBitRate, le32_to_cpu, 
cpu_to_le32, 32);
  1000  UVCG_FRAME_ATTR(dw_max_bit_rate, dwMaxBitRate, le32_to_cpu, 
cpu_to_le32, 32);
  1001  UVCG_FRAME_ATTR(dw_max_video_frame_buffer_size, 
dwMaxVideoFrameBufferSize,
  1002  le32_to_cpu, cpu_to_le32, 32);
  1003  UVCG_FRAME_ATTR(dw_default_frame_interval, dwDefaultFrameInterval,
  1004  le32_to_cpu, cpu_to_le32, 32);
  1005  
  1006  #undef noop_conversion
  1007  
  1008  #undef UVCG_FRAME_ATTR
  1009  
  1010  static ssize_t uvcg_frame_dw_frame_interval_show(struct config_item 
*item,
  1011   char *page)
  1012  {
  1013  struct uvcg_frame *frm = to_uvcg_frame(item);
  1014  struct f_uvc_opts *opts;
  1015  struct config_item *opts_item;
  1016  struct mutex *su_mutex = 
>item.ci_group->cg_subsys->su_mutex;
  1017  int result, i;
  1018  char *pg = page;
  1019  
  1020  mutex_lock(su_mutex); /* for navigating configfs hierarchy */
  1021  
  1022  opts_item = 
frm->item.ci_parent->ci_parent->ci_parent->ci_parent;
  1023  opts = to_f_uvc_opts(opts_item);
  1024  
  1025  mutex_lock(>lock);
  1026  for (result = 0, i = 0; i < frm->frame.b_frame_interval_type; 
++i) {
  1027  result += sprintf(pg, "%d\n",
  1028
le32_to_cpu(frm->dw_frame_interval[i]));
  1029  pg = page + result;
  1030  }
  1031  mutex_unlock(>lock);
  1032  
  1033  mutex_unlock(su_mutex);
  1034  return result;
  1035  }
  1036  
  1037  static inline int __uvcg_count_frm_intrv(char *buf, void *priv)
  1038  {
  1039  ++*((int *)priv);
  1040  return 0;
  1041  }
  1042  
  1043  static inline int __uvcg_fill_frm_intrv(char *buf, void *priv)
  1044  {
  1045  u32 num, **interv;
  1046  int ret;
  1047  
  1048  ret = kstrtou32(buf, 0, );
  1049  if (ret)
  1050  return ret;
  1051  
  1052  interv = priv;
  1053  **interv = cpu_to_le32(num);
  1054  ++*interv;
  1055  
  1056  return 0;
  1057  }
  1058  
  1059  static int __uvcg_iter_frm_intrv(const char *page, size_t len,
  1060   int (*fun)(char *, void *), void *priv)
  1061  {
  1062  /* sign, base 2 representation, newline, terminator */
  1063  char buf[1 + sizeof(u32) * 8 + 1 + 1];
  1064  const char *pg = page;
  1065  int i, ret;
  1066  
  1067  if (!fun)
  1068  return -EINVAL;
  1069  
  1070  while (pg - page < len) {
  1071  i = 0;
  1072  while (i < sizeof(buf) && (pg - page < len) &&
  1073  *pg != '\0' && *pg != '\n')
  1074  buf[i++] = *pg++;
  1075  if (i == sizeof(buf))
  1076  return -EINVAL;
  1077  while ((pg - page < len) && (*pg == '\0' || *pg == 
'\n'))
  1078  ++pg;
  1079  buf[i] = '\0';
  1080  ret = fun(buf, priv);
  1081  if (ret)
  1082  return ret;
  1083  }
  1084  
  1085  return 0;
  1086  }
  

Re: [PATCH] usb: gadget: uvc: configfs: Add bFrameIndex attributes

[kbuild test robot]

Hi Joel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.17 next-20180608]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Laurent-Pinchart/usb-gadget-uvc-configfs-Add-bFrameIndex-attributes/20180609-194618
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-s0-06091928 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/usb//gadget/function/uvc_configfs.c:994:20: error: expected ')' 
before numeric constant
  noop_conversion, 8);
   ^
>> drivers/usb//gadget/function/uvc_configfs.c:1141:3: error: 
>> 'uvcg_frame_attr_b_frame_index' undeclared here (not in a function)
 _frame_attr_b_frame_index,
  ^

vim +/uvcg_frame_attr_b_frame_index +1141 
drivers/usb//gadget/function/uvc_configfs.c

   992  
   993  UVCG_FRAME_ATTR_RO(b_frame_index, bFrameIndex, noop_conversion,
 > 994  noop_conversion, 8);
   995  UVCG_FRAME_ATTR(bm_capabilities, bmCapabilities, noop_conversion,
   996  noop_conversion, 8);
   997  UVCG_FRAME_ATTR(w_width, wWidth, le16_to_cpu, cpu_to_le16, 16);
   998  UVCG_FRAME_ATTR(w_height, wHeight, le16_to_cpu, cpu_to_le16, 16);
   999  UVCG_FRAME_ATTR(dw_min_bit_rate, dwMinBitRate, le32_to_cpu, 
cpu_to_le32, 32);
  1000  UVCG_FRAME_ATTR(dw_max_bit_rate, dwMaxBitRate, le32_to_cpu, 
cpu_to_le32, 32);
  1001  UVCG_FRAME_ATTR(dw_max_video_frame_buffer_size, 
dwMaxVideoFrameBufferSize,
  1002  le32_to_cpu, cpu_to_le32, 32);
  1003  UVCG_FRAME_ATTR(dw_default_frame_interval, dwDefaultFrameInterval,
  1004  le32_to_cpu, cpu_to_le32, 32);
  1005  
  1006  #undef noop_conversion
  1007  
  1008  #undef UVCG_FRAME_ATTR
  1009  
  1010  static ssize_t uvcg_frame_dw_frame_interval_show(struct config_item 
*item,
  1011   char *page)
  1012  {
  1013  struct uvcg_frame *frm = to_uvcg_frame(item);
  1014  struct f_uvc_opts *opts;
  1015  struct config_item *opts_item;
  1016  struct mutex *su_mutex = 
>item.ci_group->cg_subsys->su_mutex;
  1017  int result, i;
  1018  char *pg = page;
  1019  
  1020  mutex_lock(su_mutex); /* for navigating configfs hierarchy */
  1021  
  1022  opts_item = 
frm->item.ci_parent->ci_parent->ci_parent->ci_parent;
  1023  opts = to_f_uvc_opts(opts_item);
  1024  
  1025  mutex_lock(>lock);
  1026  for (result = 0, i = 0; i < frm->frame.b_frame_interval_type; 
++i) {
  1027  result += sprintf(pg, "%d\n",
  1028
le32_to_cpu(frm->dw_frame_interval[i]));
  1029  pg = page + result;
  1030  }
  1031  mutex_unlock(>lock);
  1032  
  1033  mutex_unlock(su_mutex);
  1034  return result;
  1035  }
  1036  
  1037  static inline int __uvcg_count_frm_intrv(char *buf, void *priv)
  1038  {
  1039  ++*((int *)priv);
  1040  return 0;
  1041  }
  1042  
  1043  static inline int __uvcg_fill_frm_intrv(char *buf, void *priv)
  1044  {
  1045  u32 num, **interv;
  1046  int ret;
  1047  
  1048  ret = kstrtou32(buf, 0, );
  1049  if (ret)
  1050  return ret;
  1051  
  1052  interv = priv;
  1053  **interv = cpu_to_le32(num);
  1054  ++*interv;
  1055  
  1056  return 0;
  1057  }
  1058  
  1059  static int __uvcg_iter_frm_intrv(const char *page, size_t len,
  1060   int (*fun)(char *, void *), void *priv)
  1061  {
  1062  /* sign, base 2 representation, newline, terminator */
  1063  char buf[1 + sizeof(u32) * 8 + 1 + 1];
  1064  const char *pg = page;
  1065  int i, ret;
  1066  
  1067  if (!fun)
  1068  return -EINVAL;
  1069  
  1070  while (pg - page < len) {
  1071  i = 0;
  1072  while (i < sizeof(buf) && (pg - page < len) &&
  1073  *pg != '\0' && *pg != '\n')
  1074  buf[i++] = *pg++;
  1075  if (i == sizeof(buf))
  1076  return -EINVAL;
  1077  while ((pg - page < len) && (*pg == '\0' || *pg == 
'\n'))
  1078  ++pg;
  1079  buf[i] = '\0';
  1080  ret = fun(buf, priv);
  1081  if (ret)
  1082  return ret;
  1083  }
  1084  
  1085  return 0;
  1086  }
  1087  
  1088  static ssize_t 

Re: [PATCH v6 05/15] usb: typec: add API to get typec basic port power and data config

[kbuild test robot]

Hi Li,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.17-rc7 next-20180529]
[cannot apply to staging/staging-testing]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Li-Jun/staging-typec-tcpci-move-out-of-staging/20180530-110011
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: i386-randconfig-s1-201821 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from include/linux/linkage.h:7:0,
from include/linux/kernel.h:7,
from include/linux/list.h:9,
from include/linux/kobject.h:19,
from include/linux/device.h:16,
from drivers/usb//typec/class.c:9:
>> drivers/usb//typec/class.c:1274:19: error: 'typec_find_power_type' 
>> undeclared here (not in a function)
EXPORT_SYMBOL_GPL(typec_find_power_type);
  ^
   include/linux/export.h:65:16: note: in definition of macro '___EXPORT_SYMBOL'
 extern typeof(sym) sym;  \
   ^~~
   drivers/usb//typec/class.c:1274:1: note: in expansion of macro 
'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(typec_find_power_type);
^
>> drivers/usb//typec/class.c:1288:19: error: 'typec_find_preferred_role' 
>> undeclared here (not in a function)
EXPORT_SYMBOL_GPL(typec_find_preferred_role);
  ^
   include/linux/export.h:65:16: note: in definition of macro '___EXPORT_SYMBOL'
 extern typeof(sym) sym;  \
   ^~~
   drivers/usb//typec/class.c:1288:1: note: in expansion of macro 
'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(typec_find_preferred_role);
^
>> drivers/usb//typec/class.c:1303:19: error: 'typec_find_data_type' undeclared 
>> here (not in a function)
EXPORT_SYMBOL_GPL(typec_find_data_type);
  ^
   include/linux/export.h:65:16: note: in definition of macro '___EXPORT_SYMBOL'
 extern typeof(sym) sym;  \
   ^~~
   drivers/usb//typec/class.c:1303:1: note: in expansion of macro 
'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(typec_find_data_type);
^

vim +/typec_find_power_type +1274 drivers/usb//typec/class.c

  1260  
  1261  /**
  1262   * typec_find_port_power_role - Get the typec port power capability
  1263   * @name: port power capability string
  1264   *
  1265   * This routine is used to find the typec_port_type by its string name.
  1266   *
  1267   * Returns typec_port_type if success, otherwise negative error code.
  1268   */
  1269  int typec_find_port_power_role(const char *name)
  1270  {
  1271  return match_string(typec_port_types, 
ARRAY_SIZE(typec_port_types),
  1272  name);
  1273  }
> 1274  EXPORT_SYMBOL_GPL(typec_find_power_type);
  1275  
  1276  /**
  1277   * typec_find_power_role - Find the typec one specific power role
  1278   * @name: power role string
  1279   *
  1280   * This routine is used to find the typec_role by its string name.
  1281   *
  1282   * Returns typec_role if success, otherwise negative error code.
  1283   */
  1284  int typec_find_power_role(const char *name)
  1285  {
  1286  return match_string(typec_roles, ARRAY_SIZE(typec_roles), name);
  1287  }
> 1288  EXPORT_SYMBOL_GPL(typec_find_preferred_role);
  1289  
  1290  /**
  1291   * typec_find_port_data_role - Get the typec port data capability
  1292   * @name: port data capability string
  1293   *
  1294   * This routine is used to find the typec_port_data by its string name.
  1295   *
  1296   * Returns typec_port_data if success, otherwise negative error code.
  1297   */
  1298  int typec_find_port_data_role(const char *name)
  1299  {
  1300  return match_string(typec_data_caps, 
ARRAY_SIZE(typec_data_caps),
  1301  name);
  1302  }
> 1303  EXPORT_SYMBOL_GPL(typec_find_data_type);
  1304  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH v6 05/15] usb: typec: add API to get typec basic port power and data config

[kbuild test robot]

Hi Li,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.17-rc7 next-20180529]
[cannot apply to staging/staging-testing]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Li-Jun/staging-typec-tcpci-move-out-of-staging/20180530-110011
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: i386-randconfig-x017-201821 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/linkage.h:7:0,
from include/linux/kernel.h:7,
from include/linux/list.h:9,
from include/linux/kobject.h:19,
from include/linux/device.h:16,
from drivers/usb/typec/class.c:9:
>> drivers/usb/typec/class.c:1274:19: error: 'typec_find_power_type' undeclared 
>> here (not in a function); did you mean 'typec_find_power_role'?
EXPORT_SYMBOL_GPL(typec_find_power_type);
  ^
   include/linux/export.h:65:16: note: in definition of macro '___EXPORT_SYMBOL'
 extern typeof(sym) sym;  \
   ^~~
>> drivers/usb/typec/class.c:1274:1: note: in expansion of macro 
>> 'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(typec_find_power_type);
^
>> drivers/usb/typec/class.c:1288:19: error: 'typec_find_preferred_role' 
>> undeclared here (not in a function); did you mean 'typec_find_power_role'?
EXPORT_SYMBOL_GPL(typec_find_preferred_role);
  ^
   include/linux/export.h:65:16: note: in definition of macro '___EXPORT_SYMBOL'
 extern typeof(sym) sym;  \
   ^~~
   drivers/usb/typec/class.c:1288:1: note: in expansion of macro 
'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(typec_find_preferred_role);
^
>> drivers/usb/typec/class.c:1303:19: error: 'typec_find_data_type' undeclared 
>> here (not in a function); did you mean 'typec_find_power_type'?
EXPORT_SYMBOL_GPL(typec_find_data_type);
  ^
   include/linux/export.h:65:16: note: in definition of macro '___EXPORT_SYMBOL'
 extern typeof(sym) sym;  \
   ^~~
   drivers/usb/typec/class.c:1303:1: note: in expansion of macro 
'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(typec_find_data_type);
^

vim +1274 drivers/usb/typec/class.c

  1260  
  1261  /**
  1262   * typec_find_port_power_role - Get the typec port power capability
  1263   * @name: port power capability string
  1264   *
  1265   * This routine is used to find the typec_port_type by its string name.
  1266   *
  1267   * Returns typec_port_type if success, otherwise negative error code.
  1268   */
  1269  int typec_find_port_power_role(const char *name)
  1270  {
  1271  return match_string(typec_port_types, 
ARRAY_SIZE(typec_port_types),
  1272  name);
  1273  }
> 1274  EXPORT_SYMBOL_GPL(typec_find_power_type);
  1275  
  1276  /**
  1277   * typec_find_power_role - Find the typec one specific power role
  1278   * @name: power role string
  1279   *
  1280   * This routine is used to find the typec_role by its string name.
  1281   *
  1282   * Returns typec_role if success, otherwise negative error code.
  1283   */
  1284  int typec_find_power_role(const char *name)
  1285  {
  1286  return match_string(typec_roles, ARRAY_SIZE(typec_roles), name);
  1287  }
> 1288  EXPORT_SYMBOL_GPL(typec_find_preferred_role);
  1289  
  1290  /**
  1291   * typec_find_port_data_role - Get the typec port data capability
  1292   * @name: port data capability string
  1293   *
  1294   * This routine is used to find the typec_port_data by its string name.
  1295   *
  1296   * Returns typec_port_data if success, otherwise negative error code.
  1297   */
  1298  int typec_find_port_data_role(const char *name)
  1299  {
  1300  return match_string(typec_data_caps, 
ARRAY_SIZE(typec_data_caps),
  1301  name);
  1302  }
> 1303  EXPORT_SYMBOL_GPL(typec_find_data_type);
  1304  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[usb:debugfs_cleanup 109/109] drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 'RTL_DEBUGFS_ADD_CORE'

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
debugfs_cleanup
head:   1c66923f2afb1578348d1f92ce01c1b9f5216dd4
commit: 1c66923f2afb1578348d1f92ce01c1b9f5216dd4 [109/109] usb: debugfs cleanup 
- try 2
config: i386-allmodconfig (attached as .config)
compiler: gcc-8 (Debian 8.1.0-3) 8.1.0
reproduce:
git checkout 1c66923f2afb1578348d1f92ce01c1b9f5216dd4
# save the attached .config to linux build tree
make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/staging/rtlwifi/debug.c: In function 'rtl_debug_add_one':
   drivers/staging/rtlwifi/debug.c:534:9: error: invalid operands to binary & 
(have 'struct dentry *' and 'struct rtl_debugfs_priv')
_debug_priv_ ##name, \
^
>> drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 
>> 'RTL_DEBUGFS_ADD_CORE'
  RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common)
  ^~~~
>> drivers/staging/rtlwifi/debug.c:565:2: note: in expansion of macro 
>> 'RTL_DEBUGFS_ADD'
 RTL_DEBUGFS_ADD(mac_0);
 ^~~
   drivers/staging/rtlwifi/debug.c:535:9: warning: passing argument 4 of 
'debugfs_create_file' discards 'const' qualifier from pointer target type 
[-Wdiscarded-qualifiers]
_ops_ ##fopname); \
^~
>> drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 
>> 'RTL_DEBUGFS_ADD_CORE'
  RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common)
  ^~~~
>> drivers/staging/rtlwifi/debug.c:565:2: note: in expansion of macro 
>> 'RTL_DEBUGFS_ADD'
 RTL_DEBUGFS_ADD(mac_0);
 ^~~
   In file included from include/net/cfg80211.h:17,
from include/net/mac80211.h:24,
from drivers/staging/rtlwifi/wifi.h:36,
from drivers/staging/rtlwifi/debug.c:25:
   include/linux/debugfs.h:61:16: note: expected 'void *' but argument is of 
type 'const struct file_operations *'
struct dentry *debugfs_create_file(const char *name, umode_t mode,
   ^~~
   drivers/staging/rtlwifi/debug.c:533:3: error: too few arguments to function 
'debugfs_create_file'
  debugfs_create_file(#name, mode, parent  \
  ^~~
>> drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 
>> 'RTL_DEBUGFS_ADD_CORE'
  RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common)
  ^~~~
>> drivers/staging/rtlwifi/debug.c:565:2: note: in expansion of macro 
>> 'RTL_DEBUGFS_ADD'
 RTL_DEBUGFS_ADD(mac_0);
 ^~~
   In file included from include/net/cfg80211.h:17,
from include/net/mac80211.h:24,
from drivers/staging/rtlwifi/wifi.h:36,
from drivers/staging/rtlwifi/debug.c:25:
   include/linux/debugfs.h:61:16: note: declared here
struct dentry *debugfs_create_file(const char *name, umode_t mode,
   ^~~
   drivers/staging/rtlwifi/debug.c:534:9: error: invalid operands to binary & 
(have 'struct dentry *' and 'struct rtl_debugfs_priv')
_debug_priv_ ##name, \
^
>> drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 
>> 'RTL_DEBUGFS_ADD_CORE'
  RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common)
  ^~~~
   drivers/staging/rtlwifi/debug.c:566:2: note: in expansion of macro 
'RTL_DEBUGFS_ADD'
 RTL_DEBUGFS_ADD(mac_1);
 ^~~
   drivers/staging/rtlwifi/debug.c:535:9: warning: passing argument 4 of 
'debugfs_create_file' discards 'const' qualifier from pointer target type 
[-Wdiscarded-qualifiers]
_ops_ ##fopname); \
^~
>> drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 
>> 'RTL_DEBUGFS_ADD_CORE'
  RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common)
  ^~~~
   drivers/staging/rtlwifi/debug.c:566:2: note: in expansion of macro 
'RTL_DEBUGFS_ADD'
 RTL_DEBUGFS_ADD(mac_1);
 ^~~
   In file included from include/net/cfg80211.h:17,
from include/net/mac80211.h:24,
from drivers/staging/rtlwifi/wifi.h:36,
from drivers/staging/rtlwifi/debug.c:25:
   include/linux/debugfs.h:61:16: note: expected 'void *' but argument is of 
type 'const struct file_operations *'
struct dentry *debugfs_create_file(const char *name, umode_t mode,
   ^~~
   drivers/staging/rtlwifi/debug.c:533:3: error: too few arguments to function 
'debugfs_create_file'
  debugfs_create_file(#name, mode, parent  \
  ^~~
>> drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 
>> 'RTL_DEBUGFS_ADD_CORE'
  RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common)
  ^~~~
   drivers/staging/rtlwifi/debug.c:566:2: note: in expansion of macro 
'RTL_DEBUGFS_ADD'
 RTL_DEBUGFS_ADD(mac_1);
 ^~~

[usb:debugfs_cleanup 109/109] drivers/staging/rtlwifi/debug.c:534:9: error: invalid operands to binary & (have 'struct dentry *' and 'struct rtl_debugfs_priv')

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
debugfs_cleanup
head:   1c66923f2afb1578348d1f92ce01c1b9f5216dd4
commit: 1c66923f2afb1578348d1f92ce01c1b9f5216dd4 [109/109] usb: debugfs cleanup 
- try 2
config: i386-randconfig-i0-201821 (attached as .config)
compiler: gcc-8 (Debian 8.1.0-3) 8.1.0
reproduce:
git checkout 1c66923f2afb1578348d1f92ce01c1b9f5216dd4
# save the attached .config to linux build tree
make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   drivers/staging/rtlwifi/debug.c: In function 'rtl_debug_add_one':
>> drivers/staging/rtlwifi/debug.c:534:9: error: invalid operands to binary & 
>> (have 'struct dentry *' and 'struct rtl_debugfs_priv')
_debug_priv_ ##name, \
^
   drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 
'RTL_DEBUGFS_ADD_CORE'
  RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common)
  ^~~~
   drivers/staging/rtlwifi/debug.c:565:2: note: in expansion of macro 
'RTL_DEBUGFS_ADD'
 RTL_DEBUGFS_ADD(mac_0);
 ^~~
>> drivers/staging/rtlwifi/debug.c:535:9: warning: passing argument 4 of 
>> 'debugfs_create_file' discards 'const' qualifier from pointer target type 
>> [-Wdiscarded-qualifiers]
_ops_ ##fopname); \
^~
   drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 
'RTL_DEBUGFS_ADD_CORE'
  RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common)
  ^~~~
   drivers/staging/rtlwifi/debug.c:565:2: note: in expansion of macro 
'RTL_DEBUGFS_ADD'
 RTL_DEBUGFS_ADD(mac_0);
 ^~~
   In file included from include/net/cfg80211.h:17,
from include/net/mac80211.h:24,
from drivers/staging/rtlwifi/wifi.h:36,
from drivers/staging/rtlwifi/debug.c:25:
   include/linux/debugfs.h:61:16: note: expected 'void *' but argument is of 
type 'const struct file_operations *'
struct dentry *debugfs_create_file(const char *name, umode_t mode,
   ^~~
>> drivers/staging/rtlwifi/debug.c:533:3: error: too few arguments to function 
>> 'debugfs_create_file'
  debugfs_create_file(#name, mode, parent  \
  ^~~
   drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 
'RTL_DEBUGFS_ADD_CORE'
  RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common)
  ^~~~
   drivers/staging/rtlwifi/debug.c:565:2: note: in expansion of macro 
'RTL_DEBUGFS_ADD'
 RTL_DEBUGFS_ADD(mac_0);
 ^~~
   In file included from include/net/cfg80211.h:17,
from include/net/mac80211.h:24,
from drivers/staging/rtlwifi/wifi.h:36,
from drivers/staging/rtlwifi/debug.c:25:
   include/linux/debugfs.h:61:16: note: declared here
struct dentry *debugfs_create_file(const char *name, umode_t mode,
   ^~~
>> drivers/staging/rtlwifi/debug.c:534:9: error: invalid operands to binary & 
>> (have 'struct dentry *' and 'struct rtl_debugfs_priv')
_debug_priv_ ##name, \
^
   drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 
'RTL_DEBUGFS_ADD_CORE'
  RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common)
  ^~~~
   drivers/staging/rtlwifi/debug.c:566:2: note: in expansion of macro 
'RTL_DEBUGFS_ADD'
 RTL_DEBUGFS_ADD(mac_1);
 ^~~
>> drivers/staging/rtlwifi/debug.c:535:9: warning: passing argument 4 of 
>> 'debugfs_create_file' discards 'const' qualifier from pointer target type 
>> [-Wdiscarded-qualifiers]
_ops_ ##fopname); \
^~
   drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 
'RTL_DEBUGFS_ADD_CORE'
  RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common)
  ^~~~
   drivers/staging/rtlwifi/debug.c:566:2: note: in expansion of macro 
'RTL_DEBUGFS_ADD'
 RTL_DEBUGFS_ADD(mac_1);
 ^~~
   In file included from include/net/cfg80211.h:17,
from include/net/mac80211.h:24,
from drivers/staging/rtlwifi/wifi.h:36,
from drivers/staging/rtlwifi/debug.c:25:
   include/linux/debugfs.h:61:16: note: expected 'void *' but argument is of 
type 'const struct file_operations *'
struct dentry *debugfs_create_file(const char *name, umode_t mode,
   ^~~
>> drivers/staging/rtlwifi/debug.c:533:3: error: too few arguments to function 
>> 'debugfs_create_file'
  debugfs_create_file(#name, mode, parent  \
  ^~~
   drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 
'RTL_DEBUGFS_ADD_CORE'
  RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common)
  ^~~~
   drivers/staging/rtlwifi/debug.c:566:2: note: in expansion of macro 
'RTL_DEBUGFS_ADD'
 RTL_DEBUGFS_ADD(mac_1);
 

[usb:debugfs_cleanup 109/109] drivers/usb/typec/tcpm.c:580:9: warning: 'return' with a value, in function returning void

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
debugfs_cleanup
head:   7b3bcbfe0aeedeec64c83cf9655273e8f42f1c54
commit: 7b3bcbfe0aeedeec64c83cf9655273e8f42f1c54 [109/109] usb: debugfs cleanup
config: i386-randconfig-s1-201821 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
git checkout 7b3bcbfe0aeedeec64c83cf9655273e8f42f1c54
# save the attached .config to linux build tree
make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/usb/typec/tcpm.c: In function 'tcpm_debugfs_init':
>> drivers/usb/typec/tcpm.c:580:9: warning: 'return' with a value, in function 
>> returning void
 return 0;
^
   drivers/usb/typec/tcpm.c:569:13: note: declared here
static void tcpm_debugfs_init(struct tcpm_port *port)
^

vim +/return +580 drivers/usb/typec/tcpm.c

f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck  2017-04-27  568  
7b3bcbfe drivers/usb/typec/tcpm.c Greg Kroah-Hartman 2018-05-29  569  
static void tcpm_debugfs_init(struct tcpm_port *port)
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck  2017-04-27  570  {
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck  2017-04-27  571
mutex_init(>logbuffer_lock);
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck  2017-04-27  572
/* /sys/kernel/debug/tcpm/usbcX */
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck  2017-04-27  573
if (!rootdir)
7b3bcbfe drivers/usb/typec/tcpm.c Greg Kroah-Hartman 2018-05-29  574
rootdir = debugfs_create_dir("tcpm", NULL);
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck  2017-04-27  575  
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck  2017-04-27  576
port->dentry = debugfs_create_file(dev_name(port->dev),
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck  2017-04-27  577
   S_IFREG | 0444, rootdir,
9e902c59 drivers/usb/typec/tcpm.c Andy Shevchenko2018-02-14  578
   port, _debug_fops);
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck  2017-04-27  579  
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck  2017-04-27 @580
return 0;
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck  2017-04-27  581  }
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck  2017-04-27  582  

:: The code at line 580 was first introduced by commit
:: f0690a25a140b853b1842fa80faf828601bb47e8 staging: typec: USB Type-C Port 
Manager (tcpm)

:: TO: Guenter Roeck 
:: CC: Greg Kroah-Hartman 

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[usb:usb-next 72/107] drivers/usb/host/xhci-mem.c:2250 xhci_create_rhub_port_array() error: potential null dereference 'rhub->ports'. (kcalloc returns null)

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
head:   58c38116c6cc5bcb6d952ca72111a7a15d4604a2
commit: bcaa9d5c59005eceed5f2112c13240401f0fb93b [72/107] xhci: Create new 
structures to store xhci port information

New smatch warnings:
drivers/usb/host/xhci-mem.c:2250 xhci_create_rhub_port_array() error: potential 
null dereference 'rhub->ports'.  (kcalloc returns null)

Old smatch warnings:
drivers/usb/host/xhci-mem.c:2280 xhci_setup_port_arrays() error: potential null 
dereference 'xhci->hw_ports'.  (kcalloc returns null)

vim +2250 drivers/usb/host/xhci-mem.c

  2235  
  2236  static void xhci_create_rhub_port_array(struct xhci_hcd *xhci,
  2237  struct xhci_hub *rhub, gfp_t 
flags)
  2238  {
  2239  int port_index = 0;
  2240  int i;
  2241  
  2242  if (!rhub->num_ports)
  2243  return;
  2244  rhub->ports = kcalloc(rhub->num_ports, sizeof(rhub->ports), 
flags);
  2245  for (i = 0; i < HCS_MAX_PORTS(xhci->hcs_params1); i++) {
  2246  if (xhci->hw_ports[i].rhub != rhub ||
  2247  xhci->hw_ports[i].hcd_portnum == DUPLICATE_ENTRY)
  2248  continue;
  2249  xhci->hw_ports[i].hcd_portnum = port_index;
> 2250  rhub->ports[port_index] = >hw_ports[i];
  2251  port_index++;
  2252  if (port_index == rhub->num_ports)
  2253  break;
  2254  }
  2255  }
  2256  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1 2/4] usb: dwc2: Modify dwc2_readl/writel functions prototype

[kbuild test robot]

Hi Gevorg,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.17-rc6]
[cannot apply to balbi-usb/next next-20180517]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Gevorg-Sahakyan/usb-dwc2-Make-dwc2-endianness-agnostic/20180523-062909
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: i386-randconfig-x078-201820 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/usb/dwc2/gadget.c: In function 'dwc2_hsotg_ep_enable':
>> drivers/usb/dwc2/gadget.c:3943:17: error: too few arguments to function 
>> 'dwc2_readl'
  u32 gsnpsid = dwc2_readl(hsotg->regs + GSNPSID);
^~
   In file included from drivers/usb/dwc2/gadget.c:31:0:
   drivers/usb/dwc2/core.h:1085:19: note: declared here
static inline u32 dwc2_readl(struct dwc2_hsotg *hsotg, u32 offset)
  ^~

vim +/dwc2_readl +3943 drivers/usb/dwc2/gadget.c

a4f827714 drivers/usb/dwc2/gadget.c  Vahram Aharonyan   2016-11-14  3769  
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3770  
/**
1f91b4cc0 drivers/usb/dwc2/gadget.c  Felipe Balbi   2015-08-06  3771   
* dwc2_hsotg_ep_enable - enable the given endpoint
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3772   
* @ep: The USB endpint to configure
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3773   
* @desc: The USB endpoint descriptor to configure with.
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3774   *
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3775   
* This is called from the USB gadget code's usb_ep_enable().
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3776   
*/
1f91b4cc0 drivers/usb/dwc2/gadget.c  Felipe Balbi   2015-08-06  3777  
static int dwc2_hsotg_ep_enable(struct usb_ep *ep,
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3778
const struct usb_endpoint_descriptor *desc)
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3779  {
1f91b4cc0 drivers/usb/dwc2/gadget.c  Felipe Balbi   2015-08-06  3780
struct dwc2_hsotg_ep *hs_ep = our_ep(ep);
941fcce4f drivers/usb/dwc2/gadget.c  Dinh Nguyen2014-11-11  3781
struct dwc2_hsotg *hsotg = hs_ep->parent;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3782
unsigned long flags;
ca4c55ad8 drivers/usb/dwc2/gadget.c  Mian Yousaf Kaukab 2015-01-09  3783
unsigned int index = hs_ep->index;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3784
u32 epctrl_reg;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3785
u32 epctrl;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3786
u32 mps;
ee2c40de6 drivers/usb/dwc2/gadget.c  Vardan Mikayelyan  2016-11-08  3787
u32 mc;
837e9f00b drivers/usb/dwc2/gadget.c  Vardan Mikayelyan  2016-05-25  3788
u32 mask;
ca4c55ad8 drivers/usb/dwc2/gadget.c  Mian Yousaf Kaukab 2015-01-09  3789
unsigned int dir_in;
ca4c55ad8 drivers/usb/dwc2/gadget.c  Mian Yousaf Kaukab 2015-01-09  3790
unsigned int i, val, size;
19c190f9e drivers/usb/gadget/s3c-hsotg.c Julia Lawall   2010-03-29  3791
int ret = 0;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3792  
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3793
dev_dbg(hsotg->dev,
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3794
"%s: ep %s: a 0x%02x, attr 0x%02x, mps 0x%04x, intr %d\n",
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3795
__func__, ep->name, desc->bEndpointAddress, desc->bmAttributes,
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3796
desc->wMaxPacketSize, desc->bInterval);
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3797  
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3798
/* not to be called for EP0 */
8c3d60927 drivers/usb/dwc2/gadget.c  Vahram Aharonyan   2016-04-27  3799
if (index == 0) {
8c3d60927 drivers/usb/dwc2/gadget.c  Vahram Aharonyan   2016-04-27  3800
dev_err(hsotg->dev, "%s: called for EP 0\n", __func__);
8c3d60927 drivers/usb/dwc2/gadget.c  Vahram Aharonyan   2016-04-27  3801
return -EINVAL;
8c3d60927 drivers/usb/dwc2/gadget.c  Vahram Aharonyan   2016-04-27  3802
}
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks  2009-06-02  3803  
5b7d70c6d 

Re: [PATCH] NFC: pn533: don't send USB data off of the stack

[kbuild test robot]

Hi Greg,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.17-rc5 next-20180517]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Greg-KH/NFC-pn533-don-t-send-USB-data-off-of-the-stack/20180518-100416
config: i386-randconfig-x013-201819 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/nfc/pn533/usb.c: In function 'pn533_usb_send_ack':
>> drivers/nfc/pn533/usb.c:163:15: error: invalid operands to binary | (have 
>> 'struct urb *' and 'int')
 phy->out_urb |= URB_FREE_BUFFER;
  ^~
   drivers/nfc/pn533/usb.c: In function 'pn533_usb_send_frame':
   drivers/nfc/pn533/usb.c:180:15: error: invalid operands to binary & (have 
'struct urb *' and 'int')
 phy->out_urb &= ~URB_FREE_BUFFER;
  ^~
   drivers/nfc/pn533/usb.c: In function 'pn533_acr122_poweron_rdr':
   drivers/nfc/pn533/usb.c:406:15: error: invalid operands to binary | (have 
'struct urb *' and 'int')
 phy->out_urb |= URB_FREE_BUFFER;
  ^~

vim +163 drivers/nfc/pn533/usb.c

   147  
   148  static int pn533_usb_send_ack(struct pn533 *dev, gfp_t flags)
   149  {
   150  struct pn533_usb_phy *phy = dev->phy;
   151  static const u8 ack[6] = {0x00, 0x00, 0xff, 0x00, 0xff, 0x00};
   152  /* spec 7.1.1.3:  Preamble, SoPC (2), ACK Code (2), Postamble */
   153  char *buffer;
   154  int rc;
   155  
   156  buffer = kmalloc(sizeof(ack), GFP_KERNEL);
   157  if (!buffer)
   158  return -ENOMEM;
   159  memcpy(buffer, ack, sizeof(ack));
   160  
   161  phy->out_urb->transfer_buffer = (u8 *)ack;
   162  phy->out_urb->transfer_buffer_length = sizeof(ack);
 > 163  phy->out_urb |= URB_FREE_BUFFER;
   164  rc = usb_submit_urb(phy->out_urb, flags);
   165  
   166  return rc;
   167  }
   168  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[linux-next:master 7522/8111] drivers/usb/dwc3/drd.c:443:19: sparse: symbol 'dwc3_get_extcon' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 
master
head:   fbbe3b8c2c9c5f84caf668703c26154cb4fbb9d1
commit: 5f0b74e54890c354d6ac0124ea7a96adf22845d0 [7522/8111] USB: dwc3: get 
extcon device by OF graph bindings
reproduce:
# apt-get install sparse
git checkout 5f0b74e54890c354d6ac0124ea7a96adf22845d0
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/usb/dwc3/drd.c:443:19: sparse: symbol 'dwc3_get_extcon' was not 
>> declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static

[kbuild test robot]

Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings")
Signed-off-by: kbuild test robot <fengguang...@intel.com>
---
 drd.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
index 2706824..218371f 100644
--- a/drivers/usb/dwc3/drd.c
+++ b/drivers/usb/dwc3/drd.c
@@ -440,7 +440,7 @@ static int dwc3_drd_notifier(struct notifier_block *nb,
return NOTIFY_DONE;
 }
 
-struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
+static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
 {
struct device *dev = dwc->dev;
struct device_node *np_phy, *np_conn;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

[kbuild test robot]

Hi Florian,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:
https://github.com/0day-ci/linux/commits/Florian-Fainelli/of-mdio-Fall-back-to-mdiobus_register-with-np-is-NULL/20180516-203317
config: arm-omap2plus_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm 

All error/warnings (new ones prefixed by >>):

   drivers/net//ethernet/ti/davinci_mdio.c: In function 'davinci_mdio_probe':
>> drivers/net//ethernet/ti/davinci_mdio.c:457:12: error: invalid storage class 
>> for function 'davinci_mdio_remove'
static int davinci_mdio_remove(struct platform_device *pdev)
   ^~~
>> drivers/net//ethernet/ti/davinci_mdio.c:457:1: warning: ISO C90 forbids 
>> mixed declarations and code [-Wdeclaration-after-statement]
static int davinci_mdio_remove(struct platform_device *pdev)
^~
>> drivers/net//ethernet/ti/davinci_mdio.c:471:12: error: invalid storage class 
>> for function 'davinci_mdio_runtime_suspend'
static int davinci_mdio_runtime_suspend(struct device *dev)
   ^~~~
>> drivers/net//ethernet/ti/davinci_mdio.c:485:12: error: invalid storage class 
>> for function 'davinci_mdio_runtime_resume'
static int davinci_mdio_runtime_resume(struct device *dev)
   ^~~
>> drivers/net//ethernet/ti/davinci_mdio.c:495:12: error: invalid storage class 
>> for function 'davinci_mdio_suspend'
static int davinci_mdio_suspend(struct device *dev)
   ^~~~
>> drivers/net//ethernet/ti/davinci_mdio.c:512:12: error: invalid storage class 
>> for function 'davinci_mdio_resume'
static int davinci_mdio_resume(struct device *dev)
   ^~~
   In file included from include/linux/device.h:23:0,
from include/linux/platform_device.h:14,
from drivers/net//ethernet/ti/davinci_mdio.c:29:
>> drivers/net//ethernet/ti/davinci_mdio.c:527:21: error: initializer element 
>> is not constant
 SET_RUNTIME_PM_OPS(davinci_mdio_runtime_suspend,
^
   include/linux/pm.h:354:21: note: in definition of macro 'SET_RUNTIME_PM_OPS'
 .runtime_suspend = suspend_fn, \
^~
   drivers/net//ethernet/ti/davinci_mdio.c:527:21: note: (near initialization 
for 'davinci_mdio_pm_ops.runtime_suspend')
 SET_RUNTIME_PM_OPS(davinci_mdio_runtime_suspend,
^
   include/linux/pm.h:354:21: note: in definition of macro 'SET_RUNTIME_PM_OPS'
 .runtime_suspend = suspend_fn, \
^~
   drivers/net//ethernet/ti/davinci_mdio.c:528:7: error: initializer element is 
not constant
  davinci_mdio_runtime_resume, NULL)
  ^
   include/linux/pm.h:355:20: note: in definition of macro 'SET_RUNTIME_PM_OPS'
 .runtime_resume = resume_fn, \
   ^
   drivers/net//ethernet/ti/davinci_mdio.c:528:7: note: (near initialization 
for 'davinci_mdio_pm_ops.runtime_resume')
  davinci_mdio_runtime_resume, NULL)
  ^
   include/linux/pm.h:355:20: note: in definition of macro 'SET_RUNTIME_PM_OPS'
 .runtime_resume = resume_fn, \
   ^
   drivers/net//ethernet/ti/davinci_mdio.c:529:31: error: initializer element 
is not constant
 SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume)
  ^
   include/linux/pm.h:330:18: note: in definition of macro 
'SET_LATE_SYSTEM_SLEEP_PM_OPS'
 .suspend_late = suspend_fn, \
 ^~
   drivers/net//ethernet/ti/davinci_mdio.c:529:31: note: (near initialization 
for 'davinci_mdio_pm_ops.suspend_late')
 SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume)
  ^
   include/linux/pm.h:330:18: note: in definition of macro 
'SET_LATE_SYSTEM_SLEEP_PM_OPS'
 .suspend_late = suspend_fn, \
 ^~
   drivers/net//ethernet/ti/davinci_mdio.c:529:53: error: initializer element 
is not constant
 SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume)
^
   include/linux/pm.h:331:18: note: in definition of macro 
'SET_LATE_SYSTEM_SLEEP_PM_OPS'
 .resume_early = resume_fn, \
 ^
   drivers/net//ethernet/ti/davinci_mdio.c:529:53: note: (near initialization 
for 'davinci_mdio_pm_ops.resume_early')
 SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume)
^
   include/linux/pm.h:331:18: note: in definition of macro 

Re: [PATCH net-next 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

[kbuild test robot]

Hi Florian,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:
https://github.com/0day-ci/linux/commits/Florian-Fainelli/of-mdio-Fall-back-to-mdiobus_register-with-np-is-NULL/20180516-203317
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm 

All error/warnings (new ones prefixed by >>):

 .runtime_suspend = suspend_fn, \
^~
   drivers/net//ethernet/ti/davinci_mdio.c:527:21: note: (near initialization 
for 'davinci_mdio_pm_ops.runtime_suspend')
 SET_RUNTIME_PM_OPS(davinci_mdio_runtime_suspend,
^
   include/linux/pm.h:354:21: note: in definition of macro 'SET_RUNTIME_PM_OPS'
 .runtime_suspend = suspend_fn, \
^~
   drivers/net//ethernet/ti/davinci_mdio.c:528:7: error: initializer element is 
not constant
  davinci_mdio_runtime_resume, NULL)
  ^
   include/linux/pm.h:355:20: note: in definition of macro 'SET_RUNTIME_PM_OPS'
 .runtime_resume = resume_fn, \
   ^
   drivers/net//ethernet/ti/davinci_mdio.c:528:7: note: (near initialization 
for 'davinci_mdio_pm_ops.runtime_resume')
  davinci_mdio_runtime_resume, NULL)
  ^
   include/linux/pm.h:355:20: note: in definition of macro 'SET_RUNTIME_PM_OPS'
 .runtime_resume = resume_fn, \
   ^
   drivers/net//ethernet/ti/davinci_mdio.c:529:31: error: initializer element 
is not constant
 SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume)
  ^
   include/linux/pm.h:330:18: note: in definition of macro 
'SET_LATE_SYSTEM_SLEEP_PM_OPS'
 .suspend_late = suspend_fn, \
 ^~
   drivers/net//ethernet/ti/davinci_mdio.c:529:31: note: (near initialization 
for 'davinci_mdio_pm_ops.suspend_late')
 SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume)
  ^
   include/linux/pm.h:330:18: note: in definition of macro 
'SET_LATE_SYSTEM_SLEEP_PM_OPS'
 .suspend_late = suspend_fn, \
 ^~
   drivers/net//ethernet/ti/davinci_mdio.c:529:53: error: initializer element 
is not constant
 SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume)
^
   include/linux/pm.h:331:18: note: in definition of macro 
'SET_LATE_SYSTEM_SLEEP_PM_OPS'
 .resume_early = resume_fn, \
 ^
   drivers/net//ethernet/ti/davinci_mdio.c:529:53: note: (near initialization 
for 'davinci_mdio_pm_ops.resume_early')
 SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume)
^
   include/linux/pm.h:331:18: note: in definition of macro 
'SET_LATE_SYSTEM_SLEEP_PM_OPS'
 .resume_early = resume_fn, \
 ^
   drivers/net//ethernet/ti/davinci_mdio.c:529:31: error: initializer element 
is not constant
 SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume)
  ^
   include/linux/pm.h:332:17: note: in definition of macro 
'SET_LATE_SYSTEM_SLEEP_PM_OPS'
 .freeze_late = suspend_fn, \
^~
   drivers/net//ethernet/ti/davinci_mdio.c:529:31: note: (near initialization 
for 'davinci_mdio_pm_ops.freeze_late')
 SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume)
  ^
   include/linux/pm.h:332:17: note: in definition of macro 
'SET_LATE_SYSTEM_SLEEP_PM_OPS'
 .freeze_late = suspend_fn, \
^~
   drivers/net//ethernet/ti/davinci_mdio.c:529:53: error: initializer element 
is not constant
 SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume)
^
   include/linux/pm.h:333:16: note: in definition of macro 
'SET_LATE_SYSTEM_SLEEP_PM_OPS'
 .thaw_early = resume_fn, \
   ^
   drivers/net//ethernet/ti/davinci_mdio.c:529:53: note: (near initialization 
for 'davinci_mdio_pm_ops.thaw_early')
 SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume)
^
   include/linux/pm.h:333:16: note: in definition of macro 
'SET_LATE_SYSTEM_SLEEP_PM_OPS'
 .thaw_early = resume_fn, \
   ^
   drivers/net//ethernet/ti/davinci_mdio.c:529:31: error: initializer element 
is not constant
 SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume)
  ^
   

[RFC PATCH] iscsit_wait_for_tag() can be static

[kbuild test robot]

Fixes: 5aff7a710f13 ("Convert target drivers to use sbitmap")
Signed-off-by: Fengguang Wu 
---
 iscsi_target_util.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/target/iscsi/iscsi_target_util.c 
b/drivers/target/iscsi/iscsi_target_util.c
index 28bcffa..e147aef 100644
--- a/drivers/target/iscsi/iscsi_target_util.c
+++ b/drivers/target/iscsi/iscsi_target_util.c
@@ -147,7 +147,7 @@ void iscsit_free_r2ts_from_list(struct iscsi_cmd *cmd)
spin_unlock_bh(>r2t_lock);
 }
 
-int iscsit_wait_for_tag(struct se_session *se_sess, int state, int *cpup)
+static int iscsit_wait_for_tag(struct se_session *se_sess, int state, int 
*cpup)
 {
int tag = -1;
DEFINE_WAIT(wait);
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] Convert target drivers to use sbitmap

[kbuild test robot]

Hi Matthew,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.17-rc5 next-20180516]
[cannot apply to target/master]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Matthew-Wilcox/Use-sbitmap-instead-of-percpu_ida/20180516-143658
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/target/iscsi/iscsi_target_util.c:150:5: sparse: symbol 
>> 'iscsit_wait_for_tag' was not declared. Should it be static?
   drivers/target/iscsi/iscsi_target_util.c:1174:31: sparse: expression using 
sizeof(void)
   drivers/target/iscsi/iscsi_target_util.c:1174:31: sparse: expression using 
sizeof(void)

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[balbi-usb:next 49/82] drivers/usb/dwc3/gadget.c:2375:19: error: 'dwc' undeclared

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
head:   3196f73ff8444f6b8bfce3dce1900b4eae27c324
commit: 0cdab4c202ea0dd241ddaacf1d3a8a282590cb61 [49/82] usb: dwc3: gadget: 
remove unnecessary 'dwc' parameter
config: x86_64-randconfig-s2-05161806 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
git checkout 0cdab4c202ea0dd241ddaacf1d3a8a282590cb61
# save the attached .config to linux build tree
make ARCH=x86_64 

Note: the balbi-usb/next HEAD 3196f73ff8444f6b8bfce3dce1900b4eae27c324 builds 
fine.
  It only hurts bisectibility.

All errors (new ones prefixed by >>):

   In file included from arch/x86/include/asm/bug.h:83:0,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/gfp.h:5,
from include/linux/slab.h:15,
from drivers/usb/dwc3/gadget.c:13:
   drivers/usb/dwc3/gadget.c: In function 
'dwc3_gadget_ep_cleanup_completed_requests':
>> drivers/usb/dwc3/gadget.c:2375:19: error: 'dwc' undeclared (first use in 
>> this function)
dev_WARN_ONCE(dwc->dev,
  ^
   include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
 ^~~
   include/asm-generic/bug.h:154:3: note: in expansion of macro 'WARN'
  WARN(1, format);\
  ^~~~
   include/linux/device.h:1506:2: note: in expansion of macro 'WARN_ONCE'
 WARN_ONCE(condition, "%s %s: " format, \
 ^
   drivers/usb/dwc3/gadget.c:2375:5: note: in expansion of macro 'dev_WARN_ONCE'
dev_WARN_ONCE(dwc->dev,
^
   drivers/usb/dwc3/gadget.c:2375:19: note: each undeclared identifier is 
reported only once for each function it appears in
dev_WARN_ONCE(dwc->dev,
  ^
   include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
 ^~~
   include/asm-generic/bug.h:154:3: note: in expansion of macro 'WARN'
  WARN(1, format);\
  ^~~~
   include/linux/device.h:1506:2: note: in expansion of macro 'WARN_ONCE'
 WARN_ONCE(condition, "%s %s: " format, \
 ^
   drivers/usb/dwc3/gadget.c:2375:5: note: in expansion of macro 'dev_WARN_ONCE'
dev_WARN_ONCE(dwc->dev,
^

vim +/dwc +2375 drivers/usb/dwc3/gadget.c

e5ba5ec833 Pratyush Anand   2013-01-14  2316  
0cdab4c202 Felipe Balbi 2018-03-27  2317  static int 
dwc3_gadget_ep_cleanup_completed_requests(struct dwc3_ep *dep,
0cdab4c202 Felipe Balbi 2018-03-27  2318const struct 
dwc3_event_depevt *event, int status)
e5ba5ec833 Pratyush Anand   2013-01-14  2319  {
31162af447 Felipe Balbi 2016-08-11  2320struct dwc3_request 
*req, *n;
e5ba5ec833 Pratyush Anand   2013-01-14  2321struct dwc3_trb 
*trb;
d6e10bf2ba Arnd Bergmann2016-09-09  2322bool
ioc = false;
e62c5bc573 Felipe Balbi 2016-10-25  2323int 
ret = 0;
e5ba5ec833 Pratyush Anand   2013-01-14  2324  
31162af447 Felipe Balbi 2016-08-11  2325
list_for_each_entry_safe(req, n, >started_list, list) {
1f512119a0 Felipe Balbi 2016-08-12  2326unsigned length;
e5b36ae2f8 Felipe Balbi 2016-08-10  2327int chain;
e5b36ae2f8 Felipe Balbi 2016-08-10  2328  
1f512119a0 Felipe Balbi 2016-08-12  2329length = 
req->request.length;
1f512119a0 Felipe Balbi 2016-08-12  2330chain = 
req->num_pending_sgs > 0;
31162af447 Felipe Balbi 2016-08-11  2331if (chain) {
1f512119a0 Felipe Balbi 2016-08-12  2332struct 
scatterlist *sg = req->sg;
31162af447 Felipe Balbi 2016-08-11  2333struct 
scatterlist *s;
1f512119a0 Felipe Balbi 2016-08-12  2334
unsigned int pending = req->num_pending_sgs;
31162af447 Felipe Balbi 2016-08-11  2335
unsigned int i;
ac7bdcc1b3 Felipe Balbi 2015-11-16  2336  
1f512119a0 Felipe Balbi 2016-08-12  2337
for_each_sg(sg, s, pending, i) {
737f1ae255 Felipe Balbi 2016-08-11  2338
trb = >trb_pool[dep->trb_dequeue];
c7de573471 Felipe Balbi 2016-07-29  2339  
7282c4ef0b Felipe Balbi 2016-10-25  2340
if (trb->ctrl & DWC3_TRB_CTRL_HWO)
7282c4ef0b Felipe Balbi 2016-10-25  2341
break;
7282c4ef0b Felipe Balbi 2016-10-25  2342  
1f512119a0 Felipe 

[balbi-usb:next 49/82] drivers/usb/dwc3/gadget.c:2375:19: error: 'dwc' undeclared; did you mean 'dwc3'?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
head:   3196f73ff8444f6b8bfce3dce1900b4eae27c324
commit: 0cdab4c202ea0dd241ddaacf1d3a8a282590cb61 [49/82] usb: dwc3: gadget: 
remove unnecessary 'dwc' parameter
config: x86_64-randconfig-i0-201819 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
git checkout 0cdab4c202ea0dd241ddaacf1d3a8a282590cb61
# save the attached .config to linux build tree
make ARCH=x86_64 

Note: the balbi-usb/next HEAD 3196f73ff8444f6b8bfce3dce1900b4eae27c324 builds 
fine.
  It only hurts bisectibility.

All errors (new ones prefixed by >>):

   In file included from arch/x86/include/asm/bug.h:83:0,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/gfp.h:5,
from include/linux/slab.h:15,
from drivers/usb/dwc3/gadget.c:13:
   drivers/usb/dwc3/gadget.c: In function 
'dwc3_gadget_ep_cleanup_completed_requests':
>> drivers/usb/dwc3/gadget.c:2375:19: error: 'dwc' undeclared (first use in 
>> this function); did you mean 'dwc3'?
dev_WARN_ONCE(dwc->dev,
  ^
   include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
 ^~~
   include/asm-generic/bug.h:154:3: note: in expansion of macro 'WARN'
  WARN(1, format);\
  ^~~~
   include/linux/device.h:1506:2: note: in expansion of macro 'WARN_ONCE'
 WARN_ONCE(condition, "%s %s: " format, \
 ^
   drivers/usb/dwc3/gadget.c:2375:5: note: in expansion of macro 'dev_WARN_ONCE'
dev_WARN_ONCE(dwc->dev,
^
   drivers/usb/dwc3/gadget.c:2375:19: note: each undeclared identifier is 
reported only once for each function it appears in
dev_WARN_ONCE(dwc->dev,
  ^
   include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
 ^~~
   include/asm-generic/bug.h:154:3: note: in expansion of macro 'WARN'
  WARN(1, format);\
  ^~~~
   include/linux/device.h:1506:2: note: in expansion of macro 'WARN_ONCE'
 WARN_ONCE(condition, "%s %s: " format, \
 ^
   drivers/usb/dwc3/gadget.c:2375:5: note: in expansion of macro 'dev_WARN_ONCE'
dev_WARN_ONCE(dwc->dev,
^

vim +2375 drivers/usb/dwc3/gadget.c

e5ba5ec833 Pratyush Anand   2013-01-14  2316  
0cdab4c202 Felipe Balbi 2018-03-27  2317  static int 
dwc3_gadget_ep_cleanup_completed_requests(struct dwc3_ep *dep,
0cdab4c202 Felipe Balbi 2018-03-27  2318const struct 
dwc3_event_depevt *event, int status)
e5ba5ec833 Pratyush Anand   2013-01-14  2319  {
31162af447 Felipe Balbi 2016-08-11  2320struct dwc3_request 
*req, *n;
e5ba5ec833 Pratyush Anand   2013-01-14  2321struct dwc3_trb 
*trb;
d6e10bf2ba Arnd Bergmann2016-09-09  2322bool
ioc = false;
e62c5bc573 Felipe Balbi 2016-10-25  2323int 
ret = 0;
e5ba5ec833 Pratyush Anand   2013-01-14  2324  
31162af447 Felipe Balbi 2016-08-11  2325
list_for_each_entry_safe(req, n, >started_list, list) {
1f512119a0 Felipe Balbi 2016-08-12  2326unsigned length;
e5b36ae2f8 Felipe Balbi 2016-08-10  2327int chain;
e5b36ae2f8 Felipe Balbi 2016-08-10  2328  
1f512119a0 Felipe Balbi 2016-08-12  2329length = 
req->request.length;
1f512119a0 Felipe Balbi 2016-08-12  2330chain = 
req->num_pending_sgs > 0;
31162af447 Felipe Balbi 2016-08-11  2331if (chain) {
1f512119a0 Felipe Balbi 2016-08-12  2332struct 
scatterlist *sg = req->sg;
31162af447 Felipe Balbi 2016-08-11  2333struct 
scatterlist *s;
1f512119a0 Felipe Balbi 2016-08-12  2334
unsigned int pending = req->num_pending_sgs;
31162af447 Felipe Balbi 2016-08-11  2335
unsigned int i;
ac7bdcc1b3 Felipe Balbi 2015-11-16  2336  
1f512119a0 Felipe Balbi 2016-08-12  2337
for_each_sg(sg, s, pending, i) {
737f1ae255 Felipe Balbi 2016-08-11  2338
trb = >trb_pool[dep->trb_dequeue];
c7de573471 Felipe Balbi 2016-07-29  2339  
7282c4ef0b Felipe Balbi 2016-10-25  2340
if (trb->ctrl & DWC3_TRB_CTRL_HWO)
7282c4ef0b Felipe Balbi 2016-10-25  2341
break;
7282c4ef0b Felipe Balbi 2016-10-25  2342  
1f512119a0 

Re: [PATCH v5 1/7] clk: msm8996-gcc: Mark halt check as no-op for USB/PCIE pipe_clk

[kbuild test robot]

Hi Manu,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on phy/next]
[also build test ERROR on v4.17-rc3 next-20180503]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Manu-Gautam/phy-qcom-Updates-for-USB-PHYs-on-SDM845/20180503-163006
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git 
next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> drivers/clk//qcom/gcc-msm8996.c:1421:16: error: 'BRANCH_HALT_SKIP' 
>> undeclared here (not in a function); did you mean 'BRANCH_HALT_VOTED'?
 .halt_check = BRANCH_HALT_SKIP,
   ^~~~
   BRANCH_HALT_VOTED

vim +1421 drivers/clk//qcom/gcc-msm8996.c

  1418  
  1419  static struct clk_branch gcc_usb3_phy_pipe_clk = {
  1420  .halt_reg = 0x50004,
> 1421  .halt_check = BRANCH_HALT_SKIP,
  1422  .clkr = {
  1423  .enable_reg = 0x50004,
  1424  .enable_mask = BIT(0),
  1425  .hw.init = &(struct clk_init_data){
  1426  .name = "gcc_usb3_phy_pipe_clk",
  1427  .parent_names = (const char *[]){ 
"usb3_phy_pipe_clk_src" },
  1428  .num_parents = 1,
  1429  .flags = CLK_SET_RATE_PARENT,
  1430  .ops = _branch2_ops,
  1431  },
  1432  },
  1433  };
  1434  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[hid:for-4.18/multitouch 7/7] drivers/hid/hid-multitouch.c:1209:9-10: WARNING: return of 0/1 in function 'mt_need_to_apply_feature' with return type bool

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git 
for-4.18/multitouch
head:   02946f4b43b11026b1a76857a33b09078b900939
commit: 02946f4b43b11026b1a76857a33b09078b900939 [7/7] HID: multitouch: 
implement precision touchpad latency and switches


coccinelle warnings: (new ones prefixed by >>)

>> drivers/hid/hid-multitouch.c:1209:9-10: WARNING: return of 0/1 in function 
>> 'mt_need_to_apply_feature' with return type bool

vim +/mt_need_to_apply_feature +1209 drivers/hid/hid-multitouch.c

  1161  
  1162  static bool mt_need_to_apply_feature(struct hid_device *hdev,
  1163   struct hid_field *field,
  1164   struct hid_usage *usage,
  1165   enum latency_mode latency,
  1166   bool surface_switch,
  1167   bool button_switch)
  1168  {
  1169  struct mt_device *td = hid_get_drvdata(hdev);
  1170  struct mt_class *cls = >mtclass;
  1171  struct hid_report *report = field->report;
  1172  unsigned int index = usage->usage_index;
  1173  char *buf;
  1174  u32 report_len;
  1175  int max;
  1176  
  1177  switch (usage->hid) {
  1178  case HID_DG_INPUTMODE:
  1179  if (cls->quirks & MT_QUIRK_FORCE_GET_FEATURE) {
  1180  report_len = hid_report_len(report);
  1181  buf = hid_alloc_report_buf(report, GFP_KERNEL);
  1182  if (!buf) {
  1183  hid_err(hdev,
  1184  "failed to allocate buffer for 
report\n");
  1185  return false;
  1186  }
  1187  hid_hw_raw_request(hdev, report->id, buf, 
report_len,
  1188 HID_FEATURE_REPORT,
  1189 HID_REQ_GET_REPORT);
  1190  kfree(buf);
  1191  }
  1192  
  1193  field->value[index] = td->inputmode_value;
  1194  return true;
  1195  
  1196  case HID_DG_CONTACTMAX:
  1197  if (td->mtclass.maxcontacts) {
  1198  max = min_t(int, field->logical_maximum,
  1199  td->mtclass.maxcontacts);
  1200  if (field->value[index] != max) {
  1201  field->value[index] = max;
  1202  return true;
  1203  }
  1204  }
  1205  break;
  1206  
  1207  case HID_DG_LATENCYMODE:
  1208  field->value[index] = latency;
> 1209  return 1;
  1210  
  1211  case HID_DG_SURFACESWITCH:
  1212  field->value[index] = surface_switch;
  1213  return 1;
  1214  
  1215  case HID_DG_BUTTONSWITCH:
  1216  field->value[index] = button_switch;
  1217  return 1;
  1218  }
  1219  
  1220  return false; /* no need to update the report */
  1221  }
  1222  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] USB: Increment wakeup count on remote wakeup.

[kbuild test robot]

Hi Ravi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.17-rc1 next-20180419]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Ravi-Chandra-Sadineni/USB-Increment-wakeup-count-on-remote-wakeup/20180419-165317
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: x86_64-randconfig-x013-201815 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/usb//core/hcd.c: In function 'usb_hcd_resume_root_hub':
>> drivers/usb//core/hcd.c:2378:18: error: 'dev' undeclared (first use in this 
>> function); did you mean 'cdev'?
 pm_wakeup_event(dev, 0);
 ^~~
 cdev
   drivers/usb//core/hcd.c:2378:18: note: each undeclared identifier is 
reported only once for each function it appears in

vim +2378 drivers/usb//core/hcd.c

  2364  
  2365  /**
  2366   * usb_hcd_resume_root_hub - called by HCD to resume its root hub
  2367   * @hcd: host controller for this root hub
  2368   *
  2369   * The USB host controller calls this function when its root hub is
  2370   * suspended (with the remote wakeup feature enabled) and a remote
  2371   * wakeup request is received.  The routine submits a workqueue request
  2372   * to resume the root hub (that is, manage its downstream ports again).
  2373   */
  2374  void usb_hcd_resume_root_hub (struct usb_hcd *hcd)
  2375  {
  2376  unsigned long flags;
  2377  
> 2378  pm_wakeup_event(dev, 0);
  2379  spin_lock_irqsave (_root_hub_lock, flags);
  2380  if (hcd->rh_registered) {
  2381  set_bit(HCD_FLAG_WAKEUP_PENDING, >flags);
  2382  queue_work(pm_wq, >wakeup_work);
  2383  }
  2384  spin_unlock_irqrestore (_root_hub_lock, flags);
  2385  }
  2386  EXPORT_SYMBOL_GPL(usb_hcd_resume_root_hub);
  2387  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH] USB: Increment wakeup count on remote wakeup.

[kbuild test robot]

Hi Ravi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.17-rc1 next-20180419]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Ravi-Chandra-Sadineni/USB-Increment-wakeup-count-on-remote-wakeup/20180419-165317
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: i386-randconfig-s0-201815 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/usb/core/hcd.c: In function 'usb_hcd_resume_root_hub':
>> drivers/usb/core/hcd.c:2378:18: error: 'dev' undeclared (first use in this 
>> function)
 pm_wakeup_event(dev, 0);
 ^~~
   drivers/usb/core/hcd.c:2378:18: note: each undeclared identifier is reported 
only once for each function it appears in

vim +/dev +2378 drivers/usb/core/hcd.c

  2364  
  2365  /**
  2366   * usb_hcd_resume_root_hub - called by HCD to resume its root hub
  2367   * @hcd: host controller for this root hub
  2368   *
  2369   * The USB host controller calls this function when its root hub is
  2370   * suspended (with the remote wakeup feature enabled) and a remote
  2371   * wakeup request is received.  The routine submits a workqueue request
  2372   * to resume the root hub (that is, manage its downstream ports again).
  2373   */
  2374  void usb_hcd_resume_root_hub (struct usb_hcd *hcd)
  2375  {
  2376  unsigned long flags;
  2377  
> 2378  pm_wakeup_event(dev, 0);
  2379  spin_lock_irqsave (_root_hub_lock, flags);
  2380  if (hcd->rh_registered) {
  2381  set_bit(HCD_FLAG_WAKEUP_PENDING, >flags);
  2382  queue_work(pm_wq, >wakeup_work);
  2383  }
  2384  spin_unlock_irqrestore (_root_hub_lock, flags);
  2385  }
  2386  EXPORT_SYMBOL_GPL(usb_hcd_resume_root_hub);
  2387  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH] xhci: dump event ring, testpatch for Luciano

[kbuild test robot]

Hi Mathias,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v4.16]
[also build test WARNING on next-20180410]
[cannot apply to usb/usb-testing]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Mathias-Nyman/xhci-dump-event-ring-testpatch-for-Luciano/20180410-211241
config: parisc-generic-64bit_defconfig (attached as .config)
compiler: hppa64-linux-gnu-gcc (GCC) 7.3.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=parisc 

All warnings (new ones prefixed by >>):

   In file included from drivers/usb/host/xhci-ring.c:58:0:
   drivers/usb/host/xhci-ring.c: In function 'xhci_dump_ev_ring':
>> drivers/usb/host/xhci-ring.c:2272:19: warning: format '%llx' expects 
>> argument of type 'long long unsigned int', but argument 3 has type 'long 
>> unsigned int' [-Wformat=]
  xhci_warn(xhci, "%llx: %s\n", seg->dma + (i * sizeof(union xhci_trb)),
  ^ ~~~
   drivers/usb/host/xhci.h:1900:48: note: in definition of macro 'xhci_warn'
 dev_warn(xhci_to_hcd(xhci)->self.controller , fmt , ## args)
   ^~~
   drivers/usb/host/xhci-ring.c:2278:18: warning: format '%llx' expects 
argument of type 'long long unsigned int', but argument 3 has type 'dma_addr_t 
{aka unsigned int}' [-Wformat=]
 xhci_warn(xhci, "dequeue: %llx\n", xhci_trb_virt_to_dma(seg, 
xhci->event_ring->dequeue));
 ^  

   drivers/usb/host/xhci.h:1900:48: note: in definition of macro 'xhci_warn'
 dev_warn(xhci_to_hcd(xhci)->self.controller , fmt , ## args)
   ^~~

vim +2272 drivers/usb/host/xhci-ring.c

  2265  
  2266  static void xhci_dump_ev_ring(struct xhci_hcd *xhci)
  2267  {
  2268  int i;
  2269  struct xhci_segment *seg = xhci->event_ring->first_seg;
  2270  
  2271  for (i = 0; i < TRBS_PER_SEGMENT; i++) {
> 2272  xhci_warn(xhci, "%llx: %s\n", seg->dma + (i * 
> sizeof(union xhci_trb)),
  2273   xhci_decode_trb(seg->trbs[i].generic.field[0],
  2274   seg->trbs[i].generic.field[1],
  2275   seg->trbs[i].generic.field[2],
  2276   
seg->trbs[i].generic.field[3]));
  2277  }
  2278  xhci_warn(xhci, "dequeue: %llx\n", xhci_trb_virt_to_dma(seg, 
xhci->event_ring->dequeue));
  2279  }
  2280  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH] xhci: dump event ring, testpatch for Luciano

[kbuild test robot]

Hi Mathias,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v4.16]
[also build test WARNING on next-20180410]
[cannot apply to usb/usb-testing]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Mathias-Nyman/xhci-dump-event-ring-testpatch-for-Luciano/20180410-211241
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/usb/host/xhci-ring.c:2272:17: sparse: incorrect type in argument 1 
>> (different base types) @@expected unsigned int [unsigned] [usertype] 
>> field0 @@got igned] [usertype] field0 @@
   drivers/usb/host/xhci-ring.c:2272:17:expected unsigned int [unsigned] 
[usertype] field0
   drivers/usb/host/xhci-ring.c:2272:17:got restricted __le32 
>> drivers/usb/host/xhci-ring.c:2272:17: sparse: incorrect type in argument 2 
>> (different base types) @@expected unsigned int [unsigned] [usertype] 
>> field1 @@got igned] [usertype] field1 @@
   drivers/usb/host/xhci-ring.c:2272:17:expected unsigned int [unsigned] 
[usertype] field1
   drivers/usb/host/xhci-ring.c:2272:17:got restricted __le32 
>> drivers/usb/host/xhci-ring.c:2272:17: sparse: incorrect type in argument 3 
>> (different base types) @@expected unsigned int [unsigned] [usertype] 
>> field2 @@got igned] [usertype] field2 @@
   drivers/usb/host/xhci-ring.c:2272:17:expected unsigned int [unsigned] 
[usertype] field2
   drivers/usb/host/xhci-ring.c:2272:17:got restricted __le32 
>> drivers/usb/host/xhci-ring.c:2272:17: sparse: incorrect type in argument 4 
>> (different base types) @@expected unsigned int [unsigned] [usertype] 
>> field3 @@got igned] [usertype] field3 @@
   drivers/usb/host/xhci-ring.c:2272:17:expected unsigned int [unsigned] 
[usertype] field3
   drivers/usb/host/xhci-ring.c:2272:17:got restricted __le32 
   drivers/usb/host/xhci-ring.c:645:9: sparse: context imbalance in 
'xhci_giveback_urb_in_irq' - unexpected unlock

vim +2272 drivers/usb/host/xhci-ring.c

  2265  
  2266  static void xhci_dump_ev_ring(struct xhci_hcd *xhci)
  2267  {
  2268  int i;
  2269  struct xhci_segment *seg = xhci->event_ring->first_seg;
  2270  
  2271  for (i = 0; i < TRBS_PER_SEGMENT; i++) {
> 2272  xhci_warn(xhci, "%llx: %s\n", seg->dma + (i * 
> sizeof(union xhci_trb)),
  2273   xhci_decode_trb(seg->trbs[i].generic.field[0],
  2274   seg->trbs[i].generic.field[1],
  2275   seg->trbs[i].generic.field[2],
  2276   
seg->trbs[i].generic.field[3]));
  2277  }
  2278  xhci_warn(xhci, "dequeue: %llx\n", xhci_trb_virt_to_dma(seg, 
xhci->event_ring->dequeue));
  2279  }
  2280  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] xhci: dump event ring, testpatch for Luciano

[kbuild test robot]

Hi Mathias,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v4.16]
[also build test WARNING on next-20180410]
[cannot apply to usb/usb-testing]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Mathias-Nyman/xhci-dump-event-ring-testpatch-for-Luciano/20180410-211241
config: i386-randconfig-x008-201814 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from drivers/usb/host/xhci-ring.c:58:0:
   drivers/usb/host/xhci-ring.c: In function 'xhci_dump_ev_ring':
>> drivers/usb/host/xhci-ring.c:2272:19: warning: format '%llx' expects 
>> argument of type 'long long unsigned int', but argument 3 has type 
>> 'dma_addr_t {aka unsigned int}' [-Wformat=]
  xhci_warn(xhci, "%llx: %s\n", seg->dma + (i * sizeof(union xhci_trb)),
  ^ ~~~
   drivers/usb/host/xhci.h:1900:48: note: in definition of macro 'xhci_warn'
 dev_warn(xhci_to_hcd(xhci)->self.controller , fmt , ## args)
   ^~~
   drivers/usb/host/xhci-ring.c:2278:18: warning: format '%llx' expects 
argument of type 'long long unsigned int', but argument 3 has type 'dma_addr_t 
{aka unsigned int}' [-Wformat=]
 xhci_warn(xhci, "dequeue: %llx\n", xhci_trb_virt_to_dma(seg, 
xhci->event_ring->dequeue));
 ^  

   drivers/usb/host/xhci.h:1900:48: note: in definition of macro 'xhci_warn'
 dev_warn(xhci_to_hcd(xhci)->self.controller , fmt , ## args)
   ^~~
   Cyclomatic Complexity 5 include/linux/compiler.h:__read_once_size
   Cyclomatic Complexity 5 include/linux/compiler.h:__write_once_size
   Cyclomatic Complexity 2 arch/x86/include/asm/bitops.h:set_bit
   Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:test_and_clear_bit
   Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:constant_test_bit
   Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:variable_test_bit
   Cyclomatic Complexity 1 include/linux/list.h:INIT_LIST_HEAD
   Cyclomatic Complexity 2 include/linux/list.h:__list_add
   Cyclomatic Complexity 1 include/linux/list.h:list_add_tail
   Cyclomatic Complexity 1 include/linux/list.h:__list_del
   Cyclomatic Complexity 2 include/linux/list.h:__list_del_entry
   Cyclomatic Complexity 1 include/linux/list.h:list_del
   Cyclomatic Complexity 1 include/linux/list.h:list_del_init
   Cyclomatic Complexity 1 include/linux/list.h:list_empty
   Cyclomatic Complexity 3 include/linux/list.h:list_is_singular
   Cyclomatic Complexity 2 arch/x86/include/asm/jump_label.h:arch_static_branch
   Cyclomatic Complexity 1 include/linux/jump_label.h:static_key_false
   Cyclomatic Complexity 6 arch/x86/include/asm/preempt.h:__preempt_count_add
   Cyclomatic Complexity 6 arch/x86/include/asm/preempt.h:__preempt_count_sub
   Cyclomatic Complexity 1 include/linux/spinlock.h:spinlock_check
   Cyclomatic Complexity 1 include/linux/spinlock.h:spin_lock
   Cyclomatic Complexity 1 include/linux/spinlock.h:spin_unlock
   Cyclomatic Complexity 1 include/linux/spinlock.h:spin_unlock_irqrestore
   Cyclomatic Complexity 1 include/linux/jiffies.h:_msecs_to_jiffies
   Cyclomatic Complexity 3 include/linux/jiffies.h:msecs_to_jiffies
   Cyclomatic Complexity 1 include/linux/rcupdate.h:rcu_read_lock_sched_notrace
   Cyclomatic Complexity 1 
include/linux/rcupdate.h:rcu_read_unlock_sched_notrace
   Cyclomatic Complexity 1 include/linux/timer.h:timer_pending
   Cyclomatic Complexity 2 include/linux/workqueue.h:to_delayed_work
   Cyclomatic Complexity 1 include/linux/workqueue.h:mod_delayed_work
   Cyclomatic Complexity 1 include/linux/mmzone.h:pfn_to_section_nr
   Cyclomatic Complexity 2 include/linux/mmzone.h:__nr_to_section
   Cyclomatic Complexity 1 include/linux/mmzone.h:__section_mem_map_addr
   Cyclomatic Complexity 1 include/linux/mmzone.h:__pfn_to_section
   Cyclomatic Complexity 1 include/linux/completion.h:reinit_completion
   Cyclomatic Complexity 1 arch/x86/include/asm/io.h:readl
   Cyclomatic Complexity 1 arch/x86/include/asm/io.h:writel
   Cyclomatic Complexity 1 include/linux/dma-debug.h:debug_dma_map_page
   Cyclomatic Complexity 1 include/linux/dma-debug.h:debug_dma_mapping_error
   Cyclomatic Complexity 1 include/linux/dma-debug.h:debug_dma_unmap_page
   Cyclomatic Complexity 1 include/linux/dma-mapping.h:valid_dma_direction
   Cyclomatic Complexity 1 arch/x86/include/asm/dma-mapping.h:get_arch_dma_ops
   Cyclomatic Complexity 4 include/linux/dma-mapping.h:get_dma_ops
   Cyclomatic Complexity 1 include/linux/dma-mapping.h:dma_map_single_attrs
   Cyclomatic Complexity 2 include/linux/dma-mapping.h:dma_unmap_single_attrs
   

Re: [PATCH] usb: gadget: f_fs: Add compat_ioctl to ep0

[kbuild test robot]

Hi Jerry,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.16 next-20180409]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Jerry-Zhang/usb-gadget-f_fs-Add-compat_ioctl-to-ep0/20180410-060430
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-x017-201814 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/usb/gadget/function/f_fs.c: In function 'ffs_ep0_compat_ioctl':
>> drivers/usb/gadget/function/f_fs.c:651:13: error: 'gadget' undeclared (first 
>> use in this function); did you mean 'bdget'?
 } else if (gadget && gadget->ops->compat_ioctl) {
^~
bdget
   drivers/usb/gadget/function/f_fs.c:651:13: note: each undeclared identifier 
is reported only once for each function it appears in

vim +651 drivers/usb/gadget/function/f_fs.c

   643  
   644  #ifdef CONFIG_COMPAT
   645  static long ffs_ep0_compat_ioctl(struct file *file, unsigned code, 
unsigned long value)
   646  {
   647  long ret;
   648  
   649  if (code == FUNCTIONFS_INTERFACE_REVMAP) {
   650  ret = ffs_ep0_ioctl(file, code, value);
 > 651  } else if (gadget && gadget->ops->compat_ioctl) {
   652  ret = gadget->ops->compat_ioctl(gadget, code, value);
   653  } else {
   654  ret = -ENOTTY;
   655  }
   656  
   657  return ret;
   658  }
   659  #endif
   660  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH] usb: gadget: f_midi: Add configfs attrs for card and device

[kbuild test robot]

Hi Jerry,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.16 next-20180409]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Jerry-Zhang/usb-gadget-f_midi-Add-configfs-attrs-for-card-and-device/20180410-061518
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-x011-201814 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/usb/gadget/function/f_midi.c: In function 'f_midi_opts_card_show':
>> drivers/usb/gadget/function/f_midi.c:1188:22: error: 'struct 
>> usb_function_instance' has no member named 'f'; did you mean 'fd'?
 if (opts->func_inst.f) {
 ^
 fd
   drivers/usb/gadget/function/f_midi.c:1189:39: error: 'struct 
usb_function_instance' has no member named 'f'; did you mean 'fd'?
  midi = func_to_midi(opts->func_inst.f);
  ^
  fd
   drivers/usb/gadget/function/f_midi.c: In function 'f_midi_opts_device_show':
   drivers/usb/gadget/function/f_midi.c:1206:22: error: 'struct 
usb_function_instance' has no member named 'f'; did you mean 'fd'?
 if (opts->func_inst.f) {
 ^
 fd
   drivers/usb/gadget/function/f_midi.c:1207:39: error: 'struct 
usb_function_instance' has no member named 'f'; did you mean 'fd'?
  midi = func_to_midi(opts->func_inst.f);
  ^
  fd

vim +1188 drivers/usb/gadget/function/f_midi.c

  1181  
  1182  static ssize_t f_midi_opts_card_show(struct config_item *item, char 
*page)
  1183  {
  1184  struct f_midi_opts *opts = to_f_midi_opts(item);
  1185  int card = -1;
  1186  struct f_midi *midi;
  1187  
> 1188  if (opts->func_inst.f) {
  1189  midi = func_to_midi(opts->func_inst.f);
  1190  if (midi->rmidi && midi->rmidi->card) {
  1191  card = midi->rmidi->card->number;
  1192  }
  1193  }
  1194  
  1195  return sprintf(page, "%d\n", card);
  1196  }
  1197  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH] usb: gadget: f_fs: Add compat_ioctl to ep0

[kbuild test robot]

Hi Jerry,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.16 next-20180409]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Jerry-Zhang/usb-gadget-f_fs-Add-compat_ioctl-to-ep0/20180410-060430
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-s3-04100757 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/usb/gadget/function/f_fs.c: In function 'ffs_ep0_compat_ioctl':
>> drivers/usb/gadget/function/f_fs.c:651:13: error: 'gadget' undeclared (first 
>> use in this function); did you mean 'dget'?
 } else if (gadget && gadget->ops->compat_ioctl) {
^~
dget
   drivers/usb/gadget/function/f_fs.c:651:13: note: each undeclared identifier 
is reported only once for each function it appears in

vim +651 drivers/usb/gadget/function/f_fs.c

   643  
   644  #ifdef CONFIG_COMPAT
   645  static long ffs_ep0_compat_ioctl(struct file *file, unsigned code, 
unsigned long value)
   646  {
   647  long ret;
   648  
   649  if (code == FUNCTIONFS_INTERFACE_REVMAP) {
   650  ret = ffs_ep0_ioctl(file, code, value);
 > 651  } else if (gadget && gadget->ops->compat_ioctl) {
   652  ret = gadget->ops->compat_ioctl(gadget, code, value);
   653  } else {
   654  ret = -ENOTTY;
   655  }
   656  
   657  return ret;
   658  }
   659  #endif
   660  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [RFT/PATCH 35/38] usb: dwc3: gadget: combine modify & restore into single argument

[kbuild test robot]

Hi Felipe,

I love your patch! Perhaps something to improve:

[auto build test WARNING on balbi-usb/next]
[also build test WARNING on next-20180409]
[cannot apply to v4.16]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Felipe-Balbi/usb-dwc3-gadget-Rework-Refactoring/20180409-204052
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   include/net/mac80211.h:2083: warning: bad line: >
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'rx_stats_avg' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'rx_stats_avg.signal' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'rx_stats_avg.chain_signal' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'status_stats.filtered' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'status_stats.retry_failed' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'status_stats.retry_count' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'status_stats.lost_packets' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'status_stats.last_tdls_pkt_time' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'status_stats.msdu_retries' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'status_stats.msdu_failed' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'status_stats.last_ack' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'status_stats.last_ack_signal' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'status_stats.ack_signal_filled' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'tx_stats.packets' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'tx_stats.bytes' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'tx_stats.last_rate' not described in 'sta_info'
   net/mac80211/sta_info.h:586: warning: Function parameter or member 
'tx_stats.msdu' not described in 'sta_info'
   kernel/sched/fair.c:3731: warning: Function parameter or member 'flags' not 
described in 'attach_entity_load_avg'
   include/linux/dma-buf.h:307: warning: Function parameter or member 
'cb_excl.cb' not described in 'dma_buf'
   include/linux/dma-buf.h:307: warning: Function parameter or member 
'cb_excl.poll' not described in 'dma_buf'
   include/linux/dma-buf.h:307: warning: Function parameter or member 
'cb_excl.active' not described in 'dma_buf'
   include/linux/dma-buf.h:307: warning: Function parameter or member 
'cb_shared.cb' not described in 'dma_buf'
   include/linux/dma-buf.h:307: warning: Function parameter or member 
'cb_shared.poll' not 

[usb:usb-next 76/100] ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
head:   5267c5e09c25e2ee6242b37833a9bdf9d97f54a2
commit: d54f063cdbe414590c97d990111ddff25c6f9593 [76/100] extcon: axp288: Set 
USB role where necessary
config: i386-randconfig-b0-03301441 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
git checkout d54f063cdbe414590c97d990111ddff25c6f9593
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

>> ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
>> ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] 
>> undefined!
>> ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] 
>> undefined!
>> ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined!

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH v3] usb: dwc2: dwc2_vbus_supply_init: fix error check

[kbuild test robot]

Hi Tomeu,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on balbi-usb/next]
[also build test WARNING on next-20180323]
[cannot apply to v4.16-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Tomeu-Vizoso/usb-dwc2-dwc2_vbus_supply_init-fix-error-check/20180324-063752
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next


coccinelle warnings: (new ones prefixed by >>)

>> drivers/usb/dwc2/hcd.c:367:9-16: ERROR: PTR_ERR applied after initialization 
>> to constant on line 366

vim +367 drivers/usb/dwc2/hcd.c

   358  
   359  static int dwc2_vbus_supply_init(struct dwc2_hsotg *hsotg)
   360  {
   361  hsotg->vbus_supply = devm_regulator_get_optional(hsotg->dev, 
"vbus");
   362  if (PTR_ERR(hsotg->vbus_supply) == -ENODEV) {
   363  hsotg->vbus_supply = NULL;
   364  return 0;
   365  } else if (IS_ERR(hsotg->vbus_supply)) {
 > 366  hsotg->vbus_supply = NULL;
 > 367  return PTR_ERR(hsotg->vbus_supply);
   368  }
   369  
   370  return regulator_enable(hsotg->vbus_supply);
   371  }
   372  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[hid:for-4.17/upstream 10/10] drivers//hid/hid-multitouch.c:379:8: error: 'struct mt_device' has no member named 'initial_quirks'

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git 
for-4.17/upstream
head:   f6e9683c937e2246bbc1e7e8582ec71d6494f1f0
commit: f6e9683c937e2246bbc1e7e8582ec71d6494f1f0 [10/10] HID: core: reset the 
quirks before calling probe again
config: i386-randconfig-x000-201811 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout f6e9683c937e2246bbc1e7e8582ec71d6494f1f0
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers//hid/hid-multitouch.c: In function 'mt_get_feature':
>> drivers//hid/hid-multitouch.c:379:8: error: 'struct mt_device' has no member 
>> named 'initial_quirks'
 if (td->initial_quirks & HID_QUIRK_NO_INIT_REPORTS)
   ^~

vim +379 drivers//hid/hid-multitouch.c

eec29e3d Benjamin Tissoires 2011-11-23  368  
6d4f5440 Mika Westerberg2015-10-07  369  static void mt_get_feature(struct 
hid_device *hdev, struct hid_report *report)
6d4f5440 Mika Westerberg2015-10-07  370  {
6d4f5440 Mika Westerberg2015-10-07  371 struct mt_device *td = 
hid_get_drvdata(hdev);
6d4f5440 Mika Westerberg2015-10-07  372 int ret, size = 
hid_report_len(report);
6d4f5440 Mika Westerberg2015-10-07  373 u8 *buf;
6d4f5440 Mika Westerberg2015-10-07  374  
6d4f5440 Mika Westerberg2015-10-07  375 /*
b897f6db Benjamin Tissoires 2016-11-25  376  * Do not fetch the feature 
report if the device has been explicitly
b897f6db Benjamin Tissoires 2016-11-25  377  * marked as non-capable.
6d4f5440 Mika Westerberg2015-10-07  378  */
b897f6db Benjamin Tissoires 2016-11-25 @379 if (td->initial_quirks & 
HID_QUIRK_NO_INIT_REPORTS)
6d4f5440 Mika Westerberg2015-10-07  380 return;
6d4f5440 Mika Westerberg2015-10-07  381  
6d4f5440 Mika Westerberg2015-10-07  382 buf = 
hid_alloc_report_buf(report, GFP_KERNEL);
6d4f5440 Mika Westerberg2015-10-07  383 if (!buf)
6d4f5440 Mika Westerberg2015-10-07  384 return;
6d4f5440 Mika Westerberg2015-10-07  385  
6d4f5440 Mika Westerberg2015-10-07  386 ret = hid_hw_raw_request(hdev, 
report->id, buf, size,
6d4f5440 Mika Westerberg2015-10-07  387  
HID_FEATURE_REPORT, HID_REQ_GET_REPORT);
6d4f5440 Mika Westerberg2015-10-07  388 if (ret < 0) {
6d4f5440 Mika Westerberg2015-10-07  389 dev_warn(>dev, 
"failed to fetch feature %d\n",
6d4f5440 Mika Westerberg2015-10-07  390  report->id);
6d4f5440 Mika Westerberg2015-10-07  391 } else {
6d4f5440 Mika Westerberg2015-10-07  392 ret = 
hid_report_raw_event(hdev, HID_FEATURE_REPORT, buf,
6d4f5440 Mika Westerberg2015-10-07  393 
   size, 0);
6d4f5440 Mika Westerberg2015-10-07  394 if (ret)
6d4f5440 Mika Westerberg2015-10-07  395 
dev_warn(>dev, "failed to report feature\n");
6d4f5440 Mika Westerberg2015-10-07  396 }
6d4f5440 Mika Westerberg2015-10-07  397  
6d4f5440 Mika Westerberg2015-10-07  398 kfree(buf);
6d4f5440 Mika Westerberg2015-10-07  399  }
6d4f5440 Mika Westerberg2015-10-07  400  

:: The code at line 379 was first introduced by commit
:: b897f6db3ae2cd9a42377f8b1865450f34ceff0e HID: multitouch: do not 
retrieve all reports for all devices

:: TO: Benjamin Tissoires 
:: CC: Jiri Kosina 

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[hid:for-4.17/multitouch 1/3] drivers/hid/hid-multitouch.c:332:4: error: 'MT_QUIRK_WIN8_PTP_BUTTONS' undeclared here (not in a function); did you mean 'MT_QUIRK_IGNORE_DUPLICATES'?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git 
for-4.17/multitouch
head:   1816c671e130e35707320987b1385387b4fc3085
commit: 2bd739551fa216c637c81e10a5d0bb39b5d0d707 [1/3] HID: multitouch: remove 
dead zones of Razer Blade Stealth
config: i386-randconfig-x014-201811 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout 2bd739551fa216c637c81e10a5d0bb39b5d0d707
# save the attached .config to linux build tree
make ARCH=i386 

Note: the hid/for-4.17/multitouch HEAD 1816c671e130e35707320987b1385387b4fc3085 
builds fine.
  It only hurts bisectibility.

All errors (new ones prefixed by >>):

>> drivers/hid/hid-multitouch.c:332:4: error: 'MT_QUIRK_WIN8_PTP_BUTTONS' 
>> undeclared here (not in a function); did you mean 
>> 'MT_QUIRK_IGNORE_DUPLICATES'?
   MT_QUIRK_WIN8_PTP_BUTTONS,
   ^
   MT_QUIRK_IGNORE_DUPLICATES

vim +332 drivers/hid/hid-multitouch.c

   212  
   213  static struct mt_class mt_classes[] = {
   214  { .name = MT_CLS_DEFAULT,
   215  .quirks = MT_QUIRK_ALWAYS_VALID |
   216  MT_QUIRK_CONTACT_CNT_ACCURATE },
   217  { .name = MT_CLS_NSMU,
   218  .quirks = MT_QUIRK_NOT_SEEN_MEANS_UP },
   219  { .name = MT_CLS_SERIAL,
   220  .quirks = MT_QUIRK_ALWAYS_VALID},
   221  { .name = MT_CLS_CONFIDENCE,
   222  .quirks = MT_QUIRK_VALID_IS_CONFIDENCE },
   223  { .name = MT_CLS_CONFIDENCE_CONTACT_ID,
   224  .quirks = MT_QUIRK_VALID_IS_CONFIDENCE |
   225  MT_QUIRK_SLOT_IS_CONTACTID },
   226  { .name = MT_CLS_CONFIDENCE_MINUS_ONE,
   227  .quirks = MT_QUIRK_VALID_IS_CONFIDENCE |
   228  MT_QUIRK_SLOT_IS_CONTACTID_MINUS_ONE },
   229  { .name = MT_CLS_DUAL_INRANGE_CONTACTID,
   230  .quirks = MT_QUIRK_VALID_IS_INRANGE |
   231  MT_QUIRK_SLOT_IS_CONTACTID,
   232  .maxcontacts = 2 },
   233  { .name = MT_CLS_DUAL_INRANGE_CONTACTNUMBER,
   234  .quirks = MT_QUIRK_VALID_IS_INRANGE |
   235  MT_QUIRK_SLOT_IS_CONTACTNUMBER,
   236  .maxcontacts = 2 },
   237  { .name = MT_CLS_INRANGE_CONTACTNUMBER,
   238  .quirks = MT_QUIRK_VALID_IS_INRANGE |
   239  MT_QUIRK_SLOT_IS_CONTACTNUMBER },
   240  { .name = MT_CLS_WIN_8,
   241  .quirks = MT_QUIRK_ALWAYS_VALID |
   242  MT_QUIRK_IGNORE_DUPLICATES |
   243  MT_QUIRK_HOVERING |
   244  MT_QUIRK_CONTACT_CNT_ACCURATE |
   245  MT_QUIRK_STICKY_FINGERS },
   246  { .name = MT_CLS_EXPORT_ALL_INPUTS,
   247  .quirks = MT_QUIRK_ALWAYS_VALID |
   248  MT_QUIRK_CONTACT_CNT_ACCURATE,
   249  .export_all_inputs = true },
   250  { .name = MT_CLS_WIN_8_DUAL,
   251  .quirks = MT_QUIRK_ALWAYS_VALID |
   252  MT_QUIRK_IGNORE_DUPLICATES |
   253  MT_QUIRK_HOVERING |
   254  MT_QUIRK_CONTACT_CNT_ACCURATE,
   255  .export_all_inputs = true },
   256  
   257  /*
   258   * vendor specific classes
   259   */
   260  { .name = MT_CLS_3M,
   261  .quirks = MT_QUIRK_VALID_IS_CONFIDENCE |
   262  MT_QUIRK_SLOT_IS_CONTACTID |
   263  MT_QUIRK_TOUCH_SIZE_SCALING,
   264  .sn_move = 2048,
   265  .sn_width = 128,
   266  .sn_height = 128,
   267  .maxcontacts = 60,
   268  },
   269  { .name = MT_CLS_EGALAX,
   270  .quirks =  MT_QUIRK_SLOT_IS_CONTACTID |
   271  MT_QUIRK_VALID_IS_INRANGE,
   272  .sn_move = 4096,
   273  .sn_pressure = 32,
   274  },
   275  { .name = MT_CLS_EGALAX_SERIAL,
   276  .quirks =  MT_QUIRK_SLOT_IS_CONTACTID |
   277  MT_QUIRK_ALWAYS_VALID,
   278  .sn_move = 4096,
   279  .sn_pressure = 32,
   280  },
   281  { .name = MT_CLS_TOPSEED,
   282  .quirks = MT_QUIRK_ALWAYS_VALID,
   283  .is_indirect = true,
   284  .maxcontacts = 2,
   285  },
   286  { .name = MT_CLS_PANASONIC,
   287  .quirks = MT_QUIRK_NOT_SEEN_MEANS_UP,
   288  .maxcontacts = 4 },
   289  { .name = MT_CLS_GENERALTOUCH_TWOFINGERS,
   290  .quirks = MT_QUIRK_NOT_SEEN_MEANS_UP |
   291  MT_QUIRK_VALID_IS_INRANGE |
   292  

Re: [PATCH] ACPI / PM: allow deeper wakeup power states with no _SxD nor _SxW

[kbuild test robot]

Hi Daniel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v4.16-rc4]
[also build test WARNING on next-20180319]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Daniel-Drake/ACPI-PM-allow-deeper-wakeup-power-states-with-no-_SxD-nor-_SxW/20180319-185209
config: i386-randconfig-x074-201811 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/acpi/device_pm.c: In function 'acpi_dev_pm_get_state':
>> drivers/acpi/device_pm.c:607:7: warning: 'sxd_status' may be used 
>> uninitialized in this function [-Wmaybe-uninitialized]
   if (sxd_status == AE_OK && target_state > ACPI_STATE_S0)
  ^

vim +/sxd_status +607 drivers/acpi/device_pm.c

   516  
   517  /**
   518   * acpi_dev_pm_get_state - Get preferred power state of ACPI device.
   519   * @dev: Device whose preferred target power state to return.
   520   * @adev: ACPI device node corresponding to @dev.
   521   * @target_state: System state to match the resultant device state.
   522   * @d_min_p: Location to store the highest power state available to the 
device.
   523   * @d_max_p: Location to store the lowest power state available to the 
device.
   524   *
   525   * Find the lowest power (highest number) and highest power (lowest 
number) ACPI
   526   * device power states that the device can be in while the system is in 
the
   527   * state represented by @target_state.  Store the integer numbers 
representing
   528   * those stats in the memory locations pointed to by @d_max_p and 
@d_min_p,
   529   * respectively.
   530   *
   531   * Callers must ensure that @dev and @adev are valid pointers and that 
@adev
   532   * actually corresponds to @dev before using this function.
   533   *
   534   * Returns 0 on success or -ENODATA when one of the ACPI methods fails 
or
   535   * returns a value that doesn't make sense.  The memory locations 
pointed to by
   536   * @d_max_p and @d_min_p are only modified on success.
   537   */
   538  static int acpi_dev_pm_get_state(struct device *dev, struct acpi_device 
*adev,
   539   u32 target_state, int *d_min_p, int 
*d_max_p)
   540  {
   541  char method[] = { '_', 'S', '0' + target_state, 'D', '\0' };
   542  acpi_handle handle = adev->handle;
   543  unsigned long long ret;
   544  int d_min, d_max;
   545  bool wakeup = false;
   546  acpi_status sxd_status;
   547  acpi_status status;
   548  
   549  /*
   550   * If the system state is S0, the lowest power state the device 
can be
   551   * in is D3cold, unless the device has _S0W and is supposed to 
signal
   552   * wakeup, in which case the return value of _S0W has to be 
used as the
   553   * lowest power state available to the device.
   554   */
   555  d_min = ACPI_STATE_D0;
   556  d_max = ACPI_STATE_D3_COLD;
   557  
   558  /*
   559   * If present, _SxD methods return the minimum D-state (highest 
power
   560   * state) we can use for the corresponding S-states.  
Otherwise, the
   561   * minimum D-state is D0 (ACPI 3.x).
   562   */
   563  if (target_state > ACPI_STATE_S0) {
   564  /*
   565   * We rely on acpi_evaluate_integer() not clobbering 
the integer
   566   * provided if AE_NOT_FOUND is returned.
   567   */
   568  ret = d_min;
   569  sxd_status = acpi_evaluate_integer(handle, method, 
NULL, );
   570  if ((ACPI_FAILURE(sxd_status) && sxd_status != 
AE_NOT_FOUND)
   571  || ret > ACPI_STATE_D3_COLD)
   572  return -ENODATA;
   573  
   574  /*
   575   * We need to handle legacy systems where D3hot and 
D3cold are
   576   * the same and 3 is returned in both cases, so fall 
back to
   577   * D3cold if D3hot is not a valid state.
   578   */
   579  if (!adev->power.states[ret].flags.valid) {
   580  if (ret == ACPI_STATE_D3_HOT)
   581  ret = ACPI_STATE_D3_COLD;
   582  else
   583  return -ENODATA;
   584  }
   585  d_min = ret;
   586  wakeup = device_may_wakeup(dev) && 
adev->wakeup.flags.valid
   587  && adev->wakeup.sleep_state >= target_state;
   588  } 

Re: [PATCH 2/2] usb: dwc3: add clock and resets

[kbuild test robot]

Hi Masahiro,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v4.16-rc4]
[also build test WARNING on next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Masahiro-Yamada/usb-dwc3-use-local-copy-of-resource-to-fix-up-register-offset/20180317-011715
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick 
(https://www.imagemagick.org)
   include/linux/crypto.h:477: warning: Function parameter or member 
'cra_u.ablkcipher' not described in 'crypto_alg'
   include/linux/crypto.h:477: warning: Function parameter or member 
'cra_u.blkcipher' not described in 'crypto_alg'
   include/linux/crypto.h:477: warning: Function parameter or member 
'cra_u.cipher' not described in 'crypto_alg'
   include/linux/crypto.h:477: warning: Function parameter or member 
'cra_u.compress' not described in 'crypto_alg'
   include/net/cfg80211.h:4129: warning: Function parameter or member 
'wext.ibss' not described in 'wireless_dev'
   include/net/cfg80211.h:4129: warning: Function parameter or member 
'wext.connect' not described in 'wireless_dev'
   include/net/cfg80211.h:4129: warning: Function parameter or member 
'wext.keys' not described in 'wireless_dev'
   include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.ie' 
not described in 'wireless_dev'
   include/net/cfg80211.h:4129: warning: Function parameter or member 
'wext.ie_len' not described in 'wireless_dev'
   include/net/cfg80211.h:4129: warning: Function parameter or member 
'wext.bssid' not described in 'wireless_dev'
   include/net/cfg80211.h:4129: warning: Function parameter or member 
'wext.prev_bssid' not described in 'wireless_dev'
   include/net/cfg80211.h:4129: warning: Function parameter or member 
'wext.ssid' not described in 'wireless_dev'
   include/net/cfg80211.h:4129: warning: Function parameter or member 
'wext.default_key' not described in 'wireless_dev'
   include/net/cfg80211.h:4129: warning: Function parameter or member 
'wext.default_mgmt_key' not described in 'wireless_dev'
   include/net/cfg80211.h:4129: warning: Function parameter or member 
'wext.prev_bssid_valid' not described in 'wireless_dev'
   include/net/mac80211.h:2259: warning: Function parameter or member 
'radiotap_timestamp.units_pos' not described in 'ieee80211_hw'
   include/net/mac80211.h:2259: warning: Function parameter or member 
'radiotap_timestamp.accuracy' not described in 'ieee80211_hw'
   include/net/mac80211.h:950: warning: Function parameter or member 'rates' 
not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'control.use_rts' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'control.use_cts_prot' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'control.short_preamble' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'control.skip_table' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'control.jiffies' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'control.vif' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'control.hw_key' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'control.flags' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'control.enqueue_time' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 'ack' not 
described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'ack.cookie' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'status.rates' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'status.ack_signal' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'status.ampdu_ack_len' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'status.ampdu_len' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'status.antenna' not described in 'ieee80211_tx_info'
   include/net/mac80211.h:950: warning: Function parameter or member 
'status.tx_time' not described in 'ieee80211_tx_info'
   

Re: [PATCH v5 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

[kbuild test robot]

Hi Benjamin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v4.16-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Benjamin-Herrenschmidt/usb-gadget-Add-an-EP-dispose-callback-for-EP-lifetime-tracking/20180317-004216
config: m32r-allyesconfig (attached as .config)
compiler: m32r-linux-gcc (GCC) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=m32r 

All warnings (new ones prefixed by >>):

   In file included from arch/m32r/include/uapi/asm/byteorder.h:8:0,
from arch/m32r/include/asm/bitops.h:22,
from include/linux/bitops.h:38,
from include/linux/kernel.h:11,
from drivers/usb/gadget/udc/aspeed-vhub/core.c:15:
   include/linux/byteorder/big_endian.h:8:2: warning: #warning inconsistent 
configuration, needs CONFIG_CPU_BIG_ENDIAN [-Wcpp]
#warning inconsistent configuration, needs CONFIG_CPU_BIG_ENDIAN
 ^~~
   In file included from include/linux/printk.h:329:0,
from include/linux/kernel.h:14,
from drivers/usb/gadget/udc/aspeed-vhub/core.c:15:
   drivers/usb/gadget/udc/aspeed-vhub/core.c: In function 'ast_vhub_irq':
>> drivers/usb/gadget/udc/aspeed-vhub/core.c:115:16: warning: format '%x' 
>> expects argument of type 'unsigned int', but argument 5 has type 'long 
>> unsigned int' [-Wformat=]
 UDCVDBG(vhub, "irq status=%08x, ep_acks=%08x ep_nacks=%08x\n",
   ^
   include/linux/dynamic_debug.h:135:39: note: in definition of macro 
'dynamic_dev_dbg'
  __dynamic_dev_dbg(, dev, fmt, \
  ^~~
>> drivers/usb/gadget/udc/aspeed-vhub/vhub.h:423:28: note: in expansion of 
>> macro 'dev_dbg'
#define UDCVDBG(u, fmt...) dev_dbg(&(u)->pdev->dev, fmt)
   ^~~
>> drivers/usb/gadget/udc/aspeed-vhub/core.c:115:2: note: in expansion of macro 
>> 'UDCVDBG'
 UDCVDBG(vhub, "irq status=%08x, ep_acks=%08x ep_nacks=%08x\n",
 ^~~
   drivers/usb/gadget/udc/aspeed-vhub/core.c:115:16: warning: format '%x' 
expects argument of type 'unsigned int', but argument 6 has type 'long unsigned 
int' [-Wformat=]
 UDCVDBG(vhub, "irq status=%08x, ep_acks=%08x ep_nacks=%08x\n",
   ^
   include/linux/dynamic_debug.h:135:39: note: in definition of macro 
'dynamic_dev_dbg'
  __dynamic_dev_dbg(, dev, fmt, \
  ^~~
>> drivers/usb/gadget/udc/aspeed-vhub/vhub.h:423:28: note: in expansion of 
>> macro 'dev_dbg'
#define UDCVDBG(u, fmt...) dev_dbg(&(u)->pdev->dev, fmt)
   ^~~
>> drivers/usb/gadget/udc/aspeed-vhub/core.c:115:2: note: in expansion of macro 
>> 'UDCVDBG'
 UDCVDBG(vhub, "irq status=%08x, ep_acks=%08x ep_nacks=%08x\n",
 ^~~
--
   In file included from arch/m32r/include/uapi/asm/byteorder.h:8:0,
from arch/m32r/include/asm/bitops.h:22,
from include/linux/bitops.h:38,
from include/linux/kernel.h:11,
from drivers/usb/gadget/udc/aspeed-vhub/epn.c:15:
   include/linux/byteorder/big_endian.h:8:2: warning: #warning inconsistent 
configuration, needs CONFIG_CPU_BIG_ENDIAN [-Wcpp]
#warning inconsistent configuration, needs CONFIG_CPU_BIG_ENDIAN
 ^~~
   In file included from include/linux/printk.h:329:0,
from include/linux/kernel.h:14,
from drivers/usb/gadget/udc/aspeed-vhub/epn.c:15:
   drivers/usb/gadget/udc/aspeed-vhub/epn.c: In function 
'ast_vhub_epn_kick_desc':
>> drivers/usb/gadget/udc/aspeed-vhub/vhub.h:427:3: warning: format '%x' 
>> expects argument of type 'unsigned int', but argument 7 has type 'long 
>> unsigned int' [-Wformat=]
  "%s:EP%d " fmt,\
  ^
   include/linux/dynamic_debug.h:135:39: note: in definition of macro 
'dynamic_dev_dbg'
  __dynamic_dev_dbg(, dev, fmt, \
  ^~~
   drivers/usb/gadget/udc/aspeed-vhub/vhub.h:426:2: note: in expansion of macro 
'dev_dbg'
 dev_dbg(&(ep)->vhub->pdev->dev,   \
 ^~~
>> drivers/usb/gadget/udc/aspeed-vhub/epn.c:234:2: note: in expansion of macro 
>> 'EPVDBG'
 EPVDBG(ep, "HW kicked, d_next=%d dstat=%08x\n",
 ^~
   drivers/usb/gadget/udc/aspeed-vhub/epn.c:234:44: note: format string is 
defined here
 EPVDBG(ep, "HW kicked, d_next=%d dstat=%08x\n",
~~~^
%08lx

vim +115 drivers/usb/gadget/udc/aspeed-vhub/core.c

  > 15  #include 
16  #include 
17  #include 
18  #include 
19  #include 
20  #include 
21  #include 
22  

Re: [PATCH v5 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

[kbuild test robot]

Hi Benjamin,

I love your patch! Yet something to improve:

[auto build test ERROR on v4.16-rc4]
[also build test ERROR on next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Benjamin-Herrenschmidt/usb-gadget-Add-an-EP-dispose-callback-for-EP-lifetime-tracking/20180317-004216
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from arch/x86/include/asm/page_32.h:35:0,
from arch/x86/include/asm/page.h:14,
from arch/x86/include/asm/thread_info.h:12,
from include/linux/thread_info.h:38,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:81,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/stat.h:19,
from include/linux/module.h:10,
from drivers/usb/gadget/udc/aspeed-vhub/hub.c:16:
   In function 'memcpy',
   inlined from 'ast_vhub_rep_desc' at 
drivers/usb/gadget/udc/aspeed-vhub/hub.c:276:2:
>> include/linux/string.h:341:4: error: call to '__read_overflow2' declared 
>> with attribute error: detected read beyond size of object passed as 2nd 
>> parameter
   __read_overflow2();
   ^~

vim +/__read_overflow2 +341 include/linux/string.h

6974f0c4 Daniel Micay 2017-07-12  332  
6974f0c4 Daniel Micay 2017-07-12  333  __FORTIFY_INLINE void *memcpy(void *p, 
const void *q, __kernel_size_t size)
6974f0c4 Daniel Micay 2017-07-12  334  {
6974f0c4 Daniel Micay 2017-07-12  335   size_t p_size = 
__builtin_object_size(p, 0);
6974f0c4 Daniel Micay 2017-07-12  336   size_t q_size = 
__builtin_object_size(q, 0);
6974f0c4 Daniel Micay 2017-07-12  337   if (__builtin_constant_p(size)) {
6974f0c4 Daniel Micay 2017-07-12  338   if (p_size < size)
6974f0c4 Daniel Micay 2017-07-12  339   __write_overflow();
6974f0c4 Daniel Micay 2017-07-12  340   if (q_size < size)
6974f0c4 Daniel Micay 2017-07-12 @341   __read_overflow2();
6974f0c4 Daniel Micay 2017-07-12  342   }
6974f0c4 Daniel Micay 2017-07-12  343   if (p_size < size || q_size < size)
6974f0c4 Daniel Micay 2017-07-12  344   fortify_panic(__func__);
6974f0c4 Daniel Micay 2017-07-12  345   return __builtin_memcpy(p, q, size);
6974f0c4 Daniel Micay 2017-07-12  346  }
6974f0c4 Daniel Micay 2017-07-12  347  

:: The code at line 341 was first introduced by commit
:: 6974f0c4555e285ab217cee58b6e874f776ff409 include/linux/string.h: add the 
option of fortified string.h functions

:: TO: Daniel Micay 
:: CC: Linus Torvalds 

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH 3/3] usb: dwc2: Add High Bandwidth ISOC OUT support

[kbuild test robot]

Hi Minas,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20180309]
[cannot apply to v4.16-rc4 v4.16-rc3 v4.16-rc2 v4.16-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Minas-Harutyunyan/usb-dwc2-gadget-Update-ISOC-DDMA-flow/20180317-012732
config: i386-randconfig-x075-201810 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/usb/dwc2/gadget.c: In function 'dwc2_gadget_start_isoc_ddma':
>> drivers/usb/dwc2/gadget.c:944:3: warning: this 'if' clause does not guard... 
>> [-Wmisleading-indentation]
  if (dwc2_hsotg_wait_bit_set(hsotg, GINTSTS,
  ^~
   drivers/usb/dwc2/gadget.c:948:4: note: ...this statement, but the latter is 
misleadingly indented as if it were guarded by the 'if'
   dwc2_writel(DXEPINT_OUTTKNEPDIS,
   ^~~
   drivers/usb/dwc2/gadget.c: In function 
'dwc2_gadget_complete_isoc_request_ddma':
   drivers/usb/dwc2/gadget.c:2233:4: warning: this 'if' clause does not 
guard... [-Wmisleading-indentation]
   if (sumofpid != 0)
   ^~
   drivers/usb/dwc2/gadget.c:2235:5: note: ...this statement, but the latter is 
misleadingly indented as if it were guarded by the 'if'
break;
^
   drivers/usb/dwc2/gadget.c:2237:4: warning: this 'if' clause does not 
guard... [-Wmisleading-indentation]
   if (sumofpid != 5)
   ^~
   drivers/usb/dwc2/gadget.c:2239:5: note: ...this statement, but the latter is 
misleadingly indented as if it were guarded by the 'if'
break;
^
   drivers/usb/dwc2/gadget.c:2241:4: warning: this 'if' clause does not 
guard... [-Wmisleading-indentation]
   if (sumofpid != 7)
   ^~
   drivers/usb/dwc2/gadget.c:2243:5: note: ...this statement, but the latter is 
misleadingly indented as if it were guarded by the 'if'
break;
^

vim +/if +944 drivers/usb/dwc2/gadget.c

   887  
   888  /*
   889   * dwc2_gadget_start_isoc_ddma - start isochronous transfer in DDMA
   890   * @hs_ep: The isochronous endpoint.
   891   *
   892   * Prepare descriptor chain for isochronous endpoints. Afterwards
   893   * write DMA address to HW and enable the endpoint.
   894   */
   895  static void dwc2_gadget_start_isoc_ddma(struct dwc2_hsotg_ep *hs_ep)
   896  {
   897  struct dwc2_hsotg *hsotg = hs_ep->parent;
   898  struct dwc2_hsotg_req *hs_req, *treq;
   899  int index = hs_ep->index;
   900  int ret;
   901  u32 dma_reg;
   902  u32 depctl;
   903  u32 ctrl;
   904  struct dwc2_dma_desc *desc;
   905  int dpi;
   906  
   907  if (list_empty(_ep->queue)) {
   908  hs_ep->target_frame = TARGET_FRAME_INITIAL;
   909  dev_dbg(hsotg->dev, "%s: No requests in queue\n", 
__func__);
   910  return;
   911  }
   912  
   913  /* Descriptor count per interval (dpi): for IN set to 1, for OUT
   914   * set to mult, i.e. 1 descritor per each packet in frame
   915   */
   916  dpi = 1;
   917  if (!hs_ep->dir_in)
   918  dpi = hs_ep->mc;
   919  
   920  /* Initialize descriptor chain by Host Busy status */
   921  for (ret = 0; ret < dpi * MAX_DMA_DESC_NUM_GENERIC; ret++) {
   922  desc = _ep->desc_list[ret];
   923  desc->status = 0;
   924  desc->status |= (DEV_DMA_BUFF_STS_HBUSY
   925  << DEV_DMA_BUFF_STS_SHIFT);
   926  }
   927  
   928  hs_ep->next_desc = 0;
   929  list_for_each_entry_safe(hs_req, treq, _ep->queue, queue) {
   930  ret = dwc2_gadget_fill_isoc_desc(hs_ep, hs_req->req.dma,
   931   hs_req->req.length);
   932  if (ret)
   933  break;
   934  }
   935  
   936  depctl = hs_ep->dir_in ? DIEPCTL(index) : DOEPCTL(index);
   937  dma_reg = hs_ep->dir_in ? DIEPDMA(index) : DOEPDMA(index);
   938  
   939  /* write descriptor chain address to control register */
   940  dwc2_writel(hs_ep->desc_list_dma, hsotg->regs + dma_reg);
   941  
   942  /* Wait for EOPF interrupt for current (u)frame */
   943  if (dpi > 1) {
 > 944  if (dwc2_hsotg_wait_bit_set(hsotg, GINTSTS,
   945  GINTSTS_EOPF, 100))
   946  dev_warn(hsotg->dev,
   947   "%s: timeout GINTSTS.EOPF\n", 
__func__);
   948  dwc2_writel(DXEPINT_OUTTKNEPDIS,
   949  hsotg->regs + 

Re: [PATCH v1 2/2] usb: dwc3: Add Qualcomm DWC3 glue driver

[kbuild test robot]

Hi Manu,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v4.16-rc4]
[also build test ERROR on next-20180314]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Manu-Gautam/dt-bindings-usb-Update-documentation-for-Qualcomm-DWC3-driver/20180314-095557
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> ERROR: "__tracepoint_dwc3_writel" [drivers/usb/dwc3/dwc3-qcom.ko] undefined!
>> ERROR: "__tracepoint_dwc3_readl" [drivers/usb/dwc3/dwc3-qcom.ko] undefined!

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH v1 2/2] usb: dwc3: Add Qualcomm DWC3 glue driver

[kbuild test robot]

Hi Manu,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v4.16-rc4]
[also build test ERROR on next-20180313]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Manu-Gautam/dt-bindings-usb-Update-documentation-for-Qualcomm-DWC3-driver/20180314-095557
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sparc64 

All errors (new ones prefixed by >>):

   drivers/usb/dwc3/dwc3-qcom.c: In function 'dwc3_qcom_probe':
>> drivers/usb/dwc3/dwc3-qcom.c:407:33: error: implicit declaration of function 
>> 'of_clk_get_parent_count'; did you mean 'clk_get_parent'? 
>> [-Werror=implicit-function-declaration]
 ret = dwc3_qcom_clk_init(qcom, of_clk_get_parent_count(np));
^~~
clk_get_parent
   cc1: some warnings being treated as errors

vim +407 drivers/usb/dwc3/dwc3-qcom.c

   380  
   381  static int dwc3_qcom_probe(struct platform_device *pdev)
   382  {
   383  struct device_node  *np = pdev->dev.of_node, *dwc3_np;
   384  struct dwc3_qcom*qcom;
   385  struct resource *res;
   386  int irq, ret, i;
   387  boolignore_pipe_clk;
   388  
   389  qcom = devm_kzalloc(>dev, sizeof(*qcom), GFP_KERNEL);
   390  if (!qcom)
   391  return -ENOMEM;
   392  
   393  platform_set_drvdata(pdev, qcom);
   394  qcom->dev = >dev;
   395  
   396  qcom->resets = 
of_reset_control_array_get_optional_exclusive(np);
   397  if (IS_ERR(qcom->resets)) {
   398  ret = PTR_ERR(qcom->resets);
   399  dev_err(>dev, "failed to get resets, err=%d\n", 
ret);
   400  return ret;
   401  }
   402  
   403  ret = reset_control_deassert(qcom->resets);
   404  if (ret)
   405  goto reset_put;
   406  
 > 407  ret = dwc3_qcom_clk_init(qcom, of_clk_get_parent_count(np));
   408  if (ret) {
   409  dev_err(qcom->dev, "failed to get clocks\n");
   410  goto reset_assert;
   411  }
   412  
   413  res = platform_get_resource_byname(pdev, IORESOURCE_MEM, 
"qscratch");
   414  qcom->qscratch_base = devm_ioremap_resource(qcom->dev, res);
   415  if (IS_ERR(qcom->qscratch_base)) {
   416  dev_err(qcom->dev, "failed to map qscratch - %d\n", 
ret);
   417  ret = PTR_ERR(qcom->qscratch_base);
   418  goto clk_disable;
   419  }
   420  
   421  irq = platform_get_irq_byname(pdev, "hs_phy_irq");
   422  if (irq > 0) {
   423  ret = devm_request_threaded_irq(qcom->dev, irq, NULL,
   424  qcom_dwc3_resume_irq,
   425  IRQF_TRIGGER_HIGH | 
IRQF_ONESHOT,
   426  "qcom_dwc3 HS", qcom);
   427  if (ret) {
   428  dev_err(qcom->dev, "hs_phy_irq failed: %d\n", 
ret);
   429  goto clk_disable;
   430  }
   431  }
   432  
   433  irq = platform_get_irq_byname(pdev, "dp_hs_phy_irq");
   434  if (irq > 0) {
   435  irq_set_status_flags(irq, IRQ_NOAUTOEN);
   436  ret = devm_request_threaded_irq(qcom->dev, irq, NULL,
   437  qcom_dwc3_resume_irq,
   438  IRQF_TRIGGER_HIGH | 
IRQF_ONESHOT,
   439  "qcom_dwc3 DP_HS", qcom);
   440  if (ret) {
   441  dev_err(qcom->dev, "dp_hs_phy_irq failed: 
%d\n", ret);
   442  goto clk_disable;
   443  }
   444  qcom->dp_hs_phy_irq = irq;
   445  }
   446  
   447  irq = platform_get_irq_byname(pdev, "dm_hs_phy_irq");
   448  if (irq > 0) {
   449  irq_set_status_flags(irq, IRQ_NOAUTOEN);
   450  ret = devm_request_threaded_irq(qcom->dev, irq, NULL,
   451  qcom_dwc3_resume_irq,
   452  IRQF_TRIGGER_HIGH | 
IRQF_ONESHOT,
   453  "qcom_dwc3 DM_HS", qcom);
   454  if (ret) {
   455  dev_err(qcom->dev, "dm_hs_phy_irq failed: 
%d\n", ret);
   456

[usb:usb-next 43/44] drivers/usb/core/quirks.c:135:9: error: implicit declaration of function 'param_set_copystring'

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
head:   8f94390226487bcb86c554ddc12eef0d27bdec3b
commit: b27560e4d9e5240b5544c9c5650c7442e482646e [43/44] usb: core: Add 
"quirks" parameter for usbcore
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout b27560e4d9e5240b5544c9c5650c7442e482646e
# save the attached .config to linux build tree
make.cross ARCH=sparc64 

All error/warnings (new ones prefixed by >>):

>> drivers/usb/core/quirks.c:27:59: warning: 'struct kernel_param' declared 
>> inside parameter list will not be visible outside of this definition or 
>> declaration
static int quirks_param_set(const char *val, const struct kernel_param *kp)
  ^~~~
   drivers/usb/core/quirks.c: In function 'quirks_param_set':
>> drivers/usb/core/quirks.c:135:9: error: implicit declaration of function 
>> 'param_set_copystring' [-Werror=implicit-function-declaration]
 return param_set_copystring(val, kp);
^~~~
   drivers/usb/core/quirks.c: At top level:
>> drivers/usb/core/quirks.c:138:21: error: variable 'quirks_param_ops' has 
>> initializer but incomplete type
static const struct kernel_param_ops quirks_param_ops = {
^~~~
>> drivers/usb/core/quirks.c:139:3: error: 'const struct kernel_param_ops' has 
>> no member named 'set'
 .set = quirks_param_set,
  ^~~
>> drivers/usb/core/quirks.c:139:9: warning: excess elements in struct 
>> initializer
 .set = quirks_param_set,
^~~~
   drivers/usb/core/quirks.c:139:9: note: (near initialization for 
'quirks_param_ops')
>> drivers/usb/core/quirks.c:140:3: error: 'const struct kernel_param_ops' has 
>> no member named 'get'
 .get = param_get_string,
  ^~~
>> drivers/usb/core/quirks.c:140:9: error: 'param_get_string' undeclared here 
>> (not in a function); did you mean 'page_get_link'?
 .get = param_get_string,
^~~~
page_get_link
   drivers/usb/core/quirks.c:140:9: warning: excess elements in struct 
initializer
   drivers/usb/core/quirks.c:140:9: note: (near initialization for 
'quirks_param_ops')
>> drivers/usb/core/quirks.c:143:15: error: variable 'quirks_param_string' has 
>> initializer but incomplete type
static struct kparam_string quirks_param_string = {
  ^
>> drivers/usb/core/quirks.c:144:3: error: 'struct kparam_string' has no member 
>> named 'maxlen'
 .maxlen = sizeof(quirks_param),
  ^~
   drivers/usb/core/quirks.c:144:12: warning: excess elements in struct 
initializer
 .maxlen = sizeof(quirks_param),
   ^~
   drivers/usb/core/quirks.c:144:12: note: (near initialization for 
'quirks_param_string')
>> drivers/usb/core/quirks.c:145:3: error: 'struct kparam_string' has no member 
>> named 'string'
 .string = quirks_param,
  ^~
   drivers/usb/core/quirks.c:145:12: warning: excess elements in struct 
initializer
 .string = quirks_param,
   ^~~~
   drivers/usb/core/quirks.c:145:12: note: (near initialization for 
'quirks_param_string')
>> drivers/usb/core/quirks.c:148:25: error: expected ')' before '&' token
module_param_cb(quirks, _param_ops, _param_string, 0644);
^
>> drivers/usb/core/quirks.c:149:26: error: expected ')' before string constant
MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying 
quirks=vendorID:productID:quirks");
 
^~
>> drivers/usb/core/quirks.c:138:38: error: storage size of 'quirks_param_ops' 
>> isn't known
static const struct kernel_param_ops quirks_param_ops = {
 ^~~~
>> drivers/usb/core/quirks.c:143:29: error: storage size of 
>> 'quirks_param_string' isn't known
static struct kparam_string quirks_param_string = {
^~~
   drivers/usb/core/quirks.c:143:29: warning: 'quirks_param_string' defined but 
not used [-Wunused-variable]
   cc1: some warnings being treated as errors

vim +/param_set_copystring +135 drivers/usb/core/quirks.c

26  
  > 27  static int quirks_param_set(const char *val, const struct kernel_param 
*kp)
28  {
29  char *p, *field;
30  u16 vid, pid;
31  u32 flags;
32  size_t i;
33  
34  mutex_lock(_mutex);
35  
36  if (!val || !*val) {
37  quirk_count = 0;
38  kfree(quirk_list);
39  quirk_list = NULL;
40  goto unlock;

Re: [PATCH v4] usb: core: Add "quirks" parameter for usbcore

[kbuild test robot]

Hi Kai-Heng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.16-rc3 next-20180228]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Kai-Heng-Feng/usb-core-Add-quirks-parameter-for-usbcore/20180227-211635
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: mips-sb1250_swarm_defconfig (attached as .config)
compiler: mips64-linux-gnuabi64-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=mips 

All errors (new ones prefixed by >>):

   drivers/usb/core/quirks.c:15:43: error: expected ')' before 'sizeof'
module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644);
  ^~
>> drivers/usb/core/quirks.c:16:26: error: expected ')' before string constant
MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying 
quirks=vendorID:productID:quirks");
 
^~

vim +16 drivers/usb/core/quirks.c

13  
14  static char quirks_param[128];
  > 15  module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644);
  > 16  MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying 
quirks=vendorID:productID:quirks");
17  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH v4] usb: core: Add "quirks" parameter for usbcore

[kbuild test robot]

Hi Kai-Heng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.16-rc3 next-20180228]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Kai-Heng-Feng/usb-core-Add-quirks-parameter-for-usbcore/20180227-211635
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: tile-tilegx_defconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=tile 

All errors (new ones prefixed by >>):

>> drivers/usb/core/quirks.c:15:43: error: expected ')' before 'sizeof'
module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644);
  ^~
   drivers/usb/core/quirks.c:16:26: error: expected ')' before string constant
MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying 
quirks=vendorID:productID:quirks");
 
^~

vim +15 drivers/usb/core/quirks.c

13  
14  static char quirks_param[128];
  > 15  module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644);
16  MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying 
quirks=vendorID:productID:quirks");
17  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH v3] usb: core: Add "quirks" parameter for usbcore

[kbuild test robot]

Hi Kai-Heng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.16-rc3 next-20180226]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Kai-Heng-Feng/usb-core-Add-quirks-parameter-for-usbcore/20180227-041204
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: arm-badge4_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm 

All errors (new ones prefixed by >>):

>> drivers/usb//core/quirks.c:15:43: error: expected ')' before 'sizeof'
module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644);
  ^~
>> drivers/usb//core/quirks.c:16:26: error: expected ')' before string constant
MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying 
quirks=vendorID:productID:quirks");
 
^~

vim +15 drivers/usb//core/quirks.c

13  
14  static char quirks_param[128];
  > 15  module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644);
  > 16  MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying 
quirks=vendorID:productID:quirks");
17  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH v4 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

[kbuild test robot]

Hi Andrzej,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.16-rc2 next-20180221]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Andrzej-Hajda/dt-bindings-add-bindings-for-USB-physical-connector/20180221-185759
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm64 

All errors (new ones prefixed by >>):

>> Error: arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi:864.1-2 syntax 
>> error
   FATAL ERROR: Unable to parse input tree

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

[kbuild test robot]

Hi Tony,

I love your patch! Perhaps something to improve:

[auto build test WARNING on phy/next]
[also build test WARNING on v4.16-rc2 next-20180216]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Tony-Lindgren/phy-mapphone-mdm6600-Add-USB-PHY-driver-for-MDM6600-on-Droid-4/20180219-131127
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git 
next
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/phy/motorola/phy-mapphone-mdm6600.c:354:24: sparse: incompatible 
>> types for operation (>=)
   drivers/phy/motorola/phy-mapphone-mdm6600.c:354:24: left side has type 
struct gpio_desc
   drivers/phy/motorola/phy-mapphone-mdm6600.c:354:24: right side has type int
>> drivers/phy/motorola/phy-mapphone-mdm6600.c:354:24: sparse: incorrect type 
>> in conditional
   drivers/phy/motorola/phy-mapphone-mdm6600.c:354:24: got bad type

vim +354 drivers/phy/motorola/phy-mapphone-mdm6600.c

   340  
   341  /**
   342   * phy_mdm6600_device_power_off() - power off mdm6600 device
   343   * @ddata: device driver data
   344   */
   345  static void phy_mdm6600_device_power_off(struct phy_mdm6600 *ddata)
   346  {
   347  struct gpio_desc *reset_gpio =
   348  ddata->gpio[PHY_MDM6600_RESET];
   349  
   350  ddata->enabled = false;
   351  phy_mdm6600_cmd(ddata, AP_STATUS_BP_SHUTDOWN_REQ);
   352  msleep(100);
   353  
 > 354  if (reset_gpio >= 0)
   355  gpiod_set_value_cansleep(reset_gpio, 1);
   356  
   357  dev_info(ddata->dev, "Waiting for power down request to 
complete.. ");
   358  if (wait_for_completion_timeout(>ack,
   359  msecs_to_jiffies(5000))) {
   360  dev_info(ddata->dev, "Powered down OK\n");
   361  } else {
   362  dev_err(ddata->dev, "Timed out powering down\n");
   363  }
   364  }
   365  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[balbi-usb:testing/next 45/57] drivers/usb/dwc2/core.c:438:13: error: static declaration of 'dwc2_clear_force_mode' follows non-static declaration

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git 
testing/next
head:   65223a0ed97c8c4b18c4899653745058f87d67e3
commit: 4caf1fe8fb537388810a4c8fecfa5324b26f80ea [45/57] usb: dwc2: Make 
dwc2_force_mode() static
config: i386-randconfig-x072-201806 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout 4caf1fe8fb537388810a4c8fecfa5324b26f80ea
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

>> drivers/usb/dwc2/core.c:438:13: error: static declaration of 
>> 'dwc2_clear_force_mode' follows non-static declaration
static void dwc2_clear_force_mode(struct dwc2_hsotg *hsotg)
^
   In file included from drivers/usb/dwc2/core.c:57:0:
   drivers/usb/dwc2/core.h:1101:6: note: previous declaration of 
'dwc2_clear_force_mode' was here
void dwc2_clear_force_mode(struct dwc2_hsotg *hsotg);
 ^

vim +/dwc2_clear_force_mode +438 drivers/usb/dwc2/core.c

   428  
   429  /**
   430   * dwc2_clear_force_mode() - Clears the force mode bits.
   431   *
   432   * After clearing the bits, wait up to 100 ms to account for any
   433   * potential IDDIG filter delay. We can't know if we expect this delay
   434   * or not because the value of the connector ID status is affected by
   435   * the force mode. We only need to call this once during probe if
   436   * dr_mode == OTG.
   437   */
 > 438  static void dwc2_clear_force_mode(struct dwc2_hsotg *hsotg)
   439  {
   440  u32 gusbcfg;
   441  
   442  gusbcfg = dwc2_readl(hsotg->regs + GUSBCFG);
   443  gusbcfg &= ~GUSBCFG_FORCEHOSTMODE;
   444  gusbcfg &= ~GUSBCFG_FORCEDEVMODE;
   445  dwc2_writel(gusbcfg, hsotg->regs + GUSBCFG);
   446  
   447  if (dwc2_iddig_filter_enabled(hsotg))
   448  msleep(100);
   449  }
   450  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH 2/4] usb: dwc3: add dwc3 glue layer for UniPhier SoCs

[kbuild test robot]

Hi Kunihiko,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.15-rc9 next-20180119]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Kunihiko-Hayashi/usb-dwc3-add-UniPhier-dwc3-glue-layer-support/20180126-035928
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

   drivers/usb//dwc3/dwc3-uniphier.c: In function 'dwc3u_probe':
>> drivers/usb//dwc3/dwc3-uniphier.c:428:12: error: implicit declaration of 
>> function 'of_clk_get_parent_count'; did you mean 'clk_get_parent'? 
>> [-Werror=implicit-function-declaration]
 nr_clks = of_clk_get_parent_count(node);
   ^~~
   clk_get_parent
   cc1: some warnings being treated as errors

vim +428 drivers/usb//dwc3/dwc3-uniphier.c

   401  
   402  static int dwc3u_probe(struct platform_device *pdev)
   403  {
   404  struct device *dev = >dev;
   405  struct device_node *node;
   406  struct dwc3u_priv *priv;
   407  struct resource *res;
   408  struct clk *clk;
   409  int i, nr_clks;
   410  int ret = 0;
   411  
   412  priv = devm_kzalloc(>dev, sizeof(*priv), GFP_KERNEL);
   413  if (!priv)
   414  return -ENOMEM;
   415  
   416  priv->data = of_device_get_match_data(dev);
   417  if (WARN_ON(!priv->data))
   418  return -EINVAL;
   419  
   420  res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
   421  priv->base = devm_ioremap_resource(dev, res);
   422  if (IS_ERR(priv->base))
   423  return PTR_ERR(priv->base);
   424  
   425  priv->dev = dev;
   426  
   427  node = dev->of_node;
 > 428  nr_clks = of_clk_get_parent_count(node);
   429  if (!nr_clks) {
   430  dev_err(dev, "failed to get clock property\n");
   431  return -ENODEV;
   432  }
   433  
   434  priv->clks = devm_kcalloc(priv->dev, nr_clks, sizeof(struct clk 
*),
   435GFP_KERNEL);
   436  if (!priv->clks)
   437  return -ENOMEM;
   438  
   439  for (i = 0; i < nr_clks; i++) {
   440  clk = of_clk_get(node, i);
   441  if (IS_ERR(clk)) {
   442  ret = PTR_ERR(clk);
   443  goto out_clk_disable;
   444  }
   445  ret = clk_prepare_enable(clk);
   446  if (ret < 0) {
   447  clk_put(clk);
   448  goto out_clk_disable;
   449  }
   450  priv->clks[i] = clk;
   451  priv->nclks = i;
   452  }
   453  
   454  priv->rst = 
devm_reset_control_array_get_optional_shared(priv->dev);
   455  if (IS_ERR(priv->rst)) {
   456  ret = PTR_ERR(priv->rst);
   457  goto out_clk_disable;
   458  }
   459  ret = reset_control_deassert(priv->rst);
   460  if (ret)
   461  goto out_clk_disable;
   462  
   463  ret = dwc3u_init(priv);
   464  if (ret)
   465  goto out_rst_assert;
   466  
   467  platform_set_drvdata(pdev, priv);
   468  
   469  ret = of_platform_populate(node, NULL, NULL, priv->dev);
   470  if (ret)
   471  goto out_exit;
   472  
   473  return 0;
   474  
   475  out_exit:
   476  dwc3u_exit(priv);
   477  out_rst_assert:
   478  reset_control_assert(priv->rst);
   479  out_clk_disable:
   480  dwc3u_disable_clk(priv);
   481  
   482  return ret;
   483  }
   484  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

[kbuild test robot]

Hi Benjamin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on balbi-usb/next]
[also build test WARNING on v4.15-rc9 next-20180119]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Benjamin-Herrenschmidt/usb-gadget-Add-an-EP-dispose-callback-for-EP-lifetime-tracking/20180124-065635
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/usb/gadget/udc/aspeed-vhub/epn.c:270:23: sparse: restricted __le32 
>> degrades to integer
--
>> drivers/usb/gadget/udc/aspeed-vhub/dev.c:269:9: sparse: context imbalance in 
>> 'ast_vhub_udc_wakeup' - different lock contexts for basic block

vim +270 drivers/usb/gadget/udc/aspeed-vhub/epn.c

   236  
   237  static void ast_vhub_epn_handle_ack_desc(struct ast_vhub_ep *ep)
   238  {
   239  struct ast_vhub_req *req;
   240  unsigned int len, d_last;
   241  u32 stat, stat1;
   242  
   243  /* Read EP status, workaround HW race */
   244  do {
   245  stat = readl(ep->epn.regs + AST_VHUB_EP_DESC_STATUS);
   246  stat1 = readl(ep->epn.regs + AST_VHUB_EP_DESC_STATUS);
   247  } while(stat != stat1);
   248  
   249  /* Extract RPTR */
   250  d_last = VHUB_EP_DMA_RPTR(stat);
   251  
   252  /* Grab current request if any */
   253  req = list_first_entry_or_null(>queue, struct ast_vhub_req, 
queue);
   254  
   255  EPVDBG(ep, "ACK status=%08x is_in=%d ep->d_last=%d..%d\n",
   256 stat, ep->epn.is_in, ep->epn.d_last, d_last);
   257  
   258  /* Check all completed descriptors */
   259  while (ep->epn.d_last != d_last) {
   260  struct ast_vhub_desc *desc;
   261  unsigned int d_num;
   262  bool is_last_desc;
   263  
   264  /* Grab next completed descriptor */
   265  d_num = ep->epn.d_last;
   266  desc = >epn.descs[d_num];
   267  ep->epn.d_last = (d_num + 1) & (AST_VHUB_DESCS_COUNT - 
1);
   268  
   269  /* Grab len out of descriptor */
 > 270  len = VHUB_DSC1_IN_LEN(desc->w1);
   271  
   272  EPVDBG(ep, " desc %d len=%d req=%p (act=%d)\n",
   273 d_num, len, req, req ? req->active : 0);
   274  
   275  /* If no active request pending, move on */
   276  if (!req || !req->active)
   277  continue;
   278  
   279  /* Adjust size */
   280  req->req.actual += len;
   281  
   282  /* Is that the last chunk ? */
   283  is_last_desc = req->last_desc == d_num;
   284  CHECK(ep, is_last_desc == (len < ep->ep.maxpacket ||
   285 (req->req.actual >= 
req->req.length &&
   286  !req->req.zero)),
   287"Last packet discrepancy: last_desc=%d len=%d 
r.act=%d "
   288"r.len=%d r.zero=%d mp=%d\n",
   289is_last_desc, len, req->req.actual, 
req->req.length,
   290req->req.zero, ep->ep.maxpacket);
   291  
   292  if (is_last_desc) {
   293  /*
   294   * Because we can only have one request at a 
time
   295   * in our descriptor list in this 
implementation,
   296   * d_last and ep->d_last should now be equal
   297   */
   298  CHECK(ep, d_last == ep->epn.d_last,
   299"DMA read ptr mismatch %d vs %d\n",
   300d_last, ep->epn.d_last);
   301  
   302  /* Note: done will drop and re-acquire the lock 
*/
   303  ast_vhub_done(ep, req, 0);
   304  req = list_first_entry_or_null(>queue,
   305 struct 
ast_vhub_req,
   306 queue);
   307  break;
   308  }
   309  }
   310  
   311  /* More work ? */
   312  if (req)
   313  ast_vhub_epn_kick_desc(ep, req);
   314  }
   315  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to 

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

[kbuild test robot]

Hi Benjamin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on balbi-usb/next]
[also build test WARNING on v4.15-rc9 next-20180119]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Benjamin-Herrenschmidt/usb-gadget-Add-an-EP-dispose-callback-for-EP-lifetime-tracking/20180124-065635
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: m32r-allyesconfig (attached as .config)
compiler: m32r-linux-gcc (GCC) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=m32r 

All warnings (new ones prefixed by >>):

   In file included from arch/m32r/include/uapi/asm/byteorder.h:8:0,
from arch/m32r/include/asm/bitops.h:22,
from include/linux/bitops.h:38,
from include/linux/kernel.h:11,
from drivers/usb/gadget/udc/aspeed-vhub/core.c:14:
   include/linux/byteorder/big_endian.h:8:2: warning: #warning inconsistent 
configuration, needs CONFIG_CPU_BIG_ENDIAN [-Wcpp]
#warning inconsistent configuration, needs CONFIG_CPU_BIG_ENDIAN
 ^~~
   In file included from include/linux/printk.h:329:0,
from include/linux/kernel.h:14,
from drivers/usb/gadget/udc/aspeed-vhub/core.c:14:
   drivers/usb/gadget/udc/aspeed-vhub/core.c: In function 'ast_vhub_irq':
>> drivers/usb/gadget/udc/aspeed-vhub/core.c:127:16: warning: format '%x' 
>> expects argument of type 'unsigned int', but argument 5 has type 'long 
>> unsigned int' [-Wformat=]
 UDCVDBG(vhub, "irq status=%08x, ep_acks=%08x ep_nacks=%08x\n",
   ^
   include/linux/dynamic_debug.h:135:39: note: in definition of macro 
'dynamic_dev_dbg'
  __dynamic_dev_dbg(, dev, fmt, \
  ^~~
   drivers/usb/gadget/udc/aspeed-vhub/vhub.h:405:28: note: in expansion of 
macro 'dev_dbg'
#define UDCVDBG(u, fmt...) dev_dbg(&(u)->pdev->dev, fmt)
   ^~~
   drivers/usb/gadget/udc/aspeed-vhub/core.c:127:2: note: in expansion of macro 
'UDCVDBG'
 UDCVDBG(vhub, "irq status=%08x, ep_acks=%08x ep_nacks=%08x\n",
 ^~~
   drivers/usb/gadget/udc/aspeed-vhub/core.c:127:16: warning: format '%x' 
expects argument of type 'unsigned int', but argument 6 has type 'long unsigned 
int' [-Wformat=]
 UDCVDBG(vhub, "irq status=%08x, ep_acks=%08x ep_nacks=%08x\n",
   ^
   include/linux/dynamic_debug.h:135:39: note: in definition of macro 
'dynamic_dev_dbg'
  __dynamic_dev_dbg(, dev, fmt, \
  ^~~
   drivers/usb/gadget/udc/aspeed-vhub/vhub.h:405:28: note: in expansion of 
macro 'dev_dbg'
#define UDCVDBG(u, fmt...) dev_dbg(&(u)->pdev->dev, fmt)
   ^~~
   drivers/usb/gadget/udc/aspeed-vhub/core.c:127:2: note: in expansion of macro 
'UDCVDBG'
 UDCVDBG(vhub, "irq status=%08x, ep_acks=%08x ep_nacks=%08x\n",
 ^~~
--
   In file included from arch/m32r/include/uapi/asm/byteorder.h:8:0,
from arch/m32r/include/asm/bitops.h:22,
from include/linux/bitops.h:38,
from include/linux/kernel.h:11,
from drivers/usb/gadget/udc/aspeed-vhub/epn.c:14:
   include/linux/byteorder/big_endian.h:8:2: warning: #warning inconsistent 
configuration, needs CONFIG_CPU_BIG_ENDIAN [-Wcpp]
#warning inconsistent configuration, needs CONFIG_CPU_BIG_ENDIAN
 ^~~
   In file included from include/linux/printk.h:329:0,
from include/linux/kernel.h:14,
from drivers/usb/gadget/udc/aspeed-vhub/epn.c:14:
   drivers/usb/gadget/udc/aspeed-vhub/epn.c: In function 
'ast_vhub_epn_kick_desc':
>> drivers/usb/gadget/udc/aspeed-vhub/vhub.h:409:3: warning: format '%x' 
>> expects argument of type 'unsigned int', but argument 7 has type 'long 
>> unsigned int' [-Wformat=]
  "%s:EP%d " fmt,\
  ^
   include/linux/dynamic_debug.h:135:39: note: in definition of macro 
'dynamic_dev_dbg'
  __dynamic_dev_dbg(, dev, fmt, \
  ^~~
   drivers/usb/gadget/udc/aspeed-vhub/vhub.h:408:2: note: in expansion of macro 
'dev_dbg'
 dev_dbg(&(ep)->vhub->pdev->dev,   \
 ^~~
   drivers/usb/gadget/udc/aspeed-vhub/epn.c:233:2: note: in expansion of macro 
'EPVDBG'
 EPVDBG(ep, "HW kicked, d_next=%d dstat=%08x\n",
 ^~
   drivers/usb/gadget/udc/aspeed-vhub/epn.c:233:44: note: format string is 
defined here
 EPVDBG(ep, "HW kicked, d_next=%d dstat=%08x\n",
~~~^
%08lx

vim +127 drivers/usb/gadget/udc/aspeed-vhub/core.c

  > 14  #include 

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

[kbuild test robot]

Hi Benjamin,

I love your patch! Yet something to improve:

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.15-rc9]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Benjamin-Herrenschmidt/usb-gadget-Add-an-EP-dispose-callback-for-EP-lifetime-tracking/20180124-065635
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

   WARNING: modpost: missing MODULE_LICENSE() in 
drivers/auxdisplay/img-ascii-lcd.o
   see include/linux/module.h for more information
   WARNING: modpost: missing MODULE_LICENSE() in drivers/gpio/gpio-ath79.o
   see include/linux/module.h for more information
   WARNING: modpost: missing MODULE_LICENSE() in drivers/gpio/gpio-iop.o
   see include/linux/module.h for more information
   WARNING: modpost: missing MODULE_LICENSE() in drivers/iio/accel/kxsd9-i2c.o
   see include/linux/module.h for more information
   WARNING: modpost: missing MODULE_LICENSE() in 
drivers/iio/adc/qcom-vadc-common.o
   see include/linux/module.h for more information
   WARNING: modpost: missing MODULE_LICENSE() in 
drivers/media/platform/mtk-vcodec/mtk-vcodec-common.o
   see include/linux/module.h for more information
   WARNING: modpost: missing MODULE_LICENSE() in 
drivers/media/platform/tegra-cec/tegra_cec.o
   see include/linux/module.h for more information
   WARNING: modpost: missing MODULE_LICENSE() in drivers/mtd/nand/denali_pci.o
   see include/linux/module.h for more information
   WARNING: modpost: missing MODULE_LICENSE() in 
drivers/pinctrl/pxa/pinctrl-pxa2xx.o
   see include/linux/module.h for more information
   WARNING: modpost: missing MODULE_LICENSE() in drivers/power/reset/zx-reboot.o
   see include/linux/module.h for more information
   WARNING: modpost: missing MODULE_LICENSE() in 
drivers/usb/gadget/udc/aspeed-vhub/dev.o
   see include/linux/module.h for more information
   WARNING: modpost: missing MODULE_LICENSE() in 
drivers/usb/gadget/udc/aspeed-vhub/ep0.o
   see include/linux/module.h for more information
   WARNING: modpost: missing MODULE_LICENSE() in 
drivers/usb/gadget/udc/aspeed-vhub/epn.o
   see include/linux/module.h for more information
   WARNING: modpost: missing MODULE_LICENSE() in 
drivers/usb/gadget/udc/aspeed-vhub/hub.o
   see include/linux/module.h for more information
>> ERROR: "ast_vhub_dev_suspend" [drivers/usb/gadget/udc/aspeed-vhub/hub.ko] 
>> undefined!
>> ERROR: "ast_vhub_dev_reset" [drivers/usb/gadget/udc/aspeed-vhub/hub.ko] 
>> undefined!
>> ERROR: "__ast_vhub_simple_reply" [drivers/usb/gadget/udc/aspeed-vhub/hub.ko] 
>> undefined!
>> ERROR: "ast_vhub_dev_resume" [drivers/usb/gadget/udc/aspeed-vhub/hub.ko] 
>> undefined!
>> ERROR: "ast_vhub_reply" [drivers/usb/gadget/udc/aspeed-vhub/hub.ko] 
>> undefined!
>> ERROR: "ast_vhub_free_request" [drivers/usb/gadget/udc/aspeed-vhub/epn.ko] 
>> undefined!
>> ERROR: "ast_vhub_alloc_request" [drivers/usb/gadget/udc/aspeed-vhub/epn.ko] 
>> undefined!
>> ERROR: "ast_vhub_nuke" [drivers/usb/gadget/udc/aspeed-vhub/epn.ko] undefined!
>> ERROR: "ast_vhub_done" [drivers/usb/gadget/udc/aspeed-vhub/epn.ko] undefined!
>> ERROR: "ast_vhub_free_request" [drivers/usb/gadget/udc/aspeed-vhub/ep0.ko] 
>> undefined!
>> ERROR: "ast_vhub_alloc_request" [drivers/usb/gadget/udc/aspeed-vhub/ep0.ko] 
>> undefined!
>> ERROR: "ast_vhub_std_dev_request" 
>> [drivers/usb/gadget/udc/aspeed-vhub/ep0.ko] undefined!
>> ERROR: "ast_vhub_class_hub_request" 
>> [drivers/usb/gadget/udc/aspeed-vhub/ep0.ko] undefined!
>> ERROR: "ast_vhub_std_hub_request" 
>> [drivers/usb/gadget/udc/aspeed-vhub/ep0.ko] undefined!
>> ERROR: "ast_vhub_nuke" [drivers/usb/gadget/udc/aspeed-vhub/ep0.ko] undefined!
>> ERROR: "ast_vhub_done" [drivers/usb/gadget/udc/aspeed-vhub/ep0.ko] undefined!
>> ERROR: "ast_vhub_init_ep0" [drivers/usb/gadget/udc/aspeed-vhub/dev.ko] 
>> undefined!
>> ERROR: "__ast_vhub_simple_reply" [drivers/usb/gadget/udc/aspeed-vhub/dev.ko] 
>> undefined!
>> ERROR: "ast_vhub_ep0_handle_setup" 
>> [drivers/usb/gadget/udc/aspeed-vhub/dev.ko] undefined!
>> ERROR: "ast_vhub_ep0_handle_ack" [drivers/usb/gadget/udc/aspeed-vhub/dev.ko] 
>> undefined!

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[PATCH] usb: xhci-mtk: fix semicolon.cocci warnings

[kbuild test robot]

From: Fengguang Wu 

drivers/usb/host/xhci-mtk.c:311:2-3: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: a2ecc4df9f84 ("usb: xhci-mtk: supports remote wakeup for mt2712 with two 
xHCI IPs")
CC: Chunfeng Yun 
Signed-off-by: Fengguang Wu 
---

 xhci-mtk.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -308,7 +308,7 @@ static void usb_wakeup_ip_sleep_set(stru
break;
default:
return;
-   };
+   }
regmap_update_bits(mtk->uwk, reg, msk, val);
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] usb: mtu3: fix semicolon.cocci warnings

[kbuild test robot]

From: Fengguang Wu 

drivers/usb/mtu3/mtu3_host.c:58:2-3: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: f0ede2c6282b ("usb: mtu3: supports remote wakeup for mt2712 with two 
SSUSB IPs")
CC: Chunfeng Yun 
Signed-off-by: Fengguang Wu 
---

 mtu3_host.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/mtu3/mtu3_host.c
+++ b/drivers/usb/mtu3/mtu3_host.c
@@ -55,7 +55,7 @@ static void ssusb_wakeup_ip_sleep_set(st
break;
default:
return;
-   };
+   }
regmap_update_bits(ssusb->uwk, reg, msk, val);
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 44/49] usb: dwc2: Bit polling functionality update.

[kbuild test robot]

Hi Sevak,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on balbi-usb/next]
[cannot apply to v4.15-rc5 next-20171222]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Grigor-Tovmasyan/usb-dwc2-fixes-enhancements-and-new-features/20171226-005211
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: i386-randconfig-x005-201752 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/usb/dwc2/core.c: In function 'dwc2_flush_tx_fifo':
>> drivers/usb/dwc2/core.c:863:3: warning: 'greset' may be used uninitialized 
>> in this function [-Wmaybe-uninitialized]
  dev_warn(hsotg->dev, "%s() HANG! AHB Idle GRSTCTL=%0x\n",
  ^
__func__, greset);
~
   drivers/usb/dwc2/core.c: In function 'dwc2_flush_rx_fifo':
   drivers/usb/dwc2/core.c:893:3: warning: 'greset' may be used uninitialized 
in this function [-Wmaybe-uninitialized]
  dev_warn(hsotg->dev, "%s() HANG! AHB Idle GRSTCTL=%0x\n",
  ^
__func__, greset);
~

vim +/greset +863 drivers/usb/dwc2/core.c

   848  
   849  /**
   850   * dwc2_flush_tx_fifo() - Flushes a Tx FIFO
   851   *
   852   * @hsotg: Programming view of DWC_otg controller
   853   * @num:   Tx FIFO to flush
   854   */
   855  void dwc2_flush_tx_fifo(struct dwc2_hsotg *hsotg, const int num)
   856  {
   857  u32 greset;
   858  
   859  dev_vdbg(hsotg->dev, "Flush Tx FIFO %d\n", num);
   860  
   861  /* Wait for AHB master IDLE state */
   862  if (dwc2_hsotg_wait_bit_set(hsotg, GRSTCTL, GRSTCTL_AHBIDLE, 
1)) {
 > 863  dev_warn(hsotg->dev, "%s() HANG! AHB Idle 
 > GRSTCTL=%0x\n",
   864   __func__, greset);
   865  return;
   866  }
   867  
   868  greset = GRSTCTL_TXFFLSH;
   869  greset |= num << GRSTCTL_TXFNUM_SHIFT & GRSTCTL_TXFNUM_MASK;
   870  dwc2_writel(greset, hsotg->regs + GRSTCTL);
   871  
   872  if (dwc2_hsotg_wait_bit_clear(hsotg, GRSTCTL, GRSTCTL_TXFFLSH, 
1))
   873  dev_warn(hsotg->dev, "%s:  HANG! timeout GRSTCTL 
GRSTCTL_TXFFLSH\n",
   874   __func__);
   875  
   876  /* Wait for at least 3 PHY Clocks */
   877  udelay(1);
   878  }
   879  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH v3 6/7] typec: tcpm: Represent source supply through power_supply class

[kbuild test robot]

Hi Adam,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20171214]
[cannot apply to usb/usb-testing hwmon/hwmon-next v4.15-rc3 v4.15-rc2 v4.15-rc1 
v4.15-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Adam-Thomson/typec-tcpm-Add-sink-side-support-for-PPS/20171220-205656


coccinelle warnings: (new ones prefixed by >>)

>> drivers/usb/typec/tcpm.c:4396:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] typec: tcpm: fix ptr_ret.cocci warnings

[kbuild test robot]

From: Fengguang Wu 

drivers/usb/typec/tcpm.c:4396:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: 91886adfce05 ("typec: tcpm: Represent source supply through power_supply 
class")
CC: Adam Thomson 
Signed-off-by: Fengguang Wu 
---

 tcpm.c |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/usb/typec/tcpm.c
+++ b/drivers/usb/typec/tcpm.c
@@ -4393,10 +4393,7 @@ int devm_tcpm_psy_register(struct tcpm_p
 
port->psy = devm_power_supply_register(port->dev, >psy_desc,
   _cfg);
-   if (IS_ERR(port->psy))
-   return PTR_ERR(port->psy);
-
-   return 0;
+   return PTR_ERR_OR_ZERO(port->psy);
 }
 
 struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header

[kbuild test robot]

Hi Adam,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20171214]
[also build test ERROR on v4.15-rc4]
[cannot apply to usb/usb-testing hwmon/hwmon-next v4.15-rc3 v4.15-rc2 v4.15-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Adam-Thomson/typec-tcpm-Add-sink-side-support-for-PPS/20171220-205656
config: i386-randconfig-x016-201751 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

Note: the 
linux-review/Adam-Thomson/typec-tcpm-Add-sink-side-support-for-PPS/20171220-205656
 HEAD 79d2ed6a04117216910ac1dad566e86599a0bcf5 builds fine.
  It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers/usb/typec/tcpm.c: In function 'tcpm_pd_send_source_caps':
>> drivers/usb/typec/tcpm.c:794:27: error: macro "PD_HEADER_LE" requires 6 
>> arguments, but only 5 given
   port->message_id, 0);
  ^
>> drivers/usb/typec/tcpm.c:791:16: error: 'PD_HEADER_LE' undeclared (first use 
>> in this function)
  msg.header = PD_HEADER_LE(PD_CTRL_REJECT,
   ^~~~
   drivers/usb/typec/tcpm.c:791:16: note: each undeclared identifier is 
reported only once for each function it appears in
   drivers/usb/typec/tcpm.c:800:24: error: macro "PD_HEADER_LE" requires 6 
arguments, but only 5 given
   port->nr_src_pdo);
   ^
   drivers/usb/typec/tcpm.c: In function 'tcpm_pd_send_sink_caps':
   drivers/usb/typec/tcpm.c:819:27: error: macro "PD_HEADER_LE" requires 6 
arguments, but only 5 given
   port->message_id, 0);
  ^
   drivers/usb/typec/tcpm.c:816:16: error: 'PD_HEADER_LE' undeclared (first use 
in this function)
  msg.header = PD_HEADER_LE(PD_CTRL_REJECT,
   ^~~~
   drivers/usb/typec/tcpm.c:825:24: error: macro "PD_HEADER_LE" requires 6 
arguments, but only 5 given
   port->nr_snk_pdo);
   ^
   drivers/usb/typec/tcpm.c: In function 'vdm_run_state_machine':
   drivers/usb/typec/tcpm.c:1190:41: error: macro "PD_HEADER_LE" requires 6 
arguments, but only 5 given
   port->message_id, port->vdo_count);
^
   drivers/usb/typec/tcpm.c:1187:16: error: 'PD_HEADER_LE' undeclared (first 
use in this function)
  msg.header = PD_HEADER_LE(PD_DATA_VENDOR_DEF,
   ^~~~
   drivers/usb/typec/tcpm.c: In function 'tcpm_pd_send_control':
   drivers/usb/typec/tcpm.c:1669:26: error: macro "PD_HEADER_LE" requires 6 
arguments, but only 5 given
  port->message_id, 0);
 ^
   drivers/usb/typec/tcpm.c:1667:15: error: 'PD_HEADER_LE' undeclared (first 
use in this function)
 msg.header = PD_HEADER_LE(type, port->pwr_role,
  ^~~~
   drivers/usb/typec/tcpm.c: In function 'tcpm_pd_send_request':
   drivers/usb/typec/tcpm.c:1946:26: error: macro "PD_HEADER_LE" requires 6 
arguments, but only 5 given
  port->message_id, 1);
 ^
   drivers/usb/typec/tcpm.c:1943:15: error: 'PD_HEADER_LE' undeclared (first 
use in this function)
 msg.header = PD_HEADER_LE(PD_DATA_REQUEST,
  ^~~~

vim +/PD_HEADER_LE +794 drivers/usb/typec/tcpm.c

f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27  782  
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27  783  static int 
tcpm_pd_send_source_caps(struct tcpm_port *port)
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27  784  {
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27  785 struct 
pd_message msg;
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27  786 int i;
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27  787  
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27  788 
memset(, 0, sizeof(msg));
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27  789 if 
(!port->nr_src_pdo) {
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27  790 
/* No source capabilities defined, sink only */
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 @791 
msg.header = PD_HEADER_LE(PD_CTRL_REJECT,
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27  792 
  port->pwr_role,
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27  793 
  port->data_role,
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 @794 
  port->message_id, 0);
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27  795 } else {
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27  796 

Re: [PATCH v2 3/4] usb: phy: Add Kconfig entry for Tegra PHY driver

[kbuild test robot]

Hi Dmitry,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.15-rc4 next-20171220]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Dmitry-Osipenko/usb-phy-tegra-Cleanup-error-messages/20171220-142227
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: arm-tegra_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   drivers/usb/host/ehci-tegra.o: In function `tegra_ehci_hub_control':
>> ehci-tegra.c:(.text+0x818): undefined reference to `tegra_usb_phy_preresume'
>> ehci-tegra.c:(.text+0x9b4): undefined reference to `tegra_usb_phy_postresume'

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[balbi-usb:testing/next 25/25] drivers/usb/renesas_usbhs/rcar3.c:115:5: sparse: symbol 'usbhs_rcar3_notifier' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git 
testing/next
head:   3a7cce26122e3925993ee2ac0b45ac6b9bf6f65f
commit: 3a7cce26122e3925993ee2ac0b45ac6b9bf6f65f [25/25] usb: renesas_usbhs: 
add extcon notifier to set mode for non-otg channel
reproduce:
# apt-get install sparse
git checkout 3a7cce26122e3925993ee2ac0b45ac6b9bf6f65f
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)


Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[RFC PATCH balbi-usb] usb: renesas_usbhs: usbhs_rcar3_notifier() can be static

[kbuild test robot]

Fixes: 3a7cce26122e ("usb: renesas_usbhs: add extcon notifier to set mode for 
non-otg channel")
Signed-off-by: Fengguang Wu 
---
 rcar3.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/renesas_usbhs/rcar3.c 
b/drivers/usb/renesas_usbhs/rcar3.c
index d657309..d0ea4ff 100644
--- a/drivers/usb/renesas_usbhs/rcar3.c
+++ b/drivers/usb/renesas_usbhs/rcar3.c
@@ -112,8 +112,8 @@ static int usbhs_rcar3_get_id(struct platform_device *pdev)
return USBHS_GADGET;
 }
 
-int usbhs_rcar3_notifier(struct notifier_block *nb, unsigned long event,
-void *data)
+static int usbhs_rcar3_notifier(struct notifier_block *nb, unsigned long event,
+   void *data)
 {
struct usbhs_priv *priv = container_of(nb, struct usbhs_priv, nb);
 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[balbi-usb:testing/next 6/16] drivers/usb/gadget/function/f_ncm.c:1105:10: error: 'HRTIMER_MODE_REL_SOFT' undeclared

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git 
testing/next
head:   4929fb631d4cedc385910fd998518e22bd71d680
commit: 562d8eeed9a6bb9ca3370a3f75d96f0e7ba0a059 [6/16] usb/gadget/NCM: Replace 
tasklet with softirq hrtimer
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 562d8eeed9a6bb9ca3370a3f75d96f0e7ba0a059
# save the attached .config to linux build tree
make.cross ARCH=xtensa 

All errors (new ones prefixed by >>):

   drivers/usb/gadget/function/f_ncm.c: In function 'ncm_wrap_ntb':
>> drivers/usb/gadget/function/f_ncm.c:1105:10: error: 'HRTIMER_MODE_REL_SOFT' 
>> undeclared (first use in this function)
 HRTIMER_MODE_REL_SOFT);
 ^
   drivers/usb/gadget/function/f_ncm.c:1105:10: note: each undeclared 
identifier is reported only once for each function it appears in
   drivers/usb/gadget/function/f_ncm.c: In function 'ncm_bind':
   drivers/usb/gadget/function/f_ncm.c:1502:50: error: 'HRTIMER_MODE_REL_SOFT' 
undeclared (first use in this function)
 hrtimer_init(>task_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_SOFT);
 ^

vim +/HRTIMER_MODE_REL_SOFT +1105 drivers/usb/gadget/function/f_ncm.c

  1011  
  1012  static struct sk_buff *ncm_wrap_ntb(struct gether *port,
  1013  struct sk_buff *skb)
  1014  {
  1015  struct f_ncm*ncm = func_to_ncm(>func);
  1016  struct sk_buff  *skb2 = NULL;
  1017  int ncb_len = 0;
  1018  __le16  *ntb_data;
  1019  __le16  *ntb_ndp;
  1020  int dgram_pad;
  1021  
  1022  unsignedmax_size = ncm->port.fixed_in_len;
  1023  const struct ndp_parser_opts *opts = ncm->parser_opts;
  1024  const int ndp_align = 
le16_to_cpu(ntb_parameters.wNdpInAlignment);
  1025  const int div = le16_to_cpu(ntb_parameters.wNdpInDivisor);
  1026  const int rem = 
le16_to_cpu(ntb_parameters.wNdpInPayloadRemainder);
  1027  const int dgram_idx_len = 2 * 2 * opts->dgram_item_len;
  1028  
  1029  if (!skb && !ncm->skb_tx_data)
  1030  return NULL;
  1031  
  1032  if (skb) {
  1033  /* Add the CRC if required up front */
  1034  if (ncm->is_crc) {
  1035  uint32_tcrc;
  1036  __le16  *crc_pos;
  1037  
  1038  crc = ~crc32_le(~0,
  1039  skb->data,
  1040  skb->len);
  1041  crc_pos = skb_put(skb, sizeof(uint32_t));
  1042  put_unaligned_le32(crc, crc_pos);
  1043  }
  1044  
  1045  /* If the new skb is too big for the current NCM NTB 
then
  1046   * set the current stored skb to be sent now and clear 
it
  1047   * ready for new data.
  1048   * NOTE: Assume maximum align for speed of calculation.
  1049   */
  1050  if (ncm->skb_tx_data
  1051  && (ncm->ndp_dgram_count >= TX_MAX_NUM_DPE
  1052  || (ncm->skb_tx_data->len +
  1053  div + rem + skb->len +
  1054  ncm->skb_tx_ndp->len + ndp_align + (2 * 
dgram_idx_len))
  1055  > max_size)) {
  1056  skb2 = package_for_tx(ncm);
  1057  if (!skb2)
  1058  goto err;
  1059  }
  1060  
  1061  if (!ncm->skb_tx_data) {
  1062  ncb_len = opts->nth_size;
  1063  dgram_pad = ALIGN(ncb_len, div) + rem - ncb_len;
  1064  ncb_len += dgram_pad;
  1065  
  1066  /* Create a new skb for the NTH and datagrams. 
*/
  1067  ncm->skb_tx_data = alloc_skb(max_size, 
GFP_ATOMIC);
  1068  if (!ncm->skb_tx_data)
  1069  goto err;
  1070  
  1071  ncm->skb_tx_data->dev = ncm->netdev;
  1072  ntb_data = skb_put_zero(ncm->skb_tx_data, 
ncb_len);
  1073  /* dwSignature */
  1074  put_unaligned_le32(opts->nth_sign, ntb_data);
  1075  ntb_data += 2;
  1076  /* wHeaderLength */
  1077  put_unaligned_le16(opts->nth_size, ntb_data++);
  1078  
  1079  /* Allocate an skb for storing the NDP,
  1080   * 

[balbi-usb:testing/next 6/16] drivers/usb/gadget/function/f_ncm.c:1105:10: error: 'HRTIMER_MODE_REL_SOFT' undeclared; did you mean 'HRTIMER_MODE_REL'?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git 
testing/next
head:   4929fb631d4cedc385910fd998518e22bd71d680
commit: 562d8eeed9a6bb9ca3370a3f75d96f0e7ba0a059 [6/16] usb/gadget/NCM: Replace 
tasklet with softirq hrtimer
config: i386-randconfig-x073-201749 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
git checkout 562d8eeed9a6bb9ca3370a3f75d96f0e7ba0a059
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/usb/gadget/function/f_ncm.c: In function 'ncm_wrap_ntb':
>> drivers/usb/gadget/function/f_ncm.c:1105:10: error: 'HRTIMER_MODE_REL_SOFT' 
>> undeclared (first use in this function); did you mean 'HRTIMER_MODE_REL'?
 HRTIMER_MODE_REL_SOFT);
 ^
 HRTIMER_MODE_REL
   drivers/usb/gadget/function/f_ncm.c:1105:10: note: each undeclared 
identifier is reported only once for each function it appears in
   drivers/usb/gadget/function/f_ncm.c: In function 'ncm_bind':
   drivers/usb/gadget/function/f_ncm.c:1502:50: error: 'HRTIMER_MODE_REL_SOFT' 
undeclared (first use in this function); did you mean 'HRTIMER_MODE_REL'?
 hrtimer_init(>task_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_SOFT);
 ^
 HRTIMER_MODE_REL

vim +1105 drivers/usb/gadget/function/f_ncm.c

  1011  
  1012  static struct sk_buff *ncm_wrap_ntb(struct gether *port,
  1013  struct sk_buff *skb)
  1014  {
  1015  struct f_ncm*ncm = func_to_ncm(>func);
  1016  struct sk_buff  *skb2 = NULL;
  1017  int ncb_len = 0;
  1018  __le16  *ntb_data;
  1019  __le16  *ntb_ndp;
  1020  int dgram_pad;
  1021  
  1022  unsignedmax_size = ncm->port.fixed_in_len;
  1023  const struct ndp_parser_opts *opts = ncm->parser_opts;
  1024  const int ndp_align = 
le16_to_cpu(ntb_parameters.wNdpInAlignment);
  1025  const int div = le16_to_cpu(ntb_parameters.wNdpInDivisor);
  1026  const int rem = 
le16_to_cpu(ntb_parameters.wNdpInPayloadRemainder);
  1027  const int dgram_idx_len = 2 * 2 * opts->dgram_item_len;
  1028  
  1029  if (!skb && !ncm->skb_tx_data)
  1030  return NULL;
  1031  
  1032  if (skb) {
  1033  /* Add the CRC if required up front */
  1034  if (ncm->is_crc) {
  1035  uint32_tcrc;
  1036  __le16  *crc_pos;
  1037  
  1038  crc = ~crc32_le(~0,
  1039  skb->data,
  1040  skb->len);
  1041  crc_pos = skb_put(skb, sizeof(uint32_t));
  1042  put_unaligned_le32(crc, crc_pos);
  1043  }
  1044  
  1045  /* If the new skb is too big for the current NCM NTB 
then
  1046   * set the current stored skb to be sent now and clear 
it
  1047   * ready for new data.
  1048   * NOTE: Assume maximum align for speed of calculation.
  1049   */
  1050  if (ncm->skb_tx_data
  1051  && (ncm->ndp_dgram_count >= TX_MAX_NUM_DPE
  1052  || (ncm->skb_tx_data->len +
  1053  div + rem + skb->len +
  1054  ncm->skb_tx_ndp->len + ndp_align + (2 * 
dgram_idx_len))
  1055  > max_size)) {
  1056  skb2 = package_for_tx(ncm);
  1057  if (!skb2)
  1058  goto err;
  1059  }
  1060  
  1061  if (!ncm->skb_tx_data) {
  1062  ncb_len = opts->nth_size;
  1063  dgram_pad = ALIGN(ncb_len, div) + rem - ncb_len;
  1064  ncb_len += dgram_pad;
  1065  
  1066  /* Create a new skb for the NTH and datagrams. 
*/
  1067  ncm->skb_tx_data = alloc_skb(max_size, 
GFP_ATOMIC);
  1068  if (!ncm->skb_tx_data)
  1069  goto err;
  1070  
  1071  ncm->skb_tx_data->dev = ncm->netdev;
  1072  ntb_data = skb_put_zero(ncm->skb_tx_data, 
ncb_len);
  1073  /* dwSignature */
  1074  put_unaligned_le32(opts->nth_sign, ntb_data);
  1075  ntb_data += 2;
  1076  /* wHeaderLength */
  1077  put_unaligned_le16(opts->nth_size, ntb_data++);
  1078  
  1079  /* Allocate an skb for 

Re: [PATCH v8] xhci : AMD Promontory USB disable port support

[kbuild test robot]

Hi Joe,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v4.14]
[also build test WARNING on next-20171201]
[cannot apply to usb/usb-testing v4.15-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Joe-Lee/xhci-AMD-Promontory-USB-disable-port-support/20171202-122325


coccinelle warnings: (new ones prefixed by >>)

>> drivers/usb/host/pci-quirks.c:541:9-10: WARNING: return of 0/1 in function 
>> 'usb_amd_pt_check_port' with return type bool

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] xhci : fix boolreturn.cocci warnings

[kbuild test robot]

drivers/usb/host/pci-quirks.c:541:9-10: WARNING: return of 0/1 in function 
'usb_amd_pt_check_port' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 5462b4b541a4 ("xhci : AMD Promontory USB disable port support")
CC: Joe Lee 
Signed-off-by: Fengguang Wu 
---

 pci-quirks.c |   32 
 1 file changed, 16 insertions(+), 16 deletions(-)

--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -538,25 +538,25 @@ bool usb_amd_pt_check_port(struct device
 
pci_read_config_byte(pdev, PT_READ_INDX, );
if (value != PT_SIG_1_DATA)
-   return 0;
+   return false;
 
pci_write_config_word(pdev, PT_ADDR_INDX, PT_SIG_2_ADDR);
 
pci_read_config_byte(pdev, PT_READ_INDX, );
if (value != PT_SIG_2_DATA)
-   return 0;
+   return false;
 
pci_write_config_word(pdev, PT_ADDR_INDX, PT_SIG_3_ADDR);
 
pci_read_config_byte(pdev, PT_READ_INDX, );
if (value != PT_SIG_3_DATA)
-   return 0;
+   return false;
 
pci_write_config_word(pdev, PT_ADDR_INDX, PT_SIG_4_ADDR);
 
pci_read_config_byte(pdev, PT_READ_INDX, );
if (value != PT_SIG_4_DATA)
-   return 0;
+   return false;
 
if ((pdev->device == 0x43b9) || (pdev->device == 0x43ba)) {
/* device is AMD_PROMONTORYA_4(0x43b9) or
@@ -572,18 +572,18 @@ bool usb_amd_pt_check_port(struct device
 
pci_read_config_byte(pdev, PT_READ_INDX, );
if (value & (1<<(port - 7)))
-   return 0;
+   return false;
else
-   return 1;
+   return true;
} else {
pci_write_config_word(pdev, PT_ADDR_INDX,
PT4_P1_REG);
 
pci_read_config_byte(pdev, PT_READ_INDX, );
if (value & (1<<(port + 1)))
-   return 0;
+   return false;
else
-   return 1;
+   return true;
}
} else if (pdev->device == 0x43bb) {
/* device is AMD_PROMONTORYA_2(0x43bb)
@@ -597,17 +597,17 @@ bool usb_amd_pt_check_port(struct device
 
pci_read_config_byte(pdev, PT_READ_INDX, );
if (value & (1<<(port - 3)))
-   return 0;
+   return false;
else
-   return 1;
+   return true;
} else {
pci_write_config_word(pdev, PT_ADDR_INDX, PT2_P1_REG);
 
pci_read_config_byte(pdev, PT_READ_INDX, );
if (value & (1<<(port + 5)))
-   return 0;
+   return false;
else
-   return 1;
+   return true;
}
} else {
/* device is AMD_PROMONTORYA_1(0x43bc)
@@ -621,18 +621,18 @@ bool usb_amd_pt_check_port(struct device
 
pci_read_config_byte(pdev, PT_READ_INDX, );
if (value & (1<<(port - 4)))
-   return 0;
+   return false;
else
-   return 1;
+   return true;
 
} else {
pci_write_config_word(pdev, PT_ADDR_INDX, PT1_P1_REG);
 
pci_read_config_byte(pdev, PT_READ_INDX, );
if (value & (1<<(port + 4)))
-   return 0;
+   return false;
else
-   return 1;
+   return true;
 
}
}
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7] xhci : AMD Promontory USB disable port support

[kbuild test robot]

Hi Joe,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v4.14]
[also build test WARNING on next-20171122]
[cannot apply to usb/usb-testing]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Joe-Lee/xhci-AMD-Promontory-USB-disable-port-support/20171124-070642
config: i386-randconfig-x008-201747 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from drivers/usb/host/ehci-hcd.c:110:0:
   drivers/usb/host/pci-quirks.h: In function 'usb_amd_pt_check_port':
>> drivers/usb/host/pci-quirks.h:27:48: warning: no return statement in 
>> function returning non-void [-Wreturn-type]
static inline int usb_amd_pt_check_port(struct device *device, int port) {}
   ^~
   In file included from include/uapi/linux/stddef.h:2:0,
from include/linux/stddef.h:5,
from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/list.h:5,
from include/linux/module.h:9,
from drivers/usb/host/ehci-hcd.c:23:
   drivers/usb/host/ehci-hcd.c: At top level:
   include/linux/compiler.h:163:4: warning: '__f' is static but declared in 
inline function 'strcpy' which is not static
   __f = { \
   ^
   include/linux/compiler.h:155:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
  ^~
   include/linux/string.h:422:2: note: in expansion of macro 'if'
 if (p_size == (size_t)-1 && q_size == (size_t)-1)
 ^~
   include/linux/compiler.h:163:4: warning: '__f' is static but declared in 
inline function 'kmemdup' which is not static
   __f = { \
   ^
   include/linux/compiler.h:155:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
  ^~
   include/linux/string.h:412:2: note: in expansion of macro 'if'
 if (p_size < size)
 ^~
   include/linux/compiler.h:163:4: warning: '__f' is static but declared in 
inline function 'kmemdup' which is not static
   __f = { \
   ^
   include/linux/compiler.h:155:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
  ^~
   include/linux/string.h:410:2: note: in expansion of macro 'if'
 if (__builtin_constant_p(size) && p_size < size)
 ^~
   include/linux/compiler.h:163:4: warning: '__f' is static but declared in 
inline function 'memchr_inv' which is not static
   __f = { \
   ^
   include/linux/compiler.h:155:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
  ^~
   include/linux/string.h:401:2: note: in expansion of macro 'if'
 if (p_size < size)
 ^~
   include/linux/compiler.h:163:4: warning: '__f' is static but declared in 
inline function 'memchr_inv' which is not static
   __f = { \
   ^
   include/linux/compiler.h:155:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
  ^~
   include/linux/string.h:399:2: note: in expansion of macro 'if'
 if (__builtin_constant_p(size) && p_size < size)
 ^~
   include/linux/compiler.h:163:4: warning: '__f' is static but declared in 
inline function 'memchr' which is not static
   __f = { \
   ^
   include/linux/compiler.h:155:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
  ^~
   include/linux/string.h:390:2: note: in expansion of macro 'if'
 if (p_size < size)
 ^~
   include/linux/compiler.h:163:4: warning: '__f' is static but declared in 
inline function 'memchr' which is not static
   __f = { \
   ^
   include/linux/compiler.h:155:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
  ^~
   include/linux/string.h:388:2: note: in expansion of macro 'if'
 if (__builtin_constant_p(size) && p_size < size)
 ^~
   include/linux/compiler.h:163:4: warning: '__f' is static but declared in 
inline function 'memcmp' which is not static
   __f = { \
   ^
   include/linux/compiler.h:155:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
   

Re: [PATCH 1/1] usb: gadget: add USB Audio Device Class 3.0 gadget support

[kbuild test robot]

Hi Ruslan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on balbi-usb/next]
[also build test WARNING on v4.14-rc8 next-20171107]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Ruslan-Bilovol/usb-gadget-add-USB-Audio-Device-Class-3-0-gadget-support/20171107-175202
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next


coccinelle warnings: (new ones prefixed by >>)

>> drivers/usb/gadget/function/f_uac3.c:766:2-9: alloc with no test, possible 
>> model on line 780

vim +766 drivers/usb/gadget/function/f_uac3.c

   722  
   723  static int f_audio_bind(struct usb_configuration *cfg, struct 
usb_function *fn)
   724  {
   725  struct f_uac3 *uac3 = func_to_uac3(fn);
   726  struct g_audio *audio = func_to_g_audio(fn);
   727  struct usb_composite_dev *cdev = cfg->cdev;
   728  struct usb_gadget *gadget = cdev->gadget;
   729  struct device *dev = >dev;
   730  struct f_uac3_opts *uac3_opts;
   731  struct uac3_hc_descriptor_header *cluster_desc;
   732  struct uac3_hc_desc *hc_desc;
   733  struct usb_string *us;
   734  u16 hc_desc_id = 1; /* HC id always starts from 1 */
   735  int ret;
   736  
   737  uac3_opts = container_of(fn->fi, struct f_uac3_opts, func_inst);
   738  
   739  us = usb_gstrings_attach(cdev, fn_strings, 
ARRAY_SIZE(strings_fn));
   740  if (IS_ERR(us))
   741  return PTR_ERR(us);
   742  
   743  iad_desc.iFunction = us[STR_ASSOC].id;
   744  std_ac_if_desc.iInterface = us[STR_IF_CTRL].id;
   745  std_as_out_if0_desc.iInterface = us[STR_AS_OUT_ALT0].id;
   746  std_as_out_if1_desc.iInterface = us[STR_AS_OUT_ALT1].id;
   747  std_as_in_if0_desc.iInterface = us[STR_AS_IN_ALT0].id;
   748  std_as_in_if1_desc.iInterface = us[STR_AS_IN_ALT1].id;
   749  
   750  INIT_LIST_HEAD(>hc_desc_list);
   751  
   752  /* Initialize the configurable parameters */
   753  cluster_desc = build_cluster_descriptor(uac3_opts, 0); /* 
capture */
   754  if (cluster_desc) {
   755  hc_desc = kzalloc(sizeof *hc_desc, GFP_KERNEL);
   756  hc_desc->hc_header = cluster_desc;
   757  list_add(_desc->list, >hc_desc_list);
   758  cluster_desc->wDescriptorID = cpu_to_le16(hc_desc_id);
   759  usb_out_it_desc.wClusterDescrID = 
cluster_desc->wDescriptorID;
   760  as_out_hdr_desc.wClusterDescrID = 
cluster_desc->wDescriptorID;
   761  hc_desc_id++;
   762  }
   763  
   764  cluster_desc = build_cluster_descriptor(uac3_opts, 1); /* 
playback */
   765  if (cluster_desc) {
 > 766  hc_desc = kzalloc(sizeof *hc_desc, GFP_KERNEL);
   767  hc_desc->hc_header = cluster_desc;
   768  list_add(_desc->list, >hc_desc_list);
   769  cluster_desc->wDescriptorID = cpu_to_le16(hc_desc_id);
   770  io_in_it_desc.wClusterDescrID = 
cluster_desc->wDescriptorID;
   771  as_in_hdr_desc.wClusterDescrID = 
cluster_desc->wDescriptorID;
   772  }
   773  
   774  as_out_hdr_desc.bSubslotSize = uac3_opts->c_ssize;
   775  as_out_hdr_desc.bBitResolution = uac3_opts->c_ssize * 8;
   776  as_in_hdr_desc.bSubslotSize = uac3_opts->p_ssize;
   777  as_in_hdr_desc.bBitResolution = uac3_opts->p_ssize * 8;
   778  
   779  /* alloc and configure Feature Unit descriptors */
 > 780  usb_out_fu_desc = 
 > alloc_fu_desc(num_channels(uac3_opts->c_chmask),
   781  USB_OUT_FU_ID,
   782  USB_OUT_IT_ID);
   783  if (!usb_out_fu_desc) {
   784  dev_err(dev, "%s: can't allocate OUT FU descriptor on 
%s\n",
   785   fn->name, gadget->name);
   786  ret = -ENOMEM;
   787  goto err_free_hc_desc;
   788  }
   789  
   790  usb_in_fu_desc = 
alloc_fu_desc(num_channels(uac3_opts->p_chmask),
   791  USB_IN_FU_ID,
   792  IO_IN_IT_ID);
   793  if (!usb_in_fu_desc) {
   794  dev_err(dev, "%s: can't allocate IN FU descriptor on 
%s\n",
   795   fn->name, gadget->name);
   796  ret = -ENOMEM;
   797  goto err_free_out_fu_desc;
   798  }
   799  
   800  /* update AC desc size with allocated FUs */
   801  ac_hdr_desc.wTotalLength = cpu_to_le16(
   802sizeof in_clk_src_desc + sizeof 
out_clk_src_desc
   803

Re: [PATCH 1/1] usb: gadget: add USB Audio Device Class 3.0 gadget support

[kbuild test robot]

Hi Ruslan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.14-rc8 next-20171107]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Ruslan-Bilovol/usb-gadget-add-USB-Audio-Device-Class-3-0-gadget-support/20171107-175202
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

>> drivers/usb/gadget/function/f_uac3.c:10:32: fatal error: 
>> linux/usb/audio-v3.h: No such file or directory
#include 
   ^
   compilation terminated.

vim +10 drivers/usb/gadget/function/f_uac3.c

  > 10  #include 
11  #include 
12  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

Re: [PATCH] drivers/hid: Convert timers to use timer_setup()

[kbuild test robot]

Hi Allen,

[auto build test ERROR on v4.14-rc6]
[cannot apply to hid/for-next next-20171018]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Allen-Pais/drivers-hid-Convert-timers-to-use-timer_setup/20171025-230118
config: i386-randconfig-x008-201743 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/ioport.h:12:0,
from include/linux/device.h:16,
from drivers//hid/hid-multitouch.c:41:
   drivers//hid/hid-multitouch.c: In function 'mt_expired_timeout':
>> include/linux/kernel.h:928:51: error: 'struct hid_device' has no member 
>> named 'release_timer'
 BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
  ^
   include/linux/compiler.h:553:19: note: in definition of macro 
'__compiletime_assert'
  bool __cond = !(condition);\
  ^
   include/linux/compiler.h:576:2: note: in expansion of macro 
'_compiletime_assert'
 _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
 ^~~
   include/linux/build_bug.h:46:37: note: in expansion of macro 
'compiletime_assert'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^~
   include/linux/kernel.h:928:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
 BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
 ^~~~
   include/linux/kernel.h:928:20: note: in expansion of macro '__same_type'
 BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
   ^~~
   include/linux/timer.h:183:2: note: in expansion of macro 'container_of'
 container_of(callback_timer, typeof(*var), timer_fieldname)
 ^~~~
>> drivers//hid/hid-multitouch.c:1251:28: note: in expansion of macro 
>> 'from_timer'
 struct hid_device *hdev = from_timer(hdev, t, release_timer);
   ^~
   In file included from include/linux/compiler.h:58:0,
from include/linux/ioport.h:12,
from include/linux/device.h:16,
from drivers//hid/hid-multitouch.c:41:
>> include/linux/compiler-gcc.h:165:2: error: 'struct hid_device' has no member 
>> named 'release_timer'
 __builtin_offsetof(a, b)
 ^
   include/linux/stddef.h:16:32: note: in expansion of macro 
'__compiler_offsetof'
#define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER)
   ^~~
   include/linux/kernel.h:931:21: note: in expansion of macro 'offsetof'
 ((type *)(__mptr - offsetof(type, member))); })
^~~~
   include/linux/timer.h:183:2: note: in expansion of macro 'container_of'
 container_of(callback_timer, typeof(*var), timer_fieldname)
 ^~~~
>> drivers//hid/hid-multitouch.c:1251:28: note: in expansion of macro 
>> 'from_timer'
 struct hid_device *hdev = from_timer(hdev, t, release_timer);
   ^~
--
   In file included from include/linux/ioport.h:12:0,
from include/linux/device.h:16,
from drivers/hid/hid-multitouch.c:41:
   drivers/hid/hid-multitouch.c: In function 'mt_expired_timeout':
>> include/linux/kernel.h:928:51: error: 'struct hid_device' has no member 
>> named 'release_timer'
 BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
  ^
   include/linux/compiler.h:553:19: note: in definition of macro 
'__compiletime_assert'
  bool __cond = !(condition);\
  ^
   include/linux/compiler.h:576:2: note: in expansion of macro 
'_compiletime_assert'
 _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
 ^~~
   include/linux/build_bug.h:46:37: note: in expansion of macro 
'compiletime_assert'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^~
   include/linux/kernel.h:928:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
 BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
 ^~~~
   include/linux/kernel.h:928:20: note: in expansion of macro '__same_type'
 BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
   ^~~
   include/linux/timer.h:183:2: note: in expansion of macro 'container_of'
 container_of(callback_timer, typeof(*var), timer_fieldname)
 ^~~~
   drivers/hid/hid-multitouch.c:1251:28: note: in expansion of macro 
'from_timer'
 struct 

Re: [PATCH] drivers/hid: Convert timers to use timer_setup()

[kbuild test robot]

Hi Allen,

[auto build test ERROR on v4.14-rc6]
[cannot apply to hid/for-next next-20171018]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Allen-Pais/drivers-hid-Convert-timers-to-use-timer_setup/20171025-230118
config: x86_64-randconfig-x011-201743 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/ioport.h:12:0,
from include/linux/device.h:16,
from drivers/hid/hid-appleir.c:26:
   drivers/hid/hid-appleir.c: In function 'key_up_tick':
>> drivers/hid/hid-appleir.c:178:39: error: 'applier' undeclared (first use in 
>> this function)
 struct appleir *appleir = from_timer(applier, t, key_up_timer);
  ^
   include/linux/compiler.h:553:19: note: in definition of macro 
'__compiletime_assert'
  bool __cond = !(condition);\
  ^
   include/linux/compiler.h:576:2: note: in expansion of macro 
'_compiletime_assert'
 _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
 ^~~
   include/linux/build_bug.h:46:37: note: in expansion of macro 
'compiletime_assert'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^~
   include/linux/kernel.h:928:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
 BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
 ^~~~
   include/linux/kernel.h:928:20: note: in expansion of macro '__same_type'
 BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
   ^~~
   include/linux/timer.h:183:2: note: in expansion of macro 'container_of'
 container_of(callback_timer, typeof(*var), timer_fieldname)
 ^~~~
>> drivers/hid/hid-appleir.c:178:28: note: in expansion of macro 'from_timer'
 struct appleir *appleir = from_timer(applier, t, key_up_timer);
   ^~
   drivers/hid/hid-appleir.c:178:39: note: each undeclared identifier is 
reported only once for each function it appears in
 struct appleir *appleir = from_timer(applier, t, key_up_timer);
  ^
   include/linux/compiler.h:553:19: note: in definition of macro 
'__compiletime_assert'
  bool __cond = !(condition);\
  ^
   include/linux/compiler.h:576:2: note: in expansion of macro 
'_compiletime_assert'
 _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
 ^~~
   include/linux/build_bug.h:46:37: note: in expansion of macro 
'compiletime_assert'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^~
   include/linux/kernel.h:928:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
 BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
 ^~~~
   include/linux/kernel.h:928:20: note: in expansion of macro '__same_type'
 BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
   ^~~
   include/linux/timer.h:183:2: note: in expansion of macro 'container_of'
 container_of(callback_timer, typeof(*var), timer_fieldname)
 ^~~~
>> drivers/hid/hid-appleir.c:178:28: note: in expansion of macro 'from_timer'
 struct appleir *appleir = from_timer(applier, t, key_up_timer);
   ^~

vim +/applier +178 drivers/hid/hid-appleir.c

  > 26  #include 
27  #include 
28  #include 
29  #include "hid-ids.h"
30  
31  MODULE_AUTHOR("James McKenzie");
32  MODULE_AUTHOR("Benjamin Tissoires ");
33  MODULE_DESCRIPTION("HID Apple IR remote controls");
34  MODULE_LICENSE("GPL");
35  
36  #define KEY_MASK0x0F
37  #define TWO_PACKETS_MASK0x40
38  
39  /*
40   * James McKenzie has two devices both of which report the following
41   * 25 87 ee 83 0a   +
42   * 25 87 ee 83 0c   -
43   * 25 87 ee 83 09   <<
44   * 25 87 ee 83 06   >>
45   * 25 87 ee 83 05   >"
46   * 25 87 ee 83 03   menu
47   * 26 00 00 00 00   for key repeat
48   */
49  
50  /*
51   * Thomas Glanzmann reports the following responses
52   * 25 87 ee ca 0b   +
53   * 25 87 ee ca 0d   -
54   * 25 87 ee ca 08   <<
55   * 25 87 ee ca 07   >>
56   * 25 87 ee ca 04   >"
57   * 25 87 ee ca 02   menu
58   * 26 00 00 00 00   for key repeat
59   *
60   * He also observes the following event sometimes
61   * sent after a 

[PATCH] usb: xhci-mtk: fix ptr_ret.cocci warnings

[kbuild test robot]

drivers/usb/host/xhci-mtk.c:256:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: b6bb72cf0df1 ("usb: xhci-mtk: add optional mcu and dma bus clocks")
CC: Chunfeng Yun 
Signed-off-by: Fengguang Wu 
---

 xhci-mtk.c |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -253,10 +253,7 @@ static int xhci_mtk_clks_get(struct xhci
return PTR_ERR(mtk->mcu_clk);
 
mtk->dma_clk = optional_clk_get(dev, "dma_ck");
-   if (IS_ERR(mtk->dma_clk))
-   return PTR_ERR(mtk->dma_clk);
-
-   return 0;
+   return PTR_ERR_OR_ZERO(mtk->dma_clk);
 }
 
 static int xhci_mtk_clks_enable(struct xhci_hcd_mtk *mtk)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[usb:usb-testing 54/61] drivers/usb/host/xhci-mtk.c:256:1-3: WARNING: PTR_ERR_OR_ZERO can be used

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
head:   2d5afd51fe6b469e09d8d63fff041cbf4a987278
commit: b6bb72cf0df128397312b6239d6c5f5702dfc6fc [54/61] usb: xhci-mtk: add 
optional mcu and dma bus clocks


coccinelle warnings: (new ones prefixed by >>)

>> drivers/usb/host/xhci-mtk.c:256:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[balbi-usb:testing/next 45/52] drivers/usb/gadget/function/f_ncm.c:1109:10: error: 'HRTIMER_MODE_REL_SOFT' undeclared

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git 
testing/next
head:   f463883ae099b7e98e8ea0a6b9c8dbd05217d94a
commit: 4e4a058b2f048b009b7826e6404ec5133563417e [45/52] usb/gadget/NCM: 
Replace tasklet with softirq hrtimer
config: x86_64-randconfig-x014-201743 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
git checkout 4e4a058b2f048b009b7826e6404ec5133563417e
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/usb/gadget/function/f_ncm.c: In function 'ncm_wrap_ntb':
>> drivers/usb/gadget/function/f_ncm.c:1109:10: error: 'HRTIMER_MODE_REL_SOFT' 
>> undeclared (first use in this function)
 HRTIMER_MODE_REL_SOFT);
 ^
   drivers/usb/gadget/function/f_ncm.c:1109:10: note: each undeclared 
identifier is reported only once for each function it appears in
   drivers/usb/gadget/function/f_ncm.c: In function 'ncm_bind':
   drivers/usb/gadget/function/f_ncm.c:1506:50: error: 'HRTIMER_MODE_REL_SOFT' 
undeclared (first use in this function)
 hrtimer_init(>task_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_SOFT);
 ^

vim +/HRTIMER_MODE_REL_SOFT +1109 drivers/usb/gadget/function/f_ncm.c

  1015  
  1016  static struct sk_buff *ncm_wrap_ntb(struct gether *port,
  1017  struct sk_buff *skb)
  1018  {
  1019  struct f_ncm*ncm = func_to_ncm(>func);
  1020  struct sk_buff  *skb2 = NULL;
  1021  int ncb_len = 0;
  1022  __le16  *ntb_data;
  1023  __le16  *ntb_ndp;
  1024  int dgram_pad;
  1025  
  1026  unsignedmax_size = ncm->port.fixed_in_len;
  1027  const struct ndp_parser_opts *opts = ncm->parser_opts;
  1028  const int ndp_align = 
le16_to_cpu(ntb_parameters.wNdpInAlignment);
  1029  const int div = le16_to_cpu(ntb_parameters.wNdpInDivisor);
  1030  const int rem = 
le16_to_cpu(ntb_parameters.wNdpInPayloadRemainder);
  1031  const int dgram_idx_len = 2 * 2 * opts->dgram_item_len;
  1032  
  1033  if (!skb && !ncm->skb_tx_data)
  1034  return NULL;
  1035  
  1036  if (skb) {
  1037  /* Add the CRC if required up front */
  1038  if (ncm->is_crc) {
  1039  uint32_tcrc;
  1040  __le16  *crc_pos;
  1041  
  1042  crc = ~crc32_le(~0,
  1043  skb->data,
  1044  skb->len);
  1045  crc_pos = skb_put(skb, sizeof(uint32_t));
  1046  put_unaligned_le32(crc, crc_pos);
  1047  }
  1048  
  1049  /* If the new skb is too big for the current NCM NTB 
then
  1050   * set the current stored skb to be sent now and clear 
it
  1051   * ready for new data.
  1052   * NOTE: Assume maximum align for speed of calculation.
  1053   */
  1054  if (ncm->skb_tx_data
  1055  && (ncm->ndp_dgram_count >= TX_MAX_NUM_DPE
  1056  || (ncm->skb_tx_data->len +
  1057  div + rem + skb->len +
  1058  ncm->skb_tx_ndp->len + ndp_align + (2 * 
dgram_idx_len))
  1059  > max_size)) {
  1060  skb2 = package_for_tx(ncm);
  1061  if (!skb2)
  1062  goto err;
  1063  }
  1064  
  1065  if (!ncm->skb_tx_data) {
  1066  ncb_len = opts->nth_size;
  1067  dgram_pad = ALIGN(ncb_len, div) + rem - ncb_len;
  1068  ncb_len += dgram_pad;
  1069  
  1070  /* Create a new skb for the NTH and datagrams. 
*/
  1071  ncm->skb_tx_data = alloc_skb(max_size, 
GFP_ATOMIC);
  1072  if (!ncm->skb_tx_data)
  1073  goto err;
  1074  
  1075  ncm->skb_tx_data->dev = ncm->netdev;
  1076  ntb_data = skb_put_zero(ncm->skb_tx_data, 
ncb_len);
  1077  /* dwSignature */
  1078  put_unaligned_le32(opts->nth_sign, ntb_data);
  1079  ntb_data += 2;
  1080  /* wHeaderLength */
  1081  put_unaligned_le16(opts->nth_size, ntb_data++);
  1082  
  1083  /* Allocate an skb for storing the NDP,
  1084   * TX_MAX_NUM_DPE should easily suffice for a
  1085   * 16k packet.

[balbi-usb:testing/next 46/52] drivers/usb/phy/phy-tahvo.c:433:9: warning: 'ret' may be used uninitialized in this function

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git 
testing/next
head:   f463883ae099b7e98e8ea0a6b9c8dbd05217d94a
commit: 649e479cc765d18030b885796e8ee160b7247d40 [46/52] usb: phy: tahvo: fix 
error handling in tahvo_usb_probe()
config: x86_64-randconfig-x018-201743 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
git checkout 649e479cc765d18030b885796e8ee160b7247d40
# save the attached .config to linux build tree
make ARCH=x86_64 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   Cyclomatic Complexity 1 include/linux/string.h:strnlen
   Cyclomatic Complexity 2 include/linux/string.h:strlen
   Cyclomatic Complexity 1 include/linux/device.h:dev_get_drvdata
   Cyclomatic Complexity 1 include/linux/device.h:dev_set_drvdata
   Cyclomatic Complexity 1 include/linux/platform_device.h:platform_get_drvdata
   Cyclomatic Complexity 1 drivers/usb/phy/phy-tahvo.c:tahvo_usb_stop_host
   Cyclomatic Complexity 2 drivers/usb/phy/phy-tahvo.c:tahvo_usb_stop_peripheral
   Cyclomatic Complexity 2 drivers/usb/phy/phy-tahvo.c:tahvo_usb_power_off
   Cyclomatic Complexity 9 drivers/usb/phy/phy-tahvo.c:check_vbus_state
   Cyclomatic Complexity 1 drivers/usb/phy/phy-tahvo.c:tahvo_usb_become_host
   Cyclomatic Complexity 1 
drivers/usb/phy/phy-tahvo.c:tahvo_usb_become_peripheral
   Cyclomatic Complexity 9 drivers/usb/phy/phy-tahvo.c:otg_mode_store
   Cyclomatic Complexity 1 drivers/usb/phy/phy-tahvo.c:tahvo_usb_vbus_interrupt
   Cyclomatic Complexity 3 drivers/usb/phy/phy-tahvo.c:otg_mode_show
   Cyclomatic Complexity 2 drivers/usb/phy/phy-tahvo.c:vbus_state_show
   Cyclomatic Complexity 1 include/linux/err.h:IS_ERR
   Cyclomatic Complexity 2 drivers/usb/phy/phy-tahvo.c:tahvo_usb_remove
   Cyclomatic Complexity 5 drivers/usb/phy/phy-tahvo.c:tahvo_usb_set_peripheral
   Cyclomatic Complexity 5 drivers/usb/phy/phy-tahvo.c:tahvo_usb_set_host
   Cyclomatic Complexity 3 drivers/usb/phy/phy-tahvo.c:tahvo_usb_set_suspend
   Cyclomatic Complexity 1 include/linux/device.h:devm_kzalloc
   Cyclomatic Complexity 10 drivers/usb/phy/phy-tahvo.c:tahvo_usb_probe
   Cyclomatic Complexity 1 drivers/usb/phy/phy-tahvo.c:tahvo_usb_driver_init
   Cyclomatic Complexity 1 drivers/usb/phy/phy-tahvo.c:tahvo_usb_driver_exit
   drivers/usb/phy/phy-tahvo.c: In function 'tahvo_usb_probe':
>> drivers/usb/phy/phy-tahvo.c:433:9: warning: 'ret' may be used uninitialized 
>> in this function [-Wmaybe-uninitialized]
 return ret;
^~~

vim +/ret +433 drivers/usb/phy/phy-tahvo.c

9ba96ae5 Aaro Koskinen  2013-12-06  356  
9ba96ae5 Aaro Koskinen  2013-12-06  357 mutex_init(>serialize);
9ba96ae5 Aaro Koskinen  2013-12-06  358  
9ba96ae5 Aaro Koskinen  2013-12-06  359 tu->ick = 
devm_clk_get(>dev, "usb_l4_ick");
9ba96ae5 Aaro Koskinen  2013-12-06  360 if (!IS_ERR(tu->ick))
9ba96ae5 Aaro Koskinen  2013-12-06  361 clk_enable(tu->ick);
9ba96ae5 Aaro Koskinen  2013-12-06  362  
9ba96ae5 Aaro Koskinen  2013-12-06  363 /*
9ba96ae5 Aaro Koskinen  2013-12-06  364  * Set initial state, so that 
we generate kevents only on state changes.
9ba96ae5 Aaro Koskinen  2013-12-06  365  */
9ba96ae5 Aaro Koskinen  2013-12-06  366 tu->vbus_state = 
retu_read(rdev, TAHVO_REG_IDSR) & TAHVO_STAT_VBUS;
9ba96ae5 Aaro Koskinen  2013-12-06  367  
860d2686 Chanwoo Choi   2015-07-01  368 tu->extcon = 
devm_extcon_dev_allocate(>dev, tahvo_cable);
860d2686 Chanwoo Choi   2015-07-01  369 if (IS_ERR(tu->extcon)) {
860d2686 Chanwoo Choi   2015-07-01  370 dev_err(>dev, 
"failed to allocate memory for extcon\n");
649e479c Alexey Khoroshilov 2017-10-21  371 goto err_disable_clk;
860d2686 Chanwoo Choi   2015-07-01  372 }
9ba96ae5 Aaro Koskinen  2013-12-06  373  
860d2686 Chanwoo Choi   2015-07-01  374 ret = 
devm_extcon_dev_register(>dev, tu->extcon);
9ba96ae5 Aaro Koskinen  2013-12-06  375 if (ret) {
9ba96ae5 Aaro Koskinen  2013-12-06  376 dev_err(>dev, 
"could not register extcon device: %d\n",
9ba96ae5 Aaro Koskinen  2013-12-06  377 ret);
9ba96ae5 Aaro Koskinen  2013-12-06  378 goto err_disable_clk;
9ba96ae5 Aaro Koskinen  2013-12-06  379 }
9ba96ae5 Aaro Koskinen  2013-12-06  380  
9ba96ae5 Aaro Koskinen  2013-12-06  381 /* Set the initial cable state. 
*/
746c9085 Chanwoo Choi   2017-01-16  382 
extcon_set_state_sync(tu->extcon, EXTCON_USB_HOST,
9ba96ae5 Aaro Koskinen  2013-12-06  383
tu->tahvo_mode == TAHVO_MODE_HOST);
746c9085 Chanwoo Choi   2017-01-16  384 
extcon_set_state_sync(tu->extcon, EXTCON_USB, tu->vbus_state);
9ba96ae5 Aaro Koskinen  2013-12-06  385  
9ba96ae5 Aaro Koskinen  2013-12-06  386 

Re: [PATCH] usb: "USB Host halt failed, -110" error when rebooting system

[kbuild test robot]

Hi Wen,

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.14-rc5 next-20171018]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/wenxiong-linux-vnet-ibm-com/usb-USB-Host-halt-failed-110-error-when-rebooting-system/20171020-195950
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: i386-randconfig-n0-201742 (attached as .config)
compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

>> ERROR: "usb_disconnect" [drivers/usb/host/xhci-hcd.ko] undefined!

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip

[balbi-usb:testing/next 31/41] drivers/usb/mtu3/mtu3_qmu.c:261:25: warning: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}'

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git 
testing/next
head:   f2fedb17e8946a24c9cf2bd20ee466fb8659196a
commit: 46ed5b0c1fac208e727c8cea6c2db44a77fc256a [31/41] usb: mtu3: support 
36-bit DMA address
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 46ed5b0c1fac208e727c8cea6c2db44a77fc256a
# save the attached .config to linux build tree
make.cross ARCH=mips 

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:329:0,
from include/linux/kernel.h:13,
from include/asm-generic/bug.h:15,
from arch/mips/include/asm/bug.h:41,
from include/linux/bug.h:4,
from include/linux/scatterlist.h:6,
from include/linux/dmapool.h:14,
from drivers/usb/mtu3/mtu3_qmu.c:30:
   drivers/usb/mtu3/mtu3_qmu.c: In function 'mtu3_prepare_tx_gpd':
>> drivers/usb/mtu3/mtu3_qmu.c:261:25: warning: format '%p' expects argument of 
>> type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}' 
>> [-Wformat=]
 dev_dbg(mep->mtu->dev, "TX-EP%d queue gpd=%p, enq=%p, qdma=%pad\n",
^
   include/linux/dynamic_debug.h:134:39: note: in definition of macro 
'dynamic_dev_dbg'
  __dynamic_dev_dbg(, dev, fmt, \
  ^~~
   drivers/usb/mtu3/mtu3_qmu.c:261:2: note: in expansion of macro 'dev_dbg'
 dev_dbg(mep->mtu->dev, "TX-EP%d queue gpd=%p, enq=%p, qdma=%pad\n",
 ^~~
   drivers/usb/mtu3/mtu3_qmu.c: In function 'mtu3_prepare_rx_gpd':
   drivers/usb/mtu3/mtu3_qmu.c:300:25: warning: format '%p' expects argument of 
type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}' 
[-Wformat=]
 dev_dbg(mep->mtu->dev, "RX-EP%d queue gpd=%p, enq=%p, qdma=%pad\n",
^
   include/linux/dynamic_debug.h:134:39: note: in definition of macro 
'dynamic_dev_dbg'
  __dynamic_dev_dbg(, dev, fmt, \
  ^~~
   drivers/usb/mtu3/mtu3_qmu.c:300:2: note: in expansion of macro 'dev_dbg'
 dev_dbg(mep->mtu->dev, "RX-EP%d queue gpd=%p, enq=%p, qdma=%pad\n",
 ^~~

vim +261 drivers/usb/mtu3/mtu3_qmu.c

   240  
   241  static int mtu3_prepare_tx_gpd(struct mtu3_ep *mep, struct mtu3_request 
*mreq)
   242  {
   243  struct qmu_gpd *enq;
   244  struct mtu3_gpd_ring *ring = >gpd_ring;
   245  struct qmu_gpd *gpd = ring->enqueue;
   246  struct usb_request *req = >request;
   247  dma_addr_t enq_dma;
   248  u16 ext_addr;
   249  
   250  /* set all fields to zero as default value */
   251  memset(gpd, 0, sizeof(*gpd));
   252  
   253  gpd->buffer = cpu_to_le32(lower_32_bits(req->dma));
   254  ext_addr = GPD_EXT_BUF(upper_32_bits(req->dma));
   255  gpd->buf_len = cpu_to_le16(req->length);
   256  gpd->flag |= GPD_FLAGS_IOC;
   257  
   258  /* get the next GPD */
   259  enq = advance_enq_gpd(ring);
   260  enq_dma = gpd_virt_to_dma(ring, enq);
 > 261  dev_dbg(mep->mtu->dev, "TX-EP%d queue gpd=%p, enq=%p, 
 > qdma=%pad\n",
   262  mep->epnum, gpd, enq, enq_dma);
   263  
   264  enq->flag &= ~GPD_FLAGS_HWO;
   265  gpd->next_gpd = cpu_to_le32(lower_32_bits(enq_dma));
   266  ext_addr |= GPD_EXT_NGP(upper_32_bits(enq_dma));
   267  gpd->tx_ext_addr = cpu_to_le16(ext_addr);
   268  
   269  if (req->zero)
   270  gpd->ext_flag |= GPD_EXT_FLAG_ZLP;
   271  
   272  gpd->chksum = qmu_calc_checksum((u8 *)gpd);
   273  gpd->flag |= GPD_FLAGS_HWO;
   274  
   275  mreq->gpd = gpd;
   276  
   277  return 0;
   278  }
   279  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip