[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
joker-eph wrote: > It's a sed s/== None/is None/g - what is there to review? On my I'm not asking for more reviews, this is why I commented that this should be **pushed** in multiple commits, I don't even need to see PRs. Another thing also mentioned above was the problem of reverts. If there is a problem in one of the project and this needs to be reverted, then it'll affect the other projects. Also imagine that this lands, then someone refactor the python code in MLIR, and then LLDB finds an issue and tries to revert. They have now to figure out why is there a merge conflicts. More commits in the history for unrelated projects does not seem like "noise" to me. When I apply automated linter (clang-tidy), I will split these into 1 commit per file and push these. https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
JDevlieghere wrote: > It's a `sed s/== None/is None/g` - what is there to review? 10 separate > commits/PRs for the same exact `sed` costs more in commit noise (and effort > on the part of @e-kwsm) than one solid, patient, review here. In addition to what @ftynse said above, the `sed` might not be the right thing in the first place (e.g. #91858). https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
ftynse wrote: > 10 separate commits/PRs for the same exact sed costs more in commit noise > (and effort on the part of @e-kwsm) than one solid, patient, review here Not unless you subscribe only to a subproject. FWIW, I'm not comfortable blanket approving changes, however trivial, to subprojects I'm not actively working on, and I suspect most folks here are not. Subprojects may have some ongoing work that will be disrupted or reasons why they chose the suboptimal implementation. https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
https://github.com/makslevental approved this pull request. There you go - diligently reviewed using GitHub 's fantastic UI.  https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
makslevental wrote: It's a `sed s/== None/is None/g` - what is there to review? 10 separate PRs for the same exact `sed` costs more in commit noise (and effort on the part of @e-kwsm) than one solid, patient, review here. https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
https://github.com/joker-eph approved this pull request. If you can push this to main in separate commits (one per project as it was mentioned?), that'd be great! https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
https://github.com/JDevlieghere commented: This should really be broken up into separate PRs per subproject. One large PR like this makes reviewing harder and causes unnecessary churn in the case that this gets reverted. https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
https://github.com/ChuanqiXu9 approved this pull request. https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
https://github.com/teresajohnson approved this pull request. compiler-rt changes lgtm https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
https://github.com/DavidSpickett approved this pull request. LLDB changes look good to me. https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
DavidSpickett wrote: LLVM uses a GitHub setting where the PR is squashed, and the commit message is taken from the PR description rather than the commits themselves. So all you have to do here is copy the commit message you updated into the PR's description. https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
https://github.com/mtrofin approved this pull request. LGTM for the `ctx_profile` part. https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
https://github.com/ftynse approved this pull request. LGTM for the MLIR part. Please seek approval from relevant reviewers for all other subprojects. https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
e-kwsm wrote: Commit message is updated/ https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
https://github.com/e-kwsm updated https://github.com/llvm/llvm-project/pull/91857 >From 7cec823d9a87b90bf8d9ae5c975f4492076e0abb Mon Sep 17 00:00:00 2001 From: Eisuke Kawashima Date: Sat, 11 May 2024 23:57:11 +0900 Subject: [PATCH] fix(python): fix comparison to None from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or is not, > never the equality operators. --- .../clang-tidy/checks/gen-static-analyzer-docs.py| 2 +- clang/docs/DebuggingCoroutines.rst | 8 clang/tools/include-mapping/gen_std.py | 2 +- clang/utils/check_cfc/obj_diff.py| 2 +- clang/utils/module-deps-to-rsp.py| 2 +- compiler-rt/test/asan/lit.cfg.py | 2 +- compiler-rt/test/builtins/Unit/lit.cfg.py| 2 +- compiler-rt/test/ctx_profile/lit.cfg.py | 2 +- compiler-rt/test/lsan/lit.common.cfg.py | 2 +- compiler-rt/test/memprof/lit.cfg.py | 2 +- compiler-rt/test/profile/lit.cfg.py | 2 +- .../android_commands/android_compile.py | 2 +- .../sanitizer_common/ios_commands/iossim_compile.py | 2 +- compiler-rt/test/ubsan/lit.common.cfg.py | 2 +- compiler-rt/test/ubsan_minimal/lit.common.cfg.py | 2 +- .../dexter/dex/command/ParseCommand.py | 2 +- .../DebuggerControllers/ConditionalController.py | 4 ++-- .../DebuggerControllers/ControllerHelpers.py | 2 +- .../debuginfo-tests/dexter/dex/debugger/Debuggers.py | 2 +- .../dexter/dex/debugger/visualstudio/VisualStudio.py | 2 +- .../debuginfo-tests/dexter/dex/tools/test/Tool.py| 2 +- cross-project-tests/lit.cfg.py | 2 +- lldb/docs/use/python.rst | 4 ++-- .../python/armv7_cortex_m_target_defintion.py| 2 +- lldb/packages/Python/lldbsuite/test/dotest.py| 2 +- lldb/packages/Python/lldbsuite/test/lldbtest.py | 6 +++--- lldb/packages/Python/lldbsuite/test/lldbutil.py | 6 +++--- .../lldbsuite/test/tools/intelpt/intelpt_testcase.py | 2 +- .../address_breakpoints/TestBadAddressBreakpoints.py | 2 +- .../step_scripted/TestStepScripted.py| 2 +- .../TestStopOnSharedlibraryEvents.py | 2 +- lldb/test/API/lua_api/TestLuaAPI.py | 2 +- .../thread_suspend/TestInternalThreadSuspension.py | 2 +- lldb/test/API/python_api/event/TestEvents.py | 2 +- .../process/read-mem-cstring/TestReadMemCString.py | 2 +- lldb/test/API/python_api/type/TestTypeList.py| 2 +- .../API/python_api/was_interrupted/interruptible.py | 2 +- lldb/test/Shell/lit.cfg.py | 2 +- llvm/utils/indirect_calls.py | 2 +- llvm/utils/lit/lit/TestRunner.py | 2 +- llvm/utils/lit/lit/util.py | 2 +- llvm/utils/schedcover.py | 2 +- llvm/utils/shuffle_select_fuzz_tester.py | 12 ++-- mlir/test/python/ir/affine_expr.py | 2 +- mlir/test/python/ir/attributes.py| 8 mlir/test/python/ir/builtin_types.py | 8 openmp/libompd/gdb-plugin/ompd/ompd_callbacks.py | 2 +- polly/lib/External/isl/libisl-gdb.py | 4 ++-- polly/lib/External/isl/python/isl.py.top | 4 ++-- polly/utils/pyscop/isl.py| 8 50 files changed, 75 insertions(+), 75 deletions(-) diff --git a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py index 6545a3906fa50..53ecb60dec539 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py +++ b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py @@ -47,7 +47,7 @@ def get_checkers(checkers_td, checkers_rst): parent_package_ = package["ParentPackage"] hidden = (checker["Hidden"] != 0) or (package["Hidden"] != 0) -while parent_package_ != None: +while parent_package_ is not None: parent_package = table_entries[parent_package_["def"]] checker_package_prefix = ( parent_package["PackageName"] + "." + checker_package_prefix diff --git a/clang/docs/DebuggingCoroutines.rst b/clang/docs/DebuggingCoroutines.rst index 53bdd08fdbc02..7f464c1f4f28c 100644 --- a/clang/docs/DebuggingCoroutines.rst +++ b/clang/docs/DebuggingCoroutines.rst @@ -513,7 +513,7 @@ So we can use the ``continuation`` field to construct the asynchronous stack: self.coro_frame = coro_frame self.resume_func = dereference(self.coro_frame.resume_addr) self.resume_func_block = gdb.block_for_pc(self.resume_func) - if
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
ftynse wrote: This should be included in the actual commit, not GitHub comments. https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
e-kwsm wrote: >From [PEP8](https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with `is` or `is > not`, never the equality operators. [flake8](https://flake8.pycqa.org/en/latest/) is used here. https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
ftynse wrote: Please provide a proper patch description, i.e., why the change is being made. https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
llvmbot wrote: @llvm/pr-subscribers-pgo @llvm/pr-subscribers-compiler-rt-sanitizer Author: Eisuke Kawashima (e-kwsm) Changes --- Patch is 35.05 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/91857.diff 50 Files Affected: - (modified) clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py (+1-1) - (modified) clang/docs/DebuggingCoroutines.rst (+4-4) - (modified) clang/tools/include-mapping/gen_std.py (+1-1) - (modified) clang/utils/check_cfc/obj_diff.py (+1-1) - (modified) clang/utils/module-deps-to-rsp.py (+1-1) - (modified) compiler-rt/test/asan/lit.cfg.py (+1-1) - (modified) compiler-rt/test/builtins/Unit/lit.cfg.py (+1-1) - (modified) compiler-rt/test/ctx_profile/lit.cfg.py (+1-1) - (modified) compiler-rt/test/lsan/lit.common.cfg.py (+1-1) - (modified) compiler-rt/test/memprof/lit.cfg.py (+1-1) - (modified) compiler-rt/test/profile/lit.cfg.py (+1-1) - (modified) compiler-rt/test/sanitizer_common/android_commands/android_compile.py (+1-1) - (modified) compiler-rt/test/sanitizer_common/ios_commands/iossim_compile.py (+1-1) - (modified) compiler-rt/test/ubsan/lit.common.cfg.py (+1-1) - (modified) compiler-rt/test/ubsan_minimal/lit.common.cfg.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/command/ParseCommand.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/ConditionalController.py (+2-2) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/ControllerHelpers.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/Debuggers.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/tools/test/Tool.py (+1-1) - (modified) cross-project-tests/lit.cfg.py (+1-1) - (modified) lldb/docs/use/python.rst (+2-2) - (modified) lldb/examples/python/armv7_cortex_m_target_defintion.py (+1-1) - (modified) lldb/packages/Python/lldbsuite/test/dotest.py (+1-1) - (modified) lldb/packages/Python/lldbsuite/test/lldbtest.py (+3-3) - (modified) lldb/packages/Python/lldbsuite/test/lldbutil.py (+3-3) - (modified) lldb/packages/Python/lldbsuite/test/tools/intelpt/intelpt_testcase.py (+1-1) - (modified) lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py (+1-1) - (modified) lldb/test/API/functionalities/step_scripted/TestStepScripted.py (+1-1) - (modified) lldb/test/API/functionalities/stop-on-sharedlibrary-load/TestStopOnSharedlibraryEvents.py (+1-1) - (modified) lldb/test/API/lua_api/TestLuaAPI.py (+1-1) - (modified) lldb/test/API/macosx/thread_suspend/TestInternalThreadSuspension.py (+1-1) - (modified) lldb/test/API/python_api/event/TestEvents.py (+1-1) - (modified) lldb/test/API/python_api/process/read-mem-cstring/TestReadMemCString.py (+1-1) - (modified) lldb/test/API/python_api/type/TestTypeList.py (+1-1) - (modified) lldb/test/API/python_api/was_interrupted/interruptible.py (+1-1) - (modified) lldb/test/Shell/lit.cfg.py (+1-1) - (modified) llvm/utils/indirect_calls.py (+1-1) - (modified) llvm/utils/lit/lit/TestRunner.py (+1-1) - (modified) llvm/utils/lit/lit/util.py (+1-1) - (modified) llvm/utils/schedcover.py (+1-1) - (modified) llvm/utils/shuffle_select_fuzz_tester.py (+6-6) - (modified) mlir/test/python/ir/affine_expr.py (+1-1) - (modified) mlir/test/python/ir/attributes.py (+4-4) - (modified) mlir/test/python/ir/builtin_types.py (+4-4) - (modified) openmp/libompd/gdb-plugin/ompd/ompd_callbacks.py (+1-1) - (modified) polly/lib/External/isl/libisl-gdb.py (+2-2) - (modified) polly/lib/External/isl/python/isl.py.top (+2-2) - (modified) polly/utils/pyscop/isl.py (+4-4) ``diff diff --git a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py index 6545a3906fa50..53ecb60dec539 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py +++ b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py @@ -47,7 +47,7 @@ def get_checkers(checkers_td, checkers_rst): parent_package_ = package["ParentPackage"] hidden = (checker["Hidden"] != 0) or (package["Hidden"] != 0) -while parent_package_ != None: +while parent_package_ is not None: parent_package = table_entries[parent_package_["def"]] checker_package_prefix = ( parent_package["PackageName"] + "." + checker_package_prefix diff --git a/clang/docs/DebuggingCoroutines.rst b/clang/docs/DebuggingCoroutines.rst index 53bdd08fdbc02..7f464c1f4f28c 100644 --- a/clang/docs/DebuggingCoroutines.rst +++ b/clang/docs/DebuggingCoroutines.rst @@ -513,7 +513,7 @@ So we can use the ``continuation`` field to construct the asynchronous stack: self.coro_frame =
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
llvmbot wrote: @llvm/pr-subscribers-clang Author: Eisuke Kawashima (e-kwsm) Changes --- Patch is 35.05 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/91857.diff 50 Files Affected: - (modified) clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py (+1-1) - (modified) clang/docs/DebuggingCoroutines.rst (+4-4) - (modified) clang/tools/include-mapping/gen_std.py (+1-1) - (modified) clang/utils/check_cfc/obj_diff.py (+1-1) - (modified) clang/utils/module-deps-to-rsp.py (+1-1) - (modified) compiler-rt/test/asan/lit.cfg.py (+1-1) - (modified) compiler-rt/test/builtins/Unit/lit.cfg.py (+1-1) - (modified) compiler-rt/test/ctx_profile/lit.cfg.py (+1-1) - (modified) compiler-rt/test/lsan/lit.common.cfg.py (+1-1) - (modified) compiler-rt/test/memprof/lit.cfg.py (+1-1) - (modified) compiler-rt/test/profile/lit.cfg.py (+1-1) - (modified) compiler-rt/test/sanitizer_common/android_commands/android_compile.py (+1-1) - (modified) compiler-rt/test/sanitizer_common/ios_commands/iossim_compile.py (+1-1) - (modified) compiler-rt/test/ubsan/lit.common.cfg.py (+1-1) - (modified) compiler-rt/test/ubsan_minimal/lit.common.cfg.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/command/ParseCommand.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/ConditionalController.py (+2-2) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/ControllerHelpers.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/Debuggers.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/tools/test/Tool.py (+1-1) - (modified) cross-project-tests/lit.cfg.py (+1-1) - (modified) lldb/docs/use/python.rst (+2-2) - (modified) lldb/examples/python/armv7_cortex_m_target_defintion.py (+1-1) - (modified) lldb/packages/Python/lldbsuite/test/dotest.py (+1-1) - (modified) lldb/packages/Python/lldbsuite/test/lldbtest.py (+3-3) - (modified) lldb/packages/Python/lldbsuite/test/lldbutil.py (+3-3) - (modified) lldb/packages/Python/lldbsuite/test/tools/intelpt/intelpt_testcase.py (+1-1) - (modified) lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py (+1-1) - (modified) lldb/test/API/functionalities/step_scripted/TestStepScripted.py (+1-1) - (modified) lldb/test/API/functionalities/stop-on-sharedlibrary-load/TestStopOnSharedlibraryEvents.py (+1-1) - (modified) lldb/test/API/lua_api/TestLuaAPI.py (+1-1) - (modified) lldb/test/API/macosx/thread_suspend/TestInternalThreadSuspension.py (+1-1) - (modified) lldb/test/API/python_api/event/TestEvents.py (+1-1) - (modified) lldb/test/API/python_api/process/read-mem-cstring/TestReadMemCString.py (+1-1) - (modified) lldb/test/API/python_api/type/TestTypeList.py (+1-1) - (modified) lldb/test/API/python_api/was_interrupted/interruptible.py (+1-1) - (modified) lldb/test/Shell/lit.cfg.py (+1-1) - (modified) llvm/utils/indirect_calls.py (+1-1) - (modified) llvm/utils/lit/lit/TestRunner.py (+1-1) - (modified) llvm/utils/lit/lit/util.py (+1-1) - (modified) llvm/utils/schedcover.py (+1-1) - (modified) llvm/utils/shuffle_select_fuzz_tester.py (+6-6) - (modified) mlir/test/python/ir/affine_expr.py (+1-1) - (modified) mlir/test/python/ir/attributes.py (+4-4) - (modified) mlir/test/python/ir/builtin_types.py (+4-4) - (modified) openmp/libompd/gdb-plugin/ompd/ompd_callbacks.py (+1-1) - (modified) polly/lib/External/isl/libisl-gdb.py (+2-2) - (modified) polly/lib/External/isl/python/isl.py.top (+2-2) - (modified) polly/utils/pyscop/isl.py (+4-4) ``diff diff --git a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py index 6545a3906fa50..53ecb60dec539 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py +++ b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py @@ -47,7 +47,7 @@ def get_checkers(checkers_td, checkers_rst): parent_package_ = package["ParentPackage"] hidden = (checker["Hidden"] != 0) or (package["Hidden"] != 0) -while parent_package_ != None: +while parent_package_ is not None: parent_package = table_entries[parent_package_["def"]] checker_package_prefix = ( parent_package["PackageName"] + "." + checker_package_prefix diff --git a/clang/docs/DebuggingCoroutines.rst b/clang/docs/DebuggingCoroutines.rst index 53bdd08fdbc02..7f464c1f4f28c 100644 --- a/clang/docs/DebuggingCoroutines.rst +++ b/clang/docs/DebuggingCoroutines.rst @@ -513,7 +513,7 @@ So we can use the ``continuation`` field to construct the asynchronous stack: self.coro_frame = coro_frame self.resume_func =
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using `@` followed by their GitHub username. If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the [LLVM GitHub User Guide](https://llvm.org/docs/GitHub.html). You can also ask questions in a comment on this PR, on the [LLVM Discord](https://discord.com/invite/xS7Z362) or on the [forums](https://discourse.llvm.org/). https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
https://github.com/e-kwsm created
https://github.com/llvm/llvm-project/pull/91857
None
>From c450df191a6b96591d7c7a7454b6e15cb925520f Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sat, 11 May 2024 23:57:11 +0900
Subject: [PATCH] fix(python): fix comparison to None
---
.../clang-tidy/checks/gen-static-analyzer-docs.py| 2 +-
clang/docs/DebuggingCoroutines.rst | 8
clang/tools/include-mapping/gen_std.py | 2 +-
clang/utils/check_cfc/obj_diff.py| 2 +-
clang/utils/module-deps-to-rsp.py| 2 +-
compiler-rt/test/asan/lit.cfg.py | 2 +-
compiler-rt/test/builtins/Unit/lit.cfg.py| 2 +-
compiler-rt/test/ctx_profile/lit.cfg.py | 2 +-
compiler-rt/test/lsan/lit.common.cfg.py | 2 +-
compiler-rt/test/memprof/lit.cfg.py | 2 +-
compiler-rt/test/profile/lit.cfg.py | 2 +-
.../android_commands/android_compile.py | 2 +-
.../sanitizer_common/ios_commands/iossim_compile.py | 2 +-
compiler-rt/test/ubsan/lit.common.cfg.py | 2 +-
compiler-rt/test/ubsan_minimal/lit.common.cfg.py | 2 +-
.../dexter/dex/command/ParseCommand.py | 2 +-
.../DebuggerControllers/ConditionalController.py | 4 ++--
.../DebuggerControllers/ControllerHelpers.py | 2 +-
.../debuginfo-tests/dexter/dex/debugger/Debuggers.py | 2 +-
.../dexter/dex/debugger/visualstudio/VisualStudio.py | 2 +-
.../debuginfo-tests/dexter/dex/tools/test/Tool.py| 2 +-
cross-project-tests/lit.cfg.py | 2 +-
lldb/docs/use/python.rst | 4 ++--
.../python/armv7_cortex_m_target_defintion.py| 2 +-
lldb/packages/Python/lldbsuite/test/dotest.py| 2 +-
lldb/packages/Python/lldbsuite/test/lldbtest.py | 6 +++---
lldb/packages/Python/lldbsuite/test/lldbutil.py | 6 +++---
.../lldbsuite/test/tools/intelpt/intelpt_testcase.py | 2 +-
.../address_breakpoints/TestBadAddressBreakpoints.py | 2 +-
.../step_scripted/TestStepScripted.py| 2 +-
.../TestStopOnSharedlibraryEvents.py | 2 +-
lldb/test/API/lua_api/TestLuaAPI.py | 2 +-
.../thread_suspend/TestInternalThreadSuspension.py | 2 +-
lldb/test/API/python_api/event/TestEvents.py | 2 +-
.../process/read-mem-cstring/TestReadMemCString.py | 2 +-
lldb/test/API/python_api/type/TestTypeList.py| 2 +-
.../API/python_api/was_interrupted/interruptible.py | 2 +-
lldb/test/Shell/lit.cfg.py | 2 +-
llvm/utils/indirect_calls.py | 2 +-
llvm/utils/lit/lit/TestRunner.py | 2 +-
llvm/utils/lit/lit/util.py | 2 +-
llvm/utils/schedcover.py | 2 +-
llvm/utils/shuffle_select_fuzz_tester.py | 12 ++--
mlir/test/python/ir/affine_expr.py | 2 +-
mlir/test/python/ir/attributes.py| 8
mlir/test/python/ir/builtin_types.py | 8
openmp/libompd/gdb-plugin/ompd/ompd_callbacks.py | 2 +-
polly/lib/External/isl/libisl-gdb.py | 4 ++--
polly/lib/External/isl/python/isl.py.top | 4 ++--
polly/utils/pyscop/isl.py| 8
50 files changed, 75 insertions(+), 75 deletions(-)
diff --git
a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py
b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py
index 6545a3906fa50..53ecb60dec539 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py
+++ b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py
@@ -47,7 +47,7 @@ def get_checkers(checkers_td, checkers_rst):
parent_package_ = package["ParentPackage"]
hidden = (checker["Hidden"] != 0) or (package["Hidden"] != 0)
-while parent_package_ != None:
+while parent_package_ is not None:
parent_package = table_entries[parent_package_["def"]]
checker_package_prefix = (
parent_package["PackageName"] + "." + checker_package_prefix
diff --git a/clang/docs/DebuggingCoroutines.rst
b/clang/docs/DebuggingCoroutines.rst
index 53bdd08fdbc02..7f464c1f4f28c 100644
--- a/clang/docs/DebuggingCoroutines.rst
+++ b/clang/docs/DebuggingCoroutines.rst
@@ -513,7 +513,7 @@ So we can use the ``continuation`` field to construct the
asynchronous stack:
self.coro_frame = coro_frame
self.resume_func = dereference(self.coro_frame.resume_addr)
self.resume_func_block = gdb.block_for_pc(self.resume_func)
- if self.resume_func_block == None:
+ if self.resume_func_block is None:
raise Exception('Not stackless coroutine.')
self.line_info = gdb.find_pc_line(self.resume_func)
