[Lldb-commits] [lldb] [lldb] Fixed the test TestQuoting (PR #91886)

[Dmitry Vasilyev via lldb-commits]

https://github.com/slydiman closed 
https://github.com/llvm/llvm-project/pull/91886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed the test TestQuoting (PR #91886)

[Pavel Labath via lldb-commits]

https://github.com/labath approved this pull request.


https://github.com/llvm/llvm-project/pull/91886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed the test TestQuoting (PR #91886)

[David Spickett via lldb-commits]

https://github.com/DavidSpickett approved this pull request.

LGTM

https://github.com/llvm/llvm-project/pull/91886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed the test TestQuoting (PR #91886)

[Dmitry Vasilyev via lldb-commits]

https://github.com/slydiman updated 
https://github.com/llvm/llvm-project/pull/91886

>From f6135c1b825afd9fe733b845dfd12ffe3c162840 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev 
Date: Sun, 12 May 2024 18:08:50 +0400
Subject: [PATCH 1/2] [lldb] Fixed the test TestQuoting

os.path.join() uses the path separator of the host OS by default. outfile_arg 
will be incorrect in case of Windows host and Linux target. Use 
lldbutil.append_to_process_working_directory() instead.
---
 lldb/test/API/commands/settings/quoting/TestQuoting.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lldb/test/API/commands/settings/quoting/TestQuoting.py 
b/lldb/test/API/commands/settings/quoting/TestQuoting.py
index 393f4be3c8242..d6246a5309c5d 100644
--- a/lldb/test/API/commands/settings/quoting/TestQuoting.py
+++ b/lldb/test/API/commands/settings/quoting/TestQuoting.py
@@ -51,8 +51,8 @@ def expect_args(self, args_in, args_out):
 outfile = self.getBuildArtifact(filename)
 
 if lldb.remote_platform:
-outfile_arg = os.path.join(
-lldb.remote_platform.GetWorkingDirectory(), filename
+outfile_arg = lldbutil.append_to_process_working_directory(
+self, filename
 )
 else:
 outfile_arg = outfile

>From ff85c4d9cb0c749fe75be1493dd22b7f7c0de9be Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev 
Date: Sun, 12 May 2024 18:35:12 +0400
Subject: [PATCH 2/2] Updated the formatting by darker

---
 lldb/test/API/commands/settings/quoting/TestQuoting.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lldb/test/API/commands/settings/quoting/TestQuoting.py 
b/lldb/test/API/commands/settings/quoting/TestQuoting.py
index d6246a5309c5d..60ad4e0a4 100644
--- a/lldb/test/API/commands/settings/quoting/TestQuoting.py
+++ b/lldb/test/API/commands/settings/quoting/TestQuoting.py
@@ -51,9 +51,7 @@ def expect_args(self, args_in, args_out):
 outfile = self.getBuildArtifact(filename)
 
 if lldb.remote_platform:
-outfile_arg = lldbutil.append_to_process_working_directory(
-self, filename
-)
+outfile_arg = lldbutil.append_to_process_working_directory(self, 
filename)
 else:
 outfile_arg = outfile
 

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed the test TestQuoting (PR #91886)

[via lldb-commits]

github-actions[bot] wrote:




:warning: Python code formatter, darker found issues in your code. :warning:



You can test this locally with the following command:


``bash
darker --check --diff -r 
1d6bf0ca29322b08e8b50681d440e7182441b025...f6135c1b825afd9fe733b845dfd12ffe3c162840
 lldb/test/API/commands/settings/quoting/TestQuoting.py
``





View the diff from darker here.


``diff
--- TestQuoting.py  2024-05-12 14:08:50.00 +
+++ TestQuoting.py  2024-05-12 14:13:04.914847 +
@@ -49,13 +49,11 @@
 
 filename = SettingsCommandTestCase.output_file_name
 outfile = self.getBuildArtifact(filename)
 
 if lldb.remote_platform:
-outfile_arg = lldbutil.append_to_process_working_directory(
-self, filename
-)
+outfile_arg = lldbutil.append_to_process_working_directory(self, 
filename)
 else:
 outfile_arg = outfile
 
 self.runCmd("process launch -- %s %s" % (outfile_arg, args_in))
 

``




https://github.com/llvm/llvm-project/pull/91886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed the test TestQuoting (PR #91886)

[via lldb-commits]

llvmbot wrote:




@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)


Changes

os.path.join() uses the path separator of the host OS by default. outfile_arg 
will be incorrect in case of Windows host and Linux target. Use 
lldbutil.append_to_process_working_directory() instead.

---
Full diff: https://github.com/llvm/llvm-project/pull/91886.diff


1 Files Affected:

- (modified) lldb/test/API/commands/settings/quoting/TestQuoting.py (+2-2) 


``diff
diff --git a/lldb/test/API/commands/settings/quoting/TestQuoting.py 
b/lldb/test/API/commands/settings/quoting/TestQuoting.py
index 393f4be3c8242..d6246a5309c5d 100644
--- a/lldb/test/API/commands/settings/quoting/TestQuoting.py
+++ b/lldb/test/API/commands/settings/quoting/TestQuoting.py
@@ -51,8 +51,8 @@ def expect_args(self, args_in, args_out):
 outfile = self.getBuildArtifact(filename)
 
 if lldb.remote_platform:
-outfile_arg = os.path.join(
-lldb.remote_platform.GetWorkingDirectory(), filename
+outfile_arg = lldbutil.append_to_process_working_directory(
+self, filename
 )
 else:
 outfile_arg = outfile

``




https://github.com/llvm/llvm-project/pull/91886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed the test TestQuoting (PR #91886)

[Dmitry Vasilyev via lldb-commits]

https://github.com/slydiman created 
https://github.com/llvm/llvm-project/pull/91886

os.path.join() uses the path separator of the host OS by default. outfile_arg 
will be incorrect in case of Windows host and Linux target. Use 
lldbutil.append_to_process_working_directory() instead.

>From f6135c1b825afd9fe733b845dfd12ffe3c162840 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev 
Date: Sun, 12 May 2024 18:08:50 +0400
Subject: [PATCH] [lldb] Fixed the test TestQuoting

os.path.join() uses the path separator of the host OS by default. outfile_arg 
will be incorrect in case of Windows host and Linux target. Use 
lldbutil.append_to_process_working_directory() instead.
---
 lldb/test/API/commands/settings/quoting/TestQuoting.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lldb/test/API/commands/settings/quoting/TestQuoting.py 
b/lldb/test/API/commands/settings/quoting/TestQuoting.py
index 393f4be3c8242..d6246a5309c5d 100644
--- a/lldb/test/API/commands/settings/quoting/TestQuoting.py
+++ b/lldb/test/API/commands/settings/quoting/TestQuoting.py
@@ -51,8 +51,8 @@ def expect_args(self, args_in, args_out):
 outfile = self.getBuildArtifact(filename)
 
 if lldb.remote_platform:
-outfile_arg = os.path.join(
-lldb.remote_platform.GetWorkingDirectory(), filename
+outfile_arg = lldbutil.append_to_process_working_directory(
+self, filename
 )
 else:
 outfile_arg = outfile

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits