Re: [Gluster-Maintainers] Release 5: Missing option documentation (need inputs)

[Raghavendra Gowdappa]

On Wed, Oct 10, 2018 at 8:30 PM Shyam Ranganathan 
wrote:

> The following options were added post 4.1 and are part of 5.0 as the
> first release for the same. They were added in as part of bugs, and
> hence looking at github issues to track them as enhancements did not
> catch the same.
>
> We need to document it in the release notes (and also the gluster doc.
> site ideally), and hence I would like a some details on what to write
> for the same (or release notes commits) for them.
>
> Option: cluster.daemon-log-level
> Attention: @atin
> Review: https://review.gluster.org/c/glusterfs/+/20442
>
> Option: ctime-invalidation
> Attention: @Du
> Review: https://review.gluster.org/c/glusterfs/+/20286


Quick-read by default uses mtime to identify changes to file data. However
there are applications like rsync which explicitly set mtime making it
unreliable for the purpose of identifying change in file content. Since
ctime also changes when content of a file changes and it cannot be set
explicitly, it becomes suitable for identifying staleness of cached data.
This option makes quick-read to prefer ctime over mtime to validate its
cache. However, using ctime can result in false positives as ctime changes
with just attribute changes like permission without changes to file data.
So, use this option only when mtime is not reliable.


>
> Option: shard-lru-limit
> Attention: @krutika
> Review: https://review.gluster.org/c/glusterfs/+/20544
>
> Option: shard-deletion-rate
> Attention: @krutika
> Review: https://review.gluster.org/c/glusterfs/+/19970
>
> Please send in the required text ASAP, as we are almost towards the end
> of the release.
>
> Thanks,
> Shyam
>
___
maintainers mailing list
maintainers@gluster.org
https://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] Release 5: Missing option documentation (need inputs)

[Krutika Dhananjay]

On Wed, Oct 10, 2018 at 8:30 PM Shyam Ranganathan 
wrote:

> The following options were added post 4.1 and are part of 5.0 as the
> first release for the same. They were added in as part of bugs, and
> hence looking at github issues to track them as enhancements did not
> catch the same.
>
> We need to document it in the release notes (and also the gluster doc.
> site ideally), and hence I would like a some details on what to write
> for the same (or release notes commits) for them.
>
> Option: cluster.daemon-log-level
> Attention: @atin
> Review: https://review.gluster.org/c/glusterfs/+/20442
>
> Option: ctime-invalidation
> Attention: @Du
> Review: https://review.gluster.org/c/glusterfs/+/20286
>
> Option: shard-lru-limit
> Attention: @krutika
> Review: https://review.gluster.org/c/glusterfs/+/20544


I added this option solely to make it easier to hit shard's in-memory lru
limit and enable testing of different cases that arise when the limit is
reached.
For this reason, this option is also marked "NO_DOC" in the code. So we
don't need to document it in the release notes.


>
> Option: shard-deletion-rate
> Attention: @krutika
> Review: https://review.gluster.org/c/glusterfs/+/19970
>
> Please send in the required text ASAP, as we are almost towards the end
>
of the release.
>

This option is used to configure the number of shards to delete in parallel
when the original file is deleted. The default value is 100. But it can
always be increased to delete more shards in parallel for faster freeing up
of space. The upper limit is yet to be fixed.  But use it with caution as a
very large number will cause serious lock contention issues on the bricks
(in locks translator). As an example, in our testing, an upper limit of
125000 was enough to cause timeouts and hangs in the gluster processes due
to lock contention.

-Krutika


> Thanks,
> Shyam
>
___
maintainers mailing list
maintainers@gluster.org
https://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] Release 5: Missing option documentation (need inputs)

[Niels de Vos]

On Thu, Oct 11, 2018 at 09:00:50AM -0400, Shyam Ranganathan wrote:
> On 10/10/2018 11:20 PM, Atin Mukherjee wrote:
> > 
> > 
> > On Wed, 10 Oct 2018 at 20:30, Shyam Ranganathan  > > wrote:
> > 
> > The following options were added post 4.1 and are part of 5.0 as the
> > first release for the same. They were added in as part of bugs, and
> > hence looking at github issues to track them as enhancements did not
> > catch the same.
> > 
> > We need to document it in the release notes (and also the gluster doc.
> > site ideally), and hence I would like a some details on what to write
> > for the same (or release notes commits) for them.
> > 
> > Option: cluster.daemon-log-level
> > Attention: @atin
> > Review: https://review.gluster.org/c/glusterfs/+/20442
> > 
> > 
> > This option has to be used based on extreme need basis and this is why
> > it has been mentioned as GLOBAL_NO_DOC. So ideally this shouldn't be
> > documented.
> > 
> > Do we still want to capture it in the release notes?
> 
> This is an interesting catch-22, when we want users to use the option
> (say to provide better logs for troubleshooting), we have nothing to
> point to, and it would be instructions (repeated over the course of
> time) over mails.
> 
> I would look at adding this into an options section in the docs, but the
> best I can find in there is
> https://docs.gluster.org/en/latest/Administrator%20Guide/Managing%20Volumes/
> 
> I would say we need to improve the way we deal with options and the
> required submissions around the same.
> 
> Thoughts?

Maybe this should be documented under
https://docs.gluster.org/en/latest/Troubleshooting/ and not the general
"Managing Volumes" part of the docs.

Having it documented *somewhere* is definitely needed. And because it
seems to be related to debugging particular components, the
Troubleshooting section seems appropriate.

Niels
___
maintainers mailing list
maintainers@gluster.org
https://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] Release 5: Missing option documentation (need inputs)

[Nithya Balachandran]

On 11 October 2018 at 18:30, Shyam Ranganathan  wrote:

> On 10/10/2018 11:20 PM, Atin Mukherjee wrote:
> >
> >
> > On Wed, 10 Oct 2018 at 20:30, Shyam Ranganathan  > > wrote:
> >
> > The following options were added post 4.1 and are part of 5.0 as the
> > first release for the same. They were added in as part of bugs, and
> > hence looking at github issues to track them as enhancements did not
> > catch the same.
> >
> > We need to document it in the release notes (and also the gluster
> doc.
> > site ideally), and hence I would like a some details on what to write
> > for the same (or release notes commits) for them.
> >
> > Option: cluster.daemon-log-level
> > Attention: @atin
> > Review: https://review.gluster.org/c/glusterfs/+/20442
> >
> >
> > This option has to be used based on extreme need basis and this is why
> > it has been mentioned as GLOBAL_NO_DOC. So ideally this shouldn't be
> > documented.
> >
> > Do we still want to capture it in the release notes?
>
> This is an interesting catch-22, when we want users to use the option
> (say to provide better logs for troubleshooting), we have nothing to
> point to, and it would be instructions (repeated over the course of
> time) over mails.
>
> I would look at adding this into an options section in the docs, but the
> best I can find in there is
> https://docs.gluster.org/en/latest/Administrator%20Guide/
> Managing%20Volumes/
>
> I would say we need to improve the way we deal with options and the
> required submissions around the same.
>
> No argument there. I will take a look and get back on what we can improve
in the docs.



> Thoughts?
>
> >
> > 
> >
> > Option: ctime-invalidation
> > Attention: @Du
> > Review: https://review.gluster.org/c/glusterfs/+/20286
> >
> > Option: shard-lru-limit
> > Attention: @krutika
> > Review: https://review.gluster.org/c/glusterfs/+/20544
> >
> > Option: shard-deletion-rate
> > Attention: @krutika
> > Review: https://review.gluster.org/c/glusterfs/+/19970
> >
> > Please send in the required text ASAP, as we are almost towards the
> end
> > of the release.
> >
> > Thanks,
> > Shyam
> >
> ___
> maintainers mailing list
> maintainers@gluster.org
> https://lists.gluster.org/mailman/listinfo/maintainers
>
___
maintainers mailing list
maintainers@gluster.org
https://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] Release 5: Missing option documentation (need inputs)

[Shyam Ranganathan]

On 10/10/2018 11:20 PM, Atin Mukherjee wrote:
> 
> 
> On Wed, 10 Oct 2018 at 20:30, Shyam Ranganathan  > wrote:
> 
> The following options were added post 4.1 and are part of 5.0 as the
> first release for the same. They were added in as part of bugs, and
> hence looking at github issues to track them as enhancements did not
> catch the same.
> 
> We need to document it in the release notes (and also the gluster doc.
> site ideally), and hence I would like a some details on what to write
> for the same (or release notes commits) for them.
> 
> Option: cluster.daemon-log-level
> Attention: @atin
> Review: https://review.gluster.org/c/glusterfs/+/20442
> 
> 
> This option has to be used based on extreme need basis and this is why
> it has been mentioned as GLOBAL_NO_DOC. So ideally this shouldn't be
> documented.
> 
> Do we still want to capture it in the release notes?

This is an interesting catch-22, when we want users to use the option
(say to provide better logs for troubleshooting), we have nothing to
point to, and it would be instructions (repeated over the course of
time) over mails.

I would look at adding this into an options section in the docs, but the
best I can find in there is
https://docs.gluster.org/en/latest/Administrator%20Guide/Managing%20Volumes/

I would say we need to improve the way we deal with options and the
required submissions around the same.

Thoughts?

> 
> 
> 
> Option: ctime-invalidation
> Attention: @Du
> Review: https://review.gluster.org/c/glusterfs/+/20286
> 
> Option: shard-lru-limit
> Attention: @krutika
> Review: https://review.gluster.org/c/glusterfs/+/20544
> 
> Option: shard-deletion-rate
> Attention: @krutika
> Review: https://review.gluster.org/c/glusterfs/+/19970
> 
> Please send in the required text ASAP, as we are almost towards the end
> of the release.
> 
> Thanks,
> Shyam
> 
___
maintainers mailing list
maintainers@gluster.org
https://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] Release 5: Missing option documentation (need inputs)

[Atin Mukherjee]

On Wed, 10 Oct 2018 at 20:30, Shyam Ranganathan  wrote:

> The following options were added post 4.1 and are part of 5.0 as the
> first release for the same. They were added in as part of bugs, and
> hence looking at github issues to track them as enhancements did not
> catch the same.
>
> We need to document it in the release notes (and also the gluster doc.
> site ideally), and hence I would like a some details on what to write
> for the same (or release notes commits) for them.
>
> Option: cluster.daemon-log-level
> Attention: @atin
> Review: https://review.gluster.org/c/glusterfs/+/20442


This option has to be used based on extreme need basis and this is why it
has been mentioned as GLOBAL_NO_DOC. So ideally this shouldn't be
documented.

Do we still want to capture it in the release notes?


>
> Option: ctime-invalidation
> Attention: @Du
> Review: https://review.gluster.org/c/glusterfs/+/20286
>
> Option: shard-lru-limit
> Attention: @krutika
> Review: https://review.gluster.org/c/glusterfs/+/20544
>
> Option: shard-deletion-rate
> Attention: @krutika
> Review: https://review.gluster.org/c/glusterfs/+/19970
>
> Please send in the required text ASAP, as we are almost towards the end
> of the release.
>
> Thanks,
> Shyam
>
___
maintainers mailing list
maintainers@gluster.org
https://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] Release 5: Missing option documentation (need inputs)

[Shyam Ranganathan]

The following options were added post 4.1 and are part of 5.0 as the
first release for the same. They were added in as part of bugs, and
hence looking at github issues to track them as enhancements did not
catch the same.

We need to document it in the release notes (and also the gluster doc.
site ideally), and hence I would like a some details on what to write
for the same (or release notes commits) for them.

Option: cluster.daemon-log-level
Attention: @atin
Review: https://review.gluster.org/c/glusterfs/+/20442

Option: ctime-invalidation
Attention: @Du
Review: https://review.gluster.org/c/glusterfs/+/20286

Option: shard-lru-limit
Attention: @krutika
Review: https://review.gluster.org/c/glusterfs/+/20544

Option: shard-deletion-rate
Attention: @krutika
Review: https://review.gluster.org/c/glusterfs/+/19970

Please send in the required text ASAP, as we are almost towards the end
of the release.

Thanks,
Shyam
___
maintainers mailing list
maintainers@gluster.org
https://lists.gluster.org/mailman/listinfo/maintainers