[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=94512

Matt Turner  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from Matt Turner  ---
Fixed by

commit 89458366585c34879b70110758bb4fd3acb62ce0
Author: Grazvydas Ignotas 
Date:   Sun Jan 8 19:38:09 2017 +0200

mapi: update the asm code to support x32

Thanks Grazvydas!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=94512

EoD  changed:

   What|Removed |Added

 CC|e...@xmw.de  |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=94512

--- Comment #13 from Grazvydas Ignotas  ---
(In reply to EoD from comment #12)
> I am no expert, but don't you want to use exact-length types instead of
> "long long"?

mapi doesn't use such types and I did not want to drag in a dependency. Also
the modified file is for x86-64 only and has asm in GNU syntax, anything
compiling that should have long long of 8 bytes.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=94512

--- Comment #12 from EoD  ---
(In reply to Grazvydas Ignotas from comment #11)
> Ignore the previous patch, it's botched.
> I've compiled the x32 deps, so could test what allowed to produce a working
> patch:
> https://lists.freedesktop.org/archives/mesa-dev/2017-January/139946.html

I tried both patches and only the one on the ML is working.

I am no expert, but don't you want to use exact-length types instead of "long
long"?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=94512

Grazvydas Ignotas  changed:

   What|Removed |Added

 CC||e...@xmw.de

--- Comment #11 from Grazvydas Ignotas  ---
Ignore the previous patch, it's botched.
I've compiled the x32 deps, so could test what allowed to produce a working
patch:
https://lists.freedesktop.org/archives/mesa-dev/2017-January/139946.html

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=94512

Grazvydas Ignotas  changed:

   What|Removed |Added

 CC||nota...@gmail.com

--- Comment #10 from Grazvydas Ignotas  ---
Created attachment 128810
  --> https://bugs.freedesktop.org/attachment.cgi?id=128810=edit
x32 fix attempt

Maybe this patch will help?

If not, any tips how to set up a x32 environment without spending the whole day
on it? My distro is Ubuntu.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=94512

--- Comment #9 from EoD  ---
(In reply to Emil Velikov from comment #8)
> Double-checking the logs - seems like TLS is built/used throughout the board.
> One thing which comes to mind - can you try with --disable-asm. I'm fairly
> sure that the code we have in there doesn't attribute x32.
> 
> Note: I'll be pushing a patch which makes --enable-glx-tls the default in a
> moment, so please keep it disabled locally until we get to the bottom of
> this.

I can confirm that a "--enable-glx-tls --disable-asm" works as well as
"--disable-glx-tls --enable-asm".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=94512

--- Comment #8 from Emil Velikov  ---
Double-checking the logs - seems like TLS is built/used throughout the board.
One thing which comes to mind - can you try with --disable-asm. I'm fairly sure
that the code we have in there doesn't attribute x32.

Note: I'll be pushing a patch which makes --enable-glx-tls the default in a
moment, so please keep it disabled locally until we get to the bottom of this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=94512

--- Comment #7 from EoD  ---
Created attachment 124376
  --> https://bugs.freedesktop.org/attachment.cgi?id=124376=edit
LD_DEBUG=libs startx

(In reply to Emil Velikov from comment #6)
> Based of the backtrace there is no information if mesa/libglapi was build
> with or w/o glx-tls. Following an IRC conversation it seems that the library
> is built w/o glx-tls as i is missing the _glapi_tls_Context and
> _glapi_tls_Dispatch symbols.
> 
> Perhaps they are different builds ? Either way it's good to attach the
> output of $nm -CD --defined-only /usr/libx32/libglapi.so in this particular
> case.
> 
> Also please that the correct libraries are being picked up. This can be done
> via something like:
>  $LD_DEBUG=libs foo (startx) 2>ld_debug.log
> 
> Obviously none of these excludes that there is an actual issue with x32 and
> glx-tls and/or that mesa silently ignores the flag on said platform ;-)

glx-tls never worked for me on my x32 setup. This setup is only around half a
year old, so I don't know if it worked before.

$ nm -CD --defined-only /usr/libx32/libglapi.so
0004 B _glapi_tls_Context
 D _glapi_tls_Dispatch
In full: https://gist.github.com/anonymous/543fd6a51163ced35819df49dbd0902c

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=94512

--- Comment #6 from Emil Velikov  ---
Based of the backtrace there is no information if mesa/libglapi was build with
or w/o glx-tls. Following an IRC conversation it seems that the library is
built w/o glx-tls as i is missing the _glapi_tls_Context and
_glapi_tls_Dispatch symbols.

Perhaps they are different builds ? Either way it's good to attach the output
of $nm -CD --defined-only /usr/libx32/libglapi.so in this particular case.

Also please that the correct libraries are being picked up. This can be done
via something like:
 $LD_DEBUG=libs foo (startx) 2>ld_debug.log

Obviously none of these excludes that there is an actual issue with x32 and
glx-tls and/or that mesa silently ignores the flag on said platform ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=94512

--- Comment #5 from EoD  ---
(In reply to Michel Dänzer from comment #4)
> Sounds like it's not a driver specific issue then but a general one with
> GLX-TLS on x32.

X did not segfault when I used my Barts (radeon + r600) instead of the Tonga
(amdgpu + radeonsi), although I had no acceleration on both. So there might be
too issues here which I mixed up by accident. I'll stick to the glx-tls issue
from now on.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=94512

Michel Dänzer  changed:

   What|Removed |Added

 QA Contact|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.
   |.org|org
   Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.
   |.org|org
  Component|Drivers/Gallium/radeonsi|GLX

--- Comment #4 from Michel Dänzer  ---
Sounds like it's not a driver specific issue then but a general one with
GLX-TLS on x32.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev