Re: [MP3 ENCODER] 3.84beta is out, default VBR mode = old VBR mode

[Robert Hegemann]

Hi,

it looks like some code in quantize.c is now broken
in lame3.84 beta. There is no quality decrease, but
an unnecessary speed decrease for the old VBR.
You would have to patch lame.c and parse.c with the following
and the old VBR would be back at its normal speed.

Ciao Robert


*** lame.c.orig Sat Jul  1 11:27:53 2000
--- lame.c  Sat Jul  1 11:28:33 2000
***
*** 1027,1036 
  
  
switch (gfp-VBR){ 
!   case 2:
  VBR_quantize( gfp,*pe_use, gfc-ms_ener_ratio, xr, *masking, l3_enc, scalefac);
  break;
!   case 1:
  VBR_iteration_loop( gfp,*pe_use, gfc-ms_ener_ratio, xr, *masking, l3_enc, 
scalefac);
  break;
case 3:
--- 1027,1036 
  
  
switch (gfp-VBR){ 
!   case 1:
  VBR_quantize( gfp,*pe_use, gfc-ms_ener_ratio, xr, *masking, l3_enc, scalefac);
  break;
!   case 2:
  VBR_iteration_loop( gfp,*pe_use, gfc-ms_ener_ratio, xr, *masking, l3_enc, 
scalefac);
  break;
case 3:
*** parse.c.origSat Jul  1 11:23:10 2000
--- parse.c Sat Jul  1 11:25:48 2000
***
*** 281,291 
  }
}
else if (strcmp(token, "vbr-old")==0) {
! gfp-VBR = 1; 
  gfp-quality = 2;
}
else if (strcmp(token, "vbr-new")==0) {
! gfp-VBR = 2; 
  gfp-quality = 2;
}
else if (strcmp(token, "abr")==0) {
--- 281,291 
  }
}
else if (strcmp(token, "vbr-old")==0) {
! gfp-VBR = 2; 
  gfp-quality = 2;
}
else if (strcmp(token, "vbr-new")==0) {
! gfp-VBR = 1; 
  gfp-quality = 2;
}
else if (strcmp(token, "abr")==0) {
***
*** 630,636 
  }
  break;
case 'V':argUsed = 1;
! gfp-VBR = gfp-VBR == 0 ? 1 : gfp-VBR;  
  gfp-VBR_q = atoi(arg);
  if (gfp-VBR_q 0) gfp-VBR_q=0;
  if (gfp-VBR_q 9) gfp-VBR_q=9;
--- 630,636 
  }
  break;
case 'V':argUsed = 1;
! gfp-VBR = gfp-VBR == 0 ? 2 : gfp-VBR;  
  gfp-VBR_q = atoi(arg);
  if (gfp-VBR_q 0) gfp-VBR_q=0;
  if (gfp-VBR_q 9) gfp-VBR_q=9;
***
*** 691,697 
  gfp-allow_diff_short = 1;
  break;
case 'v': 
! gfp-VBR = 1; 
  gfp-quality = 2;
  break;
case 'S': 
--- 691,697 
  gfp-allow_diff_short = 1;
  break;
case 'v': 
! gfp-VBR = 2; 
  gfp-quality = 2;
  break;
case 'S': 


--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )

Re: [MP3 ENCODER] 3.84beta is out, default VBR mode = old VBR mode

[Osamu Shigematsu]

Hello, everyone.

I just upload my Macintosh port at:

http://isize.egroups.co.jp/files/lame-dev/

Thanks.

-- 
Osamu Shigematsu
mailto:[EMAIL PROTECTED]



--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )

[MP3 ENCODER] 3.84beta is out, default VBR mode = old VBR mode

[Mark Taylor]

Hi Everyone,

I have taken Roel's advice: 3.84beta is now released using the
"old_vbr_mode". It has been a long time since our last release, and I
think it is a good idea to have one more release with the old VBR
mode.  

3.84beta does not use Takehiro's scalefactor_scale patch (the -Z
argument) in VBR mode, although it does use it in CBR mode.  Roel has
found that it is usefull for high bitrate VBR encodings, but at
moderate bitrate (around 128kbs), it has some clear flaws.
You can try it out with the -q1 option.  

The constant changing and remapping of options in the development code
is a problem but I dont know what to do about it.  It is good that so
many people try out the development releases, and that is the main
reason lame progresses so quickly.

So, to keep things confusing and to encourage progress: the CVS
version of lame uses the "new_vbr_mode" by default :-)

lame3.84.tar.gz is on the web site, and you can also get it
from CVS with 

% cvs update -r lame3_84beta 


Mark

--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )