Re: [jclouds-site] Update compute.md (#130)

2015-04-03 Thread Everett Toews 
Closed #130.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/130#event-272779175

Re: [jclouds-site] Update compute.md (#130)

2015-03-24 Thread jclouds-commentator 
  Go to 
http://8f9f01aa921ee2fd31c9-54b9bade39cf00b7396782e42750d03f.r67.cf5.rackcdn.com/
 to review your changes.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/130#issuecomment-85720357

Re: [jclouds-site] Update compute.md (#130)

2015-03-24 Thread Everett Toews 
Thanks for the pull request but it's release week in jclouds and that means 
it's time to clean up the PR queue. This PR will be over 6 months old as of 
April 1. If you intend to continue work on it, please make a comment by April 
2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/130#issuecomment-85719600

Re: [jclouds-site] Update compute.md (#130)

2014-10-06 Thread Everett Toews 
Thanks for the sharp eyes @yaronr!

I think it's more than slightly confusing considering there are also examples 
on this page that use `client` to refer to a `SshClient`. 

Instead of renaming the `ComputeService` var to `client`, would you be willing 
to rename all of the other `ComputeService` references to `computeService`?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/130#issuecomment-58070966

Re: [jclouds-site] Update compute.md (#130)

2014-10-06 Thread Yaron Rosenbaum 
Sure :)

(Y)

On Oct 6, 2014, at 9:47 PM, Everett Toews notificati...@github.com wrote:

 Thanks for the sharp eyes @yaronr!
 
 I think it's more than slightly confusing considering there are also examples 
 on this page that use client to refer to a SshClient.
 
 Instead of renaming the ComputeService var to client, would you be willing to 
 rename all of the other ComputeService references to computeService?
 
 —
 Reply to this email directly or view it on GitHub.
 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/130#issuecomment-58071193

[jclouds-site] Update compute.md (#130)

2014-10-01 Thread Yaron Rosenbaum 
It#39;s called #39;client#39; and not #39;computeService#39; throughout 
the rest of the examples, so this is slightly confusing
You can merge this Pull Request by running:

  git pull https://github.com/yaronr/jclouds-site patch-2

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-site/pull/130

-- Commit Summary --

  * Update compute.md

-- File Changes --

M start/compute.md (2)

-- Patch Links --

https://github.com/jclouds/jclouds-site/pull/130.patch
https://github.com/jclouds/jclouds-site/pull/130.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/130

Re: [jclouds-site] Update compute.md (#130)

2014-10-01 Thread CloudBees pull request builder plugin 
[jclouds-site-pull-requests 
#402](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/402/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/130#issuecomment-57476422

Re: [jclouds-site] Update compute.md (#130)

2014-10-01 Thread jclouds-commentator 
  Go to 
http://508829307d0fd0fdba93-25ae3b17a4de6eac0e93b4d4ddbe032e.r14.cf5.rackcdn.com/
 to review your changes.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/130#issuecomment-57476863