[jira] [Commented] (OFBIZ-13049) Configurable Main page

2024-05-11 Thread Daniel Watford (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845587#comment-17845587
 ] 

Daniel Watford commented on OFBIZ-13049:


Hi [~pierresmits] 
{quote}Regarding the feedback from Daniel, I repeat what I commented earlier:

I am just utilising what is available OOTB. implemented and reviewed by quite a 
few contributors in the period between 2008 and 2010 (amongst other Bruno 
Busco, David Jones and even you) under ticket OFBIZ-1999 and follow-ups.
{quote}
I don't think you addressed my comment other than saying their is prior-art for 
your suggestion. We also support mini-lang OOTB, but would not encourage its 
use.  A lot has changed in development approaches in the ~15 years since the 
portlets proposed to try and contain definitions of systems as version 
controllable code (e.g. infrastructure-as-code movements).

That being said, I do see frequent use of 'Dashboard Builders' in systems where 
users can build their own dashboards out of 'widgets' to display information to 
meet their needs. But the crucial difference is that these dashboard widgets 
then provide links to standard pages where the users interact with entities. 
The dashboards are a separate concern to the main system screens.
{quote} Introducing another layer of indirection via the database will reduce 
the navigability of the UI further. 

We use data everywhere to showcase the flexibility and usability of OFBiz. The 
user experience (the appeal of OFBiz as an Open Source business management and 
e-commerce solution) is dependent on data.
{quote}
Perhaps you it would help us understand your position if you provide some 
non-portlet examples of how OFBiz uses data to dynamically to affect the user 
experience.

 
{quote}I can imagine that a lot of developers (and their employers) could be 
angry with their customization experience.  

If only they would come forward and would make actionable suggestions (e.g. in 
the form of Jira ticket), the project (and its contributors) would have 
something to work with.
{quote}
Is there any evidence that people are angry with the customisation experience? 
Users/Customisers are unlikely to monitor Jira, but they might raise their 
concerns on the user mailing list if prompted.

However, even if users/customisers did highlight issues, portlets still might 
not be a good solution.

With forthcoming work around REST, I think we might solutions on the 
client-side might offer a customisation route without impacting on server-side 
implementation.

As an example, SharePoint Online offers UI extension points in the 
header/footer of a page where Javascript can render whatever if needs without 
intereferring with SharePoint's own UI implementation - 
https://learn.microsoft.com/en-us/sharepoint/dev/spfx/extensions/overview-extensions

 
{quote}...can be improved by the community in a SMART way.
{quote}
Is SMART an acronym or are you just highlighting the word to try and imply that 
an alternative approach is not smart? Use of the later technique is something 
that really annoys me as they are normally an attempt to shutdown debate. I 
have read the riot act to many a sales person that has begun a sentence with 
'obviously'!

 
{quote}...seems to be something to discuss in dev ML. But IIRW you can't write 
there, right?
{quote}
I think Jacques is right. This topic is too large to discuss in a Jira ticket's 
comments as it will need support from the wider OFBiz developer community which 
utilises the Dev mailing list.

Therefore I think you need to find a way to resolve the matters that currently 
prevent your writing to the dev mailing list before we can progress this topic 
further.

 

> Configurable Main page
> --
>
> Key: OFBIZ-13049
> URL: https://issues.apache.org/jira/browse/OFBIZ-13049
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
> Attachments: CommonPortletData.xml
>
>
> Currently the OFBiz product has configurable Main pages in applications 
> Accounting, Order, SFA, and plugin MyPortal. Unfortunately, none in the 
> community felt the urge to implement the concept further in other 
> applications.
> Having a configurable Main page of an application improves both the appeal of 
> OFBiz to (potential) adopters and their users, and to developers.
> With a configurable Main page, developers have less screens to consider when 
> doing customisation, while at the same time trying to stay in sync with 
> changes from the project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13049) Configurable Main page

2024-05-11 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845567#comment-17845567
 ] 

Pierre Smits commented on OFBIZ-13049:
--

Hi Jacques,

Thank you for your reaction.
{quote}I re-read the comments above where Daniel and Michael were not 
enthusiast.
{quote}
Regarding the feedback from Daniel, I repeat what I commented earlier:
{quote}I am just utilising what is available OOTB. implemented and reviewed by 
quite a few contributors in the period between 2008 and 2010 (amongst other 
Bruno Busco, David Jones and even you) under ticket OFBIZ-1999 and follow-ups.
{quote}
I am *not* introducing different technologies or concepts alien to what is 
already available in the OFBiz. As for
{quote} Introducing another layer of indirection via the database will reduce 
the navigability of the UI further. 
{quote}
We use data everywhere to showcase the flexibility and usability of OFBiz. The 
user experience (the appeal of OFBiz as an Open Source business management and 
e-commerce solution) is dependent on data.

Similarly the customization appeal and experience is affected by hard coded 
aspects. Everywhere we have that, we make it challenging for adopters to apply 
and maintain their customizations without disrupting ongoing updates from the 
OFBiz community. Having application main pages displaying what is most 
important through PortalPortlet and associated records facilitate just that 
flexibility and adaptability. I regard this ticket equally beneficial to 
adopters and their developers as OFBIZ-12928.


{quote}Would you mind to assume this task before we continue with subtasks here?
{quote}
Thank you for the suggestion. I will keep it in mind for future consideration. 
For now, I'm focused on prioritizing straightforward improvements that 
significantly benefit both the user and developer experience. 
Participating in an open source project is as much about enhancing the user and 
developer experience through collaboration as it is about refining the 
codebase. I truly value our positive collaborations I've had in this project 
and look forward to more in the future. 

This means that I don't just create new tickets for myself to work on; I also 
do it to encourage fellow contributors to offer valuable feedback on the matter 
at hand and to engage in the development process.

> Configurable Main page
> --
>
> Key: OFBIZ-13049
> URL: https://issues.apache.org/jira/browse/OFBIZ-13049
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
> Attachments: CommonPortletData.xml
>
>
> Currently the OFBiz product has configurable Main pages in applications 
> Accounting, Order, SFA, and plugin MyPortal. Unfortunately, none in the 
> community felt the urge to implement the concept further in other 
> applications.
> Having a configurable Main page of an application improves both the appeal of 
> OFBiz to (potential) adopters and their users, and to developers.
> With a configurable Main page, developers have less screens to consider when 
> doing customisation, while at the same time trying to stay in sync with 
> changes from the project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13049) Configurable Main page

2024-05-11 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845557#comment-17845557
 ] 

Jacques Le Roux commented on OFBIZ-13049:
-

For instance is not that easier to read:  [^CommonPortletData.xml] 

> Configurable Main page
> --
>
> Key: OFBIZ-13049
> URL: https://issues.apache.org/jira/browse/OFBIZ-13049
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
> Attachments: CommonPortletData.xml
>
>
> Currently the OFBiz product has configurable Main pages in applications 
> Accounting, Order, SFA, and plugin MyPortal. Unfortunately, none in the 
> community felt the urge to implement the concept further in other 
> applications.
> Having a configurable Main page of an application improves both the appeal of 
> OFBiz to (potential) adopters and their users, and to developers.
> With a configurable Main page, developers have less screens to consider when 
> doing customisation, while at the same time trying to stay in sync with 
> changes from the project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-13049) Configurable Main page

2024-05-11 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-13049:

Attachment: CommonPortletData.xml

> Configurable Main page
> --
>
> Key: OFBIZ-13049
> URL: https://issues.apache.org/jira/browse/OFBIZ-13049
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
> Attachments: CommonPortletData.xml
>
>
> Currently the OFBiz product has configurable Main pages in applications 
> Accounting, Order, SFA, and plugin MyPortal. Unfortunately, none in the 
> community felt the urge to implement the concept further in other 
> applications.
> Having a configurable Main page of an application improves both the appeal of 
> OFBiz to (potential) adopters and their users, and to developers.
> With a configurable Main page, developers have less screens to consider when 
> doing customisation, while at the same time trying to stay in sync with 
> changes from the project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-13049) Configurable Main page

2024-05-11 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845546#comment-17845546
 ] 

Jacques Le Roux edited comment on OFBIZ-13049 at 5/11/24 8:00 AM:
--

Hi Pierre,

I re-read the comments above where Daniel and Michael were not enthusiast. This 
happened already with Mathieu and Nicolas in 
https://lists.apache.org/thread/wk0q5m409mm96kqsgymq6fhrsy7j7xvo. And Nicolas 
had a not so postive experience with portals. So there are obviously drawbacks. 
What are the advantages that decided you to use portals?

In this thread, there is a point that held my attention.  Mathieu said:
bq.  In any case providing a precise XML schema for screen/form elements is 
definitely a good idea.
We already have that, that maybe could be improved. But we really miss the same 
for data used to define portals. So I strongly suggest that we create a shema 
for *PortletData.xml files. It should not be hard to create. It would help 
possible customers to create their own portals with a bit of documentation that 
seriously lacks for now. I also note that while adding the reference to a new 
PortletData.xsd in *PortletData.xml files we should correctly format files that 
are difficult to read when needed. CommonPortletData.xml comes to mind. Would 
you mind to assume this task before we continue with subtasks here?

Edit: I just realise that Mathieu was answering to Olivier's idea:
bq. create a widget-portal.xsd


was (Author: jacques.le.roux):
Hi Pierre,

I re-read the comments above where Daniel and Michael were not enthusiast. This 
happened already with Mathieu and Nicolas in 
https://lists.apache.org/thread/wk0q5m409mm96kqsgymq6fhrsy7j7xvo. And Nicolas 
had a not so postive experience with portals. So there are obviously drawbacks. 
What are the advantages that decided you to use portals?

In this thread, there is a point that held my attention.  Mathieu said:
bq.  In any case providing a precise XML schema for screen/form elements is 
definitely a good idea.
We already have that, that maybe could be improved. But we really miss the same 
for data used to define portals. So I strongly suggest that we create a shema 
for *PortletData.xml files. It should not be hard to create. It would help 
possible customers to create their own portals with a bit of documentation that 
seriously lacks for now. I also note that while adding the reference to a new 
PortletData.xsd in *PortletData.xml files we should correctly format files that 
are difficult to read when needed. CommonPortletData.xml comes to mind. Would 
you mind to assume this task before we continue with subtasks here?


> Configurable Main page
> --
>
> Key: OFBIZ-13049
> URL: https://issues.apache.org/jira/browse/OFBIZ-13049
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the OFBiz product has configurable Main pages in applications 
> Accounting, Order, SFA, and plugin MyPortal. Unfortunately, none in the 
> community felt the urge to implement the concept further in other 
> applications.
> Having a configurable Main page of an application improves both the appeal of 
> OFBiz to (potential) adopters and their users, and to developers.
> With a configurable Main page, developers have less screens to consider when 
> doing customisation, while at the same time trying to stay in sync with 
> changes from the project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13054) Marketing-Main page

2024-05-11 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13054.
---
Fix Version/s: Upcoming Branch
 Assignee: Jacques Le Roux
   Resolution: Implemented

> Marketing-Main page
> ---
>
> Key: OFBIZ-13054
> URL: https://issues.apache.org/jira/browse/OFBIZ-13054
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Screenshot 2024-05-08 at 08.41.28.png, Screenshot 
> 2024-05-08 at 08.47.24.png
>
>
> Currently the 'main' view-map points to a screen showing a label, see the 
> first attached image.
>  
> In order to improve the user experience the main request-map and view-map 
> should show what is most pressing in marketing to address: active campaigns 
> and contact list communication events. See the second attached image



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-11 Thread via GitHub


PierreSmits commented on PR #785:
URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2105623501

   Hi Jacques,
   
   Thanks for fixing the typo. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (OFBIZ-13054) Marketing-Main page

2024-05-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845553#comment-17845553
 ] 

ASF subversion and git services commented on OFBIZ-13054:
-

Commit f5aad6669e03fde5963eab2d2791403bed29da51 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f5aad6669e ]

Improved: Marketing-Main page (OFBIZ-13054) (#785)

* Improved: Marketing-Main page (OFBIZ-13054)

Currently the 'main' view-map points to a screen showing a label
In order to improve the user experience the main request-map and view-map 
should show what is most pressing in marketing to address: active campaigns and 
contact list communication events.

added:
- MarketingPortletData.xml, having record definitions for PortalPage, Portlet, 
etc

modified::
- ofbiz-component.xml: added data loader for MarketingPortletData.xml
- controller.xml: changed view-map 'main' to point to screen Main in 
CommonScreens.xml
- CommonScreens.xml: screen Main displaying a PortalPage
- MarketingCampaignScreens.xml: adding screen Campaigns for active campaigns
- MarketingCampaignForms.xml: adding grid Campaigns to list active campaigns
- ContactListScreens.xml: adding screen CommEvents for active communication 
events
- ContactListForms.xml: adding grid Campaigns to list active communication 
events

* Improved: Marketing-Main page (OFBIZ-13054)

Currently the 'main' view-map points to a screen showing a label
In order to improve the user experience the main request-map and view-map 
should show what is most pressing in marketing to address: active campaigns and 
contact list communication events.

modified:
- CommonScreens.xml: clean-up
- MarketingCampaignForms: added ref.data elements

* OFBIZ-13054

cleanup

* Imrproved: Marketing Main Page (OFBIZ-13054)

removed trailing spaces

* Update ofbiz-component.xml

Fixes a typo

-

Co-authored-by: Jacques Le Roux 

> Marketing-Main page
> ---
>
> Key: OFBIZ-13054
> URL: https://issues.apache.org/jira/browse/OFBIZ-13054
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pierre Smits
>Priority: Major
> Attachments: Screenshot 2024-05-08 at 08.41.28.png, Screenshot 
> 2024-05-08 at 08.47.24.png
>
>
> Currently the 'main' view-map points to a screen showing a label, see the 
> first attached image.
>  
> In order to improve the user experience the main request-map and view-map 
> should show what is most pressing in marketing to address: active campaigns 
> and contact list communication events. See the second attached image



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-11 Thread via GitHub


JacquesLeRoux merged PR #785:
URL: https://github.com/apache/ofbiz-framework/pull/785


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-11 Thread via GitHub


sonarcloud[bot] commented on PR #785:
URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2105615680

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=785)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=785=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=785=new_accepted_issues=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=785=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=785=new_duplicated_lines_density=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=785)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-11 Thread via GitHub


JacquesLeRoux commented on PR #785:
URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2105615193

   Hi,
   
   About the error above where git diff did not give any information
   ```
   error: applications/marketing/data/MarketingPortletData.xml: already exists 
in working directory
   C:\projectsASF\Git\ofbiz-framework>git diff
   C:\projectsASF\Git\ofbiz-framework>
   ```
   I know now what happened. As I said 
   > The patch does no apply in Elipse nor with git apply
   
   I actually tried with Eclipse before and did not notice that 
MarketingPortletData.xml was already there but not added.
   
   Now we have
   > C:\projectsASF\Git\ofbiz-framework>git apply 785.patch
   > 785.patch:70: trailing whitespace.
   >  785.patch:71: trailing whitespace.
   > description="The main portal page of the marketing application"
   > warning: 2 lines add whitespace errors.
   > 
   You can neglect, it's OK (new lines, no trailing whitespaces)
   
   About
   ```
   -
   +
   -
   +
   ```
   Not needed. In current code 29 `` vs 7 `` But maybe simple for you, not a pb finally.
   
   More important is this Typo (N/M)
   ``
   You see that's the brittle of portals. I also remember a space at head of a 
portal reference not bing easy to find.
   
   Anyway tests are OK and I agree it's a good improvement. Though that could 
have been done with no new data in DB, isn't?
   
   I'll  fix the typo and push. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (OFBIZ-13049) Configurable Main page

2024-05-11 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845546#comment-17845546
 ] 

Jacques Le Roux commented on OFBIZ-13049:
-

Hi Pierre,

I re-read the comments above where Daniel and Michael were not enthusiast. This 
happened already with Mathieu and Nicolas in 
https://lists.apache.org/thread/wk0q5m409mm96kqsgymq6fhrsy7j7xvo. And Nicolas 
had a not so postive experience with portals. So there are obviously drawbacks. 
What are the advantages that decided you to use portals?

In this thread, there is a point that held my attention.  Mathieu said:
bq.  In any case providing a precise XML schema for screen/form elements is 
definitely a good idea.
We already have that, that maybe could be improved. But we really miss the same 
for data used to define portals. So I strongly suggest that we create a shema 
for *PortletData.xml files. It should not be hard to create. It would help 
possible customers to create their own portals with a bit of documentation that 
seriously lacks for now. I also note that while adding the reference to a new 
PortletData.xsd in *PortletData.xml files we should correctly format files that 
are difficult to read when needed. CommonPortletData.xml comes to mind. Would 
you mind to assume this task before we continue with subtasks here?


> Configurable Main page
> --
>
> Key: OFBIZ-13049
> URL: https://issues.apache.org/jira/browse/OFBIZ-13049
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the OFBiz product has configurable Main pages in applications 
> Accounting, Order, SFA, and plugin MyPortal. Unfortunately, none in the 
> community felt the urge to implement the concept further in other 
> applications.
> Having a configurable Main page of an application improves both the appeal of 
> OFBiz to (potential) adopters and their users, and to developers.
> With a configurable Main page, developers have less screens to consider when 
> doing customisation, while at the same time trying to stay in sync with 
> changes from the project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)