[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized

2024-05-18 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847600#comment-17847600
 ] 

Pierre Smits commented on OFBIZ-12951:
--

Hi Jacques,

With the latest addition to the pull-request we can finally put the issue to 
rest. Adding a MainActionMenu to Menus.xml in ofbizsetup, that extends the same 
in PartyMenus.xml resolves the issue.

Anyway, thank you for your time and diligence.

> CommonExt - Move from hard-code menu location to parameterized
> --
>
> Key: OFBIZ-12951
> URL: https://issues.apache.org/jira/browse/OFBIZ-12951
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Screenshot 2024-05-05 at 20.32.11.png, Screenshot 
> 2024-05-13 at 12.18.38.png
>
>
> Move the menu location in the various commonest screens from hard-coded to 
> parameterized.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) [ofbiz-framework]

2024-05-18 Thread via GitHub


sonarcloud[bot] commented on PR #795:
URL: https://github.com/apache/ofbiz-framework/pull/795#issuecomment-2118995653

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=795)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=795=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=795=WONTFIX)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=795=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=795=new_duplicated_lines_density=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=795)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized

2024-05-18 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847568#comment-17847568
 ] 

Jacques Le Roux commented on OFBIZ-12951:
-

Hi Pierre,

It's not 79 but 795.

After applying this PR (795) as a patch in Eclipse I still get the same UI 
error message and this is in log running 
https://localhost:8443/ofbizsetup/control/login
2024-05-18 18:09:45,948 |jsse-nio-8443-exec-2 |ModelScreenWidget 
|E| Error rendering included menu named [MainActionMenu] at location 
[component://commonext/widget/ofbizsetup/Menus.xml]:
java.lang.IllegalArgumentException: Could not find menu with name 
[MainActionMenu] in location [component://commonext/widget/ofbizsetup/Menus.xml]
at 
org.apache.ofbiz.widget.model.MenuFactory.getMenuFromLocation(MenuFactory.java:122)
 ~[main/:?]

But then getting to https://localhost:8443/ofbizsetup/control/main works (all 
menus OK)

If I stop OFBiz and restart it, getting to https://localhost:8443/ofbizsetup 
fails again. But then using the visible menus works, weird. I did not get 
further.

> CommonExt - Move from hard-code menu location to parameterized
> --
>
> Key: OFBIZ-12951
> URL: https://issues.apache.org/jira/browse/OFBIZ-12951
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Screenshot 2024-05-05 at 20.32.11.png, Screenshot 
> 2024-05-13 at 12.18.38.png
>
>
> Move the menu location in the various commonest screens from hard-coded to 
> parameterized.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OFBIZ-13013) Improve the condition for fetching the currencyUomId while requesting to create a shipment on FedEx

2024-05-18 Thread Devanshu Vyas (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Devanshu Vyas reassigned OFBIZ-13013:
-

Assignee: Devanshu Vyas

> Improve the condition for fetching the currencyUomId while requesting to 
> create a shipment on FedEx
> ---
>
> Key: OFBIZ-13013
> URL: https://issues.apache.org/jira/browse/OFBIZ-13013
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Upcoming Branch
>Reporter: Sandeep Rajput
>Assignee: Devanshu Vyas
>Priority: Minor
>
> Improve the condition for fetching the currencyUomId while requesting to 
> create a shipment on FedEx



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Improved: Corrected the condition to fetch currency UOM id from shipment instead of shipment route segment [ofbiz-framework]

2024-05-18 Thread via GitHub


vyasdevanshu merged PR #801:
URL: https://github.com/apache/ofbiz-framework/pull/801


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: Corrected the condition to fetch currency UOM id from shipment instead of shipment route segment [ofbiz-framework]

2024-05-18 Thread via GitHub


sonarcloud[bot] commented on PR #801:
URL: https://github.com/apache/ofbiz-framework/pull/801#issuecomment-2118749666

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=801)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=801=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=801=WONTFIX)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=801=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Duplication  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=801)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Improved: Corrected the condition to fetch currency UOM id from shipment instead of shipment route segment [ofbiz-framework]

2024-05-18 Thread via GitHub


SandeepRajput20 opened a new pull request, #801:
URL: https://github.com/apache/ofbiz-framework/pull/801

   There is a typo in the condition while fetching a currency UOM id from the 
shipment route segment entity instead of shipment at the time of creating a 
shipment on the FedEx carrier.
   
   Improved:Corrected the condition to fetch currency UOM id from shipment 
instead of shipment route segment
   (OFBIZ-13013)
   
   Explanation
   
   Thanks:
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (OFBIZ-13093) Payment to Supplier with non default currency generates an error

2024-05-18 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-13093:


 Summary: Payment to Supplier with non default currency generates 
an error
 Key: OFBIZ-13093
 URL: https://issues.apache.org/jira/browse/OFBIZ-13093
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: 18.12.13
Reporter: Pierre Smits


When creating a payment to a supplier that has a different currency than 
default for the OFBiz setup (in demo stable: EuroSupplier, following error is 
shown:


{code:java}
The Following Errors Occurred:Exception thrown while creating the "payment" 
GenericValue: org.apache.ofbiz.entity.GenericEntityException: Error while 
inserting: 
[GenericEntity:Payment][amount,100(java.math.BigDecimal)][comments,paper 
toner(java.lang.String)][createdStamp,2024-05-18 
07:35:11.375(java.sql.Timestamp)][createdTxStamp,2024-05-18 
07:35:11.35(java.sql.Timestamp)][currencyUomId,USD(java.lang.String)][effectiveDate,2024-05-18
 07:35:11.375(java.sql.Timestamp)][lastUpdatedStamp,2024-05-18 
07:35:11.375(java.sql.Timestamp)][lastUpdatedTxStamp,2024-05-18 
07:35:11.35(java.sql.Timestamp)][overrideGlAccountId,null()][partyIdFrom,Company(java.lang.String)][partyIdTo,euro(java.lang.String)][paymentId,10001(java.lang.String)][paymentMethodId,ABN_CHECKING(java.lang.String)][paymentMethodTypeId,COMPANY_CHECK(java.lang.String)][paymentRefNum,1(java.lang.String)][paymentTypeId,VENDOR_PAYMENT(java.lang.String)][statusId,PMNT_NOT_PAID(java.lang.String)]
 (SQL Exception while executing the following:INSERT INTO OFBIZ.PAYMENT 
(PAYMENT_ID, PAYMENT_TYPE_ID, PAYMENT_METHOD_TYPE_ID, PAYMENT_METHOD_ID, 
PAYMENT_GATEWAY_RESPONSE_ID, PAYMENT_PREFERENCE_ID, PARTY_ID_FROM, PARTY_ID_TO, 
ROLE_TYPE_ID_TO, STATUS_ID, EFFECTIVE_DATE, PAYMENT_REF_NUM, AMOUNT, 
CURRENCY_UOM_ID, COMMENTS, FIN_ACCOUNT_TRANS_ID, OVERRIDE_GL_ACCOUNT_ID, 
ACTUAL_CURRENCY_AMOUNT, ACTUAL_CURRENCY_UOM_ID, LAST_UPDATED_STAMP, 
LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, 
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 
'PAYMENT' caused a violation of foreign key constraint 'PAYMENT_TPTY' for key 
(euro). The statement has been rolled back.)) (Error while inserting: 
[GenericEntity:Payment][amount,100(java.math.BigDecimal)][comments,paper 
toner(java.lang.String)][createdStamp,2024-05-18 
07:35:11.375(java.sql.Timestamp)][createdTxStamp,2024-05-18 
07:35:11.35(java.sql.Timestamp)][currencyUomId,USD(java.lang.String)][effectiveDate,2024-05-18
 07:35:11.375(java.sql.Timestamp)][lastUpdatedStamp,2024-05-18 
07:35:11.375(java.sql.Timestamp)][lastUpdatedTxStamp,2024-05-18 
07:35:11.35(java.sql.Timestamp)][overrideGlAccountId,null()][partyIdFrom,Company(java.lang.String)][partyIdTo,euro(java.lang.String)][paymentId,10001(java.lang.String)][paymentMethodId,ABN_CHECKING(java.lang.String)][paymentMethodTypeId,COMPANY_CHECK(java.lang.String)][paymentRefNum,1(java.lang.String)][paymentTypeId,VENDOR_PAYMENT(java.lang.String)][statusId,PMNT_NOT_PAID(java.lang.String)]
 (SQL Exception while executing the following:INSERT INTO OFBIZ.PAYMENT 
(PAYMENT_ID, PAYMENT_TYPE_ID, PAYMENT_METHOD_TYPE_ID, PAYMENT_METHOD_ID, 
PAYMENT_GATEWAY_RESPONSE_ID, PAYMENT_PREFERENCE_ID, PARTY_ID_FROM, PARTY_ID_TO, 
ROLE_TYPE_ID_TO, STATUS_ID, EFFECTIVE_DATE, PAYMENT_REF_NUM, AMOUNT, 
CURRENCY_UOM_ID, COMMENTS, FIN_ACCOUNT_TRANS_ID, OVERRIDE_GL_ACCOUNT_ID, 
ACTUAL_CURRENCY_AMOUNT, ACTUAL_CURRENCY_UOM_ID, LAST_UPDATED_STAMP, 
LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, 
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 
'PAYMENT' caused a violation of foreign key constraint 'PAYMENT_TPTY' for key 
(euro). The statement has been rolled back.))) {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized

2024-05-18 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847264#comment-17847264
 ] 

Pierre Smits edited comment on OFBIZ-12951 at 5/18/24 6:55 AM:
---

HI [~jleroux] ,

with the latest update to PR#795, the issue in demo-trunk is now fixed.


was (Author: pfm.smits):
HI [~jleroux] ,

with the latest update to PR#79, the issue in demo-trunk is now fixed.

> CommonExt - Move from hard-code menu location to parameterized
> --
>
> Key: OFBIZ-12951
> URL: https://issues.apache.org/jira/browse/OFBIZ-12951
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Screenshot 2024-05-05 at 20.32.11.png, Screenshot 
> 2024-05-13 at 12.18.38.png
>
>
> Move the menu location in the various commonest screens from hard-coded to 
> parameterized.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)