[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847635#comment-17847635 ] ASF subversion and git services commented on OFBIZ-12951: - Commit 24d42f3be2913b33543c77ae8323dc5a98d9cbe7 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=24d42f3be2 ] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) (#795) * Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) ofbizsetup uses profile screens from partymgr. modified web.xml - added profileMenuLocation * OFBIZ-12951 Fix dependency on party ofbizsetup is dependent on party elements modified: commonext - web.xml: added new context-param for createNewParty menu modified: party - web.xml: added new context-param for createNewParty menu - PartyScreens.xml: changed location createNewParty menu reference * Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) modified: Menus.xml - added MainActionMenu extending MainActionMenu in PartyMenus.xml > CommonExt - Move from hard-code menu location to parameterized > -- > > Key: OFBIZ-12951 > URL: https://issues.apache.org/jira/browse/OFBIZ-12951 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: Screenshot 2024-05-05 at 20.32.11.png, Screenshot > 2024-05-13 at 12.18.38.png > > > Move the menu location in the various commonest screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847600#comment-17847600 ] Pierre Smits commented on OFBIZ-12951: -- Hi Jacques, With the latest addition to the pull-request we can finally put the issue to rest. Adding a MainActionMenu to Menus.xml in ofbizsetup, that extends the same in PartyMenus.xml resolves the issue. Anyway, thank you for your time and diligence. > CommonExt - Move from hard-code menu location to parameterized > -- > > Key: OFBIZ-12951 > URL: https://issues.apache.org/jira/browse/OFBIZ-12951 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: Screenshot 2024-05-05 at 20.32.11.png, Screenshot > 2024-05-13 at 12.18.38.png > > > Move the menu location in the various commonest screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847568#comment-17847568 ] Jacques Le Roux commented on OFBIZ-12951: - Hi Pierre, It's not 79 but 795. After applying this PR (795) as a patch in Eclipse I still get the same UI error message and this is in log running https://localhost:8443/ofbizsetup/control/login 2024-05-18 18:09:45,948 |jsse-nio-8443-exec-2 |ModelScreenWidget |E| Error rendering included menu named [MainActionMenu] at location [component://commonext/widget/ofbizsetup/Menus.xml]: java.lang.IllegalArgumentException: Could not find menu with name [MainActionMenu] in location [component://commonext/widget/ofbizsetup/Menus.xml] at org.apache.ofbiz.widget.model.MenuFactory.getMenuFromLocation(MenuFactory.java:122) ~[main/:?] But then getting to https://localhost:8443/ofbizsetup/control/main works (all menus OK) If I stop OFBiz and restart it, getting to https://localhost:8443/ofbizsetup fails again. But then using the visible menus works, weird. I did not get further. > CommonExt - Move from hard-code menu location to parameterized > -- > > Key: OFBIZ-12951 > URL: https://issues.apache.org/jira/browse/OFBIZ-12951 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: Screenshot 2024-05-05 at 20.32.11.png, Screenshot > 2024-05-13 at 12.18.38.png > > > Move the menu location in the various commonest screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847264#comment-17847264 ] Pierre Smits commented on OFBIZ-12951: -- HI [~jleroux] , with the latest update to PR#79, the issue in demo-trunk is now fixed. > CommonExt - Move from hard-code menu location to parameterized > -- > > Key: OFBIZ-12951 > URL: https://issues.apache.org/jira/browse/OFBIZ-12951 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: Screenshot 2024-05-05 at 20.32.11.png, Screenshot > 2024-05-13 at 12.18.38.png > > > Move the menu location in the various commonest screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845870#comment-17845870 ] Pierre Smits commented on OFBIZ-12951: -- Hi Jacques, Yes, I did. And I am still investigating. If you could merge PR#795, it would surely help (see attached image), as switching between trunk and dev/test branches in the local dev environment is cumbersome and a potential source of confusion. > CommonExt - Move from hard-code menu location to parameterized > -- > > Key: OFBIZ-12951 > URL: https://issues.apache.org/jira/browse/OFBIZ-12951 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: Screenshot 2024-05-05 at 20.32.11.png > > > Move the menu location in the various commonest screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845859#comment-17845859 ] Jacques Le Roux commented on OFBIZ-12951: - Hi Pierre, Did you get a chance to have a look at this bug? > CommonExt - Move from hard-code menu location to parameterized > -- > > Key: OFBIZ-12951 > URL: https://issues.apache.org/jira/browse/OFBIZ-12951 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: Screenshot 2024-05-05 at 20.32.11.png > > > Move the menu location in the various commonest screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized
[
https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843581#comment-17843581
]
Pierre Smits commented on OFBIZ-12951:
--
This is weird: when opening ofbizsetup in a new browser session (after a
cleanAll / loadAll of the server) I get the following attached image.
The image shows the inspect section of the Mozilla browser with following code
{code:java}
{code}
More digging down the rabbit's hole
> CommonExt - Move from hard-code menu location to parameterized
> --
>
> Key: OFBIZ-12951
> URL: https://issues.apache.org/jira/browse/OFBIZ-12951
> Project: OFBiz
> Issue Type: Sub-task
> Components: commonext
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Screenshot 2024-05-05 at 20.32.11.png
>
>
> Move the menu location in the various commonest screens from hard-coded to
> parameterized.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843426#comment-17843426 ] Jacques Le Roux commented on OFBIZ-12951: - BTW did you see OFBIZ-13080? > CommonExt - Move from hard-code menu location to parameterized > -- > > Key: OFBIZ-12951 > URL: https://issues.apache.org/jira/browse/OFBIZ-12951 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Move the menu location in the various commonest screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843425#comment-17843425 ] Jacques Le Roux commented on OFBIZ-12951: - After closing https://issues.apache.org/jira/browse/OFBIZ-13005 I just daily follow the demo error.logs. They have much to say, less and less fortunately. > CommonExt - Move from hard-code menu location to parameterized > -- > > Key: OFBIZ-12951 > URL: https://issues.apache.org/jira/browse/OFBIZ-12951 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Move the menu location in the various commonest screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843413#comment-17843413 ] Pierre Smits commented on OFBIZ-12951: -- Hi [~jleroux]< I have added PR#795 that fixes the issue. Are you on a bug hunt? > CommonExt - Move from hard-code menu location to parameterized > -- > > Key: OFBIZ-12951 > URL: https://issues.apache.org/jira/browse/OFBIZ-12951 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Move the menu location in the various commonest screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843410#comment-17843410 ] Pierre Smits commented on OFBIZ-12951: -- Thanks @[~jleroux] I will look into this. > CommonExt - Move from hard-code menu location to parameterized > -- > > Key: OFBIZ-12951 > URL: https://issues.apache.org/jira/browse/OFBIZ-12951 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Move the menu location in the various commonest screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828340#comment-17828340 ] Pierre Smits commented on OFBIZ-12951: -- Thanks Jacques. > CommonExt - Move from hard-code menu location to parameterized > -- > > Key: OFBIZ-12951 > URL: https://issues.apache.org/jira/browse/OFBIZ-12951 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Move the menu location in the various commonest screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828311#comment-17828311 ] ASF subversion and git services commented on OFBIZ-12951: - Commit a9fc12b902a7faa8c077e10dfd95012b3becb9da in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a9fc12b902 ] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) (#734) Move the menu location in various commonext screens from hard-coded to parameterized. modified re ofbizsetup: - web.xml - added context-param for mainMenuLocation - CommonScreens.xml - SetupScreens.xml > CommonExt - Move from hard-code menu location to parameterized > -- > > Key: OFBIZ-12951 > URL: https://issues.apache.org/jira/browse/OFBIZ-12951 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Reporter: Pierre Smits >Priority: Major > > Move the menu location in the various commonest screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
