Re: [Nut-upsdev] UPower: 95-upower-hid.rules update

2015-07-29 Thread Richard Hughes
On 22 June 2015 at 14:14, Arnaud Quette arnaud.que...@gmail.com wrote:
 here is the patch, before I completly forgot.

I've pushed this, thanks.

Richard.

___
Nut-upsdev mailing list
Nut-upsdev@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev


Re: [Nut-upsdev] UPower: 95-upower-hid.rules update

2015-06-22 Thread Arnaud Quette
Hello Bastien,

2015-06-08 15:07 GMT+02:00 Arnaud Quette arnaud.que...@gmail.com:



 2015-06-08 13:06 GMT+02:00 Bastien Nocera had...@hadess.net:

 On Mon, 2015-06-08 at 09:45 +0200, Arnaud Quette wrote:
 
 
  2015-06-04 13:04 GMT+02:00 Bastien Nocera had...@hadess.net:
   On Sat, 2015-05-30 at 18:51 +0200, Arnaud Quette wrote:
   
   
2015-05-29 14:09 GMT+02:00 Bastien Nocera had...@hadess.net:
 On Fri, 2015-05-29 at 13:59 +0200, Arnaud Quette wrote:
  Hi Richard and the list,
 
  you'll find attached a patch for 95-upower-hid.rules, which
   adds:
  - the usbmisc filtering, as added in your repo,
  - more comments, including one that points at your UPower
   repo,
  - 3 new manufacturers (Minibox, iDowell and Powerware)
  - a bunch of new devices (7 HP,  1 APC, 1 TrippLite, 2
   PowerCOM
 and 2
  Liebert)

 Could you please split those changes into 3 separate patches?
   
since you already have the usbmisc, I can possibly check to
   split
in 2 commits (1 for the comments, and 1 for the content update).
would that suits you that way?
  
   Sure.
  
  It would also be useful to include a full URL to the NUT Perl
 script
 (to a git repository perhaps), so people don't need to check
   out
 the
 full repo to update it.

as per Charles comments, beside from the perl script, you need
   all
the drivers/*hid.c files to extract the USB info.
the added comment was just to shed light on the fact that it's an
automated data extraction.
I can reword to make it more clear if you want.
  
   Just changing the path to project page URL + the path would be fine
   (that means that somebody unfamiliar with NUT's upstream can
   actually
   find the scripts to update this file).
  
  Prior to pushing the changes in NUT and to generate the patches for
  UPower, does the below header suit you:
 
  # Uninterruptible Power Supplies with USB HID interfaces
  #
  # http://cgit.freedesktop.org/upower/tree/rules/95-upower-hid.rules

 That bit isn't necessary.


 if you don't mind, I would prefer to keep it somewhere, just to remember
 (from a NUT point of view) where the upower repos. (and that file) is.
 so, not necessary, but useful for the NUT side...


  #
  # This file was automatically generated by NUT:
  # https://github.com/networkupstools/nut/
  #
  # To keep up to date, monitor upstream NUT
  #
 https://github.com/networkupstools/nut/commits/master/scripts/upower/95-
  upower-hid.rules
  # or checkout the NUT repository and call 'tools/nut-usbinfo.pl'
 
  Or do you see any other better wording?

 The rest is fine.


 ok, thanks.

 I'll just wait for your ack on the above UPower repos. point, to push the
 remaining commit.


here is the patch, before I completly forgot.
Not that I've removed the pointer to UPower git repository, as you wanted.

Cheers,
Arno
-- 
Eaton Data Center Automation - Opensource Leader
NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.fr


0001-Fix-HID-rules-header-as-per-discussions.patch
Description: Binary data
___
Nut-upsdev mailing list
Nut-upsdev@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev

Re: [Nut-upsdev] UPower: 95-upower-hid.rules update

2015-06-08 Thread Arnaud Quette
Salut Bastien

2015-06-04 13:04 GMT+02:00 Bastien Nocera had...@hadess.net:

 On Sat, 2015-05-30 at 18:51 +0200, Arnaud Quette wrote:
 
 
  2015-05-29 14:09 GMT+02:00 Bastien Nocera had...@hadess.net:
   On Fri, 2015-05-29 at 13:59 +0200, Arnaud Quette wrote:
Hi Richard and the list,
   
you'll find attached a patch for 95-upower-hid.rules, which adds:
- the usbmisc filtering, as added in your repo,
- more comments, including one that points at your UPower repo,
- 3 new manufacturers (Minibox, iDowell and Powerware)
- a bunch of new devices (7 HP,  1 APC, 1 TrippLite, 2 PowerCOM
   and 2
Liebert)
  
   Could you please split those changes into 3 separate patches?
 
  since you already have the usbmisc, I can possibly check to split
  in 2 commits (1 for the comments, and 1 for the content update).
  would that suits you that way?

 Sure.


please find attached the first patch, addressing the added devices.
I'll send the comments update patch once you ack'ed my previous message.

cheers,
Arno
-- 
Eaton Data Center Automation - Opensource Leader
NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.fr


0001-Update-UPower-HID-rules-supported-devices-list.patch
Description: Binary data
___
Nut-upsdev mailing list
Nut-upsdev@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev

Re: [Nut-upsdev] UPower: 95-upower-hid.rules update

2015-06-08 Thread Arnaud Quette
2015-06-04 13:04 GMT+02:00 Bastien Nocera had...@hadess.net:

 On Sat, 2015-05-30 at 18:51 +0200, Arnaud Quette wrote:
 
 
  2015-05-29 14:09 GMT+02:00 Bastien Nocera had...@hadess.net:
   On Fri, 2015-05-29 at 13:59 +0200, Arnaud Quette wrote:
Hi Richard and the list,
   
you'll find attached a patch for 95-upower-hid.rules, which adds:
- the usbmisc filtering, as added in your repo,
- more comments, including one that points at your UPower repo,
- 3 new manufacturers (Minibox, iDowell and Powerware)
- a bunch of new devices (7 HP,  1 APC, 1 TrippLite, 2 PowerCOM
   and 2
Liebert)
  
   Could you please split those changes into 3 separate patches?
 
  since you already have the usbmisc, I can possibly check to split
  in 2 commits (1 for the comments, and 1 for the content update).
  would that suits you that way?

 Sure.

It would also be useful to include a full URL to the NUT Perl
   script
   (to a git repository perhaps), so people don't need to check out
   the
   full repo to update it.
  
  as per Charles comments, beside from the perl script, you need all
  the drivers/*hid.c files to extract the USB info.
  the added comment was just to shed light on the fact that it's an
  automated data extraction.
  I can reword to make it more clear if you want.

 Just changing the path to project page URL + the path would be fine
 (that means that somebody unfamiliar with NUT's upstream can actually
 find the scripts to update this file).


Prior to pushing the changes in NUT and to generate the patches for UPower,
does the below header suit you:

# Uninterruptible Power Supplies with USB HID interfaces
#
# http://cgit.freedesktop.org/upower/tree/rules/95-upower-hid.rules
#
# This file was automatically generated by NUT:
# https://github.com/networkupstools/nut/
#
# To keep up to date, monitor upstream NUT
#
https://github.com/networkupstools/nut/commits/master/scripts/upower/95-upower-hid.rules
# or checkout the NUT repository and call 'tools/nut-usbinfo.pl'

Or do you see any other better wording?

thanks and cheers,
Arno
-- 
Eaton Data Center Automation - Opensource Leader
NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.fr
___
Nut-upsdev mailing list
Nut-upsdev@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev

Re: [Nut-upsdev] UPower: 95-upower-hid.rules update

2015-06-08 Thread Bastien Nocera
On Mon, 2015-06-08 at 09:45 +0200, Arnaud Quette wrote:
 
 
 2015-06-04 13:04 GMT+02:00 Bastien Nocera had...@hadess.net:
  On Sat, 2015-05-30 at 18:51 +0200, Arnaud Quette wrote:
  
  
   2015-05-29 14:09 GMT+02:00 Bastien Nocera had...@hadess.net:
On Fri, 2015-05-29 at 13:59 +0200, Arnaud Quette wrote:
 Hi Richard and the list,

 you'll find attached a patch for 95-upower-hid.rules, which 
  adds:
 - the usbmisc filtering, as added in your repo,
 - more comments, including one that points at your UPower 
  repo,
 - 3 new manufacturers (Minibox, iDowell and Powerware)
 - a bunch of new devices (7 HP,  1 APC, 1 TrippLite, 2 
  PowerCOM
and 2
 Liebert)
   
Could you please split those changes into 3 separate patches?
  
   since you already have the usbmisc, I can possibly check to 
  split
   in 2 commits (1 for the comments, and 1 for the content update).
   would that suits you that way?
  
  Sure.
  
 It would also be useful to include a full URL to the NUT Perl
script
(to a git repository perhaps), so people don't need to check 
  out
the
full repo to update it.
   
   as per Charles comments, beside from the perl script, you need 
  all
   the drivers/*hid.c files to extract the USB info.
   the added comment was just to shed light on the fact that it's an
   automated data extraction.
   I can reword to make it more clear if you want.
  
  Just changing the path to project page URL + the path would be fine
  (that means that somebody unfamiliar with NUT's upstream can 
  actually
  find the scripts to update this file).
  
 Prior to pushing the changes in NUT and to generate the patches for 
 UPower, does the below header suit you:
 
 # Uninterruptible Power Supplies with USB HID interfaces
 #
 # http://cgit.freedesktop.org/upower/tree/rules/95-upower-hid.rules

That bit isn't necessary.

 #
 # This file was automatically generated by NUT:
 # https://github.com/networkupstools/nut/
 # 
 # To keep up to date, monitor upstream NUT
 # https://github.com/networkupstools/nut/commits/master/scripts/upower/95-
 upower-hid.rules
 # or checkout the NUT repository and call 'tools/nut-usbinfo.pl'
 
 Or do you see any other better wording?

The rest is fine.

Cheers


___
Nut-upsdev mailing list
Nut-upsdev@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev


Re: [Nut-upsdev] UPower: 95-upower-hid.rules update

2015-06-08 Thread Arnaud Quette
2015-06-08 13:09 GMT+02:00 Bastien Nocera had...@hadess.net:

 On Mon, 2015-06-08 at 10:13 +0200, Arnaud Quette wrote:
  -ATTRS{idVendor}==06da, ENV{UPOWER_VENDOR}=Liebert
 
  +ATTRS{idVendor}==06da, ENV{UPOWER_VENDOR}=Phoenixtec Power Co., Ltd

 I'm guessing this would require changes in NUT, so I should mention I
 don't like that change. Maybe:
 +ATTRS{idVendor}==06da, ENV{UPOWER_VENDOR}=Phoenixtec Power
 would be better? The names are supposed to be human readable.


though I see your rationales behind that comments, this is not NUT-only,
but also tied to usb.ids and devices USB strings and maintenance / cross
linking info:
https://usb-ids.gowdy.us/read/UD/06da

Note that such change would not make it more human readable, it's just a
truncation ;)
So I'm not in favor of changing this.

cheers,
Arno
-- 
Eaton Data Center Automation - Opensource Leader
NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.fr
___
Nut-upsdev mailing list
Nut-upsdev@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev

Re: [Nut-upsdev] UPower: 95-upower-hid.rules update

2015-06-08 Thread Bastien Nocera
On Mon, 2015-06-08 at 10:13 +0200, Arnaud Quette wrote:
 -ATTRS{idVendor}==06da, ENV{UPOWER_VENDOR}=Liebert
 
 +ATTRS{idVendor}==06da, ENV{UPOWER_VENDOR}=Phoenixtec Power Co., Ltd

I'm guessing this would require changes in NUT, so I should mention I
don't like that change. Maybe:
+ATTRS{idVendor}==06da, ENV{UPOWER_VENDOR}=Phoenixtec Power
would be better? The names are supposed to be human readable.

Cheers

___
Nut-upsdev mailing list
Nut-upsdev@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev


Re: [Nut-upsdev] UPower: 95-upower-hid.rules update

2015-06-08 Thread Arnaud Quette
2015-06-08 14:07 GMT+02:00 Bastien Nocera had...@hadess.net:

 On Mon, 2015-06-08 at 13:21 +0200, Arnaud Quette wrote:
 
 
  2015-06-08 13:09 GMT+02:00 Bastien Nocera had...@hadess.net:
   On Mon, 2015-06-08 at 10:13 +0200, Arnaud Quette wrote:
-ATTRS{idVendor}==06da, ENV{UPOWER_VENDOR}=Liebert
   
+ATTRS{idVendor}==06da, ENV{UPOWER_VENDOR}=Phoenixtec Power
   Co., Ltd
  
   I'm guessing this would require changes in NUT, so I should mention
   I
   don't like that change. Maybe:
   +ATTRS{idVendor}==06da, ENV{UPOWER_VENDOR}=Phoenixtec Power
   would be better? The names are supposed to be human readable.
  though I see your rationales behind that comments, this is not NUT
  -only, but also tied to usb.ids and devices USB strings and
  maintenance / cross linking info:
  https://usb-ids.gowdy.us/read/UD/06da
 
  Note that such change would not make it more human readable, it's
  just a truncation ;)
  So I'm not in favor of changing this.

 Actually, shouldn't it say Eaton now:
 http://www.eaton.com/Eaton/OurCompany/NewsEvents/NewsReleases/CT_141334
 ?


well, yes and no (une réponse de Breton as we say in French ;))
same as for MGE | Powerware | Best | Deltec | Sola | ...(very long list of
acquisition).
The difference here, for the sake of completion, is that PTec (short name)
or actually Centralion (same company, but different division) is
manufacturing OEM products, that are then just rebranded by Liebert, Mustek
and numerous other brands, depending on the considered timeframe.


 It's also named simply Phoenixtec in the NUT docs:
 http://www.networkupstools.org/protocols/sola.html


sure, there is still some du cleanup there ;)

Anyway.


so, works for you as is?!
thanks for your understanding.

cheers,
Arno
-- 
Eaton Data Center Automation - Opensource Leader
NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.fr
___
Nut-upsdev mailing list
Nut-upsdev@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev

Re: [Nut-upsdev] UPower: 95-upower-hid.rules update

2015-06-08 Thread Arnaud Quette
2015-06-08 13:06 GMT+02:00 Bastien Nocera had...@hadess.net:

 On Mon, 2015-06-08 at 09:45 +0200, Arnaud Quette wrote:
 
 
  2015-06-04 13:04 GMT+02:00 Bastien Nocera had...@hadess.net:
   On Sat, 2015-05-30 at 18:51 +0200, Arnaud Quette wrote:
   
   
2015-05-29 14:09 GMT+02:00 Bastien Nocera had...@hadess.net:
 On Fri, 2015-05-29 at 13:59 +0200, Arnaud Quette wrote:
  Hi Richard and the list,
 
  you'll find attached a patch for 95-upower-hid.rules, which
   adds:
  - the usbmisc filtering, as added in your repo,
  - more comments, including one that points at your UPower
   repo,
  - 3 new manufacturers (Minibox, iDowell and Powerware)
  - a bunch of new devices (7 HP,  1 APC, 1 TrippLite, 2
   PowerCOM
 and 2
  Liebert)

 Could you please split those changes into 3 separate patches?
   
since you already have the usbmisc, I can possibly check to
   split
in 2 commits (1 for the comments, and 1 for the content update).
would that suits you that way?
  
   Sure.
  
  It would also be useful to include a full URL to the NUT Perl
 script
 (to a git repository perhaps), so people don't need to check
   out
 the
 full repo to update it.

as per Charles comments, beside from the perl script, you need
   all
the drivers/*hid.c files to extract the USB info.
the added comment was just to shed light on the fact that it's an
automated data extraction.
I can reword to make it more clear if you want.
  
   Just changing the path to project page URL + the path would be fine
   (that means that somebody unfamiliar with NUT's upstream can
   actually
   find the scripts to update this file).
  
  Prior to pushing the changes in NUT and to generate the patches for
  UPower, does the below header suit you:
 
  # Uninterruptible Power Supplies with USB HID interfaces
  #
  # http://cgit.freedesktop.org/upower/tree/rules/95-upower-hid.rules

 That bit isn't necessary.


if you don't mind, I would prefer to keep it somewhere, just to remember
(from a NUT point of view) where the upower repos. (and that file) is.
so, not necessary, but useful for the NUT side...


  #
  # This file was automatically generated by NUT:
  # https://github.com/networkupstools/nut/
  #
  # To keep up to date, monitor upstream NUT
  #
 https://github.com/networkupstools/nut/commits/master/scripts/upower/95-
  upower-hid.rules
  # or checkout the NUT repository and call 'tools/nut-usbinfo.pl'
 
  Or do you see any other better wording?

 The rest is fine.


ok, thanks.

I'll just wait for your ack on the above UPower repos. point, to push the
remaining commit.

thx and cheers,
Arno
-- 
Eaton Data Center Automation - Opensource Leader
NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.fr
___
Nut-upsdev mailing list
Nut-upsdev@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev

Re: [Nut-upsdev] UPower: 95-upower-hid.rules update

2015-05-30 Thread Arnaud Quette
2015-05-29 14:09 GMT+02:00 Bastien Nocera had...@hadess.net:

 On Fri, 2015-05-29 at 13:59 +0200, Arnaud Quette wrote:
  Hi Richard and the list,
 
  you'll find attached a patch for 95-upower-hid.rules, which adds:
  - the usbmisc filtering, as added in your repo,
  - more comments, including one that points at your UPower repo,
  - 3 new manufacturers (Minibox, iDowell and Powerware)
  - a bunch of new devices (7 HP,  1 APC, 1 TrippLite, 2 PowerCOM and 2
  Liebert)

 Could you please split those changes into 3 separate patches?


since you already have the usbmisc, I can possibly check to split in 2
commits (1 for the comments, and 1 for the content update).
would that suits you that way?

It would also be useful to include a full URL to the NUT Perl script
 (to a git repository perhaps), so people don't need to check out the
 full repo to update it.


as per Charles comments, beside from the perl script, you need all the
drivers/*hid.c files to extract the USB info.
the added comment was just to shed light on the fact that it's an automated
data extraction.
I can reword to make it more clear if you want.

cheers,
Arno
-- 
Eaton Data Center Automation - Opensource Leader
NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.fr
___
Nut-upsdev mailing list
Nut-upsdev@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev

[Nut-upsdev] UPower: 95-upower-hid.rules update

2015-05-29 Thread Arnaud Quette
Hi Richard and the list,

you'll find attached a patch for 95-upower-hid.rules, which adds:
- the usbmisc filtering, as added in your repo,
- more comments, including one that points at your UPower repo,
- 3 new manufacturers (Minibox, iDowell and Powerware)
- a bunch of new devices (7 HP,  1 APC, 1 TrippLite, 2 PowerCOM and 2
Liebert)

cheers,
Arnaud
-- 
Eaton Data Center Automation - Opensource Leader
NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.fr
--- upower/rules/95-upower-hid.rules2015-05-29 13:53:23.049748923 +0200
+++ GIThub-NUT/scripts/upower/95-upower-hid.rules   2015-05-29 
13:45:58.097213385 +0200
@@ -1,10 +1,13 @@
 
##
 # Uninterruptible Power Supplies with USB HID interfaces
 #
-# to keep up to date, monitor: 
http://svn.debian.org/wsvn/nut/trunk/scripts/upower/95-upower-hid.rules
+# This file was automatically generated by NUT (nut/tools/nut-usbinfo.pl)
+# to keep up to date, monitor upstream NUT 
https://github.com/networkupstools/nut/commits/master/scripts/upower/95-upower-hid.rules
+# and upstream UPower 
http://cgit.freedesktop.org/upower/tree/rules/95-upower-hid.rules
 
-# only support USB, else ignore
+# newer hiddev are part of the usbmisc class
 SUBSYSTEM==usbmisc, GOTO=up_hid_chkdev
+# only support USB, else ignore
 SUBSYSTEM!=usb, GOTO=up_hid_end
 
 # if usbraw device, ignore
@@ -17,21 +20,31 @@
 ATTRS{idVendor}==03f0, ENV{UPOWER_VENDOR}=Hewlett Packard
 ATTRS{idVendor}==0463, ENV{UPOWER_VENDOR}=Eaton
 ATTRS{idVendor}==047c, ENV{UPOWER_VENDOR}=Dell
+ATTRS{idVendor}==04d8, ENV{UPOWER_VENDOR}=Minibox
 ATTRS{idVendor}==050d, ENV{UPOWER_VENDOR}=Belkin
 ATTRS{idVendor}==051d, ENV{UPOWER_VENDOR}=APC
-ATTRS{idVendor}==06da, ENV{UPOWER_VENDOR}=Liebert
+ATTRS{idVendor}==0592, ENV{UPOWER_VENDOR}=Powerware
+ATTRS{idVendor}==06da, ENV{UPOWER_VENDOR}=Phoenixtec Power Co., Ltd
+ATTRS{idVendor}==075d, ENV{UPOWER_VENDOR}=iDowell
 ATTRS{idVendor}==0764, ENV{UPOWER_VENDOR}=Cyber Power Systems
 ATTRS{idVendor}==09ae, ENV{UPOWER_VENDOR}=TrippLite
 ATTRS{idVendor}==0d9f, ENV{UPOWER_VENDOR}=PowerCOM
 ATTRS{idVendor}==10af, ENV{UPOWER_VENDOR}=Liebert
 
 # Hewlett Packard
+ATTRS{idVendor}==03f0, ATTRS{idProduct}==0001, 
ENV{UPOWER_BATTERY_TYPE}=ups
 ATTRS{idVendor}==03f0, ATTRS{idProduct}==1f06, 
ENV{UPOWER_BATTERY_TYPE}=ups
 ATTRS{idVendor}==03f0, ATTRS{idProduct}==1f08, 
ENV{UPOWER_BATTERY_TYPE}=ups
 ATTRS{idVendor}==03f0, ATTRS{idProduct}==1f09, 
ENV{UPOWER_BATTERY_TYPE}=ups
 ATTRS{idVendor}==03f0, ATTRS{idProduct}==1f0a, 
ENV{UPOWER_BATTERY_TYPE}=ups
 ATTRS{idVendor}==03f0, ATTRS{idProduct}==1fe0, 
ENV{UPOWER_BATTERY_TYPE}=ups
 ATTRS{idVendor}==03f0, ATTRS{idProduct}==1fe1, 
ENV{UPOWER_BATTERY_TYPE}=ups
+ATTRS{idVendor}==03f0, ATTRS{idProduct}==1fe2, 
ENV{UPOWER_BATTERY_TYPE}=ups
+ATTRS{idVendor}==03f0, ATTRS{idProduct}==1fe3, 
ENV{UPOWER_BATTERY_TYPE}=ups
+ATTRS{idVendor}==03f0, ATTRS{idProduct}==1fe5, 
ENV{UPOWER_BATTERY_TYPE}=ups
+ATTRS{idVendor}==03f0, ATTRS{idProduct}==1fe6, 
ENV{UPOWER_BATTERY_TYPE}=ups
+ATTRS{idVendor}==03f0, ATTRS{idProduct}==1fe7, 
ENV{UPOWER_BATTERY_TYPE}=ups
+ATTRS{idVendor}==03f0, ATTRS{idProduct}==1fe8, 
ENV{UPOWER_BATTERY_TYPE}=ups
 
 # Eaton
 ATTRS{idVendor}==0463, ATTRS{idProduct}==0001, 
ENV{UPOWER_BATTERY_TYPE}=ups
@@ -40,6 +53,10 @@
 # Dell
 ATTRS{idVendor}==047c, ATTRS{idProduct}==, 
ENV{UPOWER_BATTERY_TYPE}=ups
 
+# Minibox
+ATTRS{idVendor}==04d8, ATTRS{idProduct}==d004, 
ENV{UPOWER_BATTERY_TYPE}=ups
+ATTRS{idVendor}==04d8, ATTRS{idProduct}==d005, 
ENV{UPOWER_BATTERY_TYPE}=ups
+
 # Belkin
 ATTRS{idVendor}==050d, ATTRS{idProduct}==0375, 
ENV{UPOWER_BATTERY_TYPE}=ups
 ATTRS{idVendor}==050d, ATTRS{idProduct}==0551, 
ENV{UPOWER_BATTERY_TYPE}=ups
@@ -49,15 +66,23 @@
 ATTRS{idVendor}==050d, ATTRS{idProduct}==0910, 
ENV{UPOWER_BATTERY_TYPE}=ups
 ATTRS{idVendor}==050d, ATTRS{idProduct}==0912, 
ENV{UPOWER_BATTERY_TYPE}=ups
 ATTRS{idVendor}==050d, ATTRS{idProduct}==0980, 
ENV{UPOWER_BATTERY_TYPE}=ups
+ATTRS{idVendor}==050d, ATTRS{idProduct}==0f51, 
ENV{UPOWER_BATTERY_TYPE}=ups
 ATTRS{idVendor}==050d, ATTRS{idProduct}==1100, 
ENV{UPOWER_BATTERY_TYPE}=ups
 
 # APC
+ATTRS{idVendor}==051d, ATTRS{idProduct}==, 
ENV{UPOWER_BATTERY_TYPE}=ups
 ATTRS{idVendor}==051d, ATTRS{idProduct}==0002, 
ENV{UPOWER_BATTERY_TYPE}=ups
 ATTRS{idVendor}==051d, ATTRS{idProduct}==0003, 
ENV{UPOWER_BATTERY_TYPE}=ups
 
-# Liebert
+# Powerware
+ATTRS{idVendor}==0592, ATTRS{idProduct}==0004, 
ENV{UPOWER_BATTERY_TYPE}=ups
+
+# Phoenixtec Power Co., Ltd
 ATTRS{idVendor}==06da, ATTRS{idProduct}==, 
ENV{UPOWER_BATTERY_TYPE}=ups
 
+# iDowell
+ATTRS{idVendor}==075d, ATTRS{idProduct}==0300, 
ENV{UPOWER_BATTERY_TYPE}=ups
+
 # Cyber Power Systems
 ATTRS{idVendor}==0764, ATTRS{idProduct}==0005, 
ENV{UPOWER_BATTERY_TYPE}=ups
 ATTRS{idVendor}==0764, ATTRS{idProduct}==0501, 

Re: [Nut-upsdev] UPower: 95-upower-hid.rules update

2015-05-29 Thread Bastien Nocera
On Fri, 2015-05-29 at 14:09 +0200, Bastien Nocera wrote:
 On Fri, 2015-05-29 at 13:59 +0200, Arnaud Quette wrote:
  Hi Richard and the list,
  
  you'll find attached a patch for 95-upower-hid.rules, which adds:
  - the usbmisc filtering, as added in your repo,
  - more comments, including one that points at your UPower repo,
  - 3 new manufacturers (Minibox, iDowell and Powerware)
  - a bunch of new devices (7 HP,  1 APC, 1 TrippLite, 2 PowerCOM and 
  2 
  Liebert)
 
 Could you please split those changes into 3 separate patches?
 
 It would also be useful to include a full URL to the NUT Perl script
 (to a git repository perhaps), so people don't need to check out the
 full repo to update it.

There's also a few UPS related bugs in:
https://bugzilla.freedesktop.org/buglist.cgi?component=generallist_id=545920product=upowerresolution=---

It would be helpful if you could comment on those (I don't have a UPS
to test).

Cheers


___
Nut-upsdev mailing list
Nut-upsdev@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev


Re: [Nut-upsdev] UPower: 95-upower-hid.rules update

2015-05-29 Thread Arnaud Quette
Hi Bastien,

2015-05-29 14:10 GMT+02:00 Bastien Nocera had...@hadess.net:

 On Fri, 2015-05-29 at 14:09 +0200, Bastien Nocera wrote:
  On Fri, 2015-05-29 at 13:59 +0200, Arnaud Quette wrote:
   Hi Richard and the list,
  
   you'll find attached a patch for 95-upower-hid.rules, which adds:
   - the usbmisc filtering, as added in your repo,
   - more comments, including one that points at your UPower repo,
   - 3 new manufacturers (Minibox, iDowell and Powerware)
   - a bunch of new devices (7 HP,  1 APC, 1 TrippLite, 2 PowerCOM and
   2
   Liebert)
 
  Could you please split those changes into 3 separate patches?
 
  It would also be useful to include a full URL to the NUT Perl script
  (to a git repository perhaps), so people don't need to check out the
  full repo to update it.

 There's also a few UPS related bugs in:

 https://bugzilla.freedesktop.org/buglist.cgi?component=generallist_id=545920product=upowerresolution=---


23256 https://bugzilla.freedesktop.org/show_bug.cgi?id=23256: not sure,
could be some instability in the UPower / devkit stack. I'll try to check
but no promise, time is missing...
70548 https://bugzilla.freedesktop.org/show_bug.cgi?id=70548: I'll be
checking that one and commenting.


 It would be helpful if you could comment on those (I don't have a UPS
 to test).


would you be interested in getting one?
If so, please contact me back privately, preferably on my @eaton.com
address...

cheers,
Arno
-- 
Eaton Data Center Automation - Opensource Leader
NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.fr
___
Nut-upsdev mailing list
Nut-upsdev@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev

Re: [Nut-upsdev] UPower: 95-upower-hid.rules update

2015-05-29 Thread Charles Lepple
On May 29, 2015, at 8:09 AM, Bastien Nocera had...@hadess.net wrote:

 It would also be useful to include a full URL to the NUT Perl script
 (to a git repository perhaps), so people don't need to check out the
 full repo to update it.

I'm not sure how useful the nut-usbinfo.pl script will be without the NUT 
repository: it scans the NUT source files for certain macros containing USB 
VIDs and PIDs.

The NUT URL listed in the file 
https://github.com/networkupstools/nut/commits/master/scripts/upower/95-upower-hid.rules
 refers to the history of a checked-in version of the output of nut-usbinfo.pl. 
The file itself is two clicks away, but if it would help, we could include that 
URL as well.

We're certainly open to suggestions as to how we can handle this better (the 
concept of checking in an auto-generated file irks me), but for the benefit of 
those of us who aren't as familiar with UPower, is there an introduction to how 
this information is used outside of NUT?

-- 
Charles Lepple
clepple@gmail




___
Nut-upsdev mailing list
Nut-upsdev@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev