Coverity Scan: Analysis completed for openssl/openssl

2024-04-26 Thread scan-admin


Your request for analysis of openssl/openssl has been completed 
successfully.
The results are available at 
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu7On3ENqKj59w4rEawU-2BYZgjBJ8Ay1pFYeVslaCebcWhw-3D-3DMij__bGLyfjQQhnPAMp6Vz8xksML07NHC5l7WMnVZN7GWb6qWyS-2BEEEzkoS9wsJtMTNVM-2BOMy9CuaHuYzyNNR5BYFNWsvW5SkPPIq14bSdQO-2FgwPaQ0yuVIhKhov6r3I7ItFskPlt1Jfcl1ZCPjg6v9-2FLlldTs3CBiaLChXNK5gr6qjoHjZ-2BsZysGGbyHwVC1bh8LhB62tB8zeUmyegQ0M6Bbvg-3D-3D

Build ID: 608864

Analysis Summary:
   New defects found: 0
   Defects eliminated: 2



[openssl/openssl] 789f7c: tls_post_encryption_processing_default() and tls_v...

2024-04-26 Thread fwh-dc
  Branch: refs/heads/feature/dtls-1.3
  Home:   https://github.com/openssl/openssl
  Commit: 789f7c65406cb2f69710e6337ecde662a68e91fc
  
https://github.com/openssl/openssl/commit/789f7c65406cb2f69710e6337ecde662a68e91fc
  Author: Frederik Wedel-Heinen 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M ssl/record/methods/tls_common.c
M ssl/record/methods/tlsany_meth.c

  Log Message:
  ---
  tls_post_encryption_processing_default() and tls_validate_record_header()

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/22376)



To unsubscribe from these emails, change your notification settings at 
https://github.com/openssl/openssl/settings/notifications


[openssl/openssl] 3dcd85: Make a failure in ktls_sendfile a syscall error

2024-04-26 Thread Neil Horman
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 3dcd85139f30625f2e4d072fe2b0f211f76f819c
  
https://github.com/openssl/openssl/commit/3dcd85139f30625f2e4d072fe2b0f211f76f819c
  Author: Neil Horman 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M ssl/ssl_lib.c

  Log Message:
  ---
  Make a failure in ktls_sendfile a syscall error

a failure in ktls_sendfile results in an error in ERR_LIB_SSL, but its
really a syscall error, since ktls_sendfile just maps to a call to the
sendfile syscall.  Encode it as such

Fixes #23722

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/23723)


  Commit: 933f57dfe21657f7aba8f13e0cdb3b02dd64fcc3
  
https://github.com/openssl/openssl/commit/933f57dfe21657f7aba8f13e0cdb3b02dd64fcc3
  Author: Neil Horman 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M ssl/record/methods/tls_common.c

  Log Message:
  ---
  Raise an error on syscall failure in tls_retry_write_records

Record the errno when we get a syscall failure in
tls_retry_write_records

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/23723)


Compare: https://github.com/openssl/openssl/compare/3059052992ab...933f57dfe216

To unsubscribe from these emails, change your notification settings at 
https://github.com/openssl/openssl/settings/notifications


[openssl/openssl] badda7: Fix coverity-1596616

2024-04-26 Thread Neil Horman
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: badda78325dd961fa41a107796f2744ffbe8b265
  
https://github.com/openssl/openssl/commit/badda78325dd961fa41a107796f2744ffbe8b265
  Author: Neil Horman 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M crypto/hashtable/hashtable.c

  Log Message:
  ---
  Fix coverity-1596616

Need to add a null check prior to derefencing pointer for free

Reviewed-by: Matt Caswell 
Reviewed-by: Paul Dale 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/24263)


  Commit: 3059052992ab61b0ba560ddf48111cecb5158ae2
  
https://github.com/openssl/openssl/commit/3059052992ab61b0ba560ddf48111cecb5158ae2
  Author: Neil Horman 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M crypto/conf/conf_mod.c

  Log Message:
  ---
  Fix coverity 1596617

Somehow a double free slipped into conf_mod.c, remove it

Reviewed-by: Matt Caswell 
Reviewed-by: Paul Dale 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/24263)


Compare: https://github.com/openssl/openssl/compare/bde66e828dd2...3059052992ab

To unsubscribe from these emails, change your notification settings at 
https://github.com/openssl/openssl/settings/notifications


[openssl/openssl] b6456a: set module path from template

2024-04-26 Thread Neil Horman
  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: b6456af5c043397998997a4f91348fb0aeca2625
  
https://github.com/openssl/openssl/commit/b6456af5c043397998997a4f91348fb0aeca2625
  Author: Neil Horman 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M crypto/provider_core.c

  Log Message:
  ---
  set module path from template

Modules that aren't activated at conf load time don't seem to set the
module path from the template leading to load failures.  Make sure to
set that

Fixes #24020

Reviewed-by: Matt Caswell 
Reviewed-by: Richard Levitte 
Reviewed-by: Tomas Mraz 

(cherry picked from commit bc9595963a45e28e6a8b2de45a6719c252bd3a3d)

(Merged from https://github.com/openssl/openssl/pull/24198)

(cherry picked from commit 71e5bb982f9c9563567ea8ae9f6e29492e9146ca)


  Commit: 74f551e90c3415bd391add232a93d433fb052b55
  
https://github.com/openssl/openssl/commit/74f551e90c3415bd391add232a93d433fb052b55
  Author: Neil Horman 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M test/build.info
A test/pathed.cnf
M test/prov_config_test.c
M test/recipes/30-test_prov_config.t

  Log Message:
  ---
  Add test for OSSL_PROVIDER_load with module path set

Ensure that, with the modulepath setting set in a config field, that we
are able to load a provider from the path relative to OPENSSL_MODULES

Reviewed-by: Matt Caswell 
Reviewed-by: Richard Levitte 
Reviewed-by: Tomas Mraz 

(cherry picked from commit 91a77cbf66c575345cf1eab31717e8edafcd1633)

(Merged from https://github.com/openssl/openssl/pull/24198)

(cherry picked from commit db163245097bc813235403c234795721d4e5c4eb)


  Commit: f663322bd61312a07d678fe3b22e517180653a37
  
https://github.com/openssl/openssl/commit/f663322bd61312a07d678fe3b22e517180653a37
  Author: Neil Horman 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M test/prov_config_test.c

  Log Message:
  ---
  Update modulepath test for provider config to skip if not present

If the p_test.so library isn't present, don't run the test

Reviewed-by: Matt Caswell 
Reviewed-by: Richard Levitte 
Reviewed-by: Tomas Mraz 

(cherry picked from commit b80fed3f27ebe156b17246f7c12c5178cbe6834e)

(Merged from https://github.com/openssl/openssl/pull/24198)

(cherry picked from commit 83c649996c18e5185f9439172d5908ad7fef9146)


  Commit: 25e1d8dcdedaa0e99218b4dd24f82a11f2a470eb
  
https://github.com/openssl/openssl/commit/25e1d8dcdedaa0e99218b4dd24f82a11f2a470eb
  Author: Neil Horman 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M crypto/provider_core.c
M test/prov_config_test.c

  Log Message:
  ---
  Fix up path generation to use OPENSSL_MODULES

Reviewed-by: Matt Caswell 
Reviewed-by: Richard Levitte 
Reviewed-by: Tomas Mraz 

(cherry picked from commit 4e3c1e6206251c59855362d6d2edab4621c31dec)

(Merged from https://github.com/openssl/openssl/pull/24198)

(cherry picked from commit 163202f0b95cfc7e666e45cafc55a505f51f6153)


  Commit: 491ff1b13bdabad24384cc0c19c6dd7532693613
  
https://github.com/openssl/openssl/commit/491ff1b13bdabad24384cc0c19c6dd7532693613
  Author: Neil Horman 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M test/prov_config_test.c

  Log Message:
  ---
  Fix missing NULL check in prov_config_test

coverity-1596500 caught a missing null check.  We should never hit it as
the test harness always sets the environment variable, but lets add the
check for safety

Reviewed-by: Tomas Mraz 
Reviewed-by: Tom Cosgrove 
Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/24198)

(cherry picked from commit a380ec952f138f644d227637eeba90fd1e17f72f)


Compare: https://github.com/openssl/openssl/compare/f0115d45072a...491ff1b13bda

To unsubscribe from these emails, change your notification settings at 
https://github.com/openssl/openssl/settings/notifications


[openssl/openssl] 71e5bb: set module path from template

2024-04-26 Thread Neil Horman
  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: 71e5bb982f9c9563567ea8ae9f6e29492e9146ca
  
https://github.com/openssl/openssl/commit/71e5bb982f9c9563567ea8ae9f6e29492e9146ca
  Author: Neil Horman 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M crypto/provider_core.c

  Log Message:
  ---
  set module path from template

Modules that aren't activated at conf load time don't seem to set the
module path from the template leading to load failures.  Make sure to
set that

Fixes #24020

Reviewed-by: Matt Caswell 
Reviewed-by: Richard Levitte 
Reviewed-by: Tomas Mraz 

(cherry picked from commit bc9595963a45e28e6a8b2de45a6719c252bd3a3d)

(Merged from https://github.com/openssl/openssl/pull/24198)


  Commit: db163245097bc813235403c234795721d4e5c4eb
  
https://github.com/openssl/openssl/commit/db163245097bc813235403c234795721d4e5c4eb
  Author: Neil Horman 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M test/build.info
A test/pathed.cnf
M test/prov_config_test.c
M test/recipes/30-test_prov_config.t

  Log Message:
  ---
  Add test for OSSL_PROVIDER_load with module path set

Ensure that, with the modulepath setting set in a config field, that we
are able to load a provider from the path relative to OPENSSL_MODULES

Reviewed-by: Matt Caswell 
Reviewed-by: Richard Levitte 
Reviewed-by: Tomas Mraz 

(cherry picked from commit 91a77cbf66c575345cf1eab31717e8edafcd1633)

(Merged from https://github.com/openssl/openssl/pull/24198)


  Commit: 83c649996c18e5185f9439172d5908ad7fef9146
  
https://github.com/openssl/openssl/commit/83c649996c18e5185f9439172d5908ad7fef9146
  Author: Neil Horman 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M test/prov_config_test.c

  Log Message:
  ---
  Update modulepath test for provider config to skip if not present

If the p_test.so library isn't present, don't run the test

Reviewed-by: Matt Caswell 
Reviewed-by: Richard Levitte 
Reviewed-by: Tomas Mraz 

(cherry picked from commit b80fed3f27ebe156b17246f7c12c5178cbe6834e)

(Merged from https://github.com/openssl/openssl/pull/24198)


  Commit: 163202f0b95cfc7e666e45cafc55a505f51f6153
  
https://github.com/openssl/openssl/commit/163202f0b95cfc7e666e45cafc55a505f51f6153
  Author: Neil Horman 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M crypto/provider_core.c
M test/prov_config_test.c

  Log Message:
  ---
  Fix up path generation to use OPENSSL_MODULES

Reviewed-by: Matt Caswell 
Reviewed-by: Richard Levitte 
Reviewed-by: Tomas Mraz 

(cherry picked from commit 4e3c1e6206251c59855362d6d2edab4621c31dec)

(Merged from https://github.com/openssl/openssl/pull/24198)


  Commit: a380ec952f138f644d227637eeba90fd1e17f72f
  
https://github.com/openssl/openssl/commit/a380ec952f138f644d227637eeba90fd1e17f72f
  Author: Neil Horman 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M test/prov_config_test.c

  Log Message:
  ---
  Fix missing NULL check in prov_config_test

coverity-1596500 caught a missing null check.  We should never hit it as
the test harness always sets the environment variable, but lets add the
check for safety

Reviewed-by: Tomas Mraz 
Reviewed-by: Tom Cosgrove 
Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/24198)


Compare: https://github.com/openssl/openssl/compare/17f448ede695...a380ec952f13

To unsubscribe from these emails, change your notification settings at 
https://github.com/openssl/openssl/settings/notifications


[openssl/openssl] c1584a: Add an Apple privacy info file for OpenSSL

2024-04-26 Thread YOKOTA, Takehiko
  Branch: refs/heads/openssl-3.2
  Home:   https://github.com/openssl/openssl
  Commit: c1584a658c23d447f33ef3ebc60f0182aa1cbbd4
  
https://github.com/openssl/openssl/commit/c1584a658c23d447f33ef3ebc60f0182aa1cbbd4
  Author: Takehiko Yokota 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
A os-dep/Apple/PrivacyInfo.xcprivacy

  Log Message:
  ---
  Add an Apple privacy info file for OpenSSL

Added PrivacyInfo.xcprivacy to os-dep/Apple/ dir.

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/24260)

(cherry picked from commit bde66e828dd2869d02225e4aab01d0983f242ae3)



To unsubscribe from these emails, change your notification settings at 
https://github.com/openssl/openssl/settings/notifications


[openssl/openssl] bde66e: Add an Apple privacy info file for OpenSSL

2024-04-26 Thread YOKOTA, Takehiko
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: bde66e828dd2869d02225e4aab01d0983f242ae3
  
https://github.com/openssl/openssl/commit/bde66e828dd2869d02225e4aab01d0983f242ae3
  Author: Takehiko Yokota 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
A os-dep/Apple/PrivacyInfo.xcprivacy

  Log Message:
  ---
  Add an Apple privacy info file for OpenSSL

Added PrivacyInfo.xcprivacy to os-dep/Apple/ dir.

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/24260)



To unsubscribe from these emails, change your notification settings at 
https://github.com/openssl/openssl/settings/notifications


[openssl/openssl] 17f448: Add an Apple privacy info file for OpenSSL

2024-04-26 Thread YOKOTA, Takehiko
  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: 17f448ede695bb8e1c5c37472a7258914f5a4ac8
  
https://github.com/openssl/openssl/commit/17f448ede695bb8e1c5c37472a7258914f5a4ac8
  Author: Takehiko Yokota 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
A os-dep/Apple/PrivacyInfo.xcprivacy

  Log Message:
  ---
  Add an Apple privacy info file for OpenSSL

Added PrivacyInfo.xcprivacy to os-dep/Apple/ dir.

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/24260)

(cherry picked from commit bde66e828dd2869d02225e4aab01d0983f242ae3)



To unsubscribe from these emails, change your notification settings at 
https://github.com/openssl/openssl/settings/notifications


[openssl/openssl] b4604d: Add an Apple privacy info file for OpenSSL

2024-04-26 Thread YOKOTA, Takehiko
  Branch: refs/heads/openssl-3.3
  Home:   https://github.com/openssl/openssl
  Commit: b4604d5252633de9a50191795edf76d2a8e836dc
  
https://github.com/openssl/openssl/commit/b4604d5252633de9a50191795edf76d2a8e836dc
  Author: Takehiko Yokota 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
A os-dep/Apple/PrivacyInfo.xcprivacy

  Log Message:
  ---
  Add an Apple privacy info file for OpenSSL

Added PrivacyInfo.xcprivacy to os-dep/Apple/ dir.

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/24260)

(cherry picked from commit bde66e828dd2869d02225e4aab01d0983f242ae3)



To unsubscribe from these emails, change your notification settings at 
https://github.com/openssl/openssl/settings/notifications


[openssl/openssl] f0115d: Add an Apple privacy info file for OpenSSL

2024-04-26 Thread YOKOTA, Takehiko
  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: f0115d45072ae7c4e2e3658ec0db43195b31251c
  
https://github.com/openssl/openssl/commit/f0115d45072ae7c4e2e3658ec0db43195b31251c
  Author: Takehiko Yokota 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
A os-dep/Apple/PrivacyInfo.xcprivacy

  Log Message:
  ---
  Add an Apple privacy info file for OpenSSL

Added PrivacyInfo.xcprivacy to os-dep/Apple/ dir.

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/24260)

(cherry picked from commit bde66e828dd2869d02225e4aab01d0983f242ae3)



To unsubscribe from these emails, change your notification settings at 
https://github.com/openssl/openssl/settings/notifications


[openssl/openssl] 48e3cf: ssl/statem: Replace size_t with int and add the ch...

2024-04-26 Thread JiashengJiang
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 48e3cf25a80db9a2991daccb0d8d1848065bca63
  
https://github.com/openssl/openssl/commit/48e3cf25a80db9a2991daccb0d8d1848065bca63
  Author: Jiasheng Jiang 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M ssl/statem/extensions_clnt.c
M ssl/statem/extensions_srvr.c

  Log Message:
  ---
  ssl/statem: Replace size_t with int and add the checks

Replace the type of variables with int to avoid implicit conversion when it is 
assigned by EVP_MD_get_size().
Moreover, add the checks to avoid integer overflow.

Fixes: 6594189 ("Merge early_data_info extension into early_data")
Fixes: 9368f86 ("Add TLSv1.3 client side external PSK support")
Fixes: 1053a6e ("Implement Server side of PSK extension parsing")
Signed-off-by: Jiasheng Jiang 

Reviewed-by: Tom Cosgrove 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/23937)



To unsubscribe from these emails, change your notification settings at 
https://github.com/openssl/openssl/settings/notifications


[openssl/openssl] 6d0185: Avoid duplicate default CApath lookups

2024-04-26 Thread openssl-machine
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 6d018570407606acc1eabe68921496d77f27aeb9
  
https://github.com/openssl/openssl/commit/6d018570407606acc1eabe68921496d77f27aeb9
  Author: Viktor Dukhovni 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M crypto/x509/by_store.c
M crypto/x509/x509_d2.c

  Log Message:
  ---
  Avoid duplicate default CApath lookups

Fixes #21067

Reviewed-by: Neil Horman 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/24140)



To unsubscribe from these emails, change your notification settings at 
https://github.com/openssl/openssl/settings/notifications