[openssl/tools] 77a921: convert handshake test to use getopt
Branch: refs/heads/master Home: https://github.com/openssl/tools Commit: 77a921ba29ce915a9a24bd1a10bbc311310247b6 https://github.com/openssl/tools/commit/77a921ba29ce915a9a24bd1a10bbc311310247b6 Author: Neil Horman Date: 2024-06-10 (Mon, 10 Jun 2024) Changed paths: M perf/handshake.c Log Message: --- convert handshake test to use getopt We're adding a new option to not share ctx objects, and its getting hard to manage multiple options, so switch to using getopt Reviewed-by: Matt Caswell Reviewed-by: Paul Dale (Merged from https://github.com/openssl/tools/pull/195) Commit: ff39affbbf16d9306d6577b3c7ebd1d38488d043 https://github.com/openssl/tools/commit/ff39affbbf16d9306d6577b3c7ebd1d38488d043 Author: Neil Horman Date: 2024-06-10 (Mon, 10 Jun 2024) Changed paths: M perf/handshake.c Log Message: --- Make use of new -s option to not share ssl_ctx objects To better understand our performance behavior, add an option to the handshake test to allow the threads to repeatedly allocate their own contexts per connection. If -s is specified this will be the behavior. Omitting -s uses the default behavior, which is to share an ssl_ctx among all connections Reviewed-by: Matt Caswell Reviewed-by: Paul Dale (Merged from https://github.com/openssl/tools/pull/195) Commit: 8df3fcd76abb10a488d64744a7d26e9d9fb1c1a3 https://github.com/openssl/tools/commit/8df3fcd76abb10a488d64744a7d26e9d9fb1c1a3 Author: Neil Horman Date: 2024-06-10 (Mon, 10 Jun 2024) Changed paths: M perf/README Log Message: --- Update readme for new handshake option Reviewed-by: Matt Caswell Reviewed-by: Paul Dale (Merged from https://github.com/openssl/tools/pull/195) Compare: https://github.com/openssl/tools/compare/f8f26f9e86a9...8df3fcd76abb To unsubscribe from these emails, change your notification settings at https://github.com/openssl/tools/settings/notifications
[openssl/openssl] f596a4: Add defaults api to openssl build
Branch: refs/heads/read-openssldir-from-registry
Home: https://github.com/openssl/openssl
Commit: f596a4f26a53e4bc78cca55c12e0ea0f48d80a63
https://github.com/openssl/openssl/commit/f596a4f26a53e4bc78cca55c12e0ea0f48d80a63
Author: Neil Horman
Date: 2024-06-06 (Thu, 06 Jun 2024)
Changed paths:
M NOTES-WINDOWS.md
M crypto/build.info
A crypto/defaults.c
M include/internal/common.h
Log Message:
---
Add defaults api to openssl build
Build time defaults aren't great for windows, in which various macros
(like OPENSSLDIR) are selected at build time, but may be selected
differently at install time. Add an internal defaults api to return the
build time constants on unix systems, but instead query registry keys
for the form:
HLKM\SOFTWARE\OpenSSL-{version}-{wininstallcontext}
Such that each built version of openssl may maintain its own set of
registry keys to identify these locations, and be set administratiely as
appropriate at install or run time
Commit: 3c94c62939233887f10dfd0225031264900ab5e4
https://github.com/openssl/openssl/commit/3c94c62939233887f10dfd0225031264900ab5e4
Author: Neil Horman
Date: 2024-06-06 (Thu, 06 Jun 2024)
Changed paths:
M apps/version.c
M crypto/cversion.c
M crypto/engine/eng_list.c
M crypto/info.c
M crypto/provider_core.c
M crypto/x509/x509_def.c
M doc/man1/openssl-version.pod.in
M include/openssl/crypto.h.in
Log Message:
---
convert users of build time defaults to use new defaults api
Now that we can query for install time registry keys on windows, convert
users of these macros to use the api instead
Add a unit test to validate the functionality of our reg key lookups
Add a test to check to make sure our registry key lookups work. note
this test only runs on windows (clearly), but also only if the registry
keys are set via an installer or some other manual process (to be done
in the CI workflow)
Commit: e90858f6a80365970a3532a81a953726f97546f5
https://github.com/openssl/openssl/commit/e90858f6a80365970a3532a81a953726f97546f5
Author: Neil Horman
Date: 2024-06-06 (Thu, 06 Jun 2024)
Changed paths:
M .github/workflows/windows.yml
A test/recipes/02-test_windows_registry.t
Log Message:
---
Add a unit test to validate the functionality of our reg key lookups
Add a test to check to make sure our registry key lookups work. note
this test only runs on windows (clearly), but also only if the registry
keys are set via an installer or some other manual process (to be done
in the CI workflow)
Also add workflow steps to set registry keys for testing
Commit: 2829256e19690c4e1cbd222eb3661fd95273012b
https://github.com/openssl/openssl/commit/2829256e19690c4e1cbd222eb3661fd95273012b
Author: Neil Horman
Date: 2024-06-06 (Thu, 06 Jun 2024)
Changed paths:
M .github/workflows/windows.yml
Log Message:
---
Workflow debug
Compare:
https://github.com/openssl/openssl/compare/f596a4f26a53%5E...2829256e1969
To unsubscribe from these emails, change your notification settings at
https://github.com/openssl/openssl/settings/notifications
[openssl/web] 07e937: remove FTP mirrors mentions
Branch: refs/heads/master Home: https://github.com/openssl/web Commit: 07e937dcd66d989148c1ed128ad173676a48cd52 https://github.com/openssl/web/commit/07e937dcd66d989148c1ed128ad173676a48cd52 Author: Dmitry Misharov Date: 2024-04-03 (Wed, 03 Apr 2024) Changed paths: M source/dirdata.yaml M source/index.md.tt R source/mirror.md M source/old/dirdata.yaml M source/old/sub-dirdata.yaml.tt Log Message: --- remove FTP mirrors mentions Reviewed-by: Anton Arapov Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/web/pull/479) Commit: 0b3be3b1193f5f10a0f0badb42039bc02df4070d https://github.com/openssl/web/commit/0b3be3b1193f5f10a0f0badb42039bc02df4070d Author: Neil Horman Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M roadmap.md Log Message: --- update roadmap for 3.4 Fixes #24219 Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/web/pull/481) Compare: https://github.com/openssl/web/compare/d3ec13fa40e7...0b3be3b1193f To unsubscribe from these emails, change your notification settings at https://github.com/openssl/web/settings/notifications
[openssl/openssl] ef2c90: Add defaults api to openssl build
Branch: refs/heads/read-openssldir-from-registry
Home: https://github.com/openssl/openssl
Commit: ef2c90a68e9a5dda1d466b9d3a1de99ec4e9c849
https://github.com/openssl/openssl/commit/ef2c90a68e9a5dda1d466b9d3a1de99ec4e9c849
Author: Neil Horman
Date: 2024-06-03 (Mon, 03 Jun 2024)
Changed paths:
M NOTES-WINDOWS.md
M crypto/build.info
A crypto/defaults.c
M include/internal/common.h
Log Message:
---
Add defaults api to openssl build
Build time defaults aren't great for windows, in which various macros
(like OPENSSLDIR) are selected at build time, but may be selected
differently at install time. Add an internal defaults api to return the
build time constants on unix systems, but instead query registry keys
for the form:
HLKM\SOFTWARE\OpenSSL-{version}-{wininstallcontext}
Such that each built version of openssl may maintain its own set of
registry keys to identify these locations, and be set administratiely as
appropriate at install or run time
Commit: 58949ed92c398dfd0089365dfa4f26c5ba138b3b
https://github.com/openssl/openssl/commit/58949ed92c398dfd0089365dfa4f26c5ba138b3b
Author: Neil Horman
Date: 2024-06-03 (Mon, 03 Jun 2024)
Changed paths:
M apps/version.c
M crypto/cversion.c
M crypto/engine/eng_list.c
M crypto/info.c
M crypto/provider_core.c
M crypto/x509/x509_def.c
M include/openssl/crypto.h.in
Log Message:
---
convert users of build time defaults to use new defaults api
Now that we can query for install time registry keys on windows, convert
users of these macros to use the api instead
Commit: 77919e19e85e2da3a579f260f1a1f9eb60db7934
https://github.com/openssl/openssl/commit/77919e19e85e2da3a579f260f1a1f9eb60db7934
Author: Neil Horman
Date: 2024-06-03 (Mon, 03 Jun 2024)
Changed paths:
A test/recipes/02-test_windows_registry.t
Log Message:
---
Add a unit test to validate the functionality of our reg key lookups
Add a test to check to make sure our registry key lookups work. note
this test only runs on windows (clearly), but also only if the registry
keys are set via an installer or some other manual process (to be done
in the CI workflow)
Commit: 08e6f89edf634f1dc248bd8f9ff61a8842cd2fbc
https://github.com/openssl/openssl/commit/08e6f89edf634f1dc248bd8f9ff61a8842cd2fbc
Author: Neil Horman
Date: 2024-06-03 (Mon, 03 Jun 2024)
Changed paths:
M .github/workflows/windows.yml
Log Message:
---
Add workflow steps to set registry keys for testing
Compare:
https://github.com/openssl/openssl/compare/ef2c90a68e9a%5E...08e6f89edf63
To unsubscribe from these emails, change your notification settings at
https://github.com/openssl/openssl/settings/notifications
[openssl/tools] 2bd95f: adding a fetch test to perf tools
Branch: refs/heads/master Home: https://github.com/openssl/tools Commit: 2bd95fa80df1fe091451015648cfe12476176f54 https://github.com/openssl/tools/commit/2bd95fa80df1fe091451015648cfe12476176f54 Author: Neil Horman Date: 2024-05-10 (Fri, 10 May 2024) Changed paths: M perf/Makefile A perf/evp_fetch.c Log Message: --- adding a fetch test to perf tools Reviewed-by: Paul Dale Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/tools/pull/193) Commit: 977e381ab35527492b247e9ff02e4f029307148f https://github.com/openssl/tools/commit/977e381ab35527492b247e9ff02e4f029307148f Author: Neil Horman Date: 2024-05-10 (Fri, 10 May 2024) Changed paths: M perf/evp_fetch.c Log Message: --- Make alg inclusion dependent on configuration Reviewed-by: Paul Dale Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/tools/pull/193) Commit: e92bf0b822d4457dfe50a1406a3b8ec3a9934967 https://github.com/openssl/tools/commit/e92bf0b822d4457dfe50a1406a3b8ec3a9934967 Author: Neil Horman Date: 2024-05-20 (Mon, 20 May 2024) Changed paths: M perf/evp_fetch.c Log Message: --- Add environment variable to allow specific fetch testing Reviewed-by: Paul Dale Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/tools/pull/193) Compare: https://github.com/openssl/tools/compare/16bf733342e8...e92bf0b822d4 To unsubscribe from these emails, change your notification settings at https://github.com/openssl/tools/settings/notifications
[openssl/installer] 6232f4: Adding initial windows installer
Branch: refs/heads/main Home: https://github.com/openssl/installer Commit: 6232f4305f21f5d18eff4c3da8924c55c7ff0768 https://github.com/openssl/installer/commit/6232f4305f21f5d18eff4c3da8924c55c7ff0768 Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: A windows-installer/Makefile A windows-installer/README.md A windows-installer/openssl.nsi Log Message: --- Adding initial windows installer Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/4) Commit: 9ff0d81a98b1040331ecad195ab63a0267ceb1ad https://github.com/openssl/installer/commit/9ff0d81a98b1040331ecad195ab63a0267ceb1ad Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: A .github/workflows/windows-installer.yml M windows-installer/Makefile Log Message: --- Adding ci script Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/4) Commit: f2e67548d0289461287ef4142517184a7a523a50 https://github.com/openssl/installer/commit/f2e67548d0289461287ef4142517184a7a523a50 Author: Neil Horman Date: 2024-05-06 (Mon, 06 May 2024) Changed paths: M .github/workflows/windows-installer.yml M windows-installer/openssl.nsi Log Message: --- Update installer to use installed directories It occured to me that we can simplify the installer greatly by running the install command for each binary set, and just doing a recursive file copy in the installer for x64 and x32. This is adventageous as it lets us package whatever configuration we built, and will include any files created as part of the install in the future. It also makes the installer script significantly smaller Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/4) Commit: 24c467048a665016e2b69ee9647d9fec437d34b6 https://github.com/openssl/installer/commit/24c467048a665016e2b69ee9647d9fec437d34b6 Author: Neil Horman Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M .github/workflows/windows-installer.yml M windows-installer/README.md M windows-installer/openssl.nsi Log Message: --- Fix typos/etc in README.md Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/4) Compare: https://github.com/openssl/installer/compare/856e1a7867a1...24c467048a66 To unsubscribe from these emails, change your notification settings at https://github.com/openssl/installer/settings/notifications
[openssl/tools] 9eb910: adding a fetch test to perf tools
Branch: refs/heads/fetch-test Home: https://github.com/openssl/tools Commit: 9eb91089308e8994a5cfb29e1f07de79a6c9e8c1 https://github.com/openssl/tools/commit/9eb91089308e8994a5cfb29e1f07de79a6c9e8c1 Author: Neil Horman Date: 2024-05-07 (Tue, 07 May 2024) Changed paths: M perf/Makefile A perf/evp_fetch.c Log Message: --- adding a fetch test to perf tools Commit: 3f85889af745a6afff376f5d2f451b20b519b75c https://github.com/openssl/tools/commit/3f85889af745a6afff376f5d2f451b20b519b75c Author: Neil Horman Date: 2024-05-09 (Thu, 09 May 2024) Changed paths: M perf/evp_fetch.c Log Message: --- Make alg inclusion dependent on configuration Commit: 21c264ccc4c1905556177bb99ed07e9028652530 https://github.com/openssl/tools/commit/21c264ccc4c1905556177bb99ed07e9028652530 Author: Neil Horman Date: 2024-05-09 (Thu, 09 May 2024) Changed paths: M perf/evp_fetch.c Log Message: --- Add environment variable to allow specific fetch testing Compare: https://github.com/openssl/tools/compare/9eb91089308e%5E...21c264ccc4c1 To unsubscribe from these emails, change your notification settings at https://github.com/openssl/tools/settings/notifications
[openssl/openssl] 27504d: Coverity found the following issues:
Branch: refs/heads/openssl-3.3 Home: https://github.com/openssl/openssl Commit: 27504de59586a23862f2f29e0d640b51d43ff24a https://github.com/openssl/openssl/commit/27504de59586a23862f2f29e0d640b51d43ff24a Author: Neil Horman Date: 2024-05-06 (Mon, 06 May 2024) Changed paths: M crypto/conf/conf_mod.c Log Message: --- Coverity found the following issues: 1591471 1591474 1591476 which pertain to memory leaks in the conf_mod code If an error is encountered after the module STACK_OF is duplicated or created in the new_modules variable, we need to remember to free it in the error path Reviewed-by: Tomas Mraz Reviewed-by: Paul Dale Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/24337) Commit: bc3e414939d804496fc77c0f5cf4b80eb4d8c6eb https://github.com/openssl/openssl/commit/bc3e414939d804496fc77c0f5cf4b80eb4d8c6eb Author: Neil Horman Date: 2024-05-06 (Mon, 06 May 2024) Changed paths: M test/threadstest.c Log Message: --- Fix potential divide by zero error Coverity caught the following issues: 1591477 1591475 1591473 1591470 all of which are simmilar, in that they catch potential divide by zero in double values. It can't actually happen since the the threads which increment these counters don't exit until they reach non-zero values, but its easy to add the checks, so lets do that to ensure that we don't change something in the future that causes it. Reviewed-by: Tomas Mraz Reviewed-by: Paul Dale Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/24337) Compare: https://github.com/openssl/openssl/compare/287165f1b7ce...bc3e414939d8 To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
[openssl/openssl] 2a5010: Add check for public key presence on sm2 signing
Branch: refs/heads/openssl-3.0 Home: https://github.com/openssl/openssl Commit: 2a5010e31c6b9c5b4b570e038a0e3baec8268931 https://github.com/openssl/openssl/commit/2a5010e31c6b9c5b4b570e038a0e3baec8268931 Author: Neil Horman Date: 2024-05-02 (Thu, 02 May 2024) Changed paths: M crypto/sm2/sm2_sign.c M test/sm2_internal_test.c Log Message: --- Add check for public key presence on sm2 signing SM2 requires that the public EC_POINT be present in a key when signing. If its not there we crash on a NULL pointer. Add a check to ensure that its present, and raise an error if its not Reviewed-by: Paul Yang Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/24078) (cherry picked from commit 1316aa05aae57cf47d8c8bfca38aaa042db1518f) Commit: 8beb0e3cc976b42ae12284aa1fd3b3c8eeb2030c https://github.com/openssl/openssl/commit/8beb0e3cc976b42ae12284aa1fd3b3c8eeb2030c Author: Neil Horman Date: 2024-05-02 (Thu, 02 May 2024) Changed paths: M doc/man7/EVP_PKEY-SM2.pod Log Message: --- Add docs noting requirements for SM2 signing Reviewed-by: Paul Yang Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/24078) (cherry picked from commit 54673b93594a71c9f8052a1df1a7c6bf07c49f4d) Compare: https://github.com/openssl/openssl/compare/8d0d05e9cb13...8beb0e3cc976 To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
[openssl/openssl] 1316aa: Add check for public key presence on sm2 signing
Branch: refs/heads/openssl-3.1 Home: https://github.com/openssl/openssl Commit: 1316aa05aae57cf47d8c8bfca38aaa042db1518f https://github.com/openssl/openssl/commit/1316aa05aae57cf47d8c8bfca38aaa042db1518f Author: Neil Horman Date: 2024-05-02 (Thu, 02 May 2024) Changed paths: M crypto/sm2/sm2_sign.c M test/sm2_internal_test.c Log Message: --- Add check for public key presence on sm2 signing SM2 requires that the public EC_POINT be present in a key when signing. If its not there we crash on a NULL pointer. Add a check to ensure that its present, and raise an error if its not Reviewed-by: Paul Yang Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/24078) Commit: 54673b93594a71c9f8052a1df1a7c6bf07c49f4d https://github.com/openssl/openssl/commit/54673b93594a71c9f8052a1df1a7c6bf07c49f4d Author: Neil Horman Date: 2024-05-02 (Thu, 02 May 2024) Changed paths: M doc/man7/EVP_PKEY-SM2.pod Log Message: --- Add docs noting requirements for SM2 signing Reviewed-by: Paul Yang Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/24078) Compare: https://github.com/openssl/openssl/compare/e4a87616c07a...54673b93594a To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
[openssl/tools] cb9d81: adjust newraw key to record time like the handshak...
Branch: refs/heads/master Home: https://github.com/openssl/tools Commit: cb9d8154dbb3cdbdf9d4225f9791da86d9a62a43 https://github.com/openssl/tools/commit/cb9d8154dbb3cdbdf9d4225f9791da86d9a62a43 Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M perf/newrawkey.c Log Message: --- adjust newraw key to record time like the handshake test the handshake test records the average time of each thread running its test, while other tests record the overall duration, leading to inconsistencies in how we do measurement. Bring newrawkey into line with how handshake does it. Reviewed-by: Matt Caswell Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/tools/pull/184) Commit: 8e82dd6faa516f212cede0008cf1fd7828453e5b https://github.com/openssl/tools/commit/8e82dd6faa516f212cede0008cf1fd7828453e5b Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M perf/pemread.c Log Message: --- convert pemread to be consistent in its time measurement like handshake and newrawkey, record times per thread and average them Reviewed-by: Matt Caswell Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/tools/pull/184) Commit: bd3ad5fa870f4bfea1beccb116b908e555974b40 https://github.com/openssl/tools/commit/bd3ad5fa870f4bfea1beccb116b908e555974b40 Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M perf/providerdoall.c Log Message: --- Convert providerdoall to be consistent in time measurement Convert it to do the same math the other tests do Reviewed-by: Matt Caswell Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/tools/pull/184) Commit: 3486229fa96bed8bbf4aa9e8f564236d9359f0d9 https://github.com/openssl/tools/commit/3486229fa96bed8bbf4aa9e8f564236d9359f0d9 Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M perf/randbytes.c Log Message: --- convert randbytes to use consistent time measurements modify randbytes to measure time the way the other tests do Reviewed-by: Matt Caswell Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/tools/pull/184) Commit: 7efe27febfa3bc9ba526142e52dfe0b7fc64dceb https://github.com/openssl/tools/commit/7efe27febfa3bc9ba526142e52dfe0b7fc64dceb Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M perf/rsasign.c Log Message: --- make rsasign measure time consistently Like the other tests, measure time per thread and average those Reviewed-by: Matt Caswell Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/tools/pull/184) Commit: 42debe8613e93c35ed5c53356bab9d728a1260fc https://github.com/openssl/tools/commit/42debe8613e93c35ed5c53356bab9d728a1260fc Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M perf/sslnew.c Log Message: --- convert sslnew to measure time consistently Make it do the same math the other tests do Reviewed-by: Matt Caswell Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/tools/pull/184) Commit: 2db2bd1fc22cc077386cc73ec38982bcd87400d3 https://github.com/openssl/tools/commit/2db2bd1fc22cc077386cc73ec38982bcd87400d3 Author: Neil Horman Date: 2024-05-02 (Thu, 02 May 2024) Changed paths: M perf/newrawkey.c M perf/pemread.c M perf/providerdoall.c M perf/rsasign.c M perf/x509storeissuer.c Log Message: --- make x509storeissuer do timekeeping like the other tests Also, while I'm in here, fix an aliasing issue in threadcount, in which the main routine had a variable overriding the global one. Reviewed-by: Matt Caswell Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/tools/pull/184) Commit: 58b7b94ae5f674e9665f9d9c816efa3c28fce4e6 https://github.com/openssl/tools/commit/58b7b94ae5f674e9665f9d9c816efa3c28fce4e6 Author: Neil Horman Date: 2024-05-02 (Thu, 02 May 2024) Changed paths: M perf/handshake.c M perf/newrawkey.c M perf/pemread.c M perf/providerdoall.c M perf/randbytes.c M perf/rsasign.c M perf/sslnew.c Log Message: --- Convert all perf tools to not use ossl_time_divide It looses information as its doing integer division Reviewed-by: Matt Caswell Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/tools/pull/184) Compare: https://github.com/openssl/tools/compare/291a58020944...58b7b94ae5f6 To unsubscribe from these emails, change your notification settings at https://github.com/openssl/tools/settings/notifications
[openssl/openssl] 067fbc: Reduce optimization in hppa builds
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: 067fbc01b9e867b31c71091d62f0f9012dc9e41a https://github.com/openssl/openssl/commit/067fbc01b9e867b31c71091d62f0f9012dc9e41a Author: Neil Horman Date: 2024-05-02 (Thu, 02 May 2024) Changed paths: M .github/workflows/cross-compiles.yml Log Message: --- Reduce optimization in hppa builds We're getting some odd errors in the lhash test on hppa. Analysis shows that the crash is happening randomly in various places, but always occurs during an indexed load of register r11 or r23. Root cause hasn't been completely determined, but given that: 1) hppa is an unadopted platform 2) asan/ubsan/threadsan shows no issues with the affected code elsewhere 3) The hppa build does not have threading enabled 4) reducing the optimization level to 01 quashes the problem The belief is that this is either a bug in gcc optimization, or an issue in the qemu emulator we use to test. Since this is causing CI failures, I'm proposing that we just lower the optimization level of the build to -01 to avoid the problem, and address it more throughly should an actual platform user encounter an error Fixes #24272 Reviewed-by: Matt Caswell Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/24318) To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
[openssl/tools] 352d32: adjust newraw key to record time like the handshak...
Branch: refs/heads/fix-stats Home: https://github.com/openssl/tools Commit: 352d322c2ca5530de14f24436b92d550cfde0c77 https://github.com/openssl/tools/commit/352d322c2ca5530de14f24436b92d550cfde0c77 Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M perf/newrawkey.c Log Message: --- adjust newraw key to record time like the handshake test the handshake test records the average time of each thread running its test, while other tests record the overall duration, leading to inconsistencies in how we do measurement. Bring newrawkey into line with how handshake does it. Commit: 8a3e7cae16dfe86877c7f9188471e07164812e40 https://github.com/openssl/tools/commit/8a3e7cae16dfe86877c7f9188471e07164812e40 Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M perf/pemread.c Log Message: --- convert pemread to be consistent in its time measurement like handshake and newrawkey, record times per thread and average them Commit: 7b5e2edc8bc51970e86dc9125944acdad40c2ae9 https://github.com/openssl/tools/commit/7b5e2edc8bc51970e86dc9125944acdad40c2ae9 Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M perf/providerdoall.c Log Message: --- Convert providerdoall to be consistent in time measurement Convert it to do the same math the other tests do Commit: 18ada4f6390ede55dbe4aa45a80899223277ff2f https://github.com/openssl/tools/commit/18ada4f6390ede55dbe4aa45a80899223277ff2f Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M perf/randbytes.c Log Message: --- convert randbytes to use consistent time measurements modify randbytes to measure time the way the other tests do Commit: a4ccf92b254c5ed51aebe19db12aeaaa5576b077 https://github.com/openssl/tools/commit/a4ccf92b254c5ed51aebe19db12aeaaa5576b077 Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M perf/rsasign.c Log Message: --- make rsasign measure time consistently Like the other tests, measure time per thread and average those Commit: 4ca43da6822c3aee640522c526ae515e40893a73 https://github.com/openssl/tools/commit/4ca43da6822c3aee640522c526ae515e40893a73 Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M perf/sslnew.c Log Message: --- convert sslnew to measure time consistently Make it do the same math the other tests do Commit: 13fe31415f8a2333b13fd8691ad20156fa2cdbfe https://github.com/openssl/tools/commit/13fe31415f8a2333b13fd8691ad20156fa2cdbfe Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M perf/x509storeissuer.c Log Message: --- make x509storeissuer do timekeeping like the other tests Also, while I'm in here, fix an aliasing issue in threadcount, in which the main routine had a variable overriding the global one. Commit: cdd4959a97f99488df9f51cecd30b54d469733a1 https://github.com/openssl/tools/commit/cdd4959a97f99488df9f51cecd30b54d469733a1 Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M perf/newrawkey.c M perf/pemread.c M perf/providerdoall.c M perf/rsasign.c Log Message: --- fixup! make x509storeissuer do timekeeping like the other tests Compare: https://github.com/openssl/tools/compare/352d322c2ca5%5E...cdd4959a97f9 To unsubscribe from these emails, change your notification settings at https://github.com/openssl/tools/settings/notifications
[openssl/openssl] c04901: Fix alignment errors in hashtable fuzzer
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: c04901be78768eb698d575d0b046940a5cb2aa5b https://github.com/openssl/openssl/commit/c04901be78768eb698d575d0b046940a5cb2aa5b Author: Neil Horman Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M fuzz/hashtable.c Log Message: --- Fix alignment errors in hashtable fuzzer we extract several values (uint16_t and uint64_t from the fuzzer buff passed in, but they weren't aligned on 2 and 8 byte boundaries. Adjust the fuzzer to memcpy data to the target variables to avoid unalignment issues Fixes #24272 Reviewed-by: Paul Dale Reviewed-by: Tom Cosgrove (Merged from https://github.com/openssl/openssl/pull/24276) To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
[openssl/openssl] 3dcd85: Make a failure in ktls_sendfile a syscall error
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: 3dcd85139f30625f2e4d072fe2b0f211f76f819c https://github.com/openssl/openssl/commit/3dcd85139f30625f2e4d072fe2b0f211f76f819c Author: Neil Horman Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M ssl/ssl_lib.c Log Message: --- Make a failure in ktls_sendfile a syscall error a failure in ktls_sendfile results in an error in ERR_LIB_SSL, but its really a syscall error, since ktls_sendfile just maps to a call to the sendfile syscall. Encode it as such Fixes #23722 Reviewed-by: Matt Caswell Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/23723) Commit: 933f57dfe21657f7aba8f13e0cdb3b02dd64fcc3 https://github.com/openssl/openssl/commit/933f57dfe21657f7aba8f13e0cdb3b02dd64fcc3 Author: Neil Horman Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M ssl/record/methods/tls_common.c Log Message: --- Raise an error on syscall failure in tls_retry_write_records Record the errno when we get a syscall failure in tls_retry_write_records Reviewed-by: Matt Caswell Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/23723) Compare: https://github.com/openssl/openssl/compare/3059052992ab...933f57dfe216 To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
[openssl/openssl] badda7: Fix coverity-1596616
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: badda78325dd961fa41a107796f2744ffbe8b265 https://github.com/openssl/openssl/commit/badda78325dd961fa41a107796f2744ffbe8b265 Author: Neil Horman Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M crypto/hashtable/hashtable.c Log Message: --- Fix coverity-1596616 Need to add a null check prior to derefencing pointer for free Reviewed-by: Matt Caswell Reviewed-by: Paul Dale Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/24263) Commit: 3059052992ab61b0ba560ddf48111cecb5158ae2 https://github.com/openssl/openssl/commit/3059052992ab61b0ba560ddf48111cecb5158ae2 Author: Neil Horman Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M crypto/conf/conf_mod.c Log Message: --- Fix coverity 1596617 Somehow a double free slipped into conf_mod.c, remove it Reviewed-by: Matt Caswell Reviewed-by: Paul Dale Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/24263) Compare: https://github.com/openssl/openssl/compare/bde66e828dd2...3059052992ab To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
[openssl/openssl] b6456a: set module path from template
Branch: refs/heads/openssl-3.0 Home: https://github.com/openssl/openssl Commit: b6456af5c043397998997a4f91348fb0aeca2625 https://github.com/openssl/openssl/commit/b6456af5c043397998997a4f91348fb0aeca2625 Author: Neil Horman Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M crypto/provider_core.c Log Message: --- set module path from template Modules that aren't activated at conf load time don't seem to set the module path from the template leading to load failures. Make sure to set that Fixes #24020 Reviewed-by: Matt Caswell Reviewed-by: Richard Levitte Reviewed-by: Tomas Mraz (cherry picked from commit bc9595963a45e28e6a8b2de45a6719c252bd3a3d) (Merged from https://github.com/openssl/openssl/pull/24198) (cherry picked from commit 71e5bb982f9c9563567ea8ae9f6e29492e9146ca) Commit: 74f551e90c3415bd391add232a93d433fb052b55 https://github.com/openssl/openssl/commit/74f551e90c3415bd391add232a93d433fb052b55 Author: Neil Horman Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M test/build.info A test/pathed.cnf M test/prov_config_test.c M test/recipes/30-test_prov_config.t Log Message: --- Add test for OSSL_PROVIDER_load with module path set Ensure that, with the modulepath setting set in a config field, that we are able to load a provider from the path relative to OPENSSL_MODULES Reviewed-by: Matt Caswell Reviewed-by: Richard Levitte Reviewed-by: Tomas Mraz (cherry picked from commit 91a77cbf66c575345cf1eab31717e8edafcd1633) (Merged from https://github.com/openssl/openssl/pull/24198) (cherry picked from commit db163245097bc813235403c234795721d4e5c4eb) Commit: f663322bd61312a07d678fe3b22e517180653a37 https://github.com/openssl/openssl/commit/f663322bd61312a07d678fe3b22e517180653a37 Author: Neil Horman Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M test/prov_config_test.c Log Message: --- Update modulepath test for provider config to skip if not present If the p_test.so library isn't present, don't run the test Reviewed-by: Matt Caswell Reviewed-by: Richard Levitte Reviewed-by: Tomas Mraz (cherry picked from commit b80fed3f27ebe156b17246f7c12c5178cbe6834e) (Merged from https://github.com/openssl/openssl/pull/24198) (cherry picked from commit 83c649996c18e5185f9439172d5908ad7fef9146) Commit: 25e1d8dcdedaa0e99218b4dd24f82a11f2a470eb https://github.com/openssl/openssl/commit/25e1d8dcdedaa0e99218b4dd24f82a11f2a470eb Author: Neil Horman Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M crypto/provider_core.c M test/prov_config_test.c Log Message: --- Fix up path generation to use OPENSSL_MODULES Reviewed-by: Matt Caswell Reviewed-by: Richard Levitte Reviewed-by: Tomas Mraz (cherry picked from commit 4e3c1e6206251c59855362d6d2edab4621c31dec) (Merged from https://github.com/openssl/openssl/pull/24198) (cherry picked from commit 163202f0b95cfc7e666e45cafc55a505f51f6153) Commit: 491ff1b13bdabad24384cc0c19c6dd7532693613 https://github.com/openssl/openssl/commit/491ff1b13bdabad24384cc0c19c6dd7532693613 Author: Neil Horman Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M test/prov_config_test.c Log Message: --- Fix missing NULL check in prov_config_test coverity-1596500 caught a missing null check. We should never hit it as the test harness always sets the environment variable, but lets add the check for safety Reviewed-by: Tomas Mraz Reviewed-by: Tom Cosgrove Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/24198) (cherry picked from commit a380ec952f138f644d227637eeba90fd1e17f72f) Compare: https://github.com/openssl/openssl/compare/f0115d45072a...491ff1b13bda To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
[openssl/openssl] 71e5bb: set module path from template
Branch: refs/heads/openssl-3.1 Home: https://github.com/openssl/openssl Commit: 71e5bb982f9c9563567ea8ae9f6e29492e9146ca https://github.com/openssl/openssl/commit/71e5bb982f9c9563567ea8ae9f6e29492e9146ca Author: Neil Horman Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M crypto/provider_core.c Log Message: --- set module path from template Modules that aren't activated at conf load time don't seem to set the module path from the template leading to load failures. Make sure to set that Fixes #24020 Reviewed-by: Matt Caswell Reviewed-by: Richard Levitte Reviewed-by: Tomas Mraz (cherry picked from commit bc9595963a45e28e6a8b2de45a6719c252bd3a3d) (Merged from https://github.com/openssl/openssl/pull/24198) Commit: db163245097bc813235403c234795721d4e5c4eb https://github.com/openssl/openssl/commit/db163245097bc813235403c234795721d4e5c4eb Author: Neil Horman Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M test/build.info A test/pathed.cnf M test/prov_config_test.c M test/recipes/30-test_prov_config.t Log Message: --- Add test for OSSL_PROVIDER_load with module path set Ensure that, with the modulepath setting set in a config field, that we are able to load a provider from the path relative to OPENSSL_MODULES Reviewed-by: Matt Caswell Reviewed-by: Richard Levitte Reviewed-by: Tomas Mraz (cherry picked from commit 91a77cbf66c575345cf1eab31717e8edafcd1633) (Merged from https://github.com/openssl/openssl/pull/24198) Commit: 83c649996c18e5185f9439172d5908ad7fef9146 https://github.com/openssl/openssl/commit/83c649996c18e5185f9439172d5908ad7fef9146 Author: Neil Horman Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M test/prov_config_test.c Log Message: --- Update modulepath test for provider config to skip if not present If the p_test.so library isn't present, don't run the test Reviewed-by: Matt Caswell Reviewed-by: Richard Levitte Reviewed-by: Tomas Mraz (cherry picked from commit b80fed3f27ebe156b17246f7c12c5178cbe6834e) (Merged from https://github.com/openssl/openssl/pull/24198) Commit: 163202f0b95cfc7e666e45cafc55a505f51f6153 https://github.com/openssl/openssl/commit/163202f0b95cfc7e666e45cafc55a505f51f6153 Author: Neil Horman Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M crypto/provider_core.c M test/prov_config_test.c Log Message: --- Fix up path generation to use OPENSSL_MODULES Reviewed-by: Matt Caswell Reviewed-by: Richard Levitte Reviewed-by: Tomas Mraz (cherry picked from commit 4e3c1e6206251c59855362d6d2edab4621c31dec) (Merged from https://github.com/openssl/openssl/pull/24198) Commit: a380ec952f138f644d227637eeba90fd1e17f72f https://github.com/openssl/openssl/commit/a380ec952f138f644d227637eeba90fd1e17f72f Author: Neil Horman Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M test/prov_config_test.c Log Message: --- Fix missing NULL check in prov_config_test coverity-1596500 caught a missing null check. We should never hit it as the test harness always sets the environment variable, but lets add the check for safety Reviewed-by: Tomas Mraz Reviewed-by: Tom Cosgrove Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/24198) Compare: https://github.com/openssl/openssl/compare/17f448ede695...a380ec952f13 To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
