Re: [openstack-dev] [nova][api] Pagination in thre API
As a consumer of such APIs on the Horizon side, I'm all for consistency in pagination, and more of it, so yes please! On 5 November 2015 at 13:24, Tony Breedswrote: > On Thu, Nov 05, 2015 at 01:09:36PM +1100, Tony Breeds wrote: > > Hi All, > > Around the middle of October a spec [1] was uploaded to add > pagination > > support to the os-hypervisors API. While I recognize the use case it > seemed > > like adding another pagination implementation wasn't an awesome idea. > > > > Today I see 3 more requests to add pagination to APIs [2] > > > > Perhaps I'm over thinking it but should we do something more strategic > rather > > than scattering "add pagination here". > > > > It looks to me like we have at least 3 parties interested in this. > > > > Yours Tony. > > > > [1] https://review.openstack.org/#/c/234038 > > [2] > https://review.openstack.org/#/q/message:pagination+project:openstack/nova-specs+status:open,n,z > > Sorry about the send without complete subject. > > Yours Tony. > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova][api] Pagination in thre API
On 5 November 2015 at 09:46, Richard Joneswrote: > As a consumer of such APIs on the Horizon side, I'm all for consistency in > pagination, and more of it, so yes please! > > On 5 November 2015 at 13:24, Tony Breeds wrote: >> >> On Thu, Nov 05, 2015 at 01:09:36PM +1100, Tony Breeds wrote: >> > Hi All, >> > Around the middle of October a spec [1] was uploaded to add >> > pagination >> > support to the os-hypervisors API. While I recognize the use case it >> > seemed >> > like adding another pagination implementation wasn't an awesome idea. >> > >> > Today I see 3 more requests to add pagination to APIs [2] >> > >> > Perhaps I'm over thinking it but should we do something more strategic >> > rather >> > than scattering "add pagination here". +1 The plan, as I understand it, is to first finish off this API WG guideline: http://specs.openstack.org/openstack/api-wg/guidelines/pagination_filter_sort.html Once we have agreement, we can try to support that in a new micro version. Important as this is, for mitaka, we agreed to focus on documentation, not resolve this API inconsistencies/wrinkles: http://specs.openstack.org/openstack/nova-specs/priorities/mitaka-priorities.html#v2-1-api I would love to see us work with the API WG and get that guideline completed by the end of Mitaka, so we can implement something next cycle. If we get to implementing sooner, then awesome, but thats assuming we have the API documentation work complete first. Thanks, John >> > >> > [1] https://review.openstack.org/#/c/234038 >> > [2] >> > https://review.openstack.org/#/q/message:pagination+project:openstack/nova-specs+status:open,n,z >> >> Sorry about the send without complete subject. >> >> Yours Tony. >> >> __ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova][api] Pagination in thre API
So lets work on the API WG guideline first, looking forward to get it done sooner, pagination is actually very useful in production deployment. On Thu, Nov 5, 2015 at 11:16 PM, Everett Toewswrote: > On Nov 5, 2015, at 5:44 AM, John Garbutt wrote: > > > On 5 November 2015 at 09:46, Richard Jones wrote: > > As a consumer of such APIs on the Horizon side, I'm all for consistency in > pagination, and more of it, so yes please! > > On 5 November 2015 at 13:24, Tony Breeds wrote: > > > On Thu, Nov 05, 2015 at 01:09:36PM +1100, Tony Breeds wrote: > > Hi All, >Around the middle of October a spec [1] was uploaded to add > pagination > support to the os-hypervisors API. While I recognize the use case it > seemed > like adding another pagination implementation wasn't an awesome idea. > > Today I see 3 more requests to add pagination to APIs [2] > > Perhaps I'm over thinking it but should we do something more strategic > rather > than scattering "add pagination here". > > > +1 > > The plan, as I understand it, is to first finish off this API WG guideline: > > http://specs.openstack.org/openstack/api-wg/guidelines/pagination_filter_sort.html > > > > An attempt at an API guideline for pagination is here [1] but hasn't > received any updates in over a month, which can be understandable as > sometimes other work takes precedence. > > Perhaps we can get that guideline moving again? > > If it's becoming difficult to reach agreement on that approach in the > guideline, it could be worthwhile to take a step back and do some analysis > on the way pagination is done in the more established APIs. I've found that > such analysis can be very helpful as you're moving forward from a known > state. > > The place for that analysis is in Current Design [2] by filling in the > Pagination page. You can find many examples of such analysis from the > Current Design like Sorting [3]. > > Cheers, > Everett > > > [1] https://review.openstack.org/#/c/190743/ > [2] https://wiki.openstack.org/wiki/API_Working_Group/Current_Design > [3] > https://wiki.openstack.org/wiki/API_Working_Group/Current_Design/Sorting > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova][api] Pagination in thre API
On Nov 5, 2015, at 5:44 AM, John Garbutt> wrote: On 5 November 2015 at 09:46, Richard Jones > wrote: As a consumer of such APIs on the Horizon side, I'm all for consistency in pagination, and more of it, so yes please! On 5 November 2015 at 13:24, Tony Breeds > wrote: On Thu, Nov 05, 2015 at 01:09:36PM +1100, Tony Breeds wrote: Hi All, Around the middle of October a spec [1] was uploaded to add pagination support to the os-hypervisors API. While I recognize the use case it seemed like adding another pagination implementation wasn't an awesome idea. Today I see 3 more requests to add pagination to APIs [2] Perhaps I'm over thinking it but should we do something more strategic rather than scattering "add pagination here". +1 The plan, as I understand it, is to first finish off this API WG guideline: http://specs.openstack.org/openstack/api-wg/guidelines/pagination_filter_sort.html An attempt at an API guideline for pagination is here [1] but hasn't received any updates in over a month, which can be understandable as sometimes other work takes precedence. Perhaps we can get that guideline moving again? If it's becoming difficult to reach agreement on that approach in the guideline, it could be worthwhile to take a step back and do some analysis on the way pagination is done in the more established APIs. I've found that such analysis can be very helpful as you're moving forward from a known state. The place for that analysis is in Current Design [2] by filling in the Pagination page. You can find many examples of such analysis from the Current Design like Sorting [3]. Cheers, Everett [1] https://review.openstack.org/#/c/190743/ [2] https://wiki.openstack.org/wiki/API_Working_Group/Current_Design [3] https://wiki.openstack.org/wiki/API_Working_Group/Current_Design/Sorting __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova][api] Pagination in thre API
On Thu, Nov 05, 2015 at 01:09:36PM +1100, Tony Breeds wrote: > Hi All, > Around the middle of October a spec [1] was uploaded to add pagination > support to the os-hypervisors API. While I recognize the use case it seemed > like adding another pagination implementation wasn't an awesome idea. > > Today I see 3 more requests to add pagination to APIs [2] > > Perhaps I'm over thinking it but should we do something more strategic rather > than scattering "add pagination here". > > It looks to me like we have at least 3 parties interested in this. > > Yours Tony. > > [1] https://review.openstack.org/#/c/234038 > [2] > https://review.openstack.org/#/q/message:pagination+project:openstack/nova-specs+status:open,n,z Sorry about the send without complete subject. Yours Tony. pgplqNDkgelpr.pgp Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev