Re: [ovs-dev] [PATCH] utilities: Correct deletion reason in flow_reval_monitor.py.
On 5/2/24 12:11, Eelco Chaudron wrote:
> The flow_reval_monitor.py script incorrectly reported the reasons for
> FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
> This patch rectifies the order.
>
> Fixes: 86b9e653ef22 ("revalidator: Add a USDT probe during flow deletion with
> purge reason.")
> Signed-off-by: Eelco Chaudron
> ---
> utilities/usdt-scripts/flow_reval_monitor.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utilities/usdt-scripts/flow_reval_monitor.py
> b/utilities/usdt-scripts/flow_reval_monitor.py
> index 534ba8fa2..117f5bc27 100755
> --- a/utilities/usdt-scripts/flow_reval_monitor.py
> +++ b/utilities/usdt-scripts/flow_reval_monitor.py
> @@ -262,8 +262,8 @@ FdrReasonStrings = [
> "Kill all flows condition detected",
> "Mask too wide - need narrower match",
> "No matching ofproto rules",
> -"Too expensive to revalidate",
> "Purged with user action",
> +"Too expensive to revalidate",
> "Flow state inconsistent after updates",
> "Flow translation error",
> ]
Hi, Eelco. Thanks for the fix!
Did you consider changing this array to a dictionary? This may help
avoiding such issues in the future.
A few other general notes:
We may consider adding a comment to the C definition of the enum that
python version should be kept in sync.
Comments in the .c file and the descriptions here are fairly different
as well. That may be a little confusing.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] utilities: Correct deletion reason in flow_reval_monitor.py.
On 5/2/24 12:11 PM, Eelco Chaudron wrote:
The flow_reval_monitor.py script incorrectly reported the reasons for
FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
This patch rectifies the order.
Fixes: 86b9e653ef22 ("revalidator: Add a USDT probe during flow deletion with purge
reason.")
Signed-off-by: Eelco Chaudron
---
utilities/usdt-scripts/flow_reval_monitor.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/usdt-scripts/flow_reval_monitor.py
b/utilities/usdt-scripts/flow_reval_monitor.py
index 534ba8fa2..117f5bc27 100755
--- a/utilities/usdt-scripts/flow_reval_monitor.py
+++ b/utilities/usdt-scripts/flow_reval_monitor.py
@@ -262,8 +262,8 @@ FdrReasonStrings = [
"Kill all flows condition detected",
"Mask too wide - need narrower match",
"No matching ofproto rules",
-"Too expensive to revalidate",
"Purged with user action",
+"Too expensive to revalidate",
"Flow state inconsistent after updates",
"Flow translation error",
]
Reviewed-by: Adrian Moreno
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH] utilities: Correct deletion reason in flow_reval_monitor.py.
The flow_reval_monitor.py script incorrectly reported the reasons for
FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
This patch rectifies the order.
Fixes: 86b9e653ef22 ("revalidator: Add a USDT probe during flow deletion with
purge reason.")
Signed-off-by: Eelco Chaudron
---
utilities/usdt-scripts/flow_reval_monitor.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/usdt-scripts/flow_reval_monitor.py
b/utilities/usdt-scripts/flow_reval_monitor.py
index 534ba8fa2..117f5bc27 100755
--- a/utilities/usdt-scripts/flow_reval_monitor.py
+++ b/utilities/usdt-scripts/flow_reval_monitor.py
@@ -262,8 +262,8 @@ FdrReasonStrings = [
"Kill all flows condition detected",
"Mask too wide - need narrower match",
"No matching ofproto rules",
-"Too expensive to revalidate",
"Purged with user action",
+"Too expensive to revalidate",
"Flow state inconsistent after updates",
"Flow translation error",
]
--
2.43.0
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
