Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Document "--portrange" in the manpage.

[Dumitru Ceara]

On 4/17/24 08:28, Ales Musil wrote:
> On Mon, Apr 15, 2024 at 8:21 PM Mark Michelson  wrote:
> 
>> The --portrange option was added in commit [0]. The option appears in
>> the help text for ovn-nbctl, but it is not documented in the manpage at
>> all.
>>
>> This commit adds documentation to the manpage for the --portrange
>> option.
>>
>> Reported-at: https://issues.redhat.com/browse/FDP-537
>> Signed-off-by: Mark Michelson 
>> ---
>>  utilities/ovn-nbctl.8.xml | 14 +-
>>  1 file changed, 13 insertions(+), 1 deletion(-)
>>
>> diff --git a/utilities/ovn-nbctl.8.xml b/utilities/ovn-nbctl.8.xml
>> index 39c352212..ea2b201a5 100644
>> --- a/utilities/ovn-nbctl.8.xml
>> +++ b/utilities/ovn-nbctl.8.xml
>> @@ -1175,7 +1175,7 @@
>>  NAT Commands
>>
>>  
>> -  [--may-exist] [--stateless]
>> [--gateway-port=GATEWAY_PORT]
>> lr-nat-add router type
>> external_ip logical_ip [logical_port
>> external_mac]
>> +  [--may-exist] [--stateless]
>> [--gateway-port=GATEWAY_PORT] [--portrange]
>> lr-nat-add router type
>> external_ip logical_ip [logical_port
>> external_mac] [external_port_range]
>>
>>  
>>Adds the specified NAT to router.
>> @@ -1212,6 +1212,18 @@
>>specify the GATEWAY_PORT.
>>  
>>
>> +
>> +  If the --portrange option is specified, then a
>> range of
>> +  ports may be specified in the external_port_range
>> part
>> +  of the lr-nat-add command. If this option is
>> omitted,
>> +  then an external port range may not be specified. The format of
>> the
>> +  port range is port_low-port_high, where
>> +  port_low is a lower number than
>> port_high. When
>> +  the packet is NATted, a random port from the range will be
>> selected
>> +  as the source port. The range for the
>> +  external_port_range is 1-65535.
>> +
>> +
>>  
>>When type is dnat, the externally
>>visible IP address external_ip is DNATted to the
>> --
>> 2.44.0
>>
>> ___
>> dev mailing list
>> d...@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>
>>
> Looks good to me, thanks.
> 
> Acked-by: Ales Musil 
> 

Thanks, Mark and Ales!  Applied to main and backported down to 23.06.

Regards,
Dumitru


___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Document "--portrange" in the manpage.

[Ales Musil]

On Mon, Apr 15, 2024 at 8:21 PM Mark Michelson  wrote:

> The --portrange option was added in commit [0]. The option appears in
> the help text for ovn-nbctl, but it is not documented in the manpage at
> all.
>
> This commit adds documentation to the manpage for the --portrange
> option.
>
> Reported-at: https://issues.redhat.com/browse/FDP-537
> Signed-off-by: Mark Michelson 
> ---
>  utilities/ovn-nbctl.8.xml | 14 +-
>  1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/utilities/ovn-nbctl.8.xml b/utilities/ovn-nbctl.8.xml
> index 39c352212..ea2b201a5 100644
> --- a/utilities/ovn-nbctl.8.xml
> +++ b/utilities/ovn-nbctl.8.xml
> @@ -1175,7 +1175,7 @@
>  NAT Commands
>
>  
> -  [--may-exist] [--stateless]
> [--gateway-port=GATEWAY_PORT]
> lr-nat-add router type
> external_ip logical_ip [logical_port
> external_mac]
> +  [--may-exist] [--stateless]
> [--gateway-port=GATEWAY_PORT] [--portrange]
> lr-nat-add router type
> external_ip logical_ip [logical_port
> external_mac] [external_port_range]
>
>  
>Adds the specified NAT to router.
> @@ -1212,6 +1212,18 @@
>specify the GATEWAY_PORT.
>  
>
> +
> +  If the --portrange option is specified, then a
> range of
> +  ports may be specified in the external_port_range
> part
> +  of the lr-nat-add command. If this option is
> omitted,
> +  then an external port range may not be specified. The format of
> the
> +  port range is port_low-port_high, where
> +  port_low is a lower number than
> port_high. When
> +  the packet is NATted, a random port from the range will be
> selected
> +  as the source port. The range for the
> +  external_port_range is 1-65535.
> +
> +
>  
>When type is dnat, the externally
>visible IP address external_ip is DNATted to the
> --
> 2.44.0
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Looks good to me, thanks.

Acked-by: Ales Musil 

-- 

Ales Musil

Senior Software Engineer - OVN Core

Red Hat EMEA 

amu...@redhat.com

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Document "--portrange" in the manpage.

[0-day Robot]

Bleep bloop.  Greetings Mark Michelson, I am a robot and I have tried out your 
patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 322 characters long (recommended limit is 79)
#28 FILE: utilities/ovn-nbctl.8.xml:1178:
  [--may-exist] [--stateless] 
[--gateway-port=GATEWAY_PORT] [--portrange] 
lr-nat-add router type 
external_ip logical_ip [logical_port 
external_mac] [external_port_range]

Lines checked: 54, Warnings: 1, Errors: 0


Please check this out.  If you feel there has been an error, please email 
acon...@redhat.com

Thanks,
0-day Robot
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] ovn-nbctl: Document "--portrange" in the manpage.

[Mark Michelson]

The --portrange option was added in commit [0]. The option appears in
the help text for ovn-nbctl, but it is not documented in the manpage at
all.

This commit adds documentation to the manpage for the --portrange
option.

Reported-at: https://issues.redhat.com/browse/FDP-537
Signed-off-by: Mark Michelson 
---
 utilities/ovn-nbctl.8.xml | 14 +-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/utilities/ovn-nbctl.8.xml b/utilities/ovn-nbctl.8.xml
index 39c352212..ea2b201a5 100644
--- a/utilities/ovn-nbctl.8.xml
+++ b/utilities/ovn-nbctl.8.xml
@@ -1175,7 +1175,7 @@
 NAT Commands
 
 
-  [--may-exist] [--stateless] 
[--gateway-port=GATEWAY_PORT] lr-nat-add 
router type external_ip logical_ip 
[logical_port external_mac]
+  [--may-exist] [--stateless] 
[--gateway-port=GATEWAY_PORT] [--portrange] 
lr-nat-add router type 
external_ip logical_ip [logical_port 
external_mac] [external_port_range]
   
 
   Adds the specified NAT to router.
@@ -1212,6 +1212,18 @@
   specify the GATEWAY_PORT.
 
 
+
+  If the --portrange option is specified, then a range of
+  ports may be specified in the external_port_range part
+  of the lr-nat-add command. If this option is omitted,
+  then an external port range may not be specified. The format of the
+  port range is port_low-port_high, where
+  port_low is a lower number than port_high. When
+  the packet is NATted, a random port from the range will be selected
+  as the source port. The range for the
+  external_port_range is 1-65535.
+
+
 
   When type is dnat, the externally
   visible IP address external_ip is DNATted to the
-- 
2.44.0

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev