Re: Bug in current revision
On Oct 18, 2011, at 12:05 AM, Gerd Pokorra wrote: currently perl Configure.pl; make ist broken on my Fedora 15: src/pmc/packfileannotations.c: In function 'Parrot_PackfileAnnotations_nci_set_directory': src/pmc/packfileannotations.c:238:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] cc1: some warnings being treated as errors make: *** [src/pmc/packfileannotations.o] Error 1 Whoops. I wonder how that slipped by me. I did compile it locally earlier. But now it fails for me too. Strange. Will push a fix in a moment. ~~ benabik ___ http://lists.parrot.org/mailman/listinfo/parrot-dev
Re: Bug in current revision
On 10/18/11 7:57 AM, Brian Gernhardt wrote: On Oct 18, 2011, at 12:05 AM, Gerd Pokorra wrote: currently perl Configure.pl; make ist broken on my Fedora 15: src/pmc/packfileannotations.c: In function 'Parrot_PackfileAnnotations_nci_set_directory': src/pmc/packfileannotations.c:238:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] cc1: some warnings being treated as errors make: *** [src/pmc/packfileannotations.o] Error 1 Whoops. I wonder how that slipped by me. I did compile it locally earlier. But now it fails for me too. Strange. As of about 2100 ET last night, Parrot was PASSing for me as follows: linux/i386: make test: regular; optimize; all-g++ build; all-g++ build w/optimize; also: 'make fulltest' darwin/ppc: make test (my regular build) So any failures we observe there are probably due to commits made after that time. This close to release time, we should be doing commits to sensitive core files (such as those related to packfiles) only in branches (unless the release manager specifies otherwise). Should 'make headerizer' have been run? Parrot now appears to be compiling for me on linux/i386, but that's all I can report now. Thank you very much. Jim Keenan ___ http://lists.parrot.org/mailman/listinfo/parrot-dev
Re: Bug in current revision
On Oct 18, 2011, at 8:15 AM, James E Keenan wrote: So any failures we observe there are probably due to commits made after that time. This close to release time, we should be doing commits to sensitive core files (such as those related to packfiles) only in branches (unless the release manager specifies otherwise). I'm appropriately chastened. Although the Packfile PMCs are largely marked experimental, so I wouldn't exactly call them core. Should 'make headerizer' have been run? No, I think I just moved a line to the wrong place when cleaning up commits. With the code rearranged to the right places, everything should work now. ~~ Brian ___ http://lists.parrot.org/mailman/listinfo/parrot-dev
Re: Bug in current revision
Am Dienstag, den 18.10.2011, 14:19 +0200 schrieb Brian Gernhardt: On Oct 18, 2011, at 8:15 AM, James E Keenan wrote: No, I think I just moved a line to the wrong place when cleaning up commits. With the code rearranged to the right places, everything should work now. I still have the problem. Gerd ___ http://lists.parrot.org/mailman/listinfo/parrot-dev
Re: Bug in current revision
Hello No, I think I just moved a line to the wrong place when cleaning up commits. With the code rearranged to the right places, everything should work now. I still have the problem. Should be fixed in 0a87d4d86a -- Salu2 ___ http://lists.parrot.org/mailman/listinfo/parrot-dev
