Re: [PECL-DEV] I would like to take over PAM extension which isinactive since 2009

[Christoph M. Becker]

On 07.06.2021 at 15:22, Amish wrote:
>
>> 2/ Supported versions
>>
>> You say 7/8 but package.xml states > 8.0
>> Is it expected (will be nice to have all maintained versions)
>
> I use Arch Linux which supported PHP 7 till January. And then Arch Linux
> moved to PHP 8.
>
> And hence I had to fix the code to run on PHP 8.
>
> https://github.com/amishmm/php-pam/commit/efa0bf4079c2fd0cf8880a9aba1a9e7077a60648
>
>
> I am not a regular PHP coder. So I do not know how to "easily" make
> above commit work on both PHP 7 and PHP 8.

That should be fine for PHP 7 as well.  I suggest to setup CI (GH
actions are quite handy) so you can build/test against different PHP
versions.

--
Christoph M. Becker

--
PECL development discussion Mailing List (https://pecl.php.net/)
To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PECL-DEV] I would like to take over PAM extension which is inactive since 2009

[Amish]

On 07/06/21 6:33 pm, Remi Collet wrote:

Hi,

I noticed version 2.2.1 have been published on pecl

So, questions

1/ Where are the sources ?

Seems the linked github project is outdated (on 2.1 there) and no 
package.xml


I just became maintainer of this package on PECL where I published 
2.2.1. Still learning how to use PECL website.


I will update Github soon. Btw, Github is on 2.2 not 2.1.


2/ Supported versions

You say 7/8 but package.xml states > 8.0
Is it expected (will be nice to have all maintained versions)


I use Arch Linux which supported PHP 7 till January. And then Arch Linux 
moved to PHP 8.


And hence I had to fix the code to run on PHP 8.

https://github.com/amishmm/php-pam/commit/efa0bf4079c2fd0cf8880a9aba1a9e7077a60648

I am not a regular PHP coder. So I do not know how to "easily" make 
above commit work on both PHP 7 and PHP 8.


I know I need to put #ifdef but #ifdef on what variable?

If you know then please provide a PR or hint.


3/ ZTS

Looks like ZTS support is not ready
Segfault when  run with extension enabled

(gdb) bt
#0  zend_post_startup () at 
/usr/src/debug/php-7.4.20-1.fc33.remi.x86_64/Zend/zend.c:1015
#1  0x5577a59d in php_module_startup (sf=, 
additional_modules=, num_additional_modules=out>)

    at /usr/src/debug/php-7.4.20-1.fc33.remi.x86_64/main/main.c:2373
#2  0x55877cc1 in php_cli_startup (sapi_module=out>) at 
/usr/src/debug/php-7.4.20-1.fc33.remi.x86_64/sapi/cli/php_cli.c:410
#3  0x5563f45b in main (argc=6, argv=0x55e1b230) at 
/usr/src/debug/php-7.4.20-1.fc33.remi.x86_64/sapi/cli/php_cli.c:1326



I see that you have provided the PR. I will commit it soon.

Thanks.

Amish

--
PECL development discussion Mailing List (https://pecl.php.net/)
To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PECL-DEV] I would like to take over PAM extension which is inactive since 2009

[Remi Collet]

Hi,

Le 26/05/2021 à 07:28, Amish a écrit :

Hello,

My name is Amish and I am located in India and a coder since about 23 
years or so.


I would like to take over PAM extension located at 
https://pecl.php.net/package/PAM. The package is inactive since 2009.


I have improved the code to make it ready for PHP 7/8 at Github. And 
also added some additional features.


https://github.com/amishmm/php-pam


I noticed version 2.2.1 have been published on pecl

So, questions

1/ Where are the sources ?

Seems the linked github project is outdated (on 2.1 there) and no 
package.xml




2/ Supported versions

You say 7/8 but package.xml states > 8.0
Is it expected (will be nice to have all maintained versions)



3/ ZTS

Looks like ZTS support is not ready
Segfault when  run with extension enabled

(gdb) bt
#0  zend_post_startup () at 
/usr/src/debug/php-7.4.20-1.fc33.remi.x86_64/Zend/zend.c:1015
#1  0x5577a59d in php_module_startup (sf=, 
additional_modules=, num_additional_modules=)

at /usr/src/debug/php-7.4.20-1.fc33.remi.x86_64/main/main.c:2373
#2  0x55877cc1 in php_cli_startup (sapi_module=) 
at /usr/src/debug/php-7.4.20-1.fc33.remi.x86_64/sapi/cli/php_cli.c:410
#3  0x5563f45b in main (argc=6, argv=0x55e1b230) at 
/usr/src/debug/php-7.4.20-1.fc33.remi.x86_64/sapi/cli/php_cli.c:1326




Cheers,
Remi

--
PECL development discussion Mailing List (https://pecl.php.net/)
To unsubscribe, visit: https://www.php.net/unsub.php

[PECL-DEV] Re: I would like to take over PAM extension which isinactivesince2009 pecl-dev@lists.php.net

[Christoph M. Becker]

On 07.06.2021 at 14:42, Amish wrote:

> One suggestion that this link that you gave is kind of hidden next to
> "Edit Maintainers" under a tiny pencil icon.
> 
> Not easy to find for first time Maintainers.
> 
> Can it not be made textual link (say [Edit Package]) just like "Edit
> Maintainers"?

I agree that this is bad UX; consider to provide a PR to
. :)

-- 
Christoph M. Becker

-- 
PECL development discussion Mailing List (https://pecl.php.net/)
To unsubscribe, visit: https://www.php.net/unsub.php

[PECL-DEV] Re: I would like to take over PAM extension which is inactivesince2009

[Amish]

On 07/06/21 4:54 pm, Christoph M. Becker wrote:

On 07.06.2021 at 12:54, Amish wrote:


Ok I released a new version of PAM extension.

For some strange reason the package page still says:

   This package is not maintained, if you would like to take over please
go to this page.

https://pecl.php.net/package/PAM

Please also check if I have done anything wrong as I am completely new
to this pear and pecl thing.

I've disabled the warning about the package being unmaitained.  You may
want to update info on  to
point to the new repo, and also update or remove the documentation URL
there.


I have edited the links.

One suggestion that this link that you gave is kind of hidden next to 
"Edit Maintainers" under a tiny pencil icon.


Not easy to find for first time Maintainers.

Can it not be made textual link (say [Edit Package]) just like "Edit 
Maintainers"?


Regards,

Amish

--
PECL development discussion Mailing List (https://pecl.php.net/)
To unsubscribe, visit: https://www.php.net/unsub.php

[PECL-DEV] Re: I would like to take over PAM extension which is inactivesince2009

[Christoph M. Becker]

On 07.06.2021 at 12:54, Amish wrote:

> Ok I released a new version of PAM extension.
>
> For some strange reason the package page still says:
>
>   This package is not maintained, if you would like to take over please
> go to this page.
>
> https://pecl.php.net/package/PAM
>
> Please also check if I have done anything wrong as I am completely new
> to this pear and pecl thing.

I've disabled the warning about the package being unmaitained.  You may
want to update info on  to
point to the new repo, and also update or remove the documentation URL
there.

--
Christoph M. Becker

--
PECL development discussion Mailing List (https://pecl.php.net/)
To unsubscribe, visit: https://www.php.net/unsub.php

[PECL-DEV] Re: I would like to take over PAM extension which is inactive since2009

[Amish]

On 07/06/21 2:02 pm, Christoph M. Becker wrote:

On 07.06.2021 at 07:31, Amish wrote:

I had applied for PECL account on very same day (2nd June 2021) but I
haven't got any response yet.

Do I need to do anything else?

The page showed that it may take days, so do I need to wait more?

A notification mail should have been sent to the ML about your request,
but apparently was not.  Anyhow, I have approved your account request,
and added you as lead maintainer for the PAM package.

Good luck with maintaining the extension!  Feel free to ask any
questions you have on this ML.


Ok I released a new version of PAM extension.

For some strange reason the package page still says:

  This package is not maintained, if you would like to take over please 
go to this page.


https://pecl.php.net/package/PAM

Please also check if I have done anything wrong as I am completely new 
to this pear and pecl thing.


Thanks and regards,

Amish.

--
PECL development discussion Mailing List (https://pecl.php.net/)
To unsubscribe, visit: https://www.php.net/unsub.php

[PECL-DEV] Re: I would like to take over PAM extension which is inactive since2009

[Christoph M. Becker]

On 07.06.2021 at 07:31, Amish wrote:

> I had applied for PECL account on very same day (2nd June 2021) but I
> haven't got any response yet.
>
> Do I need to do anything else?
>
> The page showed that it may take days, so do I need to wait more?

A notification mail should have been sent to the ML about your request,
but apparently was not.  Anyhow, I have approved your account request,
and added you as lead maintainer for the PAM package.

Good luck with maintaining the extension!  Feel free to ask any
questions you have on this ML.

--
Christoph M. Becker

--
PECL development discussion Mailing List (https://pecl.php.net/)
To unsubscribe, visit: https://www.php.net/unsub.php