Re: [petsc-dev] Push restrictions on branches

2013-10-21 Thread Karl Rupp

Hi Jed,

 Bitbucket added support to restrict push access based on branch names

(glob matching).  For example, that would allow us to have a smaller
group of people with access to merge to 'maint' or 'master'.

Is this a feature we should start using in petsc.git?


I set this restriction on maint*, master, and next.  The integrators
group currently contains Barry, Hong, Karl, Matt, Peter, Satish, and
myself.  Everyone else with write access is still able to push to any
other branches.  We can amend or cancel this at any time.


Thanks! That should avoid accidental pushes to branches if git is not 
configured to use the 'simple' push.default.


Best regards,
Karli


Re: [petsc-dev] Push restrictions on branches

2013-10-21 Thread Jed Brown
Karl Rupp r...@mcs.anl.gov writes:
 Thanks! That should avoid accidental pushes to branches if git is not 
 configured to use the 'simple' push.default.

Yeah, I was worried about sometimes asking people to force-push branches
when they also have the ability to force-push integration branches.

For this reason, I was recommending the syntax

  $ git push origin +your/branch-name

over

  $ git push --force  # assume branch upstream has already been set

since the latter depends on push.default.  I still recommend the
explicit version for this, but it's less dangerous now since people
rarely check out non-integration branches that are not their own.


pgpDl1LbnDXzp.pgp
Description: PGP signature


Re: [petsc-dev] Push restrictions on branches

2013-10-20 Thread Jed Brown
Jed Brown jedbr...@mcs.anl.gov writes:

 Bitbucket added support to restrict push access based on branch names
 (glob matching).  For example, that would allow us to have a smaller
 group of people with access to merge to 'maint' or 'master'.

 Is this a feature we should start using in petsc.git?

I set this restriction on maint*, master, and next.  The integrators
group currently contains Barry, Hong, Karl, Matt, Peter, Satish, and
myself.  Everyone else with write access is still able to push to any
other branches.  We can amend or cancel this at any time.

 One tangible difference from the current model is that it would let give
 more people push access to named branches which then allows an
 integrator to patch up a branch for an open pull request.  (When a PR
 comes from a fork instead of an in-repo branch, we can't push to their
 repository so we can't update the PR.  This sometimes leads to tedious
 fine-tuning of trivial details in the PR comments.)


 Admins can see the branch list here:

 https://bitbucket.org/petsc/petsc/admin/branches


pgpCozdC07F1S.pgp
Description: PGP signature


Re: [petsc-dev] Push restrictions on branches

2013-09-19 Thread Patrick Sanan
This sounds like a great idea from the perspective of someone like me, who 
would only be pushing to maint/master/next in error at this point.  It would 
also allow slightly easier access to features which are new/experimental enough 
to not be in next yet. 
On Sep 19, 2013, at 4:35 PM, Jed Brown wrote:

 Bitbucket added support to restrict push access based on branch names
 (glob matching).  For example, that would allow us to have a smaller
 group of people with access to merge to 'maint' or 'master'.
 
 Is this a feature we should start using in petsc.git?
 
 One tangible difference from the current model is that it would let give
 more people push access to named branches which then allows an
 integrator to patch up a branch for an open pull request.  (When a PR
 comes from a fork instead of an in-repo branch, we can't push to their
 repository so we can't update the PR.  This sometimes leads to tedious
 fine-tuning of trivial details in the PR comments.)
 
 
 Admins can see the branch list here:
 
 https://bitbucket.org/petsc/petsc/admin/branches