Re: pgsql: Fix calculation of which GENERATED columns need to be updated.
David Rowley writes: > On Fri, 6 Jan 2023 at 08:12, Tom Lane wrote: >> Fix calculation of which GENERATED columns need to be updated. >> src/backend/nodes/outfuncs.c | 1 - >> src/backend/nodes/readfuncs.c| 1 - > Is this missing a cat version bump? ... Ugh, you're right, I should have done one in HEAD. Probably too late to be useful now. regards, tom lane
pgsql: Check relkind before using TABLESAMPLE in postgres_fdw
Check relkind before using TABLESAMPLE in postgres_fdw Check the remote relkind before trying to use TABLESAMPLE to acquire sample from the remote relation. Even if the remote server version has TABLESAMPLE support, the foreign table may point to incompatible relkind (e.g. a view or a sequence). If the relkind does not support TABLESAMPLE, error out if TABLESAMPLE was requested specifically (as system/bernoulli), or fallback to random just like we do for old server versions. We currently end up disabling sampling for such relkind values anyway, due to reltuples being -1 or 1, but that seems rather accidental, and might get broken by improving reltuples estimates, etc. So better to make the check explicit. Reported-by: Tom Lane Discussion: https://postgr.es/m/951485.1672461744%40sss.pgh.pa.us Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/57d11ef028d126f95595c08c62ffb4c5147d0f86 Modified Files -- contrib/postgres_fdw/deparse.c | 7 +++-- contrib/postgres_fdw/postgres_fdw.c | 60 ++--- contrib/postgres_fdw/postgres_fdw.h | 2 +- 3 files changed, 47 insertions(+), 22 deletions(-)
pgsql: psql: Add support for \dpS and \zS.
psql: Add support for \dpS and \zS. This allows an optional "S" modifier to be added to \dp and \z, to have them include system objects in the list. Note that this also changes the behaviour of a bare \dp or \z without the "S" modifier to include temp objects in the list, and exclude information_schema objects, making them consistent with other psql meta-commands. Nathan Bossart, reviewed by Maxim Orlov. Discussion: https://postgr.es/m/20221206193606.GB3078082@nathanxps13 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d913928c9c5e905d0062d1e7237b7fb5fbde61ed Modified Files -- doc/src/sgml/ref/psql-ref.sgml | 12 src/bin/psql/command.c | 23 +++ src/bin/psql/describe.c| 14 ++ src/bin/psql/describe.h| 2 +- 4 files changed, 30 insertions(+), 21 deletions(-)
Re: pgsql: Fix calculation of which GENERATED columns need to be updated.
On Fri, 6 Jan 2023 at 08:12, Tom Lane wrote: > > Fix calculation of which GENERATED columns need to be updated. > Branch > -- > master > src/backend/nodes/outfuncs.c | 1 - > src/backend/nodes/readfuncs.c| 1 - Is this missing a cat version bump? David
