pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra
Fix unnecessary use of moving-aggregate mode with non-moving frame. When a plain aggregate is used as a window function, and the window frame start is specified as UNBOUNDED PRECEDING, the frame's head cannot move so we do not need to use moving-aggregate mode. The check for that was put into initialize_peragg(), failing to notice that ExecInitWindowAgg() calls that function before it's filled in winstate->frameOptions. Since makeNode() would have zeroed the field, this didn't provoke uninitialized-value complaints, nor would the erroneous decision have resulted in more than a little inefficiency. Still, it's wrong, so move the initialization of winstate->frameOptions earlier to make it work properly. While here, also fix a thinko in a comment. Both errors crept in in commit a9d9acbf2 which introduced the moving-aggregate mode. Spotted by Vallimaharajan G. Back-patch to all supported branches. Discussion: https://postgr.es/m/18e7f2a5167.fe36253866818.977923893562469...@zohocorp.com Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/25675c474292dca71470ef17ea8a53c150eb0e0a Modified Files -- src/backend/executor/nodeWindowAgg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)
pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra
Fix unnecessary use of moving-aggregate mode with non-moving frame. When a plain aggregate is used as a window function, and the window frame start is specified as UNBOUNDED PRECEDING, the frame's head cannot move so we do not need to use moving-aggregate mode. The check for that was put into initialize_peragg(), failing to notice that ExecInitWindowAgg() calls that function before it's filled in winstate->frameOptions. Since makeNode() would have zeroed the field, this didn't provoke uninitialized-value complaints, nor would the erroneous decision have resulted in more than a little inefficiency. Still, it's wrong, so move the initialization of winstate->frameOptions earlier to make it work properly. While here, also fix a thinko in a comment. Both errors crept in in commit a9d9acbf2 which introduced the moving-aggregate mode. Spotted by Vallimaharajan G. Back-patch to all supported branches. Discussion: https://postgr.es/m/18e7f2a5167.fe36253866818.977923893562469...@zohocorp.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a767cdc84c9a4cba1f92854de55fb8b5f2de4598 Modified Files -- src/backend/executor/nodeWindowAgg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)
pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra
Fix unnecessary use of moving-aggregate mode with non-moving frame. When a plain aggregate is used as a window function, and the window frame start is specified as UNBOUNDED PRECEDING, the frame's head cannot move so we do not need to use moving-aggregate mode. The check for that was put into initialize_peragg(), failing to notice that ExecInitWindowAgg() calls that function before it's filled in winstate->frameOptions. Since makeNode() would have zeroed the field, this didn't provoke uninitialized-value complaints, nor would the erroneous decision have resulted in more than a little inefficiency. Still, it's wrong, so move the initialization of winstate->frameOptions earlier to make it work properly. While here, also fix a thinko in a comment. Both errors crept in in commit a9d9acbf2 which introduced the moving-aggregate mode. Spotted by Vallimaharajan G. Back-patch to all supported branches. Discussion: https://postgr.es/m/18e7f2a5167.fe36253866818.977923893562469...@zohocorp.com Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0d30e48c2578a6857aa2869f1b2696b6eb5fef68 Modified Files -- src/backend/executor/nodeWindowAgg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)
pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra
Fix unnecessary use of moving-aggregate mode with non-moving frame. When a plain aggregate is used as a window function, and the window frame start is specified as UNBOUNDED PRECEDING, the frame's head cannot move so we do not need to use moving-aggregate mode. The check for that was put into initialize_peragg(), failing to notice that ExecInitWindowAgg() calls that function before it's filled in winstate->frameOptions. Since makeNode() would have zeroed the field, this didn't provoke uninitialized-value complaints, nor would the erroneous decision have resulted in more than a little inefficiency. Still, it's wrong, so move the initialization of winstate->frameOptions earlier to make it work properly. While here, also fix a thinko in a comment. Both errors crept in in commit a9d9acbf2 which introduced the moving-aggregate mode. Spotted by Vallimaharajan G. Back-patch to all supported branches. Discussion: https://postgr.es/m/18e7f2a5167.fe36253866818.977923893562469...@zohocorp.com Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/03561a6c7bbfe305b941d46f7bafb3cdd4793982 Modified Files -- src/backend/executor/nodeWindowAgg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)
pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra
Fix unnecessary use of moving-aggregate mode with non-moving frame. When a plain aggregate is used as a window function, and the window frame start is specified as UNBOUNDED PRECEDING, the frame's head cannot move so we do not need to use moving-aggregate mode. The check for that was put into initialize_peragg(), failing to notice that ExecInitWindowAgg() calls that function before it's filled in winstate->frameOptions. Since makeNode() would have zeroed the field, this didn't provoke uninitialized-value complaints, nor would the erroneous decision have resulted in more than a little inefficiency. Still, it's wrong, so move the initialization of winstate->frameOptions earlier to make it work properly. While here, also fix a thinko in a comment. Both errors crept in in commit a9d9acbf2 which introduced the moving-aggregate mode. Spotted by Vallimaharajan G. Back-patch to all supported branches. Discussion: https://postgr.es/m/18e7f2a5167.fe36253866818.977923893562469...@zohocorp.com Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a94f51a7bfc9e65ce3799d8cb12945bd596c5ba8 Modified Files -- src/backend/executor/nodeWindowAgg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)
pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra
Fix unnecessary use of moving-aggregate mode with non-moving frame. When a plain aggregate is used as a window function, and the window frame start is specified as UNBOUNDED PRECEDING, the frame's head cannot move so we do not need to use moving-aggregate mode. The check for that was put into initialize_peragg(), failing to notice that ExecInitWindowAgg() calls that function before it's filled in winstate->frameOptions. Since makeNode() would have zeroed the field, this didn't provoke uninitialized-value complaints, nor would the erroneous decision have resulted in more than a little inefficiency. Still, it's wrong, so move the initialization of winstate->frameOptions earlier to make it work properly. While here, also fix a thinko in a comment. Both errors crept in in commit a9d9acbf2 which introduced the moving-aggregate mode. Spotted by Vallimaharajan G. Back-patch to all supported branches. Discussion: https://postgr.es/m/18e7f2a5167.fe36253866818.977923893562469...@zohocorp.com Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/de3c5b18729a234df0b9203e195a2a5c168ef1cd Modified Files -- src/backend/executor/nodeWindowAgg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)
