Re: soliciting patches to review
On Tue, Apr 23, 2024 at 1:27 PM Robert Haas wrote: > Just a quick update. We have so far had 8 suggested patches from 6 > people, if I haven't missed anything. I'm fairly certain that not all > of those patches are going to be good candidates for this session, so > it would be great if a few more people wanted to volunteer their > patches. With approximately 1 week to go, I now have a list of 24 patches that I think are good candidates for this session and another 11 that were suggested but which I think are not good candidates for various reasons, including (1) being trivial, (2) being so complicated that it's not reasonable to review them in the time we'll have, and (3) patching something other than the C code, which I consider too specialized for this session. I think that's a long enough list that we probably won't get to all of the patches in the session, so I don't necessarily *need* more things to put on the list at this point. However, I am still accepting further nominations until approximately this time on Friday. Hence, if you have written a patch that you think would be a good candidate for some folks to review in their effort to become better reviewers, let me (and Andres) know. Thanks, -- Robert Haas EDB: http://www.enterprisedb.com
Re: soliciting patches to review
On Tue, Apr 23, 2024 at 1:39 PM Melanie Plageman wrote: > Since you are going to share the patches anyway at the workshop, do > you mind giving an example of a patch that is a good fit for the > workshop? Alternatively, you could provide a hypothetical example. I, > of course, have patches that I'd like reviewed. But, I'm unconvinced > any of them would be particularly interesting in a workshop. Andres and I haven't discussed our selection criteria yet, but my feeling is that we're going to want patches that are somewhat medium-sized. If your patch makes PostgreSQL capable of faster-than-light travel, it's probably too big to be reviewed meaningfully in the time we will have. If your patch changes corrects a bunch of typos, it probably lacks enough substance to be worth discussing. I hesitate to propose more specific parameters. On the one hand, a patch that changes something user-visible that someone could reasonably like or dislike is probably easier to review, in some sense, than a patch that refactors code or tries to improve performance. However, talking about how to review patches where it's less obvious what you should be trying to evaluate might be an important part of the workshop, so my feeling is that I would prefer it if more people would volunteer and then let Andres and I sort through what we think makes sense to include. I would also be happy to have people "blanket submit" without naming patches i.e. if anyone wants to email and say "hey, feel free to include any of my stuff if you want" that is great. Our concern was that we didn't want to look like we were picking on anyone who wasn't up for it. I'm happy to keep getting emails from people with specific patches they want reviewed -- if we can hit a patch that someone wants reviewed that is better for everyone than if we just pick randomly -- but my number one concern is not offending anyone. -- Robert Haas EDB: http://www.enterprisedb.com
Re: soliciting patches to review
On Tue, Apr 23, 2024 at 1:27 PM Robert Haas wrote: > > Hi, > > Just a quick update. We have so far had 8 suggested patches from 6 > people, if I haven't missed anything. I'm fairly certain that not all > of those patches are going to be good candidates for this session, so > it would be great if a few more people wanted to volunteer their > patches. Since you are going to share the patches anyway at the workshop, do you mind giving an example of a patch that is a good fit for the workshop? Alternatively, you could provide a hypothetical example. I, of course, have patches that I'd like reviewed. But, I'm unconvinced any of them would be particularly interesting in a workshop. - Melanie
Re: soliciting patches to review
Hi, Just a quick update. We have so far had 8 suggested patches from 6 people, if I haven't missed anything. I'm fairly certain that not all of those patches are going to be good candidates for this session, so it would be great if a few more people wanted to volunteer their patches. Thanks, ...Robert
soliciting patches to review
Hi, At 2024.pgconf.dev, Andres and I will be hosting a patch review workshop.[1] Part of the workshop will be a presentation, and part of it will be a practicum. That is, we're going to actually ask attendees to review some patches during the workshop. We'll also comment on those reviews, and the patches themselves, with our own thoughts. While we could just pick some things from the CommitFest, I believe we both felt a little uncomfortable with the idea of potentially turning a spotlight on someone's patch where they might not have been expecting it. So, instead, I'd like to invite you to email me, and/or Andres, if you have a patch that isn't committed yet and which you think would be a good candidate for review during this workshop. If your patch is selected to be reviewed during the workshop, then you will very likely get some reviews for your patch posted on pgsql-hackers. But, there are no guarantees about how positive or negative those reviews will be, so you do need to be prepared to take the bad with the good. Note that this is really an exercise in helping more people in the community to get better at reviewing patches. So, if Andres and I think that what your patch really needs is an opinion from Tom Lane specifically, or even an opinion from Andres Freund or Robert Haas specifically, we probably won't choose to include it in the workshop. But there are lots of patches that just need attention from someone, at least for starters, and perhaps this workshop can help some of those patches to make progress, in addition to (hopefully) being educational for the attendees. Key points: 1. If you have a patch you think would be a good candidate for this event, please email me and/or Andres. 2. Please only volunteer a patch that you wrote, not one that somebody else wrote. 3. Please don't suggest a patch that's already committed. Thanks, -- Robert Haas EDB: http://www.enterprisedb.com [1] https://www.pgevents.ca/events/pgconfdev2024/schedule/session/40-patch-review-workshop-registration-required/
