Bug#765421: jmapviewer: Download bing logo via attribution XML at runtime?

2014-10-21 Thread Felix Natter 
Sebastiaan Couwenberg sebas...@xs4all.nl writes:

hi Bas,
hi debian-gis members,

 On 10/20/2014 11:17 PM, Felix Natter wrote:
 Felix Natter fnat...@gmx.net writes:
 = I think we need to investigate that for jessie+1, but now I think we
 should parse the attribution data and use the included link to
 download the logo at runtime (many thanks to the patch [1] from Marcus
 Lundblad m...@update.uu.se and Martin Krüger martin.krue...@gmx.com)?
 We should really agree on something now ;-)
 
 -- Can we all agree on this solution for jessie?
 (which is probably legal if JMapViewer itself is legal)
 
 I'd suggest to apply this patch now to make sure it's fixed for jessie!

 Yes, until we hear otherwise it seems to me the best solution to the
 Bing logo license problem.

 I've cleaned up the patch a little and added DEP3 headers for inclusion
 in the jmapviewer package. When the patch is forwarded upstream we have
 a nice opportunity to get the upstream point of view on this issue.

Thanks for your help! I pushed the change to jmapviewer git and tested
with josm (and freeplane).

Don Armstrong wrote:
 At the very least, I'd stick a note in NEWS.Debian.gz.

= Do we really want to do this? I think that problematic
bing support is not quite new for this package?

@Andreas: Could you sponsor this tomorrow?

Cheers and Best Regards,
-- 
Felix Natter

___
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel

Bug#765421: jmapviewer: Download bing logo via attribution XML at runtime?

2014-10-21 Thread Sebastiaan Couwenberg 
Hi Felix,

 Sebastiaan Couwenberg sebas...@xs4all.nl writes:
 On 10/20/2014 11:17 PM, Felix Natter wrote:
 Felix Natter fnat...@gmx.net writes:
 = I think we need to investigate that for jessie+1, but now I think
 we
 should parse the attribution data and use the included link to
 download the logo at runtime (many thanks to the patch [1] from Marcus
 Lundblad m...@update.uu.se and Martin Krüger
 martin.krue...@gmx.com)?
 We should really agree on something now ;-)

 -- Can we all agree on this solution for jessie?
 (which is probably legal if JMapViewer itself is legal)

 I'd suggest to apply this patch now to make sure it's fixed for jessie!

 Yes, until we hear otherwise it seems to me the best solution to the
 Bing logo license problem.

 I've cleaned up the patch a little and added DEP3 headers for inclusion
 in the jmapviewer package. When the patch is forwarded upstream we have
 a nice opportunity to get the upstream point of view on this issue.

 Thanks for your help! I pushed the change to jmapviewer git and tested
 with josm (and freeplane).

Do you intent to update the package with the 1.04 upstream release?

JMapViewer 1.04 contains the patch in slightly modified form, more in line
with the upstream coding convention.

 Don Armstrong wrote:
 At the very least, I'd stick a note in NEWS.Debian.gz.

 = Do we really want to do this? I think that problematic
 bing support is not quite new for this package?

Documenting the problems with the Bing logo is a good idea in general.

I'm inclined to document it in README.Debian instead of in a NEWS item,
because the logo was never part of the package. But NEWS items are more
visible thanks to apt-listchanges.

 @Andreas: Could you sponsor this tomorrow?

Would it make sense to sponsor the new upstream version instead of the
patches 1.03?

Kind Regards,

Bas

___
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel

Bug#765421: jmapviewer: Download bing logo via attribution XML at runtime?

2014-10-21 Thread Felix Natter 
Sebastiaan Couwenberg sebas...@xs4all.nl writes:

 Hi Felix,

hello Bas,

 Sebastiaan Couwenberg sebas...@xs4all.nl writes:
 On 10/20/2014 11:17 PM, Felix Natter wrote:
 Felix Natter fnat...@gmx.net writes:
 = I think we need to investigate that for jessie+1, but now I think
 we
 should parse the attribution data and use the included link to
 download the logo at runtime (many thanks to the patch [1] from Marcus
 Lundblad m...@update.uu.se and Martin Krüger
 martin.krue...@gmx.com)?
 We should really agree on something now ;-)

 -- Can we all agree on this solution for jessie?
 (which is probably legal if JMapViewer itself is legal)

 I'd suggest to apply this patch now to make sure it's fixed for jessie!

 Yes, until we hear otherwise it seems to me the best solution to the
 Bing logo license problem.

 I've cleaned up the patch a little and added DEP3 headers for inclusion
 in the jmapviewer package. When the patch is forwarded upstream we have
 a nice opportunity to get the upstream point of view on this issue.

 Thanks for your help! I pushed the change to jmapviewer git and tested
 with josm (and freeplane).

 Do you intent to update the package with the 1.04 upstream release?

 JMapViewer 1.04 contains the patch in slightly modified form, more in line
 with the upstream coding convention.

I would rather not like to do this, because i.e. from 1.02 to 1.03 they
introduced incompatibilies and I had to fix freeplane, and I might
not have enough time to fix freeplane (and josm) before the freeze :-/

 Don Armstrong wrote:
 At the very least, I'd stick a note in NEWS.Debian.gz.

 = Do we really want to do this? I think that problematic
 bing support is not quite new for this package?

 Documenting the problems with the Bing logo is a good idea in general.

 I'm inclined to document it in README.Debian instead of in a NEWS item,
 because the logo was never part of the package. But NEWS items are more
 visible thanks to apt-listchanges.

Ok, I added your patch description to README.Debian.

 @Andreas: Could you sponsor this tomorrow?

BTW: the git repo is here:
http://anonscm.debian.org/cgit/pkg-grass/jmapviewer.git

 Would it make sense to sponsor the new upstream version instead of the
 patches 1.03?

I appreciate that you reported the patch upstream so quickly, but I
would prefer to stick with 1.03 for jessie.

Thanks and Best Regards,
-- 
Felix Natter

___
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel

Bug#765421: jmapviewer: Download bing logo via attribution XML at runtime?

2014-10-21 Thread Vincent Privat 
I made the 1.04 release especially for this bug :/
There are very few other changes: one bug fix, optimized PNGs and code now
requiring Java 7, but that should not be a problem:
https://trac.openstreetmap.org/log/subversion/applications/viewer/jmapviewer?action=stop_on_copymode=stop_on_copyrev=30760stop_rev=30424

I am also releasing a new tested version of JOSM right now (7643). It's a
bugfix release that addresses major problems present in version 7588, this
version is meant for Jessie if possible...

Didn't know Freeplane was using JMapViewer however, it's great to see we're
not alone to use it after all :)

2014-10-21 20:52 GMT+02:00 Felix Natter fnat...@gmx.net:

 Sebastiaan Couwenberg sebas...@xs4all.nl writes:

  Hi Felix,

 hello Bas,

  Sebastiaan Couwenberg sebas...@xs4all.nl writes:
  On 10/20/2014 11:17 PM, Felix Natter wrote:
  Felix Natter fnat...@gmx.net writes:
  = I think we need to investigate that for jessie+1, but now I think
  we
  should parse the attribution data and use the included link to
  download the logo at runtime (many thanks to the patch [1] from
 Marcus
  Lundblad m...@update.uu.se and Martin Krüger
  martin.krue...@gmx.com)?
  We should really agree on something now ;-)
 
  -- Can we all agree on this solution for jessie?
  (which is probably legal if JMapViewer itself is legal)
 
  I'd suggest to apply this patch now to make sure it's fixed for
 jessie!
 
  Yes, until we hear otherwise it seems to me the best solution to the
  Bing logo license problem.
 
  I've cleaned up the patch a little and added DEP3 headers for inclusion
  in the jmapviewer package. When the patch is forwarded upstream we have
  a nice opportunity to get the upstream point of view on this issue.
 
  Thanks for your help! I pushed the change to jmapviewer git and tested
  with josm (and freeplane).
 
  Do you intent to update the package with the 1.04 upstream release?
 
  JMapViewer 1.04 contains the patch in slightly modified form, more in
 line
  with the upstream coding convention.

 I would rather not like to do this, because i.e. from 1.02 to 1.03 they
 introduced incompatibilies and I had to fix freeplane, and I might
 not have enough time to fix freeplane (and josm) before the freeze :-/

  Don Armstrong wrote:
  At the very least, I'd stick a note in NEWS.Debian.gz.
 
  = Do we really want to do this? I think that problematic
  bing support is not quite new for this package?
 
  Documenting the problems with the Bing logo is a good idea in general.
 
  I'm inclined to document it in README.Debian instead of in a NEWS item,
  because the logo was never part of the package. But NEWS items are more
  visible thanks to apt-listchanges.

 Ok, I added your patch description to README.Debian.

  @Andreas: Could you sponsor this tomorrow?

 BTW: the git repo is here:
 http://anonscm.debian.org/cgit/pkg-grass/jmapviewer.git

  Would it make sense to sponsor the new upstream version instead of the
  patches 1.03?

 I appreciate that you reported the patch upstream so quickly, but I
 would prefer to stick with 1.03 for jessie.

 Thanks and Best Regards,
 --
 Felix Natter

 --
 To unsubscribe, send mail to 765421-unsubscr...@bugs.debian.org.

___
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel

Bug#765421: jmapviewer: Download bing logo via attribution XML at runtime?

2014-10-21 Thread Sebastiaan Couwenberg 
On 10/21/2014 08:52 PM, Felix Natter wrote:
 Sebastiaan Couwenberg sebas...@xs4all.nl writes:
 JMapViewer 1.04 contains the patch in slightly modified form, more in line
 with the upstream coding convention.
 
 I would rather not like to do this, because i.e. from 1.02 to 1.03 they
 introduced incompatibilies and I had to fix freeplane, and I might
 not have enough time to fix freeplane (and josm) before the freeze :-/

That's entirely reasonable with only two weeks left until the freeze.

I mostly asked in case you missed the message by Vincent Privat in his
role as JOSM  JMapViewer upstream, who asked if it was possible to get
the new upstream version into jessie. See:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=765421#95

I've reviewed the changes between 1.03 and 1.04, and they are very
minimal (if you exclude whitespace changes), but two weeks may not be
enough to test the rdeps and have the updated package(s) migrate to testing.

 Would it make sense to sponsor the new upstream version instead of the
 patches 1.03?
 
 I appreciate that you reported the patch upstream so quickly, but I
 would prefer to stick with 1.03 for jessie.

Just for the record, I didn't forward the patch, Vincent Privat was
apparently following the bug report and/or mailinglist(s).

It's your call to update to 1.04 or not. I would update the packaging
and upload it to experimental at least if you have the time.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/E88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1

___
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel

Bug#765421: jmapviewer: Download bing logo via attribution XML at runtime?

2014-10-20 Thread Felix Natter 
Dear debian-legal and debian-gis members,

I contacted map...@microsoft.com and they replied with contact
details of Mr. Jalon Shoemaker. I talked to him on the phone,
but he is a sales person and is only in charge of selling me licenses.
I've got an email address of a more technical person at bing maps,
and I will send an email to him in a few minutes.

IMHO the question is: Under which license are we allowed to use
  
http://dev.virtualearth.net/REST/v1/Imagery/Metadata/Aerial?include=ImageryProvidersoutput=xmlkey=...
(the REST Service for Bing maps) at all?
The license (http://www.microsoft.com/maps/product/terms.html) is pretty
restrictive... (or am I missing something?)

2.Definitions.
“Education or Non-Profit Organization Use” means using the Services
with a Company Application that displays results for education or
non-profit use, where non-profit organization means a tax exempt
organization and education means use by public or private K-12 schools,
universities, community colleges or other collegiate level institutions
such as vocational schools, trade schools or career colleges, including
their faculty, staff, and students, provided that your use is consistent
with the terms of Section 5.  Further your Company Application must be
one of the following: publically available without restriction (for
example, login or password must not be required), available only to
current students of your education organization via your private network
in order to provide education related services, available internally for
free instructional use, or available internally for non-commercial
research use. Commercially funded research projects and commercial
company use for educational purposes are excluded from Education or
Non-Profit Organization Use.

5.  Education or Non-Profit Organization Use. Subject to your compliance
with Sections 1, 2, 5 and 8 of this TOU, you may develop or host a
Company Application that uses the Services to display results for
Education or Non-profit Organization Use (as defined in Section 2).

= We cannot guarantee that no one uses JMapViewer (GPL)
commercially...

= I think we need to investigate that for jessie+1, but now I think we
should parse the attribution data and use the included link to
download the logo at runtime (many thanks to the patch [1] from Marcus
Lundblad m...@update.uu.se and Martin Krüger martin.krue...@gmx.com)?
We should really agree on something now ;-)

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=765421#60

Thanks and Best Regards,
-- 
Felix Natter

___
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel

Bug#765421: jmapviewer: Download bing logo via attribution XML at runtime?

2014-10-20 Thread Felix Natter 
Felix Natter fnat...@gmx.net writes:

 Dear debian-legal and debian-gis members,

[...]

 = I think we need to investigate that for jessie+1, but now I think we
 should parse the attribution data and use the included link to
 download the logo at runtime (many thanks to the patch [1] from Marcus
 Lundblad m...@update.uu.se and Martin Krüger martin.krue...@gmx.com)?
 We should really agree on something now ;-)

-- Can we all agree on this solution for jessie?
(which is probably legal if JMapViewer itself is legal)

I'd suggest to apply this patch now to make sure it's fixed for jessie!

Best Regards,
-- 
Felix Natter

___
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel

Bug#765421: jmapviewer: Download bing logo via attribution XML at runtime?

2014-10-20 Thread Sebastiaan Couwenberg 
On 10/20/2014 11:17 PM, Felix Natter wrote:
 Felix Natter fnat...@gmx.net writes:
 = I think we need to investigate that for jessie+1, but now I think we
 should parse the attribution data and use the included link to
 download the logo at runtime (many thanks to the patch [1] from Marcus
 Lundblad m...@update.uu.se and Martin Krüger martin.krue...@gmx.com)?
 We should really agree on something now ;-)
 
 -- Can we all agree on this solution for jessie?
 (which is probably legal if JMapViewer itself is legal)
 
 I'd suggest to apply this patch now to make sure it's fixed for jessie!

Yes, until we hear otherwise it seems to me the best solution to the
Bing logo license problem.

I've cleaned up the patch a little and added DEP3 headers for inclusion
in the jmapviewer package. When the patch is forwarded upstream we have
a nice opportunity to get the upstream point of view on this issue.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/E88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1

Description: Download the Bing logo when it's not installed.
 The Bing logo is required for attribution when using the imagery, but the
 license terms covering the image are unclear. JMapViewer is licesed under
 the GPL, but the Bing logo is mostly likely not.
 .
 To not require the inclusion of the bing_maps.png file in the jmapviewer
 package, the image is downloaded using the URL provided in the BrandLogoUri
 attribute of the attribution response.
 .
Author: Marcus Lundblad m...@update.uu.se  Martin Krüger martin.krue...@gmx.com
Bug-Debian: https://bugs.debian.org/765421

--- a/src/org/openstreetmap/gui/jmapviewer/tilesources/BingAerialTileSource.java
+++ b/src/org/openstreetmap/gui/jmapviewer/tilesources/BingAerialTileSource.java
@@ -3,6 +3,7 @@ package org.openstreetmap.gui.jmapviewer
 
 import java.awt.Image;
 import java.io.IOException;
+import java.io.InputStream;
 import java.net.MalformedURLException;
 import java.net.URL;
 import java.util.ArrayList;
@@ -45,6 +46,7 @@ public class BingAerialTileSource extend
 private static final Pattern subdomainPattern = Pattern.compile(\\{subdomain\\});
 private static final Pattern quadkeyPattern = Pattern.compile(\\{quadkey\\});
 private static final Pattern culturePattern = Pattern.compile(\\{culture\\});
+private String BrandLogoUri = null;
 
 public BingAerialTileSource() {
 super(Bing Aerial Maps, http://example.com/;);
@@ -97,6 +99,9 @@ public class BingAerialTileSource extend
 subdomains[i] = subdomainTxt.item(i).getNodeValue();
 }
 
+XPathExpression BrandLogoUriXpath = xpath.compile(/Response/BrandLogoUri/text());
+this.BrandLogoUri = BrandLogoUriXpath.evaluate(document);
+
 XPathExpression attributionXpath = xpath.compile(Attribution/text());
 XPathExpression coverageAreaXpath = xpath.compile(CoverageArea);
 XPathExpression zoomMinXpath = xpath.compile(ZoomMin/text());
@@ -173,8 +178,17 @@ public class BingAerialTileSource extend
 
 @Override
 public Image getAttributionImage() {
+	for( int i=0 ; i5  getAttribution()==null ; i++ ) ;
 try {
-return ImageIO.read(JMapViewer.class.getResourceAsStream(images/bing_maps.png));
+final InputStream imageResource = JMapViewer.class.getResourceAsStream(images/bing_maps.png);
+if (imageResource != null) {
+return ImageIO.read(imageResource);
+} else {
+if (this.BrandLogoUri != null)
+return ImageIO.read(new URL(this.BrandLogoUri));
+else
+return null;
+}
 } catch (IOException e) {
 return null;
 }
___
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel

Bug#765421: jmapviewer: Download bing logo via attribution XML at runtime?

2014-10-20 Thread Vincent Privat 
On Tue, 21 Oct 2014 01:07:15 +0200 Sebastiaan Couwenberg sebas...@xs4all.nl
wrote:

 I've cleaned up the patch a little and added DEP3 headers for inclusion
 in the jmapviewer package. When the patch is forwarded upstream we have
 a nice opportunity to get the upstream point of view on this issue.


Hi guys,
Upstream point of view is that we'll commit this patch and release a new
version of JMapViewer.

I'm think also to release a new stable version of JOSM ASAP. If we release
it before Friday, is there a chance this version makes it to Jessie?
It would fix some issues listed on your bugtracker. But do not forget to
update all packages at the same time (josm, josm-plugins, jmapviewer and
openstreetmap-map-icons-classic).

Regards,
Vincent, for the JOSM team
___
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel

Bug#765421: jmapviewer: Download bing logo via attribution XML at runtime?

2014-10-20 Thread Vincent Privat 
Hi,
JMapViewer 1.04 has been released.
Vincent

2014-10-21 1:59 GMT+02:00 Vincent Privat vinc...@josm.openstreetmap.de:

 On Tue, 21 Oct 2014 01:07:15 +0200 Sebastiaan Couwenberg 
 sebas...@xs4all.nl wrote:
 
  I've cleaned up the patch a little and added DEP3 headers for inclusion
  in the jmapviewer package. When the patch is forwarded upstream we have
  a nice opportunity to get the upstream point of view on this issue.
 

 Hi guys,
 Upstream point of view is that we'll commit this patch and release a new
 version of JMapViewer.

 I'm think also to release a new stable version of JOSM ASAP. If we release
 it before Friday, is there a chance this version makes it to Jessie?
 It would fix some issues listed on your bugtracker. But do not forget to
 update all packages at the same time (josm, josm-plugins, jmapviewer and
 openstreetmap-map-icons-classic).

 Regards,
 Vincent, for the JOSM team

___
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel

Bug#765421: jmapviewer: Download bing logo via attribution XML at runtime?

2014-10-20 Thread Don Armstrong 
On Mon, 20 Oct 2014, Felix Natter wrote:
 IMHO the question is: Under which license are we allowed to use
   
 http://dev.virtualearth.net/REST/v1/Imagery/Metadata/Aerial?include=ImageryProvidersoutput=xmlkey=...
 (the REST Service for Bing maps) at all?

The fact that this is a restriction on use is a bit problematic, just
from an end-user point of view. [I don't believe this affects its DFSG
status, since it works with free data sources just fine.]

It would probably be ideal if the user was warned about potentially
restrictive data sources when they enabled them the first time too; this
would give them a chance to do due diligence. (Or even when the program
first started if the program already had some equivalent feature.) [And
if it already does so, ignore my critique; I'm not familiar with this
software beyond following your efforts to clean up the DFSG status with
regards to the Bing logo.] At the very least, I'd stick a note in
NEWS.Debian.gz.

Thanks again for working on making this software DFSG free.

-- 
Don Armstrong  http://www.donarmstrong.com

Whatever you do will be insignificant, but it is very important that
you do it.
 -- Mohandas Karamchand Gandhi

___
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel