Re: Bug#586781: /usr/bin/jabref outputs warning if openjdk6 is missing
On Tue, 22 Jun 2010 16:29:42 +0200, Martin Lutz wrote: the startup script /usr/bin/jabref contains the line find_java_runtime openjdk6 || find_java_runtime sun6 if the first find_java_runtime fails, a warning is given, even if the second part is successful (sun6 is installed). The warning is confusing: [warning] /usr/bin/jabref: No java runtime was found I agree that this output is confusing. Since it comes from /usr/lib/java-wrappers/java-wrappers.sh I guess it should be improved there. Vincent, what do you think about changing the line to something like java_warning No java runtime for argument '$1' was found ? Cheers, gregor -- .''`. http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4 : :' : Debian GNU/Linux user, admin, developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of Free Software Foundation Europe `-NP: Oasis: Live Forever (Live)/Live Forever signature.asc Description: Digital signature __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
Re: Bug#586781: /usr/bin/jabref outputs warning if openjdk6 is missing
On Tue, Jun 22, 2010 at 8:54 PM, gregor herrmann gre...@debian.org wrote: On Tue, 22 Jun 2010 16:29:42 +0200, Martin Lutz wrote: the startup script /usr/bin/jabref contains the line find_java_runtime openjdk6 || find_java_runtime sun6 if the first find_java_runtime fails, a warning is given, even if the second part is successful (sun6 is installed). The warning is confusing: [warning] /usr/bin/jabref: No java runtime was found I agree that this output is confusing. Since it comes from /usr/lib/java-wrappers/java-wrappers.sh I guess it should be improved there. Vincent, what do you think about changing the line to something like java_warning No java runtime for argument '$1' was found ? I think the usage of find_java_runtime is not preferred way. As per the comment in /usr/lib/java-wrappers/java-wrappers.sh, # More than one argument can be specified; they will be taken into account # in that order; the first one found will be selected. So ideally it should be 'find_java_runtime openjdk6 sun6'. This way the first runtime found will be used and there won't be any warning. Onkar __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
Re: Bug#586781: /usr/bin/jabref outputs warning if openjdk6 is missing
On Tue, 22 Jun 2010 21:58:58 +0530, Onkar Shinde wrote: Since it comes from /usr/lib/java-wrappers/java-wrappers.sh I guess it should be improved there. Vincent, what do you think about changing the line to something like java_warning No java runtime for argument '$1' was found ? I think the usage of find_java_runtime is not preferred way. As per the comment in /usr/lib/java-wrappers/java-wrappers.sh, # More than one argument can be specified; they will be taken into account # in that order; the first one found will be selected. Oh! So ideally it should be 'find_java_runtime openjdk6 sun6'. This way the first runtime found will be used and there won't be any warning. Thanks alot, it seems I've missed this approach so far. I'll fix the jabref wrapper script soon. Cheers, gregor -- .''`. http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4 : :' : Debian GNU/Linux user, admin, developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of Free Software Foundation Europe `-NP: Brownie McGhee: Blues Had A Baby, The signature.asc Description: Digital signature __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.