Re: Comments regarding relaxngcc_1.12-1_amd64.changes
On 19.02.2014 00:57, Timo Aaltonen wrote: On 18.02.2014 23:35, Florian Weimer wrote: * Timo Aaltonen: We have a bootstrapping issue with this.. upstream CVS repo ships with 'lib/bootstrap-relaxngcc.jar' which is used to generate the files for the parser. And since the source tarball can't include that relaxngcc has no way to enter Debian? Fedora doesn't seem to care, they used to have a version where it used the embedded jar file, but the one that entered the archive used the same build system as our original upload.. sending to debian-java too in case someone has ideas.. Just use a cyclic build dependency. They are annoying, but less problematic for Arch: all packages. How would that work in practice? Ship the generated files in the tarball and document the build in README.source? Or try to build a stripped version that's capable of generating the parser as a second stage? Benjamin explained this to me.. but instead of fiddling this manually, we went with the original tarball but that the pre-generated files are rebuilt before the final jar is built. That should be good enough for the archive, no? -- t __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
Re: Comments regarding relaxngcc_1.12-1_amd64.changes
On 28.01.2014 15:24, Gergely Nagy wrote: On Wed, Jan 22, 2014 at 3:17 PM, Timo Aaltonen tjaal...@ubuntu.com wrote: On 22.01.2014 15:56, Timo Aaltonen wrote: On 22.01.2014 15:21, Timo Aaltonen wrote: On 21.01.2014 14:44, Gergely Nagy wrote: - There are a couple of files in the source that have comments like: /* this file is generated by RelaxNGCC */ Are these files rebuildable? (Sadly, my Java build system knowledge is not enough to determine this on my own) Not sure, no idea where they were generated from.. I'll see if they are needed at all. I could remove all of them without any issues, so best to recreate the tarball and push to NEW again, with all the fixes. scratch that, removing those trims the resulting .jar too and breaks at least JAXB build.. Well, we need all files to be rebuildable, all generated files need their source, and we need at least documentation on how to rebuild them, even if they aren't rebuilt on every build. I'm afraid I'll have to reject the package in the current state, until this issue is solved. (The other things would be fine in a -2 version, but not this one). We have a bootstrapping issue with this.. upstream CVS repo ships with 'lib/bootstrap-relaxngcc.jar' which is used to generate the files for the parser. And since the source tarball can't include that relaxngcc has no way to enter Debian? Fedora doesn't seem to care, they used to have a version where it used the embedded jar file, but the one that entered the archive used the same build system as our original upload.. -- t __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
Re: Comments regarding relaxngcc_1.12-1_amd64.changes
On 18.02.2014 23:16, Timo Aaltonen wrote: On 28.01.2014 15:24, Gergely Nagy wrote: On Wed, Jan 22, 2014 at 3:17 PM, Timo Aaltonen tjaal...@ubuntu.com wrote: On 22.01.2014 15:56, Timo Aaltonen wrote: On 22.01.2014 15:21, Timo Aaltonen wrote: On 21.01.2014 14:44, Gergely Nagy wrote: - There are a couple of files in the source that have comments like: /* this file is generated by RelaxNGCC */ Are these files rebuildable? (Sadly, my Java build system knowledge is not enough to determine this on my own) Not sure, no idea where they were generated from.. I'll see if they are needed at all. I could remove all of them without any issues, so best to recreate the tarball and push to NEW again, with all the fixes. scratch that, removing those trims the resulting .jar too and breaks at least JAXB build.. Well, we need all files to be rebuildable, all generated files need their source, and we need at least documentation on how to rebuild them, even if they aren't rebuilt on every build. I'm afraid I'll have to reject the package in the current state, until this issue is solved. (The other things would be fine in a -2 version, but not this one). We have a bootstrapping issue with this.. upstream CVS repo ships with 'lib/bootstrap-relaxngcc.jar' which is used to generate the files for the parser. And since the source tarball can't include that relaxngcc has no way to enter Debian? Fedora doesn't seem to care, they used to have a version where it used the embedded jar file, but the one that entered the archive used the same build system as our original upload.. sending to debian-java too in case someone has ideas.. this is a blocker for xsom - fastinfoset - jaxb - RESTEasy - Dogtag 10 - FreeIPA :/ -- t __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
Re: Comments regarding relaxngcc_1.12-1_amd64.changes
* Timo Aaltonen: We have a bootstrapping issue with this.. upstream CVS repo ships with 'lib/bootstrap-relaxngcc.jar' which is used to generate the files for the parser. And since the source tarball can't include that relaxngcc has no way to enter Debian? Fedora doesn't seem to care, they used to have a version where it used the embedded jar file, but the one that entered the archive used the same build system as our original upload.. sending to debian-java too in case someone has ideas.. Just use a cyclic build dependency. They are annoying, but less problematic for Arch: all packages. __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
Re: Comments regarding relaxngcc_1.12-1_amd64.changes
On 18.02.2014 23:35, Florian Weimer wrote: * Timo Aaltonen: We have a bootstrapping issue with this.. upstream CVS repo ships with 'lib/bootstrap-relaxngcc.jar' which is used to generate the files for the parser. And since the source tarball can't include that relaxngcc has no way to enter Debian? Fedora doesn't seem to care, they used to have a version where it used the embedded jar file, but the one that entered the archive used the same build system as our original upload.. sending to debian-java too in case someone has ideas.. Just use a cyclic build dependency. They are annoying, but less problematic for Arch: all packages. How would that work in practice? Ship the generated files in the tarball and document the build in README.source? Or try to build a stripped version that's capable of generating the parser as a second stage? -- t __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
Re: Comments regarding relaxngcc_1.12-1_amd64.changes
On Wed, Jan 22, 2014 at 3:17 PM, Timo Aaltonen tjaal...@ubuntu.com wrote: On 22.01.2014 15:56, Timo Aaltonen wrote: On 22.01.2014 15:21, Timo Aaltonen wrote: On 21.01.2014 14:44, Gergely Nagy wrote: - There are a couple of files in the source that have comments like: /* this file is generated by RelaxNGCC */ Are these files rebuildable? (Sadly, my Java build system knowledge is not enough to determine this on my own) Not sure, no idea where they were generated from.. I'll see if they are needed at all. I could remove all of them without any issues, so best to recreate the tarball and push to NEW again, with all the fixes. scratch that, removing those trims the resulting .jar too and breaks at least JAXB build.. Well, we need all files to be rebuildable, all generated files need their source, and we need at least documentation on how to rebuild them, even if they aren't rebuilt on every build. I'm afraid I'll have to reject the package in the current state, until this issue is solved. (The other things would be fine in a -2 version, but not this one). __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
Re: Comments regarding relaxngcc_1.12-1_amd64.changes
On 21.01.2014 14:44, Gergely Nagy wrote: Dear maintainer, While processing your upload of relaxngcc 1.12-1, I noticed the following things about the packaging: - The source tarball has been repacked, but this is not documented anywhere, and the only sign of it is the get-orig-targz target in debian/rules. Please document this in the debian/copyright file. Explaining why the repacking was done and what is removed would also be nice to see documented in debian/README.source, not just as comments in debian/rules. Pretty much all the java packages I've dealt with repack the source, filtering .class and .jar files and whatnot. Now I see though that it doesn't have README.source at all, I'll add that to git. - src/relaxngcc/javabody/JavaBodyParser.jj does not appear to be under the Apache-1.1 license, but what exactly it is under, is unclear to me. This should be clarified. Looks like it's from javacc: examples/JavaGrammars/Java1.1.jj and modified for this project. The original file is under BSD-3-clause. - There are a couple of files in the source that have comments like: /* this file is generated by RelaxNGCC */ Are these files rebuildable? (Sadly, my Java build system knowledge is not enough to determine this on my own) Not sure, no idea where they were generated from.. I'll see if they are needed at all. None of these warrant a reject, but I would like to see them clarified, if I'm to let the package through NEW. If you want to correct them, and reupload, instead of fixing them in a future version, that is also an option. I will reject the current version from NEW then, and you can reupload after. If it's ok I'll push updates to git and get -2 uploaded soon enough that should cover all the above. Getting -1 through NEW would still be nice :) -- t __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
Re: Comments regarding relaxngcc_1.12-1_amd64.changes
On 22.01.2014 15:21, Timo Aaltonen wrote: On 21.01.2014 14:44, Gergely Nagy wrote: - There are a couple of files in the source that have comments like: /* this file is generated by RelaxNGCC */ Are these files rebuildable? (Sadly, my Java build system knowledge is not enough to determine this on my own) Not sure, no idea where they were generated from.. I'll see if they are needed at all. I could remove all of them without any issues, so best to recreate the tarball and push to NEW again, with all the fixes. -- t __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
Re: Comments regarding relaxngcc_1.12-1_amd64.changes
On 22.01.2014 15:56, Timo Aaltonen wrote: On 22.01.2014 15:21, Timo Aaltonen wrote: On 21.01.2014 14:44, Gergely Nagy wrote: - There are a couple of files in the source that have comments like: /* this file is generated by RelaxNGCC */ Are these files rebuildable? (Sadly, my Java build system knowledge is not enough to determine this on my own) Not sure, no idea where they were generated from.. I'll see if they are needed at all. I could remove all of them without any issues, so best to recreate the tarball and push to NEW again, with all the fixes. scratch that, removing those trims the resulting .jar too and breaks at least JAXB build.. so I guess they just need an exception on debian/copyright? -- t __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
Comments regarding relaxngcc_1.12-1_amd64.changes
Dear maintainer, While processing your upload of relaxngcc 1.12-1, I noticed the following things about the packaging: - The source tarball has been repacked, but this is not documented anywhere, and the only sign of it is the get-orig-targz target in debian/rules. Please document this in the debian/copyright file. Explaining why the repacking was done and what is removed would also be nice to see documented in debian/README.source, not just as comments in debian/rules. - src/relaxngcc/javabody/JavaBodyParser.jj does not appear to be under the Apache-1.1 license, but what exactly it is under, is unclear to me. This should be clarified. - There are a couple of files in the source that have comments like: /* this file is generated by RelaxNGCC */ Are these files rebuildable? (Sadly, my Java build system knowledge is not enough to determine this on my own) None of these warrant a reject, but I would like to see them clarified, if I'm to let the package through NEW. If you want to correct them, and reupload, instead of fixing them in a future version, that is also an option. I will reject the current version from NEW then, and you can reupload after. __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
