Re: [SCM] audacity/master: Add overrides files.

[Jaromír Mikeš]

2017-11-07 16:48 GMT+01:00 James Cowgill :

> Hi,
>
> On 07/11/17 12:32, Jaromír Mikeš wrote:
> > 2017-11-07 11:36 GMT+01:00 James Cowgill :
> >> On 07/11/17 10:32, James Cowgill wrote:
> >>> "Distribution of this memo is unlimited." is not a free license.
> >>
> >> However on closer inspection they are free for other reasons. You should
> >> probably include the relevant parts of libogg's debian/copyright in
> >> audacity's debian/copyright.
> >>
> >> https://tracker.debian.org/media/packages/libo/libogg/copyright-1.3.2-1
> >>
> >
> > ​Thank you James for spotting this ... as not-native English speaker
> > sometimes missing point :/
> > Please check my commit if all is fixed now.
>
> There are some issues.
>
> As far as I can tell, RFC 3533 and RFC 5334 are not under the same
> license, but your copyright file claims they are. Using "License: RFC"
> looks wrong and someone might read it as the license for all RFCs (which
> is not the case). I think you should have one section for each RFC eg
> "RFC-3533" and "RFC-5334".
>
> You made a copy-paste error in the license for RFC 5334 (part is
> duplicated).
>
> The indentation on the email headers is wrong. If you look at libogg's
> copyright file, it is indented correctly (remember email headers use the
> same format as Debian control files).
>
> You should not refer to tracker.debian.org because that file will
> disappear the next time libogg is uploaded.
>

​Hopefully fixed now ;) ... please check commit

best rerads

mira​
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: [SCM] audacity/master: Add overrides files.

[James Cowgill]

Hi,

On 07/11/17 12:32, Jaromír Mikeš wrote:
> 2017-11-07 11:36 GMT+01:00 James Cowgill :
>> On 07/11/17 10:32, James Cowgill wrote:
>>> "Distribution of this memo is unlimited." is not a free license.
>>
>> However on closer inspection they are free for other reasons. You should
>> probably include the relevant parts of libogg's debian/copyright in
>> audacity's debian/copyright.
>>
>> https://tracker.debian.org/media/packages/libo/libogg/copyright-1.3.2-1
>>
> 
> ​Thank you James for spotting this ... as not-native English speaker
> sometimes missing point :/
> Please check my commit if all is fixed now.

There are some issues.

As far as I can tell, RFC 3533 and RFC 5334 are not under the same
license, but your copyright file claims they are. Using "License: RFC"
looks wrong and someone might read it as the license for all RFCs (which
is not the case). I think you should have one section for each RFC eg
"RFC-3533" and "RFC-5334".

You made a copy-paste error in the license for RFC 5334 (part is
duplicated).

The indentation on the email headers is wrong. If you look at libogg's
copyright file, it is indented correctly (remember email headers use the
same format as Debian control files).

You should not refer to tracker.debian.org because that file will
disappear the next time libogg is uploaded.

James



signature.asc
Description: OpenPGP digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: [SCM] audacity/master: Add overrides files.

[Jaromír Mikeš]

2017-11-07 11:36 GMT+01:00 James Cowgill :

> On 07/11/17 10:32, James Cowgill wrote:
> > Hi,
> >
> > On 07/11/17 01:32, mira-gu...@users.alioth.debian.org wrote:
> >> The following commit has been merged in the master branch:
> >> commit c866421d7216e5748722057319a959d212c88955
> >> Author: Jaromír Mikeš 
> >> Date:   Tue Nov 7 02:31:31 2017 +0100
> >>
> >> Add overrides files.
> > [...]
> >> diff --git a/debian/source.lintian-overrides b/debian/source.lintian-
> overrides
> >> new file mode 100644
> >> index 000..e6b0970
> >> --- /dev/null
> >> +++ b/debian/source.lintian-overrides
> >> @@ -0,0 +1,4 @@
> >> +# Licence statment in these file is "Distribution of this memo is
> unlimited."
> >> +# So overriding this warnings.
> >> +audacity source: license-problem-non-free-RFC
> lib-src/libogg/doc/rfc3533.txt
> >> +audacity source: license-problem-non-free-RFC-BCP78
> lib-src/libogg/doc/rfc5334.txt
> >
> > "Distribution of this memo is unlimited." is not a free license.
>
> However on closer inspection they are free for other reasons. You should
> probably include the relevant parts of libogg's debian/copyright in
> audacity's debian/copyright.
>
> https://tracker.debian.org/media/packages/libo/libogg/copyright-1.3.2-1
>

​Thank you James for spotting this ... as not-native English speaker
sometimes missing point :/
Please check my commit if all is fixed now.

best regards

mira ​
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: [SCM] audacity/master: Add overrides files.

[James Cowgill]

On 07/11/17 10:32, James Cowgill wrote:
> Hi,
> 
> On 07/11/17 01:32, mira-gu...@users.alioth.debian.org wrote:
>> The following commit has been merged in the master branch:
>> commit c866421d7216e5748722057319a959d212c88955
>> Author: Jaromír Mikeš 
>> Date:   Tue Nov 7 02:31:31 2017 +0100
>>
>> Add overrides files.
> [...]
>> diff --git a/debian/source.lintian-overrides 
>> b/debian/source.lintian-overrides
>> new file mode 100644
>> index 000..e6b0970
>> --- /dev/null
>> +++ b/debian/source.lintian-overrides
>> @@ -0,0 +1,4 @@
>> +# Licence statment in these file is "Distribution of this memo is 
>> unlimited."
>> +# So overriding this warnings.
>> +audacity source: license-problem-non-free-RFC lib-src/libogg/doc/rfc3533.txt
>> +audacity source: license-problem-non-free-RFC-BCP78 
>> lib-src/libogg/doc/rfc5334.txt
> 
> "Distribution of this memo is unlimited." is not a free license.

However on closer inspection they are free for other reasons. You should
probably include the relevant parts of libogg's debian/copyright in
audacity's debian/copyright.

https://tracker.debian.org/media/packages/libo/libogg/copyright-1.3.2-1

Thanks,
James



signature.asc
Description: OpenPGP digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: [SCM] audacity/master: Add overrides files.

[James Cowgill]

Hi,

On 07/11/17 01:32, mira-gu...@users.alioth.debian.org wrote:
> The following commit has been merged in the master branch:
> commit c866421d7216e5748722057319a959d212c88955
> Author: Jaromír Mikeš 
> Date:   Tue Nov 7 02:31:31 2017 +0100
> 
> Add overrides files.
[...]
> diff --git a/debian/source.lintian-overrides b/debian/source.lintian-overrides
> new file mode 100644
> index 000..e6b0970
> --- /dev/null
> +++ b/debian/source.lintian-overrides
> @@ -0,0 +1,4 @@
> +# Licence statment in these file is "Distribution of this memo is unlimited."
> +# So overriding this warnings.
> +audacity source: license-problem-non-free-RFC lib-src/libogg/doc/rfc3533.txt
> +audacity source: license-problem-non-free-RFC-BCP78 
> lib-src/libogg/doc/rfc5334.txt

"Distribution of this memo is unlimited." is not a free license.

James



signature.asc
Description: OpenPGP digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers