Re: phasex – request for review

[Jaromír Mikeš]

2018-01-09 18:48 GMT+01:00 Gabor Karsay :

Bumped compat level, however I had unexpected difficulties.
> After changing compat level from 10 to 11 it won't build with pbuilder
> anymore! Drove me crazy.
>
​
I just tried build phasex compat/dh 11 and all went fine ... :(
Did you create pbuilder with distribution sid ?

$pbuilder create --distribution sid

Or just wipe pbuilder chroot and create it again.

mira ​
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: phasex – request for review

[Gabor Karsay]

Hi,

first of all sorry for being veeery slow these days.
James Cowgill schrieb am 2018-01-01 um 21:38:

Hi,

On 29/12/17 13:42, Jaromír Mikeš wrote:

2017-12-29 13:46 GMT+01:00 Gabor Karsay :

​Hi Gabor,



I fixed the watch file for phasex and I'm asking for a review/upload.
Maybe mira? You have listed yourself as uploader.

Amongst other thing I also migrated to automatic debug packages following
this guide: https://wiki.debian.org/AutomaticDebugPackages



​Lintian says:
$ lintian -IE --pedantic --no-tag-display-limit
../phasex_0.14.97-3_amd64.changes
P: phasex source: package-uses-old-debhelper-compat-version 10
W: phasex source: newer-standards-version 4.1.3 (current is 4.1.2)
I: phasex source: testsuite-autopkgtest-missing
P: phasex source: debian-watch-may-check-gpg-signature
I: phasex: spelling-error-in-binary usr/bin/phasex GNU Public License GNU
General Public License
I: phasex: arch-dep-package-has-big-usr-share 10320kB 95%
W: phasex: binary-without-manpage usr/bin/phasex
W: phasex: binary-without-manpage usr/bin/phasex-convert-patch
I: phasex: desktop-entry-lacks-keywords-entry
usr/share/applications/phasex.desktop
​
​So I would go with dh compat 11 now and keep standards version 4.1.2 until
lintian will recognize 4.1.3


Bumped compat level, however I had unexpected difficulties.
After changing compat level from 10 to 11 it won't build with pbuilder 
anymore! Drove me crazy.


It works locally but with `gbp buildpackage --git-ignore-new 
--git-pbuilder` I get this:



The following packages have unmet dependencies:
 pbuilder-satisfydepends-dummy : Depends: debhelper (>= 11) but it is not going 
to be installed
Unable to resolve dependencies!  Giving up...


I have absolutely no idea why. Of course I updated pbuilder before.


Lintian is clearly wrong here so I think you should ignore it.

I kept it at 4.1.3.


Also I would fix desktop file ... we are shipping our one in debian dir.

Done.



d/rules
override_dh_strip:
dh_strip --dbgsym-migration='phasex-dbg (<< 0.14.97-3~)'

This seems to be redundant I believe with compat 10 and higher.


Whether the --dbgsym-migration option is redundant depends on the
package. The purpose of that option is to prevent dpkg failing to
install the new dbgsym package if the old dbg package is installed (file
conflicts). Usually if all the binaries in your package have changed,
the debug files in /usr/lib/debug/.build-id will also change names and
the option isn't needed.

In this case no new upstream has been imported, so you probably do need
the option (until the next upstream version is imported).


I kept it. However I also tried piuparts (with 
--extra-old-packages=phasex-dbg) and upgrading phasex was successfull in 
both cases, with the dh_strip line and also without. In both cases 
phasex-dbg will be uninstalled. (With compat level 10.)


Gabor

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: phasex – request for review

[James Cowgill]

Hi,

On 29/12/17 13:42, Jaromír Mikeš wrote:
> 2017-12-29 13:46 GMT+01:00 Gabor Karsay :
> 
> ​Hi Gabor,
> 
> 
>> I fixed the watch file for phasex and I'm asking for a review/upload.
>> Maybe mira? You have listed yourself as uploader.
>>
>> Amongst other thing I also migrated to automatic debug packages following
>> this guide: https://wiki.debian.org/AutomaticDebugPackages
> 
> 
> ​Lintian says:
> $ lintian -IE --pedantic --no-tag-display-limit
> ../phasex_0.14.97-3_amd64.changes
> P: phasex source: package-uses-old-debhelper-compat-version 10
> W: phasex source: newer-standards-version 4.1.3 (current is 4.1.2)
> I: phasex source: testsuite-autopkgtest-missing
> P: phasex source: debian-watch-may-check-gpg-signature
> I: phasex: spelling-error-in-binary usr/bin/phasex GNU Public License GNU
> General Public License
> I: phasex: arch-dep-package-has-big-usr-share 10320kB 95%
> W: phasex: binary-without-manpage usr/bin/phasex
> W: phasex: binary-without-manpage usr/bin/phasex-convert-patch
> I: phasex: desktop-entry-lacks-keywords-entry
> usr/share/applications/phasex.desktop
> ​
> ​So I would go with dh compat 11 now and keep standards version 4.1.2 until
> lintian will recognize 4.1.3

Lintian is clearly wrong here so I think you should ignore it.

> Also I would fix desktop file ... we are shipping our one in debian dir.
> 
> d/rules
> override_dh_strip:
> dh_strip --dbgsym-migration='phasex-dbg (<< 0.14.97-3~)'
> 
> This seems to be redundant I believe with compat 10 and higher.

Whether the --dbgsym-migration option is redundant depends on the
package. The purpose of that option is to prevent dpkg failing to
install the new dbgsym package if the old dbg package is installed (file
conflicts). Usually if all the binaries in your package have changed,
the debug files in /usr/lib/debug/.build-id will also change names and
the option isn't needed.

In this case no new upstream has been imported, so you probably do need
the option (until the next upstream version is imported).

Thanks,
James



signature.asc
Description: OpenPGP digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: phasex – request for review

[Jaromír Mikeš]

2017-12-29 13:46 GMT+01:00 Gabor Karsay :

​Hi Gabor,


> I fixed the watch file for phasex and I'm asking for a review/upload.
> Maybe mira? You have listed yourself as uploader.
>
> Amongst other thing I also migrated to automatic debug packages following
> this guide: https://wiki.debian.org/AutomaticDebugPackages


​Lintian says:
$ lintian -IE --pedantic --no-tag-display-limit
../phasex_0.14.97-3_amd64.changes
P: phasex source: package-uses-old-debhelper-compat-version 10
W: phasex source: newer-standards-version 4.1.3 (current is 4.1.2)
I: phasex source: testsuite-autopkgtest-missing
P: phasex source: debian-watch-may-check-gpg-signature
I: phasex: spelling-error-in-binary usr/bin/phasex GNU Public License GNU
General Public License
I: phasex: arch-dep-package-has-big-usr-share 10320kB 95%
W: phasex: binary-without-manpage usr/bin/phasex
W: phasex: binary-without-manpage usr/bin/phasex-convert-patch
I: phasex: desktop-entry-lacks-keywords-entry
usr/share/applications/phasex.desktop
​
​So I would go with dh compat 11 now and keep standards version 4.1.2 until
lintian will recognize 4.1.3
Also I would fix desktop file ... we are shipping our one in debian dir.

d/rules
override_dh_strip:
dh_strip --dbgsym-migration='phasex-dbg (<< 0.14.97-3~)'

This seems to be redundant I believe with compat 10 and higher.

You could add yourself to uploaders in d/control file and also add hint to
d/copyright file about your contribution ...
Files: debian/*
Copyright: 2010-2013 Alessio Treglia 
License: GPL-3+

Please remove me from uploaders list as I never started work on this
package and at the moment I am maintaining quite big number of packages.

let me know when these are fixed and I will check again.

best regards

mira
 ​
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

phasex – request for review

[Gabor Karsay]

Hi,

I fixed the watch file for phasex and I'm asking for a review/upload.
Maybe mira? You have listed yourself as uploader.

Amongst other thing I also migrated to automatic debug packages 
following this guide: https://wiki.debian.org/AutomaticDebugPackages


Thanks,
Gabor

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers