Re: yoshimi_1.5.6-1_amd64.changes REJECTED

[Chris Lamb]

Hi Jaromír,

> ​​yoshimi 1.5.6-2 has been uploaded kindly by Mattia to NEW.

ACCEPTed - thanks!

> Apologize for previous spamming you.

You weren't spamming me, don't worry :)


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: yoshimi_1.5.6-1_amd64.changes REJECTED

[Jaromír Mikeš]

2017-12-21 20:16 GMT+01:00 Mattia Rizzolo :

> On Thu, Dec 21, 2017 at 08:48:16AM +0100, Jaromír Mikeš wrote:
> > Is that correct?
>
> Is the CC text that's there the 3.0 one?
>
> TBH, I'm nowhere in the mood of checking all of copyrights myself, but
> what's written in d/copyright now makes sense anyway.  If you confirm
> the above I could try uploading again.
>

​Yes ... text is CC-BY-3.0

best regards

mira
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: yoshimi_1.5.6-1_amd64.changes REJECTED

[Mattia Rizzolo]

On Thu, Dec 21, 2017 at 08:48:16AM +0100, Jaromír Mikeš wrote:
> Is that correct?

Is the CC text that's there the 3.0 one?

TBH, I'm nowhere in the mood of checking all of copyrights myself, but
what's written in d/copyright now makes sense anyway.  If you confirm
the above I could try uploading again.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: yoshimi_1.5.6-1_amd64.changes REJECTED

[Jaromír Mikeš]

2017-12-21 0:50 GMT+01:00 Mattia Rizzolo :

> [ dropping Chris and ftpmaster@ as requested ]
>
> On Wed, Dec 20, 2017 at 10:04:37PM +0100, Jaromír Mikeš wrote:
> > There is no hint on copyright holder in svg files
>
> How so, it looks pretty clear to me:
> https://sources.debian.org/src/yoshimi/1.5.5-2/Util/
> YoshimiSplash.svg/#L5-L9
> |Cloud image used in the overlay created by
> |
> |Arun Kulshreshtha, 2006
> |
> |accessed from: https://commons.wikimedia.org/
> wiki/File:Above_the_Clouds.jpg
>

​Yes ... this didn't seems to be clear copyright claim to me as it refers
to overlay only not svg file itself and sorry I didn't mentioned that.​

> and there is this link:
> > https://creativecommons.org/ns
> > Maybe this was interpreted as CC-BY license by decopy?
>
> Right.  And indeed I fail to parse that, but AFAIK that's a petty
> teplate of inkscape, and by itself that tag doesn't convey anything…
> But sometimes svg files has the correct metadata in the right tags;
> rarely, but happens :)
>
> However, there is a hint that to the original file used, which is taken
> from wikipedia and it is
> |Copyright: 2006 Arun Kulshreshtha
> |License: CC-BY-3.0
> (the us variant)
>
> And it's clearly modified so it probably should also bear the copyright
> of somebody else, but to me it looks like nobody claimed it, so ignore
> this part…
>
> The other svg Util/splashreference.svg instead doesn't have anything,
> and it clearly is an original work of yoshimi's developers, so IMHO it
> falls under the "global" copyright/license paragraph.
>

​I moved Util/splashreference.svg under global copyright/license and for
Util/YoshimiSplash.svg goes this:

Files: Util/YoshimiSplash.svg
Copyright: 2006, Arun Kulshreshtha
License: CC-BY-3.0​

Is that correct?

regards

mira
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: yoshimi_1.5.6-1_amd64.changes REJECTED

[Mattia Rizzolo]

[ dropping Chris and ftpmaster@ as requested ]

On Wed, Dec 20, 2017 at 10:04:37PM +0100, Jaromír Mikeš wrote:
> There is no hint on copyright holder in svg files

How so, it looks pretty clear to me:
https://sources.debian.org/src/yoshimi/1.5.5-2/Util/YoshimiSplash.svg/#L5-L9
|Cloud image used in the overlay created by
|
|Arun Kulshreshtha, 2006
|
|accessed from: https://commons.wikimedia.org/wiki/File:Above_the_Clouds.jpg

Seriously, are you even trying to look for it?

> and there is this link:
> https://creativecommons.org/ns
> Maybe this was interpreted as CC-BY license by decopy?

Right.  And indeed I fail to parse that, but AFAIK that's a petty
teplate of inkscape, and by itself that tag doesn't convey anything…
But sometimes svg files has the correct metadata in the right tags;
rarely, but happens :)

However, there is a hint that to the original file used, which is taken
from wikipedia and it is
|Copyright: 2006 Arun Kulshreshtha
|License: CC-BY-3.0
(the us variant)

And it's clearly modified so it probably should also bear the copyright
of somebody else, but to me it looks like nobody claimed it, so ignore
this part…

The other svg Util/splashreference.svg instead doesn't have anything,
and it clearly is an original work of yoshimi's developers, so IMHO it
falls under the "global" copyright/license paragraph.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: yoshimi_1.5.6-1_amd64.changes REJECTED

[Chris Lamb]

Hi Jaromír et al.,

> […]

Please drop me from CC whilst you work this out. However, do feel free
to ping me once you have reuploaded :)


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: yoshimi_1.5.6-1_amd64.changes REJECTED

[Jaromír Mikeš]

2017-12-20 19:11 GMT+01:00 Mattia Rizzolo :

> On Wed, Dec 20, 2017 at 06:17:10PM +0100, Jaromír Mikeš wrote:
>
> > Similar goes for license CC-BY it just has been without a version so I
> > hoped v3.0 is fitting.
> > Actually I am quite curious how decopy generate license from svg files.
>
> SVG is just a text file (an XML), just open it with your preferred text
> editor.  Util/YoshimiSplash.svg even has a human-readable comment in it
> with the information you are looking for.
>

​There is no hint on copyright holder in svg files and there is this link:
https://creativecommons.org/ns
​Maybe this was interpreted as CC-BY license by decopy?


> The xiz files seems to be gzip-compressed XML as well, just opening a
> random one (with zless) I can see this:
> |(c) Dario Straulino
> |License: GPLv3
> Guess the others are in a similar situation.
>

​Yes the others are similar case.
I added Dario Straulino as copyright holder for that banks

mira​
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: yoshimi_1.5.6-1_amd64.changes REJECTED

[Mattia Rizzolo]

On Wed, Dec 20, 2017 at 06:17:10PM +0100, Jaromír Mikeš wrote:
> I have used decopy app for first generating copyright file and than I edit
> it manually.

Let me recommend to always check what automated tools thinks of a
copyright or license of a file.  I have yet to meet with something that
does a good enough work to actually save me time.

> So for those two examles above there was no "Copyright" field at all but
> linthian complained about it.

Rightly so.

> Should be these paragraphs removed removed as there is no copyright holder?

No, they should be appropriately fixed to list the real copyright owner.
Also, this question makes me wonder on whether you have any basic
knowledge about intellectual property, but alas I don't really have any
idea where to point you for more information.

> Similar goes for license CC-BY it just has been without a version so I
> hoped v3.0 is fitting.
> Actually I am quite curious how decopy generate license from svg files.

SVG is just a text file (an XML), just open it with your preferred text
editor.  Util/YoshimiSplash.svg even has a human-readable comment in it
with the information you are looking for.
The xiz files seems to be gzip-compressed XML as well, just opening a
random one (with zless) I can see this:
|(c) Dario Straulino
|License: GPLv3
Guess the others are in a similar situation.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: yoshimi_1.5.6-1_amd64.changes REJECTED

[Jaromír Mikeš]

2017-12-20 17:27 GMT+01:00 Mattia Rizzolo :

> On Wed, Dec 20, 2017 at 03:39:29PM +0100, Jaromír Mikeš wrote:
> > Ok ... I beleave it is fixed now in our git repo.
> > Mattia can you check it and upload again please?
>

​Hi Mattia,



> I haven't looked at the whole d/copyright, but just looking at a small
> commit:
>
>
>  Files: src/Misc/Config.cpp
> @@ -122,6 +123,7 @@ License: GPL-2+ or LGPL-2+
>
>  Files: Util/YoshimiSplash.svg
> Util/splashreference.svg
> +Copyright: no-copyright
>  License: CC-BY
>
> That's not going to fly:
> * "no-copyright" is hardly a copyright holder (which afaik is "required"
>   by both GPL-3 and CC-*
> * CC-BY: what version?  you dumped a whole license text, so I guess you
>   know what the answer
>

​I have used decopy app for first generating copyright file and than I edit
it manually.
So for those two examles above there was no "Copyright" field at all but
linthian complained about it.
Should be these paragraphs removed removed as there is no copyright holder?

Similar goes for license CC-BY it just has been without a version so I
hoped v3.0 is fitting.
Actually I am quite curious how decopy generate license from svg files.




> * peaking further I see that you included the COPYING file as a
>   copyrighted thing in the paragraph at line 99; whilst due to the
>   initial Files:* it's included anyway,


​COPYING file is now removed

mira​
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: yoshimi_1.5.6-1_amd64.changes REJECTED

[Mattia Rizzolo]

On Wed, Dec 20, 2017 at 03:39:29PM +0100, Jaromír Mikeš wrote:
> Ok ... I beleave it is fixed now in our git repo.
> Mattia can you check it and upload again please?

I haven't looked at the whole d/copyright, but just looking at a small
commit:

--- a/debian/copyright
+++ b/debian/copyright
@@ -103,9 +103,10 @@ Copyright: 2011, Alan Calvert
2014-2017, Will Godfrey
 License: GPL-3+

-Files: banks/Drums/0004-Natural Drum Kit.xiz
-   banks/Drums/0005-Natural Snare - variable deca.xiz
-   banks/Drums/0006-HiHat closed - variable decay.xiz
+Files: banks/Drums/0004-Natural?Drum?Kit.xiz
+   banks/Drums/0005-Natural?Snare?-?variable?deca.xiz
+   banks/Drums/0006-HiHat?closed?-?variable?decay.xiz
+Copyright: no-copyright
 License: GPL-3

 Files: src/Misc/Config.cpp
@@ -122,6 +123,7 @@ License: GPL-2+ or LGPL-2+

 Files: Util/YoshimiSplash.svg
Util/splashreference.svg
+Copyright: no-copyright
 License: CC-BY

That's not going to fly:
* "no-copyright" is hardly a copyright holder (which afaik is "required"
  by both GPL-3 and CC-*
* CC-BY: what version?  you dumped a whole license text, so I guess you
  know what the answer
* peaking further I see that you included the COPYING file as a
  copyrighted thing in the paragraph at line 99; whilst due to the
  initial Files:* it's included anyway, I don't think it should stay in
  a paragraph of its own, I'm pretty sure the GPL-2/3 text is not
  copyrighted by those two guys; besides, 'License: GPL-3+' for the
  GPL-2 text :P

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: yoshimi_1.5.6-1_amd64.changes REJECTED

[Jaromír Mikeš]

2017-12-20 9:43 GMT+01:00 Chris Lamb :

>
> > ​What is a reason for rejecting this upload?
>
> Oh dear, the note got lost. Sorry about that. :/  Um, I thiiink it was to
> do with missing some attributions (eg. for Nikita / Jesper Lloyd /
> Christian
> Schoenebeck, etc. etc.)
>
> ... but I think there was something else too. (There was another note from
> a FTP trainee).
>
> Please fix the above (and other missing references), re-upload and let me
> know. :)  Sorry again...


​Ok ... I beleave ​it is fixed now in our git repo.
Mattia can you check it and upload again please?

best regards

mira
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: yoshimi_1.5.6-1_amd64.changes REJECTED

[Chris Lamb]

Hi Jaromír Mikeš,

> ​What is a reason for rejecting this upload?

Oh dear, the note got lost. Sorry about that. :/  Um, I thiiink it was to
do with missing some attributions (eg. for Nikita / Jesper Lloyd / Christian
Schoenebeck, etc. etc.)

... but I think there was something else too. (There was another note from
a FTP trainee).

Please fix the above (and other missing references), re-upload and let me
know. :)  Sorry again...


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: yoshimi_1.5.6-1_amd64.changes REJECTED

[Jaromír Mikeš]

2017-12-19 23:00 GMT+01:00 Chris Lamb :

​Hi Chris,​


Please feel free to respond to this email if you don't understand why
> your files were rejected, or if you upload new files which address our
> concerns.
>

​What is a reason for rejecting this upload?

best regards

mira​
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

yoshimi_1.5.6-1_amd64.changes REJECTED

[Chris Lamb]

===

Please feel free to respond to this email if you don't understand why
your files were rejected, or if you upload new files which address our
concerns.


___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers