Bug#1065756: pngnq: FTBFS on arm{el, hf}: rwpng.c:242:13: error: implicit declaration of function ‘strncmp’ [-Werror=implicit-function-declaration]
On 2024-03-10 10:50:08 +0800, xiao sheng wen(肖盛文) wrote:
> Hi,
>
> I fix this bug in mentors:
>
> https://mentors.debian.net/package/pngnq/
>
> Welcome to review and upload.
Thanks, uploaded.
Cheers
>
> [-Werror=implicit-function-declaration] is promote to error level in
> arm{el, hf} arch than before.
>
> Thanks!
>
> 在 2024/3/10 08:36, xiao sheng wen(肖盛文) 写道:
> > Hi,
> >
> > Thanks for your report.
> > The upstream of this package almost dead.
> >
> > The patch is welcome.
> >
> > CC to debian-arm list.
> >
> > 在 2024/3/10 04:07, Sebastian Ramacher via Pkg-phototools-devel 写道:
> > > Source: pngnq
> > > Version: 1.1+ds-2
> > > Severity: serious
> > > Tags: ftbfs sid trixie
> > > Justification: fails to build from source (but built successfully in
> > > the past)
> > > X-Debbugs-Cc: sramac...@debian.org
> > >
> > > https://buildd.debian.org/status/fetch.php?pkg=pngnq=armhf=1.1%2Bds-2%2Bb1=1709981044=0
> > >
> > >
> > > gcc -DHAVE_CONFIG_H -I. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
> > > -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 `libpng-config
> > > --I_opts` -Wall --pedantic -std=gnu99 -g -O2
> > > -Werror=implicit-function-declaration
> > > -ffile-prefix-map=/<>=. -fstack-protector-strong
> > > -fstack-clash-protection -Wformat -Werror=format-security -c -o
> > > colorspace.o colorspace.c
> > > rwpng.c: In function ‘rwpng_read_image’:
> > > rwpng.c:242:13: error: implicit declaration of function ‘strncmp’
> > > [-Werror=implicit-function-declaration]
> > > 242 | if(!strncmp("author",comments[c].key,6)){
> > > | ^~~
> > > rwpng.c:40:1: note: include ‘’ or provide a declaration of
> > > ‘strncmp’
> > > 39 | #include "rwpng.h" /* typedefs, common macros, public
> > > prototypes */
> > > +++ |+#include
> > > 40 |
> > > rwpng.c:242:46: warning: ‘strncmp’ argument 3 type is ‘int’ where
> > > ‘unsigned int’ is expected in a call to built-in function declared
> > > without prototype [-Wbuiltin-declaration-mismatch]
> > > 242 | if(!strncmp("author",comments[c].key,6)){
> > > | ^
> > > : note: built-in ‘strncmp’ declared here
> > > In file included from colorspace.c:7:
> > > colorspace.h:25:18: warning: ‘d00’ defined but not used
> > > [-Wunused-variable]
> > > 25 | static color_XYZ d00 = {0.0, 0.0, 0.0};
> > > | ^~~
> > > rwpng.c:85:5: warning: ignoring return value of ‘fread’ declared
> > > with attribute ‘warn_unused_result’ [-Wunused-result]
> > > 85 | fread(sig, 1, 8, infile);
> > > | ^~~~
> > > In file included from pngnq.c:99:
> > > neuquant32.h:59:22: warning: ‘biasvalue’ declared ‘static’ but never
> > > defined [-Wunused-function]
> > > 59 | static inline double biasvalue(unsigned int temp);
> > > | ^
> > > pngcomp.c: In function ‘main’:
> > > pngcomp.c:118:10: warning: variable ‘block_err_image’ set but not
> > > used [-Wunused-but-set-variable]
> > > 118 | float* block_err_image = NULL;
> > > | ^~~
> > > pngcomp.c:108:7: warning: variable ‘verbose’ set but not used
> > > [-Wunused-but-set-variable]
> > > 108 | int verbose = 0;
> > > | ^~~
> > > pngcomp.c: In function ‘printstats’:
> > > pngcomp.c:506:30: warning: format ‘%ld’ expects argument of type
> > > ‘long int’, but argument 2 has type ‘png_uint_32’ {aka ‘unsigned
> > > int’} [-Wformat=]
> > > 506 | printf("Image Dimensions %ld x %ld
> > > \n",image1_info.width,image1_info.height);
> > > | ~~^ ~
> > > | | |
> > > | long int png_uint_32 {aka
> > > unsigned int}
> > > | %d
> > > pngcomp.c:506:36: warning: format ‘%ld’ expects argument of type
> > > ‘long int’, but argument 3 has type ‘png_uint_32’ {aka ‘unsigned
> > > int’} [-Wformat=]
> > > 506 | printf("Image Dimensions %ld x %ld
> > > \n",image1_info.width,image1_info.height);
> > >
Bug#1065756: pngnq: FTBFS on arm{el, hf}: rwpng.c:242:13: error: implicit declaration of function ‘strncmp’ [-Werror=implicit-function-declaration]
Source: pngnq
Version: 1.1+ds-2
Severity: serious
Tags: ftbfs sid trixie
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: sramac...@debian.org
https://buildd.debian.org/status/fetch.php?pkg=pngnq=armhf=1.1%2Bds-2%2Bb1=1709981044=0
gcc -DHAVE_CONFIG_H -I. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 `libpng-config --I_opts` -Wall
--pedantic -std=gnu99 -g -O2 -Werror=implicit-function-declaration
-ffile-prefix-map=/<>=. -fstack-protector-strong
-fstack-clash-protection -Wformat -Werror=format-security -c -o colorspace.o
colorspace.c
rwpng.c: In function ‘rwpng_read_image’:
rwpng.c:242:13: error: implicit declaration of function ‘strncmp’
[-Werror=implicit-function-declaration]
242 | if(!strncmp("author",comments[c].key,6)){
| ^~~
rwpng.c:40:1: note: include ‘’ or provide a declaration of ‘strncmp’
39 | #include "rwpng.h" /* typedefs, common macros, public prototypes */
+++ |+#include
40 |
rwpng.c:242:46: warning: ‘strncmp’ argument 3 type is ‘int’ where ‘unsigned
int’ is expected in a call to built-in function declared without prototype
[-Wbuiltin-declaration-mismatch]
242 | if(!strncmp("author",comments[c].key,6)){
| ^
: note: built-in ‘strncmp’ declared here
In file included from colorspace.c:7:
colorspace.h:25:18: warning: ‘d00’ defined but not used [-Wunused-variable]
25 | static color_XYZ d00 = {0.0, 0.0, 0.0};
| ^~~
rwpng.c:85:5: warning: ignoring return value of ‘fread’ declared with attribute
‘warn_unused_result’ [-Wunused-result]
85 | fread(sig, 1, 8, infile);
| ^~~~
In file included from pngnq.c:99:
neuquant32.h:59:22: warning: ‘biasvalue’ declared ‘static’ but never defined
[-Wunused-function]
59 | static inline double biasvalue(unsigned int temp);
| ^
pngcomp.c: In function ‘main’:
pngcomp.c:118:10: warning: variable ‘block_err_image’ set but not used
[-Wunused-but-set-variable]
118 | float* block_err_image = NULL;
| ^~~
pngcomp.c:108:7: warning: variable ‘verbose’ set but not used
[-Wunused-but-set-variable]
108 | int verbose = 0;
| ^~~
pngcomp.c: In function ‘printstats’:
pngcomp.c:506:30: warning: format ‘%ld’ expects argument of type ‘long int’,
but argument 2 has type ‘png_uint_32’ {aka ‘unsigned int’} [-Wformat=]
506 | printf("Image Dimensions %ld x %ld
\n",image1_info.width,image1_info.height);
|~~^ ~
| | |
| long int png_uint_32 {aka
unsigned int}
|%d
pngcomp.c:506:36: warning: format ‘%ld’ expects argument of type ‘long int’,
but argument 3 has type ‘png_uint_32’ {aka ‘unsigned int’} [-Wformat=]
506 | printf("Image Dimensions %ld x %ld
\n",image1_info.width,image1_info.height);
| ~~^
~~
|| |
|long int
png_uint_32 {aka unsigned int}
| %d
In file included from pngcomp.c:59:
colorspace.h: At top level:
colorspace.h:25:18: warning: ‘d00’ defined but not used [-Wunused-variable]
25 | static color_XYZ d00 = {0.0, 0.0, 0.0};
| ^~~
colorspace.h:24:18: warning: ‘d65’ defined but not used [-Wunused-variable]
24 | static color_XYZ d65 = {0.94810,1.,1.07305};
| ^~~
pngnq.c: In function ‘createoutname’:
pngnq.c:279:7: warning: ‘__builtin_strncpy’ output truncated before terminating
nul copying 1 byte from a string of the same length [-Wstringop-truncation]
279 | strncpy(newdir+dir_len,DIR_SEPARATOR_STR,1);
| ^
cc1: some warnings being treated as errors
make[3]: *** [Makefile:403: rwpng.o] Error 1
Cheers
--
Sebastian Ramacher
Bug#1053661: darktable: no longer detects libavif
Source: darktable Version: 4.4.2-1 Severity: normal X-Debbugs-Cc: sramac...@debian.org After the rebuild for the libavif transition, darktable is no longer built with libavif support: CMake Warning at src/CMakeLists.txt:356 (find_package): Could not find a configuration file for package "libavif" that is compatible with requested version "0.8.2". The following configuration files were considered but not accepted: /usr/lib/x86_64-linux-gnu/cmake/libavif/libavif-config.cmake, version: 1.0.1 https://buildd.debian.org/status/fetch.php?pkg=darktable=amd64=4.4.2-1%2Bb1=1696715265=0 Cheers -- Sebastian Ramacher
Bug#1023997: pfstools: FTBFS: collect2: error: ld returned 1 exit status
Source: pfstools Version: 2.2.0-4 Severity: serious Tags: ftbfs sid bookworm Justification: fails to build from source (but built successfully in the past) X-Debbugs-Cc: sramac...@debian.org https://buildd.debian.org/status/fetch.php?pkg=pfstools=amd64=2.2.0-4%2Bb2=1667855058=0 /usr/bin/ld: ./obj-x86_64-linux-gnu/src/pfsglview/./src/pfsglview/m_histogram.cpp:990: undefined reference to `glutSetCursor' /usr/bin/ld: CMakeFiles/pfsglview.dir/m_histogram.cpp.o:./obj-x86_64-linux-gnu/src/pfsglview/./src/pfsglview/m_histogram.cpp:995: more undefined references to `glutSetCursor' follow /usr/bin/ld: CMakeFiles/pfsglview.dir/m_status.cpp.o: in function `SC_Status::redraw()': ./obj-x86_64-linux-gnu/src/pfsglview/./src/pfsglview/m_status.cpp:74: undefined reference to `glutBitmap8By13' /usr/bin/ld: ./obj-x86_64-linux-gnu/src/pfsglview/./src/pfsglview/m_status.cpp:74: undefined reference to `glutBitmapCharacter' /usr/bin/ld: ./obj-x86_64-linux-gnu/src/pfsglview/./src/pfsglview/m_status.cpp:79: undefined reference to `glutBitmap8By13' /usr/bin/ld: ./obj-x86_64-linux-gnu/src/pfsglview/./src/pfsglview/m_status.cpp:79: undefined reference to `glutBitmapCharacter' /usr/bin/ld: ./obj-x86_64-linux-gnu/src/pfsglview/./src/pfsglview/m_status.cpp:84: undefined reference to `glutBitmap8By13' /usr/bin/ld: ./obj-x86_64-linux-gnu/src/pfsglview/./src/pfsglview/m_status.cpp:84: undefined reference to `glutBitmapCharacter' /usr/bin/ld: ./obj-x86_64-linux-gnu/src/pfsglview/./src/pfsglview/m_status.cpp:90: undefined reference to `glutBitmap8By13' /usr/bin/ld: ./obj-x86_64-linux-gnu/src/pfsglview/./src/pfsglview/m_status.cpp:90: undefined reference to `glutBitmapCharacter' /usr/bin/ld: ./obj-x86_64-linux-gnu/src/pfsglview/./src/pfsglview/m_status.cpp:97: undefined reference to `glutBitmap8By13' /usr/bin/ld: ./obj-x86_64-linux-gnu/src/pfsglview/./src/pfsglview/m_status.cpp:97: undefined reference to `glutBitmapCharacter' /usr/bin/ld: CMakeFiles/pfsglview.dir/m_on_screen_display.cpp.o: in function `M_OnScreenDisplay::println(std::__cxx11::basic_string, std::allocator >)': ./obj-x86_64-linux-gnu/src/pfsglview/./src/pfsglview/m_on_screen_display.cpp:112: undefined reference to `glutBitmap8By13' /usr/bin/ld: ./obj-x86_64-linux-gnu/src/pfsglview/./src/pfsglview/m_on_screen_display.cpp:115: undefined reference to `glutBitmapCharacter' /usr/bin/ld: warning: creating DT_TEXTREL in a PIE collect2: error: ld returned 1 exit status make[4]: *** [src/pfsglview/CMakeFiles/pfsglview.dir/build.make:184: src/pfsglview/pfsglview] Error 1 Cheers -- Sebastian Ramacher
[Pkg-phototools-devel] Bug#1007984: netpbm-free: uncoordinated transition, consider switching to libnetpbm-dev
Control: severity -1 serious
On 2022-03-19 22:59:08, Sebastian Ramacher wrote:
> Source: netpbm-free
> Version: 2:10.7.00-1
> Severity: important
> X-Debbugs-Cc: sramac...@debian.org, ti...@debian.org
>
> Hi Andreas
>
> the upload of netpbm-free 2:10.97.00-1 started an uncoordinated
> transition from libnetpbm{9,10} to libnetpbm11. But it also requires
> all reverse dependencies to update their build dependencies to
> libnetpbm11-dev. Please consider moving to an unversioned -dev package,
> i.e., libnetpbm-dev to avoid that in the feature.
As there is no progress on this transition, I am raising the severity to
serious. We do not want to release bookworm with a half-done transition.
Cheers
--
Sebastian Ramacher
--
Pkg-phototools-devel mailing list
Pkg-phototools-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-phototools-devel
Re: [Pkg-phototools-devel] Apparently uncoordinated libnetpbm transition.
On 2022-04-03 23:43:39, Peter Green wrote: > A new version of netpbm-free was recently uploaded to unstable which > replaced the libnetpbm9, libnetpbm9-dev, libnetpbm10 and libnetpbm10-dev > packages with libnetpbm11 and libnetpbm11-dev packages. > > I could not find any evidence of an attempt to coordinate this transition > with the release team, nor could I find any evidence of bug reports filed > against the reverse dependencies. Since the dev package has also been > renamed it seems to me that this transition cannot be performed with > binnmus and sourceful uploads of the reverse dependencies will be needed. See also #1007984 Cheers -- Sebastian Ramacher -- Pkg-phototools-devel mailing list Pkg-phototools-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-phototools-devel
[Pkg-phototools-devel] Bug#1007984: netpbm-free: uncoordinated transition, consider switching to libnetpbm-dev
Source: netpbm-free
Version: 2:10.7.00-1
Severity: important
X-Debbugs-Cc: sramac...@debian.org, ti...@debian.org
Hi Andreas
the upload of netpbm-free 2:10.97.00-1 started an uncoordinated
transition from libnetpbm{9,10} to libnetpbm11. But it also requires
all reverse dependencies to update their build dependencies to
libnetpbm11-dev. Please consider moving to an unversioned -dev package,
i.e., libnetpbm-dev to avoid that in the feature.
Cheers
--
Sebastian Ramacher
signature.asc
Description: PGP signature
--
Pkg-phototools-devel mailing list
Pkg-phototools-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-phototools-devel
[Pkg-phototools-devel] Bug#1007234: netpbm-free: FTBFS almost everywhere
Source: netpbm-free Version: 2:10.97.00-1 Severity: serious Tags: ftbfs Justification: fails to build from source (but built successfully in the past) netbpm-free FTBFS almost everywhere: Test summary: == SUCCESS 178 FAILURE 2 NOT TESTABLE 3 TOTAL TESTABLE 180 == All tests done. Sun, 13 Mar 2022 10:42:42 + make[2]: *** [GNUmakefile:549: check-tree] Error 1 See https://buildd.debian.org/status/fetch.php?pkg=netpbm-free=arm64=2%3A10.97.00-1=1647168169=0 Cheers -- Sebastian Ramacher -- Pkg-phototools-devel mailing list Pkg-phototools-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-phototools-devel
Re: [Pkg-phototools-devel] upcoming transition for webp package
On 2021-02-20 07:57:12 -0400, David Bremner wrote: > Jeff Breidenbach writes: > > > Dear Debian colleagues, > > > > I'm writing because you maintain a package with a direct dependency in > > libwebp6. I'm planning to transition it to libweb8. Although I am not > > expecting any compatibility trouble, previous transitions have not always > > gone smoothly. So I'm sending this email as a heads up, and I've also just > > uploaded libweb8 to experimental. Thank you very much. > > > > Jeff > > If you have not already done so, I recommend you discuss this with the > release team ASAP as we are in the transition freeze for bullseye. It's too late for a transition. This will have to wait for bookworm. Cheers > > d > -- Sebastian Ramacher signature.asc Description: PGP signature -- Pkg-phototools-devel mailing list Pkg-phototools-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-phototools-devel
