[Pkg-phototools-devel] Bug#812657: feh and GIF images: imlib2 problem
Hi, Thanks a lot for looking into it! On Tue, Feb 02, 2016 at 04:57:26PM +0200, Peter Pentchev wrote: > At least on my Debian testing machine, there are indeed 100 failures out of > 100 attempts. I can reproduce that on my Debian sid machine, and also confirm that it works fine on Debian jessie (with imlib2 1.4.6, as opposed to 1.4.7 in testing/unstable). I have opened a bug report for libimlib2 and linked to your tarball as a demonstration: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813729 I'd rather not re-assign this one, since feh's build failure is still an issue I need to fix -- Though luckily that's pretty easy, I just need to comment out those tests, add a note under KNOWN BUGS and wait for the Debian / Imlib2 maintainers to fix this issue. --Daniel signature.asc Description: Digital signature ___ Pkg-phototools-devel mailing list Pkg-phototools-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-phototools-devel
[Pkg-phototools-devel] Bug#812657: feh: FTBFS - Can't exec "mandoc"
tags 812657 upstream retitle 812657 feh: FTBFS: test failure when preloading gif images thanks Hi, The missing mandoc binary is not the issue here, the test expects that and silently passes. However, some library difference between stable and unstable causes the gif preload / list test to fail on Debian unstable, while it works fine on Debian stable. So the test failure is caused by an actual bug. I can reproduce the problem on my systems and hope to have a fix ready soon. --Daniel signature.asc Description: Digital signature ___ Pkg-phototools-devel mailing list Pkg-phototools-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-phototools-devel
[Pkg-phototools-devel] Bug#773967: Bug#773967: feh crashes on invalid gif image data
Hi, On Mon, Jan 05, 2015 at 09:22:37AM +0100, Andreas Tille wrote: Hi, thanks for this bug report. Unfortunately I do not fully understand how to reproduce the problem. You generated the affected test images and it would help if you could put them online somehow to simplify the reproduction (or provide a generation script alternatively). I realised that upstream (in CC) released two new versions (hey, Daniel, it would be great if you would ping me on new releases). The changelog does not mention the problems you are specifying here and in your other bug report (#773968) explicitly but may be it makes sense to just upload the latest program version? (Sorry, I completely forgot about that. Will do in the future) I tested it with the latest version of feh and can reproduce the issue. However, the problem is caused by imlib_load_image_with_error_return (or, more specifically, the load function in Imlib2's gif library), which is out of feh's scope. Since the image also causes a segmentation fault in sxiv (another imlib2 based image viewer), I think the bug report should be moved to the Imlib2 package. --Daniel signature.asc Description: Digital signature ___ Pkg-phototools-devel mailing list Pkg-phototools-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-phototools-devel
[Pkg-phototools-devel] Bug#745467: weird Usage: .%V volume ... (#913) messages
Hi, On Tue, Apr 22, 2014 at 07:46:40AM +0800, 積丹尼 Dan Jacobson wrote: $ man feh 21 /dev/null Usage: .%V volume ... (#913) This is a bug in the feh manual, a fix will be included in the next release. Patch: http://git.finalrewind.org/feh/commit/?id=c07a9474ed54fb7eda17b801770cf65acda9ba7f --Daniel signature.asc Description: Digital signature ___ Pkg-phototools-devel mailing list Pkg-phototools-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-phototools-devel
[Pkg-phototools-devel] Bug#478605: Fixed in 2.9.1
feh v2.9.1 fixes this issue. signature.asc Description: Digital signature ___ Pkg-phototools-devel mailing list Pkg-phototools-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-phototools-devel
[Pkg-phototools-devel] Bug#612035: Ping: Bug#612035: Bug#612035: vulnerability: rewrite arbitrary user file
Hi,
On Thu, Jan 19, 2012 at 12:47:06PM +, Jonathan Wiltshire wrote:
On Fri, Jul 08, 2011 at 08:06:17PM +0200, Julien Cristau wrote:
[...]
ick. mkdtemp(3), please.
Any news on this?
the attached patches (created against the unpatched 1.3.4.dfsg.1-1 / 1.8-1
packages) use mkdtemp for the fix.
I removed the --cache 0 wget argument because my system's wget does not support
it anymore, if the wget in oldstable still has it it's safe to put that back in.
--Daniel
diff --git a/src/imlib.c b/src/imlib.c
index fc4dcf0..1d06628 100644
--- a/src/imlib.c
+++ b/src/imlib.c
@@ -263,7 +263,7 @@ feh_http_load_image(char *url)
char *newurl = NULL;
char randnum[20];
int rnum;
- char *path = NULL;
+ static char *path = NULL;
D_ENTER(4);
@@ -274,11 +274,16 @@ feh_http_load_image(char *url)
else
path = ;
}
- else
- path = /tmp/;
+ else {
+ path = estrdup(/tmp/feh_XX);
+ if (mkdtemp(path) == NULL)
+ eprintf(Failed to create temporary directory);
+ path = estrjoin(, path, /, NULL);
+ opt.tmp_path = path;
+ }
basename = strrchr(url, '/') + 1;
- tmpname = feh_unique_filename(path, basename);
+ tmpname = estrjoin(, path, basename, NULL);
if (opt.wget_timestamp)
{
@@ -288,7 +293,7 @@ feh_http_load_image(char *url)
ppid = getpid();
snprintf(cppid, sizeof(cppid), %06ld, (long)ppid);
tmpname_timestamper =
- estrjoin(, /tmp/feh_, cppid, _, basename, NULL);
+ estrjoin(, path, cppid, _, basename, NULL);
}
if (opt.wget_timestamp)
@@ -548,7 +553,7 @@ feh_http_load_image(char *url)
}
else
{
-execlp(wget, wget, --cache, 0, newurl, -O, tmpname,
+execlp(wget, wget, newurl, -O, tmpname,
quiet, (char*) NULL);
}
eprintf(url: exec failed: wget:);
diff --git a/src/main.c b/src/main.c
index 745fdf9..4fbe600 100644
--- a/src/main.c
+++ b/src/main.c
@@ -215,5 +215,8 @@ feh_clean_exit(void)
if (opt.filelistfile)
feh_write_filelist(filelist, opt.filelistfile);
+ if (opt.tmp_path !opt.keep_http)
+ rmdir(opt.tmp_path);
+
D_RETURN_(4);
}
diff --git a/src/options.c b/src/options.c
index d9d803d..7fd46b0 100644
--- a/src/options.c
+++ b/src/options.c
@@ -55,6 +55,7 @@ init_parse_options(int argc, char **argv)
opt.thumb_h = 60;
opt.menu_font = estrdup(DEFAULT_MENU_FONT);
opt.font = estrdup(DEFAULT_FONT);
+ opt.tmp_path = NULL;
opt.menu_bg = estrdup(PREFIX /share/feh/images/menubg_default.png);
opt.menu_style = estrdup(PREFIX /share/feh/fonts/menu.style);
opt.menu_border = 4;
diff --git a/src/options.h b/src/options.h
index 0101885..f365da8 100644
--- a/src/options.h
+++ b/src/options.h
@@ -89,6 +89,8 @@ struct __fehoptions
char *menu_style;
char *caption_path;
+ char *tmp_path;
+
gib_style *menu_style_l;
unsigned char next_button;
diff --git a/src/imlib.c b/src/imlib.c
index 69c6e50..ea88754 100644
--- a/src/imlib.c
+++ b/src/imlib.c
@@ -232,15 +232,20 @@ char *feh_http_load_image(char *url)
{
char *tmpname;
char *basename;
- char *path = NULL;
+ static char *path = NULL;
if (opt.keep_http) {
if (opt.output_dir)
path = opt.output_dir;
else
path = ;
- } else
- path = /tmp/;
+ } else {
+ path = estrdup(/tmp/feh_XX);
+ if (mkdtemp(path) == NULL)
+ eprintf(Failed to create temporary directory:);
+ path = estrjoin(NULL, path, /, NULL);
+ opt.tmp_path = path;
+ }
basename = strrchr(url, '/') + 1;
tmpname = feh_unique_filename(path, basename);
diff --git a/src/main.c b/src/main.c
index ce46879..9588863 100644
--- a/src/main.c
+++ b/src/main.c
@@ -190,5 +190,8 @@ void feh_clean_exit(void)
if (opt.filelistfile)
feh_write_filelist(filelist, opt.filelistfile);
+ if (opt.tmp_path !opt.keep_http)
+ rmdir(opt.tmp_path);
+
return;
}
diff --git a/src/options.c b/src/options.c
index 5962ca1..5f928ed 100644
--- a/src/options.c
+++ b/src/options.c
@@ -56,6 +56,7 @@ void init_parse_options(int argc, char **argv)
opt.thumb_redraw = 10;
opt.menu_font = estrdup(DEFAULT_MENU_FONT);
opt.font = NULL;
+ opt.tmp_path = NULL;
opt.image_bg = estrdup(default);
opt.menu_bg = estrdup(PREFIX /share/feh/images/menubg_default.png);
opt.menu_style = estrdup(PREFIX /share/feh/fonts/menu.style);
diff --git a/src/options.h b/src/options.h
index be20687..2cb174e 100644
--- a/src/options.h
+++ b/src/options.h
@@ -88,6 +88,8 @@ struct __fehoptions {
char *caption_path;
char *start_list_at;
+ char *tmp_path;
+
gib_style *menu_style_l;
unsigned char pan_button;
signature.asc
Description: Digital signature
___
Pkg-phototools-devel mailing list
Pkg-phototools-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-phototools-devel
[Pkg-phototools-devel] Bug#657173: URL returned error: 404... but say what the error was
Hi, On Wed, Jan 25, 2012 at 12:27:37AM +0800, jida...@jidanni.org wrote: Why don't you tell the user what the error message was?! Because libcurl does not easily tell me, either. I could write a custom header function to parse the non-number part out of the status message, but I don't see why it's worth the effort. Some 404s are different than others! Only in very special cases. HTTP 404 means file not found. As far as I know, HTTP Clients are not even required to read the non-number part of that status line... at least most I know don't care about it. I see that WWWOffle is an exception to this, but wouldn't it be easier to make it return a different status code for I am offline and don't know if this file exists or not? 404 for unkown content seems somewhat ambiguous to me. I may reconsider this later, but for now I won't add more precise status reports to feh/curl. feh is not a web browser, the http support is more of a convenience so you don't have to call wget feh. signature.asc Description: Digital signature ___ Pkg-phototools-devel mailing list Pkg-phototools-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-phototools-devel
[Pkg-phototools-devel] Bug#657172: digs through dots if no file is specified
On Wed, Jan 25, 2012 at 12:31:09AM +0800, jida...@jidanni.org wrote: $ feh feh WARNING: ./.Xauthority - No Imlib2 loader for that file format feh WARNING: ./.Xresources - No Imlib2 loader for that file format feh WARNING: ./.basex - No Imlib2 loader for that file format feh WARNING: ./.basexgui - No Imlib2 loader for that file format feh WARNING: ./.bash_history - No Imlib2 loader for that file format feh WARNING: ./.bash_history_jidanni - No Imlib2 loader for that file format feh WARNING: ./.bash_history_jidanni-emacs - No Imlib2 loader for that file format feh WARNING: ./.bash_profile - No Imlib2 loader for that file format feh WARNING: ./.bashrc - No Imlib2 loader for that file format feh WARNING: ./.bbdb - No Imlib2 loader for that file format feh WARNING: ./.cliverc - No Imlib2 loader for that file format feh WARNING: ./wwwoffle.conf.php - No Imlib2 loader for that file format feh - No loadable images specified. Use feh --help for detailed usage information Gosh, it is somehow looking at my dot files. It should just say: feh - No loadable images specified. Use feh --help for detailed usage information Feh trying to load the current directory (including dotfiles) when no file or directory argument is specified is actually intended behaviour, I just forgot to document it. But yeah, it's pretty verbose this way. Perhaps I should enable the --quiet option (which hides such errors) by default. signature.asc Description: Digital signature ___ Pkg-phototools-devel mailing list Pkg-phototools-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-phototools-devel
[Pkg-phototools-devel] Bug#654569: data: images
On Wed, Jan 04, 2012 at 07:37:33PM +0800, jida...@jidanni.org wrote: What about the 'data:' images mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=632119 It would be simple to make feh deal properly with $ feh 'data:image/png;base64,iVBORw0KGgoNS...' or maybe $ echo 'data:image/png;base64,iVBORw0K...'|feh -- Hmm. Using feh to display images in a (text-only?) browser is the only usecase for this I can think of, and I'm not sure if that makes sense. What do you need this feature for? signature.asc Description: Digital signature ___ Pkg-phototools-devel mailing list Pkg-phototools-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-phototools-devel
[Pkg-phototools-devel] Bug#653689: No Imlib2 loader for that file format
Hi, On Fri, Dec 30, 2011 at 06:49:46PM +0800, jida...@jidanni.org wrote: Package: feh Version: 2.1-1 What's the matter here? $ feh http://graph.facebook.com/jidanni/picture feh WARNING: /tmp/feh_005386_01_picture_i2oriT - No Imlib2 loader for that file format feh WARNING: couldn't load /tmp/feh_005386_01_picture_i2oriT feh WARNING: /tmp/feh_005386_01_picture_i2oriT - No Imlib2 loader for that file format feh - No loadable images specified. Use feh --help for detailed usage information The URL redirects to an actual image, and the feh code did not tell curl to follow such redirects. It's fixed in git, a new release including this will follow shortly. --Daniel signature.asc Description: Digital signature ___ Pkg-phototools-devel mailing list Pkg-phototools-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-phototools-devel
[Pkg-phototools-devel] Bug#646421: deal with today's longer image URLs
Hi, This has been fixed in git commit 021d0f975df35c52643bb6abca1c8a8459af1326, a release including this fix will follow in a few days. Thanks for pointing it out, Daniel signature.asc Description: Digital signature ___ Pkg-phototools-devel mailing list Pkg-phototools-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-phototools-devel
[Pkg-phototools-devel] Bug#570903: images march right off the screen
tags: 570903 +upstream forwarded: 570903 http://github.com/derf/feh/issues/22 thanks There is some new evidence that this might be feh's fault after all, see https://github.com/derf/feh/issues/22. I'll hopefully find out more next week. --Daniel signature.asc Description: Digital signature ___ Pkg-phototools-devel mailing list Pkg-phototools-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-phototools-devel
[Pkg-phototools-devel] Bug#619828: Caused by Imlib2
Hi,
feh uses Imlib2 to load/save the various image formats. I have verified that
this bug is caused by Imlib2, not feh, so please report it to the Imlib2 devs.
perl -MImage::Imlib2 'EOF'
my $im = Image::Imlib2-load('foo.pbm');
$im-image_set_format('png');
$im-save('foo.png');
EOF
You'll see that foo.png shows the same broken rendering that you were
reporting for feh, even when viewing it with programs not using Imlib2.
Anyways, thanks for reporting the bug,
Daniel
signature.asc
Description: Digital signature
___
Pkg-phototools-devel mailing list
Pkg-phototools-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-phototools-devel
