[Pkg-sysvinit-devel] Bug#738775: insserv: Insserv 1.16 tries to connect to systemd even though system is running on sysv-init

2014-02-13 Thread Petter Reinholdtsen
I've tried to reproduce this part of your problem report:

 * What was the outcome of this action?
 Cannot install initscripts after installing insserv 1.16 because it
 tries to connect to systemd which is present on the system but not
 used as PID 1.

I have no problem installing initscripts or any other package, even if
insserv spew out lots of error messages.  So the problem you reported
seem to be non-fatal and irrelevant for any installation problem.  Can
you tell me more about how the installation of initscripts fail?

The svn version of insserv reduces the amount of messages, but are
still printing warnings.  The behaviour do not change, as far as I can
tell.

-- 
Happy hacking
Petter Reinholdtsen

___
Pkg-sysvinit-devel mailing list
Pkg-sysvinit-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-sysvinit-devel


[Pkg-sysvinit-devel] Processing of sysvinit_2.88dsf-51_amd64.changes

2014-02-13 Thread Debian FTP Masters
sysvinit_2.88dsf-51_amd64.changes uploaded successfully to localhost
along with the files:
  sysvinit_2.88dsf-51.dsc
  sysvinit_2.88dsf-51.debian.tar.xz
  sysvinit_2.88dsf-51_amd64.deb
  sysvinit-core_2.88dsf-51_amd64.deb
  sysvinit-utils_2.88dsf-51_amd64.deb
  sysv-rc_2.88dsf-51_all.deb
  initscripts_2.88dsf-51_amd64.deb
  bootlogd_2.88dsf-51_amd64.deb

Greetings,

Your Debian queue daemon (running on host franck.debian.org)

___
Pkg-sysvinit-devel mailing list
Pkg-sysvinit-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-sysvinit-devel


[Pkg-sysvinit-devel] sysvinit_2.88dsf-51_amd64.changes ACCEPTED into unstable

2014-02-13 Thread Debian FTP Masters


Accepted:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Format: 1.8
Date: Thu, 13 Feb 2014 11:51:12 +0100
Source: sysvinit
Binary: sysvinit sysvinit-core sysvinit-utils sysv-rc initscripts bootlogd
Architecture: source amd64 all
Version: 2.88dsf-51
Distribution: unstable
Urgency: low
Maintainer: Debian sysvinit maintainers 
pkg-sysvinit-devel@lists.alioth.debian.org
Changed-By: Petter Reinholdtsen p...@debian.org
Description: 
 bootlogd   - daemon to log boot messages
 initscripts - scripts for initializing and shutting down the system
 sysv-rc- System-V-like runlevel change mechanism
 sysvinit   - System-V-like init utilities
 sysvinit-core - System-V-like init utilities
 sysvinit-utils - System-V-like utilities
Closes: 686701 703833
Changes: 
 sysvinit (2.88dsf-51) unstable; urgency=low
 .
   * Corrected tmpfs(5) manual page to correctly state when /tmp is not
 mounted as tmpfs (Closes: #703833).  Patch from Charles Plessy.
   * Add SEE ALSO fsck(8) to rcS(5) manual page (Closes: #686701).
 Patch from Regid Ichira.
Checksums-Sha1: 
 4080ffb33ea4d8fe980ad0c8412cb528b278d7c4 1777 sysvinit_2.88dsf-51.dsc
 085760b24e2768271c2fdd5602e931783942b0fb 171816 
sysvinit_2.88dsf-51.debian.tar.xz
 de6ab0e7503ba38186afc3565545f338be7aa0af 81808 sysvinit_2.88dsf-51_amd64.deb
 d827f4dc4b39feeb051a16935e530fd78be21c48 129060 
sysvinit-core_2.88dsf-51_amd64.deb
 e306dec3eb62dcb697ea456d58fe7a0312e71148 98350 
sysvinit-utils_2.88dsf-51_amd64.deb
 7ee2887d49e827435094256936b0a744feae0622 80538 sysv-rc_2.88dsf-51_all.deb
 943c8c93fa6a1876cb732e86b27805fbbbc8a391 84716 initscripts_2.88dsf-51_amd64.deb
 3101b2ef54197c0daafddb822365fa65d82769f6 56984 bootlogd_2.88dsf-51_amd64.deb
Checksums-Sha256: 
 cde0ad1a83492ab70fe0066b00f9503af077f34b98d774a85e7d868b47d1253e 1777 
sysvinit_2.88dsf-51.dsc
 909ce5bc11209f58330b5d996fd72fc15d7ade3866cca3473d590d0df6e3ce54 171816 
sysvinit_2.88dsf-51.debian.tar.xz
 85bcec8a67849a61890bc75317dbcea348af96da7c581ccf49d4462b3f6b74fa 81808 
sysvinit_2.88dsf-51_amd64.deb
 ad7bbef54a580c250d5b557f72b1ff74fdfa4d54842429f7cb8a9b18306c5015 129060 
sysvinit-core_2.88dsf-51_amd64.deb
 0fec309179a61210d9980a3eaa8a4970c1d329a20ab10bd70617798930542860 98350 
sysvinit-utils_2.88dsf-51_amd64.deb
 2e664ca7e94df76df40a3faa05c82918ddc498b7d0822d63c7532d9c1b5526c0 80538 
sysv-rc_2.88dsf-51_all.deb
 e3ef503586ee6ea370f163d91c9e651041a54bdf85e2916c119df804eb77e9a0 84716 
initscripts_2.88dsf-51_amd64.deb
 bc63ff7568837990b48948ff7ceb851af5fb876c11a06aa69661ace15cb9afb5 56984 
bootlogd_2.88dsf-51_amd64.deb
Files: 
 ca0ff0b545f480265b20faabbb32e936 1777 admin required sysvinit_2.88dsf-51.dsc
 37f71fc568f9c35343f2ecf8bb6c1d71 171816 admin required 
sysvinit_2.88dsf-51.debian.tar.xz
 12bdedb7a6ece8a058dc516239ec2ac2 81808 admin required 
sysvinit_2.88dsf-51_amd64.deb
 8ff47b26d6f195f8d6346226b35ddcc7 129060 admin required 
sysvinit-core_2.88dsf-51_amd64.deb
 0c21c558eb4c1e27fc975a58a4ff3b3b 98350 admin required 
sysvinit-utils_2.88dsf-51_amd64.deb
 af7f26ad9b8bbfacb82589f5c2f07bef 80538 admin required 
sysv-rc_2.88dsf-51_all.deb
 300ff81d9875fbaa5898b24fab6d38fb 84716 admin required 
initscripts_2.88dsf-51_amd64.deb
 63c3916605b27ef65af9ebf2036ae87e 56984 admin optional 
bootlogd_2.88dsf-51_amd64.deb

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)

iD8DBQFS/KSp20zMSyow1ykRAn/yAJ9B2hnJcKACSXwY0/nNIUq2hLWRDACg5an2
12Vq3OGdJjPIKLkTEFbk3GE=
=gUei
-END PGP SIGNATURE-


Thank you for your contribution to Debian.

___
Pkg-sysvinit-devel mailing list
Pkg-sysvinit-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-sysvinit-devel


[Pkg-sysvinit-devel] Bug#686701: marked as done (/usr/share/man/man5/rcS.5: add fsck.5 to the the list in SEE ALSO)

2014-02-13 Thread Debian Bug Tracking System
Your message dated Thu, 13 Feb 2014 11:05:01 +
with message-id e1wdu6h-0002vx...@franck.debian.org
and subject line Bug#686701: fixed in sysvinit 2.88dsf-51
has caused the Debian Bug report #686701,
regarding /usr/share/man/man5/rcS.5: add fsck.5 to the the list in SEE ALSO
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
686701: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=686701
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
---BeginMessage---

Package:  initscripts
Version:  2.88dsf-31
Severity: minor
Tags: patch
File: /usr/share/man/man5/rcS.5

  Rational: for more details about FSCK.

--- a/rcS.5 2012-09-04 23:26:41.077717991 +0300
+++ b/rcS.5 2012-09-04 23:18:06.0 +0300
@@ -103,6 +103,7 @@ Miquel van Smoorenburg miquels@cistron.
 Roger Leigh rle...@debian.org
 
 .SH SEE ALSO
+.BR fsck (8),
 .BR hwclock (5),
 .BR hwclock (8),
 .BR inetd (8),
---End Message---
---BeginMessage---
Source: sysvinit
Source-Version: 2.88dsf-51

We believe that the bug you reported is fixed in the latest version of
sysvinit, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 686...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen p...@debian.org (supplier of updated sysvinit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Format: 1.8
Date: Thu, 13 Feb 2014 11:51:12 +0100
Source: sysvinit
Binary: sysvinit sysvinit-core sysvinit-utils sysv-rc initscripts bootlogd
Architecture: source amd64 all
Version: 2.88dsf-51
Distribution: unstable
Urgency: low
Maintainer: Debian sysvinit maintainers 
pkg-sysvinit-devel@lists.alioth.debian.org
Changed-By: Petter Reinholdtsen p...@debian.org
Description: 
 bootlogd   - daemon to log boot messages
 initscripts - scripts for initializing and shutting down the system
 sysv-rc- System-V-like runlevel change mechanism
 sysvinit   - System-V-like init utilities
 sysvinit-core - System-V-like init utilities
 sysvinit-utils - System-V-like utilities
Closes: 686701 703833
Changes: 
 sysvinit (2.88dsf-51) unstable; urgency=low
 .
   * Corrected tmpfs(5) manual page to correctly state when /tmp is not
 mounted as tmpfs (Closes: #703833).  Patch from Charles Plessy.
   * Add SEE ALSO fsck(8) to rcS(5) manual page (Closes: #686701).
 Patch from Regid Ichira.
Checksums-Sha1: 
 4080ffb33ea4d8fe980ad0c8412cb528b278d7c4 1777 sysvinit_2.88dsf-51.dsc
 085760b24e2768271c2fdd5602e931783942b0fb 171816 
sysvinit_2.88dsf-51.debian.tar.xz
 de6ab0e7503ba38186afc3565545f338be7aa0af 81808 sysvinit_2.88dsf-51_amd64.deb
 d827f4dc4b39feeb051a16935e530fd78be21c48 129060 
sysvinit-core_2.88dsf-51_amd64.deb
 e306dec3eb62dcb697ea456d58fe7a0312e71148 98350 
sysvinit-utils_2.88dsf-51_amd64.deb
 7ee2887d49e827435094256936b0a744feae0622 80538 sysv-rc_2.88dsf-51_all.deb
 943c8c93fa6a1876cb732e86b27805fbbbc8a391 84716 initscripts_2.88dsf-51_amd64.deb
 3101b2ef54197c0daafddb822365fa65d82769f6 56984 bootlogd_2.88dsf-51_amd64.deb
Checksums-Sha256: 
 cde0ad1a83492ab70fe0066b00f9503af077f34b98d774a85e7d868b47d1253e 1777 
sysvinit_2.88dsf-51.dsc
 909ce5bc11209f58330b5d996fd72fc15d7ade3866cca3473d590d0df6e3ce54 171816 
sysvinit_2.88dsf-51.debian.tar.xz
 85bcec8a67849a61890bc75317dbcea348af96da7c581ccf49d4462b3f6b74fa 81808 
sysvinit_2.88dsf-51_amd64.deb
 ad7bbef54a580c250d5b557f72b1ff74fdfa4d54842429f7cb8a9b18306c5015 129060 
sysvinit-core_2.88dsf-51_amd64.deb
 0fec309179a61210d9980a3eaa8a4970c1d329a20ab10bd70617798930542860 98350 
sysvinit-utils_2.88dsf-51_amd64.deb
 2e664ca7e94df76df40a3faa05c82918ddc498b7d0822d63c7532d9c1b5526c0 80538 
sysv-rc_2.88dsf-51_all.deb
 e3ef503586ee6ea370f163d91c9e651041a54bdf85e2916c119df804eb77e9a0 84716 
initscripts_2.88dsf-51_amd64.deb
 bc63ff7568837990b48948ff7ceb851af5fb876c11a06aa69661ace15cb9afb5 56984 
bootlogd_2.88dsf-51_amd64.deb
Files: 
 ca0ff0b545f480265b20faabbb32e936 1777 admin required sysvinit_2.88dsf-51.dsc
 37f71fc568f9c35343f2ecf8bb6c1d71 171816 admin required 
sysvinit_2.88dsf-51.debian.tar.xz
 12bdedb7a6ece8a058dc516239ec2ac2 81808 admin required 
sysvinit_2.88dsf-51_amd64.deb
 8ff47b26d6f195f8d6346226b35ddcc7 129060 admin required 

[Pkg-sysvinit-devel] Bug#703833: marked as done (tmpfs.5: /tmp is not mounted as tmpfs by default in this)

2014-02-13 Thread Debian Bug Tracking System
Your message dated Thu, 13 Feb 2014 11:05:01 +
with message-id e1wdu6h-0002vd...@franck.debian.org
and subject line Bug#703833: fixed in sysvinit 2.88dsf-51
has caused the Debian Bug report #703833,
regarding tmpfs.5: /tmp is not mounted as tmpfs by default in this
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
703833: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703833
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
---BeginMessage---
Package: initscripts
Version: 2.88dsf-41
Severity: minor
Tags: patch

Dear initscripts,

I found a minor inconsistency in tmpfs.5; here is a patch to correct it.

Have a nice week-end,

-- 
Charles Plessy
Tsurumi, Kanagawa, Japan
From 1876231f9153eb0a2b803d2e4df60d88bf1f6c62 Mon Sep 17 00:00:00 2001
From: Charles Plessy ple...@debian.org
Date: Sun, 24 Mar 2013 22:31:32 +0900
Subject: [PATCH] tmpfs.5: /tmp is not mounted as tmpfs by default in this
 version.

---
 debian/src/initscripts/man/tmpfs.5 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/src/initscripts/man/tmpfs.5 b/debian/src/initscripts/man/tmpfs.5
index 44ab73f..3cc610c 100644
--- a/debian/src/initscripts/man/tmpfs.5
+++ b/debian/src/initscripts/man/tmpfs.5
@@ -17,7 +17,7 @@ currently includes the filesystems /run, /run/lock, /run/shm and /tmp.
 /run is required to be a tmpfs on systems supporting tmpfs mounts.
 /run/lock and /run/shm may be separate tmpfs mounts, useful for
 enforcing separate size limits.  /tmp is not required to be a tmpfs,
-but is mounted as a tmpfs by default.
+and is not mounted as a tmpfs by default.
 .PP
 
 .IP /run
-- 
1.8.2.rc0

---End Message---
---BeginMessage---
Source: sysvinit
Source-Version: 2.88dsf-51

We believe that the bug you reported is fixed in the latest version of
sysvinit, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 703...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen p...@debian.org (supplier of updated sysvinit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Format: 1.8
Date: Thu, 13 Feb 2014 11:51:12 +0100
Source: sysvinit
Binary: sysvinit sysvinit-core sysvinit-utils sysv-rc initscripts bootlogd
Architecture: source amd64 all
Version: 2.88dsf-51
Distribution: unstable
Urgency: low
Maintainer: Debian sysvinit maintainers 
pkg-sysvinit-devel@lists.alioth.debian.org
Changed-By: Petter Reinholdtsen p...@debian.org
Description: 
 bootlogd   - daemon to log boot messages
 initscripts - scripts for initializing and shutting down the system
 sysv-rc- System-V-like runlevel change mechanism
 sysvinit   - System-V-like init utilities
 sysvinit-core - System-V-like init utilities
 sysvinit-utils - System-V-like utilities
Closes: 686701 703833
Changes: 
 sysvinit (2.88dsf-51) unstable; urgency=low
 .
   * Corrected tmpfs(5) manual page to correctly state when /tmp is not
 mounted as tmpfs (Closes: #703833).  Patch from Charles Plessy.
   * Add SEE ALSO fsck(8) to rcS(5) manual page (Closes: #686701).
 Patch from Regid Ichira.
Checksums-Sha1: 
 4080ffb33ea4d8fe980ad0c8412cb528b278d7c4 1777 sysvinit_2.88dsf-51.dsc
 085760b24e2768271c2fdd5602e931783942b0fb 171816 
sysvinit_2.88dsf-51.debian.tar.xz
 de6ab0e7503ba38186afc3565545f338be7aa0af 81808 sysvinit_2.88dsf-51_amd64.deb
 d827f4dc4b39feeb051a16935e530fd78be21c48 129060 
sysvinit-core_2.88dsf-51_amd64.deb
 e306dec3eb62dcb697ea456d58fe7a0312e71148 98350 
sysvinit-utils_2.88dsf-51_amd64.deb
 7ee2887d49e827435094256936b0a744feae0622 80538 sysv-rc_2.88dsf-51_all.deb
 943c8c93fa6a1876cb732e86b27805fbbbc8a391 84716 initscripts_2.88dsf-51_amd64.deb
 3101b2ef54197c0daafddb822365fa65d82769f6 56984 bootlogd_2.88dsf-51_amd64.deb
Checksums-Sha256: 
 cde0ad1a83492ab70fe0066b00f9503af077f34b98d774a85e7d868b47d1253e 1777 
sysvinit_2.88dsf-51.dsc
 909ce5bc11209f58330b5d996fd72fc15d7ade3866cca3473d590d0df6e3ce54 171816 
sysvinit_2.88dsf-51.debian.tar.xz
 85bcec8a67849a61890bc75317dbcea348af96da7c581ccf49d4462b3f6b74fa 81808 
sysvinit_2.88dsf-51_amd64.deb
 ad7bbef54a580c250d5b557f72b1ff74fdfa4d54842429f7cb8a9b18306c5015 129060 
sysvinit-core_2.88dsf-51_amd64.deb
 

[Pkg-sysvinit-devel] Bug#738855: initscripts: Skip killing process starting with @

2014-02-13 Thread Dmitrijs Ledkovs
Package: initscripts
Version: 2.88dsf-41
Severity: normal
Tags: patch

Dear Maintainer,

There is convention starting that processes whos name starts with '@'
shouldn't be killed. It is used to indicate that process is needed to
manage root device / cleanly unmount the root filesystem.

At least mdadm supports it for it's 'mdmon' process which is daemon
needed to manage containers (aka fakeraid controllers - Intel Matrix
Raid and DDF).

I've implemented a patch using pgrep, thus it's optional code in
sendsigs if pgrep is not available.

Regards,

Dimitri.

From 79c394b5430104e208a8dffb2903d6bcc0ff2559 Mon Sep 17 00:00:00 2001
From: Dimitri John Ledkov x...@ubuntu.com
Date: Thu, 13 Feb 2014 13:53:36 +
Subject: [PATCH] In sendsigs, skip killing process who's name starts with '@'.

---
 debian/changelog   |  4 
 debian/src/initscripts/etc/init.d/sendsigs | 13 +
 2 files changed, 17 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index ac3f0a0..501c6e6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,12 @@
 sysvinit (2.88dsf-52) UNRELEASED; urgency=low
 
+  [ Petter Reinholdtsen ]
   * Replace debian/watch with file available from
 http://qa.debian.org/cgi-bin/watchfile.cgi?package=sysvinit .
 
+  [ Dimitri John Ledkov ]
+  * In sendsigs, skip killing process who's name starts with '@'.
+
  -- Petter Reinholdtsen p...@debian.org  Thu, 13 Feb 2014 13:23:35 +0100
 
 sysvinit (2.88dsf-51) unstable; urgency=low
diff --git a/debian/src/initscripts/etc/init.d/sendsigs b/debian/src/initscripts/etc/init.d/sendsigs
index 04bd03c..2563314 100755
--- a/debian/src/initscripts/etc/init.d/sendsigs
+++ b/debian/src/initscripts/etc/init.d/sendsigs
@@ -58,6 +58,19 @@ do_stop () {
 		done
 	fi
 
+	# A convention is starting that process whos name starts with
+	# '@' shouldn't be killed by systeminit, as typically those
+	# processes are started to manage the root filesystem. Skip
+	# killing those as well.
+	#
+	# TODO: don't use pgrep...
+	#
+	if [ -x /usr/bin/pgrep ]; then
+	for pid in $(pgrep -f '^@'); do
+		OMITPIDS=${OMITPIDS:+$OMITPIDS }-o $pid
+	done
+	fi
+
 	# Flush the kernel I/O buffer before we start to kill
 	# processes, to make sure the IO of already stopped services to
 	# not slow down the remaining processes to a point where they
-- 
1.9.rc1

___
Pkg-sysvinit-devel mailing list
Pkg-sysvinit-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-sysvinit-devel

[Pkg-sysvinit-devel] Bug#738855: initscripts: Skip killing process starting with @

2014-02-13 Thread Helmut Grohne
Hi Dimitri,

On Thu, Feb 13, 2014 at 01:58:23PM +, Dmitrijs Ledkovs wrote:
 There is convention starting that processes whos name starts with '@'
 shouldn't be killed. It is used to indicate that process is needed to
 manage root device / cleanly unmount the root filesystem.
 
 At least mdadm supports it for it's 'mdmon' process which is daemon
 needed to manage containers (aka fakeraid controllers - Intel Matrix
 Raid and DDF).
 
 I've implemented a patch using pgrep, thus it's optional code in
 sendsigs if pgrep is not available.

Are you sure that the described behaviour is desirable at all?

I argue that evading sendsigs should be a privileged operation. If it
isn't, I can simply rename my process to start with an '@' and block
umounting filesystems possibly causing data loss (due to failing
umount). I am not sure that the drafted scenario can actually happen in
practise, but from a first glance it seems to be the case. Thus applying
your patch would open up the possibility for data loss.

Do you concur with this reasoning?

 Yes - Please close this bug.
 No - Please explain in what way my argument is flawed.

Maybe mdmon should use the existing mechanism and write its PID to
/run/sendsigs.omit.d/mdmon instead?

Thanks

Helmut

___
Pkg-sysvinit-devel mailing list
Pkg-sysvinit-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-sysvinit-devel


[Pkg-sysvinit-devel] Bug#738855: initscripts: Skip killing process starting with @

2014-02-13 Thread Dimitri John Ledkov
On 13 February 2014 15:05, Helmut Grohne hel...@subdivi.de wrote:
 Hi Dimitri,

 On Thu, Feb 13, 2014 at 01:58:23PM +, Dmitrijs Ledkovs wrote:
 There is convention starting that processes whos name starts with '@'
 shouldn't be killed. It is used to indicate that process is needed to
 manage root device / cleanly unmount the root filesystem.

 At least mdadm supports it for it's 'mdmon' process which is daemon
 needed to manage containers (aka fakeraid controllers - Intel Matrix
 Raid and DDF).

 I've implemented a patch using pgrep, thus it's optional code in
 sendsigs if pgrep is not available.

 Are you sure that the described behaviour is desirable at all?

 I argue that evading sendsigs should be a privileged operation. If it
 isn't, I can simply rename my process to start with an '@' and block
 umounting filesystems possibly causing data loss (due to failing
 umount). I am not sure that the drafted scenario can actually happen in
 practise, but from a first glance it seems to be the case. Thus applying
 your patch would open up the possibility for data loss.

 Do you concur with this reasoning?

  Yes - Please close this bug.
  No - Please explain in what way my argument is flawed.


Yes, but no don't close this bug-report.

How about limiting it to processes running as root?

E.g. pgrep -u root -f ^@ ?

That way there is no loop-hole opened, since those processes could
have written to /run/sendsigs.omit.d/ already.

 Maybe mdmon should use the existing mechanism and write its PID to
 /run/sendsigs.omit.d/mdmon instead?


This is what is currently done in mdadm/stop init script.

Writing out a pidfile (and or otherwise copying them around is ok) but
it is debian [derivative] specific as far as I can tell.
Where is @ convention is supported by a larger amount of
distributions and other initsystems (e.g. systemd).
( http://www.freedesktop.org/wiki/Software/systemd/RootStorageDaemons/ )
Writing out a pid-file should be avoided, especially since that is
optional across all init systems and un-desirable for newer ones.
Also, processes could be started off-root (e.g. initramfs) and/or
otherwise not hold-up unmounting root.
Thus I find @ convention useful and lightweight self-identification.

-- 
Regards,

Dimitri.

___
Pkg-sysvinit-devel mailing list
Pkg-sysvinit-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-sysvinit-devel


[Pkg-sysvinit-devel] Processed: Bug#738855: initscripts: Skip killing root-owned process starting with @

2014-02-13 Thread Debian Bug Tracking System
Processing control commands:

 retitle -1 initscripts: Skip killing root-owned process starting with @
Bug #738855 [initscripts] initscripts: Skip killing process starting with @
Changed Bug title to 'initscripts: Skip killing root-owned process starting 
with @' from 'initscripts: Skip killing process starting with @'

-- 
738855: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=738855
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

___
Pkg-sysvinit-devel mailing list
Pkg-sysvinit-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-sysvinit-devel


[Pkg-sysvinit-devel] Bug#738855: initscripts: Skip killing root-owned process starting with @

2014-02-13 Thread Helmut Grohne
Control: retitle -1 initscripts: Skip killing root-owned process starting with @

On Thu, Feb 13, 2014 at 08:58:33PM +, Dimitri John Ledkov wrote:
 How about limiting it to processes running as root?
 
 E.g. pgrep -u root -f ^@ ?
 
 That way there is no loop-hole opened, since those processes could
 have written to /run/sendsigs.omit.d/ already.

I concur with this remedy. Can you update your patch or remove the patch
tag?

 Writing out a pidfile (and or otherwise copying them around is ok) but
 it is debian [derivative] specific as far as I can tell.
 Where is @ convention is supported by a larger amount of
 distributions and other initsystems (e.g. systemd).
 ( http://www.freedesktop.org/wiki/Software/systemd/RootStorageDaemons/ )
 Writing out a pid-file should be avoided, especially since that is
 optional across all init systems and un-desirable for newer ones.
 Also, processes could be started off-root (e.g. initramfs) and/or
 otherwise not hold-up unmounting root.
 Thus I find @ convention useful and lightweight self-identification.

Thanks for pointing out the rationale and documentation. Did you notice
that the referenced documentation explicitly restricts the technique to
root-owned processes?

Thanks for not introducing a security issue. :)

Helmut

___
Pkg-sysvinit-devel mailing list
Pkg-sysvinit-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-sysvinit-devel


[Pkg-sysvinit-devel] Bug#696534: this bug still exists ...

2014-02-13 Thread Ingo Wichmann

I managed to get my machine to boot again by adding init=/bin/bash as
kernel parameter, and then
mount -o remount,rw /
chmod -x /etc/init.d/bootlogd


What I don't understand is:

root@(none):/# /etc/rcS.d/S03mountdevsubfs.sh start
root@(none):/# /etc/rcS.d/S04bootlogd start
root@(none):/# /etc/rcS.d/S05keymap.sh start
▒
 ^[[24;2R

I could start bootlogd manually without problems. The bootprocess hang on
S05keymap.sh start

But removing bootlogd fixed it anyway.

Ingo

-- 
Linuxhotel GmbH, Geschäftsführer Dipl.-Ing. Ingo Wichmann
HRB 20463 Amtsgericht Essen, UStID DE 814 943 641
Antonienallee 1, 45279 Essen, Tel.: 0201 8536-600, http://www.linuxhotel.de

___
Pkg-sysvinit-devel mailing list
Pkg-sysvinit-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-sysvinit-devel

[Pkg-sysvinit-devel] Bug#738855: initscripts: Skip killing root-owned process starting with @

2014-02-13 Thread Dimitri John Ledkov
Control: tags -1 pending

On 13 February 2014 21:18, Helmut Grohne hel...@subdivi.de wrote:
 Control: retitle -1 initscripts: Skip killing root-owned process starting 
 with @

 On Thu, Feb 13, 2014 at 08:58:33PM +, Dimitri John Ledkov wrote:
 How about limiting it to processes running as root?

 E.g. pgrep -u root -f ^@ ?

 That way there is no loop-hole opened, since those processes could
 have written to /run/sendsigs.omit.d/ already.

 I concur with this remedy. Can you update your patch or remove the patch
 tag?


Updated patch, pushed to master. Tagging pending.

 Writing out a pidfile (and or otherwise copying them around is ok) but
 it is debian [derivative] specific as far as I can tell.
 Where is @ convention is supported by a larger amount of
 distributions and other initsystems (e.g. systemd).
 ( http://www.freedesktop.org/wiki/Software/systemd/RootStorageDaemons/ )
 Writing out a pid-file should be avoided, especially since that is
 optional across all init systems and un-desirable for newer ones.
 Also, processes could be started off-root (e.g. initramfs) and/or
 otherwise not hold-up unmounting root.
 Thus I find @ convention useful and lightweight self-identification.

 Thanks for pointing out the rationale and documentation. Did you notice
 that the referenced documentation explicitly restricts the technique to
 root-owned processes?


Yes, yes, yes I did *cough* =)

 Thanks for not introducing a security issue. :)


Thanks a lot for the review!

-- 
Regards,

Dimitri.

___
Pkg-sysvinit-devel mailing list
Pkg-sysvinit-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-sysvinit-devel


[Pkg-sysvinit-devel] Bug#738759: fix for the bug

2014-02-13 Thread Gerfried Fuchs
tags 738759 + patch
thanks

  Hi!

 Please find attach a proposed patch for the issue.  I hope we can get
around at work to test it properly within the next few days, but from
what I can tell this should be a good approach.

 Enjoy,
Rhonda
-- 
Fühlst du dich mutlos, fass endlich Mut, los  |
Fühlst du dich hilflos, geh raus und hilf, los| Wir sind Helden
Fühlst du dich machtlos, geh raus und mach, los   | 23.55: Alles auf Anfang
Fühlst du dich haltlos, such Halt und lass los|
From e211b7ba4fdce03d66b9edc097349c4d17d94063 Mon Sep 17 00:00:00 2001
From: Gerfried Fuchs rho...@debian.org
Date: Fri, 14 Feb 2014 08:03:25 +0100
Subject: [PATCH] only scan the rcX.d once for reading all kill or all start
 links (closes: #738759)

---
 debian/changelog |   5 ++
 debian/src/sysv-rc/etc/init.d/rc | 138 ++-
 2 files changed, 84 insertions(+), 59 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index ac3f0a0..0bff2a4 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,13 @@
 sysvinit (2.88dsf-52) UNRELEASED; urgency=low
 
+  [ Petter Reinholdtsen ]
   * Replace debian/watch with file available from
 http://qa.debian.org/cgi-bin/watchfile.cgi?package=sysvinit .
 
+  [ Gerfried Fuchs ]
+  * only scan the rcX.d once for reading all kill or all start links
+(closes: #738759)
+
  -- Petter Reinholdtsen p...@debian.org  Thu, 13 Feb 2014 13:23:35 +0100
 
 sysvinit (2.88dsf-51) unstable; urgency=low
diff --git a/debian/src/sysv-rc/etc/init.d/rc b/debian/src/sysv-rc/etc/init.d/rc
index 4e95302..7767778 100644
--- a/debian/src/sysv-rc/etc/init.d/rc
+++ b/debian/src/sysv-rc/etc/init.d/rc
@@ -124,6 +124,65 @@ case $CONCURRENCY in
 		;;
 esac
 
+# helper scripts
+kill_test_add() {
+	script=$1
+	# Check if the script is there.
+	[ ! -f $script ]  return 
+
+	#
+	# Find stop script in previous runlevel but
+	# no start script there.
+	#
+	suffix=${script#/etc/rc$runlevel.d/K[0-9][0-9]}
+	previous_stop=/etc/rc$previous.d/K[0-9][0-9]$suffix
+	previous_start=/etc/rc$previous.d/S[0-9][0-9]$suffix
+	#
+	# If there is a stop script in the previous level
+	# and _no_ start script there, we don't
+	# have to re-stop the service.
+	#
+	[ -f $previous_stop ]  [ ! -f $previous_start ]  return 
+
+	# Stop the service.
+	return $script
+}
+start_test_add() {
+	script=$1
+	[ ! -f $script ]  return 
+
+	suffix=${script#/etc/rc$runlevel.d/S[0-9][0-9]}
+	if [ $previous != N ]
+	then
+		#
+		# Find start script in previous runlevel and
+		# stop script in this runlevel.
+		#
+		stop=/etc/rc$runlevel.d/K[0-9][0-9]$suffix
+		previous_start=/etc/rc$previous.d/S[0-9][0-9]$suffix
+		#
+		# If there is a start script in the previous level
+		# and _no_ stop script in this level, we don't
+		# have to re-start the service.
+		#
+		if [ start = $ACTION ] ; then
+			[ -f $previous_start ]  [ ! -f $stop ]  return 
+		else
+			# Workaround for the special
+			# handling of runlevels 0 and 6.
+			previous_stop=/etc/rc$previous.d/K[0-9][0-9]$suffix
+			#
+			# If there is a stop script in the previous level
+			# and _no_ start script there, we don't
+			# have to re-stop the service.
+			#
+			[ -f $previous_stop ]  [ ! -f $previous_start ]  return 
+		fi
+
+	fi
+	return $script
+}
+
 # Is there an rc directory for this new runlevel?
 if [ -d /etc/rc$runlevel.d ]
 then
@@ -150,41 +209,28 @@ then
 	then
 		# Run all scripts with the same level in parallel
 		CURLEVEL=
+		SCRIPTS=
 		for s in /etc/rc$runlevel.d/K*
 		do
 			# Extract order value from symlink
 			level=${s#/etc/rc$runlevel.d/K}
 			level=${level%%[a-zA-Z]*}
+			if [ -z $CURLEVEL ]
+			then
+CURLEVEL=$level
+			fi
 			if [ $level = $CURLEVEL ]
 			then
+SCRIPTS=$SCRIPTS $(kill_test_add $s)
 continue
 			fi
-			CURLEVEL=$level
-			SCRIPTS=
-			for i in /etc/rc$runlevel.d/K$level*
-			do
-# Check if the script is there.
-[ ! -f $i ]  continue
-
-#
-# Find stop script in previous runlevel but
-# no start script there.
-#
-suffix=${i#/etc/rc$runlevel.d/K[0-9][0-9]}
-previous_stop=/etc/rc$previous.d/K[0-9][0-9]$suffix
-previous_start=/etc/rc$previous.d/S[0-9][0-9]$suffix
-#
-# If there is a stop script in the previous level
-# and _no_ start script there, we don't
-# have to re-stop the service.
-#
-[ -f $previous_stop ]  [ ! -f $previous_start ]  continue
+			SCRIPTS=$SCRIPTS $(kill_test_add $s)
 
-# Stop the service.
-SCRIPTS=$SCRIPTS $i
-			done
 			startup stop $SCRIPTS
+			CURLEVEL=$level
+			SCRIPTS=
 		done
+		startup stop $SCRIPTS
 	fi
 
 	if [ makefile = $CONCURRENCY ]
@@ -199,54 +245,28 @@ then
 		# Now run the START scripts for this runlevel.
 		# Run all scripts with the same level in parallel
 		CURLEVEL=
+		SCRIPTS=
 		for s in /etc/rc$runlevel.d/S*
 		do
 			# Extract order value from symlink
 			level=${s#/etc/rc$runlevel.d/S}
 			level=${level%%[a-zA-Z]*}
+			if [ -z $CURLEVEL ]
+			then
+CURLEVEL=$level
+		

[Pkg-sysvinit-devel] Processed: fix for the bug

2014-02-13 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

 tags 738759 + patch
Bug #738759 [initscripts] /etc/init.d/rc: adding/removing init scripts during 
runlevel switch results in double/no run for specific init scripts
Added tag(s) patch.
 thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
738759: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=738759
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

___
Pkg-sysvinit-devel mailing list
Pkg-sysvinit-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-sysvinit-devel