Re: [pve-devel] [PATCH qemu-server/docs/manager v10 0/4] AMD SEV

[Dominik Csapak]

all in all the series looks mostly good to me with some minor comments
(see comments on the individual patches)
i could not test it since i don't have an amd epyc system here ;)


one high level thing though (but no hard feelings)

is the systemd service really necessary ?

we could simply call the binary the first time it's needed?

so in qemu-server:

---
if (! -e $cap_path) {
   # executing the binary
}
---

before we try to parse it ?

we can still make it a service should we need, but IMHO this seems
overkill for the current use case


___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH qemu-server/docs/manager v10 0/4] AMD SEV

[Markus Frank]

Patch series to enable AMD Secure Encrypted Virtualization (SEV)

changes v10:
* removed include of sys/types.h in C Program
* also die if the BIOS is not set, since the default is SeaBIOS
* added pve-manager patch

apply/compile order:
1. qemu-server: add C program to get hardware capabilities from CPUID
2. qemu-server: config: add AMD SEV support
3. pve-docs: add AMD SEV documentation
4. pve-manager: ui: add AMD SEV configuration to Options


qemu-server:

Markus Frank (2):
  add C program to get hardware capabilities from CPUID
  config: add AMD SEV support

 Makefile  |  1 +
 PVE/API2/Qemu.pm  | 11 +++
 PVE/QemuMigrate.pm|  4 +
 PVE/QemuServer.pm | 79 +++
 query-machine-capabilities/Makefile   | 21 +
 .../query-machine-capabilities.c  | 70 
 .../query-machine-capabilities.service| 12 +++
 7 files changed, 198 insertions(+)
 create mode 100644 query-machine-capabilities/Makefile
 create mode 100644 query-machine-capabilities/query-machine-capabilities.c
 create mode 100644 
query-machine-capabilities/query-machine-capabilities.service


docs:

Markus Frank (1):
  add AMD SEV documentation

 qm.adoc | 103 
 1 file changed, 103 insertions(+)


manager:

Markus Frank (1):
  ui: add AMD SEV configuration to Options

 www/manager6/Makefile|  1 +
 www/manager6/qemu/Options.js | 11 
 www/manager6/qemu/SevEdit.js | 98 
 3 files changed, 110 insertions(+)
 create mode 100644 www/manager6/qemu/SevEdit.js

-- 
2.39.2



___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel