[issue24484] multiprocessing cleanup occasionally throws exception
New submission from Jorge Herskovic: I'm writing a library on top of multiprocessing. As part of the test suite, I create and destroy dozens of processes repeatedly. About once in 50 runs, the tests complete successfully but the program crashes with: Error in atexit._run_exitfuncs: Traceback (most recent call last): File /Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/multiprocessing/util.py, line 286, in _exit_function _run_finalizers(0) File /Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/multiprocessing/util.py, line 246, in _run_finalizers items = [x for x in list(_finalizer_registry.items()) if f(x)] RuntimeError: dictionary changed size during iteration (this is on OS X 10.10.3, Python 3.4.3; I've been unable to replicate the behavior on Python 2.7.9, 3.5.0b2, or pypy despite hundreds of runs) The problematic code is available at https://github.com/jherskovic/mpetl and the tests should be run with nosetests -- components: Library (Lib) messages: 245597 nosy: Jorge Herskovic priority: normal severity: normal status: open title: multiprocessing cleanup occasionally throws exception type: crash versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24484 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't
Raymond Hettinger added the comment: Is it expected? No, it is a bug. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24482 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't
Changes by Dmitry Odzerikho dmitry.odzeri...@gmail.com: Added file: http://bugs.python.org/file39757/test_segfault.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24482 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23883] __all__ lists are incomplete
Jacek Kołodziej added the comment: I've added previously missing test and docs for test.support.check__all__ in Issue23883_support_check__all__.v2.patch . Awaiting review. :) -- Added file: http://bugs.python.org/file39760/Issue23883_support_check__all__.v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23883 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't
Serhiy Storchaka added the comment: I can't reproduce the crash in 3.3+ (this doesn't matter the bug is gone), but can reproduce in 2.7 and 3.2. Here is a reproducer that compatible with 2.7 and 3.x. -- Added file: http://bugs.python.org/file39762/test_segfault.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24482 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19756] test_nntplib: sporadic failures, network isses? server down?
Martin Panter added the comment: See Issue 1186900 about the NNTP client raising EOFError. As for the “cannot read from timed out object” errors (also reported in Issue 19613), I think the test classes are bad. The test logs don’t seem to be available, but I reckon that the previous test to the failing test would have been skipped due to the transient Internet handler. The test classes are essentially coded like this: class NetworkedNNTP_SSLTests(TestCase): @classmethod def setUpClass(cls): with support.transient_internet(cls.NNTP_HOST): cls.server = NNTP_SSL(cls.NNTP_HOST, timeout=TIMEOUT) def test_that_triggered_the_failure(self): with support.transient_internet(self.NNTP_HOST): ... # Suppose this timed out and the test was skipped def test_capabilities(self): # Now this is reusing the existing connection, left in a broken state by # the previous test self.server.capabilities() Either the server connection should be freshly made for each individual test case (not once per class), or all the test cases grouped by setUpClass() should be skipped if the transient Internet handler kicks in. I’m not sure if it is practical to do the second option with the standard unittest module. Perhaps the method wrapping stage could add some extra checks to see if the test should be skipped. -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19756 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24426] re.split performance degraded significantly by capturing group
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24426 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't
Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24482 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24408] tkinter.font.Font.measure() broken in 3.5
Roundup Robot added the comment: New changeset 8e90f3ffa784 by Serhiy Storchaka in branch '2.7': Issue #24408: Fixed test for tkinter.Font on OS X. https://hg.python.org/cpython/rev/8e90f3ffa784 New changeset 014ee2df443a by Serhiy Storchaka in branch '3.4': Issue #24408: Fixed test for tkinter.Font on OS X. https://hg.python.org/cpython/rev/014ee2df443a New changeset 5b037f934e40 by Serhiy Storchaka in branch '3.5': Issue #24408: Fixed test for tkinter.Font on OS X. https://hg.python.org/cpython/rev/5b037f934e40 New changeset 2d072d07dfe2 by Serhiy Storchaka in branch 'default': Issue #24408: Fixed test for tkinter.Font on OS X. https://hg.python.org/cpython/rev/2d072d07dfe2 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24408 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24408] tkinter.font.Font.measure() broken in 3.5
Serhiy Storchaka added the comment: Thank you Ned and Martin. -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24408 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()
New submission from Serhiy Storchaka: There is a difference between Python and C implementations of functools.lru_cache(). Python implementation caches the hash of the key, C implementation doesn't. May be this is not too important (at least I have no an example that shows the benefit of caching the hash), but there is a place for possible optimization. Proposed patch uses private functions _PyDict_GetItem_KnownHash() and _PyDict_SetItem_KnownHash() to avoid the second calculating of the hash for new keys. The hash is still calculated second time when the key is deleted from full cache. To avoid this _PyDict_DelItem_KnownHash() is needed. -- components: Library (Lib) files: clru_cache_known_hash.patch keywords: patch messages: 245593 nosy: ncoghlan, rhettinger, serhiy.storchaka priority: normal severity: normal stage: patch review status: open title: Avoid repeated hash calculation in C implementation of functools.lru_cache() type: performance versions: Python 3.6 Added file: http://bugs.python.org/file39758/clru_cache_known_hash.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24483 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24436] _PyTraceback_Add has no const qualifier for its char * arguments
Roundup Robot added the comment: New changeset 6f659b9f7fbc by Serhiy Storchaka in branch '3.4': Issue #24436: Added const qualifiers for char* arguments of _PyTraceback_Add. https://hg.python.org/cpython/rev/6f659b9f7fbc New changeset 9602b8313dd5 by Serhiy Storchaka in branch '3.5': Issue #24436: Added const qualifiers for char* arguments of _PyTraceback_Add. https://hg.python.org/cpython/rev/9602b8313dd5 New changeset 4cd00e6fa2ee by Serhiy Storchaka in branch 'default': Issue #24436: Added const qualifiers for char* arguments of _PyTraceback_Add. https://hg.python.org/cpython/rev/4cd00e6fa2ee -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24436 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24436] _PyTraceback_Add has no const qualifier for its char * arguments
Serhiy Storchaka added the comment: Thank you for your contribution Michael. -- resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24436 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24129] Incorrect (misleading) statement in the execution model documentation
Ivan Levkivskyi added the comment: Nick, thank you for a review, I have made a new patch with all the previous comments taken into account. -- Added file: http://bugs.python.org/file39759/classdoc-v4.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24129 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()
Serhiy Storchaka added the comment: New patch adds _PyDict_DelItem_KnownHash() and uses it to guarantee that the hash is only calculated once. -- Added file: http://bugs.python.org/file39761/clru_cache_known_hash_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24483 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't
New submission from Dmitry Odzerikho: Hi, I'm using iterators returned by itertools.tee in different threads. The original iterator passed to itertools.tee is thread-safe, however, it doesn't guarantees that the cloned iterators are thread safe too. However the equivalent implementation of itertools.tee in pure Python seems to work fine in this case. Is it expected or I'm doing something wrong? I'm attaching a simple example that shows the behaviour. -- title: itertools.tee causes segfault in a multithreading environment, while the equivalent implementation does'nt - itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't Added file: http://bugs.python.org/file39756/test_segfault.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24482 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24464] Got warning when compiling sqlite3 module on Mac OSX
Ronald Oussoren added the comment: https://www.sqlite.org/c3ref/enable_shared_cache.html appears to indicate that the function is deprecated on OSX 10.7 and iOS 5.0, but looking at the latest sources on sqlite.org that's not the case, the warning in the documentation appears to be for the version of SQLite that Apple ships with their systems. Because of this I'm against merging this patch as is because it also affects anyone building using the upstream version of SQLite instead of the version shipped with OSX. I'm -0 on suppressing the warning other ways, either by detecting that the build uses Apple's build of SQLite or by using pragma's to disable deprecation warnings for this functions. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24464 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24436] _PyTraceback_Add has no const qualifier for its char * arguments
Changes by Serhiy Storchaka storch...@gmail.com: -- versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24436 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()
Raymond Hettinger added the comment: This is important. -- assignee: - rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24483 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14373] C implementation of functools.lru_cache
Raymond Hettinger added the comment: If the C version is to remain in Python3.5, please make sure it provides all of the carefully designed features of the pure python version: * The hash function is called no more than once per element * The key is constructed to be flat as possible * Thread-safe where needed: - make_key called outside locks - within a reentrant lock (either a real lock or the GIL), check to see if the key is in the cache and if so, update the stats and return the value + outside of locks, call the user function (allowing for recursive functions) + within a reentrant lock (either a real lock or the GIL) handle cache misses by 1) verifying there was not an intervening cache update by the user function, 2) updating links, 3) updating stats. During the updates, make only one potentially reentrant cache[key] assignment after all invariants have been restored. Save all decrefs until all other state updates have been completed. A number of features of the lru_cache were designed for space savings over speed (lru is all about eviction to make space for a new entry), for thread safety and to not fall apart during reentrancy. It also provides a guarantee that the hash function is not called more than once per element and is called *before* any of the lru structure updates or lookups (this makes reasoning about correctness *much* easier). In these capabilities can't be reliably reproduced for 3.5, I think the whole thing should be reverted and deferred to 3.6. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14373 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24309] string.Template should be using str.format and/or deprecated
Changes by Dmitry Kazakov jsb...@gmail.com: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24309 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't
Changes by Dmitry Odzerikho dmitry.odzeri...@gmail.com: Removed file: http://bugs.python.org/file39756/test_segfault.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24482 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24436] _PyTraceback_Add has no const qualifier for its char * arguments
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24436 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()
Raymond Hettinger added the comment: I would like the full functionality of the Python version to be implemented. Guaranteeing that the hash is only calculated once prevents a reentrancy hole and provides a speed benefit as well. Please implement exactly what the pure python version does (no more than one call to hash ever). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24483 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- Removed message: http://bugs.python.org/msg245600 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24483 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +rhettinger stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24482 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24426] re.split performance degraded significantly by capturing group
Roundup Robot added the comment: New changeset 7e46a503dd16 by Serhiy Storchaka in branch 'default': Issue #24426: Fast searching optimization in regular expressions now works https://hg.python.org/cpython/rev/7e46a503dd16 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24426 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1182143] making builtin exceptions more informative
George Jenkins added the comment: Reviewer please :) (or, advice on how I can get this to proceed, thx) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1182143 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1182143] making builtin exceptions more informative
R. David Murray added the comment: What does your patch implement? It's not clear from the issue discussion that an API was decided on. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1182143 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24439] Feedback for awaitable coroutine documentation
Yury Selivanov added the comment: Martin, if you want to help with the documentation, it would be great if you can help me with updating asyncio coroutines section: https://docs.python.org/3.5/library/asyncio-task.html#coroutines -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24439 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24479] Support LMMS project files in mimetypes.guess_type
Andreas Nilsson added the comment: Here is a decompressed example (use lmms -d file to decompress). Shouldn't this be parsed as XML? Here's a log of my experiment with it: Python 2.7.9 (default, Apr 2 2015, 15:33:21) [GCC 4.9.2] on linux2 Type help, copyright, credits or license for more information. import mimetypes mimetypes.init() mimetypes.guess_type(seaman.mmp) (None, None) mimetypes.guess_type(seaman.mmp, False) (None, None) By default LMMS saves as .mmpz which is the compressed type, I do not know the encryption method they use though but I can ask them if you want so! -- Added file: http://bugs.python.org/file39765/seaman.mmp ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24479 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14373] C implementation of functools.lru_cache
Serhiy Storchaka added the comment: If the C version is to remain in Python3.5, please make sure it provides all of the carefully designed features of the pure python version: * The hash function is called no more than once per element Will be satisfied by issue24483. I think all other capabilities are satisfied. The GIL is used to satisfy thread-safe. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14373 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()
Serhiy Storchaka added the comment: New patch touches also unbounded cache version. Larry, do you allow to commit such patch in 3.5? -- nosy: +larry versions: +Python 3.5 Added file: http://bugs.python.org/file39766/clru_cache_known_hash_3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24483 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24400] Awaitable ABC incompatible with functools.singledispatch
Yury Selivanov added the comment: An updated patch is attached. I'll commit it tomorrow morning. -- Added file: http://bugs.python.org/file39764/corotype.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24400 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24408] tkinter.font.Font.measure() broken in 3.5
Roundup Robot added the comment: New changeset 20c9290a5de4 by Ned Deily in branch '2.7': Issue #24408: Prevent test_font failures with non-ascii font names. https://hg.python.org/cpython/rev/20c9290a5de4 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24408 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24484] multiprocessing cleanup occasionally throws exception
Changes by Ned Deily n...@acm.org: -- nosy: +davin, sbt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24484 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23531] SSL operations cause entire process to hang
johnkw added the comment: This bug is not present on Python 2.7.10 on 64-bit Linux. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23531 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24464] Got warning when compiling sqlite3 module on Mac OS X
Ned Deily added the comment: I agree with Ronald that the proposed patch should not be applied as is. For example, the Pythons installed by the current python.org OS X installers build and link with a newer version of libsqlite3. This is one of several examples of third-party libraries for which the Apple-supplied version in OS X is old and users are better served by providing a newer version for use with Python. I think a better approach would be to make it easier for people building from source on OS X to also build and include these newer versions, like the installer build does. -- priority: normal - low title: Got warning when compiling sqlite3 module on Mac OSX - Got warning when compiling sqlite3 module on Mac OS X versions: +Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24464 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16095] urllib2 failing with squid proxy and digest authentication
Martin Panter added the comment: There are two problems with the test case, and one bug in Python: 1. HTTPPasswordMgr doesn’t handle realm=None; it has to be a string. You can use HTTPPasswordMgrWithDefaultRealm though. 2. The password managers won’t match a proxy with a non-standard port number against a hostname without a port. So you have to include the port in the add_password() call. 3. AbstractDigestAuthHandler.get_authorization() is using the wrong URL, as Alexander already discovered. I made proxy-digest.patch which should fix this. The wrong URL (final URL rather than proxy) was actually tested for in test_urllib2_localnet.ProxyAuthTests. So I fixed those tests. -- keywords: +patch nosy: +vadmium stage: - patch review versions: +Python 3.6 Added file: http://bugs.python.org/file39755/proxy-digest.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16095] urllib2 failing with squid proxy and digest authentication
Martin Panter added the comment: I should point out my patch also adds add_password() methods for the authentication handlers to the documentation. These were only documented by example, but everyone seems to prefer using them rather than the equivalent password manager method. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24259] tar.extractall() does not recognize unexpected EOF
Martin Panter added the comment: From the current documentation and limited experience with the module, ReadError (or a subclass) sounds best. I would only expect OSError only for OS-level things, like file not found, disk error, etc. The patches look good. One last suggestion is to use assertRaisesRegex, to be sure that you are getting exactly the exception you expect. Too many times I have found tests in the test suite that were completely broken, but happened to pass because the error happened to match the exception being tested. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24259 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24400] Awaitable ABC incompatible with functools.singledispatch
Stefan Behnel added the comment: I added three more comments to the review. The rest looks good to me, too. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24400 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22442] Deprecate PIPE with subprocess.check_call() and call()
Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +berker.peksag stage: needs patch - patch review versions: +Python 3.6 -Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22442 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
