[issue12006] strptime should implement %G, %V and %u directives
Ashley Anderson added the comment: Thanks for the review and the good suggestions. Hopefully this new patch is an improvement. I didn't know about the context manager for assertRaises - I was just following the format for another ValueError test a few lines above. The frozenset and re-wrapped comment were left from playing around with another way to do the checks, and I've corrected them. I think the conditionals around calculating the julian and year are clearer now as well. Please (obviously) let me know if there are further changes. Also please let me know if this is not the proper way to respond to the code review! -- Added file: http://bugs.python.org/file40113/issue12006_8_complete.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12006 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23672] IDLE can crash if file name contains non-BMP Unicode characters
Terry J. Reedy added the comment: The problem with astral chars and open/save dialogs is the subject of #21084. The problem with printing astral chars generated by programs is #22742 and maybe #21084. I added a fix for the very new display of filenames on the run separator bar, which is the problem discovered above. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23672 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24750] IDLE: Cosmetic improvements for main window
Serhiy Storchaka added the comment: Ah, ttk detection doesn't work this way. ImportError is not raised on import, and TclError is raised instead on widget creation. Here is a patch for 3.4 that is compatible with 8.4 (tested). @scroll.diff LGTM for 3.5+. -- Added file: http://bugs.python.org/file40100/@scroll34.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24750 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23672] IDLE can crash if file name contains non-BMP Unicode characters
sanad added the comment: On the lines of changes proposed by Terry and others in the comments, this is the patch I'm submitting. The function _filename_to_unicode() plays the major part in the plot. The function can get two types of filename ,'str' and 'bytes'. When its str, all the astral chars(characters that are outside BMP ) are replaced by the '�'(diamond question mark) character by performing a regex substitution in the return statement. If the received filename is in the form of b'..' (bytes) or any other encoding ,it is first decoded(as was earlier) into str and before returning, all the out of range Unicode characters are replaced by the '�'(diamond question mark) character . The effect on behavior is : the 1.IDLE is able to display correctly,the filename in the title-bar and in the file open dialog. 2. Any file with name that have astral chars in them are easily imported without any crash. This is my first patch,please review it ,if any errors found I will correct them and upload again :) -- keywords: +patch nosy: +sanad Added file: http://bugs.python.org/file40098/issue23672(updated third).patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23672 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23672] IDLE can crash if file name contains non-BMP Unicode characters
sanad added the comment:
Correction:
This patch fixes the problem of idle not opening when recent file list has
filenames outside BMP and the crashing of idle on using filenames with astral
characters.
The added benefit is that you can create a file with such chars and save it and
access it again from the Recent Files List.
What this patch doesn't fix is :
1. The File Open Dialog displays the filename incorrectly.
2. The File Open Dialog doesn't allows the file with such filename to be opened.
3. When trying the to run the file with such name, it gives an Traceback to
Tkinter. The following is the error message :
Exception in Tkinter callback
Traceback (most recent call last):
File /home/sanad/devpy/pessoc/cpython/Lib/tkinter/__init__.py, line 1549,
in __call__
return self.func(*args)
File /home/sanad/devpy/pessoc/cpython/Lib/idlelib/ScriptBinding.py, line
124, in run_module_event
return self._run_module_event(event)
File /home/sanad/devpy/pessoc/cpython/Lib/idlelib/ScriptBinding.py, line
145, in _run_module_event
interp.restart_subprocess(with_cwd=False, filename=code.co_filename)
File /home/sanad/devpy/pessoc/cpython/Lib/idlelib/PyShell.py, line 502, in
restart_subprocess
console.write(\n{0} {1} {0}.format(halfbar, tag))
File /home/sanad/devpy/pessoc/cpython/Lib/idlelib/PyShell.py, line 1294, in
write
'Non-BMP character not supported in Tk')
UnicodeEncodeError: 'UCS-2' codec can't encode characters in position 49-49:
Non-BMP character not supported in Tk
Which I guess is another related issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23672
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24778] mailcap.findmatch() ........ Shell Command Injection in filename
New submission from Bernd Dietzel: if the filename contains Shell Commands they will be executed if they are passed to os.system() as discribed in the docs. Filename should be quoted with quote(filename) to fix the bug. https://docs.python.org/2/library/mailcap.html mailcap.findmatch(/caps/, /MIMEtype/[, /key/[, /filename/[, /plist/]]]) Return a 2-tuple; the first element is a string containing the command line to be executed (which can be passed to*os.system() *), .. Exploid Demo wich runs xterm but should not : = import mailcap d=mailcap.getcaps() commandline,MIMEtype=mailcap.findmatch(d, text/*, filename='$(xterm);#.txt) ## commandline = less ''$(xterm);#.txt' import os os.system(commandline) ## xterm starts = By the way ... please do not use os.system() in your code, makes it unsafe. Best regards Bernd Dietzel Germany -- components: Library (Lib) files: screenshot.png messages: 247857 nosy: TheRegRunner priority: normal severity: normal status: open title: mailcap.findmatch() Shell Command Injection in filename type: security versions: Python 2.7 Added file: http://bugs.python.org/file40099/screenshot.png ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24778 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24759] Idle: add ttk widgets as an option
Serhiy Storchaka added the comment: Note also that committed patch doesn't work at all. from tkinter import ttk doesn't raise an exception with Tcl/Tk 8.4. See my patch in issue24750 that does working check. I consider impractical complex code for supporting 8.4 and ttk too. But in simplest cases this can be done easy. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24759 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24383] consider implementing __await__ on concurrent.futures.Future
Alex Grönholm added the comment: I'm having trouble compiling the latest default (@859a45ca1e86). Getting linker errors. I've updated the patch with Yury's tests in it. Would someone mind running them? Apparently they do pass on 3.5b3 at least. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24383 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23973] PEP 484 implementation
Guido van Rossum added the comment: I'm bumping this up since the CPython repo is several changes behind the typehinting repo (https://github.com/ambv/typehinting/tree/master/prototyping). Those should not miss RC1. -- priority: normal - release blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23973 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24272] PEP 484 docs
Guido van Rossum added the comment: This should probably be committed before RC1 -- it's better than nothing! -- priority: normal - release blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24272 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22227] Simplify tarfile iterator
Serhiy Storchaka added the comment: Updated patch addresses Martin's comments. Thanks Martin. -- versions: +Python 3.6 -Python 3.5 Added file: http://bugs.python.org/file40101/tarfile_tariter_2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20557] Use specific asserts in io tests
Serhiy Storchaka added the comment: Actually Raymond objected. But under pressure of positive feedbacks and to avoid non-polite discussion I'll commit the patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20557 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22227] Simplify tarfile iterator
Changes by Robert Collins robe...@robertcollins.net: -- stage: patch review - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24383] consider implementing __await__ on concurrent.futures.Future
Alex Grönholm added the comment: Yury, your tests complete even without any patches on cpython default (@74fc1af57c72). How is that possible? I verified that they are run. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24383 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24774] inconsistency in http.server.test
Chiu-Hsiang Hsu added the comment: I'm not quite sure we should put argument parsing back into the test() function or just fix docstring. It already expose port and bind through function arguments. It looks wierd to me to have function arguments CLI arguments modifying the same variable in the same time. If we want to move argument parsing back, I think we should clean the function parameters. In this way, the docstring of test function still need some update, though. (we have much more CLI arguments now) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24774 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24383] consider implementing __await__ on concurrent.futures.Future
Alex Grönholm added the comment: Ah hehe, I forgot to actually attach the patch. Thanks Yury. The asyncio docs need to explicitly mention that concurrent.futures.Futures can be directly awaited from coroutines. Aside from that, I think we're set -- just need Guido to chime in on this. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24383 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24383] consider implementing __await__ on concurrent.futures.Future
Stefan Behnel added the comment: It would be nice to have this applied to 3.5 even. I'm aware that this is a new feature that shouldn't go in any more at this point, but if it could get added in 3.5.1 at least, I think it would fill a rather clear and annoying gap when it comes to tool integration. If someone explained async/await as a new syntax feature for async programming to me, and then mentioned that you can't await a Future, I'd be rather surprised, to put it mildly. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24383 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24778] mailcap.findmatch() ........ Shell Command Injection in filename
Bernd Dietzel added the comment: Maybe it would be a good idea to do so as run-mailcap does : theregrunner@mint17 : ~ € run-mailcap --debug ';xterm;#'.txt - parsing parameter ';xterm;#'.txt - Reading mime.types file /etc/mime.types... - extension txt maps to mime-type text/plain - Reading mailcap file /etc/mailcap... Processing file ';xterm;#'.txt of type text/plain (encoding=none)... - checking mailcap entry text/plain; less '%s'; needsterminal - program to execute: less '%s' - filename contains shell meta-characters; aliased to '/tmp/fileV7f2MZ' - executing: less '/tmp/fileV7f2MZ' theregrunner@mint17 : ~ € -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24778 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20557] Use specific asserts in io tests
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20557 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20556] Use specific asserts in threading tests
Serhiy Storchaka added the comment: Yes, I missed to remove one old assertion. Thanks Mark. -- versions: +Python 3.5, Python 3.6 -Python 3.3 Added file: http://bugs.python.org/file40102/test_threading_asserts_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20556 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24383] consider implementing __await__ on concurrent.futures.Future
Yury Selivanov added the comment: Alex, the updated patch is attached. Guido, do you like the new approach? Can I commit this in 3.6? -- Added file: http://bugs.python.org/file40103/concurrent.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24383 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24759] Idle: add ttk widgets as an option
Terry J. Reedy added the comment:
If 2.7 and 3.4 are left out of consideration, then, AFAIK, the only people
necessarily affected are those with a PowerPC with OS 10.5 who upgrade to
python3.5 and also want to run Idle. People with an Intel machine instead might
be if there is no python3.5 that will run with the ActiveState 8.5 that Mark
says works on Intel 10.5 machines. I wish I know how many people that is. I
suspect a tiny fraction of Idle users and of people with such machines. But ...
The compatibility approach will work for Scrollbars, but I am dubious about
other widgets. For instance, tk Buttons have at least 31 options. ttk Buttons
have 9 of the same + style (and class_, which I do not thing we would use),
leaving 22 tk-only options.
To write tkttk code *in one file*, I believe
...ttk.Button(parent, options, style='xyz')
would have to be written (compactly) as something like
b=...Button(parent, common options)
b.config(**({'style':'xyz'} if ttk else { tk style options}))
or (expansively, in 5 lines)
b=...Button(parent, common options)
if ttk:
b['style'] = 'xyz'
else:
b.config(tk style options in '=' format})
I consider this impractical. I am unwilling to write code that way, in part
because it would have to be carefully tested both with and without ttk -- by
hand. I cannot imagine anyone else doing so either. It also does not work for
uses of ttk.Treeview, whose API is different from the multiple classes used in
Path and Class (Module) browser). I believe the same is true for ttk.Notebook
and the idlelib tab widget.
What I already planned to do instead is copy existing dialog code to new files,
possibly refactored, with pep8 filenames and internal names style. I already
planned to leave the existing files in place for now, though as zombies, in
case of any external code imports. With a little more work, it should be
possible to optionally use either old or new files. Most of the work would be
done with alternate bindings to menu items and accelerator keys, such as Find
in Files and Alt-F3.
It might be more acceptible to use ttk in 2.7 and 3.4 as an option rather than
as a replacement. Though I would only commit a ttk version when confident that
is works, leaving the option to switch back would add a safety factor. I
changed the title and will revert the patch later.
--
stage: - needs patch
title: Idle: require ttk (and tcl/tk 8.5) - Idle: add ttk widgets as an option
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24759
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20557] Use specific asserts in io tests
Roundup Robot added the comment: New changeset ace74c445a3f by Serhiy Storchaka in branch '3.4': Issue #20557: Use specific asserts in io tests. https://hg.python.org/cpython/rev/ace74c445a3f New changeset 2453ac990e5b by Serhiy Storchaka in branch '3.5': Issue #20557: Use specific asserts in io tests. https://hg.python.org/cpython/rev/2453ac990e5b New changeset 859a45ca1e86 by Serhiy Storchaka in branch 'default': Issue #20557: Use specific asserts in io tests. https://hg.python.org/cpython/rev/859a45ca1e86 New changeset 68115dd0c7f5 by Serhiy Storchaka in branch '2.7': Issue #20557: Use specific asserts in io tests. https://hg.python.org/cpython/rev/68115dd0c7f5 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20557 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24272] PEP 484 docs
Daniel Andrade Groppe added the comment: I dropped the ball here. The last message from the review system was misclassified by Gmail as spam... Sorry about that. I can take a look at this tonight but if anyone can address the comments earlier, go for it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24272 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24383] consider implementing __await__ on concurrent.futures.Future
Alex Grönholm added the comment: Nevermind, I was running the wrong Python version. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24383 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24272] PEP 484 docs
Ivan Levkivskyi added the comment: Is anyone working on this right now? If not, I could implement the comments by Guido to the latest patch by Daniel. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24272 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24217] O_RDWR undefined in mmapmodule.c
Jeffrey Armstrong added the comment: There is a patch attached to this report for greater than 2 months. Should I mark this as won't fix? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24217 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24780] unittest assertEqual difference output foiled by newlines
New submission from Chris Jerdonek: When newlines are present, the error message displayed by unittest's self.assertEqual() to show where strings differ can be nonsensical. For example, the caret symbol can show up in a strange location. The first example below shows a case where things work correctly. The second shows a newline case with the confusing display. == FAIL: test1 -- Traceback (most recent call last): File /Users/chris/***/test.py, line 66, in test1 self.assertEqual(abc, abd) AssertionError: 'abc' != 'abd' - abc ? ^ + abd ? ^ == FAIL: test2 -- Traceback (most recent call last): File /Users/chris/***/test.py, line 69, in test2 self.assertEqual(\nabcx, \nabdx) AssertionError: '\nabcx' != '\nabdx' - abcx? ^ + abdx? ^ -- components: Library (Lib) messages: 247883 nosy: chris.jerdonek priority: normal severity: normal status: open title: unittest assertEqual difference output foiled by newlines type: behavior versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24780 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24383] consider implementing __await__ on concurrent.futures.Future
Alex Grönholm added the comment: You're right Stefan -- I too was appalled that this was not possible in 3.5 to begin with. It feels completely natural to be able to await for concurrent Futures. But as this is considered a feature, it'll probably have to wait until 3.6. Otherwise you'll end up your app requiring a specific micro-release which is a big no-no in the Python world, as far as features go at least. But if this is considered a bugfix, it could still go into 3.5.0... *wink wink*. That's what I'm hoping for of course. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24383 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24779] Python/ast.c: decode_unicode is never called with rawmode=True
New submission from Eric V. Smith:
The only call to decode_unicode is this:
if (!*bytesmode !rawmode) {
return decode_unicode(c, s, len, rawmode, c-c_encoding);
}
So rawmode will always be 0. Removing this will delete a call to
PyUnicode_DecodeRawUnicodeEscape in decode_unicode.
--
components: Interpreter Core
messages: 247880
nosy: eric.smith
priority: normal
severity: normal
status: open
title: Python/ast.c: decode_unicode is never called with rawmode=True
versions: Python 3.5, Python 3.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24779
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24779] Python/ast.c: decode_unicode is never called with rawmode=True
Eric V. Smith added the comment: That's poor wording on my part: the call to PyUnicode_DecodeRawUnicodeEscape isn't actually execute if rawmode is false. So it's really just a dead branch that's being deleted. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24779 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20362] longMessage attribute is ignored in unittest.TestCase.assertRegexpMatches etc
Ilia Kurenkov added the comment: I notice folks have been subscribing to this. Any chance we could review it and merge? :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20362 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24779] Python/ast.c: decode_unicode is never called with rawmode=True
Brett Cannon added the comment: Then I say delete it. -- nosy: +brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24779 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24383] consider implementing __await__ on concurrent.futures.Future
Yury Selivanov added the comment: We may be able to do this for 3.5.1 (since PEP 492 was accepted provisionally, see https://mail.python.org/pipermail/python-dev/2015-May/139844.html) although it's still a pretty big new feature. I agree. I'm -1 on pushing this to 3.5.0 or to 3.5.1. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24383 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24776] Improve Fonts/Tabs UX for IDLE
Mark Roseman added the comment: What do you think of the layout in cfg_font_layout.png? (before/after) -- Added file: http://bugs.python.org/file40105/cfg_font_layout.png ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24776 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24777] sys.getrefcount takes no arguments
Berker Peksag added the comment: Thanks for the report. Some functions like getrefcount in sys module are specific to CPython. Other Python implementations like IronPython(it doesn't use reference counting for example) may not implement or partially implement those functions. sys.getrefcount() works fine with CPython: import sys l = 5 sys.getrefcount(l) 35 -- nosy: +berker.peksag resolution: - not a bug stage: - resolved status: open - closed title: sys.getrefcount takes no arguments ?? - sys.getrefcount takes no arguments ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24777 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23218] Modernize the IDLE Find/Replace/Find in Files dialogs
Mark Roseman added the comment: For illustration, attached idle_find_ttk.png, which is a minor layout tweak of the existing one (works on all the various find dialogs, though not shown in screen shot). I agree with Al's other suggestions here. -- nosy: +markroseman Added file: http://bugs.python.org/file40107/idle_find_ttk.png ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23218 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24782] Merge 'configure extensions' into main IDLE config dialog
New submission from Mark Roseman: I'm wondering about moving the functionality of the 'configure extensions' dialog into the main configuration dialog. As I don't know the history here, I'm wondering why it was made separate. My proposal would be to add an 'Extensions' tab in the main config dialog. Along the left would be a listbox holding the names of each extension. Along the right would be options for the extension selected in the listbox (done pretty much the same as now). Selecting a different extension from the list would swap in the appropriate set of options. This would have the additional advantage of doing away with the stacked tabs. -- components: IDLE messages: 247898 nosy: kbk, markroseman, roger.serwy, terry.reedy priority: normal severity: normal status: open title: Merge 'configure extensions' into main IDLE config dialog type: enhancement versions: Python 3.5, Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24782 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22227] Simplify tarfile iterator
Raymond Hettinger added the comment: The patch looks good and passes tests. Go ahead and apply. -- assignee: lars.gustaebel - serhiy.storchaka nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24781] Improve UX of IDLE Highlighting configuration tab
Terry J. Reedy added the comment: I find the new arrangement more confusing. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24781 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24781] Improve UX of IDLE Highlighting configuration tab
Serhiy Storchaka added the comment: I would make theme element chooser a list box and move the sample to the right. -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24781 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23218] Modernize the IDLE Find/Replace/Find in Files dialogs
Raymond Hettinger added the comment: These changes all seem reasonable and have a nice look. I have misgivings about shortening regular expression to regex. Otherwise, +1 for everything else. -- nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23218 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6631] Disallow relative files paths in urllib*.open()
Robert Collins added the comment: test_relativelocalfile is still in place in the urllib tests, so its affecting urlopen to this point. So I think the bug is fixed at least to the extent of the original report. I'm going to close this. -- nosy: +rbcollins stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6631 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22397] test_socket failure on AIX
Robert Collins added the comment: I've updated the ref in the patch to this bug per Victor's comments, and applied. I'm not sure of protocol here. Do we close this ticket, or keep it open to analyze the actual cause? -- nosy: +rbcollins ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22397 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24217] O_RDWR undefined in mmapmodule.c
Roundup Robot added the comment: New changeset 1838f37a8d9e by Benjamin Peterson in branch '3.4': include fcntl.h on all *nix platforms (closes #24217) https://hg.python.org/cpython/rev/1838f37a8d9e New changeset 25ba5e7af08a by Benjamin Peterson in branch '3.5': Merge 3.4 (#24217) https://hg.python.org/cpython/rev/25ba5e7af08a New changeset 4ed9cc2203b3 by Benjamin Peterson in branch 'default': merge 3.5 (#24217) https://hg.python.org/cpython/rev/4ed9cc2203b3 New changeset 2e635a0e0207 by Benjamin Peterson in branch '2.7': include fcntl.h on all *nix platforms (closes #24217) https://hg.python.org/cpython/rev/2e635a0e0207 -- nosy: +python-dev resolution: - fixed stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24217 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16263] sendmsg, recvmsg, recvmsg_into et al not being detected on Solaris
Changes by David Watson bai...@users.sourceforge.net: -- nosy: +baikie ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16263 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24759] Idle: add ttk widgets as an option
Terry J. Reedy added the comment: I realize now that tkinter.ttk is (normally) present and will define Python classes even if the tk widgets needed for them to work are not present. More comments on the added module on #24750 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24759 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22397] test_socket failure on AIX
Roundup Robot added the comment: New changeset e48826904e63 by Robert Collins in branch '3.4': Issue #22397: Skip failing tests on AIX https://hg.python.org/cpython/rev/e48826904e63 New changeset a12d29f87e4c by Robert Collins in branch '3.5': Issue #22397: Skip failing tests on AIX https://hg.python.org/cpython/rev/a12d29f87e4c New changeset 62235755609f by Robert Collins in branch 'default': Issue #22397: Skip failing tests on AIX https://hg.python.org/cpython/rev/62235755609f -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22397 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22397] test_socket not running all tests on AIX
Changes by Robert Collins robe...@robertcollins.net: -- stage: commit review - needs patch title: test_socket failure on AIX - test_socket not running all tests on AIX ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22397 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24781] Improve UX of IDLE Highlighting configuration tab
Mark Roseman added the comment: One of the other options I was playing with previously was a listbox for choosing the theme (what I'd suspect is the main user activity here). -- Added file: http://bugs.python.org/file40110/cfg_highlight_alt.png ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24781 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24782] Merge 'configure extensions' into main IDLE config dialog
Terry J. Reedy added the comment: In general, Idle-sig is a better place to ask question ;-). I applied the extension dialog patch just a year ago (#3068), It still needs improvements (#22704, #22705, #22706, #22707 #22726). Before that, people had to hand-edit either the idlelib or user version. So I applied the patch when clearly usable, and did not worry about making it 'perfect' first. Part of the answer to why separate dialogs is related to there being a) a separate config file (but the other dialog handles the other three) and probably more importantly, b) the set of extension being extensible, both by us and by users. This all said, I dislike the jumbled stacked tabs. Also, the entry space is wider than needed for any of our extensions. So whether the dialogs are consolidated or not, I like the idea of three columns: alphabetical list of extensions (all visible unless a user adds a large number), option names, and value entry. I would like to see a patch for this first. I would not mind patches for some of the issue above right after. I would like to improve this box before using ttk. The Idle dialog has room for an Extensions tab without stacking. I would like to see a separate, later patch for consolidation. -- nosy: +taleinat versions: +Python 2.7, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24782 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24383] consider implementing __await__ on concurrent.futures.Future
Alex Grönholm added the comment: Updated patch per review comments. I also corrected the order of the lines in the new block. If _must_cancel is True, it would have tried to call cancel() on _fut_waiter before it was set. Now the code matches that of the original block. The docs don't seem to explicitly say anywhere that they only accept asyncio's Futures and not concurrent Futures, so I'm unsure if any changes are needed there at all. -- Added file: http://bugs.python.org/file40106/concurrent.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24383 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Changes by David Watson bai...@users.sourceforge.net: -- nosy: +baikie ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24760] IDLE settings dialog shouldn't be modal
Mark Roseman added the comment: Incidentally (and this I would say is a definite bug) because the modal doesn't fully work on the Mac, you can actually create multiple copies of the config dialog! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24760 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23524] Use _set_thread_local_invalid_parameter_handler in posixmodule
Robert Collins added the comment: Looks committed a way back to me. -- nosy: +rbcollins resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23524 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22852] urllib.parse wrongly strips empty #fragment, ?query, //netloc
Robert Collins added the comment: See also issue 6631 -- nosy: +rbcollins ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22852 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24383] consider implementing __await__ on concurrent.futures.Future
Stefan Behnel added the comment: I find it questionable to mix await and threads, as I have said several times in the discussion about Nick Coghlan's proposal to introduce helper functions with a similar function. There are a couple of use cases in the context of asyncio, but definitely also a major one: blocking database drivers. Normally, applications keep a pool of connections open to a database and use a bounded size for it in order to limit the resource usage on server side. Starting a thread pool of the same size in the application provides a trivial way to make use of these connections concurrently and efficiently with a blocking database driver and/or ORM (e.g. SQLAlchemy). concurrent.futures makes this really easy. The argument but they're both Futures seems pretty bogus to me. concurrent.futures.Future is not just any Future, it's the one that is in the standard library, i.e. pretty much the only one that every tool could agree on (whether or not it knows about or uses asyncio). The fact that it's thread-safe doesn't really matter to me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24383 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24725] test_socket testFDPassEmpty fails on OS X 10.11 DP with Cannot allocate memory
Changes by David Watson bai...@users.sourceforge.net: -- nosy: +baikie ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24725 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24272] PEP 484 docs
Ivan Levkivskyi added the comment: New version of the patch by Daniel, latest comments by Guido are taken into account. -- Added file: http://bugs.python.org/file40108/typing_doc_v3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24272 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24750] IDLE: Cosmetic improvements for main window
Terry J. Reedy added the comment: Minor nit: you import 'ttkcompat' and add 'compat'. On to the new 'compat': the only doc for .setup_master is the docstring If master is not None, itself is returned. If master is None, the default master is returned if there is one, otherwise a new master is created and returned. So if master is always passed in, it seems that the call does nothing and could be removed. ._load_tile and ._tile_loaded have no doc. As near as I can tell from r = tk.Tk() s = ttk.Scrollbar(r) # does not set ._tile_loaded on r ttk._load_tile(r) # ditto, None returned with 8.5, ._load_tile does nothing and ._tile_loaded is never set. They are only used for 8.4. Correct? If the tile extension is loaded, then use_ttk would be set to True. Is the tile extension fully compatible with using ttk? I would like compat.py to consist of an initialization functions that is called exactly once, always with a Tk(), to set globals in the module. import tkinter as tk from tkinter import ttk def initialize(master, ttk_wanted=True): # untested globals use_ttk, Scrollbar, ... if not ttk_wanted: use_ttk = False else: try: ttk._load_tile(master) except tkinter.TclError: use_ttk = False else: use_ttk = True if use_ttk: from ttk import Scrollbar, ... else: from tk import Scroolbar, ... Initialize would normally be called when Idle starts up. ttk.wanted could make use_ttk a user option. Initialize with ttk_wanted True/False would be used for testing. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24750 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24781] Improve UX of IDLE Highlighting configuration tab
New submission from Mark Roseman: Placeholder for improvements to the syntax highlighting tab in IDLE config dialog. I've attached cfg_highlight.png which shows a before and after I'm suggesting as a starting point. It would have the same functionality but uses a lot less pieces to implement it. Thoughts? -- components: IDLE files: cfg_highlight.png messages: 247897 nosy: kbk, markroseman, roger.serwy, terry.reedy priority: normal severity: normal status: open title: Improve UX of IDLE Highlighting configuration tab type: enhancement versions: Python 3.5, Python 3.6 Added file: http://bugs.python.org/file40109/cfg_highlight.png ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24781 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24750] IDLE: Cosmetic improvements for main window
Mark Roseman added the comment: While I think this approach would largely be a bad idea for an IDLE-sized application, where I think it definitely would be useful is in something very restricted like the tkSimpleDialog code. To improve the various little 'askstring', 'askinteger' etc. sprinkled throughout IDLE I had to do a copy/paste to change that code to use ttk widgets. Because that is an example of something very simple and self-contained, it could easily provide an option to do ttk or non-ttk widgets. Apologies if this is too off-topic. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24750 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24781] Improve UX of IDLE Highlighting configuration tab
Mark Roseman added the comment: cfg_highlight_alt.png shows with the listbox for choosing a theme Also added highlight3.png... same kind of thing, but by renaming the tab as 'Themes' you no longer even need the row of labels at the top. And it parallels the fonts/tabs design suggestion somewhat too. -- Added file: http://bugs.python.org/file40111/highlight3.png ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24781 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24750] IDLE: Cosmetic improvements for main window
Terry J. Reedy added the comment: Keep in mind that most option substitution would be at the file rather than widget level. The scrollbar switching would be for something like editor windows, which are basically generic. For the option dialog, we would copy ConfigDialog.py to, say, configuration.py, adjust the imports, and convert to ttk (and pep8, as we wish). Then use_ttk would be used for choosing which file's ConfigDialog to bind to the Configure IDLE menu item. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24750 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24783] Import Error (undefined symbol: PyFloat_Type) when Importing math Module on Shared Build
New submission from David E. Narvaez: The original bug report can be found at https://bugs.kde.org/show_bug.cgi?id=335965. I was not able to reproduce this on Gentoo until the Fedora maintainer commented they build their Python with --enable-shared. At that point, I built two copies of Python 2.7 from git, one with defaults and one with --enable-shared. When I run the application with PYTHONHOME=/path/to/defualt/install it runs correctly, and when I run the application with PYTHONHOME=/path/to/shared/install I can reproduce the bug. Is there something missing in the linking of this application in order for it to use a Python installation built with --enable-shared? -- components: Installation messages: 247915 nosy: david-narvaez priority: normal severity: normal status: open title: Import Error (undefined symbol: PyFloat_Type) when Importing math Module on Shared Build versions: Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24783 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24781] Improve UX of IDLE Highlighting configuration tab
Terry J. Reedy added the comment: After I added a custom Terry theme, my main activity has been tweaking it. Version 3 is an clear improvement over the existing tab. With the example box on top, I think the comment should be # Click here or dropbox # below to change item. 0 Foregound 0 Background are supposed to be radio buttons. The black and white squares look like anything but. 'Theme' is ambiguous as to Idle's text highlighting themes versus ttk's widget style themes. I think the current grouping should be labeled 'Text Highlighting'. This will pave the way to add, to the ttk version, a 'Widget Style' listbox allowing users to choose among those available. With these items resolved, I would be inclined to apply a tk patch to all versions. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24781 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6500] urllib2 maximum recursion depth exceeded
Berker Peksag added the comment: Here is a patch for 2.7. I don't think backporting 9eceb618274a to 2.7 is worth the effort for this, so I just fixed the __getattr__ method and added a test. -- keywords: +patch nosy: +berker.peksag stage: needs patch - patch review Added file: http://bugs.python.org/file40112/issue6500.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6500 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
