[issue35030] Python 2.7 OrderedDict creates circular references

2018-10-20 Thread tzickel 


tzickel  added the comment:

I see, so basically this would be a problem only if the root object had a 
__del__ method and then the GC wouldn't reclaim it ?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35030] Python 2.7 OrderedDict creates circular references

2018-10-20 Thread tzickel 


tzickel  added the comment:

You can see the testing code here:

https://github.com/numpy/numpy/blob/eb40e161e2e593762da9c77858343e3720351ce7/n
umpy/testing/_private/utils.py#L2199

it calls gc.collect in the end and only throws this error if it returns a non 
zero return value from it (after clearing the gc before calling the test code).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34396] Certain methods that heap allocated subtypes inherit suffer a 50-80% performance penalty

2018-10-20 Thread Raymond Hettinger 


Change by Raymond Hettinger :


--
nosy: +rhettinger
versions:  -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34396] Certain methods that heap allocated subtypes inherit suffer a 50-80% performance penalty

2018-10-20 Thread Dan Snider 


Dan Snider  added the comment:

Well, I found another mystery. Calling tuple.__getitem__ directly, on an actual 
tuple instance, is 50-80% slower than calling list.__getitem__ even though in 
theory, they should be virtually identical with maybe tuple access being 
infinitesimally be faster.

The only difference I found here between the two __getitem__s surprisingly is 
that tuple *doesn't* have __getitem__ in its method list, while list does.

>>> [].__getitem__

>>> ().__getitem__


Since list is using the wrapper in tp_methods and tuple isn't,  it *look* like 
METH_COEXIST *is* helping but since we know that in both the dict case and now 
the tuple/list case it is unnecessary, there's clearly a bug somewhere causing 
multiple arg tuple allocs and or arg parsing. Unfortunately, it takes me 
several hours to "catch up" from CALL_FUNCTION in ceval.c to something like 
call_method in typeobject.c and I don't have that kind of time at the moment 
but hopefully someone notices this again.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

2018-10-20 Thread Anthony Sottile 


Change by Anthony Sottile :


--
pull_requests: +9361

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35034] Add closing and iteration to threading.Queue

2018-10-20 Thread Raymond Hettinger 


Raymond Hettinger  added the comment:

Note we already have the task_done() / join() API to handle the common case of 
notification for when work is done.  At one point, Guido opined that he didn't 
want the queue module to go any further into the world of task management 
(because it is beyond the scope of what the module is trying to do).

Also, because this is a significant expansion of an otherwise simple API and 
because it would establish new idioms, it would need to be discussed on 
python-ideas before going forward.  Also, to evaluate the proposal, it would be 
help to have examples of existing code that would be improved with the new API. 
 Likewise, it would be helpful to survey other languages to see if they have 
anything like this and see whether their experiences were possible or negative.

If the python-ideas discussion is fruitful, feel free to re-open this feature 
request.  The existence of the PR will help make the discussion more concrete 
and give people a chance to try it out.

--
assignee:  -> rhettinger
nosy: +pitrou, rhettinger, tim.peters
resolution:  -> later
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35025] Compiling `timemodule.c` can fail on macOS due to availability warnings

2018-10-20 Thread miss-islington 


miss-islington  added the comment:


New changeset 002aef3f66a9f8da635e20860622f2e539a0b611 by Miss Islington (bot) 
in branch '3.7':
closes bpo-35025: Properly guard the `CLOCK_GETTIME` et al macros in 
timemodule.c. (GH-9961)
https://github.com/python/cpython/commit/002aef3f66a9f8da635e20860622f2e539a0b611


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35025] Compiling `timemodule.c` can fail on macOS due to availability warnings

2018-10-20 Thread miss-islington 


miss-islington  added the comment:


New changeset beb83d013e0295c987087febf2be78b1da389b15 by Miss Islington (bot) 
in branch '3.6':
closes bpo-35025: Properly guard the `CLOCK_GETTIME` et al macros in 
timemodule.c. (GH-9961)
https://github.com/python/cpython/commit/beb83d013e0295c987087febf2be78b1da389b15


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35025] Compiling `timemodule.c` can fail on macOS due to availability warnings

2018-10-20 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +9360

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35025] Compiling `timemodule.c` can fail on macOS due to availability warnings

2018-10-20 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +9359

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35025] Compiling `timemodule.c` can fail on macOS due to availability warnings

2018-10-20 Thread Benjamin Peterson 

Benjamin Peterson  added the comment:


New changeset 94451182ccd6729c11338926d8a3d11645e86626 by Benjamin Peterson 
(Max Bélanger) in branch 'master':
closes bpo-35025: Properly guard the `CLOCK_GETTIME` et al macros in 
timemodule.c. (GH-9961)
https://github.com/python/cpython/commit/94451182ccd6729c11338926d8a3d11645e86626


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35034] Add closing and iteration to threading.Queue

2018-10-20 Thread Vladimir Filipović 

Change by Vladimir Filipović :


--
keywords: +patch, patch, patch, patch
pull_requests: +9354, 9355, 9356, 9357
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35034] Add closing and iteration to threading.Queue

2018-10-20 Thread Vladimir Filipović 

Change by Vladimir Filipović :


--
keywords: +patch, patch, patch
pull_requests: +9354, 9355, 9357
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35034] Add closing and iteration to threading.Queue

2018-10-20 Thread Vladimir Filipović 

Change by Vladimir Filipović :


--
keywords: +patch, patch
pull_requests: +9354, 9355
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35034] Add closing and iteration to threading.Queue

2018-10-20 Thread Vladimir Filipović 

Change by Vladimir Filipović :


--
keywords: +patch
pull_requests: +9354
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35020] Add multisort recipe to sorting docs

2018-10-20 Thread Benjamin Peterson 


Change by Benjamin Peterson :


--
pull_requests: +9353

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

2018-10-20 Thread Terry J. Reedy 


Change by Terry J. Reedy :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

2018-10-20 Thread Terry J. Reedy 


Terry J. Reedy  added the comment:


New changeset f125d788ff71095390a9e190da6722eb00166cd4 by Terry Jan Reedy in 
branch '2.7':
bpo-31500: Default fonts now are scaled on HiDPI displays. (#10015)
https://github.com/python/cpython/commit/f125d788ff71095390a9e190da6722eb00166cd4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35034] Add closing and iteration to threading.Queue

2018-10-20 Thread Vladimir Filipović 

New submission from Vladimir Filipović :

Code using threading.Queue often needs to coordinate a "work is finished as far 
as far as I care" state between the producing and consuming side.

When going from the producer to the consumer ("No more items after this, so 
don't bother waiting"), this is usually implemented with sentinel objects, 
which is at best needlessly verbose and at worst tricky to get right (as with 
multiple consumers, or communicating a non-trivial sentinel object).
When going the other direction ("I'm not interested in consuming any more, so 
you can stop putting them on the queue"), or when a third component needs to 
notify both sides ("You two start wrapping up, but don't drop any in-flight 
items") there isn't even a clear usual solution.

Adding a close() method to the Queue (with accompanying exception treatment 
etc.) would solve all of this in a very clean way. It would not change anything 
for code that doesn't want to use it. It would simplify a lot of everyday uses 
of Queue. Many simple producers could reduce their coordination code to a `with 
closing(queue)` idiom. A further __iter__() method would enable many simple 
consumers to safely cut all their coordination boilerplate down to just `for 
item in queue`.

I've got a sample implementation ready for Queue and its children, and I'm 
about to submit it as a PR.

I'd be happy to contribute an equivalent (within limits of its API promises) 
implementation for SimpleQueue, but I don't have it written, and I'm unsure if 
I should make a separate issue for that.

--
components: Library (Lib)
messages: 328181
nosy: hemflit
priority: normal
severity: normal
status: open
title: Add closing and iteration to threading.Queue
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35020] Add multisort recipe to sorting docs

2018-10-20 Thread Raymond Hettinger 


Change by Raymond Hettinger :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35020] Add multisort recipe to sorting docs

2018-10-20 Thread Raymond Hettinger 


Raymond Hettinger  added the comment:


New changeset 890a4b92933be8e7c554222d99ef829c88fa8637 by Raymond Hettinger 
(Xtreak) in branch 'master':
bpo-35020: Link to sorting examples from list.sort() (GH-9931)
https://github.com/python/cpython/commit/890a4b92933be8e7c554222d99ef829c88fa8637


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35030] Python 2.7 OrderedDict creates circular references

2018-10-20 Thread Raymond Hettinger 


Raymond Hettinger  added the comment:

I'm unclear whether you're reporting a true leak (one that can't be cleaned-up 
by a call to gc.collect()) or just a garden variety circular reference that 
will eventually free, just not as quickly as it would with straight reference 
counting applied when there are no circular references.

FWIW, there wasn't a backport because the latter case wasn't deemed to be bug.  
Circular references are allowed -- we just wait on GC to clean them up.  

Another consideration was that the weakref proxy alternative was much slower 
than the existing code (that mattered less in Python 3 where we have a C 
implementation of OrderedDict, giving more freedom for the pure python version 
to adopt a less performant but more memory friendly alternative).  There is a 
little more history here as well.  There used to be a __del__() method to 
accelerate the reclamation of memory but that was slow and it occasionally 
caused other problems such as the creation of an unreclaimable zombie object.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

2018-10-20 Thread Terry J. Reedy 


Change by Terry J. Reedy :


--
pull_requests: +9352

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32256] Make patchcheck.py work for out-of-tree builds

2018-10-20 Thread Alexey Izbyshev 


Alexey Izbyshev  added the comment:

Thank you for testing and merging, Victor!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31500] IDLE: Tiny font on HiDPI display

2018-10-20 Thread Terry J. Reedy 


Terry J. Reedy  added the comment:


New changeset 18c44cc0c13eed792e286ddc1d331951e723aeb9 by Terry Jan Reedy 
(Cheryl Sabella) in branch '2.7':
[2.7] bpo-31500: IDLE: Scale default fonts on HiDPI displays. (GH-3639) 
(GH-6585)
https://github.com/python/cpython/commit/18c44cc0c13eed792e286ddc1d331951e723aeb9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

2018-10-20 Thread Serhiy Storchaka 


Change by Serhiy Storchaka :


--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

2018-10-20 Thread Serhiy Storchaka 

Serhiy Storchaka  added the comment:

This change introduced a compiler warning.

/home/serhiy/py/cpython/Modules/_testcapimodule.c:5042:17: warning: 
initialization from incompatible pointer type [-Wincompatible-pointer-types]
 {"bad_get", bad_get, METH_FASTCALL},
 ^~~
/home/serhiy/py/cpython/Modules/_testcapimodule.c:5042:17: note: (near 
initialization for ‘TestMethods[173].ml_meth’)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35033] Column or row spanning cells are not implemented.

2018-10-20 Thread Karthikeyan Singaravelan 


Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35017] socketserver accept a last request after shutdown

2018-10-20 Thread Karthikeyan Singaravelan 


Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34576] [EASY doc] http.server, SimpleHTTPServer: warn users on security

2018-10-20 Thread Senthil Kumaran 


Senthil Kumaran  added the comment:


New changeset eeab510bb7e51802c18b3770cbb23ae0ca91da6b by Senthil Kumaran in 
branch 'master':
bpo-34576 - Fix the formatting for security considerations in http.server.rst 
(#10005)
https://github.com/python/cpython/commit/eeab510bb7e51802c18b3770cbb23ae0ca91da6b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34576] [EASY doc] http.server, SimpleHTTPServer: warn users on security

2018-10-20 Thread Senthil Kumaran 


Senthil Kumaran  added the comment:

Please approve this one - https://github.com/python/cpython/pull/10005 and I 
adopt the backports according the reverts.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34576] [EASY doc] http.server, SimpleHTTPServer: warn users on security

2018-10-20 Thread Senthil Kumaran 


Senthil Kumaran  added the comment:

No problem, Ned. I will update it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34909] StrEnum subclasses cannot be created

2018-10-20 Thread Ethan Furman 


Ethan Furman  added the comment:

Thank you both.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34521] Multiple tests (test_socket, test_multiprocessing_*) fail due to incorrect recvmsg(2) buffer lengths, causing failures on FreeBSD CURRENT

2018-10-20 Thread Ned Deily 


Ned Deily  added the comment:

Thanks, Pablo, I cherry-picked the NEWS entries into 3.7.1 and 3.6.7.  So I 
guess the only remaining question here is what to do about 2.7.  I'll also 
leave that for you!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34576] [EASY doc] http.server, SimpleHTTPServer: warn users on security

2018-10-20 Thread Ned Deily 


Ned Deily  added the comment:

Sorry, Senthil, I reverted the original PRs for 3.7.1 and 3.6.7 so you may need 
to redo your new PR.

--
priority: deferred blocker -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34909] StrEnum subclasses cannot be created

2018-10-20 Thread Ned Deily 


Ned Deily  added the comment:

NEWS entry added for 3.7.1 and master.  Closing again.

--
priority: deferred blocker -> 
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

2018-10-20 Thread Ned Deily 


Ned Deily  added the comment:

Released in 3.7.1

--
priority: release blocker -> 
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

2018-10-20 Thread Pablo Galindo Salgado 


Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +9351
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34909] StrEnum subclasses cannot be created

2018-10-20 Thread Ned Deily 


Ned Deily  added the comment:


New changeset 03ca8b5f23e9fe122bb0ca80397a2481c10cd7c4 by Ned Deily in branch 
'3.7':
bpo-34909: NEWS entry.
https://github.com/python/cpython/commit/03ca8b5f23e9fe122bb0ca80397a2481c10cd7c4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

2018-10-20 Thread Ned Deily 


Ned Deily  added the comment:


New changeset 60c663c0f76c790afbed4d673c3ce264dd226b8c by Ned Deily (Miss 
Islington (bot)) in branch '3.7':
bpo-34970: Protect tasks weak set manipulation in asyncio.all_tasks() (GH-9837) 
(GH-9849)
https://github.com/python/cpython/commit/60c663c0f76c790afbed4d673c3ce264dd226b8c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34521] Multiple tests (test_socket, test_multiprocessing_*) fail due to incorrect recvmsg(2) buffer lengths, causing failures on FreeBSD CURRENT

2018-10-20 Thread Ned Deily 


Ned Deily  added the comment:


New changeset ce3b5a80cc6ee4f9aff7b673f457294d7e054349 by Ned Deily (Miss 
Islington (bot)) in branch '3.7':
bpo-34521: Add NEWS entry for changes in GH-9613 (GH-9850)
https://github.com/python/cpython/commit/ce3b5a80cc6ee4f9aff7b673f457294d7e054349


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

2018-10-20 Thread Pablo Galindo Salgado 


Pablo Galindo Salgado  added the comment:

Re-adding client_context.options |= ssl.OP_NO_TLSv1_3 makes the test pass again.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34576] [EASY doc] http.server, SimpleHTTPServer: warn users on security

2018-10-20 Thread Ned Deily 


Ned Deily  added the comment:


New changeset 32fe7b0188bb73c84c0bde80643b6a3bfd03ba93 by Ned Deily in branch 
'3.7':
bpo-34576: Revert doc change until it can be properly fixed (GH-9720)
https://github.com/python/cpython/commit/32fe7b0188bb73c84c0bde80643b6a3bfd03ba93


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34576] [EASY doc] http.server, SimpleHTTPServer: warn users on security

2018-10-20 Thread Ned Deily 


Ned Deily  added the comment:


New changeset 92fe93e48a852d22ba33c0fa12112ae664724202 by Ned Deily in branch 
'3.6':
bpo-34576: Revert doc change until it can be properly fixed (GH-9720)
https://github.com/python/cpython/commit/92fe93e48a852d22ba33c0fa12112ae664724202


--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34521] Multiple tests (test_socket, test_multiprocessing_*) fail due to incorrect recvmsg(2) buffer lengths, causing failures on FreeBSD CURRENT

2018-10-20 Thread Ned Deily 


Ned Deily  added the comment:


New changeset d404ffa8adf252d49731fbd09b740360577274c8 by Ned Deily (Miss 
Islington (bot)) in branch '3.6':
bpo-34521: Add NEWS entry for changes in GH-9613 (GH-9850)
https://github.com/python/cpython/commit/d404ffa8adf252d49731fbd09b740360577274c8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35033] Column or row spanning cells are not implemented.

2018-10-20 Thread Julien Palard 


Julien Palard  added the comment:

Oh and we're also using raw spanning, in the same place, as the table header is 
two raws height and almost all cells but the last spans on two raws.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35033] Column or row spanning cells are not implemented.

2018-10-20 Thread Julien Palard 


New submission from Julien Palard :

Recent tables introduced in Doc/c-api/typeobj.rst are using columns spanning.

But columns spanning is not implemented in the sphinx text builder, resulting 
in:

$ cd Doc
$ sphinx-build -b text -d build/doctrees -W -D latex_elements.papersize= -Ea -A 
daily=1 -A switchers=1 . build/text
Running Sphinx v1.8.1
building [mo]: all of 0 po files
building [text]: all source files
updating environment: 475 added, 0 changed, 0 removed
reading sources... [100%] whatsnew/index
   
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [ 12%] c-api/typeobj  
   
Exception occurred:
  File 
"/home/mdk/.venvs/mdk/lib/python3.6/site-packages/sphinx/writers/text.py", line 
623, in visit_entry
raise NotImplementedError('Column or row spanning cells are '
NotImplementedError: Column or row spanning cells are not implemented.
The full traceback has been saved in /tmp/sphinx-err-3q24uv89.log, if you want 
to report the issue to the developers.
Please also report this if it was a user error, so that a better error message 
can be provided next time.
A bug report can be filed in the tracker at 
. Thanks!

we could either try to remove our column spannings (but they're usefull, first 
table, 2nd header line), either implement it sphinx-side.

--
assignee: docs@python
components: Documentation
messages: 328159
nosy: docs@python, mdk
priority: normal
severity: normal
status: open
title: Column or row spanning cells are not implemented.
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34969] Add --fast, --best to the gzip CLI

2018-10-20 Thread Serhiy Storchaka 


Serhiy Storchaka  added the comment:

I'm not sure those options are such useful. If you want to control more 
details, it is not hard to write a tiny Python script. Python is a programming 
language on the whole.

But if I add options for controlling the compression level, I would add options 
-1 ... -9. I never used verbose forms --fast and --best.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

2018-10-20 Thread Pablo Galindo Salgado 


Pablo Galindo Salgado  added the comment:

It seems that the problem is that the ServerProto of test_start_tls_server_1 
never receives a call to eof_received(). Weirdly enough it seems that if the 
HELLO_MSG is large enough (1024 * 1024), then the test always succeed. If we 
deactivate tls in the test, the test succeeds with any message lenght.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21363] io.TextIOWrapper always closes wrapped files

2018-10-20 Thread Mitar 


Mitar  added the comment:

I have a similar problem that text wrapper is closing the handle, and if I want 
to make a workaround, it also fails:

buffer = io.Bytes()
with io.TextIOWrapper(buffer, encoding='utf8') as text_buffer:
write_content_to(text_buffer)
text_buffer.flush()
text_buffer.detach()

Now this fails when context manager is trying to close the text_buffer with an 
error that it is already detached. If I do not detach it, then it closes buffer 
as well.

--
nosy: +mitar

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

2018-10-20 Thread Karthikeyan Singaravelan 


Karthikeyan Singaravelan  added the comment:

No problem, since this is a doc fix you can directly fork and edit on GitHub 
web UI. This requires CLA to be signed but no NEWS entry so it can be done from 
web UI and you can take wording from the commit 
8837dd092fe5ad5184889104e8036811ed839f98. I am just waiting for confirmation to 
make sure from my analysis is correct and this is a doc fix.

Thanks

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34962] make doctest does not pass :/

2018-10-20 Thread Karthikeyan Singaravelan 


Change by Karthikeyan Singaravelan :


--
pull_requests: +9350

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34562] cannot install versions 3.6.5+ on Windows

2018-10-20 Thread Steve Dower 


Steve Dower  added the comment:

Make sure your system is fully up to date and you have rebooted before/after 
installing Python.

That error means that system files are not installed correctly, which either 
means you are suffering corruption or you have pending installations waiting 
for a reboot.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34909] StrEnum subclasses cannot be created

2018-10-20 Thread Stéphane Wirtel 

Stéphane Wirtel  added the comment:

Hi Ned, good news (I hope the best for the wife of Ethan)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35032] Remove the videos from faq/Windows

2018-10-20 Thread miss-islington 


miss-islington  added the comment:


New changeset b53edb12f7176c58960d5ebaf48e740bea72a500 by Miss Islington (bot) 
in branch '2.7':
bpo-35032: Remove inaccessible videos from faq/Windows (GH-10004)
https://github.com/python/cpython/commit/b53edb12f7176c58960d5ebaf48e740bea72a500


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35032] Remove the videos from faq/Windows

2018-10-20 Thread miss-islington 


miss-islington  added the comment:


New changeset 76e8582fca17b89d2709ad7f4e1ad658ee839962 by Miss Islington (bot) 
in branch '3.6':
bpo-35032: Remove inaccessible videos from faq/Windows (GH-10004)
https://github.com/python/cpython/commit/76e8582fca17b89d2709ad7f4e1ad658ee839962


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35032] Remove the videos from faq/Windows

2018-10-20 Thread miss-islington 


miss-islington  added the comment:


New changeset 34a5ed5c0abbe75af2b75ad8bd03b68fd7e2f596 by Miss Islington (bot) 
in branch '3.7':
bpo-35032: Remove inaccessible videos from faq/Windows (GH-10004)
https://github.com/python/cpython/commit/34a5ed5c0abbe75af2b75ad8bd03b68fd7e2f596


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35032] Remove the videos from faq/Windows

2018-10-20 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +9349

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35032] Remove the videos from faq/Windows

2018-10-20 Thread miss-islington 

miss-islington  added the comment:


New changeset d262250d0732bdf36cb92091e37360cf8ff40f7c by Miss Islington (bot) 
(Stéphane Wirtel) in branch 'master':
bpo-35032: Remove inaccessible videos from faq/Windows (GH-10004)
https://github.com/python/cpython/commit/d262250d0732bdf36cb92091e37360cf8ff40f7c


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35032] Remove the videos from faq/Windows

2018-10-20 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +9348

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35032] Remove the videos from faq/Windows

2018-10-20 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +9347

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

2018-10-20 Thread Pablo Galindo Salgado 


Pablo Galindo Salgado  added the comment:

Building and testing the parent of dbf102271fcc316f353c7e0a283811b661d128f2 
always succeeds.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34977] Release Windows Store app containing Python

2018-10-20 Thread Steve Dower 


Steve Dower  added the comment:

(And I'll deal with that 1% at the PyPA sprints next weekend. We are due for a 
new pip insertion anyway, so I guess that'll come for 3.7.2.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34977] Release Windows Store app containing Python

2018-10-20 Thread Steve Dower 


Steve Dower  added the comment:

I'm 99% sure that with issue34725 I'll be able to make "pip --user" the default 
when using this install, as well as making the commands globally available 
(i.e. "python[3[.8]]", "pip[3[.8]]", "idle[3[.8]]" will work everywhere).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

2018-10-20 Thread Pablo Galindo Salgado 


Pablo Galindo Salgado  added the comment:

I think something is going on with the buildbot itself or the test has some 
race condition because that commit has been built before multiple times with no 
error. I am investigating in the buildbot itself.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

2018-10-20 Thread Pablo Galindo Salgado 


Pablo Galindo Salgado  added the comment:

Bisecting points to commit dbf102271fcc316f353c7e0a283811b661d128f2 as the 
dirst bad commit:

dbf102271fcc316f353c7e0a283811b661d128f2 is the first bad commit
commit dbf102271fcc316f353c7e0a283811b661d128f2
Author: Yury Selivanov 
Date:   Mon May 28 14:31:28 2018 -0400

bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() 
(GH-7130)

In this commit:

* Support BufferedProtocol in set_protocol() and start_tls()
* Fix proactor to cancel readers reliably
* Update tests to be compatible with OpenSSL 1.1.1
* Clarify BufferedProtocol docs
* Bump TLS tests timeouts to 60 seconds; eliminate possible race from 
start_serving
* Rewrite test_start_tls_server_1

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34909] StrEnum subclasses cannot be created

2018-10-20 Thread Ned Deily 

Ned Deily  added the comment:

Thanks, Stéphane, but I’ve already taken care of it. I’ll be closing the issue 
shortly. (And ditto on the best wishes, Ethan.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35030] Python 2.7 OrderedDict creates circular references

2018-10-20 Thread Karthikeyan Singaravelan 

Karthikeyan Singaravelan  added the comment:

Thanks for the report. I have converted the numpy code as a python helper and I 
am not sure if such a helper exists in the current test suite. Attaching the 
file that might help as a simple reproducer.

# On master no error

➜  cpython git:(master) ./python.exe ../backups/bpo35030.py

# upstream/2.7 branch

➜  cpython git:(2bad7acdfe) ✗ ./python.exe ../backups/bpo35030.py
Traceback (most recent call last):
  File "../backups/bpo35030.py", line 60, in 
del a
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/contextlib.py", 
line 24, in __exit__
self.gen.next()
  File "../backups/bpo35030.py", line 53, in assert_no_gc_cycles
) for o in objects_in_cycles
AssertionError: Reference cycles were found: 1 objects were collected, of which 
1 are shown below:
  list object with id=4475647608:
[,
 ,
 None]

--
nosy: +xtreak
Added file: https://bugs.python.org/file47885/bpo35030.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34576] [EASY doc] http.server, SimpleHTTPServer: warn users on security

2018-10-20 Thread Senthil Kumaran 


Senthil Kumaran  added the comment:

Fixed it here - https://github.com/python/cpython/pull/10005
And tested the rendering too 
https://screenshots.firefox.com/9Wlq9v1Y7M4DZBsG/localhost

Upon review / approval, I will merge this. 

Thank you!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34576] [EASY doc] http.server, SimpleHTTPServer: warn users on security

2018-10-20 Thread Senthil Kumaran 


Change by Senthil Kumaran :


--
assignee:  -> orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34576] [EASY doc] http.server, SimpleHTTPServer: warn users on security

2018-10-20 Thread Senthil Kumaran 


Change by Senthil Kumaran :


--
pull_requests: +9346

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34909] StrEnum subclasses cannot be created

2018-10-20 Thread Stéphane Wirtel 

Stéphane Wirtel  added the comment:

Hi Ethan and Ned,

I am not fluent with the code of the Enum, but maybe I could work on this issue 
and try to finish it.

Ethan, I am really sorry for your wife, take care of her.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

2018-10-20 Thread Pablo Galindo Salgado 


Change by Pablo Galindo Salgado :


--
title: test_asyncio test_start_tls_server_1 fails in -> test_asyncio 
test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35032] Remove the videos from faq/Windows

2018-10-20 Thread Stéphane Wirtel 

Change by Stéphane Wirtel :


--
keywords: +patch
pull_requests: +9345
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35032] Remove the videos from faq/Windows

2018-10-20 Thread Stéphane Wirtel 

New submission from Stéphane Wirtel :

In the FAQ of Windows, there are two references to external videos for the 
configuration of a dev environment for Windows, but these videos are no longer 
available because the domain name no longer exists.

--
assignee: docs@python
components: Documentation, Windows
messages: 328139
nosy: docs@python, matrixise, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Remove the videos from faq/Windows
versions: Python 2.7, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

2018-10-20 Thread Pablo Galindo Salgado 


Change by Pablo Galindo Salgado :


Removed file: https://bugs.python.org/file47284/traceback_filter.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35031] test_asyncio test_start_tls_server_1 fails in

2018-10-20 Thread Pablo Galindo Salgado 


New submission from Pablo Galindo Salgado :

https://buildbot.python.org/all/#/builders/168/builds/91
https://buildbot.python.org/all/#/builders/172/builds/41
https://buildbot.python.org/all/#/builders/173/builds/51

CURRENT-amd64% ./python -m test test_asyncio -m test_start_tls_server_1
Run tests sequentially
0:00:00 load avg: 3.36 [1/1] test_asyncio

Stderr:
/usr/home/pablo/cpython/Lib/test/test_asyncio/test_sslproto.py:497: 
DeprecationWarning: The loop argument is deprecated and scheduled for removal 
in Python 3.10.
  await asyncio.wait_for(
/usr/home/pablo/cpython/Lib/asyncio/sslproto.py:321: ResourceWarning: unclosed 
transport 
  warnings.warn(f"unclosed transport {self!r}", ResourceWarning,
Unhandled error in exception handler
context: {'message': 'Future exception was never retrieved', 'exception': 
ConnectionResetError(54, 'Connection reset by peer'), 'future': }
Traceback (most recent call last):
  File "/usr/home/pablo/cpython/Lib/test/libregrtest/runtest.py", line 179, in 
runtest_inner
test_runner()
  File "/usr/home/pablo/cpython/Lib/test/libregrtest/runtest.py", line 175, in 
test_runner
support.run_unittest(tests)
  File "/usr/home/pablo/cpython/Lib/test/support/__init__.py", line 2001, in 
run_unittest
_run_suite(suite)
  File "/usr/home/pablo/cpython/Lib/test/support/__init__.py", line 1920, in 
_run_suite
raise TestFailed(err)
test.support.TestFailed: Traceback (most recent call last):
  File "/usr/home/pablo/cpython/Lib/test/test_asyncio/test_sslproto.py", line 
504, in test_start_tls_server_1
self.loop.run_until_complete(run_main())
  File "/usr/home/pablo/cpython/Lib/asyncio/base_events.py", line 582, in 
run_until_complete
return future.result()
  File "/usr/home/pablo/cpython/Lib/test/test_asyncio/test_sslproto.py", line 
497, in run_main
await asyncio.wait_for(
  File "/usr/home/pablo/cpython/Lib/asyncio/tasks.py", line 457, in wait_for
raise exceptions.TimeoutError()
asyncio.exceptions.TimeoutError

Stderr:
/usr/home/pablo/cpython/Lib/test/test_asyncio/test_sslproto.py:497: 
DeprecationWarning: The loop argument is deprecated and scheduled for removal 
in Python 3.10.
  await asyncio.wait_for(
/usr/home/pablo/cpython/Lib/asyncio/sslproto.py:321: ResourceWarning: unclosed 
transport 
  warnings.warn(f"unclosed transport {self!r}", ResourceWarning,


During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/home/pablo/cpython/Lib/asyncio/base_events.py", line 1647, in 
call_exception_handler
self._exception_handler(self, context)
  File "/usr/home/pablo/cpython/Lib/test/test_asyncio/functional.py", line 22, 
in loop_exception_handler
self.loop.default_exception_handler(context)
AttributeError: 'NoneType' object has no attribute 'default_exception_handler'
/usr/home/pablo/cpython/Lib/test/support/__init__.py:1550: ResourceWarning: 
unclosed 
  gc.collect()
test test_asyncio failed -- Traceback (most recent call last):
  File "/usr/home/pablo/cpython/Lib/test/test_asyncio/test_sslproto.py", line 
504, in test_start_tls_server_1
self.loop.run_until_complete(run_main())
  File "/usr/home/pablo/cpython/Lib/asyncio/base_events.py", line 582, in 
run_until_complete
return future.result()
  File "/usr/home/pablo/cpython/Lib/test/test_asyncio/test_sslproto.py", line 
497, in run_main
await asyncio.wait_for(
  File "/usr/home/pablo/cpython/Lib/asyncio/tasks.py", line 457, in wait_for
raise exceptions.TimeoutError()
asyncio.exceptions.TimeoutError

Stderr:
/usr/home/pablo/cpython/Lib/test/test_asyncio/test_sslproto.py:497: 
DeprecationWarning: The loop argument is deprecated and scheduled for removal 
in Python 3.10.
  await asyncio.wait_for(
/usr/home/pablo/cpython/Lib/asyncio/sslproto.py:321: ResourceWarning: unclosed 
transport 
  warnings.warn(f"unclosed transport {self!r}", ResourceWarning,

test_asyncio failed in 1 min 749 ms

== Tests result: FAILURE ==

1 test failed:
test_asyncio

Total duration: 1 min 800 ms
Tests result: FAILURE

--
components: Tests, asyncio
messages: 328138
nosy: asvetlov, pablogsal, yselivanov
priority: normal
severity: normal
status: open
title: test_asyncio test_start_tls_server_1 fails in
type: behavior
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

2018-10-20 Thread Dmitry Kazakov 


Dmitry Kazakov  added the comment:

I asked for some input on this issue in January 
(https://mail.python.org/pipermail/python-dev/2018-January/151590.html). Since 
then an important PR was merged (https://github.com/python/cpython/pull/4793), 
however it mutates the traceback object. Should there be a way to hide frames 
while keeping the original traceback object intact? If not, this issue should 
probably be closed. Otherwise I would appreciate a review of the PR.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34995] functools.cached_property does not maintain the wrapped method's __isabstractmethod__

2018-10-20 Thread INADA Naoki 


INADA Naoki  added the comment:

I agree with Serhiy.

For static hinting, `@property` should be enough.
I think tools like mypy should support this pattern:

class MyABC(metaclass=ABCMeta):
@property
@abstractmethod
def myprop(self):
...

class MyConcrete(MyABC):
@cached_property
def myprop(self):
return self._some_heavy_work()

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35030] Python 2.7 OrderedDict creates circular references

2018-10-20 Thread tzickel 


Change by tzickel :


--
keywords: +patch
pull_requests: +9344
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35030] Python 2.7 OrderedDict creates circular references

2018-10-20 Thread Serhiy Storchaka 


Change by Serhiy Storchaka :


--
title: Python 2.7 OrderedDict leaks memory -> Python 2.7 OrderedDict creates 
circular references

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35030] Python 2.7 OrderedDict leaks memory

2018-10-20 Thread Serhiy Storchaka 


Change by Serhiy Storchaka :


--
assignee:  -> rhettinger
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33712] OrderedDict can set an exception in tp_clear

2018-10-20 Thread Serhiy Storchaka 


Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33712] OrderedDict can set an exception in tp_clear

2018-10-20 Thread Serhiy Storchaka 


Serhiy Storchaka  added the comment:


New changeset f1b90e3922e9d218cf1f6c94ab98874c1752bdf3 by Serhiy Storchaka in 
branch '3.6':
bpo-33712: OrderedDict only creates od_fast_nodes cache if needed (GH-7349). 
(GH-10001)
https://github.com/python/cpython/commit/f1b90e3922e9d218cf1f6c94ab98874c1752bdf3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34839] doctest: Change example under warnings section

2018-10-20 Thread Julien Palard 


Change by Julien Palard :


--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34839] doctest: Change example under warnings section

2018-10-20 Thread Julien Palard 

Julien Palard  added the comment:


New changeset 0522fd81dc6e3482c2d4c8719f1f85ad5924eede by Julien Palard 
(Stéphane Wirtel) in branch 'master':
bpo-34839: Add a 'before 3.6' in the section 'warnings' of doctest (GH-9736)
https://github.com/python/cpython/commit/0522fd81dc6e3482c2d4c8719f1f85ad5924eede


--
nosy: +mdk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35030] Python 2.7 OrderedDict leaks memory

2018-10-20 Thread tzickel 


New submission from tzickel :

https://github.com/requests/requests/issues/4553#issuecomment-431514753

It was fixed in Python 3 by using weakref, but not backported to Python 2.

Also might be nice to somehow to that leak test in more places to detect such 
issues ?

--
components: Library (Lib)
messages: 328133
nosy: rhettinger, tzickel
priority: normal
severity: normal
status: open
title: Python 2.7 OrderedDict leaks memory
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33712] OrderedDict can set an exception in tp_clear

2018-10-20 Thread Serhiy Storchaka 


Change by Serhiy Storchaka :


--
pull_requests: +9343

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33712] OrderedDict can set an exception in tp_clear

2018-10-20 Thread Serhiy Storchaka 


Serhiy Storchaka  added the comment:


New changeset 861d34eee345956cbb0940fa676bfb7ff492999d by Serhiy Storchaka in 
branch '3.7':
bpo-33712: OrderedDict only creates od_fast_nodes cache if needed (GH-7349). 
(GH-1)
https://github.com/python/cpython/commit/861d34eee345956cbb0940fa676bfb7ff492999d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33237] Improve AttributeError message for partially initialized module

2018-10-20 Thread Serhiy Storchaka 


Serhiy Storchaka  added the comment:

Example:

$ cat foo.py
import bar
bar.baz
$ cat bar.py
import foo
baz = 2
$ ./python foo.py 
Traceback (most recent call last):
  File "foo.py", line 1, in 
import bar
  File "/home/serhiy/py/cpython/bar.py", line 1, in 
import foo
  File "/home/serhiy/py/cpython/foo.py", line 2, in 
bar.baz
AttributeError: module 'bar' has no attribute 'baz'

Patched:

$ ./python foo.py 
Traceback (most recent call last):
  File "foo.py", line 1, in 
import bar
  File "/home/serhiy/py/cpython/bar.py", line 1, in 
import foo
  File "/home/serhiy/py/cpython/foo.py", line 2, in 
bar.baz
AttributeError: partially initialized module 'bar' has no attribute 'baz' (most 
likely due to a circular import)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33712] OrderedDict can set an exception in tp_clear

2018-10-20 Thread Serhiy Storchaka 


Change by Serhiy Storchaka :


--
pull_requests: +9342

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35029] Convert SyntaxWarning exception raised at code generation time to a SyntaxError

2018-10-20 Thread Serhiy Storchaka 


Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +9341
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35029] Convert SyntaxWarning exception raised at code generation time to a SyntaxError

2018-10-20 Thread Serhiy Storchaka 


New submission from Serhiy Storchaka :

SyntaxError contains more useful information than SyntaxWarning, and 
SyntaxError is special cased in tracebacks for better reporting. When 
SyntaxWarning is raised as an exception, the error report doesn't contain 
information about the source. It is hard to find the source of a SyntaxWarning. 
Currently:

$ ./python syntaxwarning.py 
syntaxwarning.py:1: SyntaxWarning: assertion is always true, perhaps remove 
parentheses?
  x = 1; assert (x, "msg")
$ ./python -We syntaxwarning.py 
SyntaxWarning: assertion is always true, perhaps remove parentheses?
$ ./python -m syntaxwarning
/home/serhiy/py/cpython3.7/syntaxwarning.py:1: SyntaxWarning: assertion is 
always true, perhaps remove parentheses?
  x = 1; assert (x, "msg")
$ ./python -We -m syntaxwarning
Traceback (most recent call last):
  File "/home/serhiy/py/cpython3.7/Lib/runpy.py", line 183, in 
_run_module_as_main
mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/home/serhiy/py/cpython3.7/Lib/runpy.py", line 153, in 
_get_module_details
code = loader.get_code(mod_name)
  File "", line 860, in get_code
  File "", line 791, in source_to_code
  File "", line 219, in _call_with_frames_removed
SyntaxWarning: assertion is always true, perhaps remove parentheses?

The proposed PR replaces SyntaxWarning with a SyntaxError if the former was 
raised as an exception:

$ ./python -We syntaxwarning.py 
  File "syntaxwarning.py", line 1
x = 1; assert (x, "msg")
   ^
SyntaxError: assertion is always true, perhaps remove parentheses?
$ ./python -We -m syntaxwarning
Traceback (most recent call last):
  File "/home/serhiy/py/cpython/Lib/runpy.py", line 183, in _run_module_as_main
mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/home/serhiy/py/cpython/Lib/runpy.py", line 153, in _get_module_details
code = loader.get_code(mod_name)
  File "", line 909, in get_code
  File "", line 839, in source_to_code
  File "", line 219, in _call_with_frames_removed
  File "/home/serhiy/py/cpython/syntaxwarning.py", line 1
x = 1; assert (x, "msg")
   ^
SyntaxError: assertion is always true, perhaps remove parentheses?

Similar replacement is already performed for warnings raised for unrecognized 
escape sequences at parsing time (see issue32912).

--
components: Interpreter Core
messages: 328130
nosy: serhiy.storchaka
priority: normal
severity: normal
status: open
title: Convert SyntaxWarning exception raised at code generation time to a 
SyntaxError
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35027] distutils.core.setup does not raise TypeError when if classifiers, keywords and platforms fields are not specified as a list

2018-10-20 Thread Tilman Krummeck 


Tilman Krummeck  added the comment:

I guess it's now or never. Give me some time to check the developer's guide and 
I'll submit a doc fix for this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34574] OrderedDict iterators are exhausted during pickling

2018-10-20 Thread Serhiy Storchaka 


Serhiy Storchaka  added the comment:

Thank your Sergey for your report and fix.

--
components: +Extension Modules
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34574] OrderedDict iterators are exhausted during pickling

2018-10-20 Thread miss-islington 


miss-islington  added the comment:


New changeset 0d3dd9fe0d2565f09f70d8ea7341dfd88e6bd380 by Miss Islington (bot) 
in branch '3.6':
bpo-34574: Prevent OrderedDict iterators from exhaustion during pickling. 
(GH-9051)
https://github.com/python/cpython/commit/0d3dd9fe0d2565f09f70d8ea7341dfd88e6bd380


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com