[issue35263] Add None handling for get_saved() in IDLE

[Terry J. Reedy]

Change by Terry J. Reedy :


--
resolution:  -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder:  -> IDLE's close fails when io.filename set to None

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35479] multiprocessing.Pool.join() always takes at least 100 ms

[శ్రీనివాస్ రెడ్డి తాటిపర్తి]

Change by Srinivas  Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) 
:


--
pull_requests: +15744
pull_request: https://github.com/python/cpython/pull/10564

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35379] IDLE's close fails when io.filename set to None

[శ్రీనివాస్ రెడ్డి తాటిపర్తి]

Change by Srinivas  Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) 
:


--
keywords: +patch
pull_requests: +15743
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/10564

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38128] IDLE undo calls get_saved() when set to None

[Terry J. Reedy]

Terry J. Reedy  added the comment:

None.get_saved (closing shell) was reported in #35263.
None.filename (closing editor) was reported in #35379.
Up-to-date reports in one page were a bit helpful.

--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> IDLE's close fails when io.filename set to None

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38160] Add a "PyInterpreterState *" field to PyTypeObject.

[Stefan Behnel]

Stefan Behnel  added the comment:

I think access to the global module state is the most critical for an 
extension, probably by far. A direct pointer to the interpreter state from 
every type feels like an optimisation that may be premature at this point. 
Modules should have that reference, though, as long as we assume a unique 
interpreter for each module instance (which we currently do).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37806] Infinite recursion with typing.get_type_hints

[Stéphane Wirtel]

Change by Stéphane Wirtel :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35379] IDLE's close fails when io.filename set to None

[Terry J. Reedy]

Terry J. Reedy  added the comment:

The get_saved tracebacks reported in #35263 and #38128 are the same except for 
line numbers. The more recent, from 3 days ago on Mac.
Exception in Tkinter callback
Traceback (most recent call last):
  File 
"/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/tkinter/__init__.py",
 line 1883, in __call__
return self.func(*args)
  File 
"/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/idlelib/multicall.py",
 line 176, in handler
r = l[i](event)
  File 
"/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/idlelib/filelist.py",
 line 54, in close_all_callback
reply = edit.close()
  File 
"/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/idlelib/pyshell.py",
 line 1008, in close
return EditorWindow.close(self)
  File 
"/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/idlelib/editor.py",
 line 1077, in close
reply = self.maybesave()
  File 
"/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/idlelib/outwin.py",
 line 94, in maybesave
return 'yes' if self.get_saved() else 'no'
  File 
"/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/idlelib/editor.py",
 line 1010, in get_saved
return self.undo.get_saved()
AttributeError: 'NoneType' object has no attribute 'get_saved'

None.filename from a day ago is also the same except for line numbers.  pyshell 
line 1008 is in PyShell(OutputWindow(EditorWindow)) so get_saved must result 
from closing Shell.  pyshell line 309 is in PyShellEditorWindow(EditorWindow) 
so must come from closing an editor window.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21872] LZMA library sometimes fails to decompress a file

[Ma Lin]

Ma Lin  added the comment:

Some memos:

1, In liblzma, these missing bytes were copied inside `dict_repeat` function:

 788 case SEQ_COPY:
 789 // Repeat len bytes from distance of rep0.
 790 if (unlikely(dict_repeat(, rep0, ))) {

See liblzma's source code (xz-5.2 branch):
https://git.tukaani.org/?p=xz.git;a=blob;f=src/liblzma/lzma/lzma_decoder.c

2, Above replies said xz's command line tools can extract the problematic files 
successfully.

This is because xz checks `if (avail_out == 0)` first, then checks `if 
(avail_in == 0)`
See `uncompress` function in this source code (xz-5.2 branch):
https://git.tukaani.org/?p=xz.git;a=blob;f=src/xzdec/xzdec.c;hb=refs/heads/v5.2

This check order just avoids the problem.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38167] O_DIRECT read fails with 4K mmap buffer

[Paul]

Paul  added the comment:

This is the platform that I'm working on as well as the failure.  I have a 
review out for a fix.

# uname -a
Linux init129-13 3.10.0-957.el7.x86_64 x86_64 x86_64 x86_64 GNU/Linux
# python3.7 directread.py
Traceback (most recent call last):
  File "small.py", line 7, in 
fo.readinto(m)
OSError: [Errno 22] Invalid argument

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38167] O_DIRECT read fails with 4K mmap buffer

[Josh Rosenberg]

Josh Rosenberg  added the comment:

Works just fine for me on 3.7.3 on Ubuntu, reading 4096 bytes. How is it 
failing for you? Is an exception raised?

It does seem faintly dangerous to explicitly use O_DIRECT when you're wrapping 
it in a buffered reader that doesn't know it has to read in units matching the 
minimum block size (file system dependent on older kernels, 512 bytes in Linux 
kernel 2.6+); BufferedIOBase.readinto is explicitly documented to potentially 
issue multiple read calls (readinto1 guarantees it won't do that at least).

--
nosy: +josh.r

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38105] hash collision when hash(x) == -2 causes many calls to __eq__

[Tim Peters]

Tim Peters  added the comment:

Some results of the "add perturb shifted left 1 instead" approach.  These come 
from using an old pile of Python code I have that allows for easy investigation 
of different collision probe strategies.

- As expected, because it has no fixed points, there are no bad cases in a 
dict/set with only two elements, _unless_ you're searching for a third distinct 
element.  Ironically, if they all, e.g., have hash code -2, no problem at all:  
then 3 probes settle it.  But if they're "random" hash codes (hashes of strings 
are good enough for testing this), then every now and again it can take up to 
10 probes.  It all depends on accidents of how the various bits get fed in 
across perturb shifts.  However, with random hashes, searching for an element 
that's there never takes more than 2 probes in the new way (again because 
there's never a fixed point).  Under the current way I've seen it take as many 
as 6.

- On average, with random hashes and 2 elements in an 8-slot table, the average 
number of probes with a successful search fall from 1.07 to 1.06, and on an 
unsuccessful search from 1.33 to 1.30.  Theoretically ideal ("uniform hashing" 
- each object visits the slots in its own random permutation of slot order) are 
1.06/1.29.

- Random hashes in an 8-slot table:  average # probes for successful and 
failing searches

1 entry
current 1.00 1.14
new 1.00 1.12
ideal   1.00 1.12

2 entries
current 1.07 1.33
new 1.06 1.30
ideal   1.06 1.29

3 entries
current 1.16 1.60
new 1.14 1.56
ideal   1.14 1.50

4 entries
current 1.27 2.00
new 1.25 1.93
ideal   1.23 1.80

5 entries
current 1.42 2.66
new 1.38 2.56
ideal   1.34 2.25 

Note:  those aren't typos ;-)  For example, if there's only 1 entry, how can it 
take more than one probe for a failing search?  Easy!  The first probe hits the 
only entry, it doesn't match, and so it takes a second probe to be sure the new 
element isn't present.  In a perfect world, that would happen 12.5% of the time 
(1 in 8).  But in the presence of fixed points ("current"), it can take _more_ 
than 2.  The most probes I saw in "current" was 6 (it hit the only entry 5 
times in a row).

- That account ends at 5 entries because we don't let an 8-slot table contain 
more than 5 entries.

- Small as those differences are, they get smaller for larger tables.  By the 
time we get to 1024 slots, three digits aren't enough to distinguish "current" 
from "ideal".  Even at 256 slots, it's just 1-or-2 ULP wobble.

So that's the good side:

- Eliminates the "surprises" in this bug report.

- For more realistic ordinary cases ("random" hashes), for small tables it buys 
small but very consistent reductions in average probes needed for both 
successful and failing searches.  It also, in general (but not spelled out 
above), cuts the rare longest probe chains.

The bad side:

- For small tables we're talking about nanoseconds regardless.

- That adding a new shift is "free" relies on that x86's LEA instruction 
supports implicitly shifting an addend, and on compilers exploiting that.

- Some cases will get worse.  That's just pragmatic fact.  The intuition here 
is that `perturb` is _trying_ to get high-order hash bits into play, and 
"current" gets 5 more into play on each iteration.  But "new" shifts perturb 
left 1 before adding, preventing them from having any effect at all on the last 
new bit.

This can have seemingly chaotic effects.  For example, with entries of the form 
i*1024 in a table with 2**13 slots and 5,461 entries ("full" - the most we 
allow),

current 3.09 5.52
new 3.22 4.78
ideal   1.65 3.00

So the change hurts successful lookups but helps failing ones.  For a full 
table with 16 slots, the reverse.  For a full table with 2**10 slots, it hurts 
both.

Bottom line?  You tell me :-)  It's just not compelling to me either way.  If I 
were writing the code from scratch, I'd do it.  But because of seemingly 
chaotic effects talked about near the end above, there's always a danger _some_ 
code important to someone will take a hit.  It's just as true that their code 
will enjoy an unexpected speed boost, but nobody screams about those ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37806] Infinite recursion with typing.get_type_hints

[hongweipeng]

hongweipeng  added the comment:

Sorry, the link is https://github.com/python/cpython/pull/15400 .

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37806] Infinite recursion with typing.get_type_hints

[hongweipeng]

hongweipeng  added the comment:

This report can be closed, PR #15400 has solved this issue.

--
nosy: +hongweipeng

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33095] Cross-reference isolated mode from relevant locations

[Nick Coghlan]

Nick Coghlan  added the comment:


New changeset bdd6945d4dbd1fe6a7fcff95f7d6908db7d791a1 by Nick Coghlan (Xtreak) 
in branch 'master':
bpo-33095: Add reference to isolated mode in -m and script option (GH-7764)
https://github.com/python/cpython/commit/bdd6945d4dbd1fe6a7fcff95f7d6908db7d791a1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38052] Include sspipe Module with Core Python

[Guido van Rossum]

Guido van Rossum  added the comment:

I'm going to close this. I find your example hard to understand. If you want to 
discuss this on python-ideas or discourse, go ahead, but this is not ready for 
a PEP or for stdlib inclusion.

--
resolution:  -> wont fix
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38167] O_DIRECT read fails with 4K mmap buffer

[Paul]

Change by Paul :


--
pull_requests: +15742
pull_request: https://github.com/python/cpython/pull/16131

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38167] O_DIRECT read fails with 4K mmap buffer

[Paul]

Change by Paul :


--
keywords: +patch
pull_requests: +15741
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/16130

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38167] O_DIRECT read fails with 4K mmap buffer

[Paul]

New submission from Paul :

The following Python3 script fails.

import mmap
import os

fd = os.open(path_to_file, os.O_DIRECT | os.O_RDWR)
fo = os.fdopen(fd, 'rb+')
m = mmap.mmap(-1, 4096)
fo.readinto(m)

But it worked for Python2.  It also works for any other multiple of 4K. For 
example:

m = mmap.mmap(-1, 8192)
fo.readinto(m)

Is fine!

--
components: IO
messages: 352397
nosy: yoyoyopcp
priority: normal
severity: normal
status: open
title: O_DIRECT read fails with 4K mmap buffer
type: behavior
versions: Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35727] sys.exit() in a multiprocessing.Process does not align with Python behavior

[Christopher Hunt]

Christopher Hunt  added the comment:

> I believe the mentality behind multiprocessing.Process triggering an exit 
> code of 1 when sys.exit() is invoked inside its process is to indicate a 
> non-standard exit out of its execution.

Can I ask what this is based on? I did a pretty good amount of digging but 
didn't find any justification for it. It just seems like a simple oversight to 
me.

> There may yet be other side effects that could be triggered by having a 
> sys.exit(0) translate into an exit code of 0 from the Process's process -- 
> and we might not notice them with the current tests.

This is definitely a behavior change and will break any code that currently 
relies on `sys.exit(None)` or `sys.exit()` exiting with a non-zero exit code 
from a multiprocessing.Process. The fact that all documentation indicates that 
`sys.exit(None)` or `sys.exit()` results in a 0 exit code in normal Python 
(with no documentation on it related to multiprocessing) makes me think that 
any code relying on this behavior is subtly broken, however. Any impacted user 
can update their code and explicitly pass 1 to `sys.exit`, which should be 
forward and backwards compatible.

> Was there a particular use case that motivates this suggested change?

I have a wrapper library that invokes arbitrary user code and attempts to 
behave as if that code was executed in a vanilla Python process, to include 
propagating the correct exit code.

Currently I have a workaround here: 
https://github.com/chrahunt/quicken/blob/2dd00a5f024d7b114b211aad8a2618ec8f101956/quicken/_internal/server.py#L344-L353,
 but it would be nice to get rid of it in 5-6 years if this fix gets in and the 
non-conformant Python versions fall out of support. :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38052] Include sspipe Module with Core Python

[Juan Telleria]

Juan Telleria  added the comment:

Even if it is not currently mainstream, piping (tidy and readable code, left to 
right), should be a foundation, not just a module.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38035] shared_semaphores cannot be shared across unrelated processes

[Ned Deily]

Change by Ned Deily :


--
nosy:  -ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38052] Include sspipe Module with Core Python

[Guido van Rossum]

Guido van Rossum  added the comment:

Sorry to burst your bubble, but I don't see a reason to include this in the 
stdlib. Is there any reason why it can't be a dependency living on PyPI just 
like the packages you used in the example (numpy, pandas)?

Surely this isn't a category killer? You have *53* stars on GitHub. I think 
you're misunderstanding the purpose of the stdlib.

--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38166] ast identifies incorrect column for compound attribute lookups

[Justin McCann]

New submission from Justin McCann :

This issue is related to https://github.com/microsoft/vscode-python/issues/7327 
and https://github.com/PyCQA/pylint/issues/3103

For compound attribute access in variable references like a.b.c.d, the AST 
reports the column of the first variable/attribute in the sequence instead of 
the specific attribute location. For example, the location of  c is reported as 
column 0 (a) and not column 4 (c).

Here's the AST test case provided by a pylint developer in a comment on pylint 
issue 3103; I confirmed the behavior is the same in python 3.8.0b4.
```
$ python3.8
Python 3.8.0b4 (v3.8.0b4:d93605de72, Aug 29 2019, 21:47:47)
[Clang 6.0 (clang-600.0.57)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import ast
>>> body = ast.parse('''
... print(x.item.akey > 2)
... ''')
>>> # x.item
... x_item = body.body[0].value.args[0].left.value
>>> print(x_item, x_item.attr, x_item.col_offset)
<_ast.Attribute object at 0x10a7751f0> item 6
>>> # x.item.akey
... print(x_item.value, x_item.value.col_offset) .  ### probably should be 8
<_ast.Name object at 0x10a775280> 6
```

Related issues:
* https://bugs.python.org/issue1440601 Add col information to parse & ast nodes
* https://bugs.python.org/issue10769 ast: provide more useful range information


Here is the resulting confusion when you use this output in pylint (and then 
VSCode highlights only "x" since it's the variable that starts in column 0):

Original pylint/vscode testcase:
```
class TestMe:
def __init__(self):
self.item = {'akey': 42}
self.again = self

x = TestMe()
### pylint error message here is
###testme.py:11:6: E1101: Instance of 'dict' has no 'akey' member 
(no-member)
### The problem is with `x.item`, but pylint shows the column for `x`
print(x.item.akey > 2)

print(x.again.item.doesnotexist)
```

Current behavior
$ pylint testme.py  -rn -sn
* Module testme
testme.py:10:6: E1101: Instance of 'dict' has no 'akey' member (no-member)
testme.py:12:6: E1101: Instance of 'dict' has no 'doesnotexist' member 
(no-member)

Expected behavior
$ pylint testme.py  -rn -sn
* Module testme
testme.py:10:8: E1101: Instance of 'dict' has no 'akey' member (no-member)
testme.py:12:14: E1101: Instance of 'dict' has no 'doesnotexist' member 
(no-member)

$ pylint --version output
pylint 2.3.1
astroid 2.2.5
Python 3.7.4 (default, Jul 9 2019, 18:13:23)
[Clang 10.0.1 (clang-1001.0.46.4)]

--
components: Library (Lib)
messages: 352393
nosy: Justin McCann
priority: normal
severity: normal
status: open
title: ast identifies incorrect column for compound attribute lookups
type: behavior
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36274] http.client cannot send non-ASCII request lines

[Matej Cepl]

Change by Matej Cepl :


--
nosy: +mcepl

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5396] os.read not handling O_DIRECT flag

[Michael Mol]

Michael Mol  added the comment:

I wound up writing it in C++ instead, and my then-employer eventually opened my 
code. https://github.com/VirtualInterconnect/diskstress

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37953] Fix ForwardRef equality checks

[Ivan Levkivskyi]

Change by Ivan Levkivskyi :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37953] Fix ForwardRef equality checks

[miss-islington]

miss-islington  added the comment:


New changeset e91edfed4214dbae17b8906b5dc7778769aac620 by Miss Islington (bot) 
in branch '3.8':
bpo-37953: Fix ForwardRef hash and equality checks (GH-15400)
https://github.com/python/cpython/commit/e91edfed4214dbae17b8906b5dc7778769aac620


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

[miss-islington]

Change by miss-islington :


--
pull_requests: +15740
pull_request: https://github.com/python/cpython/pull/16129

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset bf169915ecdd42329726104278eb723a7dda2736 by Serhiy Storchaka in 
branch 'master':
bpo-38005: Fixed comparing and creating of InterpreterID and ChannelID. 
(GH-15652)
https://github.com/python/cpython/commit/bf169915ecdd42329726104278eb723a7dda2736


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37953] Fix ForwardRef equality checks

[Ivan Levkivskyi]

Ivan Levkivskyi  added the comment:


New changeset e082e7cbe4a934b86f7a07354d97d4e14a9dd46a by Ivan Levkivskyi 
(plokmijnuhby) in branch 'master':
bpo-37953: Fix ForwardRef hash and equality checks (GH-15400)
https://github.com/python/cpython/commit/e082e7cbe4a934b86f7a07354d97d4e14a9dd46a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37953] Fix ForwardRef equality checks

[miss-islington]

Change by miss-islington :


--
pull_requests: +15739
pull_request: https://github.com/python/cpython/pull/16128

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38152] AST change introduced tons of reference leaks

[Eddie Elizondo]

Change by Eddie Elizondo :


--
keywords: +patch
pull_requests: +15738
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/16127

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38152] AST change introduced tons of reference leaks

[Eddie Elizondo]

Eddie Elizondo  added the comment:

I have a fix for this coming up.

--
nosy: +eelizondo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33214] join method for list and tuple

[Josh Rosenberg]

Josh Rosenberg  added the comment:

Note that all of Serhiy's examples are for a known, fixed number of things to 
concatenate/union/merge. str.join's API can be used for that by wrapping the 
arguments in an anonymous tuple/list, but it's more naturally for a variable 
number of things, and the unpacking generalizations haven't reached the point 
where:

[*seq for seq in allsequences]

is allowed.

list(itertools.chain.from_iterable(allsequences))

handles that just fine, but I could definitely see it being convenient to be 
able to do:

[].join(allsequences)

That said, a big reason str provides .join is because it's not uncommon to want 
to join strings with a repeated separator, e.g.:

# For not-really-csv-but-people-do-it-anyway
','.join(row_strings)

# Separate words with spaces
' '.join(words)

# Separate lines with newlines
'\n'.join(lines)

I'm not seeing even one motivating use case for list.join/tuple.join that would 
actually join on a non-empty list or tuple ([None, 'STOP', None] being rather 
contrived). If that's not needed, it might make more sense to do this with an 
alternate constructor (a classmethod), e.g.:

list.concat(allsequences)

which would avoid the cost of creating an otherwise unused empty list (the 
empty tuple is a singleton, so no cost is avoided there). It would also work 
equally well with both tuple and list (where making list.extend take varargs 
wouldn't help tuple, though it's a perfectly worthy idea on its own).

Personally, I don't find using itertools.chain (or its from_iterable alternate 
constructor) all that problematic (though I almost always import it with from 
itertools import chain to reduce the verbosity, especially when using 
chain.from_iterable). I think promoting itertools more is a good idea; right 
now, the notes on concatenation for sequence types mention str.join, 
bytes.join, and replacing tuple concatenation with a list that you call extend 
on, but doesn't mention itertools.chain at all, which seems like a failure to 
make the best solution the discoverable/obvious solution.

--
nosy: +josh.r

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38165] freezes when loading a program on imports

[Evgeniy Mischuk]

Evgeniy Mischuk  added the comment:

best interface site
dont care about my eyes

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38165] freezes when loading a program on imports

[Evgeniy Mischuk]

Evgeniy Mischuk  added the comment:

https://drive.google.com/file/d/1tJhgN9mwyPrgQc2YCmuwKioH-65Y42l-/view?usp=sharing

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38165] freezes when loading a program on imports

[Evgeniy Mischuk]

Change by Evgeniy Mischuk :


--
keywords: +patch
pull_requests: +15737
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/16126

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38165] freezes when loading a program on imports

[Evgeniy Mischuk]

New submission from Evgeniy Mischuk :

freezes when loading a program on imports because user rights are insufficient
python installed on c:/ and requires administrator rights
when run program from not root user

--
components: Windows
messages: 352384
nosy: Evgeniy Mischuk, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: freezes when loading a program on imports
type: performance
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34706] Signature.from_callable sometimes drops subclassing

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:


New changeset cf25765cf79a5bd19ba90a535a51367d6177f2bc by Stéphane Wirtel (Miss 
Islington (bot)) in branch '3.8':
bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108) 
(GH-16113)
https://github.com/python/cpython/commit/cf25765cf79a5bd19ba90a535a51367d6177f2bc


--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34706] Signature.from_callable sometimes drops subclassing

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:


New changeset 3906920cfecba83d529f8755f5ec2e53e49f9e90 by Stéphane Wirtel (Miss 
Islington (bot)) in branch '3.7':
bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108) 
(GH-16114)
https://github.com/python/cpython/commit/3906920cfecba83d529f8755f5ec2e53e49f9e90


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24416] Have date.isocalendar() return a structseq instance

[Paul Ganssle]

Paul Ganssle  added the comment:

The current state of the PR doesn't hinge on the pure Python implementation, we 
went with a very simple tuple subclass to keep the two more closely in sync and 
because we don't need any of the additional functionality that namedtuple 
brings, but if it were any more complicated than what we did we probably would 
have just gone with a namedtuple.

The only thing that's holding things up now is that we're working out a way to 
maintain the ability to pickle the object without making the class public. This 
is not really a hard requirement, but I'd like to give it an honest effort 
before calling it a day and just relying on "it's not in __all__, therefore 
it's not public." (I should note that we can only take that approach after 
issue #38155 is resolved, which is another reason for the delay).

In any case, the bulk of the conversation on the implementation has been taking 
place on GH-15633, sorry for the split discussion location, folks.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32790] Keep trailing zeros in precision for string format option g

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:

Thank you for your PR and this issue, the PR is merged into master, 3.8 and 3.7.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32790] Keep trailing zeros in precision for string format option g

[miss-islington]

miss-islington  added the comment:


New changeset e6b14c026fd9045a0d460b62dbcb512fca4c64ec by Miss Islington (bot) 
in branch '3.8':
bpo-32790: Add info about alt format using GH- for 'g' in chart (GH-6624)
https://github.com/python/cpython/commit/e6b14c026fd9045a0d460b62dbcb512fca4c64ec


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38162] Import Long Load

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch
pull_requests: +15736
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/16120

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32790] Keep trailing zeros in precision for string format option g

[miss-islington]

miss-islington  added the comment:


New changeset 77878cadc58aaca234482dffbb5fe89c74c026fa by Miss Islington (bot) 
in branch '3.7':
bpo-32790: Add info about alt format using GH- for 'g' in chart (GH-6624)
https://github.com/python/cpython/commit/77878cadc58aaca234482dffbb5fe89c74c026fa


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24416] Have date.isocalendar() return a structseq instance

[Tim Peters]

Tim Peters  added the comment:

I agree with Raymond here:  using collections.namedtuple is fine in the pure 
Python version.  Since Raymond checked in doc changes to purge the phrase 
"struct sequences" (thanks again for that!), it's consistent with everything 
else now for the new datetime docs to say that this function returns a "named 
tuple" (the docs are now clear that there may be more than one implementation 
of such a thing, and that the only things you can _rely_ on are that they 
support named element access in addition to tuple methods).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32790] Keep trailing zeros in precision for string format option g

[miss-islington]

Change by miss-islington :


--
pull_requests: +15734
pull_request: https://github.com/python/cpython/pull/16121

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32790] Keep trailing zeros in precision for string format option g

[miss-islington]

Change by miss-islington :


--
pull_requests: +15735
pull_request: https://github.com/python/cpython/pull/16122

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32790] Keep trailing zeros in precision for string format option g

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:


New changeset d44542f9a231bf725ecd82eb640a672c759a8227 by Stéphane Wirtel 
(bchhabra2490) in branch 'master':
bpo-32790: Add info about alt format using # for 'g' in chart (GH-6624)
https://github.com/python/cpython/commit/d44542f9a231bf725ecd82eb640a672c759a8227


--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:

Thank you, I close this issue.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33082] multiprocessing docs bury very important 'callback=' args

[Davin Potts]

Davin Potts  added the comment:

I appreciate the functionality offered by the callbacks and have found good 
uses for them, as Chad clearly does/has.  That said, the thought of expanding 
the documentation on the callbacks had not come up for me.

Reading through the proposed changes to the prose explanations, the choice of 
words has changed but not significantly and virtually no new concepts are being 
explained.

I agree with Julien that the docs should stay as they are.

Chad:  Thank you for advocating for things you think more people need to know 
about even if we do not update the docs this time.

--
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38163] AsyncMock child mocks should detect their type

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24416] Have date.isocalendar() return a structseq instance

[Raymond Hettinger]

Raymond Hettinger  added the comment:

It's okay for the pure python equivalent to use collections.namedtuple so long 
as the C code uses structseq. As Serhiy points out, there is no need to 
reinvent the wheel.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38164] polishing asyncio Streams API

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38164] polishing asyncio Streams API

[Yury Selivanov]

Change by Yury Selivanov :


--
title: poloshing asyncio Streams API -> polishing asyncio Streams API

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38164] poloshing asyncio Streams API

[Yury Selivanov]

New submission from Yury Selivanov :

Summary of discussion at https://github.com/python-trio/trio/issues/1208:

* `asyncio.Stream.write()` will start throwing a `DeprecationWarning` asking 
people to add an `await` if they didn't;

* `asyncio.Stream.close()` will start throwing a `DeprecationWarning` asking 
people to add an `await` if they didn't;

* `asyncio.Stream.drain()` & `asyncio.Stream.wait_closed()` will start throwing 
a `DeprecationWarning` telling about a scheduled removal (in Python 3.12) when 
used on `Process.std*` streams;

* `asyncio.Stream.drain()` & `asyncio.Stream.wait_closed()` will not work at 
all on Streams created via new 3.8 APIs: `connect()` & `StreamServer`.

--
assignee: asvetlov
components: asyncio
messages: 352372
nosy: asvetlov, lukasz.langa, yselivanov
priority: release blocker
severity: normal
stage: needs patch
status: open
title: poloshing asyncio Streams API
type: behavior
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:


New changeset 53ff2ca89feb90c1fbf2605321bcef35b457f16f by Stéphane Wirtel in 
branch '3.8':
[3.8] bpo-38150: Fix refleak in the finalizer of a _testcapimodule type 
(GH-16115) (GH-16118)
https://github.com/python/cpython/commit/53ff2ca89feb90c1fbf2605321bcef35b457f16f


--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38098] Special Characters Don't Work When Using Virtual Environment

[Eryk Sun]

Eryk Sun  added the comment:

> pyreadline (2.1)

The problem is pyreadline. It uses a low-level console read, but it fails to 
account for the Alt+Numpad sequence of input records that the console uses for 
non-OEM characters. IIRC, the Unicode character is only sent in the final input 
record of the sequence.

--
nosy: +eryksun
resolution:  -> third party
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38163] AsyncMock child mocks should detect their type

[Lisa Roach]

New submission from Lisa Roach :

We want child mocks to match their "type" (async or sync). 

Ex:

class Prod:
   async def foo():
  pass
def bar():
   pass

a_mock = AsyncMock(Prod)
isinstance(a_mock.foo(), AsyncMock) == True
isinstance(a_mock.bar(), MagicMock) == True

Also this should include magic methods:

int(a_mock) should work and return 1 like MagicMocks do.
a_mock.__enter__ should exist and be a MagicMock, just as a_mock.__aenter__ 
exists and is an AsyncMock.

--
messages: 352369
nosy: lisroach
priority: normal
severity: normal
status: open
title: AsyncMock child mocks should detect their type

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32092] mock.patch with autospec does not consume self / cls argument

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +cjw296, lisroach, mariocj89, xtreak
versions: +Python 3.9 -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

[miss-islington]

miss-islington  added the comment:


New changeset 436b429ade87b10879b3f944e99a515478e86e5e by Miss Islington (bot) 
in branch '3.8':
bpo-38092: Reduce overhead when using multiprocessing in a Windows virtual 
environment (GH-16098)
https://github.com/python/cpython/commit/436b429ade87b10879b3f944e99a515478e86e5e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33082] multiprocessing docs bury very important 'callback=' args

[Julien Palard]

Julien Palard  added the comment:

I agree Antoine on this one, if one want the result, It'll get it from the  
returned value (.get method in the example), or simply by using the not-async 
versions and directly get the results as a return value of the call.

Also the given example in the documentation won't work as the result is never 
waited for, the pool gets destroyed before the sleep have the time to sleep.

--
nosy: +mdk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38162] Import Long Load

[Evgeniy Mischuk]

New submission from Evgeniy Mischuk :

for in TMP_MAX dont break and always continue

--
components: Windows
messages: 352365
nosy: Evgeniy Mischuk, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
pull_requests: 15733
severity: normal
status: open
title: Import Long Load
type: performance
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33082] multiprocessing docs bury very important 'callback=' args

[Julien Palard]

Julien Palard  added the comment:

I'd wait for Davin's review, but I'd keep the documentation as they are.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

[Stéphane Wirtel]

Change by Stéphane Wirtel :


--
pull_requests: +15732
pull_request: https://github.com/python/cpython/pull/16118

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

[miss-islington]

miss-islington  added the comment:


New changeset a67ac2f2d9550e5a36d28f9b6eeacf6575dda2d5 by Miss Islington (bot) 
(Eddie Elizondo) in branch 'master':
bpo-38150 Fix refleak in the finalizer of a _testcapimodule type (GH-16115)
https://github.com/python/cpython/commit/a67ac2f2d9550e5a36d28f9b6eeacf6575dda2d5


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

[Steve Dower]

Steve Dower  added the comment:

Thanks for the report and partial patch!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38122] AsyncMock force always creating an AsyncMock for child mocks

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:


New changeset 14fd925a18fe3db0922a7d798e373102fe7a8a9c by Stéphane Wirtel 
(Michael Foord) in branch 'master':
bpo-38122: minor fixes to AsyncMock spec handling (GH-16099)
https://github.com/python/cpython/commit/14fd925a18fe3db0922a7d798e373102fe7a8a9c


--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38035] shared_semaphores cannot be shared across unrelated processes

[Vinay Sharma]

Vinay Sharma  added the comment:

A common use for the same can be shared memory. Currently shared memory can be 
used by unrelated processes, but there is no mechanism as such to synchronise 
them at the moment.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

[miss-islington]

miss-islington  added the comment:


New changeset f2b7556ef851ac85e7cbf189d1b29fdeb9539b88 by Miss Islington (bot) 
(Steve Dower) in branch 'master':
bpo-38092: Reduce overhead when using multiprocessing in a Windows virtual 
environment (GH-16098)
https://github.com/python/cpython/commit/f2b7556ef851ac85e7cbf189d1b29fdeb9539b88


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

[miss-islington]

Change by miss-islington :


--
pull_requests: +15731
pull_request: https://github.com/python/cpython/pull/16116

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35727] sys.exit() in a multiprocessing.Process does not align with Python behavior

[Davin Potts]

Davin Potts  added the comment:

I believe the mentality behind multiprocessing.Process triggering an exit code 
of 1 when sys.exit() is invoked inside its process is to indicate a 
non-standard exit out of its execution.  There may yet be other side effects 
that could be triggered by having a sys.exit(0) translate into an exit code of 
0 from the Process's process -- and we might not notice them with the current 
tests.

Was there a particular use case that motivates this suggested change?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5396] os.read not handling O_DIRECT flag

[Paul]

Paul  added the comment:

I've dug into stracing this python program in 2.7 vs. 3.7.

directread.py

import mmap
import os

fd = os.open('/dev/dm-2', os.O_DIRECT | os.O_RDWR)  # mapped block device
fo = os.fdopen(fd, 'rb+')
m = mmap.mmap(-1, 4096)
fo.readinto(m)

Python 2.7 result:

...
open("/dev/dm-2", O_RDWR|O_DIRECT)  = 3
...
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_SHARED|MAP_ANONYMOUS, -1, 0) = 
0x7f743db31000
...
read(0x3, 0x7f743db31000, 0x1000)   = 0x1000
...

Python 3.7 result:

...
open("/dev/dm-2", O_RDWR|O_DIRECT|O_CLOEXEC) = 3
...
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_SHARED|MAP_ANONYMOUS, -1, 0) = 
0x7f5e087ee000
...
read(0x3, 0x256c8a0, 0x1000)= -1 (errno 22)

Notice that Python 3 isn't using the mmap buffer for the read.  Why is it using 
a stack buffer?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

[Eddie Elizondo]

Change by Eddie Elizondo :


--
keywords: +patch
pull_requests: +15730
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/16115

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34706] Signature.from_callable sometimes drops subclassing

[miss-islington]

Change by miss-islington :


--
pull_requests: +15729
pull_request: https://github.com/python/cpython/pull/16114

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34706] Signature.from_callable sometimes drops subclassing

[Gregory P. Smith]

Gregory P. Smith  added the comment:


New changeset 5b9ff7a0dcb16d6f5c3cd4f1f52e0ca6a4bde586 by Gregory P. Smith in 
branch 'master':
bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108)
https://github.com/python/cpython/commit/5b9ff7a0dcb16d6f5c3cd4f1f52e0ca6a4bde586


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34706] Signature.from_callable sometimes drops subclassing

[miss-islington]

Change by miss-islington :


--
pull_requests: +15728
pull_request: https://github.com/python/cpython/pull/16113

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37199] Test suite fails when Ipv6 is unavailable

[miss-islington]

miss-islington  added the comment:


New changeset 83c21fdc36070f9fa3eb3b68181630e2cc6480fe by Miss Islington (bot) 
in branch '3.8':
bpo-37199: Replace the early returns added in c2cda63. (GH-14535)
https://github.com/python/cpython/commit/83c21fdc36070f9fa3eb3b68181630e2cc6480fe


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37609] support "UNC" device paths in ntpath.splitdrive

[Eryk Sun]

Eryk Sun  added the comment:

Please consult the attached file "splitdrive.py". I redesigned splitdrive() to 
support "UNC" and "GLOBAL" junctions in device paths. I relaxed the design to 
allow repeated separators everywhere except for the UNC root. IIRC, Windows has 
supported this since XP. For example:

>>> print(nt._getfullpathname('//server///share'))
\\server\share
>>> print(nt._getfullpathname(r'\\server\\\share'))
\\server\share

There are also a couple of minor behavior changes in the new implementation.

The old implementation would split "//server/" as ('//server/', ''). Since 
there's no share, this should not count as a drive. The new implementation 
splits it as ('', '//server/'). Similarly it splits '//?/UNC/server/' as ('', 
'//?/UNC/server/'). 

The old implementation also allowed any character as a drive 'letter'. For 
example, it would split '/:/spam' as ('/:', '/spam'). The new implementation 
ensures that the drive letter in a DOS drive is alphabetic.

I also extended test_splitdrive to use a list of test cases in order to avoid 
having to define each case twice. It calls tester() a second time for each 
case, with slash and backslash swapped.

--
Added file: https://bugs.python.org/file48607/splitdrive.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

[Eddie Elizondo]

Eddie Elizondo  added the comment:

> Checking for refleak takes between 2 and 6 hours.

Ouch! Makes sense then.

We could potentially add a `pre-merge` job that only runs once the merge starts 
to get executed. Anyways, that's a conversation for another time :-)

---

Thanks Stephane I'm very aware of that, I just thought that the build bots did 
that automatically at PR time. I rather have those drive the signal and letting 
my slow machine run for hours! Anyways, I'll just have to slightly change my 
workflow now

--
nosy:  -matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37449] Move ensurepip off of pkgutil and to importlib.resources

[miss-islington]

miss-islington  added the comment:


New changeset 2ccb50cf773881255c5669942a093eb68ad042f6 by Miss Islington (bot) 
(Joannah Nanjekye) in branch 'master':
bpo-37449: Move ensurepip off of pkgutil and to importlib.resources (GH-15109)
https://github.com/python/cpython/commit/2ccb50cf773881255c5669942a093eb68ad042f6


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38161] AsyncMock add `.awaited` like `.called`

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

awaited is now initialized with an Event object. Do you had any use case in 
mind while designing it? I think it's a good choice to have True/False instead 
of being used to give an Event object that is not used.

--
nosy: +xtreak
type:  -> enhancement
versions: +Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37555] _CallList.__contains__ doesn't always respect ANY.

[Paul Ganssle]

Paul Ganssle  added the comment:


New changeset d6a9d17d8b6c68073931dd8ffa213b4ac351a4ab by Paul Ganssle 
(Elizabeth Uselton) in branch 'master':
bpo-37555: Update _CallList.__contains__ to respect ANY (#14700)
https://github.com/python/cpython/commit/d6a9d17d8b6c68073931dd8ffa213b4ac351a4ab


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37199] Test suite fails when Ipv6 is unavailable

[miss-islington]

Change by miss-islington :


--
pull_requests: +15727
pull_request: https://github.com/python/cpython/pull/16112

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:

Eddie,

For the next time, when you change something in the C part, you could run the 
tests with this command:

./python -m test test_capi -R 3:3

--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38098] Special Characters Don't Work When Using Virtual Environment

[Spandan Garg]

Spandan Garg  added the comment:

This is the output of pip list with venv active:
(aladdin_windows_env) 
C:\Users\t-spga\Documents\workspace\aladdin_windows_env>pip list
DEPRECATION: The default format will switch to columns in the future. You can 
use --format=(legacy|columns) (or define a format=(legacy|columns) in your 
pip.conf under the [list] section) to disable this warning.
adal (1.2.2)
antlr4-python3-runtime (4.7.2)
applicationinsights (0.11.9)
argcomplete (1.10.0)
asn1crypto (0.24.0)
azure-batch (7.0.0)
azure-cli (2.0.72)
azure-cli-command-modules-nspkg (2.0.3)
azure-cli-core (2.0.72)
azure-cli-nspkg (3.0.4)
azure-cli-telemetry (1.0.3)
azure-common (1.1.23)
azure-cosmos (3.1.1)
azure-datalake-store (0.0.47)
azure-functions-devops-build (0.0.22)
azure-graphrbac (0.60.0)
azure-keyvault (1.1.0)
azure-kusto-data (0.0.33)
azure-mgmt-advisor (2.0.1)
azure-mgmt-apimanagement (0.1.0)
azure-mgmt-appconfiguration (0.1.0)
azure-mgmt-applicationinsights (0.1.1)
azure-mgmt-authorization (0.52.0)
azure-mgmt-batch (6.0.0)
azure-mgmt-batchai (2.0.0)
azure-mgmt-billing (0.2.0)
azure-mgmt-botservice (0.2.0)
azure-mgmt-cdn (3.1.0)
azure-mgmt-cognitiveservices (5.0.0)
azure-mgmt-compute (6.0.0)
azure-mgmt-consumption (2.0.0)
azure-mgmt-containerinstance (1.5.0)
azure-mgmt-containerregistry (3.0.0rc5)
azure-mgmt-containerservice (5.3.0)
azure-mgmt-cosmosdb (0.7.0)
azure-mgmt-datalake-analytics (0.2.1)
azure-mgmt-datalake-nspkg (3.0.1)
azure-mgmt-datalake-store (0.5.0)
azure-mgmt-datamigration (0.1.0)
azure-mgmt-deploymentmanager (0.1.0)
azure-mgmt-devtestlabs (2.2.0)
azure-mgmt-dns (2.1.0)
azure-mgmt-eventgrid (2.2.0)
azure-mgmt-eventhub (2.6.0)
azure-mgmt-hdinsight (1.1.0)
azure-mgmt-imagebuilder (0.2.1)
azure-mgmt-iotcentral (1.0.0)
azure-mgmt-iothub (0.8.2)
azure-mgmt-iothubprovisioningservices (0.2.0)
azure-mgmt-keyvault (1.1.0)
azure-mgmt-kusto (0.3.0)
azure-mgmt-loganalytics (0.2.0)
azure-mgmt-managedservices (1.0.0)
azure-mgmt-managementgroups (0.2.0)
azure-mgmt-maps (0.1.0)
azure-mgmt-marketplaceordering (0.2.1)
azure-mgmt-media (1.1.1)
azure-mgmt-monitor (0.5.2)
azure-mgmt-msi (0.2.0)
azure-mgmt-netapp (0.5.0)
azure-mgmt-network (4.0.0)
azure-mgmt-nspkg (3.0.2)
azure-mgmt-policyinsights (0.3.1)
azure-mgmt-privatedns (0.1.0)
azure-mgmt-rdbms (1.9.0)
azure-mgmt-recoveryservices (0.4.0)
azure-mgmt-recoveryservicesbackup (0.4.0)
azure-mgmt-redis (6.0.0)
azure-mgmt-relay (0.1.0)
azure-mgmt-reservations (0.3.1)
azure-mgmt-resource (2.2.0)
azure-mgmt-search (2.1.0)
azure-mgmt-security (0.1.0)
azure-mgmt-servicebus (0.6.0)
azure-mgmt-servicefabric (0.2.0)
azure-mgmt-signalr (0.3.0)
azure-mgmt-sql (0.13.0)
azure-mgmt-sqlvirtualmachine (0.4.0)
azure-mgmt-storage (4.0.0)
azure-mgmt-trafficmanager (0.51.0)
azure-mgmt-web (0.42.0)
azure-multiapi-storage (0.2.4)
azure-nspkg (3.0.2)
azure-storage-blob (1.5.0)
azure-storage-common (1.4.2)
bcrypt (3.1.7)
certifi (2019.6.16)
cffi (1.12.3)
chardet (3.0.4)
colorama (0.4.1)
cryptography (2.7)
fabric (2.5.0)
gitdb2 (2.0.5)
GitPython (2.1.11)
humanfriendly (4.18)
idna (2.8)
invoke (1.3.0)
isodate (0.6.0)
javaproperties (0.5.1)
Jinja2 (2.10.1)
jmespath (0.9.4)
jsondiff (1.2.0)
knack (0.6.3)
MarkupSafe (1.1.1)
mock (2.0.0)
msrest (0.6.10)
msrestazure (0.6.1)
oauthlib (3.1.0)
paramiko (2.6.0)
pbr (5.4.3)
pip (9.0.3)
portalocker (1.5.1)
psutil (5.6.3)
pycparser (2.19)
pydocumentdb (2.3.3)
Pygments (2.4.2)
PyJWT (1.7.1)
PyNaCl (1.3.0)
pyOpenSSL (19.0.0)
pypiwin32 (223)
pyreadline (2.1)
python-dateutil (2.8.0)
python-git (2018.2.1)
pytz (2019.1)
pywin32 (224)
PyYAML (5.1.2)
requests (2.22.0)
requests-oauthlib (1.2.0)
ruamel.yaml (0.16.5)
ruamel.yaml.clib (0.1.2)
scp (0.13.2)
Send2Trash (1.5.0)
setuptools (39.0.1)
six (1.12.0)
smmap2 (2.0.5)
sshtunnel (0.1.5)
tabulate (0.8.3)
urllib3 (1.25.3)
vsts (0.1.25)
vsts-cd-manager (1.0.2)
websocket-client (0.56.0)
wheel (0.30.0)
xmltodict (0.12.0)
You are using pip version 9.0.3, however version 19.2.3 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' 
command.

This is the output of pip list with venv deactivated:
C:\Users\t-spga\Documents\workspace\aladdin_windows_env>pip list
DEPRECATION: The default format will switch to columns in the future. You can 
use --format=(legacy|columns) (or define a format=(legacy|columns) in your 
pip.conf under the [list] section) to disable this warning.
pip (9.0.3)
setuptools (39.0.1)
You are using pip version 9.0.3, however version 19.2.3 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' 
command.

Thanks!

Spandan

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37199] Test suite fails when Ipv6 is unavailable

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset 81319a81b2a3f42fe1047c2e6f5fd958faab6cdb by Benjamin Peterson 
(Zackery Spytz) in branch 'master':
bpo-37199: Replace the early returns added in c2cda63. (GH-14535)
https://github.com/python/cpython/commit/81319a81b2a3f42fe1047c2e6f5fd958faab6cdb


--
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

[STINNER Victor]

STINNER Victor  added the comment:

> Also, I thought that the PR build bots already ran refleak tests by default? 
> Do you know why this it's not integrated to the PR flow?

Checking for refleak takes between 2 and 6 hours. We would like to keep our 
pre-commit CI fast enough (less than 30 minutes).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

[Eddie Elizondo]

Eddie Elizondo  added the comment:

On it.

Also, I thought that the PR build bots already ran refleak tests by default? Do 
you know why this it's not integrated to the PR flow?

--
nosy: +eelizondo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38161] AsyncMock add `.awaited` like `.called`

[Lisa Roach]

New submission from Lisa Roach :

Currently Mock has a `.called` attribute, we could add an equivalent `.awaited` 
that returns True or False if the object has been awaited on.

--
messages: 352345
nosy: lisroach
priority: normal
severity: normal
status: open
title: AsyncMock add `.awaited` like `.called`

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37879] Segfaults in C heap type subclasses

[STINNER Victor]

STINNER Victor  added the comment:

I reopen the issue: the change caused a regression on the Refleak buildbot 
workers: bpo-38150.

--
nosy: +vstinner
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38150] test_capi: test_c_subclass_of_heap_ctype_with_del_modifying_dunder_class_only_decrefs_once() leaks

[STINNER Victor]

STINNER Victor  added the comment:

The new test was added by:

commit ff023ed36ea260ab64be5895f1f1f087c798987a
Author: Eddie Elizondo 
Date:   Wed Sep 11 05:17:13 2019 -0400

bpo-37879: Suppress subtype_dealloc decref when base type is a C heap type 
(GH-15323)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36274] http.client cannot send non-ASCII request lines

[Jason R. Coombs]

Jason R. Coombs  added the comment:

I've started drafting a patch at 
https://github.com/python/cpython/tree/feature/putrequest-hooks

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26140] inspect.iscoroutinefunction raises TypeError when checks Mock of function or coroutinefunction

[Andrew Svetlov]

Andrew Svetlov  added the comment:

I believe with AsyncMock implemented we can close the issue

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38019] asyncio subprocess AttributeError: 'NoneType' object has no attribute '_add_reader' / '_remove_reader'

[Marat Sharafutdinov]

Change by Marat Sharafutdinov :


--
title: AttributeError: 'NoneType' object has no attribute '_add_reader' / 
'_remove_reader' -> asyncio subprocess AttributeError: 'NoneType' object has no 
attribute '_add_reader' / '_remove_reader'
versions: +Python 3.6, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36274] http.client cannot send non-ASCII request lines

[Jason R. Coombs]

Jason R. Coombs  added the comment:

I believe this issue is more recent and widespread than I originally thought. I 
realized today that CherryPy is affected by this issue and [disabled nightly 
tests](https://github.com/cherrypy/cherrypy/issues/1781#issuecomment-507836873) 
as a result. It looks like the changed behavior was introduced in Python 3.7.4, 
so I expect stable releases to start failing also now. In that case, the web 
framework wishes to test that a null byte transmitted by the client is handled 
properly in the server, and without a patch, it's not possible for a project 
like cherrypy to transmit the invalid request to ensure a proper invalid 
response.

I see now that the previously proposed solution wouldn't even address this 
use-case, as the null byte would still have been excluded.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25068] The proxy key's string should ignore case.

[miss-islington]

miss-islington  added the comment:


New changeset 590ed09a5b422d59cc1f049c64ac30733545eef0 by Miss Islington (bot) 
in branch '3.8':
bpo-25068: urllib.request.ProxyHandler now lowercases the dict keys (GH-13489)
https://github.com/python/cpython/commit/590ed09a5b422d59cc1f049c64ac30733545eef0


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38155] Add __all__ to the datetime module

[Dong-hee Na]

Dong-hee Na  added the comment:

Good news, When this issue is solved.
Can we solve the issue from https://github.com/python/cpython/pull/15633 ?

--
nosy: +corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34706] Signature.from_callable sometimes drops subclassing

[Gregory P. Smith]

Change by Gregory P. Smith :


--
assignee:  -> gregory.p.smith
nosy: +gregory.p.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34706] Signature.from_callable sometimes drops subclassing

[Gregory P. Smith]

Change by Gregory P. Smith :


--
versions: +Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com