[issue42145] test_io is leaking references

[Pablo Galindo Salgado]

New submission from Pablo Galindo Salgado :

❯ ./python -m test test_io -m 
test.test_io.CTextIOWrapperTest.test_read_one_by_one -R :
0:00:00 load avg: 1.59 Run tests sequentially
0:00:00 load avg: 1.59 [1/1] test_io
beginning 9 repetitions
123456789
.
test_io leaked [3, 3, 3, 3] references, sum=12
test_io leaked [1, 1, 1, 1] memory blocks, sum=4
test_io failed

== Tests result: FAILURE ==

1 test failed:
test_io

Total duration: 398 ms
Tests result: FAILURE

--
components: Tests
messages: 379564
nosy: pablogsal
priority: normal
severity: normal
status: open
title: test_io is leaking references
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14556] telnetlib Telnet.expect fails with timeout=0

[Zackery Spytz]

Zackery Spytz  added the comment:

Python 2.7 is no longer supported, so I think this issue should be closed.

--
nosy: +ZackerySpytz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42144] A missing "goto" in the _ssl module!

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
pull_requests: +21876
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/22959

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42144] A missing "goto" in the _ssl module!

[Zackery Spytz]

New submission from Zackery Spytz :

In the _ssl_configure_hostname() function, there's a missing "goto error;" if
SSL_set_tlsext_host_name() fails.

--
assignee: christian.heimes
components: Extension Modules, SSL
messages: 379562
nosy: ZackerySpytz, christian.heimes
priority: normal
severity: normal
status: open
title: A missing "goto" in the _ssl module!
versions: Python 3.10, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Thanks for hopefully finishing this issue.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33962] IDLE: use ttk.spinbox with configdialog

[Terry J. Reedy]

Terry J. Reedy  added the comment:

#27755 was about replacing uses of our custom DynOptionMenu with ttk.Combobox, 
which I believe we can do now, wherever we don't replace it with something 
else.   One use is for font size choice; Spinbox was suggested as an 
alternative replacement.

Spinbox was also proposed somewhere else to remplace the indent size Label 
scale.  But I/we had decided, somewhere,  to use a simple entry box, like those 
for entering counts on the General tab, with validation limits of 1 and 16, and 
move the choice to the General tab.  (If we don't have validate(min, max) 
function, should make one.)  SO

The transfer cannot be done until the General tab is split into 2, as it is now 
too long (does not fix on Macbook Air -- cannot see buttons).  I think General 
windows preferences (where indent should go) + help resources for 1, Specific 
Editor only or Shell only for other.  Not sure of names.

This all said, I tried out the patch.  The spinbox appears to be an Entry with 
added arrows.  If it worked right, it could be used for some other int entries 
instead of plain Entry.  But in some ways, it seems partly worse than Entry.
0. No doc in Shipman (written before 8.5.9); must use tk doc.
1. Expands to space available; is Entry char width really disabled?
2. Deleting digit to replace it generates 2 TclErrors*.
3. Clicking arrow 'selects' entry.  Patch used text selection, but my dark 
theme select looks awful for single digit.  We can fix this with different 
config.

* ...
  File "f:\dev\3x\lib\tkinter\__init__.py", line 536, in get
return self._tk.getint(value)
_tkinter.TclError: expected integer but got ""
During handling of the above exception, another exception occurred:
...
  File "f:\dev\3x\lib\tkinter\__init__.py", line 538, in get
return int(self._tk.getdouble(value))
_tkinter.TclError: expected floating-point number but got ""

I will look more later.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[miss-islington]

miss-islington  added the comment:


New changeset 8485d3b911c3cb73ed6217a47c7720f9277efc01 by Miss Skeleton (bot) 
in branch '3.8':
bpo-33987: Add master ttk Frame to IDLE search dialogs (GH-22942)
https://github.com/python/cpython/commit/8485d3b911c3cb73ed6217a47c7720f9277efc01


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[miss-islington]

miss-islington  added the comment:


New changeset 9cf26b00e42787bc668c62f1b5dde814f8307259 by Miss Skeleton (bot) 
in branch '3.9':
bpo-33987: Add master ttk Frame to IDLE search dialogs (GH-22942)
https://github.com/python/cpython/commit/9cf26b00e42787bc668c62f1b5dde814f8307259


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[miss-islington]

Change by miss-islington :


--
pull_requests: +21874
pull_request: https://github.com/python/cpython/pull/22956

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset 5df6c99cb450fe2f30be681dbf68cd1d34d3bbe4 by Mark Roseman in 
branch 'master':
bpo-33987: Add master ttk Frame to IDLE search dialogs (GH-22942)
https://github.com/python/cpython/commit/5df6c99cb450fe2f30be681dbf68cd1d34d3bbe4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[miss-islington]

Change by miss-islington :


--
pull_requests: +21875
pull_request: https://github.com/python/cpython/pull/22957

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42142] FAIL tkinter ttk LabeledScale test_resize, and more

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Azure Pipelines Ubuntu, as before, but Combobox test_virtual_event.

test_virtual_event (tkinter.test.test_ttk.test_widgets.ComboboxTest) ... 
Timeout (0:20:00)!
Thread 0x7fb09e3f3080 (most recent call first):
  File "/home/vsts/work/1/s/Lib/tkinter/__init__.py", line 696 in 
wait_visibility
  File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_widgets.py", line 
452 in test_virtual_event

--
components: +Tests, Tkinter
title: FAIL tkinter ttk LabeledScale test_resize -> FAIL tkinter ttk 
LabeledScale test_resize, and more

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[Inada Naoki]

Change by Inada Naoki :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[miss-islington]

miss-islington  added the comment:


New changeset 229eaf20694006c03af0f4740abdf8ae5579 by Miss Skeleton (bot) 
in branch '3.9':
bpo-29981: Add examples and update index for set, dict, and generator 
comprehensions'(GH-20272)
https://github.com/python/cpython/commit/229eaf20694006c03af0f4740abdf8ae5579


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29981] Update Index for set, dict, and generator 'comprehensions'

[miss-islington]

miss-islington  added the comment:


New changeset 60bef61f717dde915058b03159b2c2e97d765858 by Miss Skeleton (bot) 
in branch '3.8':
bpo-29981: Add examples and update index for set, dict, and generator 
comprehensions'(GH-20272)
https://github.com/python/cpython/commit/60bef61f717dde915058b03159b2c2e97d765858


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42127] functools.cached_property possibly disables key-sharing instance dictionaries

[Raymond Hettinger]

Raymond Hettinger  added the comment:


New changeset 427cb0aa78813b89a3f100073bf7d70a53510f57 by Miss Skeleton (bot) 
in branch '3.9':
bpo-42127:  Document effect of cached_property on key-sharing dictionaries 
(GH-22930) (GH-22955)
https://github.com/python/cpython/commit/427cb0aa78813b89a3f100073bf7d70a53510f57


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42127] functools.cached_property possibly disables key-sharing instance dictionaries

[Raymond Hettinger]

Change by Raymond Hettinger :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42127] functools.cached_property possibly disables key-sharing instance dictionaries

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 3.0 -> 4.0
pull_requests: +21873
pull_request: https://github.com/python/cpython/pull/22955

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42127] functools.cached_property possibly disables key-sharing instance dictionaries

[Raymond Hettinger]

Raymond Hettinger  added the comment:


New changeset 48be6b1ef7a6201e13c87a317361cdb60bd5faa8 by Raymond Hettinger in 
branch 'master':
bpo-42127:  Document effect of cached_property on key-sharing dictionaries 
(GH-22930)
https://github.com/python/cpython/commit/48be6b1ef7a6201e13c87a317361cdb60bd5faa8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[miss-islington]

miss-islington  added the comment:


New changeset 2d493893c7aa9af633c4ebeb56ecce42e3a82e9f by Miss Skeleton (bot) 
in branch '3.9':
bpo-33987: Use master ttk Frame for IDLE config dialog (GH-22943)
https://github.com/python/cpython/commit/2d493893c7aa9af633c4ebeb56ecce42e3a82e9f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33962] IDLE: use ttk.spinbox with configdialog

[Mark Roseman]

Change by Mark Roseman :


--
keywords: +patch
pull_requests: +21872
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/22954

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42141] Speedup various dict inits

[Inada Naoki]

Inada Naoki  added the comment:

> 1. dicts from other dicts that are not "perfect" (combined and without holes)
> 3. copies of dicts with many holes

Note that I have optimized and rejected it by myself already.
See https://github.com/python/cpython/pull/21669
and https://bugs.python.org/issue41431#msg374556

Code duplication is too huge compared to performance gain.

--
nosy: +methane

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[miss-islington]

miss-islington  added the comment:


New changeset 253c8eb40ec5a87aa539f913fcd83d1759069981 by Miss Skeleton (bot) 
in branch '3.8':
bpo-33987: Use master ttk Frame for IDLE config dialog (GH-22943)
https://github.com/python/cpython/commit/253c8eb40ec5a87aa539f913fcd83d1759069981


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42143] Corruptions in func_dealloc() with partially-created function object

[Yonatan Goldschmidt]

Change by Yonatan Goldschmidt :


--
keywords: +patch
pull_requests: +21871
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/22953

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[miss-islington]

miss-islington  added the comment:


New changeset c1b620eecc2ca0f9ae9d5ee2d973e823db295ad2 by Miss Skeleton (bot) 
in branch '3.8':
bpo-33987: Use ttk Label on IDLE statusbar (GH-22941)
https://github.com/python/cpython/commit/c1b620eecc2ca0f9ae9d5ee2d973e823db295ad2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[miss-islington]

miss-islington  added the comment:


New changeset 4efd2defb899c5c45334814234c842f8f513879e by Miss Skeleton (bot) 
in branch '3.9':
bpo-33987: Use ttk Label on IDLE statusbar (GH-22941)
https://github.com/python/cpython/commit/4efd2defb899c5c45334814234c842f8f513879e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42143] Corruptions in func_dealloc() with partially-created function object

[Yonatan Goldschmidt]

New submission from Yonatan Goldschmidt :

While reading funcobject.c, I noticed that PyFunction_NewWithQualName() may 
exit early if it fails retrieving __name__ from the globals dict.
It will destroy the partially-created PyFunction object. However, this is done 
before ever initializing ->func_qualname. Since the object is allocated with 
PyObject_GC_New() (which does *not* provide zero-initialized memory), we are 
using Py_CLEAR() on uninitialized memory.

I wrote a simple snippet to produce this bug, expecting to see a crash due to 
the Py_DECREF() call on garbage memory:

from types import FunctionType
import random

class BadEq:
def __hash__(self):
print("hash called")
return hash("__name__")
def __eq__(self, other):
print("eq called")
raise Exception()

# run until we hit a 0x61616161.. pointer for 
PyFunctionObject->func_qualname, and crash
while True:
s = int(random.random() * 1000) * "a"
try:
FunctionType(BadEq.__hash__.__code__, {BadEq(): 1})
except Exception:
pass

However, I got *another* crash immediately: func_dealloc() calls 
_PyObject_GC_UNTRACK() which crashes if _PyObject_GC_TRACK() was not called 
beforehand. When running with "--with-pydebug", you get this nice assert:

Objects/funcobject.c:595: _PyObject_GC_UNTRACK: Assertion "(((PyGC_Head 
*)(op)-1)->_gc_next != 0)" failed: object not tracked by the garbage collector

I replaced "_PyObject_GC_UNTRACK(op);" in func_dealloc() with:

if (PyObject_GC_IsTracked(op)) {
_PyObject_GC_UNTRACK(op);
}

And ran my snippet again, this time it crashes after some loops with the error 
I was expecting to receive
(here I print _py_tmp, the temporary variable inside Py_CLEAR()):

Program received signal SIGSEGV, Segmentation fault.
func_clear (op=op@entry=0x7f9c8a25faf0) at Objects/funcobject.c:587
587 Py_CLEAR(op->func_qualname);
(gdb) p _py_tmp
$1 = (PyObject *) 0x6161616161616161

This issue exists since https://github.com/python/cpython/pull/2, which 
fixed tons of call sites to use PyDict_GetItemWithError(), I guess that this 
specific flow was not tested.

As a fix, I think we should run the part that can result in errors *before* 
creating the PyFunction, so we can no longer get an error while we have a 
partial object. This fixes both of the problems I've described. Thus we can 
move the dict lookup part to the top of
PyFunction_NewWithQualName().

I see no reason not to make such a change in the function's flow. If we'd 
rather keep the flow as-is, we can make sure to initialize ->func_qualname to 
NULL, and wrap _PyObject_GC_UNTRACK() with _PyObject_GC_IS_TRACKED() in 
func_dealloc(). I like this solution less because it adds this unnecessary "if" 
statement in func_dealloc().

I'll post a PR in GitHub soon.

--
components: Interpreter Core
messages: 379546
nosy: Yonatan Goldschmidt
priority: normal
severity: normal
status: open
title: Corruptions in func_dealloc() with partially-created function object
type: crash
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset c579ad14d3b5bb9a45d7b9cc708eaf0bf4884c50 by Mark Roseman in 
branch 'master':
bpo-33987: Use master ttk Frame for IDLE config dialog (GH-22943)
https://github.com/python/cpython/commit/c579ad14d3b5bb9a45d7b9cc708eaf0bf4884c50


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[miss-islington]

Change by miss-islington :


--
pull_requests: +21870
pull_request: https://github.com/python/cpython/pull/22952

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[miss-islington]

Change by miss-islington :


--
pull_requests: +21869
pull_request: https://github.com/python/cpython/pull/22951

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[miss-islington]

Change by miss-islington :


--
pull_requests: +21868
pull_request: https://github.com/python/cpython/pull/22950

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset e53e54425d9b7b9b7b082817da104d60bb25e3a2 by Mark Roseman in 
branch 'master':
bpo-33987: Use ttk Label on IDLE statusbar (GH-22941)
https://github.com/python/cpython/commit/e53e54425d9b7b9b7b082817da104d60bb25e3a2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[miss-islington]

Change by miss-islington :


--
pull_requests: +21867
pull_request: https://github.com/python/cpython/pull/22949

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42142] FAIL tkinter ttk LabeledScale test_resize

[Terry J. Reedy]

New submission from Terry J. Reedy :

This appears to have timed out as there was no other error indication.
Azure Pipelines, retested gave 2nd failure.  Passed on another PR.

test_resize (tkinter.test.test_ttk.test_extensions.LabeledScaleTest) ... 
Timeout (0:20:00)!
Thread 0x7f787182e080 (most recent call first):
  File "/home/vsts/work/1/s/Lib/tkinter/__init__.py", line 696 in 
wait_visibility
  File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_extensions.py", line 
190 in test_resize
...

--
messages: 379543
nosy: serhiy.storchaka, terry.reedy
priority: normal
severity: normal
status: open
title: FAIL tkinter ttk LabeledScale test_resize
type: behavior
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37203] Correct classmethod emulation in Descriptor HowTo Guide

[Géry]

Change by Géry :


--
versions: +Python 3.9 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37203] Correct classmethod emulation in Descriptor HowTo Guide

[Géry]

Change by Géry :


--
resolution: not a bug -> fixed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37203] Correct classmethod emulation in Descriptor HowTo Guide

[Géry]

Change by Géry :


--
pull_requests: +21866
pull_request: https://github.com/python/cpython/pull/22934

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37658] In some cases asyncio.wait_for can lead to socket leak.

[Chris Jerdonek]

Chris Jerdonek  added the comment:

Issue #42130 that was recently filed appears related to this change.

--
nosy: +chris.jerdonek

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42130] AsyncIO's wait_for can hide cancellation in a rare race condition

[Chris Jerdonek]

Chris Jerdonek  added the comment:

It looks like issue 37658 might be the relevant change rather.

Here is the new logic it introduced: 
https://github.com/python/cpython/blob/db455296be5f792b8c12b7cd7f3962b52e4f44ee/Lib/asyncio/tasks.py#L483-L488

(via https://github.com/python/cpython/pull/21894 )

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42141] Speedup various dict inits

[Marco Sulla]

New submission from Marco Sulla :

The PR #22948 is an augmented version of #22346. It speeds up also the creation 
of:

1. dicts from other dicts that are not "perfect" (combined and without holes)
2. fromkeys
3. copies of dicts with many holes
4. dict from keywords, as in #22346

A sample bench:

python -m pyperf timeit --rigorous "dict(o)" -s """
from uuid import uuid4

def getUuid():
return str(uuid4())

o = {getUuid():getUuid() for i in range(1000)}
delkey = getUuid()
o[delkey] = getUuid()
del o[delkey]
"""
.

Before #22948:
Mean +- std dev: 35.9 us +- 0.6 us

After:
Mean +- std dev: 26.4 us +- 0.4 us

--
messages: 379540
nosy: Marco Sulla
priority: normal
pull_requests: 21865
severity: normal
status: open
title: Speedup various dict inits

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Mark Roseman]

Change by Mark Roseman :


--
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Mark Roseman]

Mark Roseman  added the comment:

have updated/cleaned up the previous patch, and there's a new PR. i realize 
this is unfortunately a somewhat monolithic change which might make reviewing 
it a bit tough...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17942] IDLE Debugger: Improve GUI

[Mark Roseman]

Change by Mark Roseman :


--
pull_requests: +21864
pull_request: https://github.com/python/cpython/pull/22947

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35823] Use vfork() in subprocess on Linux

[Gregory P. Smith]

Gregory P. Smith  added the comment:

Nice links.  LOL, yes, musl source was going to be my next stop if the larger 
libc sources proved impossible for a mere mortal to reason about. :)

regarding macOS, agreed. If someone needs vfork() to work there, I believe it 
could be made to.

Options like selecting the architecture of the child process could be higher 
level options to the subprocess API.  Hiding the platform specific details of 
how that happens and deciding which underlying approach to use based on the 
flags.

multi-arch systems are a thing.  It is conceivable that we may even see 
non-esoteric multi-arch hardware at some point.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35823] Use vfork() in subprocess on Linux

[Alexey Izbyshev]

Alexey Izbyshev  added the comment:

@ronaldoussoren

> I'd prefer to not use vfork on macOS. For one I don't particularly trust that 
> vfork would work reliably when using higher level APIs, but more importantly 
> posix_spawn on macOS has some options that are hard to achieve otherwise and 
> might be useful to expose in subprocess.

I can't comment on vfork() usability on macOS myself, but given the number of 
issues/considerations described here, I expect that significant research would 
be needed to check that.

Regarding your second point about extra posix_spawn() options, I actually don't 
see why it would be an argument against vfork(). Even on Linux, subprocess 
prefers posix_spawn() to vfork()/fork() when possible, so vfork() support 
doesn't hinder posix_spawn().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35823] Use vfork() in subprocess on Linux

[Alexey Izbyshev]

Alexey Izbyshev  added the comment:

> regarding excluding the setsid() case: I was being conservative as I couldn't 
> find a reference of what was and wasn't allowed after vfork.

Yes, there is no list of functions allowed after vfork(), except for the 
conservative POSIX.1 list consisting only of _exit() and execve(), so we can 
only take async-signal-safe functions as a first approximation and work from 
there. Thankfully, on Linux, C libraries don't do anything fancy in most cases. 
But, for example, it appears that on FreeBSD we wouldn't be able to use 
sigprocmask()/sigaction()[1]. BTW, commit[2] and the linked review are an 
interesting reading for anybody who would like to support posix_spawn() and/or 
vfork() in subprocess on FreeBSD.

> Confirming, in glibc is appears to be a shim for the setsid syscall (based on 
> not finding any code implementing anything special for it) and in uclibc 
> (*much* easier to read) it is clearly just a setsid syscall shim.

I also recommend musl[3] when simplicity (and correctness) is required :)

[1] 
https://svnweb.freebsd.org/base/head/lib/libc/gen/posix_spawn.c?view=markup=362111#l126
[2] https://svnweb.freebsd.org/base?view=revision=352712
[3] 
https://git.musl-libc.org/cgit/musl/tree/src/unistd/setsid.c?id=a5aff1972c9e3981566414b09a28e331ccd2be5d

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35823] Use vfork() in subprocess on Linux

[Gregory P. Smith]

Gregory P. Smith  added the comment:


New changeset be3c3a0e468237430ad7d19a33c60d306199a7f2 by Gregory P. Smith in 
branch 'master':
bpo-35823: Allow setsid() after vfork() on Linux. (GH-22945)
https://github.com/python/cpython/commit/be3c3a0e468237430ad7d19a33c60d306199a7f2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42096] zipfile.is_zipfile incorrectly identifying a gzipped file as a zip archive

[Gregory P. Smith]

Gregory P. Smith  added the comment:

for what it's worth: false positives are always going to be possible in any 
such "magic" check as is_zipfile is.

we don't check the start of the file because zip files are defined by their end 
of file central directory which contains length information to determine where 
within the file the zip archive actually starts.

The issue28494 tests are a demonstration of this; It is somewhat common 
practice to append a zipfile to an executable of various forms for use as 
application specific data.

If you need more more reliable determination of file type not tied to a 
specific Python release, you might look at what the various file type sniffing 
magic libraries do for you, some examples include:
 https://pypi.org/project/filetype/
 https://pypi.org/project/puremagic/
 https://pypi.org/project/python-magic/

I _can_ reproduce this issue with the testdata @bckohan provided.

But I can't promise there is anything to fix here.  Even if we make the test 
slightly more robust by looking at another byte or two, it is always possible 
for files to appear to be a bunch of things at once based on small data 
signatures.

If nothing else we should reinforce in the documentation that is_zipfile is at 
best a guess.  False means it is not as far as the zipfile module is concerned. 
 True cannot guarantee that it is.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35823] Use vfork() in subprocess on Linux

[Gregory P. Smith]

Change by Gregory P. Smith :


--
pull_requests: +21863
pull_request: https://github.com/python/cpython/pull/22945

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40001] ignore errors in SimpleCookie

[Aviram]

Aviram  added the comment:

Hi all,
still waiting for review.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41052] Opt out serialization/deserialization for heap type

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 8cd1dbae32d9303caac3a473d3332f17bc98c921 by Serhiy Storchaka in 
branch 'master':
bpo-41052: Fix pickling heap types implemented in C with protocols 0 and 1 
(GH-22870)
https://github.com/python/cpython/commit/8cd1dbae32d9303caac3a473d3332f17bc98c921


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31484] Cache single-character strings outside of the Latin1 range

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35823] Use vfork() in subprocess on Linux

[Gregory P. Smith]

Gregory P. Smith  added the comment:

regarding excluding the setsid() case: I was being conservative as I couldn't 
find a reference of what was and wasn't allowed after vfork.

I found one thing suggesting that on macOS setsid() was not safe after vfork(). 
 But that appeared to be a Darwin-ism.  I expect that is not true on Linux as 
it should just be a syscall updating a couple of fields in the process info.  
Confirming, in glibc is appears to be a shim for the setsid syscall (based on 
not finding any code implementing anything special for it) and in uclibc 
(*much* easier to read) it is clearly just a setsid syscall shim.

I'll make a PR to undo the setsid restriction given we're Linux only.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35823] Use vfork() in subprocess on Linux

[Gregory P. Smith]

Gregory P. Smith  added the comment:


New changeset 473db47747bb8bc986d88ad81799bcbd88153ac5 by Alexey Izbyshev in 
branch 'master':
bpo-35823: subprocess: Fix handling of pthread_sigmask() errors (GH-22944)
https://github.com/python/cpython/commit/473db47747bb8bc986d88ad81799bcbd88153ac5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35823] Use vfork() in subprocess on Linux

[Alexey Izbyshev]

Alexey Izbyshev  added the comment:

> Thank you for taking this on!  I'm calling it fixed for now as the buildbots 
> are looking happy with it.  If issues with it arise we can address them.

Thank you for reviewing and merging!

Using POSIX_CALL for pthread_sigmask() is incorrect, however, since it 
*returns* the error instead of setting errno. I've opened a PR with a fix and 
additional handling of the first pthread_sigmask() call in the parent (which 
can be done easily).

I've also noticed a memory leak why doing the above: cwd_obj2 is not released 
on the error path. It probably slipped with patches adding user/groups support. 
I'll file a separate issue.

Would you also clarify why you disallowed vfork() in case setsid() is needed? 
Have you discovered any potential issues with setsid()? Note that setsid() 
doesn't suffer from thread sync issues like setuid()/setgid()/etc.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35823] Use vfork() in subprocess on Linux

[Alexey Izbyshev]

Change by Alexey Izbyshev :


--
pull_requests: +21862
pull_request: https://github.com/python/cpython/pull/22944

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42132] Use specs instead of just __loader__ in C code

[Dong-hee Na]

Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[Mark Roseman]

Change by Mark Roseman :


--
pull_requests: +21861
pull_request: https://github.com/python/cpython/pull/22943

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[Mark Roseman]

Change by Mark Roseman :


--
pull_requests: +21860
pull_request: https://github.com/python/cpython/pull/22942

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: use ttk.Frame for ttk widgets

[Mark Roseman]

Change by Mark Roseman :


--
pull_requests: +21859
pull_request: https://github.com/python/cpython/pull/22941

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41835] Speed up dict vectorcall creation using keywords

[Marco Sulla]

Marco Sulla  added the comment:

I commented out sqlalchemy in the requirements.txt in the pyperformance source 
code, and it worked. I had also to skip tornado:

pyperformance run -r 
-b,-sqlalchemy_declarative,-sqlalchemy_imperative,-tornado_http -o 
../perf_master.json

This is my result:

pyperformance compare perf_master.json perf_dict_init.json -O table | grep 
Significant
| 2to3| 356 ms   | 348 ms  | 1.02x 
faster | Significant (t=7.28)   |
| fannkuch| 485 ms   | 468 ms  | 1.04x 
faster | Significant (t=9.68)   |
| pathlib | 22.5 ms  | 22.1 ms | 1.02x 
faster | Significant (t=13.02)  |
| pickle_dict | 29.0 us  | 30.3 us | 1.05x 
slower | Significant (t=-92.36) |
| pickle_list | 4.55 us  | 4.64 us | 1.02x 
slower | Significant (t=-10.87) |
| pyflate | 735 ms   | 702 ms  | 1.05x 
faster | Significant (t=6.67)   |
| regex_compile   | 197 ms   | 193 ms  | 1.02x 
faster | Significant (t=2.81)   |
| regex_v8| 24.5 ms  | 23.9 ms | 1.02x 
faster | Significant (t=17.63)  |
| scimark_fft | 376 ms   | 386 ms  | 1.03x 
slower | Significant (t=-15.07) |
| scimark_lu  | 154 ms   | 158 ms  | 1.03x 
slower | Significant (t=-12.94) |
| sqlite_synth| 3.35 us  | 3.21 us | 1.04x 
faster | Significant (t=17.65)  |
| telco   | 6.54 ms  | 7.14 ms | 1.09x 
slower | Significant (t=-8.51)  |
| unpack_sequence | 58.8 ns  | 61.5 ns | 1.04x 
slower | Significant (t=-19.66) |

It's strange that some benchmarks are slower, since the patch only do two 
additional checks to dict_vectorcall. Maybe they use many little dicts?

@methane:
> Would you implement some more optimization based on your PR to demonstrate 
> your idea?

I already done them, I'll do a PR.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35823] Use vfork() in subprocess on Linux

[Ronald Oussoren]

Ronald Oussoren  added the comment:

> From what I can tell, vfork probably also works on macOS (darwin).
> 
> Lets let this run for a bit on Linux and it can be a separate issue to 
> open vfork usage up to other platforms.

I'd prefer to not use vfork on macOS. For one I don't particularly trust that 
vfork would work reliably when using higher level APIs, but more importantly 
posix_spawn on macOS has some options that are hard to achieve otherwise and 
might be useful to expose in subprocess. An example of this is selecting the 
CPU architecture to use for the launched process when using fat binaries and a 
system that supports CPU emulation, such as the intel emulation on the upcoming 
Apple Silicon systems.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24165] Free list for single-digits ints

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I agree that it is not worth to add this optimization.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42096] zipfile.is_zipfile incorrectly identifying a gzipped file as a zip archive

[Irit Katriel]

Change by Irit Katriel :


--
nosy: +gregory.p.smith, vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41835] Speed up dict vectorcall creation using keywords

[Inada Naoki]

Inada Naoki  added the comment:

I confirmed _PyDict_FromItems() can be used to optimize _PyStack_AsDict() too.
See https://github.com/methane/cpython/pull/25

But I can not confirm significant performance gain from it too.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42130] AsyncIO's wait_for can hide cancellation in a rare race condition

[Chris Jerdonek]

Change by Chris Jerdonek :


--
nosy: +chris.jerdonek

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41835] Speed up dict vectorcall creation using keywords

[Inada Naoki]

Inada Naoki  added the comment:

@Marco Sulla

> @methane: well, to be honest, I don't see much difference between the two 
> pulls. The major difference is that you merged insertdict_init in 
> dict_merge_init.

Not only it but also some simplification which make 10% faster than GH-22346.

> But I kept insertdict_init separate on purpose, because this function can be 
> used in other future dedicated function on creation time only.

Where do you expect to use it? Would you implement some more optimization based 
on your PR to demonstrate your idea?

I confirmed that GH-22909 can be used to optimize BUILD_CONST_KEY_MAP 
(GH-22911). That's why I merged two functions.

> AssertionError: would build wheel with unsupported tag ('cp310', 'cp310', 
> 'linux_x86_64')

Try `pip install pyperformance==1.0.0`.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41835] Speed up dict vectorcall creation using keywords

[Inada Naoki]

Inada Naoki  added the comment:

@Mark.Shannon I had seen some speedup on tornado benchmark when I didn't use 
PGO+LTO. but it was noise.

Now I use PGO+LTO. master vs PR-22909:

$ ./python -m pyperf compare_to master-opt.json speedup_kw-opt.json -G 
--min-speed=1
Slower (11):
- spectral_norm: 147 ms +- 1 ms -> 153 ms +- 2 ms: 1.04x slower (+4%)
- pickle_dict: 28.6 us +- 0.1 us -> 29.5 us +- 0.6 us: 1.03x slower (+3%)
- regex_compile: 199 ms +- 1 ms -> 204 ms +- 4 ms: 1.03x slower (+3%)
- chameleon: 9.75 ms +- 0.10 ms -> 9.99 ms +- 0.09 ms: 1.02x slower (+2%)
- logging_format: 10.9 us +- 0.2 us -> 11.1 us +- 0.2 us: 1.02x slower (+2%)
- sqlite_synth: 3.29 us +- 0.05 us -> 3.36 us +- 0.05 us: 1.02x slower (+2%)
- regex_v8: 26.1 ms +- 0.1 ms -> 26.5 ms +- 0.3 ms: 1.02x slower (+2%)
- json_dumps: 14.6 ms +- 0.1 ms -> 14.8 ms +- 0.1 ms: 1.02x slower (+2%)
- logging_simple: 9.88 us +- 0.18 us -> 10.0 us +- 0.2 us: 1.02x slower (+2%)
- nqueens: 105 ms +- 1 ms -> 107 ms +- 2 ms: 1.01x slower (+1%)
- raytrace: 511 ms +- 5 ms -> 517 ms +- 6 ms: 1.01x slower (+1%)

Faster (10):
- regex_dna: 233 ms +- 1 ms -> 229 ms +- 1 ms: 1.02x faster (-2%)
- unpickle: 14.7 us +- 0.1 us -> 14.5 us +- 0.2 us: 1.02x faster (-1%)
- deltablue: 8.17 ms +- 0.29 ms -> 8.06 ms +- 0.17 ms: 1.01x faster (-1%)
- mako: 16.8 ms +- 0.2 ms -> 16.6 ms +- 0.1 ms: 1.01x faster (-1%)
- xml_etree_iterparse: 117 ms +- 1 ms -> 116 ms +- 1 ms: 1.01x faster (-1%)
- scimark_monte_carlo: 117 ms +- 2 ms -> 115 ms +- 1 ms: 1.01x faster (-1%)
- xml_etree_parse: 164 ms +- 3 ms -> 162 ms +- 1 ms: 1.01x faster (-1%)
- unpack_sequence: 62.7 ns +- 0.7 ns -> 62.0 ns +- 0.7 ns: 1.01x faster (-1%)
- regex_effbot: 3.43 ms +- 0.01 ms -> 3.39 ms +- 0.02 ms: 1.01x faster (-1%)
- scimark_fft: 405 ms +- 4 ms -> 401 ms +- 1 ms: 1.01x faster (-1%)

Benchmark hidden because not significant (39)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42140] asyncio.wait function creates futures set two times

[Denis S. Otkidach]

Change by Denis S. Otkidach :


--
nosy: +ods

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42140] asyncio.wait function creates futures set two times

[Diogo Dutra]

New submission from Diogo Dutra :

The python3.9 code creates the futures set two times.
We can create this set before, avoiding the second creation.

This python3.9 behaviour breaks the aiokafka library, because it gives an 
iterator to that function, so the second iteration become empty.

--
components: asyncio
messages: 379522
nosy: asvetlov, dutradda, yselivanov
priority: normal
pull_requests: 21858
severity: normal
status: open
title: asyncio.wait function creates futures set two times
type: enhancement
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24165] Free list for single-digits ints

[Inada Naoki]

Inada Naoki  added the comment:

I close this issue for now. Please reopen or create a new issue if you came up 
with better idea.

--
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com